Added UPC search option to numeric search.  Changed heading in preferences.

Fixed typo in footer.tt2.

Added footer and updated links.

Resized topnav bar.  Added KCPL Logos to the nav bar.

Added KCPL's image files.

Added nav files and links to topnav_links.

Changed CSS colors to KCPL theme.

Moved style.css to its correct directory.  Copied colors.tt2 and fonts.tt2 to kcpl directory.

Created directory structure for templates and copied over the css file.

Bumping version numbers and adding Changelog

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Forward port 2.9.5 to 2.9.6 upgrade script.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>

bump up upgrade instructions for 2.10.5

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

2.10.4-2.10.5 schema upgrade script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Docs: Adding 2.10 Release Notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1592891: Fix SIP2 standing penalty failures

Update too_many_overdue and excessive_fines in OpenILS::SIP::Patron
to account for the fact that the user object in this context no
longer contains an array of ausp objects, but just an array of ausp
IDs.

This fixes SIP2 failures with patron information messages when a
patron has one or more blocking penalties that are not otherwise
ignored.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1592891: tweak tests

This patch wraps the standing penalty checks in evals so that if they
crash, the test script can carry on -- and make it to the point where
it cleans up the standing penalties it adds.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1592891: Tests - SIP2 standing penalty failures

Tests for SIP2 standing penalty failures in LP#1592891

Much of the code in these tests was copied or adapted from Jason
Stephenson's tests in 14-lp1499123_csp_ignore_proximity.t

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1592565 Log successful authtoken and workstation

Recover a previously existing activity log entry that logged the
username, authtoken, and workstation (when available) for successful
logins.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jeff Godin <jgodin@tadl.org>

LP#1526858: Stamping upgrade script for faster alhr query

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/sql/Pg/002.schema.config.sql

LP#1526858: speed up queries for shelf-expired holds during checkin

This patch adds indexes on action.hold_request and tweaks
the definition of the alhr IDL view to more efficiently
identify holds that can be canceled if the "Clear Holds Shelf"
checkin modifier is in use.  This can prevent a problem
where such checkins can time out in very large databases.

The tweaks were created by Jason Etheridge and have been in
production at a large consortium for some time.

To test
-------
[1] With a suitably large database, set up an item that
    is on the holds shelf but has passed its shelf-expiration
    time, then check it in using the "Clear Holds Shelf" modifier.
[2] The checkin may fail with a "network failure" message due
    the query on the alhr timing out.
[3] Apply the patch and repeat step 1. This time, the checkin
    should succeed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Adds two missing link fields (patron profile and patron home library) to
the fm_idl.xml for the Combined Active and Aged Circulations (combcirc)
reporter source. The fix was originally posted in a comment to the
Launchpad bug by Codey Kolasinski.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1566016: remove SSN as a stock ident type

This patch removes the SSN (Social Security Number) as a stock
patron identification type, as it is no longer recommended
practice for libraries to store SSNs.

To test:

[1] Verify that in a fresh installation of Evergreen that
    has this patch in place, that SSN is no longer listed
    as a patron identification type.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1373578: fix translatability of hold placement errors

This patch fixes a circumstance where ->maketext() could be
passed an empty string, causing it to emit the PO file header text
rather than a desired string.

To test
-------
[1] Configure Evergreen to use a TPAC localization (e.g.,
    the Czech translation).
[2] Enable the "Has Local Copy Alert" library setting.
[3] In the OPAC, change locale and attempt to place a
    hold that would trigger the alert saying that there's
    already a local copy available.
[4] Note that the alert reads as "Project-Id-Version: evergreen
    Report-Msgid-Bugs-To: ..."
[5] Apply the patch.
[6] Try step 3; this time the alert will be translated correctly,
    e.g., "Ve vaší domovské knihovně je již dostupný exemplář."

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP 1548993: Remember the Show More/Fewer Details button selection.

The state of the Show More/Fewer Details button selection was
previously not remembered across searches or across changes to
advanced search.  This commit attempts to remedy that.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP 1548993: Restore Show More/Show Fewer Details button functionality.

When using a show_more_details.default setting of true in config.tt2,
the Show More/Show Fewer Details button functionality is broken.  The
detail record view is always shown, regardless of the button's state.
This patch attempts to repair the behavior so that the user can toggle
the detail record view even though the default is set to true.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

bump up upgrade instructions for 2.10.4

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

2.10.3-2.10.4 schema upgrade script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix typos in 2.10.4 release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Docs: Adding 2.10.4 Point Release Notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1584801: fix tagging of previous circs in metarecord search results

This patch fixes a bug where previously-checked-out items were not
indicated as such in search results when doing a metarecord search.

To test:

[1] Ensure that the opac.search.tag_circulated_items library setting
    is enabled and that you are testing with a user that has opted-in
    to retaining circ history.
[2] Make a couple loans to that user.
[3] Log into the public catalog using that user.
[4] Perform a catalog search, choosing search terms such that
    the previously-loaned items appear in results.
[5] Verify that "I have checked this item out before" is displayed
    on the relevant hits.
[6] Click the "Group Formats and Editions" checkbox; note that
    after the page refreshes, previously-borrowed hits are /not/
    tagged.
[7] Apply the patch and restart the open-ils.search service.
[8] Repeat step 6; verify that this time previously-borrowed hits
    are tagged.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP1567514 - Don't Output Null Byte for Spool Files

If a spool file is defined on the marc_stream_importer.pl
command line, no null byte is output after the record(s)
are processed.

To test:

[1] Use marc_stream_importer.pl to import a record from
    a file; verify that the output messages do not include
    a null character.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1517556 - Exclude inactive event defs from find_event_def_by_hook.

Currently when find_event_def_by_hook is called to find an appropriate
event_def based on the hook, it doesn't exclude inactive event defs.  So
strange behavior can happen if inactive event defs are present.

I ran into this issue when I was trying out different versions of the self
check receipt event def.  I had one ative and one inactive while I was
troubleshooting, and when the system would grab the inactive event def by
chance, the self check UI would freeze.  I think it is a resonable expectation
that an event def marked inactive doesn't get used by the system.

To test this out, clone one of the self check event defs, such as
"Self-Checkout Items Out Receipt" and mark the copy as inactive.  Now
go and trigger this event in the self check interface by attempting to
print from the Items Out screen.  It should now fail 50% of the time, since
both the active and inactive defs are returned.

After the fix the inactive event def will always be excluded, so the action
should no longer fail.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1580676: fix error message

This patch fixes a typo in the error message presented
if the queued record could not be cleaned up for some
reason; it also reports the correct type of the record.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1580676 MARC stream authority cleanup repair

Delete the successfully imported authority record from the vandelay
authority queue instead of the bib record that happens to have the same
ID as the imported authority record.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP 1499123: 0951.schema.config.standing_penalty.ignore_proximity.sql.

The script was not inserting the version into config.upgrade_log when
run standalone because the line to do so was still commented out.
This commit removes the comment characters.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Forward port 2.9.4 to 2.9.5 db upgrade script.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>

Docs: Adding 2.9.5 Release Notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP1497374 fm_IDL.xml metabib::record_attr_flat contains an incorrect link

Corrected the link in fm_IDL.xml. Also added a link to metabib::record_attr_flat
in biblio::record_entry

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1578716 Fix Responsive Items Out

With "Title" and "Author" as separate columns, here is a quick fix
to get the responsive labels to line up again.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <ben@evergreener.net>

release notes for 2.10.3

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

update upgrade instructions for 2.10.3

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

update upgrade instructions for 2.10.2

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

2.10.2 to 2.10.3 schema upgrade script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1579225: fix handling of passwords in patron registration

This patch improves how the new password hashing is invoked
by open-ils.actor.patron.update; in particular, it fixes
a problem whereby newly registered patrons could not
log in.  It also fixes other issues:

- actor.usr.passwd would be set to an MD5 of the password
  for new users, vitiating the strong hashes in actor.passwd
- certain types of updates via patron registration, such as
  adding or deleting addresses, could result in the patron's
  password getting doubly-hashed, thereby locking them out
  of their account.

To test
-------
[1] Register a new patron; verify that they can log in.
[2] Edit an existing patron and change their password; verify
    that they can log in.
[3] Edit an existing patron but do NOT change their password;
    verify that they can still log in.
[4] Inspect the actor.usr rows for these patrons and verify
    that actor.usr.passwd is set to the value MD5(''), not
    the MD5 of their password.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1579225: add live_t regression test

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Docs: Undo heading name change to fix broken link

This commit reverts a chapter heading change, which had broken an
internal cross reference link, thus causing the HTML docs to fail to
build. In this case, it seems best to keep the older heading rather than
fix the link to it.

In general, we should be careful about changing any AsciiDoc
headings, since we currently rely on autogenerated section IDs when
making internal links, and changing a heading changes its ID. If a
heading is changed, then all links to it need to be changed accordingly.

This commit also corrects a heading underline.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

LP#1031335 No-op the escape_email_header helper

As suggested by Mike Rylander, keep the escape_email_header helper
around to avoid breaking templates that already adopted it, but make it
a no-op as the SendEmail reactor now encodes the email headers of
interest by default.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Fix LP#1031335 by escaping some email headers automatically

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward port 2.9.3 to 2.9.4 db upgrade script.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>

Adding 2.8.7 -> 2.8.8 DB upgrade script

Signed-off-by: Bill Erickson <berickxx@gmail.com>

2.10.1 to 2.10.2 schema upgrade script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

updates to the 2.10.2 release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

Adding 2.10.2 point release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

update release notes for 2.9.4

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

Adding 2.9.4 release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

updates to 2.8.8 release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

Point release notes for the 2.8.8 release

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1562153: fix case where changing sort order to relevance can fail

This patch fixes a cause where sending a 'sort' CGI parameter
with the empty string as value (which specifies relevance sorting)
fails to override a previously-set sort order.

To test:

[1] Do a public catalog search starting from the advanced search form,
    e.g., keyword = "cats"
[2] Change the sort order to (say) Title A-Z from the results page.
[3] Note that the query string changes to "sort(titlesort) cats" and
    that the results are re-sorted
[4] Attempt to change the sort order to relevance.
[5] This time, the sort order does not change ... and it should have.
[6] Apply the patch and repeat steps 1-5. This time, the sort order
    should be successfully changed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1562153: add regression test

This patch adds a regression test for successfully
overrding the sort order in a query from a 'sort' CGI
parameter.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1563531: add libpcre3/libpcre3-dev deps for Jessie

This patch adds libpcre3 and libpcre3-dev to the list
of packages installed when installing Evergreen on Debian
Jessie. Evergreen's direct dependency on libpcre3 is new in 2.10
(see bug 1468422); it happens that libpcre3 and libpcre3-dev
are installed on Wheezy by virtue of a different dependency
chain.

To test
-------
[1] On a fresh Debian Jessie netinstall, follow the OpenSRF
    and Evergreen installation instructions. Verify that with
    this patch in place, Evergreen's "configure" step succeeds.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1568195: Stamping upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1568195: fix retrieving big OUS batches

This patch fixes a regression introduced in LP#1501471
where the Library Settings Editor could fail to retrieve
the values of org unit settings if more than 99 were
requested at a time.

To test
-------
[1] Open the XUL library settings editor and ensure that
    no search filters are in effect. Note that values
    are not displayed for any of the OU settings, and that
    the Pg log contains error messages like this:

    "ERROR: cannot pass more than 100 arguments to a function"

[2] Apply the patch.
[3] Repeat step one, and verify that values are now retrieved
    for all of the OU settings that have values set.
[4] Verify that the pgTAP tests in live_t/aous_batch.pg pass.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1569884: stamp schema update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1569884: fix schema update script

CREATE INDEX cannot run concurrently in a transaction
block period, at least as of 9.4.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1569884 Fix two problems in previous commit.

The CREATE TABLE biblio.monograph_part statement in
010.schema.biblio.sql ended up with a trailing comma.

The CREATE UNIQUE INDEX on biblio.monograph_part cannot be done
CONCURRENTLY at DB creation time, apparently.  At least not on
PostgreSQL 9.3.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1569884 Updated base schema with monograph parts index.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1569884 Allow deleted monograph parts to be recreated.

Changed the constraint on the biblio.monograph_part table to allow for a
monograph part to be created if a duplicate deleted version is found.

To test:

[1] Add a monograph part to a bib.
[2] Delete that monograph part.
[3] Attempt to add a monograph part to the same bib using
    the same part label. Without the patches installed, this
    will fail; upon applying the database update, this operation
    should succeed.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1569884: add regression test

This pgTAP test verifies that if you logically delete a monograph part,
you can subsequently add a new one with the same label as that of the
deleted one.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP 1562426: Renumber Perl live_t tests.

We had some overlap in numbers at the beginning of test file names.
The OCD in me think this should be straightened out.  This branch
renumbers the duplicates starting with 10-.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1564079 Stamping upgrade script

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1564079 Checkout history skips nonexistent items

Modify the user checkout history migration process
(2.9.3-2.10.0-upgrade-db.sql and 0960.schema.decouple_co_history.sql) to
avoid inserting history rows for circulations whose copies do not
exist in the database.

For reference, this is a rare condition that cannot be recreated in a
modern EG system short of modifying constraints.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1564079 Checkout history handles serials

Remove the target_copy foreign key constraint on action.usr_circ_history
so that it does not prevent creation of rows from circulation's that
link to serial.unit objects.  Similar to action.circulation, the foreign
key constraint is enforced via a evergreen.fake_fkey_tgr trigger
instead.

This modifies the 2.9.3-2.10.0-upgrade-db.sql and 0960 upgrade scripts,
since without this change, the scripts may fail.

A separate upgrade script is added to drop the constraint for those who
have already successfully run the the 2.9.3-2.10.0-upgrade-db.sql script
(i.e. those who don't use serials).  For simplicity, the
evergreen.fake_fkey_tgr trigger is only applied in this separate upgrade
script (in addition to the base schema, of course).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: image fix

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>

Docs: Paid PO Lineitems

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>

Docs: Funds disencumbered when invoice is closed

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>

LP#1559121: remove Debian Squeeze support

Now that Debian Squeeze's LTS (long-term support) period
has ended, Evergreen no longer offers community support
for that distribution. This patch removes references
to Squeeze from the installation scripts and documentation.

To test:

[1] Verify that Debian Squeeze is no longer referenced in
    the installation documentation.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
Conflicts:
docs/installation/server_upgrade.txt

Docs: clean up formatting & typos in using_the_public_access_catalog.txt

Thanks to Anna Goben for these fixes.

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: Screenshots and step by step instructions added to Self Check section

Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>

LP#1573372: Opt-in test broken because it uses bail-out.

Use skip instead!

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

Docs: New changes to new patron registration duplicate search.

Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>

LP#1573364: Use a timezone in the future backdate checkin test.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

Docs: Exclude Electronic Resources

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: Updated attributions.txt

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: resized image

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: Expanded information about item record view in OPAC

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: resized image

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: added tip on using hold counts in renewals

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: small syntax fix circulation/circulation_patron_records.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: small syntax fix in cataloging/authorities.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: small fix for circulation_patron_records_web_client.txt & root.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: small fix for lsa-barcode_completion.txt & root.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: update root.txt to include 2.10 release notes

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: typo fix in authentication_proxy.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>

LP#1564685 Prevent linked address edit on reload

Prevent editing of linked addresses when a user is loaded after the
clone operation.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1564685 Avoid referencing out-of-scope stat cats

Fixes a bug in the patron editor where out-of-scope stat cats would be
incorrectly bundled in the patron save operation, resulting in a
server-side error on save.  In short, ignore out-of-scope stat cat
entries for patrons in the editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1564685 Prevent edit of linked addresses

Do not allow a cloned user to modify a linked address.  Only the address
owner should be able to do that.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1564685 New Address button is always accessible

The New Address button in the patron editor is now always accessible,
regardless of the existence of any addresses.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1564685 Repair patron editor checkboxes sizing

Fix the checkbox HTML markup to prevent huge checkboxes in the patron
editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1564685 Required-field org settings overlay defaults

An org setting requiring a value for a field in the patron editor means
the field is required, even if it's not required by default.  IOW, fix
the code that was supposed to do that already.

Of note, county and state can now both be marked as required by org
settings in the patron editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1564685 Allow delete of all patron addresses

If the org setting ui.patron.registration.require_address is not true,
allow all addresses to be removed from a patron's account.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>