PINES already has 0977 applied, so comment it out.

Creating PINES pre-upgrade script.  Drop public.demographic view

LP#802700 Sort funds by code and year

This commit applies Bill Erickson's change from bug #1227344 to the fund
selector that appears on the Selection List (picklist) screen when you click
"Copies" to reveal the line items table. (Bill also mentioned this in
bug #1266471.)

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Addition of new item format icon for direct audio (ie, Playaways and
similar items that are pre-loaded with audiobooks and do not require
access to a computer to use).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1599634 - Remove DROP VIEW statement, add .sql to name.

When running the upgrade script, the DROP VIEW statement resulted in an
error since the view did not already exist.  You could add IF EXISTS, but
CREATE OR REPLACE VIEW is sufficient.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1599634 Circulation report source to include in-house(non cat), and non cat circ

Added a simple view and supporting IDL. This will allow all the circulation
data to output in the same report.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Conflicts:
Open-ILS/src/sql/Pg/090.schema.action.sql

LP#1610246 Classic Circulation View excluding circulations

The reporter.classic_current_circ view, which is available via
Open-ILS/src/sql/Pg/example.reporter-extension.sql, was excluding
circulations because it was assuming all users have a billing address
This branch corrects that with a LEFT JOIN.

No upgrade script will be included since these views are not assumed
to be installed by all Evergreen instances.  Please re-run the
example.reporter-extension.sql file to apply this change for your
instance.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Updates to KPAC Features (addition of TumbleBooks)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1528647 Self-check only accepts user name value if regex for barcode
not set up

The original fix only worked if password was not required for self-check.
This fix allows it to work when password is required as well.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1528647 Self-check only accepts user name value if regex
for barcode not set up

This fix allows a patron to log into the self-check interface with either
a barcode or a user name.

Written by: Bob Wicksall <bwicksall@pls-net.org>

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Revert "LP#1528647 Self-check only accepts user name value if regex"

Terran reports this not working as expected.

This reverts commit 0eb3a73c2fba4f609c0dab015a843a550e03516e.

LP#1528647 Self-check only accepts user name value if regex
for barcode not set up

This patch was written by Bob Wicksall and posted to launchpad. I've
tested on my own server and packaged it for review here.

The fix allows a patron to log into the self-check interface with either
a barcode or a user name.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

KPAC SRP 2016 tweaks to pre-set search categories

KPAC files to promote Summer Reading Program for 2016.

Removing testing piece.

Actually, that never needed to be in parens.

Testing for now, so no commit;

Forgot a closing parens.

I've redone all of the kpac category links so they no longer use
a link shortener. I also rearranged some of the links so that there
are more options on the home page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/examples/kpac.xml

KPAC - Hold results not displaying item title and throwing log error

I believe the path comparison operator in the 'load' subroutine has
a flaw in logic caused by a path-naming problem. The path-matching
function recognizes the kpac/getit_results path as matching positively
for both the load_getit subroutine and the load_getit_results subroutine.

This patch reverses the order in which the matching occurs in an attempt
to resolve the conflict.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Fix for org unit order in OPAC holdings list (adapted from
http://git.evergreen-ils.org/?p=evergreen/pines.git;a=commit;h=adc566e152d10796b73c992a16ae46e69cc3ab77)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Adding PG 9.4 installation targets

Second piece to the bug fix for group holds...

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

adding a/t environment to new event def

More changes to post-upgrade data file.

LP#1463166 Removed multiple perms

The use of multiple perms in creating the widget was causing problems.
I changed the permlist back to a single perm.

Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop>

LP#1463166 Fix Batch update of Funds in Selection Lists

Selection lists are currently unable to batch update funds.  The problem
stems from the fact that the Fund selection list is not populated in the
copy rows.  New code used to limit the number of funds, in the dropdown
list, to those funds available to the user was added for purchase
orders.  However, these changes were not added to Selection Lists.  This
code adds the new call to initBatchUpdater to the selection list code.

Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop>

Temporary modifications to My Account > Holds History until more
permanent fixes are developed.

Hid paging because it is broken. See:
https://bugs.launchpad.net/evergreen/+bug/1422927

Showing "Canceled" instead of "Active" for canceled holds. See:
https://bugs.launchpad.net/evergreen/+bug/1275118

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Adding customization to disable the "Clear Holds Shelf" function.

adding login redirection page

Adding post-upgrade datawork script

Adding PINES-ified notification wordings.

These changes undo a couple of small things I tried to tweak on the web
client that didn't work the way I hoped they would.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Changes to splash screen and receipt template defaults for web client.

(Note: Could not test on terran-testbox since it is not https-enabled,
so I could not log in to the web client.)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Self-Check changes in preparation for upgrade:
Changed wording on some of the on-screen directions.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

OPAC changes in preparation for upgrade:

1. Added instructions to circ history page in My Account for turning
on your circulation history.

2. Modified behavior or NoveList tab on item details page so that it
is closed by default in the staff client, and it will close when a
different tab is opened to reduce page scrolling.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

KPAC changes in preparation for upgrade:

1. Biggest change was to move the library selector box to the main
search panel instead of on the side - had to modify quite a few files
in order to make this work and pass the values correctly.

2. Also changed the feature icons to use links instead of search terms
to allow more control over search limits and sorting and to see if
caching the searches would improve response speed.

3. A number of smaller UI changes.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Selfcheck Cookie Path

Change base.xul/base.js to support a "cookie path" option to limit what paths
will use the login cookie, then tell the selfcheck interface to use it.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Additional changes to the self-check interface.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Images for new "no image available" functionality.

Lines 94-104 in eg_vhost.conf need to be un-commented.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Fixes to OPAC holds & patron self-registration pages

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

These are modifications to the Evergreen self-check interface to:

1. Fix bugs with printing holds and fines.
2. Improve page layout overall, and with consideration for
   1024x768 resolution monitors that a lot of libraries use.
3. Hide hold status from view on holds table.
4. Hide buttons/fields from screen when user is not logged in.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/circ/selfcheck/banner.tt2

Further adjustments to staff client splash page so it will fit onto
older 1024x768 resolution monitors better.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Modifications to patron self-registration form to make it
display better and change library locator link.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/opac/register.tt2

Miscellaneous OPAC UI tweaks for spacing / layout.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/opac/parts/org_selector.tt2
Open-ILS/src/templates/opac/parts/record/copy_table.tt2
Open-ILS/src/templates/opac/parts/searchbar.tt2

Numerous local customizations to My Account pages for layout and
to add on-screen assistance to patrons.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/opac/myopac/circs.tt2
Open-ILS/src/templates/opac/myopac/holds.tt2
Open-ILS/src/templates/opac/myopac/prefs.tt2
Open-ILS/src/templates/opac/myopac/prefs_settings.tt2

Staff Client tweaks to splash page:
- Added link to PINES Documentation
- Changed logo at top to PINES logo
- Adjusted spacing
- Updated copyright date

Also, hid footer on OPAC pages while viewing from
within the staff client because it clutters the page
without adding any value.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/web/opac/locale/en-US/lang.dtd
Open-ILS/xul/staff_client/server/index.xhtml

Improved list display in OPAC (title, description, annotations).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Removed added content from the KPAC for now since it doesn't
display properly. Possibly add back in later if we can get
the NoveList content to pull in right.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Improvements to KPAC list display, especially adding
display of list annotations that were not shown.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/kpac/parts/record_row.tt2
Open-ILS/src/templates/kpac/results.tt2

Updated kpac.xml configuration file to be ready to roll out after upgrade.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/examples/kpac.xml

Adding corrected wording for self-registration agreement.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Customizations to patron self-registration form and footer link.

Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2
Open-ILS/src/templates/opac/register.tt2

PINES has already applied 0940

correcting typo causing Chilifresh to continue to display

Correcting a typo that caused the copy_table.tt2 template to break

Enable Halloween holiday feature in KPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/examples/kpac.xml

Conflicts:
Open-ILS/examples/kpac.xml

Change links old library map to new interactive library locator map.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Updated link to old library map to new library locator map in KPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Added PINES Quick Reports icon and link to Evergreen Staff Client
main page. The link will open in a browser window.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Enabled Google Analytics for OPAC usage tracking.

Adds B4 Book Log icon to KPAC search results page and
KPAC item details page.

(This is a PINES-only customization.)

Adds B4 Book Log icon and link to KPAC search results page and
KPAC item details page.

(This is a PINES-only customization.)

Conflicts:
Open-ILS/src/templates/kpac/parts/record_row.tt2
Open-ILS/src/templates/kpac/record.tt2

Adding GALILEO in-library link logic to topnav links.

PINES/GALILEO avoid auth redirect within library

If the physical_loc is set, indicating the patron is physically at a
branch (via IP redirect), link directly to the GALILEO site with no
authentication pass-through.  GALILEO does not requires PINES auth
if the client is coming from a known IP address.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2

LP#1446860 - Correct mistaken logic in previous fix.

See https://bugs.launchpad.net/evergreen/+bug/1446860/comments/2
for reference.  The logic was not enforcing the "if the editing
staff member doesn't have permission to edit a user in this
permission group" check.  This corrects that.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1446860 Staff were able to edit their own accounts.

This change reverses what appears to be a thinko in the
original programming.  If the editing user is the same
as the user being edited, disable the Save button.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Conflicts:
Open-ILS/web/js/ui/default/actor/user/register.js

branding the built-in selfcheck interface for PINES

Sadly, GALILEO/EBSCO does not use HTTPS, so this will create errors for patrons who authenticate via PINES.  Reverting to HTTP.

Make users_of_interest test for defined actor.usr.card values

If the open-ils.collections.users_of_interest API encounters a patron that
has a null "card" value in actor.usr the API will crash with an error like:

Received Exception:
Name: osrfMethodException
Status:  *** Call to [open-ils.collections.users_of_interest.retrieve] failed for session [1416515351.333446.1416515351406], thread trace [1]:
Can't call method "barcode" on an undefined value at /usr/local/share/perl/5.14.2/OpenILS/Application/Collections.pm line 299.

This patches users_of_interest to be sure that the user has a defined value
for actor.usr.card before proceeding to pull out the barcode for the results
of the API call.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Collections.pm

Header and Footer display changes to improve the way they display
on mobile devices and smaller-width windows.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

restoring commented out checkbox to allow multiple hold requests on the same title

Tweaks to layout of holdings on item details page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/opac/parts/record/copy_table.tt2

Made table cells in holdings white to temporarily solve CSS display
issue in staff client.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/opac/parts/record/copy_table.tt2

Revert "LP#1406387 Fix for Holds Placement Advanced Options"

Not working for us yet, so reverting.

This reverts commit 2322ee5ae9cbe3caefb6998d62c3716cf40411a3.

Conflicts:
Open-ILS/src/templates/opac/parts/place_hold.tt2

LP#1406387 Fix for Holds Placement Advanced Options

In the staff client, when placing a hold and clicking
Advanced Hold Options, the barcode input will populate
with the staff member's barcode if it was previously
empty, regardless of whether the radio input for the
hold was specified for a patron or the staff member.

This patch corrects that behavior, and also populates
the input radio on load after clicking Advanced Hold
Options.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Conflicts:
Open-ILS/src/templates/opac/parts/place_hold.tt2

Corrected KPAC hold notification code to allow for text messaging preferences.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Revert "Revert "Update ContentCafe Added Content Module""

This reverts commit bd7b7ee5b0b323967cb8fcb22c20c5a405e650bf.

Revert "Update ContentCafe Added Content Module"

Experimenting with reverting this commit, which appears to
break Syndetics (and we don't use ContentCafe).

This reverts commit 164c7e7bc4e542af9ada4ea2716cbce784820e6d.

Fix to Advanced Search 'Clear Form' button not clearing
previously selected library.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Revert label change on item detail page from 'Related electronic
resources' to 'Electronic resources.'

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Capitalized 'Closed' on library pages.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

KPAC 2.7 Upgrade Tweaks

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:

Open-ILS/examples/kpac.xml

Fix to grouped search result set navigation bar display issue in OPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/opac/results.tt2

removing reference to dates with slashes / in the example text

Disallow patron self-registration form to accept slashes in dob

(further modification to https://bugs.launchpad.net/evergreen/+bug/1361266)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Tweaks to OPAC UI - account login page, my account holds page, text call number page

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

replacing copy_table.tt2 with the correct version

Conflicts:
Open-ILS/src/templates/kpac/parts/copy_table.tt2

Fix for KPAC holdings display issue.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Fix for too-large header sizes causing display issues in KPAC

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Preparing kpac.xml for upgrade

bringing in current kpac.xml

Conflicts:
Open-ILS/examples/kpac.xml

Starting the upgraded version with MLK Day

Conflicts:
Open-ILS/examples/kpac.xml

Modified KPAC login code to redirect to KPAC after logging in

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:

Open-ILS/src/templates/kpac/parts/header.tt2

Fix for KPAC multi-format items

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:

Open-ILS/src/templates/kpac/record.tt2
Open-ILS/web/css/skin/default/kpac/style.css

Tweak to make library selector box wider in OPAC only.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

KPAC Login Redirect Fix

Fixes the redirect from the KPAC login to return back to the
home page of the KPAC from the /opac/login screen, rather
than back to the /opac/home screen, which is the current
behavior, and confuses users of the KPAC when they end
up back in the OPAC after having logged in.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>

Correcting typo that breaks this template.

Conflicts:
Open-ILS/src/templates/opac/parts/record/summary.tt2

LP#1361266 Patron self-registration form accepts date of birth in wrong format

This patch applys some basic javascript to validate that a date entered is
at least in ISO 8601 format.  This prevents someone from entering "cupcake"
or 55/66/6666 as a valid date of birth by validating the stgu.dob input
at the time of submission.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>

Change to allow KPAC to display more than one format icon (like OPAC).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>