LP1904036 lint

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 add billings

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 add billings and more

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 events and overrides

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Alert dialog honors dialogTitle when present

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 events and overrides

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Renew with due date

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Renew all; initial events override dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Renew; Batch Checkout/Renew; shared circ components

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Claims never checked out

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Claims returned

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Claims returned; circ notices

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron alerts page continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron alerts page; resolver service

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Move precat dialog to shared circ service

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron noncat count display

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Mark items lost

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Mark missing; initial checkin api

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Mark damaged; canceled holds display repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Edit due date; styling overdues

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron items out: printing

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron items out grid; shared circ grid; noncats

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Noncat batch retrieval API

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron items out grid; shared circ grid

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Angular login now handles routeTo

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Barcode completion continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Barcode completion dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 checkout continued; grid actions

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 precat checkouts

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 precat dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Prompt dialog focus input followup

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Prompt dialog focus input; submit on enter

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron ui checkout tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron ui checkout tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron ui checkout tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron ui checkout tab; noncats

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Prompt dialog gets input type and min/max

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron UI lint repairs; sanity checks

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron UI; search persistence

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron UI; canceled holds

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 patron Ui holds tabs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 patron UI noncat/holds summary

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 patron expire check

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Angular Patron UI initial structures

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Grid rowSelectionChange Output

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron search form improvements

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron sesarch form improvements

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1928258: Correct Upgrade Script

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#1924562 - pingest.pl help typo for --max-duration

In the help command example the argument --duration is used but
--max-duration is the correct command.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP1911023 Batch hold cancel refreshes before completion

Ensure all hold cancelation promises complete before reporting the
results back to the caller.  Issue was result of thinko in the code
that failed to relay one of the promises in the chain, so it reported
promise completion prematurely.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

Lp 1899974: Export PERL5LIB in oils_ctl.sh

A change in Perl release 5.26.0 necessitates that the SIP_DIR variable
(default value "/opt/SIPServer") be exported to the environment in
oils_ctl.sh when attempting to start SIPServer.  This change affects
Ubuntu 18.04 (Bionic Beaver) and Debian 10 (Buster) and any future
releases.

To verify the bug:

1. Install OpenSRF, Evergreen, and SIPServer on an affected O/S.
2. Start OpenSRF service.
3. Start SIPServer via oils_ctl.sh:
   oils_ctl.sh -a start_sip
4. Notice the "Starting OILS SIP Server" message is printed with no
   indication of failure.
5. Verify that the PID file exists: /openils/var/run/oils_sip.pid
6. Verify that no SIPServer processes are actually running:
   pgrep -af SIPServer
   The above should produce no output.

To test this patch:

1. Apply this patch and install oils_ctl.sh to /openils/bin/.
2. Assuming you have run the previous steps, delete the PID file:
   rm /openils/var/run/oils_sip.pid
3. Start SIPServer via oils_ctl.sh:
   oils_ctl.sh -a start_sip
4. Notice the "Starting OILS SIP Server" message is printed.
5. Verify that the PID file exists: /openils/var/run/oils_sip.pid
6. `pgrep -af SIPServer` should produce output.

It is safe to apply this patch on an unaffected O/S.  Explicitly
adding SIP_DIR to PERL5LIB will have no detrimental effect on any O/S
currently supported by Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#1928275: fix the Angular "Copy Queue To Bucket"

Similar to bug 1934184, a blank routerLink on an anchor no longer
causes an ngbModal to open via a click handler.

To test
-------
[1] Create a MARC import bib queue that has at least one imported
    record it.
[2] Click the "Copy Queue To Bucket" link from the queue inspection page
    and observe that nothing happens.
[3] Apply the patch and repeat step 2. This time, the add-to-bucket dialog
    should appear.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP1924621 Place Hold For shows pref name

In the staff catalog banner which displays when a hold is being placed
for a pre-selected patron.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP1924621 Staff catalog place hold screen preferred name

Displays the preferred first or last name on the place holds screen,
if a patron barcode is entered.

To test.
1. Set up a borrower with a preferred first name, and one with a
preferred last name, and one with both.
2. Use the catalog place hold screen to search for these borrowers
and notice that the preferred names, if available, are displayed.

* note newline added by Bill to break up wide column.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

Revert "Docs: added receipt contents references."

This reverts commit 649d81b06ecee12324d3a4c604ea20451c3fea85.

LP#1672346: add release notes

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1672346 - Copy Statistics View

Certain third-party products such as collection development
management providers require copy statistics that are not
readily available in a single report.  This view adds those,
which will also benefit library staff reports generally.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>

Docs: added receipt contents references.

Signed-off-by: Lynn Floyd <lfloyd1@library.in.gov>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1864516: stamp DB upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1864516: add release notes

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1864516: case-insensitive browse entry display value comparison

Following up on bug 1350831, there remains one complaint relating to
"bad data makes browse suboptimal" that can't actually be handled today
by the existing Evergreen code or a pullrequested branch: case differences,
particularly in titles.

We should allow an Evergreen admin to decide on a field-by-field basis
whether case should be considered when determining the uniqueness of a
browse entry coming from a bibliographic record, effectively allowing case
folding. Note that authority fields, being by definition the authorized
value that should be used, do not support this case folding. However, if
authority records are processed first, then bibliographic fields can fold
/into/ those authority fields, achieving the desired result and, in fact,
using the best possible case-preserving display value.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1759382: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1759382: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1759382 Setting: staff placed holds default to workstation

New org unit setting to always default the pickup location to
the workstation when placing holds as staff, regardless of the
patron's preferred pickup location.

The setting applies to staff placed holds in the Angular and
traditional catalogs.

Priority for determining the default pickup location when
placing holds as staff:

1. workstation if circ.staff_placed_holds_default_to_ws_ou
2. user preferred location if opac.default_pickup_location
3. workstation if circ.staff_placed_holds_fallback_to_ws_ou
4. user home org unit

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1925028: Make Hold/Copy Ratio Reports Consistent, Add a By Home Library Version

Use ahcm for all hold/copy ratio reporting sources so the counts are more
consistent, ignore metarecord hold copies (by default) and the copies from
frozen or captured holds.

Also a Hold/Copy Ratio per Bib and Home Library source is added.

Sponsored-by: Westchester Library System
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1921057: fix release notes typo

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1921057: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1921057 - add release notes

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1921057 - Expand reporter.demographic to include detailed age breakdown

Add "age_division" column to reporter.demographic.  Expose the new
column to the reporter as "Detailed Age Division" resulting in the following
options:

Child 0-5 Years Old
Child 6-12 Years Old
Teen 13-17 Years Old
Adult 18-25 Years Old
Adult 50-59 Years Old
Adult 50-59 Years Old
Adult 60-69 Years Old
Adult 70+

If no DOB is present, say so.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1940962: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1940962: Improve stock carousel display

Allow carousels to take up 80% of the home page width and raise
the default size to 5 titles so it doesn't look silly.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1207533: (follow-up) fix ng lint warnings

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1928258: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1928258 Vandelay separate bib edit update option

Adds a new field "Update Bib Edit Date" to Vandelay merge profiles which
allows users to update the edit date and editor information on a
merged/overlaid bib record without also having to modify the bib source.

For backwards compatibility, any existing merge profiles that have
"Update Bib Source" applied will also get "Update Bib Edit Date" applied.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1941764 Import from queue propagate form inputs

When importing records from an existing Vandelay queue, ensure the
selected queue, its match set, its match bucket, and its holdings import
profile are propagated into the import form.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1920253: Stamp Upgrade Script

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP1920253 Add missing carousel workstation setting types

Adds ws setting types for the following pages:

Carousels Visible at Library Configuration (eg.grid.admin.local.container.carousel_org_unit)
Carousels Configuration (eg.grid.admin.container.carousel)
Carousel Types Configuration (eg.grid.admin.server.config.carousel_type)

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP1905028: Make live tests chill out

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#1207533: (follow-up) fix typo from merge conflict resolution

Fixes database schema creation.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1207533: Stamp upgrade scripts, minor typo correction

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1207533: item-oriented Triggered Event Log

Building on the previous commit from Jason Etheridge, this adds an
Angular reimplementation of the item-oriented TEL variant.  In addition,
it separates the grid settings persist key and creates the YAOUSen
needed to save those grid settings.

Because these interfaces make use of the flattener service to drive grid
construction and data retrieval, staff will have to have the appropriate
VIEW_USER permission to be able to see patron related data in the
item-oriented grid.

Funding for these interfaces comes from PaILS, for the patron-oriented
interface, and from ECDI, for the item-oriented one.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1207533 patron triggered events log

* first cut at schema
* setting context_user, context_library, and context_bib on action_trigger.event
  when building the environment
* toward UI
  The original interface still exists and is used when spawned from Item Status,
  but for the patron interface, the Other -> Triggered Events / Notifications
  action will now spawn a new tab with the new interface.
* data retention
  Break the link between actor.usr and action_trigger.event when purging user data
  or aging circulations (as best as we can; some textual links may exist in
  action_trigger.event_output--i.e. overdue notices)
* release notes
* live tests

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1642000 - Add Prefix,Suffix and Part to bootsrap opac circ history

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1642000 - Add Call number prefix, suffix and part to opac circ history

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1642000 - Bootstrap Opac - Add CN Prefix, Suffix and Parts to opac checked out item display

Add Call Number Prefix, Call Number Suffix and Part to the call number column of
checked out items display.  Also sort based on the label_sortkey value of those fields.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1642000 - Add CN Prefix, Suffix and Parts to opac checked out item display

Add Call Number Prefix, Call Number Suffix and Part to the call number column of
checked out items display.  Also sort based on the label_sortkey value of those fields.

Testing Notes:

Check out an asortment of copies to your patron account.  Pick a mix of items with
Call number prefix and suffix, and some with parts.

View the list of checked out items in the myopac interface.

Notices that no call number suffix or prefix are showing, and no parts info is showing.

Apply the patch and see that the extra info is showing.  Also try sorting on call number column.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1844121: prevent staff login by expired barcode

open-ils.auth.authenticate.init accepts an identifier as its
sole parameter, then determines whether it looks like a
username or barcode and retrieves the patron's password
salt as the seed accordingly.

open-ils.auth.authenticate.complete can accept the identifier
via the 'identifier', 'username', or 'barcode' keys, but the
key used does not need to match how .init found the patron.

As a consequence, the .init/.complete dance can retrieve the
patron by barcode but handle the barcode value as if it were
a username, thereby bypassing the check of whether the barcode
was inactive. In particular, the AngularJS staff client login
process does this, meaning that staff members can log in to the
staff client via the AngularJS form using an expired barcode.

This is not good. The OPAC explicitly blocks logging in using an
inactive barcode because it checks the identifier type and sets
the key passed to .complete accordingly. The Angular staff login
page also prevents logging in using an inactive barcode because
(a) it uses open-ils.auth.login, which doesn't have the same
problem and (b) it forces the identifier to be marked as a user
name regardless.

NOTE: this means that the Angular staff login form prevents staff
from logging in via barcode, which potentially is a regression as
compared to the AngularJS side (or, alternatively, is providing
additional necessary strictness).

This patch avoids the problem by having .complete inspect the
cached seed created by .init to determine how the user was ultimately
found.

Some alternative approaches that were rejected include:

[1] Having AngularJS just mirror Angular. Problem: if some staff
    users are used to using their barcode to log in, doing
    this would cause an immediate problem. I note that because
    the staff interface URL is commonly expressed as
    https://library.example/eg/staff, is currently far more common
    for the staff interface to be logged into via the AngularJS
    form rather than the Angular one.
[2] Having AngularJS use open-ils.auth.login, but make it and
    Angular use 'identifier' as the key rather than 'username'.
    Problem: while this would have the desired effect if you
    only use native authentication, if you're using open-ils.auth_proxy,
    it won't work - open-ils.auth_proxy.login doesn't recognize an
    'identifier' parameter. While that could be changed, it
    is more invasive.

To test
-------
[1] Set up a staff user that has a username, an active barcode,
    and an inactive barcode.
[2] Log in to the AngularJS staff interface (/eg/staff) using
    the username, the active barcode, and the inactive one.
[3] Note that you are permitted to log in with all three identifiers.
[4] Apply the patch and repeat step 2.
[5] This time, logging in using the inactive barcode should
    fail.
[6] Verify that other login types continue to work as expected:
    - Angular staff login form
    - OPAC
    - SIP2 terminal login
    - SIP2 user authentication
    - operator change (Angular and AngularJS)
    - Web-based self-check
[7] Extra credit: test logging in via open-ils.auth_proxy with
    it falling back to native authentication.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1904754 Former precat still displays precat info

This fixes a display issue where the precat title and author
were still displaying once the record was no longer a precat,
which effectively duplicated the title and author.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904593 Remove errant color[sic].log() call

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1903357 Angstcat Hold Activate Date Validation

Prevent setting activation dates in the past when placing holds in the
Angular Staff Catalog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Josh Stompro <stompro@stompro.org>

LP#1737019: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1737019: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1737019: (follow-up) more tweaks

- When creating a new funding source, default the active flag
  in the modal to checked
- Disable actions to allocate from a funding source or
  apply credits to it if it is not active

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1737019: (follow-up) fix issue in schema update

Looks like 'SET DEFAULT ...' and 'SET NOT NULL' cannot be
combined in a single ALTER TABLE statement.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1737019 Add an active flag to funding sources

This adds an active flag to funding sources. It also adds limits the
available funding sources in the Create Allocation dropdown to only
active funding sources.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Lindsay Stratton <lstratton@wlsmail.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1929242: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1929242: edit release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1929242: (follow-up) additional tweaks

- remove console message upon deleting note
- flesh the creator and editor columns
- make notes grid filterable

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1929242: (follow-up) add grid config WS setting

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1929242: add missing comma

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>