add a bit of separation

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

hide the provider info tabset if there's no selected provider

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

after selecting a provider from the search form, update the route

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

move provider search form

The provider search form is now outside of the tabset and its
visibility is controlled by a button. Also, clicking on a row
on the search results will now hide the search form.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

hide provider column by default in contact and address grids...

... but if the user insists on displaying that column, redundantly,
flesh it so that the code is displayed

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Mark required fields on the provider-contact object

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

provider purchase orders component

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add provider invoices component

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

provider record service: add currentProviderId

This works around some race conditions fetching the current
provider upon initialization; we should fix this so that
current() can account for in-flight initialization or
refreshes.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update provider contacts component to reflect updates in provider record service

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

contacts modal

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

default to valid == true when creating new provider addresses

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

mark required fields as required in IDL for provider addresses

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update provider address component to reflect updates to provider record service

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

provider record service updates

- fetch() now returns a promise
- added refreshCurrent();
- added batchUpdate()

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

provider address modal

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

refresh record service upon ID change

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add contact and address components to their tabs

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

hook up contact and provider components to record service

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

actually push out initial version of provider record service

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

address and contact stubs

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

set active provider ID when a row is selected

Note - not changing the route for now

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

initial stab at provider record service

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add summary pane component to module and a missing decorator

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

toward summary pane

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

make ng lint happier

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Require classes for search; be very verbose for typescript

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

WIP: complex, cross-table searches

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

more work on hooking up search service and search form

TODO:
- contact name searching
- get the org-family-selector to show the starting value
  of the WS OU
- refactor how form parameters are managed?

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

fix thinko

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

WIP: provider search/result stub and required IDL change

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

start work on AcqProviderSearch

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

acq providers: allow search form and details view to share a tab

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add provider search placeholder menu entry to eg2

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

ang providers: create base modules and components

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

org-select: allow applyOrg[Id] to clear the org unit

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

eg-grid: fix disabling filter controls when data is being fetched

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

clean up router event subscription

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

acq search: ensure that results grid is cleared in certain cases

Namely, when navigating to the same search tab when retrieve
immediately is not in force, e.g., when going from 'My Selection Lists'
to 'Selection List Search'

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

acq search: implement hard-coded fallback searches

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

adjust nav menus to add explicit

* Selection List Search
* Purchase Order Search
* renamed On Order at Workstation
* Invoice Search

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

eg-grid: disable filter controls while fetching data

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

ensure that following a menu link to the acq search form will always refresh the search

... assuming it has query parameters; may need to do more later.

TODO: make sure that setting onSameUrlNavigation to 'reload' for
the entire Angular app doesn't have unexpected consequences

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

eg-combobox: handle cases where selectedId gets cleared

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

eg-combobox: teach it to accommodate idlClass changes

This can happen in dynamically constructed search forms such
as the acquisitions search form.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

eg-combobox: add per-IDL-class formatting

This patch teaches eg-combobox to apply display templates
and label formatters for when idlClass is set. Currently templates
are defined for acqf and acpl.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add cellTextGenerators where needed

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

acq search: allow searching on an explicit null value

This adjusts the special logic introduced in LP#1031535 so
that explicitly searching with a field set to not null (e.g.,
when using the Angular grid 'exists' filter) will work.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

eg-grid: ensure that ignoreFields does not need to be set

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Flesh PO and SL, and display their names rather than IDs because sorting is by name

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

suppress marc field in lineitem grid

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

eg-grid: Add ignoreFields support to suppress selected IDL-generated grid fields

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add 50px of bottom margin the Angular interface across the board

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

emit toast upon saving a default search

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

tweaks to PO results grid

Primary change is making prepayment_required not be sortable,
as it's a Boolean and Pg doesn't default a min(bool) aggregate.

Along the way:

- explicitly list all columns that should display be default
- unhide some columns that were hidden by default for some reason
  in a previous patch

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

acq search: improvements to server-side sorting

- create joins for aou, acqim, and acqipm as needed
- look up identity column for a class rather than assuming
  that it's always 'id'

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Sort by remote selector column when sort-on-link is requested and selector exists

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

hide inapplicable operators for the search form rather than disable them

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

allow __gte and __lte searches for ACQLIA that include 'date' in their code

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add support for __gte, __gt, __lte, and _lt for acqlia searches (perl)

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

eg-combobox: set a limit on number of entries fetched for idlClass

The automatically-created data source for eg-combobox when used
in idlClass will now limit itself to 100 entries in order to avoid
scenarios where it attempts to fetch all patrons in the database
or the like.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add permissions checks for retrieving POs and invoices via unified_search

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

relabel PO and LI state column to "Status"

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

improve how picklist operation failures are displayed to user

- don't show the success toast unless the operation has actually
  succeeded
- give user a hint if creation failed because of a duplicate name

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

tweak style of form buttons

Makes the 'Set As Default XXX Search' button respond better
to smaller viewports.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add state label views to seed data

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

fix grid initialization bug

If an IDL link field has an explicit eg-grid-column definition,
ensure that the datatype is set correctly.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Dynamic dropdown rather than bespoke

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Teach some grids to allow click-to-dropdown for some fields in acq search

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Create and link DB views for PO and LI state, allowing for dynamic loading and I18N (eventually)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Add passthrough capabilities for click-to-dropdown on linked fields

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

clarify open-ils.acq.picklist.clone

Method is now clear that _nothing_ of the acq.picklist row
itself gets copied over.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

fix comparison of IDs when prepping args for picklist merge

The API expects the lead to _not_ be on the list of IDs of
lists to merge into the lead.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

enable results grid sorting

TODO: deal with sorting provider, user, and OU columns by the
      relevant code or username

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

ensure that json_query will produce useful SQL when sorting by an LIA

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

remove retrieve results immediately checkbox

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

implement > and < in acq search grid filters

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add _gt/_lt operators to unified search method

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

flesh user fields on search results grids

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add flesh_{creator,editor,selector} options to LI retrieval

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

display provider code instead of name on LI results grid

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

increase margin below search form

Closes LH#8

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

WIP - add more permissions to stock Acquisitions and Acq Admin profiles

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Angular Acquistions Search

Angular app + linking AngularJS navigation elements to it

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Seed data for Angular acquisitions search

* grid persistance WS settings
* retrieve-results-immediately stick checkbox settings
* default saved searches settings

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

eg-interval-input: Angular component for inputting time intervals

Usage:

   <eg-interval-input [(ngModel)]="interval">
   </eg-interval-input>

This provides a simple combination of a numeric input and a
drop-down for time interval units.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

eg-grid: indicate error condition to user if data source throws one

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

grid: use bolder styling for the 'Nothing to Display' message

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

combobox: teach it how to start with a selected value when IDL-based

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

new Angular file-reader component

This adds a ControlValueAccessor wrapper around a file
reader form input. Any file loaded via that input is interpreted
as a text file whose lines are to be split into an array on
newlines, with leading and trailng whitespace removed.

Usage is:

<eg-file-reader [(ngModel)]="fileContents">
</eg-file-reader>

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Angular Acq Search: Perl API changes

* Add __age (interval), __starts, and __ends operators.

Update __between to support __castdate modifier, for a more natural
comparison of dates entered by humans to timestamps stored in the
database.

* teach open-ils.acq.lineitem.retrieve more fleshing

In particular, teach it how to flesh the LI provider,
Vandelay queue, and claim policy so that Angular LI search
can display them without having to make additional server
requests.

* Add additonal fleshing for purchase order, selection lists,
  and invoice searches.

* Add au_by_id option

This specifies performing queries on au-linked fields by
ID rather than adding joins to query the fields by user
barcode or username, etc.

* Implement "contains" operator for provider searches.

This is similar to how user searches are handled.

This patch contains work by Mike Rylander, Galen Charlton, and Jason
Etheridge.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Give searchFieldTransformPredicate a special case to handle transformation of fields used in BETWEEN operations

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1775276: Check In - "Route To" Field Sometimes Incorrect

When open-ils.circ.checkin closes a transit and creates a new one, the
payload only returns the closed transit. The route dialogs perform a
pcrud search to get the most recent transit, but the grid's Route To
field still depends on the transit returned by the API, so received
transits display the old destination in the Route To field instead of
the shelving location or new destination.

This branch returns the most recent route info collected by the route
dialog and, if the most recent transit destination doesn't match the
old one, the new one is assigned to the route_to prop on the
final_resp. It also checks that the transit is open before displaying
the destination in the Route To field so the shelving location
displays if the most recent transit is closed.

To test:
1. Sign in as Library A and check in an item owned by Library B
2. Place a copy hold on the item with a pickup location of Library C
3. Sign in as Library B and check in the item - note the dialog is
   correct but the grid's Route To field displays Library B instead of
   Library C
4. Apply patch
5. Repeat steps 1-3, note the Route To field displays Library C

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

Forward port 3.3.5 to 3.3.6 db upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>

Forward Port 3.4.1 to 3.4.2 upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>

Docs: release notes for 3.4.2

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: release notes for 3.3.6

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1801163: (follow-up) deal with header fields that contain Unicode strings

Since Email::MIME->header_str_set() expects Unicode strings, not octets,
use decode_utf8() on the header values to

To test
-------
[1] Update the biblio.format.record_entry.print A/T event definition
    to include non-ASCII characters in the subject and from headers.
[2] Upon applying the patch series, verifying that the strings provided
    in step 1 are not mangled when the email is sent.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>

LP#1801163: update Debian Buster and Fedora installation deps

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>

Lp 1801163: Switch to Email::MIME in SendEmail A/T Reactor

Switch from Email::Simple to Email::MIME Perl module in the SendEmail
Action/Trigger Reactor.  Email::MIME properly encodes unescaped header
fields when added to the message with the header_str_set method.

We allow only 1 of each address field to be created while doing the
encoding, so that messages conform to RFC 2822.

This commit adds a new prerequisite as mentioned in the release notes,
so be sure to install the prerequisites for your Linux distribution
before installing.

You can test this with concerto data from a fresh installation by:

1. Configuring your test system to send email.

2. Updating all actor.usr entries to have your email address.

3. Updating the New User Created Welcome Notice event definiton to
   active = true.

4. Run the action_trigger_runner with --process-hooks --run-pending.

5. You should get 237 new user welcome emails.  The exact number is
   subject to change.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>