LP1665534: Make pickup library in bib record holds view sticky

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1808006 - Sitemap generator fix to allow shortname parameter.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Geoff Sams <gsams@roanoketexas.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1798628: Copy alert counts in Holdings

Currently the count of all copy alerts ever applied
to a copy is displayed in the Holdings view, which
can be quite confusing when clicking Manage and not
seeing the expected number of alerts. This branch
changes the display to only count the number of
events currently active since those are the only
ones available to manage.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1780639 - stamping upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1780639 - add marc tag identifier field 758

Add needed sql to seed data.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off by: Beth Willis <willis@noblenet.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1778571 Fix logic error converting JS bool to DB bool

Two minor bugs in the Copy Notes editor had the same cause in two
separate places. The cause was forgetting to convert the checkbox status
(a JavaScript bool) to the correct database format ('t' or 'f'). The
resulting symptoms were buggy behavior related to the state of the
"Public Note" checkbox. This commit addresses both cases mentioned in
the bug report and comments.

To test the buggy behavior:
1. Edit an item (e.g. click the "Edit" link from the client OPAC view).
2. Click the "Item Notes" button (near the bottom of the editor).
3. Add a new note and check the "Public Note" box.
4. Click "OK".
5. Click "Item Notes" again and notice that the "Public Note" box on your
   new note is no longer checked. (That's bug #1.)
6. Check "Public Note" again, click "OK", and click "Save & Exit".
7. Edit the same item again. Click "Item Notes".
8. Your note should correctly have the "Public Note" checkbox checked.
9. Uncheck the box and click "OK". Click "Save & Exit".
10. Edit the same item. Click "Item Notes".
11. Notice that your change didn't save. The "Public Note" checkbox is
    still checked. (That's bug #2.)

To test the fixes:
- Clear your browser cache.
- Repeat the steps above, noticing that:
  - At step 5, the new note correctly has the "Public Note" checkbox
    checked.
  - At step 11, the edited note correctly has the "Public Note" checkbox
    unchecked.

NOTE: Testing requires clearing the browser cache, since the
t_copy_notes.tt2 file is fetched asynchronously by AngularJS.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1759238: stamping upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1759238: Add upgrade script to fix typo for Physical Description in DB

This upgrade script will check and update the typo if it is present in
an existing installation.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1769238: fix typo in 950.data.seed-values.sql for Physical Description

Instead of "Physical Description", "Physical Descrption" is used by mistake.
Fix the seed data and all related PO files for translation.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Conflicts:
build/i18n/po/db.seed/cs-CZ.po

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Lp 712490: Stamping UPgrade Script

Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#712490 Vandelay replace/merge PGTAP tests

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#712490 Vandelay merge-based field replacement

Modify the vandelay field replacement logic to merge replacement data
into existing field data where possible, instead of simply deleting then
re-adding the data.  The key benefit is that subfields retain their order
in affected MARC fields.  As a result, for example, propagating
authority field changes to bib records will no longer result in the $0
field being pushed to the front of the field when it was previously that
last subfield.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1709698 - stamping upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1709698: no longer require descriptions in report templates

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1794588 Web client edit single call number changes all when multiple items attached

This patch tweaks the behavior Cat.pm's fleshed_volume_update, aka
open-ils.cat.asset.volume.fleshed.batch.update

Previously, if a volume label was edited, all items attached to that
volume would be essentially affected.  Now, if only a sub-set of items
for the original volume being edited are being edited along with the
volume, then a new volume is potentially created instead, leaving the
original volume (and its unedited copies) untouched.  If no copies are
being edited along with a volume, then the volume itself is edited.

Auto-merging of volumes may still happen in all of these scenarios.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Janet Schrader <jschrader@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

lp1802662 - Splash Page Icon Links

Moved the image icons on splash.component.html and t_splash.tt2 inside
the anchor links to the associated pages.

Signed-off-by: Sam Link <slink@LIBPC002>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1818576 Offline Noncataloged Checkout Preview

This adds the noncataloged type and number to the right-hand
preview when doing an offline checkout. (Prior to this, the
display was blank if there was no barcode.)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1716473 A few tweaks to correct field labels

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1716473 Release Notes: copy edit hide disabled

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Geoff Sams <gsams@roanoketexas.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1716473 Copy editor hide disabled defaults

Disabling a field in the copy editor "Defaults" tab now hides the field
instead of simply disabling it.  Once a field is hidden, subsequent
field shift left to fill the space.

The "Working Items" grid is shifted to the bottom of the page, below the
attributes editor.  This allows the attributes to fill the horizontal
space and puts the working items and save operations visually at the end
of the page, i.e. at end of the work flow.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Geoff Sams <gsams@roanoketexas.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1812389: make Group Penalty Threshold admin page accessible again

As a consequence of the patch for bug 1744756 adding a new
admin/local/permission AngularJS app, the routing for
admin/local/permission/grp_penalty_threshold got broken, making the
embdeded Conify interface for group penalty thresholds inaccessible
from the web staff client. This patch fixes that.

To test
-------
[1] From Administration | Local Administration, go to Group Penalty
    Thresholds. Note that the embedded Conify admin interface
    is not displayed and the URL changes to .../permission/grp_tree.
[2] Apply the patch and repeat step 1. This time, the admin interface
    should appear.
[3] Verify that the Permission Group Tree Entries interface remains
    accessible from Local Administration.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1811689 Stamping upgrade - truncate simple rec

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1811689 TRUNCATE when rebuilding simple record

TRUNCATE reporter.materialized_simple_record for more efficient
rebuilding of the table.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>

LP1734775: Show multiple items in Item Status

The ListCtrl controller was only displaying a single
copy when an id list was passed to Item Status in the
URL. This branch separates each id into a separate
fetch call and when all have been resolved it
refreshes the grid, which now has all of the items.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1721109: Update item status when holdings are edited

To test:
1) Go to Item Status List View, select an item, and go to Actions >
Edit > Items (or Call Numbers, or both).
2) Make a change to one of the columns you have active in
the Item Status list view. Click Save and Exit.
3) Note that the list view of Item Status has not updated.
4) Load this commit.
5) Repeat steps 1-2.
6) Note that the columns are updated this time.  Note that
there is a new status column, and that an icon appears for
all the rows that you have changed.  Also, note that there
is a toast message in the bottom right hand corner of the
screen confirming that you have successfully made your change.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP #1705497 Replaces functionality in web client from legacy
XUL client by including a find function for originating
acquisition where it exists.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Docs: Fixing broken link

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1800178 Holdings View should also sort by part

The Holdings View tab of the web client doesn't correctly sort by
monograph parts. The JS is already grabbing the part label for display,
so this commit moves that chunk before the sorting code, and also grabs
the sort key. Note that the part labels and sort keys are joined per
item, since the database supports multiple parts per item (though the UI
hasn't yet supported that). And we now join the label on comma-space,
instead of the default (just a comma).

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1818153 Stamping DB upgrade - WS user activity

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1818153 Log user activity for websocket login/verify

Adds support for logging additional user activity types:

 * websocket v1 login (apache2-websockets)
 * websocket v2 login (websocketd)
 * websocket v1 verify
 * websocket v2 verify
 * generic login (any ingress)
 * generic verify (any ingress)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1746360 Add Deleted Column to Record Bucket

This adds the Deleted column to the Record Bucket view.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1667497 - Define $params{depth} to avoid uninitialized warning.

$depth is set to 0 if $params{depth} is unset, but then $params{depth}
gets used later on, which causes an uninitialized value warning.

So set $params{depth} to whatever $depth was set to.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1806087 Synchronize browse code for staff cat / tpac

Teach the TPAC to call the use browse API, which was originally built
from the TPAC browse code.  This way we avoid duplicating the code.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1806087 Ang catalog pending tabs offer manual redirect

Instead of sending users to the AngJS versions of not-yet-implemented
tabs from the Angular catalog, show a message indicating the tab is not
yet implemented and offer a link to open the requested record tab in a
new browser tab.  This better clarifies what is happening and helps to
avoid situations where the back-button is confusingly hijacked via
intermediate redirect.

We now also open the "View" link for copies in a new tab as well for
consistency with the modified "Edit" link.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Stop asciidoc from squawking about missing list number

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward-port 3.2.4 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward-port 3.1.10 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

First pass at 3.3 release notes

Ran create_release_notes.sh, cleaned up the output a bit, and removed
the separate files.  Still TODO are acknowledgments and combing out
any upgrade notes.

Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1813646: For now, direct the Home link to the AngularJS version.

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Docs: Adding release notes for 3.2.4

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding release notes for 3.1.10

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1801191: Refactor for clarity; bugfix

This commit makes a few small adjustments:

- Replace two instances of 'cleanse_ISO8601' with 'clean_ISO8601', as
  the former does not exist (at least in these contexts)
- Delay converting DateTimes to strings until necessary (which allows us
  to compare the original DateTime objects instead of having to recreate
  them from strings)
- Increase comments

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1801191: ensure recall does not extend due date

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1787479: Stamping upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1787479 Final fixes for print label customizations. Corrects duplication of pcrud objects
in previous submission and adds CSS to item label template.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1787479: Fixes print label template customization saving for local storage

updates and incorporates added template fields from the patch
user/gmcharlt/lp1726568_label_owning_lib.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1787479: Adds customization for multipage print label printing and fixes the issue
with saving templates after the change to DB saving from local storage.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1787479: Relocate t_view.tt2 file

Accidentally saved tt2 changes in last commit to the wrong directory. Fixing
it in this commit.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1787479: More layout changes

Based on cataloger feedback, we 1) Moved the Label Set Configuration higher
grouped with the spine and spine/pocket options because all of these options
are related 2) Moved the starting label option higher because this is the
one setting that will probably be adjusted on each use of the interface and
3) Made the Gap Between Columns setting label conditional on whether the
user us printing to a sheet with label sets or not.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1787479: Make the display of some fields conditional on the Print Feed Option

Ideally, we would remove the entire Page Settings section for those who are
printing to a continuous feed printer, but it carries the risk of users
not being able to see a field with a value that is affecting the layout. However, there are several fields within that section that don't affect the
continuous feed layout and can be hidden in continuous feed mode. I also
adjusted one help tip to display different information for continuous and
sheet feed printing.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1787479: Make label names more descriptive

As previously discussed on the cataloging list and the LP bug, the previous
label names of 'left' and 'right' no longer make sense since staff can
control the placement of these labels. However, label 1 and label 2 are too
generic. We therefore are going back to spine and pocket labels.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1787479: Some CSS and other formatting changes

Moved most of the CSS to cat.css.tt2; removed most borders since they aren't
needed as much without the full settings descriptions on the page; added some
more help text and removed Windows carriage returns.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1787479: Use help tips for settings descriptions

We are now using popup help tips for descriptions on this page. Adding these
help tips for the new settings added through this branch.

Also changes strings in this interface to translatable text.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1787479: Restore spacing fixes

Restore spacing fixes introduced by Garry Collum that were overwritten with
the original branch.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Modified Evergreen custom print label toolbox with save modifications.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1787479: Custom label printing toolbox

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/staff/cat/printlabels/t_view.tt2

LP1806087 Repair SQL upgrade script file name

Make the name of the file match the upgrade version number applied by
the file.

As is, build/tools/update_db.sh fails to recognize a new update is
available.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1784893 Reporter - External Documentation Links

Removed old xulG logic which was not working in
the web client. Link now opens in new browser tab.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1797934: Simplify header labels

Since the patron is already on the "Reservations" tab in their account,
it seems unnecessary to use the word "Reservations" in the header
labels. Also, simpler labels will make translations easier, since "Start
time" and "End time" are already used in other Bookings interfaces.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1797934: Add a patron's booking reservations to their OPAC account

This commit creates a new tab in the patron OPAC account area where a
patron can view their current bookings.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1806087 Stamp upgrade script for staff catalog preview

Signed-off-by: Dan Wells <dbw2@calvin.edu>

lp1806087 Place Holds Improvements

- Disable SMS Carriers dropdown if Notify by SMS  unchecked.
- Move Search for patron button to same level as "Place Hold (name)" text.
- Add Search icon to "Search for Patron" button
- Add "Submit" button to Barcode input for improved UX.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.html

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1806087 Angular catalog Ang7 & lint repairs

Update rxjs imports to work with Angular7.  Add ng-lint repairs.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1806087 Experimental Angular catalog release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1806087 Org setting to enable experimental staff catalog

Adds a new org unit setting "GUI: Enable Experimental Angular Staff
Catalog" (ui.staff.angular_catalog.enabled).  When set to true, a new
navbar menu item will appear in both the Angular and AngJS client menus
for "Staff Catalog (Experimental)".  This action directs the user to the
Angular staff catalog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1806087 Angular staff catalog phase II.

* Record detail tabs redirect to AngJS catalog where needed.
* Initial holds placement UI.
* Record baskets, actions, and UI.
* Ported MonographParts tab to Angular
* Set default catalog tab
* Browse
* MARC search
* Identifier search
* pub date filter
* Record detail 'View in Catalog' button
* Group formats and editions

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Lp 1813172: Option to Specify Attributes for Reingest in pingest.pl

Add the --attr option to pingest.pl to specify one or more specific
attributes to be reingested by metabib.reingest_record_attributes.

Add a release note.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

lp1717551 Holdings view action menu clarity adjustment

- Added clarifying wording for add, edit, and delete options

Signed-off-by: Katlyn Beck <kbeck@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/catalog/t_holdings.tt2

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1813647 Titles for Angular admin and splash page

Add page titles for auto-generated admin pages, workstation admin, and
the root splash page.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1813647 Angular page title component & sandbox example

Adds a new component <eg-title /> which may be used to pass strings to
the native Angular Title service.

Each title may have a prefix and/or a suffix.  If both are defined, they
are separated by a "-" (by default / en-US) and the prefix is tructed to
12 characters, consistent with AngularJS strings.setPageTitle()
function.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1779158 Stamping upgrade scripts for Angular Vandelay

Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1779158 Angular7 and ng-lint updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1779158 Import field id/class mismatch fix

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1779158 Always clear import selection

Clear the import selection (e.g. Queue => Import All Items) from the
import UI when the user navigates away, regardless of whether the import
succeeded.  Otherwise, the import UI gets stuck in selection mode
requiring the user to manually clear it.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1779158 Vandelay workstation setting repairs/additions

* Fix some workstation setting names that were missing the 'eg.grid.*'
  prefix
* Add workstation setting types for merge profile and attr definition
  admin pages.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1779158 Import non-matching saved template repair

Fix issue in Vandelay import form templates where template variable name
did not match the form variable name.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1779158 Cache new queues / display active queues

* Only list active (non-complete) queues in the Vandelay queue selector
  combobox.
* Display an alert message when the user attempts to create a queue
  whose name collides with an existing queue for the user.
* Be sure newly created queues are added to the local cache of queues in
  the Vandelay service.
* Remove unused activeQueue list from vandelay.service to avoid having
  to maintain 2 separate queue caches.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1779158 Angular alert dialog component

Similar to the PromptDialogComponent except it displays a simple message
(formatted as 'danger') and the only option available to the user is to
close the dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

lp1779158 Inspect Queue Improvements

- Add "Delete selected" option to Authority Queues
- Change Queuetype to 'authority' from 'auth' when selecting single record to view
in auth record queue.
- Ensure "Imported As" link correctly navigates to Auth record view for Auth Queues

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue-list.component.html
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.html
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.ts

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

lp1779158 Vandelay Authority Import Tweaks

- Check for "Auth" string
- Dummy rec.import_items when record is not bib
- Teach resolveQueue() to assume startQueueId unless a queue is selected already

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/import.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/vandelay.service.ts

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1779158 Vandelay UI accessibilty/usability improvements

* Associate <input>'s with their labels in the import and export forms
* Hide the MARC removal groups selector when record type is authority.
* Disable ACQ copy overlay option when record type is authority.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1800481 Vandelay import form templates

Support saving MARC Import form values as named templates.  Values are
stored as (by defualt) workstation settings.  A template may be selected
as the default and templates may be deleted.

Includes release notes update angular vandelay.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1779158 Ang6 Vandelay Release Notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1779158 Ang6 Vandelay UI Port

Port of the MARC Import/Export UI from a Dojo-driven interface to a
Angular(6) interface.

Includes an additional UI called "Recent Imports" which displays
Vandelay session tracker information for both active sessions and those
within the selected time frame.  Active sessions are updated regularly
to display progress to the user.

Includes grid persist key workstation settings.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Lp 1808580: Remove Installation Support for Ubuntu 14.04

Remove prerequisite installation on Ubuntu 14.04 "Trusty Tahr" from
Makefile.install and the edi_translator installation script.

Remove and/or update references to Ubuntu 14.04 Trusty Tahr to Ubuntu
18.04 Bionic Beaver in the server installation and upgrade documents.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1802594: (follow-up) avoid a regression on "Copy" => "Item"

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1802594 - Splash Page Image Alt Text

Added alt="evergreen" to the logo image on the splash page, and alt=""
role="presentation" to the icon images. This was done for both the AngJS
and Ang7 clients.

Signed-off-by: Sam Link <slink@LIBPC002>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Lp 1813290: Fix IAMBROWSER check in ac lineitem table.

Looks like commit e9a9875d added a check for IAMBROWSER that missed
the window.  This commit adds the window.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1796225: Only auto-focus search on the home page

For a11y and usability, it's better to autofocus form fields
only when they are the main purpose of a page.

To test:
1) In the public catalog, visit the search results, record view,
library details, basket, and password reset pages.  Notice that
the cursor leaps to the search bar in each of these pages.
2) Apply this commit.
3) Re-visit all those pages.  Notice that the cursor no longer
leaps to the search bar.
4) Visit the home page of the public catalog.  Notice that the
cursor still leaps to the search bar on this page only.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1799963: Adjust fix to Staff Default Adv Search

By moving the only assignment to $scope.catalog_url inside
an if(<url is advanced search>) then only the advanced search
page can load in the opac. By adding a second assignment
inside an else block all opac pages can load again.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1799963 - fix catalog advanced search type default

Since eg.search.adv_pane is now a server stored WS setting
it needed to be fetched with the proper way in order to work.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1806709: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Lp 1806709: Add circ.patron.billhistory_xacts persist key to database.

We add the eg.grid.circ.patron.billhistory_xacts persist key to
config.workstation_setting_type in the database.

This is a follow-on to the LP1739606: Allow saving Billing History
xacts grid commit and should be applied to master and rel_3_2.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1726568: expose circ lib and owning lib fields to spine/pocket labels

This patch fleshes the item circulation library and owning library
fields so that spine/pocket labels can include the short name or
full name of the OU rather than just the ID.  As a consequence, the
following fields are now available for label templates:

* copy['call_number.owning_lib.id']
* copy['call_number.owning_lib.shortname']
* copy['call_number.owning_lib.name']
* copy['circ_lib.id']
* copy['circ_lib.shortname']
* copy['circ_lib.name']

If, for some reason, existing label templates intentionally use
copy['call_number.owning_lib'] or copy['circ_lib'] to include the numeric
ID of the OU on the label, they will need to be replaced with
copy['call_number.owning_lib.id'] or copy['circ_lib.id'] respectively.

To test
-------
[1] Apply the patch.
[2] Open the print labels window for an item and try including one
    or more of the new fields listed above; verify that the current
    value is displayed on the label preview.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1752665: suppress located URIs in holdings view

To test:

[1] Locate or create a bibliographic record that has at least
    one located URI (e.g., an 856 with a $9 containing an org
    unit code)
[2] View the record in the Holdings View in the web staff interface,
    with the 'Show empty call numbers' (or volumes) option
    selected.
[3] Note that rows are displayed with a call number label of '##URI##';
    these are for the located URIs and should not be visible here.
[4] Apply the patch and repeat step 2. This time the '##URI##' entries
    should not display.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1812733: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1812733: put in correct version of actor.usr_delete()

This fixes an issue in the previous patch where second_given_name
would never have been NULLed.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1812733 - Repair actor.usr_delete function.

The Parent/Guardian feature altered the actor.usr_delete
function, but accidentally tries to update the "guardian"
field twice.  This fixes that problem.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>