working/Evergreen.git
10 years agomake clearing the record bucket pending list action functional
Galen Charlton [Thu, 15 Jan 2015 21:52:00 +0000 (21:52 +0000)]
make clearing the record bucket pending list action functional

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoMerge branch 'collab/miker/web-client-sprint1-bug-fixing-rebased-collab' into webstaf...
Galen Charlton [Thu, 15 Jan 2015 16:23:00 +0000 (16:23 +0000)]
Merge branch 'collab/miker/web-client-sprint1-bug-fixing-rebased-collab' into webstaff_buckets

10 years agoimplement Show All in Catalog action for record buckets
Galen Charlton [Thu, 15 Jan 2015 16:16:03 +0000 (16:16 +0000)]
implement Show All in Catalog action for record buckets

Note that this will typically require the brower's pop-up
blocker to be disabled for the webstaff site.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agouse staff search for record bucket queries
Galen Charlton [Thu, 15 Jan 2015 15:01:02 +0000 (15:01 +0000)]
use staff search for record bucket queries

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agouse staff search for record bucket queries
Galen Charlton [Thu, 15 Jan 2015 15:01:02 +0000 (15:01 +0000)]
use staff search for record bucket queries

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoMerge remote-tracking branch 'working/collab/miker/web-client-sprint1-bug-fixing...
Galen Charlton [Thu, 15 Jan 2015 14:29:48 +0000 (14:29 +0000)]
Merge remote-tracking branch 'working/collab/miker/web-client-sprint1-bug-fixing-rebased-collab' into webstaff_buckets

10 years agoImprove styling of retrieve-by pages
Mike Rylander [Thu, 15 Jan 2015 14:11:26 +0000 (09:11 -0500)]
Improve styling of retrieve-by pages

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoImplement retrieve record by id and tcn
Mike Rylander [Wed, 14 Jan 2015 22:20:23 +0000 (17:20 -0500)]
Implement retrieve record by id and tcn

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoUse egCore.env.basePath to construct the URL for last record
Mike Rylander [Wed, 14 Jan 2015 20:27:15 +0000 (15:27 -0500)]
Use egCore.env.basePath to construct the URL for last record

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoImplement "Retrieve Last Bib Record" using localStorage record cache
Mike Rylander [Wed, 14 Jan 2015 20:05:14 +0000 (15:05 -0500)]
Implement "Retrieve Last Bib Record" using localStorage record cache

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoSave the record we land on from within the staff client as the "last record retrieved"
Mike Rylander [Wed, 14 Jan 2015 19:15:25 +0000 (14:15 -0500)]
Save the record we land on from within the staff client as the "last record retrieved"

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoLP#980296: Stamping upgrade script for void lost on claims returned, etc.
Ben Shum [Tue, 13 Jan 2015 22:00:16 +0000 (17:00 -0500)]
LP#980296: Stamping upgrade script for void lost on claims returned, etc.

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#980296: Release notes entry for voiding lost on Claims Return
Kathy Lussier [Mon, 10 Feb 2014 06:03:12 +0000 (01:03 -0500)]
LP#980296: Release notes entry for voiding lost on Claims Return

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#980296: pgtap tests for the void on claims returned org settings.
Jason Stephenson [Sun, 7 Dec 2014 18:55:53 +0000 (13:55 -0500)]
LP#980296: pgtap tests for the void on claims returned org settings.

A single pgtap file to check if the 4 new settings exist in the database.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#980296: Update void on claims returned for longoverdue status.
Jason Stephenson [Sun, 7 Dec 2014 18:41:42 +0000 (13:41 -0500)]
LP#980296: Update void on claims returned for longoverdue status.

We add settings for voiding longoverdue fees on claims returned.

We modify code in Circ.pm to check those settings and void those
bills when a circulation is claims returned.

We also make some logical repairs to the new void_lost function
in CircCommon.pm and to event handling where that function is
called in set_circ_claims_returned in Circ.pm.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#980296: Add void of lost processing fee on claims returned.
Jason Stephenson [Mon, 1 Oct 2012 21:10:25 +0000 (17:10 -0400)]
LP#980296: Add void of lost processing fee on claims returned.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
10 years agoLP#980296: Void Lost Fines if copy claims returned.
Jason Stephenson [Mon, 1 Oct 2012 18:30:44 +0000 (14:30 -0400)]
LP#980296: Void Lost Fines if copy claims returned.

Add an ou setting (circ.void_lost_on_claimsreturned) to control whether or
not lost fines are voided when a lost circulation is claims returned.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
10 years agoLP#1392759 Add 'bzr' to 'packager' targets
Bill Erickson [Fri, 9 Jan 2015 15:42:40 +0000 (10:42 -0500)]
LP#1392759 Add 'bzr' to 'packager' targets

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1392759 dev/pack makefile.install repairs
Bill Erickson [Thu, 8 Jan 2015 15:09:08 +0000 (10:09 -0500)]
LP#1392759 dev/pack makefile.install repairs

* remove 'make', since you can't execute a Makefile without it.
* remove duplicate installation of auto* packages for debian-wheezy

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1392759 dev/packager Makefile.install additions
Bill Erickson [Wed, 7 Jan 2015 16:55:47 +0000 (11:55 -0500)]
LP#1392759 dev/packager Makefile.install additions

Add additional packages to the "packager" target to help support
building Evergreen packages on machines where Evergreen and its prereqs
are not installed.

The "packager" target now depends internally on the "developer" target,
since packagers have to build the browser client dependencies.

Since older OSes have to build the nodejs dependencies, the autoconf,
etc. targets have been moved into the developer target, again to support
"headless" packaging.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1392759 developer/packager Makefile.install targets
Bill Erickson [Fri, 14 Nov 2014 15:45:07 +0000 (10:45 -0500)]
LP#1392759 developer/packager Makefile.install targets

* Adds <osname>-developer target for installing packages only needed by
  developers installing from source.  Currently, this is limited to
  packages needed for managing browser client dependencies, but others
  could be added later.

* Adds <osname>-packager target for installing packages needed to build
  Evergreen release bundles.

* Updates README install docs to reference these new targets.

* Updates README install docs to remove requirements for installing
  libtool/automake/autoconf, since those packages will have been
  installed during the OpenSRF install (which is required).

* NOTE: this does not include new Makefile.install targets for fedora

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1407507: Update relator codes
Dan Scott [Sun, 4 Jan 2015 21:26:04 +0000 (16:26 -0500)]
LP#1407507: Update relator codes

Per bug # 1046149, we added a script that will generate the contents of the
opac/parts/relators.tt2 file to provide more granular credits for added entries
that have relator codes. However, we haven't run that script since 2013, and
as there are a number of new relator codes, along with some revisions to the
existing relator terms, we should update relators.tt2 accordingly.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1074096: Remove Bib Call Number Search
Kathy Lussier [Thu, 11 Dec 2014 17:12:51 +0000 (12:12 -0500)]
LP#1074096: Remove Bib Call Number Search

Removes the Bib Call Number search as a default numeric search in the
catalog. Release notes include instructions for restoring it for those
sites that wish to restore it.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1386347 stamping upgrade for hold clear copy maps
Bill Erickson [Mon, 12 Jan 2015 16:58:40 +0000 (11:58 -0500)]
LP#1386347 stamping upgrade for hold clear copy maps

Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoLP#1386347 clear maps at fulfillment time
Bill Erickson [Thu, 11 Dec 2014 19:36:11 +0000 (14:36 -0500)]
LP#1386347 clear maps at fulfillment time

For backwards compatibility with queue stats info on captured holds,
clear hold copy maps at fulfillment time instead of capture time, as
before.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoLP#1386347 Remove more unneeded map deleters
Bill Erickson [Wed, 29 Oct 2014 17:08:10 +0000 (13:08 -0400)]
LP#1386347 Remove more unneeded map deleters

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoLP#1386347: Clear hold-copy-map efficiently
Mike Rylander [Wed, 29 Oct 2014 14:37:29 +0000 (10:37 -0400)]
LP#1386347: Clear hold-copy-map efficiently

When capturing or canceling a hold, we can clear the hold-copy-map
with a trigger, saving the time of the user, and making the business
logic simpler.

LP#1386347 copy map trigger wants a RETURN

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoLP#1395456: (Fixing) Add back missing 0901 upgrade script
Ben Shum [Mon, 12 Jan 2015 16:52:22 +0000 (11:52 -0500)]
LP#1395456: (Fixing) Add back missing 0901 upgrade script

I apparently fumbled the upgrade script and it was lost in the action.
LP#1395456 is now closed with adding back this script to the repositories.

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1402797 browser client noncat circ display
Bill Erickson [Wed, 31 Dec 2014 21:05:53 +0000 (16:05 -0500)]
LP#1402797 browser client noncat circ display

Adds a new tab to the patron items out page for Non-Cataloged
Circulations.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoLP#1402797 browser client noncat counts in patron summary
Bill Erickson [Wed, 31 Dec 2014 21:00:06 +0000 (16:00 -0500)]
LP#1402797 browser client noncat counts in patron summary

Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoLP#1402797 browser client interval parser
Bill Erickson [Wed, 31 Dec 2014 20:28:48 +0000 (15:28 -0500)]
LP#1402797 browser client interval parser

Adds a new service on the core module for adding date handling
utilities.  Included in this commit is a new function:

egDate.intervalToSeconds(interval);

Includes Gruntfile additions and unit tests.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoLP#1402797 PCRUD access for noncat circs in IDL
Bill Erickson [Wed, 31 Dec 2014 20:26:03 +0000 (15:26 -0500)]
LP#1402797 PCRUD access for noncat circs in IDL

Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoLP1402797 patron search form focus repairs cont.
Bill Erickson [Fri, 2 Jan 2015 16:21:43 +0000 (11:21 -0500)]
LP1402797 patron search form focus repairs cont.

Building on Mike's original work, use Angular ng-mouseover and the
Angular $document built-in.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoLP#1396359: Add entries for 345 and 346 tags to en-US/marcedit-tooltips.xml.
Jason Stephenson [Thu, 4 Dec 2014 21:28:32 +0000 (16:28 -0500)]
LP#1396359: Add entries for 345 and 346 tags to en-US/marcedit-tooltips.xml.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1396359: Add tooltips for 264, 344, & 347 tags to en-US/marcedit-tooltips.xml.
Jason Stephenson [Tue, 25 Nov 2014 21:29:26 +0000 (16:29 -0500)]
LP#1396359: Add tooltips for 264, 344, & 347 tags to en-US/marcedit-tooltips.xml.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoChanges to smooth out make_release
Dan Wells [Thu, 16 Jan 2014 20:07:40 +0000 (15:07 -0500)]
Changes to smooth out make_release

1) Make the fake 'HeadURL' into a URL which works with our web repo.
Note that this has 'tags/' hardcoded in, so it only works with true
release branches (e.g. rel_x_y_z) not "working" branches
(e.g. rel_x_y).

2) Change range selector when building log to better exclude commits
from previous releases.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoForward-port 2.6.4 upgrade script
Dan Wells [Tue, 6 Jan 2015 21:59:01 +0000 (16:59 -0500)]
Forward-port 2.6.4 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoLP#1406367 Fine generator skips no-fines transactions (parallel)
Bill Erickson [Mon, 29 Dec 2014 22:05:39 +0000 (17:05 -0500)]
LP#1406367 Fine generator skips no-fines transactions (parallel)

Avoid inspecting no-fines transactions when running the fine generator
in parallel mode.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoLP#1406367 Fine generator skips no-fines transactions
Bill Erickson [Mon, 29 Dec 2014 19:04:45 +0000 (14:04 -0500)]
LP#1406367 Fine generator skips no-fines transactions

Filter out any circs or booking reservations which will never be billed
in the initial overdue transactions query used by the fine generator.
This allows us to avoid loading rows into memory that the fine generator
will ignore anyway.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoLP#1406367 Reduce Fine gen. API memory use
Bill Erickson [Fri, 19 Dec 2014 17:14:10 +0000 (12:14 -0500)]
LP#1406367 Reduce Fine gen. API memory use

Avoid loading the full set of billable transaction objects into
memory when generating fines to reduce the memory footprint of the
open-ils.storage fine generater API.  Instead, load transaction IDs
on startup, then fetch individual transactions as needed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoMake Vandelay merge profile names translatable.
Pasi Kallinen [Thu, 4 Jul 2013 09:00:48 +0000 (12:00 +0300)]
Make Vandelay merge profile names translatable.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agouse null as default payment amount
Galen Charlton [Fri, 26 Dec 2014 22:46:31 +0000 (22:46 +0000)]
use null as default payment amount

This means that operator does not have to select the
previous default of "0" in the control to clear it out.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1319964 "Summaries & More" displays improperly in TPAC
Michael Peters [Mon, 8 Dec 2014 17:08:21 +0000 (12:08 -0500)]
LP#1319964 "Summaries & More" displays improperly in TPAC

Commit 14eb3d30 added HTML-escaping of OPAC extras display
labels, meaning that if an ampersand in such a label is
desired, it should be entered in the template just as an ampersand.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
[Amended original commit to tweak message and remove unecessary changes
 to .po files, which are rebuilt when a release is rolled.]

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoForward-port 2.7.1-2.7.2 upgrade script
Ben Shum [Wed, 17 Dec 2014 21:04:33 +0000 (16:04 -0500)]
Forward-port 2.7.1-2.7.2 upgrade script

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoForward port 2.7.0-2.7.1 upgrade script
Ben Shum [Wed, 5 Nov 2014 20:55:09 +0000 (15:55 -0500)]
Forward port 2.7.0-2.7.1 upgrade script

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agowebby: catalog record -> view holds org filter repair
Bill Erickson [Mon, 15 Dec 2014 18:47:51 +0000 (13:47 -0500)]
webby: catalog record -> view holds org filter repair

Selecting a pickup library from the filter in the Catalog -> View Holds
UI shows holds for the selected org unit and descendant org units.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoRepair browser client dropdown buttons - #2
Bill Erickson [Mon, 15 Dec 2014 18:46:14 +0000 (13:46 -0500)]
Repair browser client dropdown buttons - #2

Repairs egOrgSelector.

Angular-ui-bootstrap as of version ~0.11.2 does not want bare
"dropdown-toggle" attributes within action link tags.  When present,
they prevent the dropdown button from opening.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoAllow, and use, disabling of button-ish anchors
Mike Rylander [Wed, 17 Dec 2014 16:31:24 +0000 (11:31 -0500)]
Allow, and use, disabling of button-ish anchors

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoOnly enable the Apply Payment button when a bill is selected
Mike Rylander [Wed, 17 Dec 2014 15:57:28 +0000 (10:57 -0500)]
Only enable the Apply Payment button when a bill is selected

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoLP#1402905 Use stricter matching for UPC values
Dan Scott [Tue, 16 Dec 2014 04:23:49 +0000 (23:23 -0500)]
LP#1402905 Use stricter matching for UPC values

Per http://www.loc.gov/marc/bibliographic/bd024.html we
should be checking to see if either the ind1 is "1" or
if there's a subfield 2 with a value of "upc" before
assuming that any "Other standard identifier" 024 field
is a UPC value.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#921142: Bring back automatic padding of short fixed fields in the GUI MARC editor
Mike Rylander [Fri, 18 May 2012 12:30:08 +0000 (08:30 -0400)]
LP#921142: Bring back automatic padding of short fixed fields in the GUI MARC editor

Bring back automatic padding of short fixed fields in the GUI MARC
editor. Also, use onblur instead of oninput, so that we've already lost
focus and don't care if that happens again.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1394356: Stamping upgrade script for patron purge post code fix
Ben Shum [Tue, 16 Dec 2014 20:15:57 +0000 (15:15 -0500)]
LP#1394356: Stamping upgrade script for patron purge post code fix

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1394356 Patron purge circs retain post code
Bill Erickson [Fri, 28 Nov 2014 21:29:57 +0000 (16:29 -0500)]
LP#1394356 Patron purge circs retain post code

When purging a patron, clear the address data after circulation
anonymization to ensure the usr_post_code is retained.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1400376: Stamping upgrade script for fix to metabib.record_attr
Ben Shum [Tue, 16 Dec 2014 20:01:53 +0000 (15:01 -0500)]
LP#1400376: Stamping upgrade script for fix to metabib.record_attr

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1400376: Don't allow NULL attrs to polute an HSTORE as a key
Mike Rylander [Tue, 16 Dec 2014 01:32:51 +0000 (20:32 -0500)]
LP#1400376: Don't allow NULL attrs to polute an HSTORE as a key

That causes the HSTORE to blow up, which is bad for circs that
want to succeed.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1389403: Stamping upgrade script for normalizer detection to call number browse
Ben Shum [Tue, 16 Dec 2014 19:54:28 +0000 (14:54 -0500)]
LP#1389403: Stamping upgrade script for normalizer detection to call number browse

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1389403 Normalizer detection compatibility with LP#1373693
Dan Wells [Wed, 19 Nov 2014 17:16:03 +0000 (12:16 -0500)]
LP#1389403 Normalizer detection compatibility with LP#1373693

In LP#1373693, $ou_ids become an optional argument when at the top of
the tree.  We need to account for that.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1389403 Add normalizer detection to call number browse
Dan Wells [Fri, 4 Oct 2013 14:02:39 +0000 (10:02 -0400)]
LP#1389403 Add normalizer detection to call number browse

When finding the pivot for call number browse, we currently rely on
simple label matching (rather than normalized label matching), since
we do not know at the time of the search which normalizer we should
use.

Rather than blindly using the label, let's select the pivot in two
phases.  First, we will do what we do know, getting as close as
possible by label alone.  If we find an exact match, we are done (same
as the current code).  If we don't find an exact match, we take the
normalizer setting from the closest label match, normalize our input,
then search again.

This method *greatly* improves the overall accuracy of call number
searching whenever the call number being browsed for does not exist,
while causing no harm to accuracy when it does exist (since it will
either match the label or normalize to the same call number anyway).

Eventually, we may want to add interface elements for selecting the
call number type, probably defaulting to the default call number type
for the org unit being searched, but even with that in place, this
"auto-detection" logic should still be valuable.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1401286: Cleaner display of URIs in search results
Dan Scott [Wed, 10 Dec 2014 22:05:38 +0000 (17:05 -0500)]
LP#1401286: Cleaner display of URIs in search results

Right now a record with an 856 like:

856 40 $zAvailable online $uhttp://publications.gc.ca $9LUSYS

shows up in search results with an HTML display like:

<a href="http://publications.gc.ca">http://publications.gc.ca</a> - Available online

rather than the much cleaner:

<a href="http://publications.gc.ca">Available online</a>

My simplistic approach is to check to see if the link text == the href,
and if so, and we have a note to display, to use the note as the text of
the link instead.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1400082 - avoid uninitialized var warning at TPAC login
Dan Scott [Sun, 7 Dec 2014 13:51:33 +0000 (08:51 -0500)]
LP#1400082 - avoid uninitialized var warning at TPAC login

Give username a default value of '', which makes the regex happy (avoiding an
uninit warning in Apache logs if no value was entered) and still counts as de
nada for the purposes of the actual login dance.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1401271: Add missing dependency for Date::Manip perl module
Jason Stephenson [Sat, 29 Nov 2014 15:34:53 +0000 (10:34 -0500)]
LP#1401271: Add missing dependency for Date::Manip perl module

This commit adds lines to distro-specific Makefiles to install
Perl Date::Manip packages so that Date::Manip::Date is
avaliable for marc_export. Somehow, this got missed or removed.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1400100 - Avoid extra </div> when OpenURL is enabled
Dan Scott [Sun, 7 Dec 2014 15:17:42 +0000 (10:17 -0500)]
LP#1400100 - Avoid extra </div> when OpenURL is enabled

When the OpenURL resolver is enabled, the record summary.tt2 page always
inserts a </div>, whether or not there actually are any OpenURL results to
point at (which is the condition that triggers the opening <div>).

This has the effect of resulting in the generated RDFa not including anything
below the OpenURL section, effectvely preventing the schema.org/Offer types
from being associated with the record. Which is not good for the semantic web
of library data.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoUpdate 2.6-2.7.0-upgrade-db.sql to reflect that it actually starts from 2.6.3 and up.
Ben Shum [Fri, 5 Dec 2014 21:02:04 +0000 (16:02 -0500)]
Update 2.6-2.7.0-upgrade-db.sql to reflect that it actually starts from 2.6.3 and up.

So, actually, the 2.7 upgrade path needs to include everything up to 2.6.3 to get all
the fixes.

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoRe-order parts of 0887 upgrade script
Ben Shum [Fri, 5 Dec 2014 20:59:40 +0000 (15:59 -0500)]
Re-order parts of 0887 upgrade script

Based on feedback from dbs, in PostgreSQL 9.1, the order to which we
fix up these functions matters.  So drop if exists first, then create
new.

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agowebby: checkin fine tally patron bills link
Bill Erickson [Fri, 12 Dec 2014 22:27:06 +0000 (17:27 -0500)]
webby: checkin fine tally patron bills link

Checkin fine tally display now acts as a link which opens a new tab to
the patron bills page for the current checkin patron when fines exist.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoDocs: Circulation - Patron Record web client updated content
Yamil Suarez [Fri, 12 Dec 2014 22:33:20 +0000 (17:33 -0500)]
Docs: Circulation - Patron Record web client updated content

There are still some sections missing, like 'Staff-Generated
Penalties/Messages' and 'merging patrons'.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
10 years agoActually do search button, too
Mike Rylander [Fri, 12 Dec 2014 21:43:53 +0000 (16:43 -0500)]
Actually do search button, too

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoFocus patron search field on search, expand, clear
Mike Rylander [Fri, 12 Dec 2014 21:41:24 +0000 (16:41 -0500)]
Focus patron search field on search, expand, clear

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoUse .finally() instead of hash-y syntax~
Mike Rylander [Fri, 12 Dec 2014 19:02:29 +0000 (14:02 -0500)]
Use .finally() instead of hash-y syntax~

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoApply focus in the .finally() in case there was a popup
Mike Rylander [Fri, 12 Dec 2014 19:01:59 +0000 (14:01 -0500)]
Apply focus in the .finally() in case there was a popup

Signed-off-by: Mike Rylander <mrylander@gmail.com>
11 years agoLP#1401177: Stamping upgrade script of unique_mr_attrs.sql.
Jason Stephenson [Wed, 10 Dec 2014 21:03:11 +0000 (16:03 -0500)]
LP#1401177: Stamping upgrade script of unique_mr_attrs.sql.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
11 years agoLP#1401177: uniquify attrs across a metarecord
Mike Rylander [Wed, 10 Dec 2014 18:51:51 +0000 (13:51 -0500)]
LP#1401177: uniquify attrs across a metarecord

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
11 years agofix checkout focus after patron load
Jason Etheridge [Fri, 5 Dec 2014 21:59:30 +0000 (16:59 -0500)]
fix checkout focus after patron load

Thanks to berick and jcamins, and to eeevil for actually nailing the solution

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
11 years agoDOCS: Tab documentation for web client
Kathy Lussier [Fri, 5 Dec 2014 19:28:02 +0000 (14:28 -0500)]
DOCS: Tab documentation for web client

Replacing the XUL-based tab docs with general tips for using web browser
controls, shortcuts, add-ons to support navigation in the web client.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
11 years agoDOCS: Logging into the web client
Kathy Lussier [Fri, 5 Dec 2014 17:24:45 +0000 (12:24 -0500)]
DOCS: Logging into the web client

Adding a login section to the web client docs.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
11 years agoRepair browser client dropdown buttons
Bill Erickson [Thu, 4 Dec 2014 22:22:46 +0000 (17:22 -0500)]
Repair browser client dropdown buttons

Angular-ui-bootstrap as of version ~0.11.2 does not want bare
"dropdown-toggle" attributes within action link tags.  When present,
they prevent the dropdown button from opening.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
11 years agoDocs: Web Client preview intro
Remington Steed [Fri, 5 Dec 2014 15:29:48 +0000 (10:29 -0500)]
Docs: Web Client preview intro

This commit adds an introduction for the Web Client preview. It explains
what to expect as development continues, and where to give feedback. It
also includes the rationale from the 2.7 release notes.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
11 years agoMinor fix to web client section headers in root.txt
Kathy Lussier [Fri, 5 Dec 2014 14:03:20 +0000 (09:03 -0500)]
Minor fix to web client section headers in root.txt

I accidentally added the circulation header twice when adding the new
sections for web client docs. This commit removes one of the headers.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
11 years agoWeb client section headings
Kathy Lussier [Thu, 4 Dec 2014 21:36:08 +0000 (16:36 -0500)]
Web client section headings

Adding section headings for web client documentation, which will be coming
shortly.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
11 years agowebby: repair Hatch type=text printing
Bill Erickson [Wed, 3 Dec 2014 19:57:54 +0000 (14:57 -0500)]
webby: repair Hatch type=text printing

When printing text, Hatch was receiving no print content due to some
code refactoring.  Repaired.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
11 years agoAvoid org tree retrieval race condition on patron app
Bill Erickson [Wed, 3 Dec 2014 17:48:12 +0000 (12:48 -0500)]
Avoid org tree retrieval race condition on patron app

Avoid calling egOrg.ancestors() during startup, because the org unit
tree is not guarantee to be available until startup has completed.  This
was causing an occasional JS excpetion in the patron app pages, which
prevented the pages from loading.

The error in question:

 TypeError: Cannot read property 'map' of undefined
    at Object.service.get (https://host/js/ui/default/staff/services/org.js:21:25)
    at Object.service.ancestors (https://host/js/ui/default/staff/services/org.js:34:28)
    at Object.egCore.env.classLoaders.actsc (https://host/js/ui/default/staff/circ/patron/app.js:41:37)
    at https://host/js/ui/default/staff/services/env.js:77:55
    at Object.r [as forEach] (https://host/js/ui/default/staff/build/js/angular.min.js:7:290)
    at Object.service.load (https://host/js/ui/default/staff/services/env.js:76:17)
    at https://host/js/ui/default/staff/services/startup.js:64:23
    at J (https://host/js/ui/default/staff/build/js/angular.min.js:101:96)
    at https://host/js/ui/default/staff/build/js/angular.min.js:102:259
    at h.$eval (https://host/js/ui/default/staff/build/js/angular.min.js:113:32)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
11 years agoAdjust timestamp with local timezone before truncating to the date
Mike Rylander [Wed, 3 Dec 2014 21:40:50 +0000 (16:40 -0500)]
Adjust timestamp with local timezone before truncating to the date

Signed-off-by: Mike Rylander <mrylander@gmail.com>
11 years agoAdd usr and requestor columns to the hold pull list
Mike Rylander [Wed, 3 Dec 2014 15:54:34 +0000 (10:54 -0500)]
Add usr and requestor columns to the hold pull list

Signed-off-by: Mike Rylander <mrylander@gmail.com>
11 years agoBegin teaching grid about class hierarchies for labels
Mike Rylander [Wed, 3 Dec 2014 15:54:13 +0000 (10:54 -0500)]
Begin teaching grid about class hierarchies for labels

Signed-off-by: Mike Rylander <mrylander@gmail.com>
11 years agoFetch old circ when the user is not the same (API misuse)
Mike Rylander [Wed, 3 Dec 2014 15:53:35 +0000 (10:53 -0500)]
Fetch old circ when the user is not the same (API misuse)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
11 years agoBrowser client checkout 'Done' clears current user
Bill Erickson [Tue, 2 Dec 2014 22:28:01 +0000 (17:28 -0500)]
Browser client checkout 'Done' clears current user

Clicking the 'Done' button after checkout resets the patron side bar and
action tabs to completely hide the previous patron's data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
11 years agoDocs: Update to template receipt docs
Lynn Floyd [Mon, 10 Nov 2014 18:29:31 +0000 (13:29 -0500)]
Docs: Update to template receipt docs

Thanks to Lynn Floyd. When adding the new content I ended up splitting new and old content into three files.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
11 years agoRemove useless options in record bucket export
Mike Rylander [Wed, 26 Nov 2014 15:48:07 +0000 (10:48 -0500)]
Remove useless options in record bucket export

Signed-off-by: Mike Rylander <mrylander@gmail.com>
11 years agoRevert "LP#1198465 Allow fine generator to respect a stop_fines filter"
Dan Wells [Wed, 19 Nov 2014 23:08:31 +0000 (18:08 -0500)]
Revert "LP#1198465 Allow fine generator to respect a stop_fines filter"

This reverts commit e1fdcd3a6885baac3f86402e330aef3d8b36c681.

The code failed in the case of restoring voided lost overdues together
with generating new lost overdues on checkin.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
11 years agoRevert "LP#1198465 lost overdues generated in main xact"
Dan Wells [Wed, 19 Nov 2014 23:06:18 +0000 (18:06 -0500)]
Revert "LP#1198465 lost overdues generated in main xact"

This reverts commit d2a521c0ff32e9921bfc93cb86b2c917e5eda92e.

The code failed in the case of restoring voided lost overdues together
with generating new lost overdues on checkin.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
11 years agoLP#1207529: Add /openils assumption note
alzr [Mon, 5 Aug 2013 21:50:09 +0000 (16:50 -0500)]
LP#1207529: Add /openils assumption note

Signed-off-by: alzr <aleksey.lazar@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoLP#1207529: Make sure $PATH includes /openils/bin when configuring
alzr [Mon, 5 Aug 2013 19:33:07 +0000 (14:33 -0500)]
LP#1207529: Make sure $PATH includes /openils/bin when configuring

https://bugs.launchpad.net/evergreen/+bug/1207529

Signed-off-by: alzr <aleksey.lazar@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
docs/installation/server_upgrade.txt

11 years agoLP#1384932: document the zips.txt ZIP code database feature
Josh Stompro [Wed, 29 Oct 2014 21:12:08 +0000 (16:12 -0500)]
LP#1384932: document the zips.txt ZIP code database feature

Patron Address City/State/County Pre-Populate by ZIP Code.

Documented the zips.txt feature that auto fills patron address
(City, State, County) information.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoLP#1246371: Allow BibCommon::title_is_empty to accept a bre id or bre object.
Jason Stephenson [Wed, 30 Oct 2013 15:05:45 +0000 (11:05 -0400)]
LP#1246371: Allow BibCommon::title_is_empty to accept a bre id or bre object.

I was trying to delete copies with the record fleshed in the call number
object and got the following error:

Can't use an undefined value as an ARRAY reference at
/usr/local/share/perl/5.14.2/OpenILS/Application/Cat/BibCommon.pm line 399

Having title_is_empty check for a bre object and use its id solved this
problem for me.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoLP#1083639: use "cp -r" instead of "cp -R"
Galen Charlton [Thu, 13 Nov 2014 18:45:14 +0000 (10:45 -0800)]
LP#1083639: use "cp -r" instead of "cp -R"

This change is purely for the sake of consistency; there's
no functional difference.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoLP#1083639 - Added command to copy fonts into the KPAC2 / Alternate monster skin dir
Josh Stompro [Thu, 23 Oct 2014 19:30:05 +0000 (14:30 -0500)]
LP#1083639 - Added command to copy fonts into the KPAC2 / Alternate monster skin dir

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoLP#1116387 - adding kpac setup notes.
Josh Stompro [Thu, 23 Oct 2014 18:21:16 +0000 (13:21 -0500)]
LP#1116387 - adding kpac setup notes.

Revised instructions based on my testing.  Swapped around the Monster
and Default skin discriptions since the listed Alternate Skin is the default skin.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoAdd KPAC configuration info to the community docs
Kathy Lussier [Tue, 5 Feb 2013 15:24:17 +0000 (10:24 -0500)]
Add KPAC configuration info to the community docs

Adds the KPAC TechRef docs to root.txt so that this information can be
available via the community docs. Also adds a section to the docs on
configuring the alternate skin and removes a reference to configuration
from the end-user KPAC docs.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoLP#1246839: marc_stream_importer.pl no longer crashes with vs 0.23 of File::Temp
Fredric T Parks [Wed, 6 Nov 2013 23:36:32 +0000 (15:36 -0800)]
LP#1246839: marc_stream_importer.pl no longer crashes with vs 0.23 of File::Temp

updated marc_stream_importer.pl to use the 0.23 API

Signed-off-by: Fredric T Parks <fparks@catalystitservices.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoAllow the status bar to be hidden
Mike Rylander [Wed, 12 Nov 2014 20:00:07 +0000 (15:00 -0500)]
Allow the status bar to be hidden

Signed-off-by: Mike Rylander <mrylander@gmail.com>