TPac: MARC expert search bug fixes

- Allow for searching on tags w/o specifying subfield
- Protect against empty search queries
- Cleanup: Avoid some of the manual osrf session management by using
  $U->simplereq, which does all of that for us.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

TPac: Submit search on sort/limit change

By popular demand, when the user changes the search sort or
limit-to-available options, the form is immediately resubmitted via
JavaScript.  Fails gracefully in the absence of JS.

Minor JS cleanup.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac-master-merge

Stamping upgrade script for LP#837566

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#837566 undeleting a bib record causes an error

fixes a column reference

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

fix Acq -> Update Barcodes post-parts

Items from acquisitions were having null instead of [] for .parts()

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

TPac: more template scrubbing and cleaning

Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP#838969 Silent print cannot be unselected

Thanks Bill!

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Tpac: Support for skinning via Apache configuration

More generally, support for augmenting the Template Toolkit template
path list to allow for per-vhost template paths.

For example, a 3-tier consortium could do something like this:

<VirtualHost ...>
    [...]
    PerlAddVar OILSTemplatePath "/openils/var/templates_branch_abc"
    PerlAddVar OILSTemplatePath "/openils/var/templates_system_xyz"
    PerlAddVar OILSTemplatePath "/openils/var/templates_shared"
</VirtualHost>

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Don't prepend / to relative template paths

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Remove /default/ from template paths

The original goal of having a /default/ component to the template path
was to support alternate skins.  However, Template Toolkit supports
alternate skins through a more elegant mechanism of providing template
overlays via template path configuration.  In other words, skin files
will be differentiated by the location of their root path and not
because they live in a different skin directory inside the main
template root.

Because of this, the /default/ component in the template path serves
no purpose and generally just gets in the way.

As a part of this, EGWeb.pm no longer inserts the skin name into the
template file path.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac-master-merge

Removed (very) old, unused template files

Signed-off-by: Bill Erickson <berick@esilibrary.com>

TPac: more cleanup of unused IDs and files

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Tpac: more unused ID cleanup; parts/record

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Address LP#837517, Vandelay ISxN matching

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Add the forgotten script-numbering to previous commit (db756e623a9)

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Address LP#837522, bib-killing authority overlay generation bug

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Tpac: removed unused code and IDs in advanced search parts

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac-master-merge

Merge branch 'collab/miker/acs-ui-repairs' from working/Evergreen.git

Use bib tag instead to find the correct ACS, instead of the static field map
Use authority main entry instead of thesaurus to find the correct ACS
Add method for finding an ACS by authority tag

See https://bugs.launchpad.net/evergreen/+bug/837637

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Tpac: only show opac_visible notification opt-in settings

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Tpac: Support for adding/editing pending addresses

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Tpac: show hold/copy count summary in holds status

Signed-off-by: Bill Erickson <berick@esilibrary.com>

TPac: apply the select-all JS to holds list

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Tpac: config option for record detail jacket size

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Tpac: merged esi/template-toolkit-opac; conflict resolution

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac-master-merge

Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac

Merge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into template-toolkit-opac

Merge branch 'master' of git.evergreen-ils.org:Evergreen

pin upgrade version number for magic macros
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Expose sort values from lists

Specifically useful for things like receipt templates.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Five initial OU settings for %INCLUDE()% use

header_text
footer_text
notice_text
alert_text
event_text

None are really restricted to a specific purpose. Names are more of a
hint than a requirement.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Receipt Macros: %INCLUDE()%

Takes a single parameter: The name of the include.

Each include is an OU setting: circ.staff_client.receipt.<name>

The includes are done as the first substitution. This has the benefit
of allowing other substitutions within them (including additional calls
to %INCLUDE()%) and the downside of not allowing dynamic includes.

Because an include can contain includes the code keeps track of all
includes already done, skipping those already included. This prevents
infinite loops when A includes B and B includes A, or longer variants
thereof.

Primary intended use would be for libraries to place frequently changed
notices and such in their templates. Instead of having to edit every
template on every workstation they use the %INCLUDE()% macro and edit
the org unit settings. At the next login the updated text appears on
every workstation.

Due to the includes being processed first a library could use them to
centrally administer templates by using an include for each piece of
each template.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Receipt Macros: %SORT()%

Added to line item templates.
Takes one or more comma separated parameters:
field AS type ASC/DESC

AS type is optional
ASC/DESC is optional

Field is the field name without % signs.
Type is DATE, INT, FLOAT, NUMBER, LOWER, or UPPER

DATE will sort based on wrapping both sides in "new Date"
INT will sort based on wrapping both sides in parseInt
FLOAT and NUMBER will sort based on wrapping both sides in parseFloat
LOWER will apply .toLowerCase to both sides
UPPER will apply .toUpperCase to both sides

ASC (default) will sort in ascending order.
DESC will sort in descending order.

Can be specified more than once:
%SORT(a,b)% %SORT(c)%
Would sort by a, then b, then c.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Add SIP2 chargeable loan support.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP#824257 Fix nasty overlapping when patron has more than 6 notes

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Push phrases down to be subqueries, so they can be ORed together

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Merge branch 'ttopac-advanced-sort-avail' into template-toolkit-opac

Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac

Add IDs to offline import/export buttons

Ensures that the import one, at least, can be found and disabled when
pending transactions exist.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add a new visible alert to the main client screen alerting about pending transactions

Signed-off-by: Edoceo <code@edoceo.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamped upgrade script for acq-copy-creator-from-receiver

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Option to set copy creator value to ACQ receiver

YAOUS to support updating the asset.copy.creator value to match the
staff user that marked the ACQ-copy (acq.lineitem_detail) as received.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamped upgrade script for acq-lineitem-detail-receiver

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Show copy receiver in ACQ copy grid

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Column to track ACQ copy (lineitem_detail) receiver

Creates acq.lineitem_detail.receiver column, set to the staff that
marked the copy as received.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Protect against div-by-0 for negated words

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Track count of dummy atoms and use a NULL tsquery when all dummy

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Use unphrases in SQL generation

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

add "unphrases" to capture negated phrases ( -"foo bar" ) and make the negator configurable

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Ignore empty atoms in query decomposition

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Add to existing PO (by ID) from related items page

In the View/Place orders page for a bib record, it's now possible to add
a lineitem representing the bib record to an existing purchase order.

Includes a new general API call for adding a LI to a PO.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Support labelFormat for read-only AutoFieldWidget's

Previously only worked with edit widgets (e.g. drop-downs).  This also
takes into account the fact that different instances of AutoFieldWidget
for the same class and value may have different labelFormat's

One user-visible result of this change is the ACQ read-only fund display
in purchase orders.  Funds will now show the code and year for funds in
the copy grid before and after the data is rendered read-only.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Branchify patch from Steven Chan on LP bug #821640.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Really stop the z39.50 daemon when a client is connected.

Send a SIGTERM instead of SIGINT from do_action when the action is
stop in oils_ctl.sh.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Enhance sample Z39.50 config file

Make "expose holdings" the default; use specific indexes for ISBN and
ISSN; show how to scope results to a part of the org tree; and show that
multiple database configs can be specified in the same file.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Make some oils_ctl.sh improvements.

Add start|stop|restart commands for z39.50 to oils_ctl.sh.

Use LOCALSTATEDIR and SYSCONFDIR configuration variables in
oils_ctl.sh.

Modify the existing SIP2 commands in oils_ctl.sh to use these
configuration variables.

Modify src/Makefile.am to replace LOCALSTATEDIR and SYSCONFDIR
variables in oils_ctl.sh when installing.

Add example/default xml configurations for z39.50:
Open-ILS/examples/oils_yaz.xml.example
Open-ILS/examples/oils_z3950.xml.example

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>

Menu item for "portal"

To return a tab to "new" state without close/reopen

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Make portal name its tab.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamped upgrade script for LP#825245

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Vandelay: added some info to print/csv bib output

Added bib match count, import error, and error detail to print and CSV
queued record export.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Vandelay: show record match counts in record queue UI

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

master-stamped upgrade script for LP#816131

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Reverse direction of org_unit_ancestors

Apparently callers expect it to start at the top of the org tree.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Unwrapped upgrade script for oua_force_order

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

New version of actor.org_unit_ancestors

Preserves order through joins

Basically actor.org_unit_ancestors_distance with a join to get the
entire org units, rather than just IDs and a distance.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fixed seaching for a colon (:) surrounded by white space

When searching for a colon surrounded by white space the search would
freeze.  An example of such a search would be:
Climate change economics and policy : an RFF anthology
This was happening because the decompose function within QueryParser.pm
Would build a regular expression that would search the query for both
classes and class aliases e.g (keyword and kw).  However, when buliding
the regex for aliases QueryParser would add extraneous or symbols (|)
to the end of the regex without adding the accompanying alias.
This was happening because there was a check to see if the corresponding
class to each alias had already been added to the regex.  But, the
check to see if the alias had already been appened to the regex happened
too late.  I have moved the check to encopase the appending of the or
symbols and the class.
Signed-off-by: Liam Whalen <lwhalen@evergreen-dev.catalogue.nrcan.gc.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Adds org unit selectors to Admin -> Server Admin -> Booking menu items, also modifies
the IDL to give context-field based pcrud perms instead of 'require global'
This makes the booking module more org-unit scopable

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix "Retarget Local Holds" for non-holdable copies

Specificially:

Wrap holdable check in is_true
Add check for current copy status holdable
Add check for current copy location holdable

The latter stores the fetched location for later use.
The one later use I found updated to check if the location is a reference.

The update copy code already checks if location is a reference and deals
with it properly.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Vandelay: Insufficient Quality Fall-Thru Merge Profile

When a user selects "Merge On Single Match" or "Merge On Best Match" and
apply a minimum quality ratio, the fall-through profile will be used in
a secondary merge attempt for any records that fail the initial merge
due to insufficient record quality.

This allows the user to choose 2 different outcomes based on record
quality.  For example, you may wish to do a full overlay for all
high-quality records, but only extract subjects or other information
from lower quality records.  This also allows users to do record+copy
imports for high-quality records and copy-only imports for low quality
records (using a no-op merge profile like "replace 901c").

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Branchify patch from LP bug #802523.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

UI cleanup for batch-holds from lists

* Handle hold placement override with a single form and checkboxes
instead of a series individual forms

* Added a cancel button on the override page

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Make the sort-by and limit-to-available controls appear after adv search

This is hackish and suboptimal until we leverage the parsed queries soon
to be returned by QP.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

stamp an upgrade version for the czs use_perm feature

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

use_perm column for config.z3950_source

The idea is that if a permission code is specified for a given source, then
staff will need that permission to use that source in the staff client z39.50
interface.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

TPac: batch holds from on-the-fly lists and bookbags

* Enable the 'Place Hold' action in the drop-down for bookbag and
on-the-fly list items

* Place hold form now support lists of targets and will report error
conditions for each target

* Batch and individual hold overrides supported where appropriate

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Fix penalty generation during billing creation

by passing the editor object referencing the database transaction to xact_org

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Display only available formats for metarecord holds in IE

The OPAC's usual hideMe()/unHideMe() tricks don't work for <option>
elements in Internet Explorer 8.  Use the disabled attribute.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Remove cache-generator.sh from Makefile.am

In a previous commit, we removed cache-generator.sh. Now we remove the
remaining reference to it in the Makefile.am that was generating an
error (reported by Ben Webb).

Signed-off-by: Dan Scott <dan@coffeecode.net>

T-PAC: Localize payment refund policy message

The policy in all likelihood will differ from library to library anyway,
but we might as well ensure that it can be translated.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Disable Google Analytics in T-PAC by default

The option to enable Google Analytics has been turned into a config
setting in parts/config.tt2 for now, with a place to set the GA account
code.

Also, get consistent with foo.enabled instead of a mix of foo.enable /
foo.enabled in config.tt2.

Also, be a bit more careful about whitespace and hide comments in the
HTML source about things that are disabled (such as ChiliFresh and
Google Analytics) until they are enabled.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Vandelay: repair item attr context org selector

1. Prevents resetting the context selector to the workstation org unit
each time it's changed.

2. Prevent the unintentional pileup of dojo.connect() events, which
can lead to exponential growth in the number of server calls to fetch
import-item-attribute-definitions with each change of the context org
selector.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into dbs/ttopac-master-merge

#LP801961, error when running edi_fetcher.pl

This patch addresses an error encountered when running edi_fetcher.pl.
The method "is_dir" should be just plain "dir" in RemoteAccount.pm file.
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Branchify second patch from James Fournie on LP bug #791941.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Branchify the first patch from James Fournie on LP bug #791941.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Branchify patch from LP bug #809478 and forward port to 

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Tpac: fetch bib record piles non-atomicly to avoid large messages

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Tpac: fetch bib record piles non-atomicly to avoid large messages

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Tpac: stream bookbag entry retrieval to reduce msg size

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Tpac: stream bookbag entry retrieval to reduce msg size

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Stricter order for actor.org_unit_parent_protect()

actor.org_unit_parent_protect() may not work due to the fact
that 'IF' conditions in PL/pgSQL are not necessarily processed
in the order written. This line:

"IF TG_OP = 'INSERT' OR NEW.parent_ou
IS DISTINCT FROM OLD.parent_ou THEN"

may fail because the 'IS DISTINCT FROM' happens before the
'INSERT' check, and and that fails because there is no 'OLD'
variable for INSERTs.

This commit may not be the optimal style for this circumstance
in this language, but it works.  It also appears to change more
than it really does due to a loss of one level of indentation in
the structure.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Whitespace Only Changes

Files uses primarily tabs, function used both spaces and tabs.
It now uses all tabs.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Update README to reflect the --create-database option

Now that eg_db_config.pl is intelligent enough to create the database,
update the README to free people from the tyranny of having to manually
issue database creation (and contrib-adding) commands.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac

Tpac: style inactive holds w/ grey bground

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Tpac: style inactive holds w/ grey bground

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Add --create-database option to eg_db_config.pl

Uses create_database.sql and superuser rights to do all
database creation steps other than making a usable superuser
account to begin with.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>