PINES Customization: Hide FAST Subject Headings

See help desk ticket 4655.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Customization: Self-check - add note about online catalog

Added note to screen referring people to online catalog if they
wish to perform functions not available in self-check such as
paying fines and handling renewals.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Customization: Self-check text changes

Modified login text to make it more user friendly.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Customization: Add IMLS logo to footer

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Customization: Adding menu link to Android App download.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Add Invoice Summary Reporting View.

Before now, there have been no easy ways to gather acq
receiving totals from reports.  Here is an attempt to remedy
that situation.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Driver's license guidelines
Added on-screen tip to remind staff how driver's licenses should be
entered in PINES.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

OPAC Updates related to page text and translations. Also required are the
en-PINES.po custom text file and the es-ES.po translation file.

Language - here are three files I missed including in the prior
collection of translation-related files.

Language files - a few more corrections.

Changing hard-coded string to allow locale to work.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/opac/parts/advanced/search.tt2
Open-ILS/src/templates/opac/parts/pref_lib_display.tt2

Restoring selfcheck.js to stock version

Addition of new item format icon for direct audio (ie, Playaways and
similar items that are pre-loaded with audiobooks and do not require
access to a computer to use).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

adding login redirection page

Adding PINES-ified notification wordings.

Changes to splash screen and receipt template defaults for web client.

(Note: Could not test on terran-testbox since it is not https-enabled,
so I could not log in to the web client.)

These changes undo a couple of small things I tried to tweak on the web
client that didn't work the way I hoped they would.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Self-Check changes in preparation for upgrade:
Changed wording on some of the on-screen directions.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Selfcheck Cookie Path

Change base.xul/base.js to support a "cookie path" option to limit what paths
will use the login cookie, then tell the selfcheck interface to use it.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Additional changes to the self-check interface.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Images for new "no image available" functionality.

Lines 94-104 in eg_vhost.conf need to be un-commented.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

These are modifications to the Evergreen self-check interface to:

1. Fix bugs with printing holds and fines.
2. Improve page layout overall, and with consideration for
   1024x768 resolution monitors that a lot of libraries use.
3. Hide hold status from view on holds table.
4. Hide buttons/fields from screen when user is not logged in.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/circ/selfcheck/banner.tt2

Change links old library map to new interactive library locator map.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Enabled Google Analytics for OPAC usage tracking.

branding the built-in selfcheck interface for PINES

Make users_of_interest test for defined actor.usr.card values

If the open-ils.collections.users_of_interest API encounters a patron that
has a null "card" value in actor.usr the API will crash with an error like:

Received Exception:
Name: osrfMethodException
Status:  *** Call to [open-ils.collections.users_of_interest.retrieve] failed for session [1416515351.333446.1416515351406], thread trace [1]:
Can't call method "barcode" on an undefined value at /usr/local/share/perl/5.14.2/OpenILS/Application/Collections.pm line 299.

This patches users_of_interest to be sure that the user has a defined value
for actor.usr.card before proceeding to pull out the barcode for the results
of the API call.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Collections.pm

Removing "Bib Call Number" from the advanced numeric search options.

Commenting out Bib Call Number and uncommenting Call Number Browse.

Conflicts:
Open-ILS/src/templates/opac/parts/advanced/numeric.tt2

Allowing unfillable hold placement in the staff client, not the OPAC

In PINES, we do not allow patrons to override hold policies, but staff
may in certain circumstances.  This change makes the option visible in
the staff client, but not the OPAC.

KPAC squashed

This combines multiple KPAC customizations into a single commit.

Conflicts:

Open-ILS/src/templates/kpac/home.tt2
Open-ILS/src/templates/kpac/parts/copy_table.tt2
Open-ILS/src/templates/kpac/parts/header.tt2
Open-ILS/web/css/skin/default/kpac/style.css

Conflicts:
Open-ILS/src/templates/kpac/parts/copy_table.tt2
Open-ILS/web/css/skin/default/kpac/style.css

Updated dewey.tt2

PINES customization of KPAC - beta ready for testing

Removing "kpac-original" directory in order to keep a clean source directory.

Image handling has changed in the new version...

Removing PINES-customized code that referred to a now-missing image.

Modifications to quick search functions and stylesheet.

Conflicts:

Open-ILS/web/css/skin/default/kpac/style.css

Testing modifications to navigation.

Further tweaks to search limits and modifications to book bag links.

Small changes to Search Limit names and Category names.

Correcting file path for PINES logo on KPAC.

PINES KPAC landing page doesn't include the Print button.

Temporarily hid Add to List functionality until it can be further developed.

Adding KPAC link to header and footer.

Modified style guide to emphasize call numbers in search results and item display.

Attempt to fix default pickup location bug when user is not logged in.

Conflicts:
Open-ILS/src/templates/kpac/getit.tt2

fixed problem with referencing wrong org selector

Conflicts:
Open-ILS/src/templates/kpac/getit.tt2

temporary workaround for holds error when user isn't logged in and doesn't select a pickup location

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm

Adding fix for KPAC hold placement.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Corrected version of kpac.xml with properly nested preset searches

Added README and graphics template for use of KPAC graphics.

Conflicts:
Open-ILS/examples/kpac.xml

Added Nutrition subcategory under Early Learning category in KPAC.

Add GALILEO for Kids link to KPAC header.

Syncing kpac.xml with rel_2_5_1_kpac

Change to allow KPAC to display more than one format icon (like OPAC).

Fix for KPAC multi-format items

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:

Open-ILS/src/templates/kpac/record.tt2
Open-ILS/web/css/skin/default/kpac/style.css

KPAC Login Redirect Fix

Fixes the redirect from the KPAC login to return back to the
home page of the KPAC from the /opac/login screen, rather
than back to the /opac/home screen, which is the current
behavior, and confuses users of the KPAC when they end
up back in the OPAC after having logged in.

Modified KPAC login code to redirect to KPAC after logging in

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:

Open-ILS/src/templates/kpac/parts/header.tt2

Fix for too-large header sizes causing display issues in KPAC

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Fix for KPAC holdings display issue.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC 2.7 Upgrade Tweaks

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:

Open-ILS/examples/kpac.xml

Adds B4 Book Log icon and link to KPAC search results page and
KPAC item details page.

(This is a PINES-only customization.)

Adds B4 Book Log icon to KPAC search results page and
KPAC item details page.

Conflicts:
Open-ILS/src/templates/kpac/parts/record_row.tt2
Open-ILS/src/templates/kpac/record.tt2

Updated link to old library map to new library locator map in KPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Improvements to KPAC list display, especially adding
display of list annotations that were not shown.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/kpac/parts/record_row.tt2
Open-ILS/src/templates/kpac/results.tt2

Removed added content from the KPAC for now since it doesn't
display properly. Possibly add back in later if we can get
the NoveList content to pull in right.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC changes in preparation for upgrade:

1. Biggest change was to move the library selector box to the main
search panel instead of on the side - had to modify quite a few files
in order to make this work and pass the values correctly.

2. Also changed the feature icons to use links instead of search terms
to allow more control over search limits and sorting and to see if
caching the searches would improve response speed.

3. A number of smaller UI changes.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC - Hold results not displaying item title and throwing log error

I believe the path comparison operator in the 'load' subroutine has
a flaw in logic caused by a path-naming problem. The path-matching
function recognizes the kpac/getit_results path as matching positively
for both the load_getit subroutine and the load_getit_results subroutine.

This patch reverses the order in which the matching occurs in an attempt
to resolve the conflict.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
I've redone all of the kpac category links so they no longer use
a link shortener. I also rearranged some of the links so that there
are more options on the home page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/examples/kpac.xml

Updates to KPAC Features (addition of TumbleBooks)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Since we only have bits and pieces of Spanish translations for our
customized KPAC right now, removing the parts that would display in
Spanish if Spanish has been selected in the OPAC. In the future when
all parts of the KPAC have been translated and graphic buttons have
been switched to text buttons that can be translated, we will then
need to go back in and re-add the language markup to allow the
translations to occur.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC Config File: Feature Page Reset

Fresh version of kpac.xml file ready for upgrade to 3.0.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>
KPAC Fix to broken image links

Removes cache info from image links in KPAC because
it was causing links on Dewey page to break.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC Art and Features for SRP 2018

Signed-off-by: McCanna <tmccanna@georgialibraries.org>
PINES KPAC: Summer Reading 2019 Topics

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC Update: Remove Tumblebooks Link

GALILEO canceled Tumblebooks, so removing link.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC Updates: Add E-Read Kids

Add new permanent KPAC icon for E-Read Kids, hide summer reading,
show back to school.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
PINES KPAC: New logo

Updates to incorporate new PINES logo.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Changing the default hold message for when an item is age protected.

adding in gmcharlt's fix for trailing TCN spaces

Conflicts:

Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/BibCommon.pm

adding PINES help links

Conflicts:

Open-ILS/src/templates/opac/parts/login/help.tt2

updating the username/password hints for the opac

Conflicts:

Open-ILS/src/templates/opac/parts/login/form.tt2
Open-ILS/src/templates/opac/parts/login/password_hint.tt2

improving the default hold message for range-protected items

Enabling the display of 856 field URLs for related resources

Password Length Helpers

This branch provides length helpers when patrons are setting or resetting
passwords.

This assumes the default 7 characters, 1 number requirement that comes stock.
You would need to change the hard coded strings if you use a different password
requirement regex in Library Settings Editor.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>

removing journal title and bib call number from query type selector dropdown

Conflicts:

Open-ILS/src/templates/opac/parts/qtype_selector.tt2

Conflicts:
Open-ILS/src/templates/opac/parts/qtype_selector.tt2

removing bib level advanced search filter

Conflicts:

Open-ILS/src/templates/opac/parts/config.tt2

Conflicts:
Open-ILS/src/templates/opac/parts/config.tt2

PINES GALILEO TPAC link and auth redirector

* adds a GALILEO link in the footer template
* adds a new TPAC URL target for /eg/opac/galileo, which redirects the
  user to the GALILEO URL, ensuring the user is first logged in.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2

PINES/GALILEO avoid auth redirect within library

If the physical_loc is set, indicating the patron is physically at a
branch (via IP redirect), link directly to the GALILEO site with no
authentication pass-through.  GALILEO does not requires PINES auth
if the client is coming from a known IP address.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2

Sadly, GALILEO/EBSCO does not use HTTPS, so this will create errors for patrons who authenticate via PINES.  Reverting to HTTP.

Bumping version numbers and adding Changelog

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

bump up Perl version for 3.8.0

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Translation updates - po files - 3.8.0

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

final update to release notes for 3.8.0

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

update upgrade script for 3.7.1-3.8.0

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1830089: close transaction and update copy status on payment or adjust to zero

When you make a payment that sets the balance owed to zero, Evergreen
closes the transaction and sets the item status to Lost & Paid (if
appropriate).  Adjust to Zero should do the same thing, but hitherto it
would not update the item status.  This commit refactors some code to
ensure that Evergreen gives the same result whether you make a payment
or adjust to zero.

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

update Czech translations for Angular staff client

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1948594: Fix pgtap live test

Fix the lp1145213_test_func_asset.merge_record_assets.pg pgtap live
test by removing the COMMIT and adding a ROLLBACK at the end.  This
permits the test to run multiple times without requiring a database
reload.

To verify the bug:

1. Install the pgtap package appropriate for your PostgreSQL database
version.

2. Load a fresh database with eg_db_config using the --load-all-sample
option.

3. Create the pgtap extension in the evergreen database.

4. Run the Open-ILS/src/sql/Pg/live_t/ tests with pg_prove.

5. Repeat step 4, and if this patch has not been applied, then the
lp1145213_test_func_asset.merge_record_assets.pg tests will fail on
the second run.

To test the fix, repeat steps 2 - 5, above, after pulling this commit.
Step 5 should succeed.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1947173: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1947173: Clean up bad cataloging pot hole

If a MARC record has effectively empty fields (all space or punctuation)
then it's possible to stumble over a NULL text array when parsing
content for the symspell dictionary.  This commit checks for that
condition and returns early to avoid the problem.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1947173: Speed up the symspell part of ingest

For certain data, and certain data set sizes, merging the suggestion
arrays used by the symspell algorithm is noticably expensive.  This is
the case for suggestion arrays containing many thousands of entries.
These suggestion sets are not only slow, but generally not useful.  We
avoid the creation of such overly long suggestion sets using several
word filters that take advantage of our knowledge of the incoming data
to optimize for what is useful in a bibliographic context.  The
mechanisms employed by this patch are:

- Omit suggestions whose length is longer than the max prefix key length
  when the prefix key length is less than or equal to the maximum prefix
  key length minus the maximum edit distance.
- Omit words that contain a run of 5 or more digits. This will drop most
  identifiers from the dictionary while still allowing suggestions to
  happen for year values.
- Omit empty keys from the dictionary.  This should have been the case
  already but is now enforced directly.
- Add a small speedup to evergreen.text_array_merge_unique() by making
  it assume that arrays passed to it do not have null values, which we
  intentionally avoid, and against which we protect in other ways in the
  commit.

Besides improving reingest speed, the patches will also make the
search.symspell_dictionary table significantly smaller.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: corrections to Hold Groups Admin doc

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: corrections to Library Groups Admin doc

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: 3.8 Release Notes updates

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

i18n: fix contruct in seed data that broken string extraction

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

update version tag for Antora

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1903358 Staff catalog holds barcode realtime lookup

Avoid requiring staff to send an Enter event (keyword / scanner) when
entering a patron barcode into the place holds form.  Instead, look the
barcode up after a sufficient amount of time has passed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

schema update script from 3.7.1 to 3.8-beta

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1846354: add another missed function update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1846354: add missing function updates to schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

add typo fix to release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: add acknowledgment to 3.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

3.8 release notes copy-editing and acknowledgment updates

Including typo fixes by Lisa Carlucci.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1826759: end DB update scripts with "COMMIT", not "END"

The former is what tools like make_release are looking
for.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

wipe the release note slate clean

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

check in first draft of release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1922567: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Lp 1922567: Limit authority.full_rec.value indexes

Limit the authority_full_rec_value_index and
authority_full_rec_value_tpo_index indexes to the first 1024
characters of a field or subfield in order to avoid database errors
when inserting or updating authorities with long fields.

Include release note and regression test.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Lp 1826759: Stamping Upgrade Script

Signed-off-by: Jason Stephenson <jason@sigio.com>

Lp 1826759: Fix Database Upgrade Script

Remove 2 extraneous updates, add a blank line between the remaining
updates, and add a placeholder the upgrade_deps_block_check().

Signed-off-by: Jason Stephenson <jason@sigio.com>

Lp 1826759: Spelling correction: oustanding to outstanding

Correct the spelling of "oustanding" to "outstanding" in the
descriptions of 3 config.org_unit_setting_type entries:

  * ui.circ.items_out.longoverdue
  * ui.circ.items_out.lost
  * ui.circ.items_out.claimsreturned

Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

Lp 1942920: Show Legacy/Not Dated for Legacy Circs

When legacy circ counts are displayed in the AngularJS client, the
year shows up as -1.  This patch attempts to replace -1 with a
translatable string: "Legacy/Not Dated" as was used in the XUL staff
client.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1928258: update pgTAP regression test

Now that update_bib_editor is split out into a separate
merge profile field, need to account for that in the regression
test for 1447746.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1864516: (follow-up) install current version of function

Fixes a regression that caused bib record saves to fail

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1919465: fix issue with DB rev stamping

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1919465: stamp upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1919465 Pull list only shows holds with current_copy

This avoids a scenario where copy-level holds would appear in the pull
list even if they are not pull-able, because they have "a copy" (i.e.
the requested copy), but no current copy (i.e. targeted copy).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1919465 Avoid dupe Current Item's in pull list

* Show a value for Current Item when a hold is targeted
* Show a value for a new column on Requested Item for copy-level holds.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1919465 Pull List Mark Discard/Weed Action

Includes general purpose discard/weed dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1919465 Relabel Item Location -> Shelving Location

Rename various "Item Location ..." references to "Shelving Location ..."
in the Angular holds grids.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1919465 Pull list detail show record summary

Display the bib record summary when displaying the hold detail view from
the holds pull list.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1919465 Pull list prefix/suffix sorting; columns

* Include call number prefix and suffix in hold pull list sorting.
* Apply sane default grid columns.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1919465 Fix default holds pull list sorting

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1919465 Holds pull list Angular / Wide Holds API Port

Ports the holds pull list to Angular and takes advantage of the new Wide
Holds API.  Includes seed data for grid preferences and a new holds pull
list (server) print template.

The UI displays the total holds count and includes a org unit selector.
It pre-fetches all holds, partly to display the full count, but also
based on the assumption that a pull list will typically be used all or
none.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1944765: add headers to bullseye install script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1944765: enable the Apache module mod_headers

This patch enables mod_headers for Debian Stretch and Buster
and Ubuntu Bionic and Focal during installation. Without
mod_headers, the Angular staff client application can have
its index page cached for 24 hours on a stock system, meaning
that browsers will not consistently fetch the updated app
after an upgrade.

This patch does not change the Fedora Makefile as mod_headers
is enabled by default on RHEL-like distributions.

UPGRADE NOTES
-------------
Existing Evergreen systems on Debian and Ubuntu should
do the following to ensure that mod_headers is active:

sudo a2enmod headers
sudo systemctl restart apache2

To test
-------
[1] Perform a fresh installation of Evergreen on Stretch, Buster,
    Bionic, or Focal.
[2] Verify that mod_headers is enabled.
[3] (Optional) Fetch the Angular staff client index page, e.g.,
    /eg2/staff, and verify that the response headers call for
    not caching it.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1834258 Replace Javascript with Placeholder Attribute

onfocus/onblur javascript replaced with placeholder="[% seed %]" in
Open-ILS/src/templates/kpac/getit.tt2 and
Open-ILS/src/templates/kpac/parts/searchbox.tt2

Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1881012 Typo in staff/circ/hold/app.js

Fixes 'legnth' typo.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1848575 Angular boolean filters should use Yes/No

Changes the filter options for boolean values to Yes/No instead of True/False.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1901597: Stamp upgrade scripts

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1901597: Allow multi-subfield match in vandelay.strip_field

Now, when supplying a subfield match restriction for use with
vandelay.strip_field, you can separate multiple restrictions with '&&'
(no quotes).  For instance, to remove a Located URI 856 for for a
combination of a specific owner and a specific domain, you might say:

 856[u~oldservice.com && 9~MYLIB]

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1940146: Debian Bullseye Installation Support

Update documentation and prerequisite installation Makefiles to add
support for Debian Bullseye (11.0).

Use PKG_CHECK_MODULES instead of AC_CHECK_PROG to test for the
presence of yaz.  This is done because of the following Changelog
entry:

    yaz-config and its man page are no longer packaged.  Please switch
    to pkg-config (yaz, yaz-icu or yaz-server).  This also makes the
    package reproducible.  Closes: #955501

This change works on all currently supported Evergreen distros.  You
can test it by running autoreconf -f and then running the normal
configure command.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Lp1940145: Remove Installation Support for Debian Jessie

Remove references to Debian Jessie (8.0) in the installation and
upgrade documentation as well as from the prerequisite installation
Makefiles.  Debian 8 has been out of long term support for over a year
at this point.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1850156: Remove Browsers From *-developer Targets

Because the developer targets are currently necessary for a from-git
installation, both Firefox and Chrome are removed and the docs updated
to note that you should install one or both if you want to run the tests.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1938729 Cache "cascade" setting values

Cache values retrieved from 'open-ils.actor.settings.retrieve' lookups
in IndexedDB, similar to to org unit setting lookups, to reduce the need
for so many API calls for settings retrieval.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP1909144 BooPAC Login Form Tabbing

This change places the cursor in the user name field and adjusts the order
of the elements so that tabbing out of the user name field comes to the
password field next.

Note that this modifies both the login modal and the embedded login form.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP1928258: Correct Upgrade Script

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#1924562 - pingest.pl help typo for --max-duration

In the help command example the argument --duration is used but
--max-duration is the correct command.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP1911023 Batch hold cancel refreshes before completion

Ensure all hold cancelation promises complete before reporting the
results back to the caller.  Issue was result of thinko in the code
that failed to relay one of the promises in the chain, so it reported
promise completion prematurely.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

Lp 1899974: Export PERL5LIB in oils_ctl.sh

A change in Perl release 5.26.0 necessitates that the SIP_DIR variable
(default value "/opt/SIPServer") be exported to the environment in
oils_ctl.sh when attempting to start SIPServer.  This change affects
Ubuntu 18.04 (Bionic Beaver) and Debian 10 (Buster) and any future
releases.

To verify the bug:

1. Install OpenSRF, Evergreen, and SIPServer on an affected O/S.
2. Start OpenSRF service.
3. Start SIPServer via oils_ctl.sh:
   oils_ctl.sh -a start_sip
4. Notice the "Starting OILS SIP Server" message is printed with no
   indication of failure.
5. Verify that the PID file exists: /openils/var/run/oils_sip.pid
6. Verify that no SIPServer processes are actually running:
   pgrep -af SIPServer
   The above should produce no output.

To test this patch:

1. Apply this patch and install oils_ctl.sh to /openils/bin/.
2. Assuming you have run the previous steps, delete the PID file:
   rm /openils/var/run/oils_sip.pid
3. Start SIPServer via oils_ctl.sh:
   oils_ctl.sh -a start_sip
4. Notice the "Starting OILS SIP Server" message is printed.
5. Verify that the PID file exists: /openils/var/run/oils_sip.pid
6. `pgrep -af SIPServer` should produce output.

It is safe to apply this patch on an unaffected O/S.  Explicitly
adding SIP_DIR to PERL5LIB will have no detrimental effect on any O/S
currently supported by Evergreen.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#1928275: fix the Angular "Copy Queue To Bucket"

Similar to bug 1934184, a blank routerLink on an anchor no longer
causes an ngbModal to open via a click handler.

To test
-------
[1] Create a MARC import bib queue that has at least one imported
    record it.
[2] Click the "Copy Queue To Bucket" link from the queue inspection page
    and observe that nothing happens.
[3] Apply the patch and repeat step 2. This time, the add-to-bucket dialog
    should appear.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP1924621 Place Hold For shows pref name

In the staff catalog banner which displays when a hold is being placed
for a pre-selected patron.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP1924621 Staff catalog place hold screen preferred name

Displays the preferred first or last name on the place holds screen,
if a patron barcode is entered.

To test.
1. Set up a borrower with a preferred first name, and one with a
preferred last name, and one with both.
2. Use the catalog place hold screen to search for these borrowers
and notice that the preferred names, if available, are displayed.

* note newline added by Bill to break up wide column.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

Revert "Docs: added receipt contents references."

This reverts commit 649d81b06ecee12324d3a4c604ea20451c3fea85.