working/Evergreen.git
5 years agoexact/prefix searches continued
Bill Erickson [Mon, 9 Sep 2019 19:01:43 +0000 (15:01 -0400)]
exact/prefix searches continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoelastic service continued
Bill Erickson [Mon, 9 Sep 2019 16:26:27 +0000 (12:26 -0400)]
elastic service continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoelastic-builder / marc search
Bill Erickson [Fri, 6 Sep 2019 22:10:45 +0000 (18:10 -0400)]
elastic-builder / marc search

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoelastic-builder in action
Bill Erickson [Fri, 6 Sep 2019 20:36:38 +0000 (16:36 -0400)]
elastic-builder in action

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoelastic bib field IDL class mod
Bill Erickson [Fri, 6 Sep 2019 18:43:49 +0000 (14:43 -0400)]
elastic bib field IDL class mod

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agomore catalog integration experiements / elastic-builder
Bill Erickson [Fri, 6 Sep 2019 14:37:38 +0000 (10:37 -0400)]
more catalog integration experiements / elastic-builder

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agotighter catalog integration WIP
Bill Erickson [Tue, 3 Sep 2019 21:29:42 +0000 (17:29 -0400)]
tighter catalog integration WIP

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agotighter catalog integration WIP
Bill Erickson [Tue, 3 Sep 2019 19:24:05 +0000 (15:24 -0400)]
tighter catalog integration WIP

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoinitial tighter catalog integration / cat side needs more data
Bill Erickson [Fri, 30 Aug 2019 16:26:04 +0000 (12:26 -0400)]
initial tighter catalog integration / cat side needs more data

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoadd label to bib_fields list
Bill Erickson [Fri, 6 Sep 2019 14:41:29 +0000 (10:41 -0400)]
add label to bib_fields list

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoadditional index tidying
Bill Erickson [Fri, 6 Sep 2019 14:35:40 +0000 (10:35 -0400)]
additional index tidying

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoadditional index tidying
Bill Erickson [Thu, 5 Sep 2019 19:59:18 +0000 (15:59 -0400)]
additional index tidying

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoinitial support multiple lang analyzers; multi_match queries
Bill Erickson [Thu, 5 Sep 2019 16:42:18 +0000 (12:42 -0400)]
initial support multiple lang analyzers; multi_match queries

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoUpdated example search in test script
Bill Erickson [Thu, 5 Sep 2019 15:52:47 +0000 (11:52 -0400)]
Updated example search in test script

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoadd marc data to bib search index
Bill Erickson [Tue, 3 Sep 2019 21:33:19 +0000 (17:33 -0400)]
add marc data to bib search index

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoConsolidate some indexing code
Bill Erickson [Fri, 30 Aug 2019 21:08:31 +0000 (17:08 -0400)]
Consolidate some indexing code

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agobib marc record index / searching
Bill Erickson [Wed, 28 Aug 2019 21:41:39 +0000 (17:41 -0400)]
bib marc record index / searching

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agobib marc record index / searching
Bill Erickson [Wed, 28 Aug 2019 16:16:17 +0000 (12:16 -0400)]
bib marc record index / searching

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agobib marc record index
Bill Erickson [Tue, 27 Aug 2019 21:50:47 +0000 (17:50 -0400)]
bib marc record index

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agosupport es proxied path; indexes one at a time
Bill Erickson [Thu, 18 Jul 2019 19:20:13 +0000 (15:20 -0400)]
support es proxied path; indexes one at a time

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agodata sync continued / _id fix
Bill Erickson [Tue, 9 Jul 2019 14:31:04 +0000 (10:31 -0400)]
data sync continued / _id fix

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoworking on data sync
Bill Erickson [Mon, 8 Jul 2019 22:12:16 +0000 (18:12 -0400)]
working on data sync

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agodisabled marc indexer experiment
Bill Erickson [Mon, 8 Jul 2019 14:46:20 +0000 (10:46 -0400)]
disabled marc indexer experiment

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoRemove some TODO comments: done
Bill Erickson [Tue, 2 Jul 2019 20:51:13 +0000 (16:51 -0400)]
Remove some TODO comments: done

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoEL sample config superseded by per-index definitions
Bill Erickson [Fri, 31 May 2019 18:51:50 +0000 (14:51 -0400)]
EL sample config superseded by per-index definitions

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoforce-on ang7 cat for now
Bill Erickson [Tue, 12 Feb 2019 17:40:30 +0000 (17:40 +0000)]
force-on ang7 cat for now

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoAvoid huge index values
Bill Erickson [Tue, 12 Feb 2019 17:02:36 +0000 (17:02 +0000)]
Avoid huge index values

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLog first/last bib ID of each indexed batch
Bill Erickson [Mon, 11 Feb 2019 19:05:01 +0000 (14:05 -0500)]
Log first/last bib ID of each indexed batch

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoIndexer orders by ID for batch consistency
Bill Erickson [Mon, 11 Feb 2019 17:11:10 +0000 (12:11 -0500)]
Indexer orders by ID for batch consistency

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoindexer start-date support
Bill Erickson [Tue, 6 Nov 2018 15:52:59 +0000 (10:52 -0500)]
indexer start-date support

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoES gets child init
Bill Erickson [Tue, 6 Nov 2018 15:20:02 +0000 (10:20 -0500)]
ES gets child init

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agocopy loc/stat filters
Bill Erickson [Tue, 6 Nov 2018 02:21:50 +0000 (21:21 -0500)]
copy loc/stat filters

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agocopy loc/stat filters wip
Bill Erickson [Mon, 5 Nov 2018 22:21:09 +0000 (17:21 -0500)]
copy loc/stat filters wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoGroup searches OR-based; lower kw normalizer
Bill Erickson [Fri, 2 Nov 2018 20:56:37 +0000 (16:56 -0400)]
Group searches OR-based; lower kw normalizer

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoQP comp continued
Bill Erickson [Fri, 2 Nov 2018 18:48:55 +0000 (14:48 -0400)]
QP comp continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoang6 catalog use correct search_format filter
Bill Erickson [Wed, 31 Oct 2018 21:34:07 +0000 (17:34 -0400)]
ang6 catalog use correct search_format filter

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoQP based query compilation
Bill Erickson [Wed, 31 Oct 2018 21:30:43 +0000 (17:30 -0400)]
QP based query compilation

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agosearch_format filter; logging
Bill Erickson [Tue, 30 Oct 2018 15:07:04 +0000 (11:07 -0400)]
search_format filter; logging

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agofacets continued
Bill Erickson [Tue, 30 Oct 2018 14:51:46 +0000 (10:51 -0400)]
facets continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agobib search api wip
Bill Erickson [Mon, 29 Oct 2018 22:17:01 +0000 (18:17 -0400)]
bib search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agobib search api wip
Bill Erickson [Mon, 29 Oct 2018 22:02:32 +0000 (18:02 -0400)]
bib search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agobib search api wip
Bill Erickson [Mon, 29 Oct 2018 22:01:38 +0000 (18:01 -0400)]
bib search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoIndexer improvements, docs, and options
Bill Erickson [Mon, 29 Oct 2018 17:58:27 +0000 (13:58 -0400)]
Indexer improvements, docs, and options

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agofacets, etc.
Bill Erickson [Sat, 27 Oct 2018 14:31:46 +0000 (10:31 -0400)]
facets, etc.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoel conf idl fields, etc.
Bill Erickson [Fri, 26 Oct 2018 18:00:25 +0000 (14:00 -0400)]
el conf idl fields, etc.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agouse existing indexed values; refactoring
Bill Erickson [Fri, 26 Oct 2018 15:43:38 +0000 (11:43 -0400)]
use existing indexed values; refactoring

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agouse existing indexed values
Bill Erickson [Fri, 26 Oct 2018 01:17:43 +0000 (21:17 -0400)]
use existing indexed values

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agobib-search indexing; search api wip
Bill Erickson [Wed, 24 Oct 2018 21:42:28 +0000 (17:42 -0400)]
bib-search indexing; search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agobib-search indexing; search api wip
Bill Erickson [Wed, 24 Oct 2018 19:20:53 +0000 (15:20 -0400)]
bib-search indexing; search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agobib-search indexing; search api wip
Bill Erickson [Wed, 24 Oct 2018 15:37:37 +0000 (11:37 -0400)]
bib-search indexing; search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agobib-search indexing wip
Bill Erickson [Wed, 24 Oct 2018 14:36:56 +0000 (10:36 -0400)]
bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agobib-search indexing wip
Bill Erickson [Tue, 23 Oct 2018 22:18:24 +0000 (18:18 -0400)]
bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agobib-search indexing wip
Bill Erickson [Tue, 23 Oct 2018 14:57:11 +0000 (10:57 -0400)]
bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agobib-search indexing wip
Bill Erickson [Mon, 22 Oct 2018 23:31:28 +0000 (19:31 -0400)]
bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agobib-search indexing wip
Bill Erickson [Mon, 22 Oct 2018 21:09:56 +0000 (17:09 -0400)]
bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agojson config for now; index create/delete
Bill Erickson [Mon, 22 Oct 2018 20:46:04 +0000 (16:46 -0400)]
json config for now; index create/delete

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoES/EG SQL
Bill Erickson [Mon, 22 Oct 2018 16:43:55 +0000 (12:43 -0400)]
ES/EG SQL

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLP#1843599: AngularJS MARC editor once again sets bib source
Galen Charlton [Fri, 20 Dec 2019 17:40:34 +0000 (12:40 -0500)]
LP#1843599: AngularJS MARC editor once again sets bib source

This patch fixes a regression introduced by the patch for bug 1693580
that prevent changes to the bib source from being made via the AngularJS
MARC editor.

To test
-------
[1] Apply the patch.
[2] Create a new bib record and save it with a non-empty source. Verify
    that the record sets the source as expected.
[3] Edit a bib record and change the source. Verify that the new source
    is retained when the record is saved.
[4] Edit an authority record and save it. Verify that it can be updated
    without error. (Note that authority records do not have sources in
    the same way that bib records do.)

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Rogan Hamby <rhamby@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
5 years agoLP#1855329: Hold shelf query speed problem
Mike Rylander [Thu, 5 Dec 2019 20:12:57 +0000 (15:12 -0500)]
LP#1855329: Hold shelf query speed problem

In bug 1827250 I suggested Jason Stephenson look at an alternate SQL
formulation to solve the original problem. He did, and deemed it faster,
so went with that. Unfortunately, on PG 9.6, we're seeing some data sets
that decide on a /very/ poor plan for the wide-hold query with the
solution as implemented, but the original suggestion from Jason works
fine.

In the face of evidence controverting my thought that giving PG more
options for planning is better in this case, this commit moves to his
original query change.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1858138: (follow-up) flesh creator and editor in sandbox's acp grid
Galen Charlton [Fri, 3 Jan 2020 16:02:29 +0000 (11:02 -0500)]
LP#1858138: (follow-up) flesh creator and editor in sandbox's acp grid

Doing so ensures that the usrnames are displayed in the respective
grid columns rather than the au ID.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLP#1858138: remove remaining uses of showLinkSelector
Galen Charlton [Fri, 3 Jan 2020 15:35:56 +0000 (10:35 -0500)]
LP#1858138: remove remaining uses of showLinkSelector

Now that showLinkSelector is deprecated and does nothing,
remove current uses of it.

To test
-------
[1] Apply the patch.
[2] Visit Angular admin interfaces that have grids that
    refer to linked IDL classes, e.g.,

    - Local Admin -> Carousels (carousel type)
    - Server Admin -> Weights Association (circ weights and hold
                                           weights)
    - Local Admin -> Item Tags (copy tag type)
    - Acq Admin -> EDI Accounts (provider)

[3] Verify that the columns for linked fields display the
    appropriate selector field rather than the numeric ID.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLP1858138 Sandbox example of simple grid filtering
Bill Erickson [Thu, 2 Jan 2020 21:31:31 +0000 (16:31 -0500)]
LP1858138 Sandbox example of simple grid filtering

Adds a trimmed down grid example demonstrating consistent filtering and
link selector display for auto and manual fields without requiring any
additional grid markup to define basic column behevior.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1858138 Link selector consolidation/repairs
Bill Erickson [Thu, 2 Jan 2020 21:28:46 +0000 (16:28 -0500)]
LP1858138 Link selector consolidation/repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1858138 Grid IDL field definition repairs and more
Bill Erickson [Thu, 2 Jan 2020 21:22:34 +0000 (16:22 -0500)]
LP1858138 Grid IDL field definition repairs and more

* Deprecate showLinkSelectors, since FormatService now performs that
  logic under the covers.  Includes deprecation console warning.

* Fix Grid field IDL class extraction off-by-one error.  The code was
  stamping the source field with the class of the field's link target
  instead of the class the field actually belonged to.

* Allow for IDL field info extraction from the 'name' attribute when no
  'path' attribute is defined.

* Avoid console errors when clearing combobox values in grid filters.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1858138 Link selector consolidation/repairs
Bill Erickson [Thu, 2 Jan 2020 21:17:59 +0000 (16:17 -0500)]
LP1858138 Link selector consolidation/repairs

Move more of the IDL link class selector extraction logic into the IDL
service.

Avoid using 'name' as a fall-through selector field when no 'name' field
exists on the class.

Teach the idl service to log warnings on invalid class and field name
combinations in selector lookups.

Modify fm-editor and combobox to use the new idl link selector
functions.

While we're in there, avoid unnecessary API calls from the combobox
by preventing async data lookups with a search term of "_CLICK_".

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1858138 Action/Trigger IDL selector additions
Bill Erickson [Thu, 2 Jan 2020 20:19:16 +0000 (15:19 -0500)]
LP1858138 Action/Trigger IDL selector additions

Adds selector field entries for Action/Trigger hook, collector,
validator, reactor, and cleanup classes for ease of admin page building.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1857156: handle HHH:MM:SS durations in loans
Galen Charlton [Fri, 20 Dec 2019 17:55:16 +0000 (12:55 -0500)]
LP#1857156: handle HHH:MM:SS durations in loans

This patch fixes a problem where loan durations of the form
HHH:MM:SS, where the hours component is longer than 2 digits, could
cause checkouts to fail. This sort of duration has been observed
in cases where a library wanted a long-term reserves loan that
doesn't have the due time bumped up to midnight.

To test
-------
[1] Set up a circulation policy that has a loan duration of 167:59:59.
[2] Attempt a checkout that uses that policy. Note that the checkout
    will fail.
[3] Apply the patch and repeat step 2. This time, the checkout should
    succeed.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
5 years agoLP1858118 Hatch enabled check repairs
Bill Erickson [Tue, 12 Nov 2019 20:13:39 +0000 (15:13 -0500)]
LP1858118 Hatch enabled check repairs

Teach code asking Hatch whether printing is enabled to properly handle
the asynchronous response of the setting which now exists as a
workstation setting instead of a localStorage setting.

Related, if Hatch is unavailable, use browser printing regardless of the
hatch printing workstation setting.

Additionally update the "reprint last" handling to store the
last_printed value in localStorage instead of attempting to save its
value as a workstation setting.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoDocs: Fixing asciidoc syntax so fop doesn't complain about staff client admin manual
Jane Sandberg [Mon, 30 Dec 2019 22:50:47 +0000 (14:50 -0800)]
Docs: Fixing asciidoc syntax so fop doesn't complain about staff client admin manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoDocs: LP1767378 follow up: adding manual anchor
Jane Sandberg [Mon, 30 Dec 2019 22:24:58 +0000 (14:24 -0800)]
Docs: LP1767378 follow up: adding manual anchor

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoDocs: fixed a spacing issue
lfloyd [Mon, 23 Dec 2019 17:53:04 +0000 (12:53 -0500)]
Docs: fixed a spacing issue

Signed-off-by: Lynn Floyd <lfloyd@library.in.gov>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoDOCS: LP 1767378 Work Log documentation
lfloyd [Mon, 23 Dec 2019 16:25:40 +0000 (11:25 -0500)]
DOCS: LP 1767378 Work Log documentation

Updated Work Log documentation with new image.
Deleted old image files, noted which holds log.

Signed-off-by: Lynn Floyd <lfloyd1@library.in.gov>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoLP#1855931: (follow-up) make grid filter control cells wrap as well
Galen Charlton [Fri, 27 Dec 2019 21:45:42 +0000 (16:45 -0500)]
LP#1855931: (follow-up) make grid filter control cells wrap as well

This patch applies "word-wrap: normal" to filter control cells
as well, making it more likely that they will stay aligned with
the width of their corresponding header cells. This can be tested
by adding visible columns to the "Grid with filtering" table in
the Angular sandbox (/eg2/en-US/staff/sandbox) and verifying that
the column after "Circulating Library" continues to have its
filter widget stay aligned with its label.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agolp1855931 wrap text for wide Angular eg-grid column headers
Mike Risher [Tue, 10 Dec 2019 23:15:35 +0000 (23:15 +0000)]
lp1855931 wrap text for wide Angular eg-grid column headers

Make column headers text wrap so that you can fully read the header even if
it's several words long.  This will help when there are multiple headers
that start with the same word and they show up identically.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoLP#1857350: (follow-up) fix lint issue
Galen Charlton [Fri, 27 Dec 2019 22:50:08 +0000 (17:50 -0500)]
LP#1857350: (follow-up) fix lint issue

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLP1857350 Org selector sorts by display value
Bill Erickson [Thu, 26 Dec 2019 18:18:26 +0000 (13:18 -0500)]
LP1857350 Org selector sorts by display value

When displaying the org unit selector, sort each set of children by the
display label (defaults to shortname).

Fixes issues with the org server sortTree function and adds a unit test
to test the repaired sort function.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agolp1843640 Standing Penalty Followup
Mike Risher [Fri, 13 Sep 2019 21:53:42 +0000 (21:53 +0000)]
lp1843640 Standing Penalty Followup
Fix 2 issues:  grid not updating when a new record is created and
double clicking a row doesn't edit it

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/standing-penalty.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/standing-penalty.component.ts

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1848778 Use consistent MARC breaker delimiter
Bill Erickson [Fri, 18 Oct 2019 17:47:17 +0000 (13:47 -0400)]
LP1848778 Use consistent MARC breaker delimiter

Use the '$' delimiter in the read-only MARC breaker view for
consistency with the flat text MARC editor to easy copy/paste from one
to the other.

To test
-------
[1] Apply the patch.
[2] Set up two records in a record bucket and initiate a merge. Note
    that when you select a lead record and choose to edit it in
    flat text mode, you can copy and paste fields from the subordinate
    record display without having to change the subfield delimiter
    character.
[3] Mark a record for overlay, perform a Z39.50 search, then select
    a hit and choose the overlay action. Note that you can copy and
    paste fields from the record to overlay when editing the incoming
    record using the flat text editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1780283 Checking One Bill Checks Them All
Dan Briem [Fri, 9 Aug 2019 03:45:40 +0000 (23:45 -0400)]
LP#1780283 Checking One Bill Checks Them All

Under Patron->Bills->History if Bill # isn't visible for the Transactions
grid or Payment ID isn't visible for Payments grid, rows can't be selected
individually. This adds the required attribute to those field directives.

1. Under a patron account with multiple bills, go to Bills->History
2. Remove Bill # from the Transactions grid
3. Try to select an individual row (note all rows are selected)
4. Apply patch and repeat steps 1-3 (note rows are selected individually)

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agolp1712644 Prevent check out due date in past
Katlyn Beck [Mon, 26 Nov 2018 21:23:48 +0000 (21:23 +0000)]
lp1712644 Prevent check out due date in past

- Prevents selecting past due date when checking out an item
- Prevents saving a due date with hatch when input date is invalid

Signed-off-by: Katlyn Beck <kbeck@catalyte.io>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1857710: fix Angular client whitescreen on Firefox
Galen Charlton [Fri, 27 Dec 2019 18:21:15 +0000 (13:21 -0500)]
LP#1857710: fix Angular client whitescreen on Firefox

Work done for LP#1830391 added an instance of a Javascript
regexp replace using the dotAll ("/s") flag, but as of the moment
Firefox treats that flag as a fatal syntax error, breaking the
Angular staff client.

To test
-------
[1] Attempt to log in the Angular staff client with Firefox. Note
    that you get a whitescreen with the following in the browser
    console:

    SyntaxError: invalid regular expression flag s
[2] Apply the patch and repeat step 1. This time, the Angular
    staff client should work normally.
[3] Verify that the Angular unit tests pass.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
5 years agoLP#1827942: follow-up to fix a couple issues
Galen Charlton [Fri, 27 Dec 2019 16:04:32 +0000 (11:04 -0500)]
LP#1827942: follow-up to fix a couple issues

[1] Sets a default value for the modal options for dialogs such
    as ProgressDialog that do not supply any value for the
    options parameter; otherwise, progress dialogs would not
    appear at all.
[2] Fix lint warnings.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agolp1827942: prevent clicking outside an Angular modal from closing it
Zavier Banks [Tue, 17 Sep 2019 20:59:15 +0000 (20:59 +0000)]
lp1827942: prevent clicking outside an Angular modal from closing it

I added a new property to the "options" object inside the "open"
function, which resides in the dialog.component.ts. The static string
inside the backdrop property makes the form stay, even if the backdrop
is clicked.

Signed-off-by: Zavier Banks <zbanks@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoFix doc build for glossary
Dan Scott [Sun, 15 Dec 2019 15:53:33 +0000 (10:53 -0500)]
Fix doc build for glossary

asciidoctor was throwing the error "invalid part, must have at least one
section (e.g., chapter, appendix, etc.)"; including [appendix] in front
of the include mollified it.

Also we don't need the duplicated Glossary / Glossary headings.

Signed-off-by: Dan Scott <dan@coffeecode.net>
5 years agoLP1830391 Stamping DB upgrate (hatch omnibus)
Bill Erickson [Fri, 13 Dec 2019 19:27:16 +0000 (14:27 -0500)]
LP1830391 Stamping DB upgrate (hatch omnibus)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLP1830391 Angular test spec updates for Hatch store updates
Bill Erickson [Fri, 13 Dec 2019 19:13:40 +0000 (14:13 -0500)]
LP1830391 Angular test spec updates for Hatch store updates

The store service now leverages Hatch for workstation storage.  Update
unit tests which load the store service to also load and propagate the
Hatch service.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLP1830391 Warn on dupe workstation settings user/jboyer/lp1830391_signoff
Bill Erickson [Thu, 12 Dec 2019 21:47:31 +0000 (16:47 -0500)]
LP1830391 Warn on dupe workstation settings

Check for duplication workstations (by name and workstation) before
applying the UNIQUE constraint on actor.workstation_setting.  If found,
raise a notice to the user to provide suggestions.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
5 years agoLP1830391 Angular Hatch enabled flag lookup repair
Bill Erickson [Mon, 28 Oct 2019 17:53:46 +0000 (13:53 -0400)]
LP1830391 Angular Hatch enabled flag lookup repair

Fix the Angular Hatch enabled setting lookup to pull the value from the
workstation setting instead of localStorage.  This required shuffling a
few things around to support the asynchronicity.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
5 years agoLP1830391 Hatch core mod import/export repairs
Bill Erickson [Mon, 5 Aug 2019 14:44:55 +0000 (10:44 -0400)]
LP1830391 Hatch core mod import/export repairs

No need to import/export HatchService from the base common module since
it's now a core service which is exported automatically to root.

Includes minor lint repair.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
5 years agoLP1830391 Workstation settings unique constraint
Bill Erickson [Thu, 23 May 2019 22:02:41 +0000 (18:02 -0400)]
LP1830391 Workstation settings unique constraint

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
5 years agoLP1824391 Hatch File Writer release notes
Bill Erickson [Fri, 12 Apr 2019 19:47:24 +0000 (15:47 -0400)]
LP1824391 Hatch File Writer release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
5 years agoLP1824391 Hatch print-to-file Angular edition
Bill Erickson [Mon, 15 Apr 2019 15:34:21 +0000 (11:34 -0400)]
LP1824391 Hatch print-to-file Angular edition

Adds support for the Angular hatch service for sending 'bare' text/plain
print-to-file requests.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
5 years agoLP1824391 Hatch File Writer print support
Bill Erickson [Fri, 12 Apr 2019 16:52:09 +0000 (12:52 -0400)]
LP1824391 Hatch File Writer print support

Adds support for translating receipt data to plain text and writing the
output to a file instead of sending it to a printer.

Adds a new stock printer named "Hatch File Writer" to the print
configuration interface.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
5 years agoLP1825891 Use Hatch 'hostname' for workstation reg.
Bill Erickson [Mon, 22 Apr 2019 21:02:05 +0000 (14:02 -0700)]
LP1825891 Use Hatch 'hostname' for workstation reg.

Populate the workstation name with the hostname of the PC when
registring a new workstation for Hatch-enabled workstations.

Note the code gracefully returns null if Hatch returns a 404 (not found)
or Hatch is not active.

Updates the AngJS and Angular workstation admin pages to load the
hostname value when possible.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
5 years agoLP1825896 Store workstations in Hatch when available
Bill Erickson [Tue, 23 Apr 2019 14:57:31 +0000 (07:57 -0700)]
LP1825896 Store workstations in Hatch when available

When Hatch is enabled, use Hatch for storing workstation registration
information.

If workstations are found in localStorage, they are merged into the
collection of workstations stored in hatch and removed from
localStorage.

Include DB udpate to add workstation setting 'eg.hatch.enable.printing'
so that it may live on the server.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
5 years agoDocs: Fix AsciiDoc syntax error in glossary
Remington Steed [Fri, 13 Dec 2019 13:22:17 +0000 (08:22 -0500)]
Docs: Fix AsciiDoc syntax error in glossary

This commit fixes a minor syntax problem that causes an AsciiDoc build
error.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoDocs: Added linkages, and additonal terms.
lfloyd [Fri, 6 Dec 2019 19:26:35 +0000 (14:26 -0500)]
Docs: Added linkages, and additonal terms.

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
5 years agoDocs: Glossary Added
Lynn [Wed, 27 Nov 2019 17:18:01 +0000 (12:18 -0500)]
Docs: Glossary Added

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
6 years agoLP#1803406 Due date box in check out has display issues at wider resolutions
Dan Briem [Wed, 7 Aug 2019 23:13:21 +0000 (19:13 -0400)]
LP#1803406 Due date box in check out has display issues at wider resolutions

Adjusted bootstrap .col classes so the specific due date input displays the
full date and prevents the barcode input group from collapsing at < 1179px.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP1830923 Replace some pesky tabs
Bill Erickson [Thu, 5 Dec 2019 15:08:48 +0000 (10:08 -0500)]
LP1830923 Replace some pesky tabs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>