webstaff: fix template ref for Holds for Bib Record

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: alphabetize entries on acq admin splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: improve column collapse on acq admin splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: improve column collapse on server admin splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: improve column collapse on local admin splash page

With this patch, when the local admin splash page is displayed
on small screens, the three columns are stacked better. E.g.,

A  D  G
B  E  H
C  F

becomes

A
B
C
D
E
F
G
H

rather than

A
D
G
B
E
H
C
F

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

add Print Bills to Bill History

FIXME: duplicated a code chunk, should probably refactor into a shared printBills
FIXME: disable actions or make otherwise obvious that they only work on selected rows

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: fix Payment Method in receipt

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: toast on volume/copy template save and delete

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: fix a couple thinkos is vol/copy template editor

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: tweaks to egPrint

This patch attempts to unbreak receipt and CSV printing
by fetching and injecting the print CSS into a style element,
as a link element in the print div doesn't seem to get
processed.  It also automatically clears the content
of the print div so that after you print a receipt, the
browser print command will print the page, not the receipt.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff transit list: switch to egGridFlatDataProvider

This gets us sorting "for free", or at least more easily than
with a custom-written data provider.  The following fields
are marked sortable for now:

- barcode
- title
- source library
- destination library
- send date/time

Because egGridFlatDataProvider gives us flattened hashes, not
fieldmapper objects, various tweaks were required to compensate.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

better idea with Check Number

unset default Check Number, disable widget if not Check Payment,
and disable Apply Payment button if Check Payment with invalid Check Number

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: default Check Number to 1

instead of 0, so that it doesn't speedbump payments (of any type)

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Allow system printing to work normally by delaying stylesheet inclusion

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

implement item attributes editor AKA volume/copy template editor

Add a specialization of the volume/copy editor that is restricted
just to managing volume/copy templates; this can be accessed
at the path /eg/staff/cat/volcopy/edit_templates.  A link is added
to the local administration splash page with the label "Volume/Copy
Template Editor"

In attempt to improve terminology, on the local administration page,
the previous "Copy Template Editor" is now called "Serial Copy Template
Editor".

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Put the toaster at the bottom right everywhere

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: CSS tweak for chrome/webkit

Specifically, in the Copy Location Group interface, make sure the disabled
position textbox in the New location group dialog is visible within Chrome.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: CSS tweak for chrome/webkit

Specifically, in the Copy Location Group interface, make sure the disabled org
selector in the New location group dialog is visible within Chrome.

This also happened with Custom Org Unit Trees, and if we run across it again,
I'll put more effort into injecting this more globally for the embedded Dojo
interfaces.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: CSS tweak for chrome/webkit

Specifically, for Custom Org Unit Trees, make sure the "OPAC" selection in the
disabled combobox is not too light to see in Chrome.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: implement patron merge interface

This patch adds a 'Merge Patrons' button to the patron
search grid. If the user selects two patron records, the
button can be clicked to present a dialog that allows
the user to pick a lead record and confirm a merge of the
patrons.

This patch also adds an egPatronSummary directive that
uses the existing patron summary template with a couple
modifications.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Protect XUL-ish code when not running under XULRunner

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

add limit and sorting to transit list fetch

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: provide login type options for operator change

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

changes to transit list interface

* convert barcode column to hyperlink to item status
  page (and remove the 'Item Status' action; note that
  default double-click action remains going to the
  item status page)
* convert title column to hyperlink to record details page
* add 'Add Items to Bucket' button
* add 'Edit Item Attributes' button

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Acquisitions Administration

FIXME:

* Acq Admin -> Distribution Formulas -> Formula Detail Page : render problem, no uncaught exceptions
* Acq Admin -> Funds : TypeError: openils.XUL.localStorage is not a function

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: various Acq menu entries

* Purchase Orders
* Create Purchase Order
* Claim-Ready Items
* Open Invoices
* Create Invoice

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Load MARC Order Records

FIXME:

TypeError: openils.XUL.localStorage is not a function
at vlagent.js:56

Having trouble working around this.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: various Acq menu entries

* My Selection Lists
* New Brief Record
* Patron Requests
* MARC Federated Search
* Load Catalog Record IDs

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

tweak to vlagent.js

Otherwise, within "General Search", we'll get this error:

TypeError: openils.XUL.localStorage is not a function from vlagent.js:6

FIXME: brittle workaround?

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: first Acq menu-entry and embedded UI

* General Search

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: tweaks to transit list

- filter out transits that have been received, thus matching
  previous XUL functionality
- remove the Receive Date/Time column, as it is superfluous
- display the time component of the Send Date/Time

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: implement some workstation preferences

- Default search library
- Preferred library
- Advanced search pane

Because AngularJS has no way of adding HTTP request headers to
user interactions with the contents of an iframe, the search
library and preferred library are passed to TPAC via two new
session cookies, eg_pref_lib and eg_search_lib.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Webstaff: implement Operator Change (and Operator Restore)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1467663 webstaff: login requires valid workstation

Hide the workstation selector when no workstations are registered.
After successful login, direct the user to the new workstation admin
page to create a new workstation.

After successful login with an invalid workstation, direct the user
to the workstation admin page, issuing a 'remove' command to un-register
the offending WS.  On the WS admin page, the user can create a new
workstation or select from their existing workstations.

Any attempt to access a browser client interface (minus the WS admin
page) without a valid workstation will cause the page to redirect to
the workstation admin page.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1467663 webstaff: dedicated workstation admin page

Adds a new standalone workstations admin page, accessible from the main
Workstation Administration page.

Adds the ability to delete a workstation by name both within the page
and via URL (with permission).

Fixes the "Use Now" button so that it actually logs the user out before
redirecting to the login page with the desired workstation
pre-selected.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

make egAudio respect eg.audio.disable

This patch also removes some console.debug noise.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Add reports menu option

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Supply a back link on tabular report output

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP1537214 Staff Initials in Patron Notes

Add Initials field to new note dialog when
Require Staff Initials option is active.  Notes with
initials will use the following format:
          "Note [Initials]"

Signed-off-by: Kyle Huckins <khuckins@catalystdevworks.com>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/circ/patron/t_new_note_dialog.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/app.js

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: consolidating some duplicate language

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Incorporating overlay/merge profiles documentation from Evergreen in Action + new 2.11 feature

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1621799: disable checkout for inactive patrons

Add search_barcode variable to patronSvc
Add function fetchedWithInactiveCard to patronSvc
Add check to disable checkout for fetchedWithInactiveCard

Signed-off-by: Billy Horn <bhorn@catalystdevworks.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1528916 Patron Holds Ready/Total

Switch order or patron_stats().holds.ready and
patron_stats().holds.total in t_summary and patron
index.

Signed-off-by: Kyle Huckins <khuckins@catalystdevworks.com>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/circ/patron/index.tt2
modified:   Open-ILS/src/templates/staff/circ/patron/t_summary.tt2

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: documenting new authority features

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

2.10.7-2.10.8 schema upgrade script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

update 2.10.8 release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

updates to 2.11.1 release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1488655: stamp schema upgrade script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1488655: fix MR remapping upon fingerprint change

This patch ensures that if the fingerprint of a bib changes, the
bib will be moved to a new metarecord as opposed to ending up
as a member of more than one metarecord.

To test
-------
[1] Note the metarecord that a bib belongs to.
[2] Change the bib so that its fingerprint changes -- with stock
    cbf settings, editing the 245$a should suffice.
[3] Note that it is now a component of two metarecords.
[4] Apply the patch.
[5] Repeat step 2 or force a reingest. The bib should now be part
    of exactly one metarecord.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1488655: regression test for metarecord remapping

This patch contains pgTAP tests for verifying that when
the fingerprint of a bib is changed, it remains part of
exactly one metarecord (as opposed to being part of both
its old and new MRs).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Docs: Adding 2.11.1 point release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: Adding 2.10.8 point release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1618183: more work backporting update to rel_2_10

This patch tries to ensure that if somebody running 2.10.8 (or a
later 2.10.x) attempts to upgrade to 2.11.1 or later  using the
monolithic version upgrade scripts, the presence of the es-ES locale won't
abort the 2.10.7-2.11.0 update.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1618183: placeholder schema update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

forward-port 2.10.7-2.11.0 schema update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1618183: make upgrade not die if es-ES locale already exists

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1615736: stamping schema update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1615736 - Add an index on the usr field of action.usr_circ_history.

Improve the performance of looking up a users circ history by adding
an index on action.usr_circ_history( usr ).

To test for performance improvements time doing a search for a particular
users history before and after the index is created.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1612873 - Fix text of notice message for history migration.

The notice text that was outputed for every 10000 circs processed
was labeled as users, which made the output confusing.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Revert "webstaff: add template for patron merge dialog"

Whoops, sorry.

This reverts commit afbda31bf6ffb065f3c1b1c85c0caddc0fcbc583.

webstaff: add template for patron merge dialog

This had been skipped by mistake.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP 1639250: Install Excel::Writer::XLSX from deb on Wheezy.

Change Open-ILS/src/extras/install/Makefile.debian-wheezy from the
deb, libexcel-writer-xlsx-perl, instead of via CPAN.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

LP#1640153 Fix abort-transit-copy-status.t perl test.

Fixes added by bug 1613374 changed the behavior of canceled
transits so that the test written for bug 1306666 stopped working.
Accounting for the new "Canceled Transit" status fixes the test.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

Fix purge_user_activity.pg live test

The purge_user_activity.pg test inserts rows into actor.usr_activity
in a random date order, but the changes in bug 1570909 created a trigger
that overwrites the previous entry for a transient type, causing the
test to fail.  We reorder the usr_activity rows so that the most recent
row will be in place.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP 1628966: View Temporary/My Lists from Record Summary

This commit adds a link to the record summary screen in the public
opac that allows access to a temporary list or, if logged in, all your
lists.

Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1638921 List display broken in 2.11

The badges feature added more data to an array which broke bib_record_list_via_search
Taking the first item in the array instead of the last item fixes the issue.
Thanks to miker and Dyrcona!

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Mike Rylander <miker@esilibrary.com>

lp1629075: Hide Permalink in Staff Client

This will hide the permalink in the staff client catalog.

Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1584807: Clicking column header should not unsort list

Clicking column headers in My Account cycled through ascending order,
descending order, and then unsorted. But unsorting a list after clicking a
header is unintutive to the user. Instead, it should toggle between ascending /
descending order.

Test plan
* Using the concerto dataset, log in as user 99999395984 / maes1234
* Go to the Items Out area of my account and click the title column header to
sort the list.
* The list will first sort alphabetically in ascending order, on a second click
will sort alphabetically in descending order, and, on a third click, will
return to the default sort order.
* After loading the patch, clicking the column header should only result in
sorting in ascending and descending order.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1620750 Prevent log warning for uninit var in checkin_retarget()

If the retarget_mode variable is not initialized, then a warning is generated
in the logs every time an item is checked in. Avoid the warning by
short-circuiting before testing the value in the regex.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1624491 Avoid uninit var prox_cache during holds processing

open-ils.circ was logging a prox_cache hash value before it is
guaranteed to have been initialized. Instead, log messages _after_ they
have been initialized.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1282751 Credit card payment balance owed rounding fix

Avoid using Perl's int() when summing owed/paid totals for display in
the TPAC credit card payment form, since this can lead to rounding
errors.

A simple example of why we should not use int() when summing floating
point numbers:

perl -e 'print "no match\n" unless ((8.29 * 100) == int(8.29 * 100))';

Furthermore, use the relatively new fpsum() utility function for summing
floating point numbers so we can avoid having multiple versions of the
summing logic floating (*cough*) around (*cough cough*).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Docs: Update base system requirements for Evergreen

These memory values are woefully out of date for modern Evergreen installations.

Recommending also at least 2 GB of RAM for client workstation, though honestly,
more is probably better there too.

Also adding specific Linux distributions supported by this community instead of
just Linux.

And dropping specific Windows versions (especially since two out of the three
are no longer supported by Microsoft).

Signed-off-by: Ben Shum <ben@evergreener.net>

Docs: add mpm_prefork config for Apache 2.4 systems

We had only documented the Apache 2.2 stanzas for mpm_prefork, so include a
section for 2.4 that uses MaxRequestWorkers and MaxConnectionsPerChild. Given
the memory leaks that we have seen, suggest lower settings for these two values
(assuming that most sites will be serving a public catalogue instead of using a
separate discovery layer).

Also fix the weird formatting where Debian instructions were indented under a
Fedora section.

Also use dots for ordered bullets instead of renumbering all of the bullets
again.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Docs: set up default action_trigger_filters.json file

Given that action_trigger_runner.pl looks by default for a file called
action_trigger_filters.json, instruct people to create that file when they are
first setting up their system.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

LP#1623955: Keep periods in subject links

The subject links in the record summary were stripping periods, changing
headings that contained N.Y., for example, to NY in the subsequent search
string. Since normalization at index time replaces the period with a space,
clicking the subject links did not successfully retrieve all relevant
results.

Test plan:
Click the Subject link for a record that has New York (N.Y.) in its heading and
has no other instances of ny in the keyword index. This record will not be
retrieved when you click the link. After loading the patch, the record will be
successfully retrieved, along with other records that contain New York (N.Y.) in
their subject headings.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1494750 - Extra closing curly bracket in style.css disables following css

Which is the .sort_deemphasize class, so the modification of the non-filing
characters never happens in the sort results.

Test Plan:

Needed: Patron account with checkout history that contains titles with
non filing characters.

Before change, view the checkout history and sort by title.  Note that the
leading non filing characters look the same as the rest of the title.

After change, view the checkout history and sort by title.  Note that the
leading non filing characters now have a different style than the rest
of the title.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1526159 Webstaff Items Out includes overdue, etc.

Items Out tally in patron summary (side-bar) is now consistent with the
Items Out value displayed along the top of the patron UI.  It now includes
overdues and optionally lost/claims-returned total.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1565009 Webstaff patron search progress bar

Displays a progress bar while waiting for results from a patron search
in the browser client.  Bar only displays when a server-side search is
required.  (It's not displayed for cached searches, etc.).  Results grid
is hidden while the progress bar is visible and vice versa.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1629029: Fixed missing space in line 11

Signed-off-by: Jim Keenan <jkeenan@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1618992 Webstaff checkin UI bib title link repair

Fix bib record title link in browser staff checkin grid so that clicking
on the link directs the user to the bib record page.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1618992 Webstaff checkin error handler repairs

Fix typo in browser staff checkin error handler which resulted in null
errors any time a checkin failed instead of gracefully handling the
error.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1618992 Work log checkin/user sanity checks

Avoid attempts to log user information during checkin when no user
information is available.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#802700 Sort funds by code and year

This commit applies Bill Erickson's change from bug #1227344 to the fund
selector that appears on the Selection List (picklist) screen when you click
"Copies" to reveal the line items table. (Bill also mentioned this in
bug #1266471.)

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Add a simple Item Information test for SIP server

Useful if you want to check the ability of the server to return Unicode
response.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Docs: Minor fixes for 2.11 Release Notes

Fixed a header level as well as some minor typos in the 2.11 release notes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Create/consolidate release notes for 2.11

Signed-off-by: Dan Wells <dbw2@calvin.edu>

small typo fix in 2.10 release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Forward port 2.9.7 to 2.9.8 db upgrade script.

Signed-off-by: Jason Stephenson <jason@sigio.com>

schema update script: 2.10.6 -> 2.10.7

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Docs: Adding 2.10.7 point release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: Adding 2.9.8 point release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: 2.11 Release Notes updates

Updates to the 2.11, including: adding a note about Ubuntu Xenial support,
adding acknowledgements for translators and for some who were missed in the
first iteration of Release Notes, slimming down the activity metric release
notes entry and moving the original, detail-rich entry to the TechRef directory.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1623541: Booking will fail if its router isn't called "router"

The circ code checks to see if the booking app is running, and if not, it
skips some booking-related logic. This is a useful performance enhancement
where booking is not in use. It does this by asking the OpenSRF router if
the "open-ils.booking" app has registered with it. Most of the time the
OpenSRF router will be called, unimaginatively, "router" but when it's not,
booking will not be considered by the circ module even if it's running.

Instead of assuming "router" we should simply look up the router's name.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Docs: improving documentation for catalog searching widgets

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1624846 Add charset declaration to TPAC print output

Non-ASCII characters were printed incorrectly in some browsers, such as
Firefox, that still default to ISO-8859-1 encodings in the absence of a
specifically declared encoding.

Our output encoding will always be UTF-8, so declare it.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1624025 - Add 'is_available' field to config::copy_status

The fix to bug 1464709 overlooked a necessary place to define
the newly added 'is_available' column to the config.copy_status
table.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

Docs: 2.11 release note fixes

2.11 release note entries edited for clarity, grammar, spelling and style.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: Adding acknowledgements to the 2.11 release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1620803 Add missing workstation passthru to AuthProxy

The AuthProxy.pm login function was not passing through a possible
'workstation' parameter to auth_internal's 'session.create' method.
Without this, all login's end up with a workstation set to the user's
home_ou, which can affect things including opt-in and transit
behaviors.

While not needed for the initial 'user.validate', it seems cleaner
and simpler to just bring it over when constructing the initial
$args hash.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>