evergreen/tadl.git
12 years agoChange the display of subjects in the sidebar
Jeff Godin [Mon, 23 Apr 2012 08:30:04 +0000 (04:30 -0400)]
Change the display of subjects in the sidebar

For the sidebar display of subjects, use one link per subject
item, not the "increasingly specific" multiple link style of
the record detail summary.

Also minor other formatting changes, such as using <li>. Change
to slot.parentNode reference for unHideMe.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoExtras as "tabs", hide some useless AC content
Jeff Godin [Mon, 23 Apr 2012 08:25:56 +0000 (04:25 -0400)]
Extras as "tabs", hide some useless AC content

Use a "tab" effect to bring more attention to extras such as
added content reviews, author notes.

Hide useless / duplicated content such as the title and author
in added content reviews (as returned by Syndetic Solutions).

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoOnly show series if there is content
Jeff Godin [Mon, 23 Apr 2012 06:49:40 +0000 (02:49 -0400)]
Only show series if there is content

Only show series if there is content available for that field.

Also, show series by default without need to select "More Info".

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoAdd subjects to sidebar
Jeff Godin [Mon, 23 Apr 2012 03:31:04 +0000 (23:31 -0400)]
Add subjects to sidebar

Add bibtemplate style subjects to the sidebar. Shows only in
record detail view, no apparent problems being present-but-
not-visible elsewhere.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoUpdate hardcoded tadlv3 paths to tadlv4
Jeff Godin [Mon, 23 Apr 2012 02:34:20 +0000 (22:34 -0400)]
Update hardcoded tadlv3 paths to tadlv4

Update hardcoded paths in files to reference tadlv4 instead
of tadlv3.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoFork tadlv3 skin to tadlv4 skin
Jeff Godin [Mon, 23 Apr 2012 02:19:24 +0000 (22:19 -0400)]
Fork tadlv3 skin to tadlv4 skin

Fork tadlv3 to tadlv4 to begin work.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agohs18738 checked for expired accounts with SIP
Jason Etheridge [Fri, 20 Apr 2012 11:29:14 +0000 (07:29 -0400)]
hs18738 checked for expired accounts with SIP

12 years agoFix link display even when no physical copies skin_tadlv3
Jeff Godin [Mon, 16 Apr 2012 20:18:21 +0000 (16:18 -0400)]
Fix link display even when no physical copies

This is a bugfix: We were failing to create any copy / uri
summary if there were zero physical copies. Now, instead of
"return", we "return output.innerHTML" to display the links
which have been generated previously (but not output).

At this time, we don't want to do that in the record detail
page, so we continue to bail there regardless.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoFix bug in copy summary display on detail page
Jeff Godin [Mon, 16 Apr 2012 17:40:39 +0000 (13:40 -0400)]
Fix bug in copy summary display on detail page

Copy summaries with multiple libraries were having their
list of libraries overwritten by the last library in the
list.

Thanks to wjr for noting the issue. This fixes it by moving
a mis-placed curly brace.

Previous commit fixed search results but not record detail.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoFix bug in copy summary display
Jeff Godin [Mon, 16 Apr 2012 16:52:31 +0000 (12:52 -0400)]
Fix bug in copy summary display

Copy summaries with multiple libraries were having their
list of libraries overwritten by the last library in the
list.

Thanks to wjr for noting the issue. This fixes it by moving
a mis-placed curly brace.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoUse available copy summary in record detail page
Jeff Godin [Mon, 16 Apr 2012 14:47:49 +0000 (10:47 -0400)]
Use available copy summary in record detail page

Having removed the copy info matrix/table from the record detail
page, we now replace it with the new available copy summary from
the search results page.

When there are copies at multiple libraries, display a total
count of available copies at each library.

When there are copies available at only one library (which also
happens when search is scoped to one library), display a count
of available copies grouped by copy shelving location and call
number label.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoCopy summary group by call number, add max_lines
Jeff Godin [Mon, 16 Apr 2012 14:39:34 +0000 (10:39 -0400)]
Copy summary group by call number, add max_lines

Group copy summary by call number in addition to circ lib and
copy location.

Also, support setting of max_lines for limiting the number
of call numbers output -- useful for bibs with lots of volumes
at a single library -- to prevent the search results page from
growing too long.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoSummarize copy availability in search results
Jeff Godin [Mon, 16 Apr 2012 14:01:31 +0000 (10:01 -0400)]
Summarize copy availability in search results

Summary of available copies in search results.

Next, need to display call numbers.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoShow reviews/anotes by default if found
Jeff Godin [Sun, 15 Apr 2012 03:41:59 +0000 (23:41 -0400)]
Show reviews/anotes by default if found

If the added content handler found reviews or author notes,
show that information by default (first reviews, then author
notes if there were no reviews).

If neither are found, show nothing by default -- but things
like Table of Contents or Excerpts will still be available
by clicking the proper link.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoRemove copy info matrix from rdetail page
Jeff Godin [Sun, 15 Apr 2012 03:07:12 +0000 (23:07 -0400)]
Remove copy info matrix from rdetail page

Removing copy info matrix.

Next up: bibtemplate-style copy information to replace
copy info matrix.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoGRPL-style more/less info button in rdetail
Jeff Godin [Fri, 13 Apr 2012 21:20:29 +0000 (17:20 -0400)]
GRPL-style more/less info button in rdetail

Add GRPL-style more/less info button in rdetail view.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoRemove some borders/color, adjust a missed color
Jeff Godin [Fri, 13 Apr 2012 21:12:30 +0000 (17:12 -0400)]
Remove some borders/color, adjust a missed color

Remove border around "home" page search, remove border around
search results.r

Remove some color from top and bottom of search results.

Override a missed color which was resulting in the default green
color on "low search results".

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoAdjust include paths from tadlv2 to tadlv3
Jeff Godin [Fri, 13 Apr 2012 20:30:27 +0000 (16:30 -0400)]
Adjust include paths from tadlv2 to tadlv3

Adjust include paths which reference tadlv2 to reference tadlv3
instead. We'd rather not rely on default AND the previous skin
revision.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoForking tadlv2 to tadlv3 skin
Jeff Godin [Fri, 13 Apr 2012 15:30:37 +0000 (11:30 -0400)]
Forking tadlv2 to tadlv3 skin

Breaking ground on tadlv3 skin, starting with what is currently
the tadlv2 skin.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoMerge branch 'prod/rel_2_1/deployed' of yeti.esilibrary.com:tadl/evergreen into tadl_...
Steven Callender [Thu, 12 Apr 2012 16:44:31 +0000 (12:44 -0400)]
Merge branch 'prod/rel_2_1/deployed' of yeti.esilibrary.com:tadl/evergreen into tadl_skin_changes

12 years agoMerge branch 'prod/rel_2_1/deployed' of yeti.esilibrary.com:tadl/evergreen into my_tadl
Steven Callender [Thu, 12 Apr 2012 14:55:21 +0000 (10:55 -0400)]
Merge branch 'prod/rel_2_1/deployed' of yeti.esilibrary.com:tadl/evergreen into my_tadl

12 years agoperl modules from asp-tadl-app1, minus OpenILS/SIP/Patron.pm
Jason Etheridge [Wed, 4 Apr 2012 14:38:53 +0000 (10:38 -0400)]
perl modules from asp-tadl-app1, minus OpenILS/SIP/Patron.pm

12 years agomore modified perl modules from asp-tadl-sip1
Jason Etheridge [Wed, 4 Apr 2012 14:35:18 +0000 (10:35 -0400)]
more modified perl modules from asp-tadl-sip1

12 years agosnapshot of /usr/local/share/perl/5.10.1/OpenILS/SIP/Patron.pm from asp-tadl-sip1
Jason Etheridge [Wed, 4 Apr 2012 14:23:50 +0000 (10:23 -0400)]
snapshot of /usr/local/share/perl/5.10.1/OpenILS/SIP/Patron.pm from asp-tadl-sip1

12 years agoAdjust styling of css_button class skin_tadlv2
Jeff Godin [Tue, 3 Apr 2012 23:49:03 +0000 (19:49 -0400)]
Adjust styling of css_button class

Adjust the styling of the css_button class, especially changes
in margin and changing of display to inline-block so as not to
overlap with other buttons or other display elements.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoFix: recs without online_loc break results display
Jeff Godin [Tue, 3 Apr 2012 19:41:01 +0000 (15:41 -0400)]
Fix: recs without online_loc break results display

Don't try to check a substring of rec.online_loc()[0] if there
are no entries returned by rec.online_loc() to begin with.

Manifests result_info_2 (with the prev/next links) not being
visible on the bottom of the search results page when there
are any bibs present in the results which have no online_loc()
entries.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoUse a default auri label instead of http:// urls
Jeff Godin [Tue, 3 Apr 2012 18:39:52 +0000 (14:39 -0400)]
Use a default auri label instead of http:// urls

Use a default auri label in search results and record summary
pages. This is mostly to prevent the symptoms of LP 918020
but may be more generally useful as well.

Also, use css_button class for BibTemplate-generated auri links
in a record summary.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoReference tadlv2 skin-local myopac.js
Jeff Godin [Tue, 3 Apr 2012 15:22:14 +0000 (11:22 -0400)]
Reference tadlv2 skin-local myopac.js

Use the skin-local myopac.js instead of that from the
default skin.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoDisplay Series, Hold Count in record summary
Jeff Godin [Tue, 3 Apr 2012 14:54:59 +0000 (10:54 -0400)]
Display Series, Hold Count in record summary

Re-adding pre-bibtemplate Series display to record summary,
re-adding CGI-backed Hold Count.

These are both prime candidates for being replaced using
newly-available features.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoUse library local patron barcode regex in myopac
Jeff Godin [Tue, 3 Apr 2012 14:37:24 +0000 (10:37 -0400)]
Use library local patron barcode regex in myopac

Use library local patron barcode regex in myopac, so that
username vs barcode detection will be correct.

The regex used at login is maintained outside of the skin,
so we're already set there.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoHide copy counts for online-only bibs in results
Jeff Godin [Tue, 3 Apr 2012 14:34:25 +0000 (10:34 -0400)]
Hide copy counts for online-only bibs in results

Hide copy counts in search results for bibs which appear to be
online-only.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoFork rresult.js from default skin
Jeff Godin [Tue, 3 Apr 2012 14:27:41 +0000 (10:27 -0400)]
Fork rresult.js from default skin

This is the rresult.js from the default skin.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoEnhance display of online-only bibs
Jeff Godin [Tue, 3 Apr 2012 14:25:26 +0000 (10:25 -0400)]
Enhance display of online-only bibs

On search results:
* Hide "place hold" links for bibs which appear to have TADL
  ezproxy auris.
* Simplify physical description for online-only bibs in search
  results
* Hide format icons for online-only bibs
* Add some padding to result_table_format_cell

On record summary:
* Change auri links to use the css_button class.
* Hide things which only make sense for physical holdings:
  * place hold
  * copy info displays
  * call number browse

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoUse medium item image for record summary
Jeff Godin [Tue, 3 Apr 2012 14:24:09 +0000 (10:24 -0400)]
Use medium item image for record summary

Switch to "medium" size item image in record summary.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoUse skin-local rdetail.js, result_common.js
Jeff Godin [Tue, 3 Apr 2012 14:06:28 +0000 (10:06 -0400)]
Use skin-local rdetail.js, result_common.js

Start using the skin-local rdetail.js and result_common.js
files. Previously we were still referencing those from the
default skin.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoDisplay TADL ezproxy OPAC links in search results
Jeff Godin [Tue, 3 Apr 2012 13:40:24 +0000 (09:40 -0400)]
Display TADL ezproxy OPAC links in search results

Feature the auri when it appears to be a TADL ezproxy link.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoHide item image in results when error loading
Jeff Godin [Tue, 3 Apr 2012 13:32:45 +0000 (09:32 -0400)]
Hide item image in results when error loading

Hide the item image in results table when there is an
error loading it -- typically a 404.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoChange "Place Hold" links to css buttons
Jeff Godin [Tue, 3 Apr 2012 13:29:00 +0000 (09:29 -0400)]
Change "Place Hold" links to css buttons

Make "Place Hold" more visible by using CSS to turn
the link into something that resembles a button.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoAdd online payment link
Jeff Godin [Tue, 3 Apr 2012 13:18:42 +0000 (09:18 -0400)]
Add online payment link

Add online payment link to My Fines in the OPAC for
the tadlv2 skin.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoFork myopac.js in prep for online payment link
Jeff Godin [Tue, 3 Apr 2012 13:14:25 +0000 (09:14 -0400)]
Fork myopac.js in prep for online payment link

This is myopac.js from the default skin, before changes.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoTADL CSS changes - layout and color
Jeff Godin [Mon, 2 Apr 2012 21:27:50 +0000 (17:27 -0400)]
TADL CSS changes - layout and color

tadl_layout.css overrides and adds to default/layout.css
tadl_colors.css is a copy of theme/tadl/css/colors.css

tadl_colors.css should be trimmed down and unintentional
overrides/conflicts with theme/default/css/colors.css
eliminated.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoRemove extra / PINES-specific links from footer
Jeff Godin [Mon, 2 Apr 2012 21:12:39 +0000 (17:12 -0400)]
Remove extra / PINES-specific links from footer

Remove extra links (and PINES-specific links) from footer.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoUpdated TADL logo for tadlv2 skin
Jeff Godin [Mon, 2 Apr 2012 21:09:45 +0000 (17:09 -0400)]
Updated TADL logo for tadlv2 skin

Updated copy of TADL logo in tadlv2 skin.

Increase logo display size on search result / detail pages --
anywhere common/logo.xml is used.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoDisable Google Chrome Frame, Google Books
Jeff Godin [Mon, 2 Apr 2012 20:19:18 +0000 (16:19 -0400)]
Disable Google Chrome Frame, Google Books

In both the tadlstaff and the tadlv2 skins:

* Disable Google Chrome Frame by removing the div and script
* Disable Google Books links, preview by setting existing
  boolean values to false

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoAdding two new skins: tadlstaff, tadlv2
Jeff Godin [Mon, 2 Apr 2012 19:40:33 +0000 (15:40 -0400)]
Adding two new skins: tadlstaff, tadlv2

Two new skins, forked from default.

Currently, both are identical and reference the css and js files
from the default skin.

Intent is to fork css and js if and when needed.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
12 years agoReshelving fix.
Steven Callender [Mon, 2 Apr 2012 15:19:38 +0000 (11:19 -0400)]
Reshelving fix.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
12 years agoOPAC customizations including password reset text change.
Steven Callender [Tue, 20 Mar 2012 15:46:39 +0000 (15:46 +0000)]
OPAC customizations including password reset text change.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
12 years agoConfigue credit card processing to default to the recording setting.
Steven Callender [Thu, 1 Mar 2012 19:05:57 +0000 (19:05 +0000)]
Configue credit card processing to default to the recording setting.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
12 years agocorrected combined.js after running autogen.sh
Jason Etheridge [Wed, 29 Feb 2012 20:40:51 +0000 (15:40 -0500)]
corrected combined.js after running autogen.sh

12 years agochanges since migration, but not sure where these came from yet
Jason Etheridge [Wed, 29 Feb 2012 20:20:31 +0000 (15:20 -0500)]
changes since migration, but not sure where these came from yet

12 years agocustom OPAC skin at the time of migration
Jason Etheridge [Wed, 29 Feb 2012 19:57:38 +0000 (14:57 -0500)]
custom OPAC skin at the time of migration

12 years agohelpspot 18373
Jason Etheridge [Wed, 29 Feb 2012 16:09:34 +0000 (11:09 -0500)]
helpspot 18373

https://gist.github.com/179cd9a682a509537cb8

12 years agoAdded Content module for pointing to another Evergreen instance
jason [Mon, 27 Feb 2012 22:41:16 +0000 (17:41 -0500)]
Added Content module for pointing to another Evergreen instance

Needs tweaks to opensrf.xml, for example:

        <added_content>
            <!-- load the OpenLibrary added content module -->
            <module>OpenILS::WWW::AddedContent::Evergreen</module>
            <base_url>http://grpl.michiganevergreen.org/opac/extras/ac</base_url>

12 years agoPatron editor changes
jason [Mon, 27 Feb 2012 22:32:31 +0000 (17:32 -0500)]
Patron editor changes

Originating from https://github.com/grpl-eg/rel_2_1.git:

aad962182fc75967a763a66bf32208065fd4b773
39a67d5523f80aaf119b537f5665c0772958e6f7
8bac903b2e512d3625553f2693b100f3cc60f9a0

12 years agoStock rel_2_1 patron editor copied into TADL specific directories as a baseline
jason [Mon, 27 Feb 2012 22:23:13 +0000 (17:23 -0500)]
Stock rel_2_1 patron editor copied into TADL specific directories as a baseline

13 years agoBumping version numbers, adding Upgrade Script and Changelog
Thomas Berezansky [Wed, 16 Nov 2011 17:37:15 +0000 (12:37 -0500)]
Bumping version numbers, adding Upgrade Script and Changelog

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
13 years agoStamping upgrade script for copy visibility vs peer-bibs fix
Mike Rylander [Wed, 16 Nov 2011 17:07:54 +0000 (12:07 -0500)]
Stamping upgrade script for copy visibility vs peer-bibs fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoDistinct cache_copy_visibility copy/record
Thomas Berezansky [Mon, 24 Oct 2011 14:36:39 +0000 (10:36 -0400)]
Distinct cache_copy_visibility copy/record

Because if you peer bib a copy to the bib it is on things don't like you.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoStamped upgrade for full circ count view fix
Mike Rylander [Tue, 15 Nov 2011 21:24:06 +0000 (16:24 -0500)]
Stamped upgrade for full circ count view fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoUse DISTINCT in counts to avoid dupes
Thomas Berezansky [Thu, 29 Sep 2011 14:44:26 +0000 (10:44 -0400)]
Use DISTINCT in counts to avoid dupes

Otherwise you get:
Legacy count + 2(normal count)(aged count)

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoFull Circ Count View Amplifies Legacy Circs
Dan Wells [Thu, 29 Sep 2011 13:23:49 +0000 (09:23 -0400)]
Full Circ Count View Amplifies Legacy Circs

The current extend_reported.full_circ_count sums the legacy circ count
column, but this results in amplifying the count by the number of current
circs in the system.  This commit adds the legacy count to the GROUP BY
instead of summing it.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoFix a problem in the clear holds shelf list printer
Lebbeous Fogle-Weekley [Wed, 28 Sep 2011 20:50:03 +0000 (16:50 -0400)]
Fix a problem in the clear holds shelf list printer

This is a "special" interface that you get to via Admin -> For
Developers -> Local Administration in the staff client.

The addition features to one "side" of this hackish interface of label affix
and parts had caused breakage on the other "side."  This fixes that.

Also improve document printing, making it less likely the progress
dialog itself gets printed.

One day this will be replaced with something better.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoStamped upgrade for asset.merge_record_assets fix
Mike Rylander [Tue, 15 Nov 2011 20:47:05 +0000 (15:47 -0500)]
Stamped upgrade for asset.merge_record_assets fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoLP#849143 fix some gaps in bib record merging
Jason Etheridge [Tue, 13 Sep 2011 16:22:58 +0000 (12:22 -0400)]
LP#849143 fix some gaps in bib record merging

Tweaks asset.merge_record_assets such that it considers acquisition line items and user requests, serial subscriptions, booking resource types, biblio monograph parts, and biblio peer bib copy maps. I'm not handling vandelay.queued_record.imported_as or any other vandelay tables, but we may wish to do that too. We're also leaving acq.acq_lineitem_history alone.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoAligned the MARC editor subfields to 'start' fixes long subfield display
Liam Whalen [Tue, 1 Nov 2011 19:59:13 +0000 (15:59 -0400)]
Aligned the MARC editor subfields to 'start' fixes long subfield display

When viewing a record in the MARC editor that has extremely long
entries in a subfield, the output would align in the center of the
subfield making the output hard to read.  This patch adds an
align: 'start' option to both the subfield, and the subfield code
elements in the marcSubfield function to make the subfields align in a
 more readable manner.
Signed-off-by: Liam Whalen <lwhalen@evergreen-dev.catalogue.nrcan.gc.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoPatch from Jeff Davis (SITKA) fixing cardless patron updates
Mike Rylander [Tue, 15 Nov 2011 20:04:08 +0000 (15:04 -0500)]
Patch from Jeff Davis (SITKA) fixing cardless patron updates

Quoth the bug report (https://bugs.launchpad.net/evergreen/+bug/851110):

  On our Evergreen 2.0.8 system, it sometimes arises that a patron's card gets deleted. If it was the patron's only card, it becomes impossible to add a new card to the account via the staff client.

  How to reproduce:
  1. Retrieve a patron record for a patron who has no associated card.
  2. Click the Edit button.
  3. Click Replace Barcode and enter a new barcode.
  4. Click Save. This does not work - the process hangs, and if you hit Reload, you will find that your changes were not saved.

  I believe this happens because some code in register.js assumes the patron has at least one card. I have a potential fix that this comment box is too small to contain ... uh, that is to say, I will post it momentarily.

Which he did, and I applied.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoReshelving update.
Steven Callender [Wed, 19 Oct 2011 18:51:14 +0000 (18:51 +0000)]
Reshelving update.

Update to the reshelving code to make it faster and utilize the new status change time field on asset.copy.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoClear shelf canceled holds notification fix
Bill Erickson [Mon, 24 Oct 2011 20:27:29 +0000 (16:27 -0400)]
Clear shelf canceled holds notification fix

After cancelling a batch of holds via the clear-shelf process, before we
send the holds off to action/trigger for potential notification
generation, re-fetch the holds from the DB to pick up the calculated
cancel_time value (i.e. get a real value for "now").  Otherwise, A/T may
die attempting to create a DateTime object by parsing "now".

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoMake idlval build, rather than be dead code
Dan Scott [Sun, 23 Oct 2011 23:58:53 +0000 (16:58 -0700)]
Make idlval build, rather than be dead code

The tool "idlval" contained in Open-ILS/src/c-apps can be used to check
the correctness of fieldmapper definitions in files like
Open-ILS/examples/fm_IDL.xml - but currently does not have a build
target, nor does it compile cleanly due to the use of unspecified
OpenSRF header files. This commit adds a build target, fixes the compile
problems, and installs the tool in the bin directory.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoAdd link to cbs from bre via bre.source -> cbs.id in fm_IDL.xml.
Jason Stephenson [Tue, 8 Nov 2011 19:39:29 +0000 (14:39 -0500)]
Add link to cbs from bre via bre.source -> cbs.id in fm_IDL.xml.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoLP887822 mint_condition/Quality not set correctly
Jason Etheridge [Tue, 8 Nov 2011 23:42:18 +0000 (18:42 -0500)]
LP887822 mint_condition/Quality not set correctly

during item creation.

Specifically, the Javascript object for a new item (acp) does not explicitly set
the mint_condition field, leaving it null. The item attribute editor treats the
null as false (which it displays as "Mediocre" for that field). The database has
a not null constraint the corresponding column in asset.copy, and defaults to
true. So a new item in the attribute editor will show "Mediocre", but when
actually created, will become "Good".

This branch just sets mint_condition to true when an item is created.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoSerials: in the holding code mini-wizard, offer a dropdown for seasons
Lebbeous Fogle-Weekley [Mon, 14 Nov 2011 20:31:14 +0000 (15:31 -0500)]
Serials: in the holding code mini-wizard, offer a dropdown for seasons

This spares the user from having to remember the MFHD code for the
season, when dealing with periodicals issued by season (21 - 24 for
Spring - Winter, respectively).

This also applies sets the "scrollOnFocus" attribute to false for the
dijits within the mini wizard, as the jumpy behavior you get in
less-than-fullscreen staff client windows is otherwise maddening.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoMore filtering of characters that could end up in PO JEDI template output
Lebbeous Fogle-Weekley [Tue, 11 Oct 2011 15:25:51 +0000 (11:25 -0400)]
More filtering of characters that could end up in PO JEDI template output

Backslashes cause problems too.  Let's JSON encode this thing and get it
right once and for all.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoSerials: allow freer input in holding code mini-wizard
Lebbeous Fogle-Weekley [Thu, 10 Nov 2011 22:22:22 +0000 (17:22 -0500)]
Serials: allow freer input in holding code mini-wizard

In the Subscription Details interface of the Alternate Serials Control
View, under the Issuance tab, if you create a new issuance you can
now enter things like "01/02" in (say) the month field to denote a combined
January/February issue.  All those fields are now free-form, whereas some of
them used to be numeric only.

Also, avoid an occasional issue where an error message about
dijit.form.DateTextBox not being a constructor would appear in the
JavaScript console.  The problem was in a race condition among some
co-dependent JavaScript files that were all being loaded at the same
time.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoLP88653 force SSL for requests from local XUL
Jason Etheridge [Thu, 10 Nov 2011 17:55:32 +0000 (12:55 -0500)]
LP88653 force SSL for requests from local XUL

Modifies RemoteRequest.js to convert any http:// request URL to https:// if the
requesting location has a chrome:// protocol.

Modifies util/network.js such that any use of util.network.request (as opposed
to util.network.simple_request) will assume "secure" for the resulting request.

Adds an example to the bottom of eg_vhost.conf for forcing SSL for an entire
site (OPAC and everything), courtesy of Dan Wells.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoXML.ignoreWhitespace causes syntax errors
Thomas Berezansky [Wed, 9 Nov 2011 16:00:05 +0000 (11:00 -0500)]
XML.ignoreWhitespace causes syntax errors

So remove it.

Disabling pretty printing appears to be enough to fix the marc editor.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoFix vanishing whitespace in marc editor
Thomas Berezansky [Mon, 7 Nov 2011 22:28:02 +0000 (17:28 -0500)]
Fix vanishing whitespace in marc editor

XML.ignoreWhitespace and XML.prettyPrinting cause whitespace to vanish.

So disable them at the top of marcedit.js.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agolp849447: trival stylistic tweaks
Galen Charlton [Mon, 31 Oct 2011 15:46:48 +0000 (11:46 -0400)]
lp849447: trival stylistic tweaks

- rename variable avoid double-negative
- avoid 'Variable declared in conditional statement' perlcritic gripe

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoInitial patch from Sarah Chodrow on LP bug 849447.
Sarah E. Chodrow [Wed, 14 Sep 2011 13:15:14 +0000 (09:15 -0400)]
Initial patch from Sarah Chodrow on LP bug 849447.

Also check for standing penalties and expired cards when checking
if it is ok for the patron to checkout, charge_ok.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Sarah E. Chodrow (sarah.chodrow@bibliotheca-itg.com)
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoMerge branch 'rel_2_1' of git.evergreen-ils.org:Evergreen into rel_2_1
Mike Rylander [Tue, 8 Nov 2011 18:06:12 +0000 (13:06 -0500)]
Merge branch 'rel_2_1' of git.evergreen-ils.org:Evergreen into rel_2_1

13 years agoProtect against slony replication lag, LP#621448
Mike Rylander [Tue, 8 Nov 2011 17:43:44 +0000 (12:43 -0500)]
Protect against slony replication lag, LP#621448

Make open-ils.circ.captured_holds.id_list.* API calls authoritative within
the staff client to avoid replication-lag related stale displays.  Inspired
by James Fournie at SITKA.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoMerge remote branch 'working/collab/dbs/rel_2_1-release_notes' into rel_2_1
Galen Charlton [Tue, 8 Nov 2011 13:36:24 +0000 (08:36 -0500)]
Merge remote branch 'working/collab/dbs/rel_2_1-release_notes' into rel_2_1

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
13 years agoRelease Notes: Suggestions from Grace Dunbar
Dan Scott [Tue, 8 Nov 2011 02:46:22 +0000 (21:46 -0500)]
Release Notes: Suggestions from Grace Dunbar

Grace Dunbar <gdunbar@esilibrary.com> sent me a private email with some
suggestions for additions to the release notes; I've added many of her
suggestions, edited in some cases for grammar or to match the labels in
the staff client. Much appreciated, Grace!

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoREADME: Use consistent endings (none!) for titles/subtitles
Dan Scott [Mon, 7 Nov 2011 21:49:31 +0000 (16:49 -0500)]
README: Use consistent endings (none!) for titles/subtitles

Most, but not all, of the titles/subtitles had colons appended. This
looks really weird in the Table of Contents, so try to be consistently
unweird and have no appended colons.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoBackup the existing opensrf config files before copying
Dan Scott [Mon, 7 Nov 2011 21:38:32 +0000 (16:38 -0500)]
Backup the existing opensrf config files before copying

Per a suggestion from Wolf Halton <wolf.halton@gmail.com>, create backup
versions of the opensrf configuration files when we're copying the
Evergreen example versions over, so that we can retrieve the Jabber user
names and passwords and domains from the backups (if necessary).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoAdd tarball download / untar instructions to README
Dan Scott [Mon, 7 Nov 2011 21:28:04 +0000 (16:28 -0500)]
Add tarball download / untar instructions to README

Per suggestions from Yamil Suarez <ysuarez@berklee.edu> and Martha
Driscoll <driscoll@noblenet.org> and Wolf Halton
<wolf.halton@gmail.com>, restore the version-specific wget / untar
instructions to the README.

Aside: Need to remember to update these links in the repo before tagging
a release.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoLP874597 password from phone # when cloning users
Jason Etheridge [Thu, 27 Oct 2011 18:16:12 +0000 (14:16 -0400)]
LP874597 password from phone # when cloning users

Patron: password from phone # does not work when cloning users

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoLP#860845 hold placement UI can break
Jason Etheridge [Tue, 27 Sep 2011 19:42:49 +0000 (15:42 -0400)]
LP#860845 hold placement UI can break

hold placement UI can break and give misleading error on Submit

Adds some defensive coding, but since I don't quite grok everything going on here, may not be the best fix.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoThis prevents the acq unified_search method from returning anything other
James Fournie [Tue, 1 Nov 2011 23:01:57 +0000 (16:01 -0700)]
This prevents the acq unified_search method from returning anything other
than the objects of the expected type.

This is to address LP 884991 in which Acq users get a perm error for each
result of a search that they don't have access to retrieve.  They shouldn't
even know about the existence of anything they don't have access to retrieve.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoPreviously invisible copies showed as beige in the staff client, they stopped doing...
James Fournie [Tue, 20 Sep 2011 19:03:03 +0000 (12:03 -0700)]
Previously invisible copies showed as beige in the staff client, they stopped doing this in 2.0

This is because in 2.0 the copy counts logic was moved from open-ils.storage.biblio.record_entry.copy_count.staff
to an in-database function wrapped in open-ils.search.biblio.record.copy_count.staff.  Both methods returned various
counts including an 'unshadow' count, however the 'unshadow' in the new database function was not completed and it
has only been returning a simple copy count rather than a count of opac visible copies as it should be to
replicate the old behaviour.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoAcq: better error message if trying to create PO without provider or agency
Lebbeous Fogle-Weekley [Thu, 6 Oct 2011 20:13:51 +0000 (16:13 -0400)]
Acq: better error message if trying to create PO without provider or agency

Before now, if you leave either the provider or ordering agency
fields blank in the "Create Purchase Order" dialog, you get a
nonsensical warning about prepayment.

This fixes that.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTurn ebooks AC from OpenLibrary into usable HTML
dbs [Wed, 27 Apr 2011 16:18:54 +0000 (16:18 +0000)]
Turn ebooks AC from OpenLibrary into usable HTML

Add <a> elements to turn URLs into links, and use the upper case
ebook format as the content of the link. "Read online" is the one
i18n-unfriendly exception, but this is a good start.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@20346 dcc99617-32d9-48b4-a31d-7c20da2025e4
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoTeach OpenLibrary.pm how to extract ebook links from OpenLibrary results
dbs [Wed, 27 Apr 2011 15:54:48 +0000 (15:54 +0000)]
Teach OpenLibrary.pm how to extract ebook links from OpenLibrary results

If the Internet Archive has an available ebook, then OpenLibrary will
provide links to it in various formats. For now, we return the results
as a plain set of <div> elements with class attributes denoting what
kind of ebook was returned; i18n will have to take care of providing
an actual label. Oh, and I guess we want to turn these into actual
<a> links...

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoModified authority.indexing_ingest_or_delete to update MARC data
Liam Whalen [Thu, 3 Nov 2011 20:53:57 +0000 (16:53 -0400)]
Modified authority.indexing_ingest_or_delete to update MARC data

The authority.indexing_ingest_or_delete trigger in the update script
was missing a call to authority.propagate_changes which is responsible
for updating the MARC data of records affected by an auhtority merge.
This patch adds the call to authority.propagate_changes as it appears
in the authority.indexing_ingest_or_delete trigger from the file
999.functions.global.sql.

Signed-off-by: Liam Whalen <lwhalen@nrcan-rncan.gc.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoAcq: fix a bug that sometimes prevents the general search page from loading
Lebbeous Fogle-Weekley [Thu, 6 Oct 2011 16:06:09 +0000 (12:06 -0400)]
Acq: fix a bug that sometimes prevents the general search page from loading

Within Acquisitions General Search, javascript included from one file
in the <head> relies on the variable "localeStrings" being initialized
by javascript included from a file in <body>.  Sometimes the wrong
javascript wins the race, you get an error about localeStrings being
undefined in the Javascript console, and the page stops loading.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoFine generator; raise multi-session mode recv timeout
Bill Erickson [Tue, 1 Nov 2011 21:02:44 +0000 (17:02 -0400)]
Fine generator; raise multi-session mode recv timeout

When fetching the batch of overdue circ IDs to process for fine
generation, wait a little longer for the data to arrive, since
it is a longer running DB query than most.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoforgot to update upgrade_log
Jason Etheridge [Tue, 1 Nov 2011 20:19:01 +0000 (16:19 -0400)]
forgot to update upgrade_log

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agopin upgrade script
Jason Etheridge [Tue, 1 Nov 2011 20:17:59 +0000 (16:17 -0400)]
pin upgrade script

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoProtect SVF normalizers against NULL values
Mike Rylander [Tue, 1 Nov 2011 19:49:15 +0000 (15:49 -0400)]
Protect SVF normalizers against NULL values

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoForce Amazon AC requests to use 10-digit ISBNs
Dan Scott [Tue, 1 Nov 2011 17:29:25 +0000 (13:29 -0400)]
Force Amazon AC requests to use 10-digit ISBNs

Inspired by a patch submitted by Ian Bays <ian.bays@ptfs-europe.com>
via https://bugs.launchpad.net/evergreen/+bug/870171, this patch takes
the incoming key and, if it is longer than 10 characters (a 10-digit
ISBN or Amazon ID), attempts to normalize it and return a 10-digit ISBN.

We don't normalize all incoming keys because some sites are horribly
abusing the 020 MARC field to include an Amazon ID instead of an ISBN -
but that works in practice and we'd rather not break working
installations if we can avoid it.

Signed-off-by: Dan Scott <dscott@laurentian.ca>