add acknowledge alerts to renewal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

allow both CHECKIN and CHECKOUT alerts to fire during renewal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

correctly test whether the alert_type fires during renewal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

no longer display the legacy copy alert message

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix styling of manage copy alert button in item status

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add new-style copy alerts to volcopy defaults selector

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

copy alert type editor can now create and update copy alert types

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

make copy alert suppression editor feature-complete

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

set name as copy alert type selector field

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add copy alert suppression to splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

start UI for managing copy alert suppression

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add copy alerts to local admin splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

start on a config editor for config.copy_alert_types

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

teach vol/copy editor how to deal with copy alerts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add copy alert ack/manage action to checkin, checkout, and item status

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
Open-ILS/src/templates/staff/cat/item/t_summary_pane.tt2

implement setting next status upon checkin

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

display text for system-generated copy alerts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

return all potential next copy statuses, not just first

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

have a bit of visual separation between alerts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

start work on egCopyAlertManagerDialog

This dialog is currently capable of:

- displaying copy alerts during checkin and checkout
- allowing the operator to acknowledge temporary alerts

TODO:

- allow display of all current alerts
- allow alerts to be added

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
Open-ILS/web/js/ui/default/staff/circ/services/circ.js

make egCore.pcrud.apply() work

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

some sample copy alert types

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

don't generate system copy alerts if copy state is normal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

support the LOST_AND_PAID status added in LP#1198475

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix various thinkos and syntax errors to get the biz logic working

As of now, open-ils.circ.checkin is now starting to emit
custom copy alerts.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix some typos, syntax errors, and stray invisible characters

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add typo/space fixes to baseline schema

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

biz logic for alerts

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Baseline IDL stuff for alerts

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Initial schema for copy alerts

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Docs: Publish the 2.12 release notes

We've released 2.12, let's integrate the corresponding release
notes into the doc build.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Docs: Use the 2.11 release notes

Update root.txt to point to the 2.11 release notes.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

Resolve a few doc build errors with images

* We need to match the case of images exactly on case-sensitive file systems
* Two dots in a file name confuses the simple-minded PDF build
* Comment out images that we don't actually have yet

Signed-off-by: Dan Scott <dscott@laurentian.ca>

LP#1669868: fix regression that broke building staff client

Looks like AM_CONDITIONAL should not be in if blocks per
https://www.gnu.org/software/automake/manual/html_node/Usage-of-Conditionals.html

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

fix typo that broken generation of es-ES lang.dtd

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - po files

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update server upgrade instructions for 2.12.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update release notes for 2.12.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

2.11.3-2.12.0 schema update script

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1668720: remove browser console noise for OPAC

This patch fixes a case where JavaScript used in the OPAC
attempts to set the value of a #client_tz_id input on all
pages, even though only the login page has such an input.

To test:

[1] Load the OPAC homepage and open the JavaScript console/developer tools.
    Note that there's a "Cannot set property 'value' of null"
    error.
[2] Apply the patch and try again; this time there shouldn't
    be such an error.
[3] Open the login page, and verify, using developer tools,
    that the hidden client_tz_id input does have its value
    set to the client timezone.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP 1669868: Fix make check for all distros.

Chris Sharp found that make check was failing on Ubuntu 14.04 and 16.04.

I borrowed a few lines from the OpenSRF configure.ac and modified the
Open-ILS/src/c-apps/tests/Makefile.am to use a more autoconf-oriented
approach that won't lead to unnecessary checks in the install scripts.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1675025: Docs: mention that Vandelay can load MARCXML

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: README to include Debian for changing ownership of /var/lock/apache2

Minor tweak to also include Debian among distributions where it might
be necessary to change ownership of /var/lock/apache2 to opensrf user.
Previously this had been Ubuntu only issue, but has since been encountered
during new Debian installations.

Signed-off-by: Ben Shum <ben@evergreener.net>

Docs: replacing XUL booking module screenshots with browser client ones

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1673891: Fix untranslatable strings in metarecord sibling links

We had a couple of untrasnlatable strings in the new sibling link section
of the record summary page. This commit makes the strings translatable and
also rewords one of the strings, as recommended by Eva Cerninakova, to make
it easier to translate in other languages.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1670512 Apply focus/select model udpates via timeout

Avoid manually invoking scope.$apply() in the midst of an angular
$digest loop, since this is forbidden by angular.  Wrap the apply()'s in
a $timeout, so they occur after the currently running digest.

Fixes the focusMe, blurMe, and selectMe directives.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1638377: update release notes to mention --with-perlbase

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1638377: Allow perl to be installed in non-standard locations

Add --with-perlbase configure option to specify
an alternative location for installing the Perl modules. This
can be useful for setups that want to run the Perl modules
from a shared filesystem or environments that need to run
multiple versions of OpenSRF simultaneously.

Users of --with-perlbase are responsible for ensuring that
PERL5LIB is set appropriately.

To test
-------
[1] Use --with-perlbase during the configure step, e.g.,

    ./configure --with-perlbase /tmp/perl

[2] Run make; make check; sudo make install
[3] Verify that the Perl modules are installed under
    /tmp/perl.
[4] Make a change to a Perl source file, then
    go to src/perlmods, then run sudo ./Build install. Verify
    that it remembers the --with-perlbase directory
    and installs the updated module there.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update a couple references of 2.12-beta to 2.12-rc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - po files

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update monolithic schema upgrade script for 2.12-rc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1671936: add facet reingest to version-upgrade from 2.11.3

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1671936: Tweak to release notes entry on reingest

Changes the Upgrade Notes in the release notes that a reingest of both browse
and facet indexes is required.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
docs/RELEASE_NOTES_2_12.adoc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1671936: Provide reingest for 1006 upgrade script

We missed the reingest for upgrade script 1006. Adding it here.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Fix typo, add missing contributing organization

This commit fixes a small grammar mistake and adds a missing
organization to the Acknowledgements section.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Slight rewording of release notes

This commit slightly rewords the release notes entry about the new
translator make target.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Grammar tweaks to the 2.12 release notes

Many thanks to Andrea Neiman for catching these!

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Updates to Czech organizations

Making updates to Czech organizations listed in acknowledgements as recommended
by Eva Cerninakova.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: more 2.12 release notes updates

* additional formatting
* mention the two new services in the top-level upgrade
  section.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: more typo and formatting improvements for 2.12 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: mark subfield labels in 2.12 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: replace "OPAC" jargon in release notes

... in favor of "public catalog". Please note that
I don't feel strongly about this change, and won't mind
if it gets reverted. I do feel more strongly about the
word "OPAC" slipping into patron-targeted documentation.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: typo fix for 2.12 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Translator acknowledgements and PostgreSQL support

Updates the release notes with acknowledgements for translators that changed
trasnlations strings for offically-supported languages since the last release.
Also adds PostgreSQL as a recommendation as per discussion at March 2017 dev
meeting and follow-up e-mail to the dev list.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Additions to 2.12 release notes

Adds organizations that commissioned development, contributors who have
contributed since the beta release, new notes for ebook integration, and
some some missed features.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1673059: Update passwd storage test

The passwd storage PgTAP test is failing because the user ids shifted when new
sample records were added to the actor.usr table in the Concerto dataset. This
branch changes the id in the test to point to the correct user.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1671112 Sample users and addresses with Unicode characters

Introducing to the line up of sample users, José Antonio Bautista
and Munenori Kawasaki (川﨑 宗則), hailing from 800 René-Lévesque Blvd W in
Montréal.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <ben@evergreener.net>

webstaff: Make Items Bookable and Book Item Now for Holdings View

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1586567 Always return Fund Years sorted descending

Currently, fund year selectors in Acq interfaces (at least Acq Admin ->
Funds, and Acq -> Load MARC Order Records) show the fund years in
database order. This commit adds a descending sort to the perl function
that retrieves fund years for those interfaces. It also removes the
unsuccessful attempt at sorting that was present in the dojo code.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP# 1668414: Stamping upgrade script for oneclickdigital base URI

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1541559: org setting for OneClickdigital API base URI

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

lp1629016: Hide List Option In Staff Client

This will hide the option to add to Lists when in the staff client.

Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

lp1261835 stop colliding bill UI refreshes

for want of promises in Angular :)

population of the bill list in this implementation is asynchronous, but the rest
of the refresh action is not, and it's sadly being invoked multiple times. There
are different ways to fix this, but using a semaphore seems to work.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1175293 Use filtered fund dropdown in funding source interface

The exising interface for allocating to funds from a funding source
view lists all funds by code only.  Since many (most?) orgs reuse
fund codes year to year, you eventually end up with a bunch of
dupes you cannot tell apart.

Let's "borrow" an AutoFieldWidget to do the heavy lifting of creating
a filtered list of active funds, and include the year for further
user validation.

This is inspired by a few other fund dropdowns, but may not be the
best overall solution.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1668682 Checkout holds fullfill ignores expire time

Checking out a hold-captured item for a hold whose expire time is in the
past, but has not yet been canceled by the hold targeter, now marks the
hold as fulfilled.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1522644: Make Mark for Hold Transfer option consistent with other options

Makes the following changes to the Mark for Holds Transfer Destination option:

1) Changes the label from "Mark As Title Hold Transfer Destination" to "Title
Hold Transfer." The 'Mark" piece is already implied in the "Mark For" button
label, and the long text was pushing the menu off the screen for some displays.

2) Makes the option behave as other Mark options. If a record is already marked,
it displays the marked Record ID in the menu. The mark is also removed when the
"Reset Record Marks" option is clicked.

3) Pushes the reset option down to the bottom of the menu and alphabetizes the
other Mark options above it.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1522644: webclient: Transfer title holds issues

    Hid "Transfer All Titles" button from the View Holds tab of the bib record

    Moved the "Mark as Title Hold Transfer Destination" button to the
    "Mark For:" dropdown to make it more consistent with other "mark" actions.

    To test
    -------
    [1] Place a hold on a title.

    [2] Choose another title. Under "Mark For" click
        "Mark as Title Hold Transfer Destination"

    [3] Return to original title on hold. Under "Actions"
        click "Transfer To Marked Title"

    [4] Confirm that hold is transfered.

Signed-off-by: Victoria Lewis <vlewis@catalystdevworks.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1442276: Stamp schema upgrade for corrupted XSL output

Signed-off-by: Dan Scott <dscott@laurentian.ca>

LP#1442276: Upgrade script for Encoding UTF8 output

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

LP#1442276 output_as_chars() instead of toString

The SuperCat transform methods for records retrieved by record ID or ISBN call
toString on the XSLT output object, which results in a byte string and thus
corrupted output. Instead, call output_as_chars() on the stylesheet object to
generate a character string and avoid corruption.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1442276 pgTAP test for oils_xslt_process

In moving from the deprecated XML::LibXSLT::output_string() to output_as_chars(),
add a regression test to ensure that we do not suffer from corrputed encoding
output in the future.

We test both the case where an output encoding has been explicitly declared,
as well as the case where an output encoding has not been explicitly declared.
It was this subtle difference that was causing the problem with output_string().

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1442276 Prevent corrupted Unicode chars in MARCTXT and RIS

The MARCTXT and RIS feeds use the deprecated XML::LibXSLT::output_string()
method which, depending on the stylesheet, generated either a byte string
or characters. Using output_as_bytes() ensures it is always a byte string
and avoids the resulting MARCTXT and RIS output from corrupting Unicode
characters.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1442276 Encode UTF8 output of XSLT transforms

The XML::LibXSLT::output_string() method was deprecated in favour of
output_as_bytes() and output_as_chars(). The latter always generates
UTF8 output as characters, which is what we need, while output_string()
behaviour depended on the stylesheet.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1671904 egDate unit test handles time change

Teach the egDate unit test requesting '2 days' worth of seconds to allow
values for 47, 48, or 49 hours.  47 and 49 happen when crossing time
change boundaries.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1671165: Fix web client build error

Bower install was grabbing a later version of angular-cookies than we wanted,
resulting in errors when attempting to build the web client. Changing a
caret to a tilde in the bower.json files keeps us to a 1.5.x version of
angular-cookies, making web client builds happy.

Many thanks to Ben Shum for finding the solution to this problem!

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1642378 Webstaff negative balance UI progress dialog

Display a progress dialog while loading the Patrons With Negative
Balances UI.  Dialog starts indeterminate, morphing into
semi-determinate as patron data streams in.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1642378 Webstaff Negative Balance org select repairs

1. Disable org units in the org unit selector that cannot have users.

Additional code cleanup:

2. The org selector calls egStartup internally, so if the page
controller has no need to wait on the startup to complete, then it does
not need to manually invoke the startup.

3. No longer necessary to manually track the selected org unit from the
org selector directive.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1642378 Webstaff org selector misc. repairs

1. Always apply default values after egStartup.go() has completed.
   Among other things, this prevents the occaisonal "cannot call ws_ou()
   on an undefined value" errors bubbling up from the org selector
   when an attempt to set default values occured before egAuth had
   retrieved the user (which occurs during startup).

2. For consistency, always run the $scope.onchange handler on initial
   page load when a selected value and change handler are defined.
   Similar to #1 above, the initial onchange always fires after
   egStartup has completed.

3. Run the change handler in a $timeout so that the $scope.selected
   value has a chance to propagate to the calling controller's $scope.
   Otherwise, the the calling controller has to manually track the
   selected value (which partially defeats the purpose of having this
   directive in the first place).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1653001 Hold pull list progress dialog

Display a progress dialog while loading the holds pull list grid and the
when collecting data for printing the holds pull list.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1653001 webstaff: Holds pull list sortable columns

Retrieve holds for the pull list via the canned "ahopl" pull list IDL
class.  This lets the grid fetch the data via canned flattener query,
supporting server-side sort/limit/offset options.

To retain all previous UI behavior, primarily editing hold attributes
(e.g. notification prefs), hold details for each hold have to be fetched
(and cached) in addition to the main grid data.  The grid renders and
sorts the flattener data, then grid actions act upon the fleshed hold
details data.

Commit also includes:

1. Added some missing IDL links for the "ahopl" class.
2. Micro-optimization to egGrid to exit early when an invalid IDL path
   is provided.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1653001 Hold details authoritative API cstore maintenance

Avoid cstore exhaustion during .authorative API calls that run
Holds:retrieve_hold_queue_status_impl() by using the in-transaction
editor for YAOUS lookups instead of allowing the lookups to create their
own cstore connections, each spawning a new transaction, since
CStoreEditor is in authoritative mode.

Since CStoreEditor authoritative handling leaves each cstore transaction
open until the API call completes, and in this case, each hold in the batch
lookup resulted in 2 additional open cstore connections per hold, a batch
lookup of (say) 15 holds, meant 31 cstore connections were opened in one API
call.

Telling the YAOUS lookup to use the existing editor means the same call
completes with 1 cstore connection.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1522638 Patron search uses progress modal

Use the progress modal dialog in the web staff patron search UI for
consistency / code re-use.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1522638 Bib holds egProgressDialog API updates

1. Use the new egProgressDialog name and the new increment() function.
2. Open the dialog before data retrieval starts to better indicate work
   is happening.
3. Close the dialog in promise.finally() to ensure it always closes.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1522638 egProgressDialog features and docs

Use an HTML5 <progress/> element as the progress bar instead of the
Bootstrap progress CSS class.  The HTML5 element provides a more
accurate display.

Add support for 3 modes of operation:

* determinate - shows dialog and percentage progress
* semi-determinate - shows a value-less <progress/> but also displays
  the current value to indicate work happening.
* indeterminate - shows a value-less <progress/> with no specificat
  indication of forward momentum.

Adds a bunch of docs.

Rename egProgressModal to egProgressDialog for consistency with other
eg*Dialog's (which are also modal).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1522638 Record holds tab gets modal progress bar

When loading "View Holds" for a bib record
progress bar modal appears while user waits for titles to display.

Signed-off-by: Victoria Lewis <vlewis@catalystdevworks.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1526185 Disable second toast on permfail

Supress extra toast after inputting valid credentials after
permission failure.

Signed-off-by: Kyle Huckins <khuckins@catalystdevworks.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1526185 op-change supplies egNet.handlePermFailure

Teach egOpChange to handle permission failure events via the new
egNet.handlePermFailure() handler.

This commit includes additional repairs to op-change promise
handling and minor formatting adjustments.

Op-change also now displays the username of the op-changed user
in the navbar immediately upon op-change.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1526185 Operator Change Service

Move operator change functionality into its
own dedicated service.

Notify user when action fails due to unauthorized
credentials, complete with message as to what has
gone wrong.

Fire off any failed action after input of authorized
credentials.

Signed-off-by: Kyle Huckins <khuckins@catalystdevworks.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>