evergreen/bjwebb.git
15 years agofixed reltype for hold notes. might_have -> has_many
erickson [Mon, 20 Jul 2009 15:33:54 +0000 (15:33 +0000)]
fixed reltype for hold notes. might_have -> has_many

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13633 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agono need to destroy and recreate this interface if staff bounce around the patron...
phasefx [Mon, 20 Jul 2009 05:14:34 +0000 (05:14 +0000)]
no need to destroy and recreate this interface if staff bounce around the patron sub-interfaces

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13632 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoremoved unused variable
phasefx [Mon, 20 Jul 2009 04:30:08 +0000 (04:30 +0000)]
removed unused variable

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13631 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agodisplay label strings for linked objects instead of bare pkeys. still need to look...
erickson [Mon, 20 Jul 2009 03:20:48 +0000 (03:20 +0000)]
display label strings for linked objects instead of bare pkeys.  still need to look at resizing the cell

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13628 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoThis interface needs to change a bit, but I wanted to refactor the existing code...
phasefx [Mon, 20 Jul 2009 02:47:04 +0000 (02:47 +0000)]
This interface needs to change a bit, but I wanted to refactor the existing code first to make it more readable (did I succeed?)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13627 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadded seed data for hold-available notifications. update holdisavail validator to...
erickson [Sun, 19 Jul 2009 15:35:54 +0000 (15:35 +0000)]
added seed data for hold-available notifications.  update holdisavail validator to use same basic logic as hold status method

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13624 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoIn oils_auth.c: changed the treatment of inactive accounts.
scottmk [Sat, 18 Jul 2009 12:07:49 +0000 (12:07 +0000)]
In oils_auth.c: changed the treatment of inactive accounts.

Previously, if someone tried to log on to an inactive account,
the error message reported to the client would identify the
account as inactive, without regard to the password.

Now the message identifies the account as inactive only if the
password matches.  Otherwise it reports it simply as a failure.

Also: changed the barcode to a pointer to const, pointing to
an existing string, rather than allocating a separate copy
that we have to free later.

Also: tinkered with a couple of info messages to avoid
invoking undefined behavior when barcode is NULL.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13623 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoIn oils_auth.c: Fixed a bug.
scottmk [Fri, 17 Jul 2009 20:54:17 +0000 (20:54 +0000)]
In oils_auth.c: Fixed a bug.

If you try to log in with a non-existent username, the old
code would report that the username was inactive.  Now it
reports a login failure.  Inactive usernames are still
reported as inactive.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13622 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoautodetect marcxml (or, rather, "not binary marc") at vandelay staging import
miker [Fri, 17 Jul 2009 16:36:15 +0000 (16:36 +0000)]
autodetect marcxml (or, rather, "not binary marc") at vandelay staging import

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13620 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadded option to import holdings from main record import screen. Give the user the...
erickson [Fri, 17 Jul 2009 16:04:45 +0000 (16:04 +0000)]
added option to import holdings from main record import screen.  Give the user the option to choose which item import profile,  when bibs are done importing, attempt to import holdings for successfully imported records.  Still needs a UI for configuring new import profiles and ways to import holdings from the queue interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13617 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years ago1. OK to have duplicate usr_standing_penalty's. 2. find the best context org using...
erickson [Thu, 16 Jul 2009 20:22:17 +0000 (20:22 +0000)]
1.  OK to have duplicate usr_standing_penalty's.  2. find the best context org using the configured penalty org depth.  3. set the staff field.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13616 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoCreate a bunch of new indexes so that the new actor.usr_delete
scottmk [Thu, 16 Jul 2009 20:07:02 +0000 (20:07 +0000)]
Create a bunch of new indexes so that the new actor.usr_delete
and actor.usr_purge_data procedures won't have to do full
table scans.

The CREATE INDEX statements are sprinkled across seven different
installation scripts.  Here there are all in one place, for
updating an existing database:

-- 200.schema.acq.sql
CREATE INDEX fund_alloc_allocator_idx ON acq.fund_allocation ( allocator );
CREATE INDEX li_creator_idx           ON acq.lineitem ( creator );
CREATE INDEX li_editor_idx            ON acq.lineitem ( editor );
CREATE INDEX li_selector_idx          ON acq.lineitem ( selector );
CREATE INDEX li_note_creator_idx      ON acq.lineitem_note ( creator );
CREATE INDEX li_note_editor_idx       ON acq.lineitem_note ( editor );
CREATE INDEX li_usr_attr_def_usr_idx  ON acq.lineitem_usr_attr_definition ( usr );
CREATE INDEX acq_picklist_owner_idx   ON acq.picklist ( owner );
CREATE INDEX acq_picklist_creator_idx ON acq.picklist ( creator );
CREATE INDEX acq_picklist_editor_idx  ON acq.picklist ( editor );
CREATE INDEX acq_po_note_creator_idx  ON acq.po_note ( creator );
CREATE INDEX acq_po_note_editor_idx   ON acq.po_note ( editor );
CREATE INDEX po_creator_idx           ON acq.purchase_order ( creator );
CREATE INDEX po_editor_idx            ON acq.purchase_order ( editor );

-- 090.schema.action.sql
CREATE INDEX circ_all_usr_idx                   ON action.circulation ( usr );
CREATE INDEX circ_circ_staff_idx                ON action.circulation ( circ_staff );
CREATE INDEX circ_checkin_staff_idx             ON action.circulation ( checkin_staff );
CREATE INDEX ahn_notify_staff_idx               ON action.hold_notification ( notify_staff );
CREATE INDEX hold_request_fulfillment_staff_idx ON action.hold_request ( fulfillment_staff );
CREATE INDEX hold_request_requestor_idx         ON action.hold_request ( requestor );
CREATE INDEX action_in_house_use_staff_idx      ON action.in_house_use ( staff );
CREATE INDEX non_cat_in_house_use_staff_idx     ON action.non_cat_in_house_use ( staff );
CREATE INDEX action_non_cat_circ_patron_idx     ON action.non_cataloged_circulation ( patron );
CREATE INDEX action_non_cat_circ_staff_idx      ON action.non_cataloged_circulation ( staff );
CREATE INDEX action_survey_response_usr_idx     ON action.survey_response ( usr );

-- 005.schema.actors.sql
CREATE INDEX actor_usr_note_creator_idx           ON actor.usr_note ( creator );
CREATE INDEX usr_org_unit_opt_in_staff_idx        ON actor.usr_org_unit_opt_in ( staff );
CREATE INDEX actor_usr_standing_penalty_staff_idx ON actor.usr_standing_penalty ( staff );

-- 040.schema.asset.sql
CREATE INDEX asset_call_number_note_creator_idx   ON asset.call_number_note ( creator );
CREATE INDEX cp_creator_idx                       ON asset.copy ( creator );
CREATE INDEX cp_editor_idx                        ON asset.copy ( editor );
CREATE INDEX asset_copy_note_creator_idx          ON asset.copy_note ( creator );

-- 901.audit-tables.sql
CREATE INDEX aud_actor_usr_address_hist_id_idx    ON auditor.actor_usr_address_history ( id );
CREATE INDEX aud_actor_usr_hist_id_idx            ON auditor.actor_usr_history ( id );
CREATE INDEX aud_asset_cn_hist_creator_idx        ON auditor.asset_call_number_history ( creator );
CREATE INDEX aud_asset_cn_hist_editor_idx         ON auditor.asset_call_number_history ( editor );
CREATE INDEX aud_asset_cp_hist_creator_idx        ON auditor.asset_copy_history ( creator );
CREATE INDEX aud_asset_cp_hist_editor_idx         ON auditor.asset_copy_history ( editor );
CREATE INDEX aud_bib_rec_entry_hist_creator_idx   ON auditor.biblio_record_entry_history ( creator );
CREATE INDEX aud_bib_rec_entry_hist_editor_idx    ON auditor.biblio_record_entry_history ( editor );

-- 070.schema.container.sql
CREATE INDEX user_bucket_item_target_user_idx     ON container.user_bucket_item ( target_user );

-- 080.schema.money.sql
CREATE INDEX m_c_t_collector_idx                  ON money.collections_tracker ( collector );

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13615 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoflesh hold notes on retrieve by id
erickson [Thu, 16 Jul 2009 16:25:04 +0000 (16:25 +0000)]
flesh hold notes on retrieve by id

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13614 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoGive cataloguers a chance to recover from errors, or add holdings to an empty MFHD...
dbs [Thu, 16 Jul 2009 05:53:11 +0000 (05:53 +0000)]
Give cataloguers a chance to recover from errors, or add holdings to an empty MFHD record

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13611 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoin duplicate patron search, sort patrons with penalties to the top, followed by last...
erickson [Wed, 15 Jul 2009 20:15:00 +0000 (20:15 +0000)]
in duplicate patron search, sort patrons with penalties to the top, followed by last/first name sorting

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13610 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoeh, still didn't think it through. so much for one changeset :)
phasefx [Wed, 15 Jul 2009 19:20:42 +0000 (19:20 +0000)]
eh, still didn't think it through.  so much for one changeset :)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13609 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agodidn't mean to leave param2 and param3 in there
phasefx [Wed, 15 Jul 2009 19:19:21 +0000 (19:19 +0000)]
didn't mean to leave param2 and param3 in there

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13608 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoNot tested, but let the keys 'search_limit' and 'search_sort' be useable in the JSON...
phasefx [Wed, 15 Jul 2009 19:17:50 +0000 (19:17 +0000)]
Not tested, but let the keys 'search_limit' and 'search_sort' be useable in the JSON-encoded 'query' object that pre-populates the search fields in search_form.xul when spawned by say, the patron editor

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13607 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agopatch from Mike R. to provide an option to sort user search results on the number...
erickson [Wed, 15 Jul 2009 17:05:18 +0000 (17:05 +0000)]
patch from Mike R. to provide an option to sort user search results on the number of outstanding penalties a user has

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13606 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoIn actor.usr_delete(): correct the mistreatment of the profile column.
scottmk [Wed, 15 Jul 2009 17:04:42 +0000 (17:04 +0000)]
In actor.usr_delete(): correct the mistreatment of the profile column.
It points to permission.grp_tree, not to actor.org_unit.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13605 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agocheck for a null circ mod on an item when doing a non-null circ_mod test
miker [Wed, 15 Jul 2009 16:48:39 +0000 (16:48 +0000)]
check for a null circ mod on an item when doing a non-null circ_mod test

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13602 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoProtect against duplicate Located URIs at ingest time
miker [Wed, 15 Jul 2009 16:12:55 +0000 (16:12 +0000)]
Protect against duplicate Located URIs at ingest time

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13599 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agorepaired missing ; after COMMENT
erickson [Wed, 15 Jul 2009 15:01:59 +0000 (15:01 +0000)]
repaired missing ; after COMMENT

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13597 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agopatched up some logic bugs, fixed some typos
erickson [Wed, 15 Jul 2009 14:06:37 +0000 (14:06 +0000)]
patched up some logic bugs, fixed some typos

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13596 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoIn verifyObjectPCRUD: pull the lookup of the root org_unit id into
scottmk [Wed, 15 Jul 2009 12:22:34 +0000 (12:22 +0000)]
In verifyObjectPCRUD: pull the lookup of the root org_unit id into
a separate function.  Cache the results for up to an hour, in order
to reduce the repetition of identical queries getting identical results.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13595 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoUndoing previous misguided commit
scottmk [Wed, 15 Jul 2009 01:11:44 +0000 (01:11 +0000)]
Undoing previous misguided commit

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13594 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoCorrect a syntax error where '$func$' appeared in the place of '$$'
scottmk [Tue, 14 Jul 2009 23:27:48 +0000 (23:27 +0000)]
Correct a syntax error where '$func$' appeared in the place of '$$'

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13593 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadded seed data for org-unit setting
erickson [Tue, 14 Jul 2009 20:08:41 +0000 (20:08 +0000)]
added seed data for org-unit setting

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13592 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agowhen patron checks out an item and they have no holds that directly target the item,
erickson [Tue, 14 Jul 2009 19:57:29 +0000 (19:57 +0000)]
when patron checks out an item and they have no holds that directly target the item,
allow for a setting that tells the system to look for an alternate hold to fulfil the item.

also cleaned up some unnecessarily complicated checkout hold fulfil code

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13591 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoCorrecting some careless typos...
scottmk [Tue, 14 Jul 2009 18:42:30 +0000 (18:42 +0000)]
Correcting some careless typos...

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13590 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoAdd tables from the auditor schema to actor.usr_purge_data().
scottmk [Tue, 14 Jul 2009 18:22:34 +0000 (18:22 +0000)]
Add tables from the auditor schema to actor.usr_purge_data().

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13589 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoFor the id_list methods: build the SELECT clause directly
scottmk [Tue, 14 Jul 2009 17:12:01 +0000 (17:12 +0000)]
For the id_list methods: build the SELECT clause directly
instead of incurring the overhead of jsonParseStringFmt().

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13588 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoPatch from James Fournie -- fixing org tree fleshing depth.
erickson [Tue, 14 Jul 2009 16:36:52 +0000 (16:36 +0000)]
Patch from James Fournie -- fixing org tree fleshing depth.

====
I was having a horrible time getting the hasCommonAncestor() function
to work in the circ Javascripts.  I eventually discovered that
ScriptBuilder.pm was making a cstore actor.org_unit search with flesh
= 2, which limited the search to org units above depth 2.  My org
units were depth 3.  I changed the cstore flesh to -1 and this seems
to retreive all org units.  I also found an similar problem in
AppUtils.pm

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13584 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoTweaks to oils_cstore.c:
scottmk [Tue, 14 Jul 2009 13:30:41 +0000 (13:30 +0000)]
Tweaks to oils_cstore.c:

1. Added a couple of const qualifiers.

2. In verifyObjectPCRUD: renamed meta to method_metadata, for clarity.
In many places we use "meta" for class metadata.

3. In verifyObjectPCRUD: when looking for the root of the org tree,
build the where clause object directly instead of incurring the overhead
of jsonParseString().

4. A few lines further down: free the where clause object in only
a single place.

5. In single_hash(): represent a NULL value as a JSON_NULL.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13583 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoEnhance RefWorks support on a per-skin basis:
dbs [Tue, 14 Jul 2009 02:24:21 +0000 (02:24 +0000)]
Enhance RefWorks support on a per-skin basis:
  * Add the ability to disable it entirely (rdetailEnableRefWorks variable)
  * Add the ability to specify a different host for the RefWorks application (rdetailRefWorksHost)

Also, collect the growing list of configuration variables in rdetail.js at the head of the file.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13580 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadded duplicate phone / address searching. added and started using locale strings...
erickson [Mon, 13 Jul 2009 19:12:33 +0000 (19:12 +0000)]
added duplicate phone / address searching.  added and started using locale strings bundle

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13579 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoAdd two functions to the actor schema:
scottmk [Mon, 13 Jul 2009 18:03:45 +0000 (18:03 +0000)]
Add two functions to the actor schema:

usr_purge_data: purges rows associated with a given user, by either
deleting them or reassigning them to another user.

usr_delete: logically deletes a user; removes personally identifiable
information, and purges associated rows in other tables.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13578 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agouse new dojo-ified patron edit interface by default
erickson [Mon, 13 Jul 2009 17:29:37 +0000 (17:29 +0000)]
use new dojo-ified patron edit interface by default

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13577 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoBasic fix for reporter as of rel_1_6 and the super-smart cstore
dbs [Mon, 13 Jul 2009 16:23:59 +0000 (16:23 +0000)]
Basic fix for reporter as of rel_1_6 and the super-smart cstore

As virtual fields are no longer defined in fm_IDL.xml, the old code that returned
a list of fields filtering on the virtual attribute started returning an empty list.

As a quick fix, we'll just return an array of all field elements.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13574 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoforce the staff flag to true for staff-created notes
erickson [Mon, 13 Jul 2009 16:22:10 +0000 (16:22 +0000)]
force the staff flag to true for staff-created notes

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13573 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadded 'staff' column to indicate a staff-created hold note
erickson [Mon, 13 Jul 2009 15:17:51 +0000 (15:17 +0000)]
added 'staff' column to indicate a staff-created hold note

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13572 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agocapture the timeout argument to json_query
erickson [Mon, 13 Jul 2009 13:31:48 +0000 (13:31 +0000)]
capture the timeout argument to json_query

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13567 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoPlug a couple of memory leaks.
scottmk [Sat, 11 Jul 2009 22:22:47 +0000 (22:22 +0000)]
Plug a couple of memory leaks.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13566 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoUpdate to latest libyaz; install z39.50 server library out of the box
dbs [Sat, 11 Jul 2009 04:41:36 +0000 (04:41 +0000)]
Update to latest libyaz; install z39.50 server library out of the box

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13563 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agodtd entity for new usr_summary column in stat cat editor
erickson [Fri, 10 Jul 2009 14:47:23 +0000 (14:47 +0000)]
dtd entity for new usr_summary column in stat cat editor

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13562 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agousing new penalty org depth when setting invalid addr penalty. created const for...
erickson [Fri, 10 Jul 2009 14:46:30 +0000 (14:46 +0000)]
using new penalty org depth when setting invalid addr penalty.  created const for penalty name

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13561 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadded ancestor at depth util function
erickson [Fri, 10 Jul 2009 14:45:50 +0000 (14:45 +0000)]
added ancestor at depth util function

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13560 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadded support for setting usr_summary column on actor stat cats
erickson [Thu, 9 Jul 2009 21:19:04 +0000 (21:19 +0000)]
added support for setting usr_summary column on actor stat cats

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13559 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadded usr_summary column to storage since most of the stat-cat mgmnt code is still...
erickson [Thu, 9 Jul 2009 20:10:48 +0000 (20:10 +0000)]
added usr_summary column to storage since most of the stat-cat mgmnt code is still using storage

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13558 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agodon't force a depth on the call to actor.org_unit_full_path. if no depth is requeste...
erickson [Thu, 9 Jul 2009 20:10:16 +0000 (20:10 +0000)]
don't force a depth on the call to actor.org_unit_full_path.  if no depth is requested, call the no-depth version of the function

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13557 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoAdd new column org_depth to config.standing_penalty.
scottmk [Thu, 9 Jul 2009 18:45:54 +0000 (18:45 +0000)]
Add new column org_depth to config.standing_penalty.

SQL to alter existing table:

alter table config.standing_penalty
add column org_depth integer;

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13556 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadded invalid patron address penalty creation/deletion. need to add penalty org_dept...
erickson [Thu, 9 Jul 2009 14:31:44 +0000 (14:31 +0000)]
added invalid patron address penalty creation/deletion.  need to add penalty org_depth logic

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13555 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadded another user penalty fetcher which just returns the flat list of penalties
erickson [Thu, 9 Jul 2009 14:28:36 +0000 (14:28 +0000)]
added another user penalty fetcher which just returns the flat list of penalties

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13554 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoThe introduction of codecs broke this script. Fun!
dbs [Thu, 9 Jul 2009 03:19:31 +0000 (03:19 +0000)]
The introduction of codecs broke this script. Fun!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13551 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoMore codecs conversion for i18n scripts
dbs [Thu, 9 Jul 2009 03:13:15 +0000 (03:13 +0000)]
More codecs conversion for i18n scripts

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13550 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoBring the magic of codecs to the i18n script masses
dbs [Thu, 9 Jul 2009 03:06:20 +0000 (03:06 +0000)]
Bring the magic of codecs to the i18n script masses

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13549 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoNeed to generate the opac.js Dojo string file, too
dbs [Thu, 9 Jul 2009 02:54:35 +0000 (02:54 +0000)]
Need to generate the opac.js Dojo string file, too

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13546 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoReproduced miker's problem building i18n on a clean Debian Lenny system. codecs,...
dbs [Thu, 9 Jul 2009 02:13:05 +0000 (02:13 +0000)]
Reproduced miker's problem building i18n on a clean Debian Lenny system. codecs, to the rescue!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13541 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoFix calculation of of date correction.
djfiander [Wed, 8 Jul 2009 21:42:54 +0000 (21:42 +0000)]
Fix calculation of of date correction.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13540 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoComment out some debugging statements I checked in by accident.
djfiander [Wed, 8 Jul 2009 21:40:00 +0000 (21:40 +0000)]
Comment out some debugging statements I checked in by accident.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13539 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoAdd a new boolean column usr_summary to actor.stat_cat.
scottmk [Wed, 8 Jul 2009 17:27:10 +0000 (17:27 +0000)]
Add a new boolean column usr_summary to actor.stat_cat.

SQL to apply this change to an existing table:

alter table actor.stat_cat
add column usr_summary boolean not null default false;

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13532 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadded functionality of searching for patron via barcode or rdbms-given id, changes...
lmcfarland [Wed, 8 Jul 2009 17:21:47 +0000 (17:21 +0000)]
added functionality of searching for patron via barcode or rdbms-given id, changes are inactive by default, setting id_as_barcode to true will enable.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13531 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoif alerting on empty bibs and not overriding, return the alert. if overriding or...
erickson [Wed, 8 Jul 2009 15:48:41 +0000 (15:48 +0000)]
if alerting on empty bibs and not overriding, return the alert.  if overriding or not alerting, do the delete (if keep on empty if not set)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13526 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agodon't fuss if staff do not override TITLE_LAST_COPY here
phasefx [Wed, 8 Jul 2009 15:45:12 +0000 (15:45 +0000)]
don't fuss if staff do not override TITLE_LAST_COPY here

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13525 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoTITLE_LAST_COPY override for batch copy delete in bucket interface. Need to test
phasefx [Wed, 8 Jul 2009 15:42:57 +0000 (15:42 +0000)]
TITLE_LAST_COPY override for batch copy delete in bucket interface.  Need to test

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13524 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadded invalid addr penalty and org-unit setting to enable use of said penalty
erickson [Wed, 8 Jul 2009 14:09:34 +0000 (14:09 +0000)]
added invalid addr penalty and org-unit setting to enable use of said penalty

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13523 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agouse dynamic bucket item class name for notes fleshing
erickson [Wed, 8 Jul 2009 13:50:53 +0000 (13:50 +0000)]
use dynamic bucket item class name for notes fleshing

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13522 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoAdd an ON DELETE CASCADE clause to the foreign key pointing
scottmk [Wed, 8 Jul 2009 04:43:03 +0000 (04:43 +0000)]
Add an ON DELETE CASCADE clause to the foreign key pointing
from action.hold_notification to action.hold_request.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13521 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoRefactor to pass around array refs instead of long lists. Generalize on_or_before()
djfiander [Wed, 8 Jul 2009 02:51:48 +0000 (02:51 +0000)]
Refactor to pass around array refs instead of long lists. Generalize on_or_before()

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13520 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoAdd more evil test cases
djfiander [Wed, 8 Jul 2009 00:32:42 +0000 (00:32 +0000)]
Add more evil test cases

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13519 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoFix a call to DateTime::clone() that I missed the other day
djfiander [Wed, 8 Jul 2009 00:32:27 +0000 (00:32 +0000)]
Fix a call to DateTime::clone() that I missed the other day

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13518 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadded an additional status of 5 for holds. if a captured copy is still within the...
erickson [Tue, 7 Jul 2009 20:51:28 +0000 (20:51 +0000)]
added an additional status of 5 for holds.  if a captured copy is still within the hold-shelf-status-delay interval, return status 5

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13517 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadded the hold-shelf-status-delay setting with description
erickson [Tue, 7 Jul 2009 20:33:13 +0000 (20:33 +0000)]
added the hold-shelf-status-delay setting with description

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13516 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agooops, meant to check pickup-lib, not requesting lib.
erickson [Tue, 7 Jul 2009 20:04:09 +0000 (20:04 +0000)]
oops, meant to check pickup-lib, not requesting lib.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13515 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agowhitespace, locale, and no chrome skin in remote xul other than chrome:://global...
phasefx [Tue, 7 Jul 2009 15:49:33 +0000 (15:49 +0000)]
whitespace, locale, and no chrome skin in remote xul other than chrome:://global/skin

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13514 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoMore tinkering with oils_cstore.c:
scottmk [Tue, 7 Jul 2009 14:32:12 +0000 (14:32 +0000)]
More tinkering with oils_cstore.c:

1. In a couple of spots: replaced jsonObjectClone() with
jsonObjectExtractIndex(), so that we can use an existing
object instead of copying it.

2. In verifyObjectClass(): protected against formatting a NULL
into an error message.

3. In verifyObjectPCRUD(): eliminated a pointless strdup().

4. Rearranged doRetrieve() a bit for clarity, and renamed some
variables for the same reason.  Also added a couple of comments.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13513 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoAdd some more complex publication patterns, fix code so they pass.
djfiander [Tue, 7 Jul 2009 01:21:39 +0000 (01:21 +0000)]
Add some more complex publication patterns, fix code so they pass.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13512 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoDon't need DateTime in this file any more, now that there's
djfiander [Mon, 6 Jul 2009 23:45:15 +0000 (23:45 +0000)]
Don't need DateTime in this file any more, now that there's
MFHD::Date, so don't include it here.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13511 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoIn oils_cstore.c: converted several iterator loops to indexed loops.
scottmk [Mon, 6 Jul 2009 15:06:57 +0000 (15:06 +0000)]
In oils_cstore.c: converted several iterator loops to indexed loops.

doFieldMapperSearch always returns a JSON_ARRAY (or NULL).  It is
more efficient to traverse such an array with a subscript than with
a jsonIterator, because a subscript doesn't require a malloc and free.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13510 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoOrder copy locations by name by default; useful for shelving location filter in advan...
dbs [Mon, 6 Jul 2009 03:09:48 +0000 (03:09 +0000)]
Order copy locations by name by default; useful for shelving location filter in advanced search

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13509 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoMore tweaks to oils_cstore.c:
scottmk [Sun, 5 Jul 2009 21:42:54 +0000 (21:42 +0000)]
More tweaks to oils_cstore.c:

1. In osrfAppInitialize(): reuse the growing_buffer method_name
instead of repeatedly destroying and recreating it.  That should
save hundreds of mallocs and frees in the initialization.

2. Also in osrfAppInitialize(): correct an inaccurate debug
message, and rearrange a few lines for clarity.

3. Throughout: replace the dbi_get_* functions, which do lookups
by name, with the corresponding dbi_get_*_idx functions, which
do lookups by index.  Lookups by index are faster than lookups
by name, because they don't have to do a search.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13508 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoUnbelievably, not all systems have Python 2.6 yet!
dbs [Sun, 5 Jul 2009 17:44:55 +0000 (17:44 +0000)]
Unbelievably, not all systems have Python 2.6 yet!

Use the exception handling method supported by previous Python versions

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13503 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoTweaks to osrfAppInitialize() in oils_cstore.c:
scottmk [Sun, 5 Jul 2009 12:47:11 +0000 (12:47 +0000)]
Tweaks to osrfAppInitialize() in oils_cstore.c:

1. Move some invariant tests out of the inner loop.

2. Plugged a memory leak by freeing the array of class names.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13502 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoSeveral tweaks to oils_cstore.c:
scottmk [Sun, 5 Jul 2009 11:09:14 +0000 (11:09 +0000)]
Several tweaks to oils_cstore.c:

1. Added a utility function single_hash() to create simple WHERE
clauses instead of calling jsonParseStringFmt().  This change
avoids the overhead of creating and then parsing a JSON string.

2. In SELECT(), processing an ORDER BY clause: traverse a
JSON_ARRAY with an index instead of an iterator.  This change
avoids some mallocs and frees -- and also plugs a memory leak,
since we weren't freeing the iterator.

3. Also in SELECT(), processing an ORDER BY clause: free the
iterator that we use for traversing the hash of classes.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13501 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoFix SQL translation script and associated unit tests
dbs [Sun, 5 Jul 2009 05:28:40 +0000 (05:28 +0000)]
Fix SQL translation script and associated unit tests

It looks like polib became stricter about forcing the line number portion of
filename:line occurrences in the PO to actually be an integer, with the result
of simply concatenating the text "line numbers" that we had been using to
store ID values to the table names.

Now we're using specially formatted translator comments to hold the ID values,
and using the filename:line occurence entries to actually hold the source filename
and line number for occurrences. Fancy that!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13500 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoChange the interface to doFieldMapperSearch(), and reap some performance
scottmk [Sat, 4 Jul 2009 19:01:35 +0000 (19:01 +0000)]
Change the interface to doFieldMapperSearch(), and reap some performance
gains that this change makes possible.

Instead of passing the query as two jsonObjects wrapped in a JSON_ARRAY,
pass them as separate parameters.  This change makes it possible to
avoid the overhead of constructing a single package to bundle them both.

The resulting code is also, to my eyes, easier to read.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13499 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoRemove dangling semicolon from PerlChildInitHandler
dbs [Fri, 3 Jul 2009 20:55:31 +0000 (20:55 +0000)]
Remove dangling semicolon from PerlChildInitHandler

Thanks to Jeff Godin for pointing this out!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13494 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agodon't throw exception when auth session is not found. just return undef. updated...
erickson [Thu, 2 Jul 2009 20:30:56 +0000 (20:30 +0000)]
don't throw exception when auth session is not found.  just return undef.  updated related code

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13493 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoRequests for added content fail all the time; don't pollute the logs with bogus errors
dbs [Thu, 2 Jul 2009 18:14:16 +0000 (18:14 +0000)]
Requests for added content fail all the time; don't pollute the logs with bogus errors

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13492 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoGive unAPI and friends the ability to redirect to an OPAC with a specific locale...
dbs [Thu, 2 Jul 2009 02:06:07 +0000 (02:06 +0000)]
Give unAPI and friends the ability to redirect to an OPAC with a specific locale and skin

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13491 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoIn usr_merge(): when merging rows from reporter.*_folder,
scottmk [Tue, 30 Jun 2009 14:25:00 +0000 (14:25 +0000)]
In usr_merge(): when merging rows from reporter.*_folder,
change the name in order to avoid collisions with existing
rows belonging to the destination user.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13490 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoIn actor.usr_merge(): when transferring rows from vandelay.queue,
scottmk [Tue, 30 Jun 2009 13:06:20 +0000 (13:06 +0000)]
In actor.usr_merge(): when transferring rows from vandelay.queue,
change the name in order to avoid collisions with existing rows
belonging to the destination user.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13489 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoTreat SRU queries as UTF8 input.
dbs [Tue, 30 Jun 2009 02:56:54 +0000 (02:56 +0000)]
Treat SRU queries as UTF8 input.

Resolves a problem whereby any non-ASCII input in SRU queries resulted in searches for corrupted strings (and consequently 0 hits)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13486 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadd tests for weekly publication, fix bug in code for "day" publication patterns
djfiander [Tue, 30 Jun 2009 01:50:10 +0000 (01:50 +0000)]
add tests for weekly publication, fix bug in code for "day" publication patterns

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13485 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoIn actor.usr_merge(): transfer picklists with changes of the
scottmk [Mon, 29 Jun 2009 23:03:48 +0000 (23:03 +0000)]
In actor.usr_merge(): transfer picklists with changes of the
name column so as to avoid collisions with existing picklists.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13484 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agofetch org setting types from server now. yay.
erickson [Mon, 29 Jun 2009 21:14:29 +0000 (21:14 +0000)]
fetch org setting types from server now.  yay.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13483 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agomenu entry for org-unit-setting-type editor
erickson [Mon, 29 Jun 2009 20:10:43 +0000 (20:10 +0000)]
menu entry for org-unit-setting-type editor

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13482 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoIn actor.usr_merge(): For each *_bucket table, transfer the buckets
scottmk [Mon, 29 Jun 2009 18:53:51 +0000 (18:53 +0000)]
In actor.usr_merge(): For each *_bucket table, transfer the buckets
belonging to the source user into the custody of the destination user.

In order to avoid colliding with an existing bucket owned by the
destination user, append the source user's id (in parenthesese) to the
name.  If you still get a collision, add successive spaces to the name
and keep trying until you succeed.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13481 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoforce valid org-unit-setting name when updating settings
erickson [Mon, 29 Jun 2009 17:44:49 +0000 (17:44 +0000)]
force valid org-unit-setting name when updating settings

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13480 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoAdd new table config.org_unit_setting_type to define
scottmk [Mon, 29 Jun 2009 15:46:40 +0000 (15:46 +0000)]
Add new table config.org_unit_setting_type to define
valid setting names for actor.org_unit_setting.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@13479 dcc99617-32d9-48b4-a31d-7c20da2025e4