summary |
shortlog | log |
commit |
commitdiff |
tree
first ⋅ prev ⋅ next
djfiander [Fri, 26 May 2006 02:12:26 +0000 (02:12 +0000)]
Fix bugs in Patron Enable: A valid patron with an invalid
password should generate a true patron status message, but
shouldn't enable the patron.
Fix language handling in Block Patron: return the patron's
language, rather than sending 'unknown'.
djfiander [Sun, 21 May 2006 13:56:40 +0000 (13:56 +0000)]
Initial set of tests for Checkout Response
djfiander [Sun, 21 May 2006 13:52:51 +0000 (13:52 +0000)]
Eliminate warning message for uninitialized variable use
djfiander [Fri, 19 May 2006 02:30:52 +0000 (02:30 +0000)]
Fix spelling mistake
djfiander [Fri, 19 May 2006 02:30:21 +0000 (02:30 +0000)]
Fix handling of the "renewal ok" status field in the ILS
djfiander [Wed, 17 May 2006 02:50:02 +0000 (02:50 +0000)]
Finish first pass at ILS::Patron documentation
djfiander [Tue, 16 May 2006 01:44:00 +0000 (01:44 +0000)]
Initial, incomplete, documentation for ILS::Patron
djfiander [Tue, 16 May 2006 01:40:29 +0000 (01:40 +0000)]
Missed an unused function in the last code cleanup
djfiander [Tue, 16 May 2006 01:37:29 +0000 (01:37 +0000)]
Code cleanups
djfiander [Mon, 15 May 2006 00:16:42 +0000 (00:16 +0000)]
Initial pass at documentation for ILS::Item
djfiander [Mon, 15 May 2006 00:15:36 +0000 (00:15 +0000)]
Delete unused access method
djfiander [Mon, 15 May 2006 00:15:11 +0000 (00:15 +0000)]
Add code to build HTML documentation from the podfiles.
djfiander [Mon, 15 May 2006 00:14:27 +0000 (00:14 +0000)]
Finish first pass at documentation for ILS module
djfiander [Sun, 14 May 2006 11:40:39 +0000 (11:40 +0000)]
Minor code cleanups
djfiander [Thu, 4 May 2006 01:24:52 +0000 (01:24 +0000)]
Adjust tests to agree with the code. Since the server reports
that a patron is valid, but the password was wrong, we need to
make sure that that's what the tests expect.
djfiander [Thu, 4 May 2006 01:24:09 +0000 (01:24 +0000)]
Sequence numbers are a single digit, so when it hits 10, wrap
around to 0.
djfiander [Thu, 4 May 2006 01:23:28 +0000 (01:23 +0000)]
Adjust the test data so that it works with the test cases.
djfiander [Thu, 4 May 2006 01:22:54 +0000 (01:22 +0000)]
If the patron is valid, but the patron password is provided, and
wrong, still report that the patron's good. This seems to be
what clients are expecting, and since we can "trust" them, we
will give them full disclosure.
djfiander [Thu, 4 May 2006 01:21:42 +0000 (01:21 +0000)]
'0' is a valid sequence number (it comes after '9'), so we have
to see if the sequence number is set, not just if it's true.
djfiander [Sun, 30 Apr 2006 12:17:18 +0000 (12:17 +0000)]
minor cleanups
djfiander [Sun, 30 Apr 2006 01:20:47 +0000 (01:20 +0000)]
Add a bunch of tests, and stock field checks
djfiander [Sun, 30 Apr 2006 01:20:01 +0000 (01:20 +0000)]
Make sure to set BL: Patron Valid when the patron is, in fact,
valid (uncovered by the tests)
djfiander [Sun, 30 Apr 2006 01:19:22 +0000 (01:19 +0000)]
Fix formatting, export FID_PATRON_BIRTHDATE FID_PATRON_CLASS
djfiander [Sun, 30 Apr 2006 00:15:04 +0000 (00:15 +0000)]
Add support for FID_PATRON_BIRTHDATE (PB) and FID_PATRON_CLASS
(PC) to Patron Information Response, for Envisionware terminals.
djfiander [Sun, 30 Apr 2006 00:13:48 +0000 (00:13 +0000)]
Add stub methods sip_birthdate and ptype, to support Envisionware
terminals (and probably others).
djfiander [Sun, 30 Apr 2006 00:12:59 +0000 (00:12 +0000)]
Change port for raw socket connection from 5300 (chosen at random
by your's truly) to 6001, as per Envisionware email.
djfiander [Wed, 26 Apr 2006 14:37:19 +0000 (14:37 +0000)]
Very basic tests. This will be a big test case. I suspect that
the test harness will have to be enhanced in a variety of ways,
including some way of indicating fields that SHOULD NOT appear,
as well as just fields that are required.
djfiander [Wed, 26 Apr 2006 14:35:20 +0000 (14:35 +0000)]
Generalize handling of tagged fields, so we can reuse field
specifications between test scenarios.
djfiander [Wed, 26 Apr 2006 14:33:39 +0000 (14:33 +0000)]
Fix Patron Information message handling to parallel the situation
in the handling of Patron Status messages: if the password's not
provided by the terminal, then we don't worry about checking the
password, but if the terminal gives us the password, then it has
to match before we say anything about the patron.
djfiander [Wed, 26 Apr 2006 14:19:52 +0000 (14:19 +0000)]
Replace call to nonexistent method 'hold_items_count' with
correct code.
djfiander [Wed, 26 Apr 2006 13:34:31 +0000 (13:34 +0000)]
Return an item title, even if the checkout failed (assuming that
the item ID was valid).
djfiander [Wed, 26 Apr 2006 13:31:22 +0000 (13:31 +0000)]
Clean up handling of Patron Status Response messages when there's
no password provided by the terminal. I have a strong suspicion
that there exist terminals that expect to get patron status or
patron information even if they don't provide a password.
djfiander [Wed, 26 Apr 2006 01:19:53 +0000 (01:19 +0000)]
Create code to test tagged field values, create tests for Patron
Status message
djfiander [Fri, 21 Apr 2006 02:18:47 +0000 (02:18 +0000)]
Initial test environment
djfiander [Fri, 21 Apr 2006 02:15:43 +0000 (02:15 +0000)]
Clean up handling of SIP boolean flags, and fix interface to
write_msg(). Since it never used the $server parameter, get rid
of it, and add an optional $file parameter, so that write_msg()
can be use by the test harness.
djfiander [Wed, 19 Apr 2006 00:03:55 +0000 (00:03 +0000)]
Remove hold_items_count method, and move the code to drop a hold
into a Patron method, rather than embedding it in the ils
transaction level.
djfiander [Sun, 16 Apr 2006 15:50:16 +0000 (15:50 +0000)]
Implement code to handle Renew All messages.
Minor cleanups.
Move add_count() into Sip.pm
Consistently use methods to access fields in Transaction status
objects.
djfiander [Sun, 16 Apr 2006 15:47:29 +0000 (15:47 +0000)]
Minor cleanups.
djfiander [Sun, 16 Apr 2006 15:47:07 +0000 (15:47 +0000)]
Minor cleanups.
move available() method out of Transaction and into Item.
djfiander [Sun, 16 Apr 2006 15:46:04 +0000 (15:46 +0000)]
add messages for Renew, Renew All, and Patron Enable
djfiander [Sun, 16 Apr 2006 15:44:56 +0000 (15:44 +0000)]
Move add_count() to Sip.pm from Sip::MsgType.pm
djfiander [Sun, 16 Apr 2006 15:44:23 +0000 (15:44 +0000)]
Implement stubs necessary for Renew All support.
Consistently use methods to access fields rather than getting
at the fields directly.
djfiander [Sun, 16 Apr 2006 15:43:11 +0000 (15:43 +0000)]
Switch to AUTOLOAD-based field access
djfiander [Sun, 16 Apr 2006 01:40:34 +0000 (01:40 +0000)]
Stub code to handle renewals
djfiander [Sun, 16 Apr 2006 01:39:47 +0000 (01:39 +0000)]
Add stub code necessary to support item renewal
djfiander [Sun, 16 Apr 2006 01:39:26 +0000 (01:39 +0000)]
Add support for Renew message
djfiander [Sat, 15 Apr 2006 21:12:47 +0000 (21:12 +0000)]
Change IP on service so that it will work regardless of the IP of
the host.
djfiander [Sat, 15 Apr 2006 21:10:37 +0000 (21:10 +0000)]
Stub code to handle status returned by a "hold" transaction.
djfiander [Sat, 15 Apr 2006 15:45:07 +0000 (15:45 +0000)]
Clean up some test messages so they work against the existing
test stub. Add messages for placing and cancelling a hold.
djfiander [Sat, 15 Apr 2006 15:44:12 +0000 (15:44 +0000)]
Add support for Hold message
djfiander [Sat, 15 Apr 2006 15:43:10 +0000 (15:43 +0000)]
Add support for placing, altering, and cancelling holds
djfiander [Sat, 15 Apr 2006 00:45:00 +0000 (00:45 +0000)]
Use the new $patron->block() method. Implement support for the
Patron Enable message
djfiander [Sat, 15 Apr 2006 00:44:15 +0000 (00:44 +0000)]
Move block() from the ILS into the ILS::Patron. Create the
opposite enable() method to support the Patron Enable message
djfiander [Sat, 15 Apr 2006 00:43:20 +0000 (00:43 +0000)]
Get handling of institution IDs right. Make "block_patron" a
method of the ILS::Patron object, rather than an ILS method
djfiander [Fri, 14 Apr 2006 23:33:35 +0000 (23:33 +0000)]
Add support for Status Update message
djfiander [Fri, 14 Apr 2006 23:33:11 +0000 (23:33 +0000)]
Add stub to handle Status Update message
djfiander [Fri, 14 Apr 2006 20:07:32 +0000 (20:07 +0000)]
use the new ILS::check_inst_id to verify the institution ID that
we receive from the terminal.
Also implement support for Item Information message.
djfiander [Fri, 14 Apr 2006 20:06:24 +0000 (20:06 +0000)]
Added stub routines that provide support for the Item Information
Response message.
djfiander [Fri, 14 Apr 2006 20:05:41 +0000 (20:05 +0000)]
Sip::timestamp now takes an optional parameter (seconds since the
epoch) and generates a timestamp for that time. Default
continues to be timestamp of 'now'.
djfiander [Fri, 14 Apr 2006 20:04:27 +0000 (20:04 +0000)]
new ILS takes an institution configuration as input, so the name
of the ILS institution is the $institution->{id}
djfiander [Fri, 14 Apr 2006 19:59:29 +0000 (19:59 +0000)]
Added code to verify the institution id, and to manage due dates
within the stub item db.
djfiander [Fri, 14 Apr 2006 17:14:56 +0000 (17:14 +0000)]
Delete handling of "FID_FEE_ITEMS", since it doesn't exist (the
Patron Information Response message documentation is wrong).
Correct handling of Address, Email, and Home Phone fields in
Patron Information Response in response to corrections from 3M
djfiander [Fri, 14 Apr 2006 17:13:32 +0000 (17:13 +0000)]
Delete non-existent "FID_FEE_ITEMS", since we heard back from 3M
that the documentation about the Patron Information Response
message was incorrect.
djfiander [Wed, 12 Apr 2006 15:22:13 +0000 (15:22 +0000)]
Don't use "ILS::pay_fee()", use "$ils->pay_fee()"
djfiander [Wed, 12 Apr 2006 15:21:35 +0000 (15:21 +0000)]
Change label for tag generation
djfiander [Wed, 12 Apr 2006 15:20:54 +0000 (15:20 +0000)]
More documentation
djfiander [Wed, 12 Apr 2006 02:00:26 +0000 (02:00 +0000)]
Initial documentation for the ILS.pm portable interface between
the SIP code and the ILS.
miker-pines [Fri, 7 Apr 2006 02:29:56 +0000 (02:29 +0000)]
adding loadable module support
djfiander [Wed, 5 Apr 2006 01:58:43 +0000 (01:58 +0000)]
Base makefile that just simplifies some common operations
djfiander [Wed, 5 Apr 2006 01:53:33 +0000 (01:53 +0000)]
Stub for Fee Paid functionality. Right now this is all handled
in the Transaction module itself.
djfiander [Wed, 5 Apr 2006 01:52:32 +0000 (01:52 +0000)]
Implement stub support for Checkin operations in the ILS
djfiander [Wed, 5 Apr 2006 01:41:17 +0000 (01:41 +0000)]
Implement Superclass handlers necessary for Checkin and Fee Paid
djfiander [Wed, 5 Apr 2006 01:37:33 +0000 (01:37 +0000)]
Implement Checking and Fee Paid response messages
djfiander [Wed, 5 Apr 2006 01:36:43 +0000 (01:36 +0000)]
Fix calculation of ends of lists of items used in the Patron
Status Response message
djfiander [Wed, 5 Apr 2006 01:36:07 +0000 (01:36 +0000)]
Add support necessary for Checkin operation
djfiander [Wed, 5 Apr 2006 01:35:45 +0000 (01:35 +0000)]
Implement Checkin and Fee Payment stubs
djfiander [Wed, 5 Apr 2006 01:34:09 +0000 (01:34 +0000)]
Strip off error detection fields, since they're automatically
generated by the (Python) test harness anyway. This way it's
easier to cut/paste messages into the interactive test session (I
really must develop a real test harness).
Change some fields to match the test database hardcoded into the
ILS module.
djfiander [Wed, 29 Mar 2006 23:08:49 +0000 (23:08 +0000)]
Add support for End Patron Session message
djfiander [Wed, 29 Mar 2006 23:08:27 +0000 (23:08 +0000)]
Add end_patron_session stub
djfiander [Wed, 29 Mar 2006 01:53:17 +0000 (01:53 +0000)]
Added Patron Information request message
djfiander [Wed, 29 Mar 2006 01:52:37 +0000 (01:52 +0000)]
Move $last_response here from Sip/MsgType.pm
djfiander [Wed, 29 Mar 2006 01:51:56 +0000 (01:51 +0000)]
Restructure code to handle Patron Information message, move more
code into Sip.pm
djfiander [Wed, 29 Mar 2006 01:50:52 +0000 (01:50 +0000)]
Create stub APIs that provide information needed for Patron
Information Response message
djfiander [Sun, 26 Mar 2006 12:30:55 +0000 (12:30 +0000)]
Defined field identify FID_FEE_ITEMS. This field id isn't
defined by the specification, but it's required by the Patron
Information Response message. The current value is a place
holder (and a guess at the true value), until we can hear back
from 3M about what the correct value is.
djfiander [Sun, 26 Mar 2006 12:29:04 +0000 (12:29 +0000)]
Moved utility functions from Sip::Msgtype to here.
djfiander [Sun, 26 Mar 2006 12:28:29 +0000 (12:28 +0000)]
Add support for "Patron Information" message and move some
utility functions into Sip.pm, in an attempt to manage the size
of this file. In the long run, MsgType.pm will probably be split
into a set of files that collect similar sorts of messages
together.
djfiander [Wed, 22 Mar 2006 02:15:51 +0000 (02:15 +0000)]
changed service IP address
djfiander [Wed, 22 Mar 2006 02:08:33 +0000 (02:08 +0000)]
Create fields to store pending "screen message" and "print line",
initially needed for "Block Patron" messages.
djfiander [Wed, 22 Mar 2006 02:07:46 +0000 (02:07 +0000)]
"block patron" stub implemented. Basically just flag all the
patron actions as not allowed.
djfiander [Wed, 22 Mar 2006 02:06:42 +0000 (02:06 +0000)]
Block Patron implemented. This required extracting the guts of
the "Patron Status" message handler out into a utility function
since both "Block Patron" and "Patron Status" messages require a
"Patron Status Response" message.
djfiander [Tue, 21 Mar 2006 01:02:27 +0000 (01:02 +0000)]
Deleted sub y_or_n(), since it duplicates
Sip::MsgType::sipbool(), and that module is the only place it's
used.
djfiander [Tue, 21 Mar 2006 01:00:30 +0000 (01:00 +0000)]
Define subs that provide status information necessary for
handle_acs_status()
djfiander [Tue, 21 Mar 2006 00:59:25 +0000 (00:59 +0000)]
Delete vestigal build_checkout_failed subroutine, convert
handle_acs_status() to query status from ILS rather than from
configuration file.
djfiander [Tue, 21 Mar 2006 00:31:12 +0000 (00:31 +0000)]
Implement Checkout message type based on the new ILS interfaces.
djfiander [Tue, 21 Mar 2006 00:29:43 +0000 (00:29 +0000)]
Checkout transaction stub module. Derived from the Transaction
superclass.
djfiander [Tue, 21 Mar 2006 00:28:25 +0000 (00:28 +0000)]
Beginnings of the stub Transaction class. All ILS transactions
(checkout, renew, etc.) are derived from this base class.
djfiander [Tue, 21 Mar 2006 00:26:55 +0000 (00:26 +0000)]
Implement Checkout operation stub using the Transaction and
Transaction::Checkout modules.
djfiander [Tue, 21 Mar 2006 00:17:54 +0000 (00:17 +0000)]
Beginnings of the Item stub module: support for the Checkout
operation
djfiander [Tue, 21 Mar 2006 00:15:55 +0000 (00:15 +0000)]
Fix package name, initialize ILS module.
djfiander [Thu, 9 Mar 2006 03:22:32 +0000 (03:22 +0000)]
Initial revision