working/Evergreen.git
10 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into collab/berick/web-client-p3
Bill Erickson [Thu, 30 Jul 2015 16:27:28 +0000 (12:27 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into collab/berick/web-client-p3

10 years agoLP 1198465: Load negative balance test transactions in load_all.sql
Dan Wells [Wed, 29 Jul 2015 15:30:51 +0000 (11:30 -0400)]
LP 1198465: Load negative balance test transactions in load_all.sql

This commit integrates the SQL needed to setup negative balance
testing into the load_all.sql which loads the rest of the test data.

It also separates out the "reset" commands into a separate SQL file.
They are useful when doing repeated testing, but unnecessary and
may eventually require manual tweaking, so they are provided here as a
convenience only.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
10 years agoLP 1198465: Move negative balance test xacts into sample data
Dan Wells [Wed, 29 Jul 2015 15:04:24 +0000 (11:04 -0400)]
LP 1198465: Move negative balance test xacts into sample data

It makes more sense for this to live with the other sample data, so
let's put it there.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
10 years agoLP 1198465: Add missing util function for tests
Dan Wells [Wed, 29 Jul 2015 14:48:28 +0000 (10:48 -0400)]
LP 1198465: Add missing util function for tests

do_checkin_override() is needed for the new tests, but was missing
from the branch.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
10 years agobrowser: closed dates / research missing dump() func
Bill Erickson [Wed, 29 Jul 2015 13:33:26 +0000 (09:33 -0400)]
browser: closed dates / research missing dump() func

Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agobrowser client local admin re-org 2
Bill Erickson [Sat, 25 Jul 2015 18:11:00 +0000 (14:11 -0400)]
browser client local admin re-org 2

Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agobrowser client local admin re-org; adding new links
Bill Erickson [Sat, 25 Jul 2015 18:10:37 +0000 (14:10 -0400)]
browser client local admin re-org; adding new links

Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agobrowser client: starting local admin landing page
Bill Erickson [Fri, 24 Jul 2015 02:35:47 +0000 (22:35 -0400)]
browser client: starting local admin landing page

Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoLP#1477677 - fix JS TypeError that prevents stat cats from displaying in stat cat...
Jeff Davis [Mon, 1 Jun 2015 23:16:25 +0000 (16:16 -0700)]
LP#1477677 - fix JS TypeError that prevents stat cats from displaying in stat cat editor

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agobrowser client: age to lost UI
Bill Erickson [Mon, 20 Jul 2015 01:38:07 +0000 (21:38 -0400)]
browser client: age to lost UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoBrowser client: integrate address alert HTML UI
Bill Erickson [Wed, 15 Jul 2015 02:04:39 +0000 (22:04 -0400)]
Browser client: integrate address alert HTML UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years ago2.8 doc image name change
Angela Kilsdonk [Mon, 6 Jul 2015 19:51:15 +0000 (14:51 -0500)]
2.8 doc image name change

Image name change to fix display

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
10 years agoWIP: more Z39.50 improvements
Galen Charlton [Tue, 28 Jul 2015 15:04:16 +0000 (15:04 +0000)]
WIP: more Z39.50 improvements

* change binding of marc_xml
* implement edit-then-overlay
* add search-in-progress indicator
* implement display of total hit count
* implement remove fields on import

10 years agohave egRecordHtml watch for chagnes to the MARC XML
Galen Charlton [Tue, 28 Jul 2015 15:06:36 +0000 (15:06 +0000)]
have egRecordHtml watch for chagnes to the MARC XML

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoweb staff: teach MARC editor how to work in-place
Galen Charlton [Tue, 28 Jul 2015 15:00:16 +0000 (15:00 +0000)]
web staff: teach MARC editor how to work in-place

This patch adds an "in-place" mode to the MARC editor for
cases where client-side MARC munging is needed without
immediately saving the results to the database.

To use, include in-place-mode="true" in the eg-marc-edit-record
directive.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1347807: Release note for "No Image" configuration examples
Ben Shum [Tue, 28 Jul 2015 21:04:03 +0000 (17:04 -0400)]
LP#1347807: Release note for "No Image" configuration examples

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1347807: Add example "No Image" configuration
Thomas Berezansky [Wed, 23 Jul 2014 13:46:32 +0000 (09:46 -0400)]
LP#1347807: Add example "No Image" configuration

To make it easy to see how to do that kind of thing.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1465385: Fix some syntax issues with make_release
Mike Rylander [Mon, 15 Jun 2015 19:32:20 +0000 (15:32 -0400)]
LP#1465385: Fix some syntax issues with make_release

Some versions of bash become confused when a unary = operator
is used in place of a binary == operator.  Also, some variables
live without the protection of quoting, and thus further confuse
the shell when their contents are not as simple as originally
expected.

Here we adress those issues.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1454879: Release notes for Account Expiration Date in OPAC
Ben Shum [Tue, 28 Jul 2015 20:49:23 +0000 (16:49 -0400)]
LP#1454879: Release notes for Account Expiration Date in OPAC

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP1454879: Add Account Expiration Date to OPAC
Terran McCanna [Fri, 15 May 2015 17:18:15 +0000 (10:18 -0700)]
LP1454879: Add Account Expiration Date to OPAC

Added Account Expiration Date to OPAC My Account display on
Account Summary page and Account Preferences page. This is in
response to patron requests to know when their accounts will
expire before the point at which they actually expire.

To test, log into My Account through the OPAC - a new table row
with account expiration date should appear on the main account
summary page, and another new row should appear on the main
account preferences page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1476370 Selfcheck inactivity warning release notes
Bill Erickson [Tue, 21 Jul 2015 14:00:41 +0000 (10:00 -0400)]
LP#1476370 Selfcheck inactivity warning release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP1476370 Selfcheck logout warning, checkout resets
Bill Erickson [Mon, 20 Jul 2015 20:26:30 +0000 (16:26 -0400)]
LP1476370 Selfcheck logout warning, checkout resets

* Show a logout warning dialog 20 seconds before discontinuing a
self-check patron login session.

* Reset the inactivity timer with each checkout.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1466201: Release note for disabling Google Analytics in staff interface
Ben Shum [Tue, 28 Jul 2015 20:40:55 +0000 (16:40 -0400)]
LP#1466201: Release note for disabling Google Analytics in staff interface

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agolp1466201 Disable Google Analytics in the staff client
Kathy Lussier [Fri, 10 Jul 2015 03:23:08 +0000 (23:23 -0400)]
lp1466201 Disable Google Analytics in the staff client

As Galen Charlton noted in bug 1452883, "I suggest disabling Google Analytics
outright in the staff client; there's far too much potential for leaking patron
information." This branch aims to do so.

Test plan: Enable Google Analytics in config.tt2. Access the catalog in the
staff client. Click Debug to view the source code. Pre-patch, you'll see
the Google Analytics javascript within the head element. Post-patch, that
javascript will be gone. Viewing the source of a catalog page in a browser
should continue to show the Google Analytics javascript within the head element.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1198465: Stamping upgrade script for conditional negative balance
Ben Shum [Tue, 28 Jul 2015 20:28:45 +0000 (16:28 -0400)]
LP#1198465: Stamping upgrade script for conditional negative balance

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP 1198465: Adapt some language in the negative balance branch
Kathy Lussier [Fri, 24 Jul 2015 00:53:33 +0000 (20:53 -0400)]
LP 1198465: Adapt some language in the negative balance branch

End users may see the term 'adjustment payment' and think that an actual
payment was made. Let's use 'account adjustment' instead. Also, remove any
references to credits in the description for the OU settings since it could
be confused with patron credits, which aren't prohibited by the code.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP 1198465: More tests for conditional negative balances
Remington Steed [Tue, 21 Jul 2015 17:21:15 +0000 (13:21 -0400)]
LP 1198465: More tests for conditional negative balances

This commit adds the remaining test cases documented by Kathy Lussier on
this wiki page:

    http://evergreen-ils.org/dokuwiki/doku.php?id=qa:billing_test_cases

Test cases included in this commit are:

    6. Restores Overdue Fines Appropriately, No Previous "Voids", Patron
       Will Not Owe On Lost Item Return
    7. Restores Overdue Fines Appropriately, No Previous "Voids", Patron
       Will Still Owe On Lost Item Return
    9. Restore Overdue Fines Appropriately, Previous Voids, Negative
       Balance Allowed
   13. Prohibit negative balances on lost materials bills ONLY
   14. Prohibit negative balances on overdue bills ONLY

Note that test case 5 is omitted because it is a duplicate of case 2,
and case 11 is included but commented out because it is unclear how best
to handle the situation.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP 1198465: Make conditional negative balances test sql re-runnable
Dan Wells [Fri, 17 Jul 2015 20:45:16 +0000 (16:45 -0400)]
LP 1198465: Make conditional negative balances test sql re-runnable

Add some DELETEs and some more explicit setting of a few DB pieces such
that running the test SQL a second time will get everything back to
state where the tests will again proceed as expected (hopefully
successfully!).

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP 1198465: Initial tests for conditional negative balances
Remington Steed [Fri, 17 Jul 2015 19:42:37 +0000 (15:42 -0400)]
LP 1198465: Initial tests for conditional negative balances

This is a first commit of work-in-progress for testing the conditional
negative balances features.  It covers 9 of the 14 test cases listed
here (as of today):

http://evergreen-ils.org/dokuwiki/doku.php?id=qa:billing_test_cases

TODO:
- The test is currently an SQL setup file plus a Perl live test file.
  One simple improvement would be to switch the setup process to
  cstore calls within the Perl test file.  This would be both more
  contained and more robust.
- A second step to more advanced and useful tests would be to use
  higher-level API calls to create portions of the setup rather than
  doing everthing manually.  However, some test conditions cannot be
  reasonably setup with the normal API calls (e.g. bills of a specific
  age, or bills using a legacy format no longer generated by current
  code), so certain areas will likely always require direct
  manipulation.

Signed-off-by: Daniel Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP 1198465: Clean up terminology
Dan Wells [Thu, 28 May 2015 18:10:50 +0000 (14:10 -0400)]
LP 1198465: Clean up terminology

Replace the "void payment" language with "adjustment" in variable names
and comments.  This commit should not make any functional difference.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP 1198465: Set restored overdue timestamp to time of last overdue
Dan Wells [Thu, 28 May 2015 17:54:26 +0000 (13:54 -0400)]
LP 1198465: Set restored overdue timestamp to time of last overdue

When we have our settings configured to generate new overdues on lost
item return, we start generation after the most recent overdue fine.
Because of this, we need the restored fine to be dated in the past,
which in turn allows the fine generator to apply catch-up fines as
expected.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP 1198465: Account for overdues voided the old way
Remington Steed [Wed, 18 Jun 2014 13:34:13 +0000 (09:34 -0400)]
LP 1198465: Account for overdues voided the old way

The code for the particular case of "void"-overdues-for-lost is incomplete.
This is the one case in the new code where it now always adjusts rather
than voids, but the new restore code still needs to recognize cases where
the voiding happened under the old code.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP 1198465: Delay creation of bill map for special bill handling
Dan Wells [Tue, 1 Apr 2014 19:13:00 +0000 (15:13 -0400)]
LP 1198465: Delay creation of bill map for special bill handling

We were making the map, then deciding whether we wanted to void or
adjust.  Since we only want the map if we adjust (and it creates havoc
when voiding), let's just get the bill IDs, then let the adjustment
code create the map it needs.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP 1198465: Fix and improve void/adjustment code
Dan Wells [Wed, 26 Feb 2014 22:44:45 +0000 (17:44 -0500)]
LP 1198465: Fix and improve void/adjustment code

This commit does three things:

- Replace ou_ancestor_setting() with ou_ancestor_setting_value() calls
  This also fixed a bug where we were expecting just the setting, not
  a HASH

- Reword interval checking
  This fix is two part.  First, we simplify the check to not require
  the whole payment map.  Second, we use this newfound simplicity to
  push this check up into the gatekeeper functions, further clarifying
  the code paths.

- make $note into $for_note for void_or_zero_bills_of_type()
  Because the function can both void and adjust, we can't supply a
  complete note, so let's just supply text of what the void/adjustment
  is for.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP 1198465: Refactor logic into gatekeeper functions
Dan Wells [Wed, 26 Feb 2014 16:12:21 +0000 (11:12 -0500)]
LP 1198465: Refactor logic into gatekeeper functions

The bulk of this commits take the logic from adjust_bills_to_zero() and
moves it up a layer into the "gatekeeper" void_or_zero* functions.
This move also allows us to simplify the logic, since some facts are
already known based on our function path.

Also:
- give void_or_zero_overdues() a new signature to better support
  multiple options
- add new 'force_void' and 'force_zero' options to this function
- rename real_void_bills() to simply void_bills() (since there is no
  other void_bills(), the "real" was redundant)

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP 1198465: Rename internal functions for clarity
Dan Wells [Fri, 20 Feb 2015 22:19:42 +0000 (17:19 -0500)]
LP 1198465: Rename internal functions for clarity

These methods will now be the splitting point for void vs. adjustment,
so let's give them broader names.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP 1198465: Restore voiding code, rename adjustment function
Dan Wells [Tue, 25 Feb 2014 22:37:43 +0000 (17:37 -0500)]
LP 1198465: Restore voiding code, rename adjustment function

This commit restores the code we removed a few commits earlier, and
also renames "real_void_bills()" "adjust_bills_to_zero()" in order to
better delineate the split functionality.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP 1198465: Fix typo in BILL_ALREADY_VOIDED event
Jason Stephenson [Tue, 25 Feb 2014 19:47:47 +0000 (14:47 -0500)]
LP 1198465: Fix typo in BILL_ALREADY_VOIDED event

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP 1198465: Update CDBI/money.pm for adjustment_payment
Jason Stephenson [Wed, 8 Jan 2014 01:44:47 +0000 (20:44 -0500)]
LP 1198465: Update CDBI/money.pm for adjustment_payment

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP 1198465: Update logic in checkin_handle_lost_or_lo_now_found_restore_od
Jason Stephenson [Sun, 6 Oct 2013 21:13:01 +0000 (17:13 -0400)]
LP 1198465: Update logic in checkin_handle_lost_or_lo_now_found_restore_od

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP 1198465: Modify O::A::Circ::Circulator->checkin_handle_lost_or_lo_now_found()
Jason Stephenson [Sun, 6 Oct 2013 15:09:10 +0000 (11:09 -0400)]
LP 1198465: Modify O::A::Circ::Circulator->checkin_handle_lost_or_lo_now_found()

Simplify it to use the new, CircCommon->void_bills_of_type() method.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP 1198465: Add code for adjustment payments
Jason Stephenson [Fri, 20 Feb 2015 22:17:46 +0000 (17:17 -0500)]
LP 1198465: Add code for adjustment payments

This new payment type complements the current void logic that flags
bills as voided.

This new payment type is needed because the current way that Evergreen
voids bills requires that all voids happen in the same increment as the
bills themselves.  This prevents voiding of a partial bill or a bill
that has had a partial payment applied.

This commit also adds the org. unit setting types for the conditional
negative balances enhancements:

bill.prohibit_negative_balance_default
bill.prohibit_negative_balance_on_overdues
bill.prohibit_negative_balance_on_lost
bill.negative_balance_interval_default
bill.negative_balance_interval_on_overdues
bill.negative_balance_interval_on_lost

Finally, create a helper function for checking intervals along the way,
and a handy little subroutine to void all bills of a given type on a
circulation transaction.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
Open-ILS/src/sql/Pg/950.data.seed-values.sql

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1478299: fix location for asset used in test
Jason Etheridge [Mon, 27 Jul 2015 20:04:17 +0000 (16:04 -0400)]
LP#1478299: fix location for asset used in test

specifically lp1277731_hold_permit_test.pg

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoWIP: webstaff Z39.50 - more improvements
Galen Charlton [Thu, 23 Jul 2015 17:52:33 +0000 (17:52 +0000)]
WIP: webstaff Z39.50 - more improvements

* add grid actions
* fix markup
* add view MARC action
* improve name of check for disabling actions that
  require at least one result to be selected
* display cover image on view MARC modal
* add Z39.50 raw search capability
* implement selecting local record for overlay
* implement record overlay with confirm

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoteach eg-record-html how to initialize itself from MARCXML
Galen Charlton [Mon, 27 Jul 2015 17:14:06 +0000 (17:14 +0000)]
teach eg-record-html how to initialize itself from MARCXML

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1155771 Copy location sample data additions
Bill Erickson [Tue, 2 Apr 2013 21:22:37 +0000 (17:22 -0400)]
LP#1155771 Copy location sample data additions

* added some new locations and better groups (thanks gdunbar)
* applying locations to copies in a slightly more sane fashion
* added todo comment about possible future improvement

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
10 years agoLP#1155771 Copy location sample data additions
Bill Erickson [Mon, 18 Mar 2013 15:01:36 +0000 (11:01 -0400)]
LP#1155771 Copy location sample data additions

* Add/remove some locations
* Add some locations whose flags (circulate, etc.) vary along the org
  pathway.  Thanks to Thomas Berezansky for this suggestion.
* Ensure that copy location owner matches copy circ lib when applying
  locations to copies.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
10 years agoLP#1155771 Sample data : copy locations, location groups
Bill Erickson [Fri, 15 Mar 2013 18:32:18 +0000 (14:32 -0400)]
LP#1155771 Sample data : copy locations, location groups

Adds a pile of sample copy location and location groups to the sample
data in Open-ILS/tests/datasets/sql.  Samples are loaded as part of
"load_all.sql"

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
10 years agoLP#1477677 - fix JS TypeError that prevents stat cats from displaying in stat cat...
Jeff Davis [Mon, 1 Jun 2015 23:16:25 +0000 (16:16 -0700)]
LP#1477677 - fix JS TypeError that prevents stat cats from displaying in stat cat editor

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoteach egGrid action menus how to conditionally disable items
Galen Charlton [Thu, 23 Jul 2015 17:49:36 +0000 (17:49 +0000)]
teach egGrid action menus how to conditionally disable items

It is now possible to pass a function to specify if an action
menu item should be disabled:

  <eg-grid-action handler="do_stuff" disabled="cant_do_stuff"
    label="[% l('Do Stuff') %]"></eg-grid-action>

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoFixed-position navigation menu for web client
Kathy Lussier [Tue, 14 Jul 2015 16:26:24 +0000 (12:26 -0400)]
Fixed-position navigation menu for web client

Changes the class for top-navbar so that it stays fixed at the top of the
screen. This is useful for staff who will need to quickly jump to another
area of the client after they have scrolled down a page.

Initially, changing the class shifted some of the content higher so that the
navbar was covering some elements. I addressed this by adding some padding to

Many thanks to Jason Etheridge for pointing me in the right direction to get
started.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoWIP: more webstaff Z39.50 search work
Galen Charlton [Fri, 17 Jul 2015 18:56:10 +0000 (18:56 +0000)]
WIP: more webstaff Z39.50 search work

* add widget to show/hide search form
* add more vertical space between search form and results table
* forgo a label on the results table
* make Z39.50 search results non-multiselect-able
* implement edit-then-import

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoforce MARC editor context menus to have a high z-index
Galen Charlton [Fri, 17 Jul 2015 22:22:47 +0000 (22:22 +0000)]
force MARC editor context menus to have a high z-index

Magic value of 2000 chosen to ensure that they appear
even when the MARC editor is embedded in a Bootstrap
modal.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoteach MARC editor how to initialize itself from a MARCXML blob
Galen Charlton [Fri, 17 Jul 2015 22:10:15 +0000 (22:10 +0000)]
teach MARC editor how to initialize itself from a MARCXML blob

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoteach egGrid how to disable multiselect
Galen Charlton [Fri, 17 Jul 2015 19:22:36 +0000 (19:22 +0000)]
teach egGrid how to disable multiselect

For grids where it makes sense to allow only one row to be
selected at a time, egGrid now supports a "-multiselect"
feature that:

  * disables generation of the checkbox column
  * disables control-/shift/command-click to multiselect

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agomake Firefox happy in various ways
Mike Rylander [Fri, 17 Jul 2015 20:13:54 +0000 (16:13 -0400)]
make Firefox happy in various ways

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoZ39.50 webstaff WIP: more functionality and fixes
Galen Charlton [Thu, 16 Jul 2015 18:17:04 +0000 (18:17 +0000)]
Z39.50 webstaff WIP: more functionality and fixes

* check for empty query correctly
* retain reference to target list
* preserve search query input when toggling Z39.50 target selection
* implement clear form handler
* allow enter key to submit search
* track index of Z39.50 results so that individual ones can be selected
* note results of experiences to make the title be conditionally a hyperlink
* implement show in catalog
* implement direct import

10 years agoWIP: add more Z39.50 search functionality to webstaff
Galen Charlton [Thu, 9 Jul 2015 16:25:25 +0000 (16:25 +0000)]
WIP: add more Z39.50 search functionality to webstaff

- can now select targets
- search field form now active
- can now retrieve results

Next steps:

- start adding actions to the results grid
- add estimated hits count
- add caching of results already retrieved
- add ability to move the search field and target list out
  of the way

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoWIP: start work on Z39.50 interface
Galen Charlton [Tue, 9 Jun 2015 22:10:18 +0000 (22:10 +0000)]
WIP: start work on Z39.50 interface

So far, fetch targets. Next steps:

- add directive for the search input boxes;
  will need to watch the target list
- add search service

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1472787: add regression test
Galen Charlton [Wed, 8 Jul 2015 22:24:55 +0000 (22:24 +0000)]
LP#1472787: add regression test

This patch adds some unit tests for egGrid's egGridColumnsProvider,
including regression tests for LP#1472787.

To run these tests (and all others for the web staff client)
from with a Git checkout of Evergreen:

[1] cd Open-ILS/web/js/ui/default/staff
[2] grunt test

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1472787: fix expansion of wildcard eg-grid-field paths
Galen Charlton [Wed, 8 Jul 2015 21:35:43 +0000 (21:35 +0000)]
LP#1472787: fix expansion of wildcard eg-grid-field paths

This fixes a bug where expansion of wildcard egGridField
paths didn't handle a plain "*" correctly.

To test:

[1] In the web staff client, bring up the list of a patron's
    current loans.  Add the grace period column to the grid,
    but note that the loans' grace period values are not
    actually displayed.
[2] Apply the patch.
[3] Refresh the browser and repeat step 1.  This time, the
    grace period values are displayed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoSimplify logic of grouped items; Add mark missing/damaged; Add show item holds
Mike Rylander [Wed, 24 Jun 2015 13:39:46 +0000 (09:39 -0400)]
Simplify logic of grouped items; Add mark missing/damaged; Add show item holds

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAdd actions for jumping to item status
Mike Rylander [Wed, 24 Jun 2015 13:18:47 +0000 (09:18 -0400)]
Add actions for jumping to item status

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAdd support for item list population from the URL
Mike Rylander [Wed, 24 Jun 2015 13:18:04 +0000 (09:18 -0400)]
Add support for item list population from the URL

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAdjust how padding is applied
Mike Rylander [Mon, 22 Jun 2015 19:35:02 +0000 (15:35 -0400)]
Adjust how padding is applied

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoColumn ordering improvement
Mike Rylander [Mon, 22 Jun 2015 19:21:35 +0000 (15:21 -0400)]
Column ordering improvement

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoTypo
Mike Rylander [Mon, 22 Jun 2015 19:20:08 +0000 (15:20 -0400)]
Typo

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoUse function calls instead of watches; Collapse columns
Mike Rylander [Mon, 22 Jun 2015 19:14:29 +0000 (15:14 -0400)]
Use function calls instead of watches; Collapse columns

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAttempt to provide defaults
Mike Rylander [Mon, 22 Jun 2015 17:26:55 +0000 (13:26 -0400)]
Attempt to provide defaults

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAdd checkboxes and logic for collapsing copy and vol detail
Mike Rylander [Mon, 22 Jun 2015 17:17:42 +0000 (13:17 -0400)]
Add checkboxes and logic for collapsing copy and vol detail

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoTeach grids how to provide checkboxes
Mike Rylander [Mon, 22 Jun 2015 17:16:19 +0000 (13:16 -0400)]
Teach grids how to provide checkboxes

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoHoldings View!
Mike Rylander [Mon, 22 Jun 2015 12:47:12 +0000 (08:47 -0400)]
Holdings View!

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAdd "align" support to grid cells
Mike Rylander [Mon, 22 Jun 2015 12:46:18 +0000 (08:46 -0400)]
Add "align" support to grid cells

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoOnly make the iframe bigger, never smaller
Mike Rylander [Mon, 27 Apr 2015 16:18:40 +0000 (12:18 -0400)]
Only make the iframe bigger, never smaller

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoMove buttons to the top
Mike Rylander [Mon, 27 Apr 2015 14:47:19 +0000 (10:47 -0400)]
Move buttons to the top

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAdd height adjustment hacks for a couple dojo interfaces
Mike Rylander [Fri, 24 Apr 2015 20:27:31 +0000 (16:27 -0400)]
Add height adjustment hacks for a couple dojo interfaces

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoDouble scrollbars are bad, this stops them where we can.
Mike Rylander [Thu, 23 Apr 2015 21:35:09 +0000 (17:35 -0400)]
Double scrollbars are bad, this stops them where we can.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoJust build the path directly, we know our base
Mike Rylander [Thu, 23 Apr 2015 21:09:34 +0000 (17:09 -0400)]
Just build the path directly, we know our base

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoPass override when needed, and interpret events correctly
Mike Rylander [Thu, 23 Apr 2015 19:30:53 +0000 (15:30 -0400)]
Pass override when needed, and interpret events correctly

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoIntegrate Monograph Parts UI
Mike Rylander [Mon, 20 Apr 2015 20:38:13 +0000 (16:38 -0400)]
Integrate Monograph Parts UI

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoTeach egEmbedFrame how to not throw warnings, and also how to be used more than once...
Mike Rylander [Mon, 20 Apr 2015 20:32:30 +0000 (16:32 -0400)]
Teach egEmbedFrame how to not throw warnings, and also how to be used more than once per app

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAdd "delete" and "undelete" actions to the MARC editor
Mike Rylander [Mon, 20 Apr 2015 17:46:52 +0000 (13:46 -0400)]
Add "delete" and "undelete" actions to the MARC editor

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoEnable next/prev/first/last/results buttons on all new search results
Mike Rylander [Mon, 20 Apr 2015 17:46:17 +0000 (13:46 -0400)]
Enable next/prev/first/last/results buttons on all new search results

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoSmall-ize the "set default" button, and move it "into" the tab
Mike Rylander [Fri, 17 Apr 2015 20:49:46 +0000 (16:49 -0400)]
Small-ize the "set default" button, and move it "into" the tab

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoUse tabs instead of Actions For this Record, and do away with that menu altogether...
Mike Rylander [Wed, 15 Apr 2015 20:38:50 +0000 (16:38 -0400)]
Use tabs instead of Actions For this Record, and do away with that menu altogether (YAY!)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoalways calculate context menu for egMarcEditEditable on the fly
Galen Charlton [Mon, 13 Apr 2015 19:24:14 +0000 (19:24 +0000)]
always calculate context menu for egMarcEditEditable on the fly

This way, the correct context menus get generated for a new
field/subfield entry or when a field's tag is changed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoset value ctype for RDA 33x$a
Galen Charlton [Mon, 13 Apr 2015 17:20:47 +0000 (17:20 +0000)]
set value ctype for RDA 33x$a

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoteach MARC editor how to build context menus for subfield values
Galen Charlton [Mon, 13 Apr 2015 17:16:57 +0000 (17:16 +0000)]
teach MARC editor how to build context menus for subfield values

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1427287: allow coded value maps to be associated with subfields
Galen Charlton [Mon, 13 Apr 2015 16:38:45 +0000 (16:38 +0000)]
LP#1427287: allow coded value maps to be associated with subfields

This change allows a set of values from a record attribute's
coded value map to be associated with a MARC subfield and
returned by the tag-table service.  This is for supporting
the use of controlled vocabularies for subfield values in
the MARC editor.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1442815: add RDA Content Type, Media Type, and Carrier Type attributes to seed...
Galen Charlton [Fri, 10 Apr 2015 22:27:16 +0000 (22:27 +0000)]
LP#1442815: add RDA Content Type, Media Type, and Carrier Type attributes to seed data

Note that a record attribute reingest is required for the
attributes to be available for search purposes.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1442815: teach record attributes about SKOS
Galen Charlton [Fri, 10 Apr 2015 22:03:46 +0000 (22:03 +0000)]
LP#1442815: teach record attributes about SKOS

Add columns to the database for storing URIs of SKOS
vocabularies and concepts.  In particular:

- add a vocabulary column to config.record_attr_definition
  to store the URI of the published vocabulary associated
  with the record attribute
- add a concept_uri column to config.coded_value_map

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1442796: make XPath-based record attribute definitions work
Galen Charlton [Fri, 10 Apr 2015 20:56:17 +0000 (20:56 +0000)]
LP#1442796: make XPath-based record attribute definitions work

Record attribue definitions that use XPath to extract their values
could break ingest; this patch fixes that.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoRegister a pile of standard hotkeys
Mike Rylander [Fri, 10 Apr 2015 16:34:18 +0000 (12:34 -0400)]
Register a pile of standard hotkeys

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoTeach access keys how to deal with ng-click actions and empty hrefs
Mike Rylander [Fri, 10 Apr 2015 16:33:26 +0000 (12:33 -0400)]
Teach access keys how to deal with ng-click actions and empty hrefs

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoIntegrate Manage Authorities UI -- will require modification to de-XUL-ify in a later...
Mike Rylander [Tue, 7 Apr 2015 19:00:22 +0000 (15:00 -0400)]
Integrate Manage Authorities UI -- will require modification to de-XUL-ify in a later sprint

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoIntegrate URL Verification UI -- will require modification to de-XUL-ify in a later...
Mike Rylander [Tue, 7 Apr 2015 18:48:15 +0000 (14:48 -0400)]
Integrate URL Verification UI -- will require modification to de-XUL-ify in a later sprint

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoBatch Edit iframe template
Mike Rylander [Tue, 7 Apr 2015 17:01:46 +0000 (13:01 -0400)]
Batch Edit iframe template

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoIntegrate batch edit (including bucket batch edit entry point)
Mike Rylander [Tue, 7 Apr 2015 16:55:07 +0000 (12:55 -0400)]
Integrate batch edit (including bucket batch edit entry point)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAdd support for standalone grid menu items even when there is a menu label
Mike Rylander [Tue, 7 Apr 2015 16:54:29 +0000 (12:54 -0400)]
Add support for standalone grid menu items even when there is a menu label

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoEmbed vandelay
Mike Rylander [Mon, 6 Apr 2015 19:47:09 +0000 (15:47 -0400)]
Embed vandelay

Signed-off-by: Mike Rylander <mrylander@gmail.com>