LP#1775466 String service queue pending

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Tree widget

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Improve handling org_unit / boolean types

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Grid column position improvements

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Grid showFields option

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Common form CSS

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 StoreService marks all cookies secure

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Grid pageOffset option continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Import grid/basic admin in staff common mod

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Grid pageOffset option continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Grid pageOffset option

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Dialog robustification

In certain circumstances, the close() operation can be called after the
dismiss() operation (blur action maybe?) which tries to invoke a method
on a now-null reference.  Avoid said invocation.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Grid vert expand fixes; lint updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Grid vert expand top-level option

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Common catalog mod; marchtml repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Marc html view genericized

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Progress dialog title option

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Grid cell vertical expand option

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Avoid workstation removal login loop

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Grid toolbar checkboxes; more combobox

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 tight-card css reduce header padding

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Combobox additions

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 make grid onRowActivate/onRowClick proper Outputs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into collab/berick/lp1775466-ang6-base-app

Docs: fixing physical characteristics wizard representation in consolidated docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding indexterms to physical characteristics wizard docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: configuring fixed field dropdown menus

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: removing broken link

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1779392: Stop sending broken queries

It's possible to send invalid parameters to the
search.highlight_display_fields function which
wastes a db roundtrip and fills the logs with
errors. Checking to be sure there's anything in
the parameter will prevent both.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP 1772993: Ability to blank Age Hold Protection in Vol/Copy Editor.

Add the <NONE> option to the age-based hold protection field in the
web staff client Vol/Copy Editor.

To test:

1. Add a value for age-based hold protection to a copy.

2. Attempt to remove the value in the copy editor.  Note that the
   dropdown does not allow you to do so.

3. Apply this commit.

4. Repeat step 2.  Now there is a <NONE> option that removes the value
   from the copy.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

LP#1775466 move format svc to core w/ unit tests; root inject core svcs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Grid default hidden fields; tidying

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 ng-bootstrap update; self-hosted bs css

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 combobox gets dynamic data

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Inline progress row style

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Inline progress; more combobox

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Combobox repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Combobox repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Typeahead is now combobox; entries

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Typeahead is now combobox; entries

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Typeahead has allowFreeText option

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Typeahead arrow icons

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Typeahead repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Generic typeahead component

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#775466 Org selector shows all on click

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Forward-port 3.1.3 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward port 3.0.9 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Docs: Adding 3.1.3 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Adding 3.0.9 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1775466 Grid row flair tooltips

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1635386: Restore to xul colors and remove colors from class names

This commit restores the xul display where overdue items were highlighted
in red and long overdue items were highlighted in orange. Also removes
the colors from the class names since people may decide to use totally different
colors or style the rows in different ways.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1635386 Clarify and simplify row highlighting code

The existing code had a few functional problems for me.  In the process
of fixing them, I decided it best to also apply a number of small
refactorings.  Here is a list of changes in rough order of significance:

-Made the new CSS classes test and apply once per row rather than once
per cell

-Fixed the test case for overdues: we now just look for no checkin-time
+ no lost/long-overdue stop-fines (matches XUL test)

-Made the color and icon tests totally consistent, and also simplified
where possible

-Made the widened configuration header style (to accommodate status
column) functional again (it was using old 'statusicon' class)

-Made row highlight colors '!important' to avoid bad interactions with
alternating row color styles

-Changed status-cell (and statusCell) to status-column (and
statusColumn) for a little extra clarity

-Changed nested function name from 'rowClass()' to 'apply()' for greater
code distinction (i.e. avoid 'rowClass.rowClass()' calls, and instead
have 'rowClass.apply()')

-Removed some unused variable assignments from grid.js

-Cleaned up a few field attributes for necessity and consistency

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>

LP#1635386: Improve contrast for colors used in Bills interface

The contrast between cell contents and background colors did not
meet WCAG standards. This commit provides adequate contrast to
meet AA level of WCAG standards. The red and dark red background
colors are similar to what we saw in the XUL client. The orange
for long overdue is much lighter.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>

lp1635386 Items Column & Styles for Bill Item Status

- CSS classes for red, dark red, and orange eg-grid-cells.
- New parameter for eg-grid 'rowClass' to take an object with a function
to set the class of a cell, allowing such customizations as coloring based
on item fields.
- Implementation of 'rowClass' on the Patron Bills interface to display
colors indicating current Fines Stop reason, based on XUL client.
- New parameter for eg-grid 'statusCell' to take an object with a function
to programattically add status icons to a new "Status Icon" column. Said
column requires a boolean in the object in order to display.
- Implementation of 'statusCell' on the Patron Bills interface to display
glyphicons based on if the bill is for a circ that is lost, overdue, or long
overdue.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/circ/patron/t_bills_list.tt2
modified:   Open-ILS/src/templates/staff/css/style.css.tt2
modified:   Open-ILS/src/templates/staff/share/t_autogrid.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/bills.js
modified:   Open-ILS/web/js/ui/default/staff/services/grid.js

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>

LP#1775466 Catalog/grid thinko fixes

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Doc updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1773832: Empty deleted records can be surfaced in search results

There are cases where we avoid checking the deleted flag of bibs as an
optimization that avoids a JOIN in the search query.  However, for some
shapes of real-world data, particularly in upgraded instances, deleted
records can slip through.  This commit adds an explicit check for the
flag to all search queries.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Daniel Pearl <dpearl@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1775466 Grid row flair; ng-lint updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP 1758160: Bump version in upgrade_log.

Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1758160_Deleting_patrons_can_exceed_staff_client_timeouts

Added an index to action.usr_circ_history for much needed postgresql justice.
This will increase the speed when deleting patrons with large number of circulations.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1775466 Catalog add to list linked up

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Grid row/cell CSS handlers

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Catalog repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Grid body/cell components; print fixes

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Catalog uses display fields; more extensible guts

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Grid cell value tooltips

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Print repairs; rm-ing legacy template parser

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Grid header row styling

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Initial catalog add-volumes support

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Catalog add to bucket action

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Catalog record Other Actions (partial) menu

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Catalog record MarkFor actions

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Catalog copies now use grid

For added display flexibility, grid printing, possible future
multi-select actions.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Ported About page

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Remaining navbar entries and icons

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Acq nav menu; Cat nav menu icons

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Implement reprint last receipt

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 AngJS reprint last stores compiled html

Store the compiled HTML instead of the source template and source
context after each print.  With this, reprintLast() doesn't have to
recompiled the content.  This is particularly useful for sharing printed
content between AngularJS and Angular.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 more legacy parser; printing; cleanup

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 printer uses template parser

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 AngJS style minimal template parser continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 AngJS style minimal template parser continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 AngJS style minimal template parser WIP

So we can continue supporting AngularJS-style print templates
-- without having to use AngularJS -- which will buy some time
for determining how we want to handle print templates in the
future and to ease existing template migration.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Docs: documenting --items option of marc_export

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: improving index terms for MARC import/export options

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

added fields for hold notification preference to display

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>

Docs: fixing broken reference in cat manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding info about item status screen

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1772444: Updating list of variables in bill template descriptions

Bill: repaired merge conflicts and applied some additional docs
consistency across the two billing templates.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1772444: Add Patron Names to Bill Receipts

The bills_current and bills_historical receipt templates
were missing patron information. This has been added to
match most other receipt templates (money_summary is not
included since it could potentially be stale).

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Disable reprint last receipt in navbar

Functionality is not supported.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Retracting dynamic component for now

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 ident search defaults to isbn

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Ang catalog supports most identifier query types

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Nested grid fields support

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Ang6 app config improvement; simplify building

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1775466 Dynamic component partial retraction

Dynamic component as-is only works in JIT compliation mode.  Leaving for
reference, but commenting out any uses.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1774427 Parse DoB dates as whole dates

Fixes DoB parsing in the browser client patron edit interface by
creating date objects from a whole YMD date string instead of compiling
the date as collection of pieces.  Compiling dates from pieces (calling
setFullYear(), setMonth(), etc.) can have unexpected consequences,
because a change of month can result in a change of days as well, if the
number of days in the date object exceeds the capacity of the selected
month.

For example:

---
> d = new Date()
2018-05-31T14:59:26.186Z
> d.setMonth(1)
1520092766186
> d
2018-03-03T15:59:26.186Z
--

Parsing as Date(YYYY,MM,DD) instead avoids this kind of shuffling.

To test

[1] Log in to the staff client on the 31st day of the month :)
[2] Change a patron's DoB to a month that does not contain 31 days.
[3] Save patron and note on reload, the DoB shows the wrong value.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: Minor corrections to "Borrowing items" section

This commit fixes a number of small inconsistencies in wording (between
the docs and the interface) and formatting (e.g. making menu names bold).
Also, one sentence is expanded for clarity.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

LP#1740535: retrieve list of billing types

This patch changes how the web staff client retrieves the list
of billing types available for use by the Bill Patron modal. PCRUD
permissions on config.billing_type don't quite match how the
the set of billing types available to a staff user used to work
in the XUL staff client, so this patch uses the
open-ils.circ.billing_type.ranged.retrieve.all method instead.

To test
-------
[1] Log in as a Circulators staff user (assuming stock data
    and permissions).
[2] Try the Bill Patron dialog in the web staff client; note that
    no billing types are accessible.
[3] Apply the patch and repeat step #2. This time, it should
    include the miscellaneous billing type.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>