Dan Scott [Wed, 25 May 2011 15:38:11 +0000 (11:38 -0400)]
Fix authority linking script typo
Problem reported by Ditty Mulder <dmu@iisg.nl>
Signed-off-by: Dan Scott <dan@coffeecode.net>
Dan Wells [Wed, 25 May 2011 13:29:13 +0000 (09:29 -0400)]
upgrade_deps_block_check() is not in the branches at this point
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Scott [Wed, 25 May 2011 03:20:40 +0000 (23:20 -0400)]
Use the right upgrade log format for 2.0 upgrade
Signed-off-by: Dan Scott <dan@coffeecode.net>
Dan Scott [Wed, 25 May 2011 01:56:13 +0000 (21:56 -0400)]
Trivial line-wrapping patch for call number class defaults
Signed-off-by: Dan Scott <dan@coffeecode.net>
Dan Wells [Tue, 24 May 2011 14:53:09 +0000 (10:53 -0400)]
Make label_class on any new call numbers default to org_unit setting
Evergreen 2.0 added a label_class column to the call number table with
one major purpose being the generation of correct sort keys. You can
also specify a default label class as an org unit setting. However:
1) There are no interface elements for setting the label class of an
individual call number.
2) The default setting from the actor.org_unit_setting
'cat.default_classification_scheme' value, if set, is not consulted
(that is, not set in the call number table) when new call numbers are
created.
These two facts together greatly reduce the utility of this very
valuable feature, as all new call numbers end up in the 'Generic' class.
While #1 has been addressed in 2.1+, there is still work to be done in
setting this class on import. Also, which interface parts (if any) make
it back to 2.0 is subject to debate.
This commit addresses #2.
See lp #787150.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dan@coffeecode.net>
Dan Wells [Tue, 24 May 2011 20:55:47 +0000 (16:55 -0400)]
Bring serial.unit in line with asset.copy
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Jason Etheridge [Tue, 24 May 2011 18:55:57 +0000 (14:55 -0400)]
remove restriction on resetting pw to random number when Use Phone Password setting is active. uEditMakeRandomPw will still get called for new users, but should get overwritten once a phone number is entered
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Galen Charlton [Tue, 17 May 2011 04:40:02 +0000 (00:40 -0400)]
stop hold permit check from crashing if age protection in effect
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Mike Rylander [Mon, 23 May 2011 15:14:02 +0000 (11:14 -0400)]
Merge branch 'rel_2_0' of git.evergreen-ils.org:Evergreen into rel_2_0
Mike Rylander [Mon, 23 May 2011 15:07:20 +0000 (11:07 -0400)]
Revert "Wrap proximity refreshing in a transaction to avoid timespans where there is no such information"
This reverts commit
85b522e155283010f8e58f51c78afc119ab3d813.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Mon, 23 May 2011 14:16:16 +0000 (10:16 -0400)]
Update Lenny prereqs for MARC::Record 2.0.1+
2.0 requires MARC::Record 2.0.1+, and the packaged version of
MARC::Record is just 2.0.0. This causes mysterious failures of
various open-ils.search.biblio.* methods - so teach the prereq
installer to get a new enough version of MARC::Record on Lenny.
Aside: The juggling of prereqs in a single Makefile for multiple distros
is starting to get extremely complex, perhaps it's time to split them
out to a single Makefile per distro?
Signed-off-by: Dan Scott <dan@coffeecode.net>
Dan Wells [Mon, 23 May 2011 13:38:22 +0000 (09:38 -0400)]
Apply Apache file expiration to the current official Javascript content type
At least on Ubuntu 10.04, Javascript files are generally delivered
with a Content-Type header of 'application/javascript', not
'application/x-javascript'. This change applies the much shorter
18 hour expiration to the affected files, rather than allowing them
to default to 1 month.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Lebbeous Fogle-Weekley [Fri, 20 May 2011 19:47:04 +0000 (15:47 -0400)]
Fix bad seed data in an A/T template
The action_trigger event def template for printing acq invoices was
syntatically broken. The collapse filter isn't important per se, but
it balances the extra [% END %] at the bottom of the template, and it
was there originally, and I see no reason not to put it back.
Incidentally, maybe the database upgrade script in the commit will be
the first in master to successfully use the new
evergreen.upgrade_deps_block_check() function ?
Reported by Sally Fortin.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Lebbeous Fogle-Weekley [Fri, 20 May 2011 14:17:05 +0000 (10:17 -0400)]
Fix a problem with open-ils.circ.holds.retrieve_all_from_title
Anoop Atre spotted this bug that's triggered by selecting "View Holds"
from "Actions for Selected Record" in the catalog seen through the staff
client.
Said method would error out like this:
[2011-05-20 10:04:03] open-ils.circ [ERR
:31866:CStoreEditor.pm:109:
13058333633194115] editor[0|1] request error
open-ils.cstore.direct.serial.issuance.id_list.atomic :
{"subscription":[]} : Exception:
OpenSRF::DomainObject::oilsMethodException 2011-05-20T10:04:03
OpenILS::Utils::CStoreEditor
/openils/lib/perl5/OpenILS/Utils/CStoreEditor.pm:412 <500> Severe query
error -- see error log for more details
because when trying to gather issuance-type holds, it didn't properly test
whether there actually were any subscriptions and issuances related to
the bib record in question.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Galen Charlton [Fri, 20 May 2011 01:28:50 +0000 (21:28 -0400)]
add missing upgrade step to create staging schema
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Lebbeous Fogle-Weekley [Wed, 18 May 2011 21:26:58 +0000 (17:26 -0400)]
Add permission checking for updating and deleting volumes.
This addresses LP #784062 reported by Ben Shum, and I think others?
Creating volumes was already covered. The ability to delete volumes
without permission would be less often an issue in practice since you
would need permission to delete the volume's copies before you could
delete the volume itself.
Anyway, this should square things.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Tue, 17 May 2011 04:29:47 +0000 (00:29 -0400)]
LP#783486: Improve authority lookup performance
Testing showed that the two indexes added herein improve
authority lookup performance radically; on a 16 GB RAM
database server with 1.1M records, lookup times decreased
from 5500 ms to 0.223 ms. Recommended, would EXPLAIN ANALYZE
again.
Signed-off-by: Dan Scott <dan@coffeecode.net>
Mike Rylander [Mon, 16 May 2011 22:17:30 +0000 (18:17 -0400)]
Ignore "deleted" authority records when using the tag-validation method
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Wells [Mon, 16 May 2011 19:23:10 +0000 (15:23 -0400)]
Borrow on_or_after() from MFHD/Caption.pm in MFHD/Date.pm
Signed-off-by: Dan Wells <dbw2@calvin.edu>
dbwells [Fri, 13 May 2011 16:06:04 +0000 (16:06 +0000)]
A bevy of MFHD bug fixes (and test cases)
1) Remove hard-coded 'gap' text from format_part()
2) Honor $ypm## for chron_to_date() for annuals
3) Removed overly simple check on $w as digit
4) Allow for combined chronologies other than 2nd level
5) Make calendar changes trump $u counts
6) Honor issue restarts at calendar changes
7) Rudimentary support of $u counts for non-restarting issue numbering
8) Special interpretation of $yps for early winters (i.e. winter is the first season of the calendar year)
9) Teach chron_to_date() about early winters
The last two points deserve some special attention. A large number of journals consider 'Winter' to be the first season of the year, so Winter 2011 means (roughly) January 2011, not December 2011. However, there is no explicit way to indicate this in the standard, and also the code relies in many ways on the fact that 24 (chronology code for winter) is greater than 21 (code for spring). To work around this, we are interpreting a certain ambiguous pattern in a particular way. Specifically, if you set $w to a digit, then set $y to 'ps24,21,22,23' (or some variation with '24' as the first value), you will get this winter-first behavior. Also, the season is treated internally as '20' then converted to '24' when processing is completed.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20472
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 12 May 2011 19:52:47 +0000 (19:52 +0000)]
Patch from James Fournie addressing LP#781803: Multiple renewal fails on MAX_FINES circs
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20463
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 12 May 2011 19:23:52 +0000 (19:23 +0000)]
Wrap proximity refreshing in a transaction to avoid timespans where there is no such information
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20457
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 12 May 2011 15:19:04 +0000 (15:19 +0000)]
Address LP#779975; Status of Available (0) not honored because 0==false -- use ternary op with defined() instead
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20454
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbwells [Thu, 12 May 2011 14:24:33 +0000 (14:24 +0000)]
Add missing permission checks to Serial.pm
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20451
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 5 May 2011 18:41:20 +0000 (18:41 +0000)]
Use valid JSON in Dojo i18n for Searcher.js
Dojo i18n processing scripts require valid JSON (quoted keys in hashes),
even though Dojo itself is more relaxed and accepts unquoted keys. So,
do the i18n dance here.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20439
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 5 May 2011 18:07:27 +0000 (18:07 +0000)]
adding upgrade script
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20433
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 4 May 2011 18:01:27 +0000 (18:01 +0000)]
Patch from James Fournie improving due-date-editor usability by auto-checking the check box; LP#
70956965
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20422
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 4 May 2011 17:50:39 +0000 (17:50 +0000)]
Patch from Jason Boyer swapping the order of report and template name in emailed notices; LP#777273
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20419
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbwells [Wed, 4 May 2011 13:50:22 +0000 (13:50 +0000)]
Fix some Serial Control text boxes which were too small to use effectively.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20416
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 4 May 2011 05:18:18 +0000 (05:18 +0000)]
Collaboration patch from Joseph Lewis and Michael Peters addressing LP#758007, missing patron merge OU settings.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20409
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 4 May 2011 04:59:36 +0000 (04:59 +0000)]
Addressing LP#732681 at upgrade time -- make authority records useful for controlling bibs
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20403
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 4 May 2011 04:54:57 +0000 (04:54 +0000)]
Initial fix from Michael Peters addressing small-screen UI issues: LP#767507
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20402
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Wed, 4 May 2011 04:44:08 +0000 (04:44 +0000)]
Change an ERROR to a DEBUG log message in mod_idlchunk
Reported by James Fournie at Sitka, this message was logged
as an error when it is simply a debug message; we drop the
level accordingly so that it will not appear in the Apache
logs during the normal course of operations.
Signed-off-by: Dan Scott <dan@coffeecode.net>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20399
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 4 May 2011 04:42:04 +0000 (04:42 +0000)]
Patch from Michael Peters to protect cut-in-line holds from staff without the appropriate permission
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20396
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 3 May 2011 16:34:51 +0000 (16:34 +0000)]
Avoid data loss by setting MARC::Charset->assume_unicode(1)
When using MARC::File::XML, MARC::Charset is used to perform character
conversions; however, MARC::File::XML does not tell MARC::Charset that it is
handling Unicode data. If we do not tell MARC::Charset that it is handling
Unicode data, it can return an error which results in the loss of data
(typically a subfield containing one or more characters which MARC::Charset
does not have an equivalent mapping outside of Unicode).
This problem could be reproduced in authority_control_fields.pl with a
subfield like "von Hans-Christian Müơller" - when this subfield was encountered
without assume_unicode(1), a null string was returned for that subfield, and
if the record was written back to the database due to an authority match being
found in a different field, the only recourse was to restore the record from
auditor.biblio_record_entry_history. The same sort of problems could occur
for any other script or function that modifies the data being handed to it
using MARC::File::XML and BinaryEncoding => UTF8.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20387
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 3 May 2011 15:08:48 +0000 (15:08 +0000)]
Followup patch to the first listed in https://bugs.launchpad.net/evergreen/+bug/745123
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20384
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 2 May 2011 14:06:36 +0000 (14:06 +0000)]
Fix bug and typo in stat cat editor
Specifically, disabling the ability to select a stat cat type on no permissions on current type.
If you don't have permissions on ASSET you could never get to ACTOR.
If you picked ACTOR without rights you couldn't get back to ASSET.
Also, re-enable the library selector and new buttons when you do change to one you can add for.
Author: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20373
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 2 May 2011 13:21:38 +0000 (13:21 +0000)]
fix "undefined is in transit"
https://bugs.launchpad.net/evergreen/+bug/773528
---
Fix bug squashing of params in checkin_via_barcode2 in circ/util.js.
Author: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20370
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Sun, 1 May 2011 13:53:22 +0000 (13:53 +0000)]
After investigation by Dan Scott, Michael Peters and Mike Rylander (a little), apos removal in advanced search normalization is considered harmful.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20366
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Sun, 1 May 2011 13:48:01 +0000 (13:48 +0000)]
Patch from Michael Peters, Jason Boyer and Jason Etheridge addressing LP#744244: bill_details.xul "Checkout or Renew Library" column is blank
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20363
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Sun, 1 May 2011 12:13:33 +0000 (12:13 +0000)]
Slight optimization for authority_control_fields.pl
Instead of creating two CStoreEditors per bib record, reuse the global
CStoreEditor for read operations; this way we only have to create a new
CStoreEditor if a record has fields to authorize.
Signed-off-by: Dan Scott <dan@coffeecode.net>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20358
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Wed, 27 Apr 2011 12:24:20 +0000 (12:24 +0000)]
One more strictly integer check for fleshing feeds in SuperCat
Missed this one in r20336. Argh.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20338
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Wed, 27 Apr 2011 12:21:13 +0000 (12:21 +0000)]
Consolidate on checking for integers for -full / -uris
The check for an integer when $flesh eq 'uris' was throwing errors
and breaking authority browsing; rather than complicating matters
further, use an explicit integer for the return value when the format
ends with "-uris" so that we can simply test for an integer value
greater than 0.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20337
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Wed, 27 Apr 2011 01:47:22 +0000 (01:47 +0000)]
Prevent a MARC::File::XML error from killing authority_control_fields.pl batch
Continuing to make this script bullet-proof, MARC::File::XML cares deeply
about things like whether datafields have indicators and throws exceptions
that, if not caught, kill a processing script - like this one.
Borrowing the approach from marc_export, wrap the new_from_xml() call in
a try / otherwise block and roll on.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20334
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 26 Apr 2011 20:53:22 +0000 (20:53 +0000)]
Hold, Transit, and Hold/Transit Slips used to suppress the printer dialog, but we lost that when we moved to templated slips. This adds a sticky Printer Prompt checkbox to Check In for controlling that behavior.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20331
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 26 Apr 2011 20:46:03 +0000 (20:46 +0000)]
Setting print.always_print_silent to false is a bad thing, since it trumps gPrintSettings.printSilent, and will cause a print dialog regardless of Printer Prompt or Auto-Print checkboxes. Let's clear it instead when toggling it off, and if we find it lingering as false from past code, let's clear it then too.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20330
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 26 Apr 2011 17:24:16 +0000 (17:24 +0000)]
Protect against errors returned by open-ils.search
If open-ils.search returns an error rather than a result, prevent
authority_control_fields.pl from bombing out completely; instead,
flag the problem in STDERR and move on to the next record.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20325
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 26 Apr 2011 15:49:38 +0000 (15:49 +0000)]
set the cancel cause field when patrons cancel holds. There's a holdsCancel function that also does this, but it never gets called by anything
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20322
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 26 Apr 2011 14:41:30 +0000 (14:41 +0000)]
fix disappearing cursor/caret for Check In
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20316
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 26 Apr 2011 14:13:55 +0000 (14:13 +0000)]
Make authority_control_fields.pl resistant to database timeouts
LP 771237 describes how on an underpowered system, the work that
authority_control_fields.pl tries to do on a per-record basis may hit the
CStore default timeout of 6 seconds for a transaction and automatically
end the transaction, resulting in no work being committed once the script tries
to update the bibliographic record. Searching each controlled field for a
matching authority record can be costly in a database with millions of
authority records.
To enable the script to accomplish its work on underpowered test systems, use a
regular read-only CStoreEditor session to accomplish the lookups and create a
separate CStoreEditor session to issue the update in a transaction if required.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20313
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 25 Apr 2011 18:24:33 +0000 (18:24 +0000)]
Add a space between TOC part and TOC title in OpenLibrary added content
In trunk/rel_2_1 we switched to layout.css for table of contents
styling. We'll keep it simpler for stable 2.0 and handle this
bugfix completely inline.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20305
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 22 Apr 2011 21:37:12 +0000 (21:37 +0000)]
address the empty-query case
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20297
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Fri, 22 Apr 2011 21:13:39 +0000 (21:13 +0000)]
Disable Save Columns in xul holds interface when Hold Details is being viewed. https://bugs.launchpad.net/evergreen/+bug/691599 Not the best fix, but the quickest fix
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20294
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 22 Apr 2011 20:50:29 +0000 (20:50 +0000)]
Address LP#730743, errant parens cause pain
Specifically, we prune subplans that contain no nodes (empty parens), and avoid dropping out of the top level query context when we encounter a close-paren.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20291
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Fri, 22 Apr 2011 14:32:12 +0000 (14:32 +0000)]
Turn off non-working print button for holds pull
https://bugs.launchpad.net/evergreen/+bug/727983
Author: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20282
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 22 Apr 2011 00:41:15 +0000 (00:41 +0000)]
Patch from James Fournie to sort statcats in their comboboxes
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20277
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 21 Apr 2011 13:17:10 +0000 (13:17 +0000)]
check user 'active' field in SIP charge_ok (and dependent) calls
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20270
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Wed, 20 Apr 2011 20:32:12 +0000 (20:32 +0000)]
Revert r20035 - restore default copy status for Fast Add to "Available"
As noted in https://bugs.launchpad.net/evergreen/+bug/756838, the default
status for "Fast Add" copies has been "Available" since release 1.6.1.0.
Changing the default in the middle of the 2.0 release series would likely
cause more confusion for those sites who appreciate the current Fast Add
behaviour, so this reverts the changes in r20035 and maintains the same
defaults as 1.6.1.0.
Note that in r20264, 2.1.0 will gain two new org unit settings that will
enable sites to control their preferred default copy status for the Fast Add
and Add Volume interfaces.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20265
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 20 Apr 2011 16:11:58 +0000 (16:11 +0000)]
Backport of trunk r20250: Always use BinaryEncodeing => "UTF-8" with MARC::File::XML
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20252
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 20 Apr 2011 15:41:21 +0000 (15:41 +0000)]
Patch from Jeff Davis addressing parameter usage issues
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20246
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 19 Apr 2011 21:05:24 +0000 (21:05 +0000)]
Typo: Propeties/Properties
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20226
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 19 Apr 2011 19:51:26 +0000 (19:51 +0000)]
Use top level join instead of subquery in hold queue position query
This is more readily optimized by the Postgres planer.
Note also, for very large data sets (lots of holds, on the order of 100k+ active), the following is also advised:
ALTER TABLE action.hold_copy_map alter column target_copy SET statistics 500, alter column hold set statistics 500;
ANALYZE action.hold_copy_map;
This gives the planner better data about the hold-copy-map n-distinct.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20219
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbwells [Tue, 19 Apr 2011 17:56:49 +0000 (17:56 +0000)]
Fix dump-style printing by ensuring 'params' is defined before accessing it
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20218
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 19 Apr 2011 14:16:54 +0000 (14:16 +0000)]
one more fix, for Show in Catalog on issuance holds
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20198
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 19 Apr 2011 14:16:51 +0000 (14:16 +0000)]
display issuance label, not subscription label
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20197
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 19 Apr 2011 14:16:48 +0000 (14:16 +0000)]
Add xul support for displaying issuance holds (needs testing)
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20196
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 19 Apr 2011 02:54:06 +0000 (02:54 +0000)]
Mark cmc.label for translation, not cmc.name, in seed data
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20194
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 19 Apr 2011 02:20:56 +0000 (02:20 +0000)]
Mark cmf and cmc labels as translatable
We went to the effort of extracting the translatable text from
950.data.seed-values.sql, but had not marked the fields as
translatable in the IDL. Now at least the out-of-the-box
fields and classes will easily be able to have translations.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20191
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 19 Apr 2011 01:49:45 +0000 (01:49 +0000)]
Add openils.widget.Searcher Dojo NLS to the i18n build
Necessary for the "advanced" searchbar on the Evergreen
AjaxPAC.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20187
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 19 Apr 2011 01:08:25 +0000 (01:08 +0000)]
Correct encoding issue with authority_control_fields.pl
Is there ever a time when MARC::File::XML would be invoked with
anything other than BinaryEncoding => 'utf-8'? Not here, at
least. Addresses LP# 764582.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20184
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Mon, 18 Apr 2011 15:47:18 +0000 (15:47 +0000)]
improve comments on a couple config tables
Based on suggestions from Mike Rylander and Thomas Berezansky.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20167
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Mon, 18 Apr 2011 15:47:16 +0000 (15:47 +0000)]
minor improvements to database object comments
* remove copyright, license verbiage, and C-style comment marking
from the comments; these can live in the SQL scripts
* updated several copyright headers
* minor improvements to documentation of a couple tables
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20166
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 18 Apr 2011 05:30:29 +0000 (05:30 +0000)]
in the MARC Editor, put the callnumber and barcode textboxes for Fast Item Add on a separate row
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20153
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 18 Apr 2011 05:15:34 +0000 (05:15 +0000)]
Enable relative paths in i18n testing scripts
We were 98% of the way there; now we no longer need to
cd into the same directory as the i18n testing scripts
to run them with meaningful output. Should be useful
for adding these to the CI server.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20150
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 18 Apr 2011 04:40:17 +0000 (04:40 +0000)]
Don't check .js files for entities
Must have asked this script to check JS files for valid entities
for a reason at some point in the dark past, but it couldn't have
been a very good reason; we're getting a false positive that needs
to be hushed now. Better to just stop looking for XML entities in
JavaScript.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20147
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Sat, 16 Apr 2011 03:28:36 +0000 (03:28 +0000)]
Allow NULL "use restriction" fields for located URIs
The asset.uri.use_restriction field, which is really a sort of public notes
field for 856 fields, was grabbing the $u subfield (URL) as a sort of last-gasp
effort to give it some data. However, the effect was rather odd and led to
workarounds like Conifer's skin to avoid displaying the use restriction field
if its value was identical to the URL, etc.
Instead, stop grabbing $u and handle the case where use_restriction column is
NULL gracefully, just like the schema intended.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20125
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Sat, 16 Apr 2011 03:19:49 +0000 (03:19 +0000)]
Do not clear auri links in default skin
The dojo orphan() call which attempted to wipe any non-located 856s
was actually wiping the located 856s in the record detail display.
Removing the extra call makes this work in Firefox and Chromium,
at least.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20122
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Sat, 16 Apr 2011 02:20:06 +0000 (02:20 +0000)]
Delete ##URI## call numbers and uri_call_number_map entries on bib reingest
This approach will lead to some acn/auricnm ID inflation, but it works.
Addresses LP# 761130 (immortal ##URI## entries in asset.call_number) reported
by Ben Shum and LP# 761085 (cannot delete bib with ##URI## volumes) reported
by Jason Etheridge.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20119
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Fri, 15 Apr 2011 20:18:05 +0000 (20:18 +0000)]
Protect dumb JavaScript engines from having to deal with actual Unicode
The holdings_xml format did not include an XML declaration, but adding that
as we do here still does not make the Firefox and Chromium JS engines capable
of consuming XML that contains Unicode content outside of the base ASCII
range.
So, we invoke entityize() to convert anything outside of the realm of
ASCII to XML entities. An alternative would be to invoke entityize() in
OpenILS::Application::SuperCat::unAPI::acn but it's not clear if that
would interfere with any other uses.
With this change, library names / copy location names with Unicode content
can be displayed correctly on the search results page.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20114
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 15 Apr 2011 15:46:09 +0000 (15:46 +0000)]
Re-add (from ingest in 1.6) support mulitiple subfield-9 values in a single 856 tag
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20103
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 15 Apr 2011 13:56:45 +0000 (13:56 +0000)]
Protect pcrud-ish retrieve from an empty result set
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20096
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 14 Apr 2011 21:22:33 +0000 (21:22 +0000)]
Restore URIs in marcxml-uris unAPI format
At some point (r16750) we started doing a numeric comparison of
$flesh instead of just checking to see if $flesh was defined; this
returned false when $flesh == 'uris', preventing URIs from being
included in the marcxml-uris unAPI format.
This restores URIs to marcxml-uris and so we can revert the extra
BibTemplate call in rdetail_summary.xml.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20093
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 14 Apr 2011 20:39:07 +0000 (20:39 +0000)]
Specify the holdings_xml unAPI format for URI calls
The unAPI marcxml-uris format is not returning URIs at the moment.
While we're getting that fixed, use the holdings_xml format to
get the URI job done; requires an extra JS call, but that's
better than not working at all.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20090
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 14 Apr 2011 18:24:42 +0000 (18:24 +0000)]
Escape rather than filter SIMILAR TO metacharacters in patron crazy search
The filtering I introduced in r19983 was overly aggressive, and included
characters that weren't actually SIMILAR TO metacharacters. Instead, escape
each character, carefully going through the list of metacharacters listed at
http://www.postgresql.org/docs/8.4/interactive/functions-matching.html
Works for email addresses like "foo.bar+baz@example.com".
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20087
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Thu, 14 Apr 2011 17:58:52 +0000 (17:58 +0000)]
Backport r20082 from trunk
Address LP #754880, where printing happens before the progress dialog can be
cleared in the alternate holds pull list print interface
Additionally, provide the usual "print page" button so that the list can be
reprinted at will
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20084
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 14 Apr 2011 16:51:55 +0000 (16:51 +0000)]
upgrade script for consistency w/ schema change in r20073
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20081
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 14 Apr 2011 16:10:09 +0000 (16:10 +0000)]
rely on search_path to locate the extract_marc_field() function which is now installed in the 'evergreen' schema by default
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20078
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Thu, 14 Apr 2011 15:49:54 +0000 (15:49 +0000)]
tweaks to quick_metarecord_map.sql
* used version from wiki, which provides same results as the
previous version but performs better on large databases
* now works without editing (a vacuum cannot run inside of a transaction)
* don't do vacuum full, just a regular vacuum analyze
[1] http://evergreen-ils.org/dokuwiki/doku.php?id=scratchpad:random_magic_spells#how_to_generate_metarecords_for_a_newly_loaded_bib_batch
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20077
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 13 Apr 2011 16:13:14 +0000 (16:13 +0000)]
Protect search against all-deleted bibs by pinning the estimation ratios in that case
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20067
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 12 Apr 2011 21:59:44 +0000 (21:59 +0000)]
repaired SQL upgrade syntax error
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20062
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 12 Apr 2011 18:16:46 +0000 (18:16 +0000)]
Add a trigger function to simulate FKEY constraints on inherited tables
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20055
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 12 Apr 2011 17:28:37 +0000 (17:28 +0000)]
Final cleanup for the base schema, re search_path ... I hope
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20050
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 12 Apr 2011 17:24:58 +0000 (17:24 +0000)]
Fix functions stranded in the evergreen schema without a search path reference (ugly but mechanical)
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20049
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Tue, 12 Apr 2011 16:54:18 +0000 (16:54 +0000)]
add missing upgrade script
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20046
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 11 Apr 2011 16:56:51 +0000 (16:56 +0000)]
Let's not be picky about permissions here; an item needs to go where it needs to go :)
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20042
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Sun, 10 Apr 2011 21:35:46 +0000 (21:35 +0000)]
patch from jamesrf for lp#756880 for Grocery Billing Location in Bill Patron wizard
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20038
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Sun, 10 Apr 2011 20:53:56 +0000 (20:53 +0000)]
for lp bug#756838, consistent copy status for new items. jamesrf++
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20035
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 8 Apr 2011 19:29:16 +0000 (19:29 +0000)]
repaired bug in prepayment_required check. property -> method
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20032
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Fri, 8 Apr 2011 18:23:33 +0000 (18:23 +0000)]
For transit_slip template, %item_title%, %item_barcode%, etc. need to be in the Header, not the Line Item
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20029
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 7 Apr 2011 18:41:34 +0000 (18:41 +0000)]
test for pre-cat slightly off in OPAC My Account, spotted by Steve Callender
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20019
dcc99617-32d9-48b4-a31d-
7c20da2025e4