Add more seed data

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Adjust display of next-status labels in the copy alert popup

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Correct location test for at_circ and at_owning

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

tweak styling

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

improve init of next status

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add 'add copy alert' action

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/web/js/ui/default/staff/circ/services/circ.js

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add acknowledge alerts to renewal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

allow both CHECKIN and CHECKOUT alerts to fire during renewal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

correctly test whether the alert_type fires during renewal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

no longer display the legacy copy alert message

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

fix styling of manage copy alert button in item status

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add new-style copy alerts to volcopy defaults selector

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

copy alert type editor can now create and update copy alert types

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

make copy alert suppression editor feature-complete

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

set name as copy alert type selector field

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add copy alert suppression to splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

start UI for managing copy alert suppression

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add copy alerts to local admin splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

start on a config editor for config.copy_alert_types

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

teach vol/copy editor how to deal with copy alerts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add copy alert ack/manage action to checkin, checkout, and item status

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/src/templates/staff/cat/item/t_summary_pane.tt2

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

implement setting next status upon checkin

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

display text for system-generated copy alerts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

return all potential next copy statuses, not just first

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

have a bit of visual separation between alerts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

start work on egCopyAlertManagerDialog

This dialog is currently capable of:

- displaying copy alerts during checkin and checkout
- allowing the operator to acknowledge temporary alerts

TODO:

- allow display of all current alerts
- allow alerts to be added

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/web/js/ui/default/staff/circ/services/circ.js

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

some sample copy alert types

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

don't generate system copy alerts if copy state is normal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

support the LOST_AND_PAID status added in LP#1198475

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

fix various thinkos and syntax errors to get the biz logic working

As of now, open-ils.circ.checkin is now starting to emit
custom copy alerts.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

fix some typos, syntax errors, and stray invisible characters

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add typo/space fixes to baseline schema

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

biz logic for alerts

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Baseline IDL stuff for alerts

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Initial schema for copy alerts

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Fixing menu refs on booking docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: replacing Admin menu with Administration menu

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

docs: LP1717583 add details about aged circulation

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Fix AsciiDoc header syntax bug

This docs section header was renamed, but the underline needs to be
changed to match.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: Remove duplicate lines from root.adoc

In the previous commit to root.adoc (7ecad6eb) a chunk of lines were
accidentally duplicated. This commit removes the duplicate lines. I
confirmed that this change allows the PDF to build successfully.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

LP#1656036 Webstaff dynamic page titles

Support page/tab titles applied by page controllers.  Each title is
composed of 2 optional components, a dynamic component and a context
component.

The dynamic component may be interpolated with real-time data (e.g. a
patron's name) and the context is generally a page or tab-level value
(e.g. Checkout).

For example:  "Smith, Jane - Checkout"

Apply a title within a controller like so:

egCore.strings.setPageTitle(
    egCore.strings.MY_DYNAMIC_TEMPLATE,
    egCore.strings.MY_CONTEXT_STRING,
    {foo : 'foo', bar : 'bar'}
);

If no values are set, the default template-level title is applied.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/templates/staff/base_js.tt2
Open-ILS/web/js/ui/default/staff/circ/patron/app.js

forward-port 2.12.7 upgrade script

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Forward-port 3.0.1 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Fix stray beta1 in 3.0.0 upgrade script

I do not think this actually affects anything.

We'll fix this for early adopters in the 3.0.1 upgrade script, I
think.

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Docs: 3.0.1 Release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: 2.12.7 release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1659181 Mark Items Damaged Prompt

- Add new prompt for marking an item as damaged.
- If there is a fee when marking an item as damaged, offer the
option to charge as normal, manually bill the patron, or to waive
the charge.
-Affected interfaces: Holds pull list, Holds Shelf, Patron Holds,
Record Holds, Record Holdings, Item Status(List), Item Status(Detail)

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm
modified:   Open-ILS/src/templates/staff/cat/catalog/index.tt2
modified:   Open-ILS/src/templates/staff/circ/checkin/index.tt2
modified:   Open-ILS/src/templates/staff/circ/holds/index.tt2
new file:   Open-ILS/src/templates/staff/circ/share/t_mark_damaged.tt2
modified:   Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
modified:   Open-ILS/web/js/ui/default/staff/cat/item/app.js
modified:   Open-ILS/web/js/ui/default/staff/circ/checkin/app.js
modified:   Open-ILS/web/js/ui/default/staff/circ/services/circ.js
modified:   Open-ILS/web/js/ui/default/staff/circ/services/holds.js
modified:   Open-ILS/web/js/ui/default/staff/circ/services/item.js

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Merge branch 'master' of git.evergreen-ils.org:Evergreen

DOCS: added tip for patron insensitive search (ignores punctuation)

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>

LP#1712686 - display completed barcode on copy grids not partial input

The check in, check out, and renew interfaces were not displaying
the actual complete(d) barcode when barcode completion is on.
This saves the inputted partial barcode in row_item.input_barcode
and let's the returned acp.barcode be in row_item.copy_barcode for
display.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1714566 - enable hold notes to display on dialogs

Also display all notes in the hold shelf dialog and other dialogs
so that staff is aware of any public notes that will
print.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1714566 - enable hold notes set to print on slip to be shown

Adds a bit of code and edits the realted templates in order
to be able to see any hold notes set to print on the slip.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1714060 -  fixes thinko when obeying patron.password.use_phone setting in patron regctl

There was a bug, an undefined variable was being used to assign the last
four digits of the day_phone to usr.passwd when this library setting
was being used.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1715423 - fix issues with the display of IDs in patron summary pane

The Patron summary pane was not properly displaying the values
for the primary ID and secondary ID. Also added the type name of
the ID in next to primary ID label.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1714056 - fix for webstaff patron registration not requiring DOB

For some reason the ng-required attribute was not on the dob input
control. Setting 'ui.patron.edit.au.dob.require' should now work
as intended.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1721145 - fix Patron Message tab grids missing persist-keys

In order to store grid column config preferences locally, a persist-key
attribute needs to be declared for the grid. Thus, for this UI a
'circ.patron.staff_messages' and a 'circ.patron.archived_messages'
persist-keys were added.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1689325 - correct typo repeated templateUrl modal

Patron items out renew with date modal had a repeated templateURl.
Probably just a copy-pasta typo.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1689325 - require most modals have explicit 'exit' or 'cancel' action inside the modal

Disable the default bahavior of bootstrap modals that lets
the user click outside the modal to dismiss or cancel it.
Similar behavior is not in the XUL, and this will make
unintentional clicks outside the modal less prone to losing
work in said modal.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1710731 - fix webstaff hold slip and other templates missing call number

Added call number to various dialogs and printtemplates
that lacked them.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1717025 - make Specific Due Dates Until Logout in Patron Checkout

Made a few (opinionated) changes, that try to follow some JS
best practices. Changed Bool flags like date_options.sticky_date
to has_sticky_date, which avoids confusion with the checkoutArgs
property of the same name, and provides a clue about it's type
and function. Also added semicolons to any JS statements and
function expressions that were missing them.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1717025: Persist Specific Due Dates Until Logout

Add an option to the specific due date feature to
save the specified date until logout. This allows
all circulations from a given workstation to be due
on the same date.

Signed-off-by: Jason Boyer <JBoyer@library.in.gov>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1717010 Webstaff print/export full grid

1. Adds a new 'Print Full Grid' action which generates printer-friendly
HTML output of all grid rows.  The print content matches the display
grid structure, uses the same field filters (e.g. for formatting dates)
and is retrieved using the same query and sort parameters as the display
grid.

To render the grid as HTML, a new print HTML template is included at
print_templates/t_grid_html.tt2.

2. Modifies the 'Export CSV' action to export all grid rows instead of
only the visible rows.  The link label is modified to 'Export Full CSV'
to better indicate its intent.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1716962 - honor In-House Use: num of uses threshold setting

The 'ui.circ.in_house_use.entry_warn' library setting was not being
taken into account nor any confirmation/warning modal being shown.
This fix addresses that by watching the changes and if selected
num_uses value exceeds setting value, displays egConfirm modal.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1719967 - Add alert message field to volcopy editor

As 1676608 was deferred to 3.1, this adds a copy alert_message
field, to the volcopy editor. The defaults tab "Alerts" checkbox has
been replaced by "Alert Message" and this new field will be active until replaced by
the changes of 3.1.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Docs: adding backup information to cli manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding new services to command line manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: 2 new services

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1721557 Fix Vandelay export within web client

Triggering a file download from dojo pages within the web client
requires a new technique. This commit borrows from the acq lineitem
table export (acq/common/li_table.js) and applies the technique to the
vandelay feature.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: located URIs don't work with trailing spaces

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: documentation for Record Buckets

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: updating copy buckets docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: bumping release notes for consolidated manual to 3.0

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: remove electronic resources heading

The additional heading isn't needed in the release notes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: ebook api release note entry and doc changes

Moved the content from ebook_transactions.adoc file to the 3.0 release notes.
I also incorporated changes introduced in 3.0 into the documentation on
ebook api.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1720394: This html thinko in copy tag display

A closing td tag appears to be have been accidentally used when closing the
opening td tag. It doesn't appear to affect the display of the copy tag, but should probably be fixed.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1717007 Improve egProgressDialog collision handling

Resolves a race condition where egProgressDialog.open() is called twice
before the first call completes (i.e. the dialog is opened), leaving 2
open dialogs, one of which cannot be closed because its reference is
lost.

Going forward, attempts to open multiple dialogs will always result in
the most recently visible dialog taking preference.  When collisions
occur, a warning is also issued to the console.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1666512: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1666512 - Only insert if not already existing

This repatch was requested by Galen Charlton to make it easier for
upgrades to avoid adding the entries or failing if the entries already
existed.

Also drops the unnecessary i18n tagging for the billing type names
since it does not work with applying upgrade scripts (only for sourcing
db.seed data for translation to PO file)

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1666512 - Add billing types from 2009-era features.

For systems that were running Evergreen 1.2 or so and upgraded to 1.4
or so, there were billing types added that did not make it into an
upgrade script.  We add them here just in case you don't have them.
Systems installed since Evergreen 1.4 are probably not affected.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

correct the acknowledgement of Consortium of Ohio Libraries

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

bump up monolithic schema upgrade script for 3.0.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Remove redundant function update from 3.0-RC upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Rename monolithic upgrade for 3.0-RC

To account for 2.12.6 being the current flavor of 2.12.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - po files

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - newpot

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

minor updates to release notes

* formatting fixes
* make capitalization of headings more consistent
* replace remaining references to "OPAC"

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Juvenile-to-adult script

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: documenting copy locations

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: cleaning up client sysadmin manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Adding search config info to client admin manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Adding some use cases to MARC Batch Edit

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: documenting RDA 264

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: cleaning up client sysadmin manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Merge branch 'master' of git.evergreen-ils.org:Evergreen

LP#1720345: ensure egEditFmRecord's customFieldTemplates is optional

This patch ensures that the custom-field-templates attribute of
the eg-edit-fm-record directive is strictly optional, fixing a
regression for instances of that directive that don't need that
attribute.

To test
-------
[1] Apply the patch.
[2] Verify that the Server Administration | Copy Tag Types and
    and Local Administration | Copy Tags admin interfaces
    allow you to create and edit values.
[3] Verify that the Serials Administration | Prediction
    Pattern Templates interface continues to work.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Update RELEASE_NOTES_3_0.adoc

minor spelling corrections in the Acknowledgment section

Docs: info about LP #1622364

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: root.adoc can now compile

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Adding information on using native browser functionality

The section on setting a home page seemed out of place in the Log in section.
I moved it to a new section that covers best practices for using the browser,
which also includes earlier documentation on using tabs and new documentation
on disabling popup blockers.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: Update login chapter
Some things have changed in the web client since this documentation was
first created. Removing the note that workstation registration is not required
and updating the caution on what happens when exiting the browser.

Previously, workstation registration was part of installing the staff client,
but since we have nothing to install, I added it to the logging in section. I
also removed a xul client feature from the main root.adoc.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>