working/Evergreen.git
7 years agoLP#1775466 Grid tooltips max width 400 collab/berick/lp1775466-ang6-base-app
Bill Erickson [Wed, 29 Aug 2018 18:15:20 +0000 (14:15 -0400)]
LP#1775466 Grid tooltips max width 400

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1775466 Remove cookie migration note from Ang6 install docs
Bill Erickson [Wed, 29 Aug 2018 14:54:22 +0000 (10:54 -0400)]
LP#1775466 Remove cookie migration note from Ang6 install docs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1775466 Point Server Admin back to AngJS app
Bill Erickson [Wed, 29 Aug 2018 14:52:34 +0000 (10:52 -0400)]
LP#1775466 Point Server Admin back to AngJS app

Now only the Acq Admin menu item directs the user to the Angular app.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1775466 Migrate auth cookies to / for sharing
Bill Erickson [Wed, 29 Aug 2018 14:45:17 +0000 (10:45 -0400)]
LP#1775466 Migrate auth cookies to / for sharing

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into collab/berick/lp1775466...
Bill Erickson [Wed, 29 Aug 2018 14:12:49 +0000 (10:12 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into collab/berick/lp1775466-ang6-base-app

7 years agoLP#1775466 Splash page catalog search routes to angjs version
Bill Erickson [Mon, 27 Aug 2018 21:33:25 +0000 (17:33 -0400)]
LP#1775466 Splash page catalog search routes to angjs version

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1775466 Add Angular(6) build steps to make_release
Bill Erickson [Fri, 24 Aug 2018 21:30:19 +0000 (17:30 -0400)]
LP#1775466 Add Angular(6) build steps to make_release

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1768902 Stamping DB upgrade for Z39 UPC
Bill Erickson [Fri, 24 Aug 2018 20:05:09 +0000 (16:05 -0400)]
LP#1768902 Stamping DB upgrade for Z39 UPC

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1768902: quick release note entry
Ben Shum [Thu, 3 May 2018 17:36:31 +0000 (12:36 -0500)]
LP#1768902: quick release note entry

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1768902: Add UPC to z3950 search for OCLC and LOC
Ben Shum [Thu, 3 May 2018 17:24:44 +0000 (12:24 -0500)]
LP#1768902: Add UPC to z3950 search for OCLC and LOC

Based on settings provided by Jane Sandberg, add the UPC as a search
attribute definition for OCLC and LOC z3950 targets.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1775466 Improve locale building
Bill Erickson [Fri, 24 Aug 2018 16:26:54 +0000 (12:26 -0400)]
LP#1775466 Improve locale building

Break string export and merge into multiple steps to more easily
accomodate other locales down the road.

Adds script to stamp the locale-specific index.html file (for fr-CA only
now) so users don't have to do it manually.  For now, this command is
still locale-specific, but we should be able to further generify down
the road.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1775466 Grid tooltips on overflow only / top-left
Bill Erickson [Fri, 24 Aug 2018 15:52:50 +0000 (11:52 -0400)]
LP#1775466 Grid tooltips on overflow only / top-left

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into collab/berick/lp1775466...
Bill Erickson [Fri, 24 Aug 2018 14:40:25 +0000 (10:40 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into collab/berick/lp1775466-ang6-base-app

7 years agoDocs: adding release notes and docs for LP1760160
Jane Sandberg [Tue, 1 May 2018 08:22:15 +0000 (03:22 -0500)]
Docs: adding release notes and docs for LP1760160

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP1760160: Search bar has a different CSS class when on the home page
Jane Sandberg [Sat, 31 Mar 2018 13:48:49 +0000 (06:48 -0700)]
LP1760160: Search bar has a different CSS class when on the home page

To test:
1. In templates/opac/css/style.css, add some highly noticeable CSS that
applies to .searchbar-home or an element within .searchbar-home, e.g.
  .searchbar-home .search-box {
    background-color: purple;
    height: 4em;
  }
2. Go to the home page of your public catalog.  The .searchbar-home .search-box CSS
should have taken effect.
3. Go to another page of your public catalog, such as a search results
or login page.  The CSS should not have taken effect here.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP 1768715: pingest.pl merge conflict typo fix: skip_dispaly
Bill Erickson [Thu, 23 Aug 2018 16:26:11 +0000 (12:26 -0400)]
LP 1768715: pingest.pl merge conflict typo fix: skip_dispaly

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP 1768715: pingest.pl Release Notes and Installation
Jason Stephenson [Sun, 3 Jun 2018 00:33:23 +0000 (20:33 -0400)]
LP 1768715: pingest.pl Release Notes and Installation

Add pingest.pl to Open-ILS/src/Makefile.am so it will be installed by
default.

Add release notes for pingest.pl.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP 1768715: Fix pingest.pl bug discovered by Dan Scott of Laurentian U.
Jason Stephenson [Sat, 2 Jun 2018 23:18:40 +0000 (19:18 -0400)]
LP 1768715: Fix pingest.pl bug discovered by Dan Scott of Laurentian U.

Reingest was not happening if all ingests were skipped, except for the
display field reingest.  This came down to a matter of two conditional
statements not including checks for the $skip_display variable being
true.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP 1768715: Use older named notation in pingest.pl
Jeff Godin [Fri, 24 Nov 2017 15:23:56 +0000 (10:23 -0500)]
LP 1768715: Use older named notation in pingest.pl

Use older style param := 'value' named notation for PostgreSQL
function calls in pingest.pl to support PostgreSQL versions < 9.5.

NOTE: This commit was modified to fit with the flow of the surrounding
commits from the master branch of the source repository.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP 1768715: Whitespace cleanup in Blake's commit.
Jason Stephenson [Wed, 22 Nov 2017 02:23:03 +0000 (21:23 -0500)]
LP 1768715: Whitespace cleanup in Blake's commit.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP 1768715: Missing semi colon
Blake GH [Tue, 21 Nov 2017 16:41:48 +0000 (10:41 -0600)]
LP 1768715: Missing semi colon

Add missing semi-colon in pingest.pl.

Signed-off-by: Blake GH <blake@mobiusconsortium.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP 1768715: Handle the skip_display option of metabib.reingest_metabib_field_entries.
Jason Stephenson [Wed, 4 Oct 2017 20:43:37 +0000 (16:43 -0400)]
LP 1768715: Handle the skip_display option of metabib.reingest_metabib_field_entries.

pingest.pl gets a --skip-display option of its own that disables the
display ingest.  The display ingest is also skipped in the browse
ingest.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP 1768715: Add skip_browse where it was missed in pingest.pl.
Jason Stephenson [Wed, 4 Oct 2017 17:25:19 +0000 (13:25 -0400)]
LP 1768715: Add skip_browse where it was missed in pingest.pl.

I missed the named parameter for skip_browse in reingest_field_entries
in pingest.pl in the earlier commit.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP 1768715: Use named arguments in function calls in pingest.pl.
Jason Stephenson [Wed, 4 Oct 2017 16:55:05 +0000 (12:55 -0400)]
LP 1768715: Use named arguments in function calls in pingest.pl.

This makes it work, more or less, with Evergreen 3.0 and the changes
to metabib.reingest_field_entries.  Note that the new skip_display
parameter is not set, so you might get collisions between the browse
ingest and one of the other ingest processes if they both work on the
same record at once.

I will make a branch for use with Evergreen 3.0 until I upgrade to
Evergreen 3.0 and merge that branch into master.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP 1768715: Add database connection parameters to pingest.pl command line.
Jason Stephenson [Wed, 4 Oct 2017 15:18:35 +0000 (11:18 -0400)]
LP 1768715: Add database connection parameters to pingest.pl command line.

This will serve as the model for future Perl scripts that need to
connect to the PostgreSQL database with DBI.  I may go back and alter
the existing scripts to use this method.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP 1768715: Make the pingest.pl --pipe option be greedy.
Jason Stephenson [Mon, 11 Apr 2016 16:25:57 +0000 (12:25 -0400)]
LP 1768715: Make the pingest.pl --pipe option be greedy.

The --pipe option is used with pingest.pl now assumes that that any
string of digits in the input is a record id.  Instead of using just
the first string of digits on a line, as it did before, it now uses
each string of digits on a line.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP 1768715: Simplify Open-ILS/src/support-scripts/pingest.pl with selectcol_arrayref.
Jason Stephenson [Mon, 11 Apr 2016 14:39:02 +0000 (10:39 -0400)]
LP 1768715: Simplify Open-ILS/src/support-scripts/pingest.pl with selectcol_arrayref.

By switching to DBI->selectcol_arrayref in pingest.pl, we can avoid
having to check for references in the main loop.  This eliminates an
extra variable and an extra line of code that are no longer needed.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP 1768715: Only connect to the database when needed in pingest.pl.
Jason Stephenson [Fri, 1 Apr 2016 14:02:45 +0000 (10:02 -0400)]
LP 1768715: Only connect to the database when needed in pingest.pl.

We chagne where we connect and disconnect the database in the parent
process in pingest.pl.  There's no point connecting at all if the
--pipe option is used.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP 1768715: Fix bug in pingest.pl after --pipe option was added.
Jason Stephenson [Fri, 1 Apr 2016 14:00:20 +0000 (10:00 -0400)]
LP 1768715: Fix bug in pingest.pl after --pipe option was added.

Apparently, the results of DBI->selectall_arrayref need to be cast to
an array and not just returned as a list.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP 1768715: Add --pipe option to pingest.pl
Jason Stephenson [Thu, 31 Mar 2016 15:39:49 +0000 (11:39 -0400)]
LP 1768715: Add --pipe option to pingest.pl

With this option, pingest.pl reads a list of record IDs from standard
input, instead of running a query.  This is useful if you have a
custom query to output only certain records to reingest and you can
pipe the output into pingest.pl.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP 1768715: pingest supports max/min ID, duration, more ops
Bill Erickson [Tue, 16 Feb 2016 17:59:55 +0000 (12:59 -0500)]
LP 1768715: pingest supports max/min ID, duration, more ops

From the new help text:

    --batch-size
        Number of records to process per batch

    --max-child
        Max number of worker processes

    --skip-browse
    --skip-attrs
    --skip-search
    --skip-facets
        Skip the selected reingest component

    --start-id
        Start processing at this record ID.

    --end-id
        Stop processing when this record ID is reached

    --max-duration
        Stop processing after this many total seconds have passed.

    --help
        Show this help text.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
7 years agoLP 1768715: Add pingest.pl to Evergreen.
Jason Stephenson [Mon, 26 Oct 2015 14:32:19 +0000 (10:32 -0400)]
LP 1768715: Add pingest.pl to Evergreen.

Add Open-ILS/src/support-script/pingest.pl to do ingests in parallel.
See release notes for details.

NOTE: This and subsequent commits were added from a branch that
preserves the history of the repository from which pingest.pl was
copied.  The dates on these commits represent when the code was added
or modified in the source repository.  They do not reflect when the
code was added to Evergreen.

Also, pingest.pl predates this commit.  The date on this commit was
when the source repository was split into separate directories for SQL
and Perl scripts.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1732552: Move OPAC login username hint to separate template
Jeff Davis [Wed, 15 Nov 2017 22:36:21 +0000 (14:36 -0800)]
LP#1732552: Move OPAC login username hint to separate template

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoDocs: finalizing 3.1.5 release notes
Jane Sandberg [Wed, 22 Aug 2018 20:58:24 +0000 (13:58 -0700)]
Docs: finalizing 3.1.5 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 years agoDocs: finalizing 3.0.11 release notes
Jane Sandberg [Wed, 22 Aug 2018 20:57:32 +0000 (13:57 -0700)]
Docs: finalizing 3.0.11 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 years agoLP1733590: Only Print Selected Items Out
Jason Boyer [Wed, 22 Aug 2018 13:07:55 +0000 (09:07 -0400)]
LP1733590: Only Print Selected Items Out

The list of selected items being passed to print_receipt
was being ignored and the whole list of items currently
checked out used instead. This patch uses the list
presented so staff can only print those items that they
want to, such as a small number of items renewed today,
etc.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
7 years agoDocs: more release notes for 3.1.5
Jane Sandberg [Wed, 22 Aug 2018 17:22:20 +0000 (10:22 -0700)]
Docs: more release notes for 3.1.5

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 years agoDocs: updating 3.0.11 release notes
Jane Sandberg [Wed, 22 Aug 2018 17:18:29 +0000 (10:18 -0700)]
Docs: updating 3.0.11 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 years agoLP#1788417: boolean fields should say 'Yes'/'No' instead of true/false
a. bellenir [Wed, 22 Aug 2018 15:33:55 +0000 (11:33 -0400)]
LP#1788417: boolean fields should say 'Yes'/'No' instead of true/false

boolean fields on egGrid use tt2-translated strings for "Yes" and "No"
instead of letting the browser translate the values 'true' and 'false'
(in accordance with the prophecy of XUL)

Signed-off-by: a. bellenir <ab@grpl.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
7 years agoLP#1774448 Auth poll spam/timing repairs
Bill Erickson [Thu, 31 May 2018 19:12:55 +0000 (15:12 -0400)]
LP#1774448 Auth poll spam/timing repairs

Avoid spamming the server with authentication session checks on bad poll
time values.  Specifically, never poll more often than once per minute
and avoid integer overflow on long authentication timeout values
(greater than about 24.8 days) resulting in the poll running with an
effective timeout of zero and spamming the server with API calls.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
7 years agoLP#1724029 Patron search API returns correct order
Bill Erickson [Fri, 10 Aug 2018 16:16:57 +0000 (12:16 -0400)]
LP#1724029 Patron search API returns correct order

Avoid use of max_chunk_size in patron search API as it results in
streaming responses in the wrong order.  Use max_bundle_count instead,
which does not suffer from the sorting issues.  What's more, its purpose
and affect is easier to grasp in the code.

Bundle count is set to 5 so the API will begin returning results at most
5 patrons into the data fleshing process.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
7 years agoLP#1743801: Item Status List Display Issues
a. bellenir [Mon, 4 Jun 2018 18:25:00 +0000 (14:25 -0400)]
LP#1743801: Item Status List Display Issues

Update fm_IDL.xml, establishing circ_as_type as a link to
config::item_type_map.  Flesh this field to display desired value on
client side.

Conflicts:
    Open-ILS/web/js/ui/default/staff/circ/services/item.js

Signed-off-by: a. bellenir <ab@grpl.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
7 years agoLP#1743801: Item Status List View Display Issues
a. bellenir [Thu, 24 May 2018 15:44:28 +0000 (11:44 -0400)]
LP#1743801: Item Status List View Display Issues

Age Protection was missing '.name' field.

Loan Duration and Fine Levels are numeric: 1, 2, or 3.
Added an Angular filter to show the desired string from numeric index.

Conflicts:
    Open-ILS/src/templates/staff/cat/item/t_list.tt2

Signed-off-by: a. bellenir <ab@grpl.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
7 years agoDocs: Adding release notes for 3.1.5
Jane Sandberg [Tue, 21 Aug 2018 17:12:45 +0000 (10:12 -0700)]
Docs: Adding release notes for 3.1.5

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 years agoDocs: Adding release notes for 3.0.11
Jane Sandberg [Tue, 21 Aug 2018 17:10:32 +0000 (10:10 -0700)]
Docs: Adding release notes for 3.0.11

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 years agoDocs: removing outdated info about alerts
Jane Sandberg [Mon, 20 Aug 2018 23:47:23 +0000 (16:47 -0700)]
Docs: removing outdated info about alerts

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 years agoDocs: small changes to record bucket docs
Jane Sandberg [Fri, 17 Aug 2018 19:25:55 +0000 (12:25 -0700)]
Docs: small changes to record bucket docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 years agoLP#1775216: Stamping upgrade script for inconsistent copy counts
Kathy Lussier [Wed, 15 Aug 2018 22:10:08 +0000 (18:10 -0400)]
LP#1775216: Stamping upgrade script for inconsistent copy counts

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1587620: inconsistent copy counts between opac and staff client for peer bibs
a. bellenir [Fri, 15 Jun 2018 19:53:10 +0000 (15:53 -0400)]
LP#1587620: inconsistent copy counts between opac and staff client for peer bibs

staff copy counts should include peer bib copies, per LP1587620.

Signed-off-by: a. bellenir <ab@grpl.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1775216: inconsistent copy counts between opac and staff client
a. bellenir [Fri, 8 Jun 2018 15:42:53 +0000 (11:42 -0400)]
LP#1775216: inconsistent copy counts between opac and staff client

opac version of copy counts was including copies under deleted call numbers
more discussion here: http://irc.evergreen-ils.org/evergreen/2018-06-08#i_363334

Signed-off-by: a. bellenir <ab@grpl.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1775216: adding a pgtap test for inconsistent availability counts
a. bellenir [Fri, 8 Jun 2018 14:29:59 +0000 (10:29 -0400)]
LP#1775216: adding a pgtap test for inconsistent availability counts

Signed-off-by: a. bellenir <ab@grpl.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1775216: inconsistent availability counts between staff client and opac
a. bellenir [Tue, 5 Jun 2018 19:56:24 +0000 (15:56 -0400)]
LP#1775216: inconsistent availability counts between staff client and opac

update asset.staff_ou_record_copy_count to get an accurate available count.

borrow asset.opac_ou_record_copy_count's logic for counting available copies
so that statuses with is_available set to 't' in config.copy_status are used
instead of using the hardcoded status id list (0,7,12)

Signed-off-by: a. bellenir <ab@grpl.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1721575 Stamping DB upgrade: batch catalog actions
Bill Erickson [Wed, 15 Aug 2018 18:08:41 +0000 (14:08 -0400)]
LP#1721575 Stamping DB upgrade: batch catalog actions

Also replaced a remaining reference to "cart" with "basket"

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1721575: Changes to some strings
Kathy Lussier [Tue, 14 Aug 2018 20:28:35 +0000 (16:28 -0400)]
LP#1721575: Changes to some strings

We missed one instance of cart when changing everything over to baskets. Also,
I updated language for clearing a basket after placing a hold to make it a
little clearer.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1721575: Batch Actions In the Public Catalog
Galen Charlton [Mon, 14 May 2018 19:24:59 +0000 (15:24 -0400)]
LP#1721575: Batch Actions In the Public Catalog

The public catalog now displays checkboxes on the bibliographic and
metarecord constituents results pages. Selecting one or more titles
by using the checkboxes will dynamically add those title to the
temporary list, which is now renamed the basket.

Above the results lists there is now a bar with a select-all checkbox,
a link to the basket management page that also indicates the number of
of titles in the basket, and a link to remove from the basket titles that
are selected on the currently displayed results page.

The search bar now includes an icon of a basket and displays the number
of titles currently in the basket. Next to that icon is a menu of basket
actions.

The basket actions available are Place Hold, Print Title Details,
Email Title Details, Add Cart to Saved List, and Clear Cart. In the
web staff client, the basket actions also include Add Cart to Bucket.
When an action is selected from this menu, the user is given an
opportunity to confirm the action and to optionally empty the basket
when the action is complete. The action is applied to all titles
in the basket.

Clicking on the basket icon brings the user to a page listing the
titles in the basket. From there, the user can select specific records
to request, print, email, add to a list, or remove from the basket.

The list of actions on the record details page now provides separate
links for adding the title to a basket or to a permanent list.

The permanent list management page in the public catalog now also
includes batch print and email actions.

Additional information
++++++++++++++++++++++
* The checkboxes do not display on the metarecord results page, as
  metarecords currently cannot be put into baskets or lists.
* The checkboxes are displayed only if Javascript is enabled. However,
  users can still add items to the basket and perform batch actions on
  the basket and on lists.
* A template `config.tt2` setting, `ctx.max_basket_size`, can be used to
  set a soft limit on the number of titles that can be added to the
  basket. If this limit is reached, checkboxes to add more records to the
  basket are disabled unless existing titles in the basket are removed
  first. The default value for this setting is 500.

Developer notes
+++++++++++++++

This patch adds the the public catalog two routes that return JSON
rather than HTML:

* `GET /eg/opac/api/mylist/add?record=45`
* `GET /eg/opac/api/mylist/delete?record=45`

The JSON response is a hash containing a mylist key pointing to the list
of bib IDs of contents of the basket.

The record parameter can be repeated to allow adding or removing
records as an atomic operation. Note that this change also now available
to `/eg/opac/mylist/{add,delete}`

More generally, this adds a way for EGWeb context loaders to specify that
a response should be emitted as JSON rather than rendering an HTML
page using `Template::Toolkit`.

Specifically, if the context as munged by the context loader contains
a `json_response` key, the contents of that key will to provide a
JSON reponse. The `json_response_cookie` key, if present, can be used
to set a cookie as part of the response.

Template Toolkit processing is bypassed entirely when emitting a JSON
response, so the context loader would be entirely reponsible for
localization of strings in the response meant for direct human
consumption.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1770981 Apply OpenSRF locale on webstaff page load
Bill Erickson [Tue, 14 Aug 2018 19:22:49 +0000 (15:22 -0400)]
LP#1770981 Apply OpenSRF locale on webstaff page load

Translate the locale from the locale cookie into the global
OpenSRF.locale variable so network calls are stamped with the correct
locale.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
7 years agoTranslation updates - newpot
Ben Shum [Wed, 15 Aug 2018 15:31:01 +0000 (11:31 -0400)]
Translation updates - newpot

Signed-off-by: Ben Shum <ben@evergreener.net>
7 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into collab/berick/lp1775466...
Bill Erickson [Tue, 14 Aug 2018 20:06:21 +0000 (16:06 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into collab/berick/lp1775466-ang6-base-app

7 years agoLP#1775466 Add missing i18n tags for staff splash page
Bill Erickson [Tue, 14 Aug 2018 20:06:11 +0000 (16:06 -0400)]
LP#1775466 Add missing i18n tags for staff splash page

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP1164061: Edit authority record by database ID
Jane Sandberg [Thu, 5 Jul 2018 21:33:24 +0000 (14:33 -0700)]
LP1164061: Edit authority record by database ID

Allow users to jump directly to the authority record MARC edit interface
by entering the authority record ID.

Includes release notes.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1775466 XLIFF->PO->XLIFF merge tool
Bill Erickson [Tue, 14 Aug 2018 16:51:25 +0000 (12:51 -0400)]
LP#1775466 XLIFF->PO->XLIFF merge tool

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1775466 XLIFF->PO->XLIFF crosswalk repair tool
Bill Erickson [Mon, 13 Aug 2018 21:45:20 +0000 (17:45 -0400)]
LP#1775466 XLIFF->PO->XLIFF crosswalk repair tool

Script to repair message-id chaos caused by crosswalking between PO and
XLIFF files for translations.  Script duplicates the message context value
into the id attribute on the translation unit, to match Angular's
expectations.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1718032 Patron merge honors group perms; no self-merge
Bill Erickson [Tue, 7 Aug 2018 18:27:47 +0000 (14:27 -0400)]
LP#1718032 Patron merge honors group perms; no self-merge

Ensure the staff performing a patron merge have sufficient permission to
edit all users involved in the merge process, in addition the
MERGE_USERS permssion.

Prevent staff from merging their own logged in account.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
7 years agoLP#1775466 Admin page grid content translator
Bill Erickson [Mon, 13 Aug 2018 17:12:01 +0000 (13:12 -0400)]
LP#1775466 Admin page grid content translator

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1775466 Translation widget; apply OpenSRF.locale
Bill Erickson [Mon, 13 Aug 2018 15:08:14 +0000 (11:08 -0400)]
LP#1775466 Translation widget; apply OpenSRF.locale

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1752891 Crowded text on Print Item Labels page fix.
Garry Collum [Sun, 10 Jun 2018 04:08:53 +0000 (00:08 -0400)]
LP#1752891 Crowded text on Print Item Labels page fix.

This patch replaces an h4 style used for labels for dropdown lists, removes a blue background, and changes the style of the title of the page. All to make this page look more consistent with other pages in Evergreen.  Also removes some unnecessary extra divs and makes the bootstrap columns for the top form more consistent.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/templates/staff/cat/printlabels/t_view.tt2

7 years agoDocs: sample patron import script now also updates existing patron data
Jane Sandberg [Fri, 10 Aug 2018 17:34:28 +0000 (10:34 -0700)]
Docs: sample patron import script now also updates existing patron data

With inspiration and help from Martha Driscoll

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 years agoLP#1775719 Modify array check for Phantomjs; reduce logging;
Bill Erickson [Thu, 9 Aug 2018 14:20:54 +0000 (10:20 -0400)]
LP#1775719 Modify array check for Phantomjs; reduce logging;

PhantomJS doesn't support the handy [1,2,3].includes(1) function, so
replace it with the tried-and-true indexOf();

Avoid logging errors on failure to connect to the shared offline worker
when running within phantomjs.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1747512 Non-cat checkout fix display/print
Bill Erickson [Tue, 7 Aug 2018 19:00:12 +0000 (15:00 -0400)]
LP#1747512 Non-cat checkout fix display/print

Fixes an issue which caused an exception to be thrown during non-cat
item checkout in the browser client, preventing the checkout from being
properly displayed in the checkout page, the Items Out list, and on the
receipt.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
7 years agoLP#1702978: memcache Remove method used in a variadic way
Mike Rylander [Fri, 7 Jul 2017 19:34:57 +0000 (15:34 -0400)]
LP#1702978: memcache Remove method used in a variadic way

Related to the OpenSRF branch on this same bug, the prevents Evergreen from
using a to-be-non-variadic memcache method in that way.  This prevents issues
for memcache keys that contain a %.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
7 years agoLP#1775466 Point more ACQ admin pages to legacy versions
Bill Erickson [Thu, 9 Aug 2018 20:56:15 +0000 (16:56 -0400)]
LP#1775466 Point more ACQ admin pages to legacy versions

Found a few more UIs where the admin page is not a simple CRUD grid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1775466 Hide nav link to experimental angular catalog
Bill Erickson [Thu, 9 Aug 2018 20:30:22 +0000 (16:30 -0400)]
LP#1775466 Hide nav link to experimental angular catalog

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1775466 WS admin page workstations sanity check
Bill Erickson [Thu, 9 Aug 2018 18:22:11 +0000 (14:22 -0400)]
LP#1775466 WS admin page workstations sanity check

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1785305: Item Status 'Edited By' shows id instead of username.
a. bellenir [Wed, 8 Aug 2018 15:49:57 +0000 (11:49 -0400)]
LP#1785305: Item Status 'Edited By' shows id instead of username.

This commit changes Item Status 'Edited By' field to show the editor's
username to match XUL.

Signed-off-by: a. bellenir <ab@grpl.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
7 years agoLP#621459 Clear Z39 overlay target message after overlay
Bill Erickson [Tue, 7 Aug 2018 21:41:23 +0000 (17:41 -0400)]
LP#621459 Clear Z39 overlay target message after overlay

Reset the "Record with TCN XXX marked for overlay." message to show "No
record marked for overlay." once the overlay target is cleared after a
Z39 overlay.

Removed an errant '"' in the overlay message.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#621459: Discard overlay target after merge in Z39.50 interface
Mike Rylander [Fri, 3 Aug 2018 15:00:25 +0000 (11:00 -0400)]
LP#621459: Discard overlay target after merge in Z39.50 interface

Cataloger concensus is that we should discard the overlay target after a merge
is completed in order to help avoid accidental re-overlay.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1739460: Be more careful when gathering shelving locations
Mike Rylander [Wed, 10 Jan 2018 16:55:08 +0000 (11:55 -0500)]
LP#1739460: Be more careful when gathering shelving locations

Specifically, make sure we're getting the IDs, and comparing them as numbers.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP 1780660: Add more workstation functions to OpenILS::Utils::TestUtils.
Jason Stephenson [Sun, 8 Jul 2018 18:19:10 +0000 (14:19 -0400)]
LP 1780660: Add more workstation functions to OpenILS::Utils::TestUtils.

Add methods find_or_register_workstation($name, $lib) and
find_workstation($name, $lib) to OpenILS::Utils::TestUtils.  These can
be used when writing tests or other scripts to find or create
workstations.

The following Perl live tests were updated to use the new methods
rather than their hand-rolled versions:

* 14-lp1499123_csp_ignore_proximity.t
* 18-lp1592891_sip_standing_penalties.t
* 19-lp1306666-abort-transit-copy-status.t
* 25-lp1694058-multiple-hold-placement.t

Testing this is very simple:

1. Install Evergreen from this branch.
2. Load the Concerto dataset.
3. Start Evergreen services with osrf_control.
4. cd to the perlmods source directory.
5. Do 'make livecheck' and see that all tests pass, particularly the 4
   mentioned above.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1775466 Apache/doc Perm check repairs for admin pages / grids
Bill Erickson [Wed, 8 Aug 2018 18:41:15 +0000 (14:41 -0400)]
LP#1775466 Apache/doc Perm check repairs for admin pages / grids

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1775466 Apache/doc updates for locale changes
Bill Erickson [Wed, 8 Aug 2018 16:00:09 +0000 (12:00 -0400)]
LP#1775466 Apache/doc updates for locale changes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1785333: Right-click can clear grid selection
a. bellenir [Tue, 7 Aug 2018 22:18:41 +0000 (18:18 -0400)]
LP#1785333: Right-click can clear grid selection

This commit uses egGrid's indexValue API to identify the clicked row rather
than depending on grid row order when checking whether the that row is
currently selected.  This is a generalized fix for all grids.

Signed-off-by: a. bellenir <ab@grpl.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1768947 Disable offline download button, improve logging
Bill Erickson [Tue, 7 Aug 2018 16:10:17 +0000 (12:10 -0400)]
LP#1768947 Disable offline download button, improve logging

Once the offline block list download button is clicked, it's disabled to
prevent any possibility of double-clicks.  The shared worker also
reports a more meaningful error in case a double-click sneaks past.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1768947 Offline xact presence is cached; show date
Bill Erickson [Fri, 22 Jun 2018 14:56:02 +0000 (10:56 -0400)]
LP#1768947 Offline xact presence is cached; show date

Maintain an entry to the object date cache table indicating the time of
the most recent offline transaction entry.  This data is used on the
login page to determine if offline transactions exist, so the staff
logging in can be notified.  We do this in lieu of checking the offline
transaction table, since that table only exists in the offline UI.

As a bonus, since we know the last transaction add time, display this
information in the login page offline xact alert panel.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1768947 Offline DB runs in shared web worker
Bill Erickson [Fri, 8 Jun 2018 17:08:18 +0000 (13:08 -0400)]
LP#1768947 Offline DB runs in shared web worker

Move the lovefield database access logic into a shared web worker
script.  This ensures the only one connection (per schema) can exist,
avoiding data integrity problems caused by having multiple tabs writing
to the database at the same time.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1775466 Admin grid persist key options
Bill Erickson [Mon, 6 Aug 2018 14:33:40 +0000 (10:33 -0400)]
LP#1775466 Admin grid persist key options

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1775466 Local tweaks
Bill Erickson [Mon, 6 Aug 2018 14:04:19 +0000 (10:04 -0400)]
LP#1775466 Local tweaks

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1775466 Server settings continued, needs a bit more testing
Bill Erickson [Fri, 3 Aug 2018 22:41:16 +0000 (18:41 -0400)]
LP#1775466 Server settings continued, needs a bit more testing

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into collab/berick/lp1775466...
Bill Erickson [Fri, 3 Aug 2018 17:38:51 +0000 (13:38 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into collab/berick/lp1775466-ang6-base-app

7 years agoLP#1775466 Support server-stored settings
Bill Erickson [Fri, 3 Aug 2018 17:38:46 +0000 (13:38 -0400)]
LP#1775466 Support server-stored settings

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1750894: Stamping upgrade script for workstation settings on server
Kathy Lussier [Fri, 3 Aug 2018 17:29:14 +0000 (13:29 -0400)]
LP#1750894: Stamping upgrade script for workstation settings on server

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1750894 Remove errant phantomjs-killing comma
Bill Erickson [Fri, 3 Aug 2018 15:39:15 +0000 (11:39 -0400)]
LP#1750894 Remove errant phantomjs-killing comma

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1750894 Additional workstation setting types + repairs
Bill Erickson [Tue, 31 Jul 2018 20:52:18 +0000 (16:52 -0400)]
LP#1750894 Additional workstation setting types + repairs

Added new workstation setting types:

circ.checkout.strict_barcode
cat.holdings_show_empty_org
cat.copy.defaults
cat.printlabels.default_template
cat.printlabels.templates

Bump perm ID in seed data, take 2.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1750894 Batch settings lookup handles migration
Bill Erickson [Tue, 31 Jul 2018 20:30:17 +0000 (16:30 -0400)]
LP#1750894 Batch settings lookup handles migration

As with a single getItem() call, the batch version of the call, when
making server requests, will migrate any settings necessary from
localStorage to server settings.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1750894 Hatch set local storage item thinko
Bill Erickson [Fri, 27 Jul 2018 21:52:24 +0000 (17:52 -0400)]
LP#1750894 Hatch set local storage item thinko

Ensure hatch.setItem() returns a promise for both server- and browser-
stored values.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1750894 Bump perm ID; apply consistently
Bill Erickson [Fri, 27 Jul 2018 21:26:08 +0000 (17:26 -0400)]
LP#1750894 Bump perm ID; apply consistently

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1750894 Store grid limits in grid config
Bill Erickson [Mon, 4 Jun 2018 21:14:24 +0000 (17:14 -0400)]
LP#1750894 Store grid limits in grid config

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1750894 Server-stored workstaion prefs admin view
Bill Erickson [Mon, 4 Jun 2018 16:10:20 +0000 (12:10 -0400)]
LP#1750894 Server-stored workstaion prefs admin view

Adds a new "Server Workstation Prefs" tab to the stored preferences
workstation admin interface.  From here, users can view which
preferences are stored as server-stored workstation preferences and
delete select values.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1750894 Workstation/Cascade setting pgtap tests
Bill Erickson [Wed, 30 May 2018 20:38:56 +0000 (16:38 -0400)]
LP#1750894 Workstation/Cascade setting pgtap tests

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1750894 Workstation/Cascade settings Release Notes
Bill Erickson [Tue, 29 May 2018 15:47:16 +0000 (11:47 -0400)]
LP#1750894 Workstation/Cascade settings Release Notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1750894 Workstation & Cascade settings
Bill Erickson [Tue, 13 Mar 2018 18:06:23 +0000 (14:06 -0400)]
LP#1750894 Workstation & Cascade settings

Adds a new config.workstation_setting_type table for managing
workstation-specific settings.

Adds new PG and perl API functionality for determining values for
settings which may be represnted as workstation, user, and/or org unit
settings.

Teaches the AngularJS browser client to load and apply most settings at
the server.  Values for settings stored in localStorage/Hatch are migrated
to server settings at time of next use.

Stock workstation setting types added to accommodate most browser client
settings.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>