include angular map files to avoid 404's

Signed-off-by: Bill Erickson <berick@esilibrary.com>

only set is_browser_staff when no xul header present

Signed-off-by: Bill Erickson <berick@esilibrary.com>

removing inline log / report files before merge

Signed-off-by: Bill Erickson <berick@esilibrary.com>

remove an old bit of debug code in patron reg.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

make_release -c for building browser client

Adds support for fetching JS dependencies, minification, and building of
the experimental browser client via new -c option.  Browser client
building is disabled by default.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

repair precat checkouts; unit test repair

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into web-staff-proto

wrap up group member details

Signed-off-by: Bill Erickson <berick@esilibrary.com>

scan missing pieces

Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP#1099979 Provide facility to merge parts in the Monograph Parts display

A new facility is provided to make it relatively simple to merge parts that should be named the same, but are
not.  The user will check-off the parts that need to be merged, and click on the new Merge Selected Parts
control, at which point the "winner" will be selected from a pop-up.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

user permission editor from patron view

Signed-off-by: Bill Erickson <berick@esilibrary.com>

user perm editor; resurrected from xhtml editor

Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP#1339118: Ignore permission checks for "jump" context

We don't worry about checking permissions on foreign objects when we're
simply using them to get a context OU for the local object permission
testing.  The "jump" field just gives us more layers of indirection, and
shouldn't cause a perm check, just like normal foreign context OUs.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1334693 make_release optional -j <osrf_js_path>

make_release supports a "-j" option for passing in the OpenSRF JS path:

make_release [options] -j /openils/lib/javascript

This is useful when running make_release, specifically the staff client
building portion, on a machine where the OpenSRF libs are available
(say, from a git checkout) but osrf_config is not available because
OpenSRF is not actually installed.

The script will attempt to find osrf_config and the JS path
automatically, so under normal circumstances, -j is not required.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

patron / item triggered events

Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP#827442 Z39.50 will split the total cap between locations when multiple locations selected

This code does a bit of oversampling, and buffers the results so that a
full batch of results are returned.

In addition, the values in the hover text under "Displaying xxx of yyy records"
has been repaired, as it was easily confused.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

minor cleanup

Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP#1341703 Thinko in Batch Edit (hidden by older OpenSRFs)

There's a bug on line 272 of O::A::Cat.pm where we called a non-existent
method named respond_complete on the invocant object. Instead, we need to
call that on the client object (spelled $conn in this method). Batch bib
edit won't work on new OpenSRF's until this is fixed.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

move eframe to external; copy detail link for catalog

Signed-off-by: Bill Erickson <berick@esilibrary.com>

initial patron hold placement via catalog

Signed-off-by: Bill Erickson <berick@esilibrary.com>

update record links; initial holds placement

Signed-off-by: Bill Erickson <berick@esilibrary.com>

catalog; view holds cont.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

catalog record / html view

Signed-off-by: Bill Erickson <berick@esilibrary.com>

initial tpac integration via eg-embed-frame

Signed-off-by: Bill Erickson <berick@esilibrary.com>

EGCatLoader sets is_staff / is_browser_staff

When embedded in the browser client, set is_staff and an additional
is_browser_staff flag, which is used to apply different handling in some
cases than the XUL wrapper.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

patron edit; plug in editor xulG handlers

Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP#1341013: Load apache mod CGI

As of Apache 2.4, mod CGI needs to be enabled directly and is not built
with apache.  So let's add it to the Makefile for Ubuntu Trusty 14.04.

Also, add handling for disabling unwanted apache conf like serve-cgi-bin,
which can break offline cgi-bin script alias.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1341013: Remove NameVirtualHost from eg.conf.in for Apache 2.4.

NameVirtualHost does nothing in Apache 2.4 and will be removed in
the next release.  We might as well get rid of it now and silence
a warning when starting Apache.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

patron search supports url params; patron edit now has spawn_search plugin

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Forward-port 2.6.2 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward-port 2.5.6 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Fix 950.data.seed-values.sql.

Code from the lost and paid copy status was missing an argument
on the insert.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

move pending patrons to /circ/patron/pending; wire up load action

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into web-staff-proto

Release notes entry for lost and paid status

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1198475: Wrapping upgrade script for lost and paid copy status.

Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1198475: Add a new, optional, Lost and Paid copy status.

Add the Lost and Paid status to config.copy_status.

Add org_unit_settig to control if the copy status is used.

Add checks to O::A::Circ::Money::make_payments to check for LOST
status and org_unit setting and change the copy status to
Lost and Paid as appropriate.

Also add checks for Lost and Paid copy status wherever LOST copy
status is used.

Add the COPY_STATUS_LOST_AND_PAID event.

Add the event to ils_events.xml with id 7026.

Check for the event in circ/util.js in the staff client.

Add pgTAP tests for the existence of the Lost and Paid copy status
and the new org_unit setting to control if it isused.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>

initial patron reg / clone / edit integration (experimental)

Signed-off-by: Bill Erickson <berick@esilibrary.com>

pending patrons, initial

Signed-off-by: Bill Erickson <berick@esilibrary.com>

hold pull list printing

Signed-off-by: Bill Erickson <berick@esilibrary.com>

remove Apache auth wrapper for alt hold pull list

The application proper performs an authentication check before rendering
the list.  Adding an extra Apache auth layer over it is unnecessary and
complicates the handoff from the browser app to the pull list.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP#1234845: Stamping upgrade script for improved evergreen.ranked_volumes()

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1234845: Performance improvement to evergreen.ranked_volumes() database function.

For the client I analyzed logs from production Pg instance for ~ 10
days.

During this time, the single most time consuming query (summarized time
for all instances of the query, with different parameters) was:

SELECT * FROM unapi.bre ( ... ) AS "unapi.bre";

I profiled this function, and found that in my test case most of the
time (2.04s out of 2.06s, so ~ 99%) was spent in call to
unapi.holdings_xml() function.

When I profiled this function, I found that most of the time (sorry,
don't have the number now with me) was spent in call to
evergreen.ranked_volumes() function.

At this moment in my research something changed on the server I was
testing on, and all subsequent times were ~ 4-5 times lower, but the
ratios were more or less the same.

Anyway - call to evergreen.ranked_volumes() showed repeatable time (with
full caches/buffers) of ~ 380ms.

I modified the function by:
1. inlining actor.org_unit_descendants(?, ?)
2. inlining evergreen.rank_ou(?, ?, ?)
3. extracting depth calculation to separate call
4. switched to plpgsql (which gives me ability to use variables)
5. removed evergreen.rank_ou() and evergreen.rank_cp_status() from
   select clause - these are still in WINDOW definition, but they
   weren't used in the SELECT, so it's better to remove from there.
6. in passing renamed arguments to avoid name clash (argument depth vs.
   field depth)
7. in passing changed usage of $* to access parameters to using named
   parameters, for readability.

New function did the same work in ~ 18ms.

EDIT: Convert to SQL, keeping all of the improvements from depesz
EDIT2: Added Signed-off-by line for depesz, see http://markmail.org/message/rv4vaarwixeswqgu

Signed-off-by: Hubert depesz Lubaczewski <depesz@depesz.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Force the installation of Business::Stripe on Ubuntu Trusty.

Apparently the required force was missed in the Makefile.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1254918 limit ACQ batch update fund retrieval by perms

In the ACQ batch update bar along the top of the PO page, limit the
number of funds which require permission checks on the server by
limiting the fund search to those at org units where the requesting user
has the CREATE_PURCHSE_ORDER or MANAGE_FUND permissions.

In other words, if a user only has create-po perms at Branch 1, we can
specifically request funds at that branch (or below) for display so that
the server (PCRUD) does not have to inspect unrelated funds for
permissibility.  This speeds up fund retrieval.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1254918: Allow skiping of user-object perms

Previous to this commit, permissions in Evergreen check a cominbation
of:
 * user-object permissions (does the user have a direct permission
   mapping to the object in question)
 * user-context permissions (does the user have the permission at the
   object's context location, whose field is defined in the IDL)
 * user-global permission (lacking a context location, does the user
   have the permission globally (at the top of the org tree) and therefore
   can apply the action to all objects of this typ)

In practice, there are almost no user-object permissions.  When retrieving
just on object from the database, the cost of this check is negligable to
the point that we can completely ignore it.  However, when retrieving a
large set of objects, such as the list of all funds in a large, consortial
environment, the cost to check the user-object permission adds up to a
noticable amount of time.

To address this, we add a new construct to the IDL instructing the PCRUD
infrastructure to skip user-object permission checking in those cases where
the design and use of the system makes user-specific object permissions
needless or superfluous.  This is embodied in a new XML attribute on the
<pcrud> element: ignore_object_perms.  When set to "true", pcrud will skip
all user-object permission checks, resulting in faster time-to-first-result.

Additionally, we add a new "owning_user" attribute on the <action> element
of the <pcrud> section. This new attribute specifies the field containing
the actor.usr.id of the user that "owns" the object.  This allows PCRUD to
test ownership of an object directly, and if the requesting user and owning
user are the same, the action is allowed.

Finaly, when "global_required" is "true" for the permission check, and there
is no "owning_user" attribute defined for the class in the IDL, we skip the
above-mentioned user-object permission check.  When "global_required" is
"false" or there is an "owning_user" attribute, we check for user permissions.

In all cases, the "ignore_object_perms" attribute is honored, and in its
presence we skip non-owner user-object permissions.

The net result is an immediate increase in speed for retrieval of objects
in the presence of the "global_required" attribute, and a mechanism to
increase the speed of specific cases of context-aware retrival by the use
of "ignore_object_perms".

We use this new mechanism to speed the retrieval of fund objects in the
ACQ interfaces that draw available-fund dropdowns.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1334693 ./configure avoid osrf_config without core

Avoid the check for and use of osrf_config during Evergreen ./configure
when run with --disable-core.  This allows the staff client to be built
and, in general, for make_release to be run on a machine that does not
have opensrf installed (or has multiple versions).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP# 1337550 remove schema.org itemOffered, add price property

We use the "offers" property to link the Product to the Offer, so there
is no reason to use a reciprocal "itemOffered" property to link back to
the Product from the Offer. The circular reference confuses some tools
(http://rdfa.info/play) and may complicate general processing, so let's
simply remove it.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP# 1337550 Remove AggregateOffer schema.org instance

As our record details page lists each copy as a separate Offer (well, in
many cases anyway, unless paging gets invoked), the AggregateOffer
entity is not really necessary--and using it on the same page as
separate Offer entities is not recommended by at least one search engine
(per Google https://support.google.com/webmasters/answer/146750?hl=en
says a given page should include "_one_ of the following: Offer or
Offer-aggregate").

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP# 1330784: Release notes for sitemap builder

More like documentation than release notes, but more is probably better
than less.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1330784 Add a sitemap generator for Evergreen

Following the requirements at sitemaps.org, generate a
set of sitemaps that reflect the bib record's last edit
date, with 50,000 records per sitemap file.

Users can run this script targeting different libraries
and generating different output filenames using the
documented options in the script.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1308239 support holds fulfillment on precat copies

During checkout, allow holds on precat copies to get fulfilled.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1308239 Support pre-cat copy hold targeting

Remove an unused line of code in the hold targeter which was preventing
targeting of pre-cat copies.

In OpenILS::Utils::PermitHold::permit_copy_hold, neither in-db nor
script based hold viability checks inspect the value of the
"title_descriptor" field in the provided params.  Remove this field and
pre-cats just work.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Release notes entry for holds shelf expire change

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1306753: Only look at holds that expire before 'today'

We should not count today when generating the hold expiration list.
So, we'll look for holds that expire before 'today' instead of those
that expire before 'now'.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1316814: Change potentially incorrect information display in hold_status.tt2

Removed word "circulating" from patron hold status message regarding the number of copies of the material.
Some copies may be ON ORDER and therefore not circulating.

Signed-off-by: Victoria Lewis <vcamklewis@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Documentation: added release notes for LP#1327284 Display "Imported As" column

LP#1327284 Display "Imported As" in Vandelay queue

Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1327284 Display Imported As column in vandelay queue

For Bib and Authority records which have been imported / merged /
overlayed, etc. into the system via Vandelay, show the record ID of the
catalog bib/auth record to which the record was imported.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1210161: Stamping upgrade script to rename bookbag to list

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1210161: Upgrade script to rename bookbag to list

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1210161: Finish renaming bookbag to list

The JSPAC bookbag feature was renamed to "Lists" in TPAC, but several
references still exist to "bookbag", "book bag", "Book Bag", etc. in the
public and staff interfaces. This commit attempts to provide simple and
clear replacements for the old term. In some cases "list" seems best,
but where the context is uncertain "book list" is used to err on the
side of clarity. Some of these changes may be in old code that is no
longer used.

This commit also includes two minor wording changes - one to fix grammar,
and the second to update instructions for sharing a list.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1315531 Remove remaining references to Lucid from README and Makefile

There were still a few references to Ubuntu Lucid in README and makefile
comments area.  Also, the Makefile itself for Lucid was still there.

Remove these last traces forever!

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1315531 Fix README asciidoc syntax

Noticed when generating the asciidoc output to HTML there was an error in the
README file. This adds the proper syntax around the text blocks.

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1315531 Quick clarification about which Ubuntu we mean.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1315531 Correcting typo: "eg_host.conf" -> "eg_vhost.conf".

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1315531 Adding further changes to the server install docs for Ubuntu 14.04:

- adding apache configuration instructions that adjust for the new
mpm_prefork module in Apache 2.4 on 14.04
- adding new standalone database dependency installation instructions
that rely on OS packages rather than CPAN where possible

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1315531 Ben Shum pointed out an error, which I have now corrected.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1315531 Change default location of libdbi libraries.

In libdbi 0.8.4, the default installed location has changed to
/usr/lib/x86_64-linux-gnu/dbd/.  On the advice of Thomas Berezansky,
I made the new location the default and ensured that the previous
locations are in the fallback.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1315531 Missed libtest-output-perl in the deb list.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1315531 Adding Business::Stripe; Moving CPAN stuff to debs where I can

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1315531 Continuing to add trusty support and remove lucid.

Adding PostgreSQL 9.3 as the default database for 14.04.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1315531 adding trusty Makefile.install, removing lucid support

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Documentation: Upgrade instructions examples

This commit adds a note (with examples) about upgrading the database schema
across major versions. It also reformats a long line into multiple lines,
changes a NOTE to a TIP, makes a small correction, and replaces a repetitive
command with a short explanation.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Documentation: Update upgrade instruction for 2.6.1

- Update location references for 2.6.1.
- Update database updates to include 2.6.1 update.
- Add a note regarding reingesting bib records after updates.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

Documentation: updated some SIP content

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Documentation: added AsciiDoc version of old SIP docs from EG 1.6/2.0 docs

Signed-off-by: Yamil Suarez <yamil@yamil.com>

hold pull list API cont. flesh copy loc.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

initial hold pull list;  hold grid action consolidation

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Fleshed, streaming, authoritative hold pull list API

Signed-off-by: Bill Erickson <berick@esilibrary.com>

holds shelf.  detail view

Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP#1339767: follow-up: Thumbs.db, not Thumbs.DB

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1339767: add Thumbs.DB to .gitignore

Removes a minor annoyance for documenters who use recent
versions of Windows

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

holds shelf.  clear shelf

Signed-off-by: Bill Erickson <berick@esilibrary.com>

checkin; fetch transit for route-to as needed

Signed-off-by: Bill Erickson <berick@esilibrary.com>

holds shelf.  actions / clear shelf

Signed-off-by: Bill Erickson <berick@esilibrary.com>

holds shelf

Signed-off-by: Bill Erickson <berick@esilibrary.com>

capture holds

Signed-off-by: Bill Erickson <berick@esilibrary.com>

grid persist only stores necessary data

Signed-off-by: Bill Erickson <berick@esilibrary.com>

patron holds / hold details

Signed-off-by: Bill Erickson <berick@esilibrary.com>

patron holds / add notification

Signed-off-by: Bill Erickson <berick@esilibrary.com>

pcrud service improved error tracking

Signed-off-by: Bill Erickson <berick@esilibrary.com>

patron holds / hold notifications

Signed-off-by: Bill Erickson <berick@esilibrary.com>

pcrud access for hold notifications

Signed-off-by: Bill Erickson <berick@esilibrary.com>

patron holds / add hold note

Signed-off-by: Bill Erickson <berick@esilibrary.com>

patron holds / detail view

Signed-off-by: Bill Erickson <berick@esilibrary.com>

patron holds; printing

Signed-off-by: Bill Erickson <berick@esilibrary.com>

patron holds ; retarget

Signed-off-by: Bill Erickson <berick@esilibrary.com>

patron holds / mark damaged / missing

Signed-off-by: Bill Erickson <berick@esilibrary.com>

patron holds / transfer to marked title, second half

Signed-off-by: Bill Erickson <berick@esilibrary.com>

patron holds / top o' queue

Signed-off-by: Bill Erickson <berick@esilibrary.com>