working/Evergreen.git
3 years agoRename DB Upgrade scripts collab/dyrcona/lp1902937-quipu_renewal_wip
Jason Stephenson [Tue, 29 Nov 2022 20:22:05 +0000 (15:22 -0500)]
Rename DB Upgrade scripts

Rename the Quipu standing penalty and erenew pgt column upgrade
scripts so that the order that they should be run is obvious from the
filenames.

Signed-off-by: Jason Stephenson <jstephenson@cwmars.org>
3 years agoAlter schema upgrade for erenew column
Jason Stephenson [Tue, 29 Nov 2022 20:19:18 +0000 (15:19 -0500)]
Alter schema upgrade for erenew column

Set the column to "NOT NULL DEFAULT FALSE" and remove the extra
updates to set the current columsn to FALSE and add the NOT NULL
constraint.  This new version does it all in 1 ALTER TABLE statement.

Signed-off-by: Jason Stephenson <jstephenson@cwmars.org>
3 years agoOnline Renewal - Progress on updating addresses
Terran McCanna [Wed, 23 Nov 2022 18:56:49 +0000 (13:56 -0500)]
Online Renewal - Progress on updating addresses

(still issues with checkmarks when changing from 1 to 2
addresses or from 2 to 1 address)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - Got surveys working
Terran McCanna [Wed, 23 Nov 2022 16:30:39 +0000 (11:30 -0500)]
Online Renewal - Got surveys working

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - Remove perm group ID references
Terran McCanna [Tue, 22 Nov 2022 22:04:47 +0000 (17:04 -0500)]
Online Renewal - Remove perm group ID references

Look up permission groups by name or by e-renewal eligibility flag
instead of by specific permission group ID.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - add temp renewal flag to quipu response
Terran McCanna [Tue, 22 Nov 2022 19:38:29 +0000 (14:38 -0500)]
Online Renewal - add temp renewal flag to quipu response

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - Use standing penalty names instead of IDs
Terran McCanna [Tue, 22 Nov 2022 19:10:30 +0000 (14:10 -0500)]
Online Renewal - Use standing penalty names instead of IDs

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - Add Standing Penalty when Temp Renewal
Terran McCanna [Tue, 22 Nov 2022 18:49:38 +0000 (13:49 -0500)]
Online Renewal - Add Standing Penalty when Temp Renewal

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - Tweak new standing penalty
Terran McCanna [Mon, 21 Nov 2022 19:26:18 +0000 (14:26 -0500)]
Online Renewal - Tweak new standing penalty

The ID of the standing penalty has to be under 100 to prevent
staff from manually adding it to patron accounts through the
client interface.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - See & update permission group setting through staff client
Terran McCanna [Mon, 21 Nov 2022 17:26:01 +0000 (12:26 -0500)]
Online Renewal - See & update permission group setting through staff client

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - tweak SQL
Terran McCanna [Fri, 11 Nov 2022 16:37:25 +0000 (11:37 -0500)]
Online Renewal - tweak SQL

- Parentheses on first SQL generated error.
- Set erenew default to FALSE instead of TRUE.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoadd column to permission.grp_tree to account for e-renew
Chris Sharp [Fri, 11 Nov 2022 14:32:08 +0000 (09:32 -0500)]
add column to permission.grp_tree to account for e-renew

3 years agoOnline Renewal - Now saving and responding okay
Terran McCanna [Tue, 8 Nov 2022 21:21:06 +0000 (16:21 -0500)]
Online Renewal - Now saving and responding okay

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - Document which patron groups are eligible in code
Terran McCanna [Tue, 25 Oct 2022 18:55:26 +0000 (14:55 -0400)]
Online Renewal - Document which patron groups are eligible in code

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - Show Updated Expire Date
Terran McCanna [Tue, 25 Oct 2022 16:56:13 +0000 (12:56 -0400)]
Online Renewal - Show Updated Expire Date

Without this, the page loads the initial patron expiration date
and continues to show the button to renew the account.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - Progress on writing quipu into to db
Terran McCanna [Fri, 21 Oct 2022 20:30:58 +0000 (16:30 -0400)]
Online Renewal - Progress on writing quipu into to db

Still to do:
* Actor.pm - failing on standing penalties line 597
* sub update_addresses - creating separate addresses works if mailing & billing are different,
   but it is not checking the right checkbox
* writing new home ou is failing on terran-test, but should work on pines data
* after update, opac page doesn't refresh
* if this is a temporary (30 day) renewal, need to pass message to quipu telling patron to come to the library
* if temp renewal, need to add alert to patron account to inform staff to get proof of identity to do full renewal
* need to test voter registration survey on pines test server since I don't have that on my test server

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - fix typos
Terran McCanna [Tue, 6 Sep 2022 13:31:33 +0000 (09:31 -0400)]
Online Renewal - fix typos

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - Get URL path in a different way
Terran McCanna [Fri, 2 Sep 2022 21:35:15 +0000 (17:35 -0400)]
Online Renewal - Get URL path in a different way

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - Fix msg declaration error
Terran McCanna [Fri, 2 Sep 2022 19:28:25 +0000 (15:28 -0400)]
Online Renewal - Fix msg declaration error

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - Exceptions for temp renewal
Terran McCanna [Fri, 2 Sep 2022 17:25:00 +0000 (13:25 -0400)]
Online Renewal - Exceptions for temp renewal

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - Retrieve patron then update fields to push back
Terran McCanna [Mon, 29 Aug 2022 20:50:13 +0000 (16:50 -0400)]
Online Renewal - Retrieve patron then update fields to push back

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - Add page routing to EGCatLoader
Terran McCanna [Mon, 29 Aug 2022 19:56:56 +0000 (15:56 -0400)]
Online Renewal - Add page routing to EGCatLoader

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - Remove old subroutines we don't use
Terran McCanna [Mon, 29 Aug 2022 18:49:31 +0000 (14:49 -0400)]
Online Renewal - Remove old subroutines we don't use

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agodeclare the variable once, then update the values
Chris Sharp [Mon, 29 Aug 2022 16:45:16 +0000 (12:45 -0400)]
declare the variable once, then update the values

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agodeclare the variable, and update it if needed
Chris Sharp [Mon, 29 Aug 2022 16:42:54 +0000 (12:42 -0400)]
declare the variable, and update it if needed

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoeven FURTHER typo fix
Chris Sharp [Mon, 29 Aug 2022 16:40:57 +0000 (12:40 -0400)]
even FURTHER typo fix

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoeven further typo fix
Chris Sharp [Mon, 29 Aug 2022 16:38:29 +0000 (12:38 -0400)]
even further typo fix

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agofurther typo fix
Chris Sharp [Mon, 29 Aug 2022 16:37:31 +0000 (12:37 -0400)]
further typo fix

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agotypo fix
Chris Sharp [Mon, 29 Aug 2022 16:34:51 +0000 (12:34 -0400)]
typo fix

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoOnline Renewal - First stab at adding erenew to Ecard.pm
Terran McCanna [Mon, 29 Aug 2022 16:24:12 +0000 (12:24 -0400)]
Online Renewal - First stab at adding erenew to Ecard.pm

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - Create page to hold embedded form
Terran McCanna [Thu, 25 Aug 2022 19:42:53 +0000 (15:42 -0400)]
Online Renewal - Create page to hold embedded form

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - Create new API instead of piggybacking on vital_stats
Terran McCanna [Wed, 24 Aug 2022 16:44:24 +0000 (12:44 -0400)]
Online Renewal - Create new API instead of piggybacking on vital_stats

New api: open-ils.actor.user.opac.renewal

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal: Flesh out patron info in API
Terran McCanna [Mon, 22 Aug 2022 18:33:26 +0000 (14:33 -0400)]
Online Renewal: Flesh out patron info in API

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - Add standing penalty
Terran McCanna [Mon, 11 Oct 2021 20:36:08 +0000 (16:36 -0400)]
Online Renewal - Add standing penalty

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoOnline Renewal - Start of working branch
Terran McCanna [Thu, 5 Aug 2021 22:36:17 +0000 (18:36 -0400)]
Online Renewal - Start of working branch

- Creates placeholders for new English & Spanish pages
- Adds ability for those pages to load
- Create div on My Account main page & prefs page to hold renewal message or button
- Adds code to check whether or not patron is eligible to renew online or not:
* patron has not already had one temporary renewal
* patron account is still active
* patron account expiration date is no more than 30 days in the future
* patron account is not barred
* patron account does not have a staff-added blocking alert
* patron does not owe any fines
* patron is not in collections (even if patron pays fines, staff still need
to remove collections note)
* patron is in one of these perm groups: Patron (2), Friend (14), GLS (56),
Homebound (53), Trustee (22), Quipu (64), Digital Only (60)
* patron has a valid billing address
* patron has a valid day phone

NOTE: New standing penalty needs to be created called PATRON_TEMP_RENEWAL.
It should display a staff alert and have the label "Patron was given a 30-day temporary account renewal. Please archive this message after the account is fully renewed." It should not create any type of block on its own. The ID of
the new standing penalty needs to be updated in the Account.pm file.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
3 years agoLP1902937: Use setting for guardian check
Jason Stephenson [Thu, 18 Nov 2021 13:54:08 +0000 (08:54 -0500)]
LP1902937: Use setting for guardian check

Check the value of the ui.patron.edit.guardian_required_for_juv
setting before requiring the guardian field for juvenile eCard
registrations.  We should add our own setting for this.

Signed-off-by: Jason Stephenson <jason@sigio.com>
3 years agoLp 1902937: Make the Quipu Integration Code More Generic
Jason Stephenson [Fri, 10 Sep 2021 16:56:16 +0000 (12:56 -0400)]
Lp 1902937: Make the Quipu Integration Code More Generic

Rename quipu upgrade script.

Enable ecard form in EGCatLoader.

Add the calculate_luhn_checkdigit function to calculate a barcode
check digit using the Luhn algorithm to OpenILS::Applicaiton::AppUtils
because it could be useful for more than just generating barcodes for
the eCard integration.  We may also need more than one check digit
algorithm in the future.

Replace the KCLS specific registration form with one that is more generic.

Add new settings.

Add the generate_barcode utility function.

Modify Ecard login_vendor to use org unit settings

Change the login field value to FALSE so it can't be used to login.

Add evergreen.upgrade_deps_block_check to upgrade script

Add Ecard registration link to OPAC footer

Make voter registration field optional in Ecard.pm because not
everyone has or requires this survey.  It is PINES-specific.

Do not set actor.usr.name_keywords in Ecard.pm

Make day_phone optional.

Make in_house_registration optional.

Return the user's expiration date, in ISO format (YYYY-MM-DD), as the
"expiration_date" field in a successful response to Quipu.

Signed-off-by: Jason Stephenson <jason@sigio.com>
3 years agoQuipu eCard Integration for PINES
Chris Sharp [Fri, 14 Aug 2020 13:11:30 +0000 (09:11 -0400)]
Quipu eCard Integration for PINES

Altering KCLS's Quipu eCard implementation to align
with PINES's needs, with an eye towards a generic feature
that could be submitted to Evergreen master.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
3 years agoKCLS Quipu integration bits
Bill Erickson [Tue, 7 Jul 2020 14:41:36 +0000 (10:41 -0400)]
KCLS Quipu integration bits

Notes:

1. See constants along the top of Ecard.pm which will need changing.
2. Ecard.pm add_stat_cats() is very kcls-specific
3. The vendor login uses a new password type 'ecard_vendor' which does
   not have the intermediate md5 hashing.
4. Ecard.pm and templates have header/footer stuff that's specific to
   bibliocommons and should be removed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
3 years agoLP#1971745 - speed up open-ils.storage.action.live_holds.wide_hash
Josh Stompro [Tue, 22 Nov 2022 18:09:46 +0000 (12:09 -0600)]
LP#1971745 - speed up open-ils.storage.action.live_holds.wide_hash

Postgresql 10 and EG 3.9.0

The query to grab holds on the hold shelf was taking 35-50 seconds on
a test system to return 466 records.  Explain analyze showed that the
left join on asset.call_number was causing a sequential scan and reading
all asset.call_number rows.

Letting PG know that the two conditions of the join are mutually exclusive
seems to let PG know that an index scan is faster.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Jason Stephenson <jstephenson@cwmars.org>
3 years agoLP#1971745: work around issue that can cause large hold shelf lists to fail
Galen Charlton [Thu, 5 May 2022 16:44:26 +0000 (12:44 -0400)]
LP#1971745: work around issue that can cause large hold shelf lists to fail

This patch addresses an issue where hold shelf lists with
more than ~350 rows can fail to be retrieved. It works by
making the open-ils.circ.hold.wide_hash.stream method fetch
the holds from an open-ils.storage method in one fell swoop,
rather than both streaming the list from open-ils.storage and
streaming it back to the client that invoked the open-ils.circ
method.

I suspect that this is working around a subtle OpenSRF bug when
bidirectional streaming is in play, but I'm not positive.

To test
-------
[1] Set up an environment with hundreds or thousands of holds on
    a shelf at an OU.
[2] Attempt to display the holds shelf list.
[3] It may fail; if it doesn't, try with even larger number of holds
    or by setting up a test system that has ejabberd s2s going on
    to service requests.
[4] Apply the patch and repeat step 2. This time, the holds shelf
    list should be consistently retrieved. There will also be a
    user-visible change: the spinner on the AngularJS holds shelf page
    will pause for a few seconds, then start advancing.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jason Stephenson <jstephenson@cwmars.org>
3 years agoLP1995211: Angular styleext setting is now called style
Jane Sandberg [Sun, 30 Oct 2022 14:25:32 +0000 (07:25 -0700)]
LP1995211: Angular styleext setting is now called style

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1980275 Bootstrap - buttons on two lines in current hold screen
Garry Collum [Fri, 29 Jul 2022 15:26:45 +0000 (15:26 +0000)]
LP1980275 Bootstrap - buttons on two lines in current hold screen

This fixes the button arrangement in the Bootstrap Opac's Current Items on Hold screen.

To test:
1. Place some items on hold for patron.
2. Login as that patron in the Bootstrap opac.
3. View the Current Items on Hold screen and notice the buttons are on two lines.
4. Apply the patch.
5. View the Current Itesms on Holcs screen to see that the buttons are now arranged on a
single line.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP 1944602 Bootstrap Opac: Address alignment
Garry Collum [Tue, 23 Aug 2022 19:47:00 +0000 (19:47 +0000)]
LP 1944602 Bootstrap Opac: Address alignment

Fixes the alignment of patron addresses in the Bootstap opac, if the
patron as more than one address.  Two addresses will now display
side-by-side in a row, except on smaller screens.

To test:

1. To fully test use patrons with one address, two addresses, and more than
two addresses.
2. Login as each patron and notice the mis-aligned addresses.
3. Apply the patch.
4. The addresses should now be displayed side-by-side, two per row. They
collapse to one per row on smaller screens.
5. Enable the 'Allow pending addresses' library setting.  The editable
address displays in the same space as it's non-editable display.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1955403-Bootstrap opac - Google Books preview not rendering.
Garry Collum [Mon, 20 Dec 2021 12:59:27 +0000 (07:59 -0500)]
LP1955403-Bootstrap opac - Google Books preview not rendering.

Fixes the Google Books preview in the Bootstrap Opac.

To test.
1. Set ctx.google_books_preview=1 in config.tt2.
2. View a bibliographic record that would have an ISBN that would link to
a google book preview.  In concerto you can change and ISBN on a record to
and ISBN that you know would pull data (97880271037829781629795645).
3. Notice there is no preview button link, or preview.
4. Apply the patch and refresh.  The google preview button should render.
Clicking on the button will display the preview.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Eva Cerninakova <cerninakova@jabok.cz>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoDocs: Update Supported Browsers, Drop Staff Client
Jason Boyer [Wed, 16 Nov 2022 21:23:52 +0000 (16:23 -0500)]
Docs: Update Supported Browsers, Drop Staff Client

Stated that supported browsers are Chrome, Edge, and Firefox, and removed the
reference to the XUL staff client as it's no longer available and never coming
back.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
3 years agoLP1915440 Clear Hopeless Date on Capture
Bill Erickson [Mon, 8 Aug 2022 18:04:55 +0000 (14:04 -0400)]
LP1915440 Clear Hopeless Date on Capture

Clear the hold hopeless date when a copy is captured for the hold.

One way to make this happen for testing:

. Configure the Missing copy status as holdable=true hopeless_prone=true
. Place hold with only 1 viable copy.
. Mark said copy as missing -- this stamps a hopeless_date on the hold.
. Check the copy in.  This results in a capture + hopeless hold.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Susan Morrison <smorrison@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1991726: add release notes entry
Galen Charlton [Wed, 16 Nov 2022 16:32:57 +0000 (11:32 -0500)]
LP#1991726: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1991726 View Holds: Patron Home Library Column
Dan Briem [Wed, 5 Oct 2022 18:52:40 +0000 (14:52 -0400)]
LP#1991726 View Holds: Patron Home Library Column

Adds a patron home library shortcode column to the
staff catalog view holds grid.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Susan Morrison <smorrison@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1991590: Better order for survey admin fields
Jane Sandberg [Mon, 3 Oct 2022 23:08:38 +0000 (16:08 -0700)]
LP1991590: Better order for survey admin fields

To test:
1. Press Admin > Local Admin
2. Press Surveys
3. Create a new survey.
4. Notice that the Start Date field comes before the End Date field.
5. Repeat steps 1-2.
6. Select a survey and edit selected.
7. Notice that the Start Date again comes before the End Date.

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agowipe the release note slate clean
Galen Charlton [Wed, 16 Nov 2022 00:16:31 +0000 (19:16 -0500)]
wipe the release note slate clean

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoforward-port 3.10.0 database update script
Galen Charlton [Wed, 16 Nov 2022 00:12:45 +0000 (19:12 -0500)]
forward-port 3.10.0 database update script

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoforward-port 3.10 release notes
Galen Charlton [Wed, 16 Nov 2022 00:12:26 +0000 (19:12 -0500)]
forward-port 3.10 release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1969994: Add Release Note
Jason Boyer [Tue, 15 Nov 2022 13:25:38 +0000 (08:25 -0500)]
LP#1969994: Add Release Note

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
3 years agoLP#1969994: Stripe: Add User Database ID
Terran McCanna [Fri, 22 Apr 2022 21:12:47 +0000 (17:12 -0400)]
LP#1969994: Stripe: Add User Database ID

Adds the patron's database ID to the payment intent so that
payments can be more easily reconciled with the Evergreen
database.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
3 years agoLP1995653: small create_release_notes script changes
Jane Sandberg [Fri, 4 Nov 2022 01:46:40 +0000 (18:46 -0700)]
LP1995653: small create_release_notes script changes

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
3 years agoLp 1943634: Fix MARC Stream Importer Temp File Creation
Jason Stephenson [Tue, 14 Sep 2021 19:02:38 +0000 (15:02 -0400)]
Lp 1943634: Fix MARC Stream Importer Temp File Creation

Use fileparse on $0 in marc_stream_importer.pl to get the program's
basename and use that instead of $0 to generate the temp file's name.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
3 years agoLP#1864507: (follow-up) another fix to the schema update
Galen Charlton [Fri, 4 Nov 2022 17:39:15 +0000 (13:39 -0400)]
LP#1864507: (follow-up) another fix to the schema update

Fixing a syntax error to the reingest step this time.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1755876: Add progress bar when renewing items
Jessica Woolford [Thu, 29 Sep 2022 17:27:20 +0000 (13:27 -0400)]
LP1755876: Add progress bar when renewing items

Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Susan Morrison <smorrison@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP#1989133: Bootstrap physical description display error.
Steven Callender [Thu, 8 Sep 2022 16:47:38 +0000 (12:47 -0400)]
LP#1989133: Bootstrap physical description display error.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP1995032 follow-up: syntax correction
Jane Sandberg [Fri, 4 Nov 2022 13:52:26 +0000 (06:52 -0700)]
LP1995032 follow-up: syntax correction

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP1895675 Bootstrap OPAC: Add notification method testing to My Account
Terran McCanna [Fri, 28 Oct 2022 22:19:58 +0000 (18:19 -0400)]
LP1895675 Bootstrap OPAC: Add notification method testing to My Account

This adds the work done in the TPAC for LP1777677 to the Bootstrap OPAC.
A test email button is added to My Account > Preferences, and a test
text message button is added to My Account > Preferences > Notification
Preferences.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Christine Burns <christine.burns@bc.libraries.coop>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP1972928: Show course user role dropdown choices without typing
Jane Sandberg [Tue, 4 Oct 2022 01:22:48 +0000 (18:22 -0700)]
LP1972928: Show course user role dropdown choices without typing

To test:
1. Go to Admin > Local Admin > Course List
2. Choose a course
3. Go to the Course users tab
4. Activate the Role dropdown.
5. Note that no options appear.
6. Apply the patch
7. Repeat steps 1-5
8. Note that the role options appear when you activate the dropdown now

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
3 years agolp1856097 stamp and small fixes to upgrade script
Jane Sandberg [Fri, 4 Nov 2022 03:00:11 +0000 (20:00 -0700)]
lp1856097 stamp and small fixes to upgrade script

Don't apply the upgrade if it would overwrite existing customizations
to the description, also add a missing semicolon.

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agolp1856097 Tide Default Classification Scheme Description
Kyle Huckins [Wed, 11 Dec 2019 23:17:22 +0000 (23:17 +0000)]
lp1856097 Tide Default Classification Scheme Description

- With the updates in lp1839341, the description in the YAOUS for
Default Classification Scheme is incorrect. It prompts for a number:
1, 2, or 3. The Angular Settings Editor now displays a verbose
dropdown. The description has been updated accordingly.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/sql/Pg/950.data.seed-values.sql
new file:   Open-ILS/src/sql/Pg/upgrade/XXXX.data.default_classification-description-update.sql

Signed-off-by: Susan Morrison <smorrison@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP1995032 Add empty alt text to decorative icons
Stephanie Leary [Fri, 28 Oct 2022 14:32:43 +0000 (09:32 -0500)]
LP1995032 Add empty alt text to decorative icons

Adds alt="" to alert dialog icons in patron circulation screens.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP1824709: Allow comboboxes inputs to have IDs
Jane Sandberg [Thu, 17 Sep 2020 21:13:54 +0000 (14:13 -0700)]
LP1824709: Allow comboboxes inputs to have IDs

This adds a new input, domId, for the combobox component.

A good way to test:

1) Download the Wave accessibility checker.
2) Go to one of the following screens:
  - Admin > Local > Course Reserves > Choose a course > Associate
    item from catalog
  - Admin > Local > Course Reserves > Choose a course > Associate
    brief record
  - MARC Batch Import
  - MARC Batch Import/Export > Inspect Queue
  - Staff Catalog Add to bucket
  - Staff catalog conjoined items
  - Hold cancel dialog
3) Right click and select "WAVE this page"
4) On the Details tab of WAVE, notice that there are several "Missing
   form label" errors.
5) Apply this patch.
6) Run WAVE again; notice that the number of missing form label errors
   has decreased.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Garry Collum <gcollum@gmail.com>
3 years agoLP1993859 Keyboard tabbing for results pagination
Stephanie Leary [Fri, 21 Oct 2022 21:15:57 +0000 (16:15 -0500)]
LP1993859 Keyboard tabbing for results pagination

In the staff catalog search results pagination component, adds
tabindex="0" to link tags without href attributes to enable keyboard
navigation.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Christine Burns <christine.burns@bc.libraries.coop>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP1994159 Higher contrast H2s
Stephanie Leary [Tue, 25 Oct 2022 16:29:53 +0000 (11:29 -0500)]
LP1994159 Higher contrast H2s

The Evergreen logo color used for H2s, including the card headers on the
staff splash page, doesn't pass color contrast checks. I've also removed
the underlines, as those should be used only for links.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoAdd another entry for Jason Stephenson to mailmap
Jason Stephenson [Thu, 3 Nov 2022 14:50:10 +0000 (10:50 -0400)]
Add another entry for Jason Stephenson to mailmap

Signed-off-by: Jason Stephenson <jstephenson@cwmars.org>
3 years agoLP#1864507: (follow-up) fix another error in the 1344 schema update
Galen Charlton [Wed, 2 Nov 2022 23:13:02 +0000 (19:13 -0400)]
LP#1864507: (follow-up) fix another error in the 1344 schema update

The normalizer is already present, so trying to add it again
breaks the update.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoforward-port 3.9.0-3.9.1 update
Galen Charlton [Wed, 2 Nov 2022 01:55:02 +0000 (21:55 -0400)]
forward-port 3.9.0-3.9.1 update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agofix version stamp in 1341 update
Galen Charlton [Wed, 2 Nov 2022 01:53:46 +0000 (21:53 -0400)]
fix version stamp in 1341 update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoadd additional fixes in 3.9.1 to release notes
Galen Charlton [Tue, 1 Nov 2022 20:12:21 +0000 (16:12 -0400)]
add additional fixes in 3.9.1 to release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agodocs: release notes 3.9.1 and 3.8.2
Jennifer Pringle [Tue, 18 Oct 2022 13:33:47 +0000 (09:33 -0400)]
docs: release notes 3.9.1 and 3.8.2

Author: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Author: Jennifer Weston <jennifer.weston@equinoxoli.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agocheck in latest cs-CZ strings for the Angular staff client
Galen Charlton [Tue, 1 Nov 2022 19:45:08 +0000 (15:45 -0400)]
check in latest cs-CZ strings for the Angular staff client

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1982887: (follow-up) set l10n list back to en-US
Galen Charlton [Tue, 1 Nov 2022 19:42:29 +0000 (15:42 -0400)]
LP#1982887: (follow-up) set l10n list back to en-US

This works around an issue where the Angular staff client's
navbar langauge selector selects all provided locales, but
that can break things without additional configuration.

To enable the Czech translation, edit

Open-ILS/src/eg2/src/environments/environment.prod.ts

to add 'cs-CZ' to the list of locales, then rebuild the
Angular app using

ng build --configuration=production

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1982887: Repair translations for eg2 client
Jason Boyer [Wed, 27 Jul 2022 22:07:59 +0000 (18:07 -0400)]
LP1982887: Repair translations for eg2 client

Previously following the build instructions for the Czech localization
placed the results in eg2/cs-CZ/cs-CZ and also broke the en-US build.
These changes bring the staff client a little more in line with current
Angular localization methods.

Note that currently both en-US and cs-CZ are always built. This can be
limited to en-US by using "--localize false" on the ng build command line.
Until an alternative method to determine the number of available locales is
implemented the only way to hide the locale selector is to edit environment.prod.ts.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Linda Jansova <skolkova@chello.cz>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1954681 - Add Release Notes
Michele Morgan [Mon, 31 Oct 2022 17:20:24 +0000 (13:20 -0400)]
LP1954681 - Add Release Notes

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP#1954681 Individual overrides when placing multiple holds
Dan Briem [Fri, 18 Feb 2022 22:25:26 +0000 (17:25 -0500)]
LP#1954681 Individual overrides when placing multiple holds

This adds an override all button above the override column if
there are multiple overridable holds (Angular Staff Catalog).

To test:
1. Ensure staff has permission to CREATE_DUPLICATE_HOLDS
   and HOLD_ITEM_CHECKED_OUT.override
2. Set org setting for Maximum number of duplicate holds allowed
   to a value greater than 1
3. Check out an item to a patron
4. Try to place a hold on that item with Number of copies set
   to a value greater than 1
5. Test that the Override All button appears and works

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1829418 release notes
Jane Sandberg [Sat, 29 Oct 2022 04:25:34 +0000 (21:25 -0700)]
LP1829418 release notes

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP1829418 OPAC-Visible Stat Cats Not Visible
Terran McCanna [Fri, 30 Sep 2022 19:28:48 +0000 (15:28 -0400)]
LP1829418 OPAC-Visible Stat Cats Not Visible

This adds patron and item statistical categories to the Bootstrap OPAC.

OPAC-visible patron stat cats will appear in My Account > Preferences >
Personal Information as new rows below the Account Expiration Date.

OPAC-visible item stat cats will appear below Copy Notes in the copy table
on the record details page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoLP1859701 - Stamping upgrade script
Michele Morgan [Fri, 28 Oct 2022 20:02:03 +0000 (16:02 -0400)]
LP1859701 - Stamping upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1859701: remove unused imports
Jane Sandberg [Mon, 3 Oct 2022 13:42:43 +0000 (06:42 -0700)]
LP1859701: remove unused imports

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1859701 follow-up fixes for Cash Report
Jason Etheridge [Mon, 29 Aug 2022 11:38:42 +0000 (07:38 -0400)]
LP1859701 follow-up fixes for Cash Report

  * restore totals to area outside of grid
  * add Debit Card Payments
  * relabel Credit Payment to Patron Credit Payment in outside-grid area
  * relabel User Payments to Staff User Payments in outside-grid area
  * relabel "patron" columns in Staff User Payments grid to "staff"

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1859701 Cash reports inline patron info
Bill Erickson [Wed, 6 Jul 2022 16:26:46 +0000 (12:26 -0400)]
LP1859701 Cash reports inline patron info

Display patron info in the User Payments grid inline with the grid
instead of requiring an additional click to open a separate dialog.

Make patron barcode a link so the patron can be opened in a new tab.

Adds grid prefs workstation settings.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1859701 Cash Reports Tidying
Bill Erickson [Thu, 30 Jun 2022 20:57:52 +0000 (16:57 -0400)]
LP1859701 Cash Reports Tidying

* Avoid manual currency data formatting when it can happen in the template.
* Replace ngbTab with ngbNav.  ngbTab is deprecated.
* Tweak date filter form layout to fix some obscured fields.
* Remove no longer needed view child static specifiers
* Use 2-space "tabs" in HTML consistent w/ other angular components.
* Remove unused code / css styles
* ng lint

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1859701 fix routing from admin page
Jason Etheridge [Tue, 5 Apr 2022 18:49:13 +0000 (14:49 -0400)]
LP1859701 fix routing from admin page

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1859701 release note
Jason Etheridge [Wed, 6 Apr 2022 15:18:04 +0000 (11:18 -0400)]
LP1859701 release note

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1859701 replace "totals" row in each grid with a totals section above each grid
Jason Etheridge [Tue, 5 Apr 2022 22:53:08 +0000 (18:53 -0400)]
LP1859701 replace "totals" row in each grid with a totals section above each grid

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1859701 Cash Reports
Zavier Banks [Thu, 9 Jan 2020 18:45:26 +0000 (18:45 +0000)]
LP1859701 Cash Reports

Migrating the DOJO UI for Cash Reports into
Angular. The disabling of the different orgs
is dependent on bug #1863168.

Signed-off-by: Zavier Banks <zbanks@catalyte.io>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1983991 release notes
Jane Sandberg [Fri, 28 Oct 2022 04:53:54 +0000 (21:53 -0700)]
LP1983991 release notes

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP1983991 handle when IN list empty
Llewellyn Marshall [Tue, 25 Oct 2022 14:11:14 +0000 (10:11 -0400)]
LP1983991 handle when IN list empty

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP1983991 Allow display of source address and source location on transit slips
Llewellyn Marshall [Mon, 8 Aug 2022 18:39:50 +0000 (14:39 -0400)]
LP1983991 Allow display of source address and source location on transit slips

Added source address and source location information to transit slip & hold transit slip print template documentation.

Signed-off-by: Llewellyn Marshall <llewellyn.marshall@ncdcr.gov>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP1966342 follow-up: prefer === over ==
Jane Sandberg [Fri, 28 Oct 2022 02:39:19 +0000 (19:39 -0700)]
LP1966342 follow-up: prefer === over ==

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP#1966342: (follow-up) adjust for color contrast
Galen Charlton [Fri, 28 Oct 2022 01:58:12 +0000 (21:58 -0400)]
LP#1966342: (follow-up) adjust for color contrast

The default Bootstrap text-light color on a bg-info background
fails the WCAG color contrast ratio; letting the text default
to black meets level AA.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1966342 Highlight Zero Holdings in Staff Catalog
Terran McCanna [Mon, 4 Apr 2022 21:02:13 +0000 (17:02 -0400)]
LP1966342 Highlight Zero Holdings in Staff Catalog

This highlights the holdings on the staff catalog search results page
when there are zero holdings as such:

bg-warning (yellow) when there are no copies
and the record is NOT transcendant, and bg-info (blue) when there are
no copies, but it is transcendant.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1977761: (follow-up) enforce use of the permission at API level
Galen Charlton [Fri, 28 Oct 2022 01:46:43 +0000 (21:46 -0400)]
LP#1977761: (follow-up) enforce use of the permission at API level

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1977761: add release note
Galen Charlton [Fri, 28 Oct 2022 01:45:21 +0000 (21:45 -0400)]
LP#1977761: add release note

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1977761: stamp DB update
Galen Charlton [Fri, 28 Oct 2022 01:41:27 +0000 (21:41 -0400)]
LP#1977761: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>