working/Evergreen.git
6 years agoLP#1772680: fix look-up of authorized services collab/gmcharlt/lp1772680_rbdigital_enhancements
Galen Charlton [Wed, 23 Jan 2019 01:53:44 +0000 (20:53 -0500)]
LP#1772680: fix look-up of authorized services

We now search for authorized digital services using the
patron's home OU _and_ its ancestors.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1772680: improvements to IDL
Galen Charlton [Wed, 23 Jan 2019 01:52:17 +0000 (20:52 -0500)]
LP#1772680: improvements to IDL

These changes were made to better support editing rows in
the RBDigital configuration tables using the web staff client.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1772680: add admin interfaces for the RBDigital integration tables
Galen Charlton [Wed, 23 Jan 2019 01:50:01 +0000 (20:50 -0500)]
LP#1772680: add admin interfaces for the RBDigital integration tables

The database tables used by the RBDigital interface now have
standard Angular administration interfaces. These can be reached
from a new item on the web staff Adminstration menu, "Extras Administration"

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: more file mode fixes
Galen Charlton [Fri, 16 Nov 2018 19:43:50 +0000 (14:43 -0500)]
LP#1772680: more file mode fixes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: update DB installation and upgrade scripts
Galen Charlton [Fri, 16 Nov 2018 19:32:03 +0000 (14:32 -0500)]
LP#1772680: update DB installation and upgrade scripts

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Fixed holds issue
Jaswinder Singh [Mon, 29 Oct 2018 17:40:54 +0000 (13:40 -0400)]
LP#1772680: Fixed holds issue

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Fixed the logic display Download link for checkedout item even if they...
Jaswinder Singh [Fri, 26 Oct 2018 20:02:05 +0000 (16:02 -0400)]
LP#1772680: Fixed the logic display Download link for checkedout item even if they are not available

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Removed unwanted statement
Jaswinder Singh [Thu, 25 Oct 2018 18:39:15 +0000 (14:39 -0400)]
LP#1772680: Removed unwanted statement

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Resolved caching, holds, and checkout issues
Jaswinder Singh [Wed, 24 Oct 2018 19:12:34 +0000 (15:12 -0400)]
LP#1772680: Resolved caching, holds, and checkout issues

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Fixed a bug with checkouts and holds API call
Jaswinder Singh [Thu, 18 Oct 2018 21:17:25 +0000 (17:17 -0400)]
LP#1772680: Fixed a bug with checkouts and holds API call

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Added Library User Name and PIN element for registration
Jaswinder Singh [Sat, 13 Oct 2018 00:14:33 +0000 (20:14 -0400)]
LP#1772680: Added Library User Name and PIN element for registration

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Fixed issues related to caching, page refresh, and add libraryCard number...
Jaswinder Singh [Fri, 12 Oct 2018 21:25:04 +0000 (17:25 -0400)]
LP#1772680: Fixed issues related to caching, page refresh, and add libraryCard number to register api call

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Fixed issues related to Caching
Jaswinder Singh [Thu, 11 Oct 2018 19:25:55 +0000 (15:25 -0400)]
LP#1772680: Fixed issues related to Caching

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Enhanced application to support multilibrary and architected sessions...
Jaswinder Singh [Thu, 11 Oct 2018 15:09:49 +0000 (11:09 -0400)]
LP#1772680: Enhanced application to support multilibrary and architected sessions for ebook

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Fixed search and css issues
Jaswinder Singh [Tue, 2 Oct 2018 15:56:04 +0000 (11:56 -0400)]
LP#1772680: Fixed search and css issues

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Removed hard coded API_URL from code and add to the database
Jaswinder Singh [Mon, 1 Oct 2018 16:57:12 +0000 (12:57 -0400)]
LP#1772680: Removed hard coded API_URL from code and add to the database

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Added Link to Wishlist Title, Fixed CSS issues, Changed Buttons on Holds...
Jaswinder Singh [Sat, 29 Sep 2018 23:40:00 +0000 (19:40 -0400)]
LP#1772680: Added Link to Wishlist Title, Fixed CSS issues, Changed Buttons on Holds, and other minor fixes

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Added RBdigital links to social, changed registration failed text, minor...
Jaswinder Singh [Thu, 27 Sep 2018 22:51:05 +0000 (18:51 -0400)]
LP#1772680: Added RBdigital links to social, changed registration failed text, minor css changes

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Fixed issues with Sorting and added image assests
Jaswinder Singh [Thu, 27 Sep 2018 03:10:24 +0000 (23:10 -0400)]
LP#1772680: Fixed issues with Sorting and added image assests

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Changed code to display RBdigital only when user home library is tied...
Jaswinder Singh [Thu, 27 Sep 2018 02:28:42 +0000 (22:28 -0400)]
LP#1772680: Changed code to display RBdigital only when user home library is tied to RBdigital library

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Added blank target for hyperlinks
Jaswinder Singh [Tue, 25 Sep 2018 21:39:33 +0000 (17:39 -0400)]
LP#1772680: Added blank target for hyperlinks

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Changed Registrationn Form output and various other changes
Jaswinder Singh [Tue, 25 Sep 2018 21:21:18 +0000 (17:21 -0400)]
LP#1772680: Changed Registrationn Form output and various other changes

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Fixed Search issue
Jaswinder Singh [Thu, 20 Sep 2018 21:21:08 +0000 (17:21 -0400)]
LP#1772680: Fixed Search issue

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Changed Registration form, added code in the backend to save email into...
Jaswinder Singh [Sun, 23 Sep 2018 15:57:01 +0000 (11:57 -0400)]
LP#1772680: Changed Registration form, added code in the backend to save email into evergreen if changed

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Fixed issue related with Advanced Search when navigating from PINES to...
Jaswinder Singh [Thu, 20 Sep 2018 02:03:25 +0000 (22:03 -0400)]
LP#1772680: Fixed issue related with Advanced Search when navigating from PINES to RBDigital Tab

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: do not enable RBDigital service by default
Galen Charlton [Thu, 20 Sep 2018 21:25:31 +0000 (17:25 -0400)]
LP#1772680: do not enable RBDigital service by default

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: tweak release notes
Galen Charlton [Thu, 20 Sep 2018 21:25:23 +0000 (17:25 -0400)]
LP#1772680: tweak release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: add some release notes and installation instructions
Galen Charlton [Thu, 20 Sep 2018 21:16:58 +0000 (17:16 -0400)]
LP#1772680: add some release notes and installation instructions

Some text initially written by Jaswinder Singh <Jaswinder.Singh0011@gmail.com>.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: add some guards
Galen Charlton [Thu, 20 Sep 2018 20:52:27 +0000 (16:52 -0400)]
LP#1772680: add some guards

Avoid crashes if the RBDigital API is not available or incorrect
tokens are configured.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: add global flag to control display of digital search tab
Galen Charlton [Thu, 20 Sep 2018 20:23:10 +0000 (16:23 -0400)]
LP#1772680: add global flag to control display of digital search tab

This patch introduces a new global flag, extras.enable_digital_resource_search_tab,
that controls whether the public catalog search tab for digital
resources is displayed. If that flag is not turned on, the tab
is not displayed and unnecessary RBDigital initialization code
is bypassed.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: remove ebook_rl table, which is no longer used
Galen Charlton [Wed, 19 Sep 2018 19:54:20 +0000 (15:54 -0400)]
LP#1772680: remove ebook_rl table, which is no longer used

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: added RBDigital search language
Jaswinder Singh [Tue, 18 Sep 2018 16:30:41 +0000 (12:30 -0400)]
LP#1772680: added RBDigital search language

Signed-off-by: Jaswinder Singh <Jaswinder.Singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Added message at Login
Jaswinder Singh [Mon, 17 Sep 2018 20:17:48 +0000 (16:17 -0400)]
LP#1772680: Added message at Login

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Changed the code to accommodate new Registration Response Structure
Jaswinder Singh [Mon, 17 Sep 2018 17:26:52 +0000 (13:26 -0400)]
LP#1772680: Changed the code to accommodate new Registration Response Structure

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: adjust how additional JS/CSS deps are brought in for master
Galen Charlton [Tue, 14 Aug 2018 01:47:11 +0000 (21:47 -0400)]
LP#1772680: adjust how additional JS/CSS deps are brought in for master

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: sort out fm_IDL.xml changes
Galen Charlton [Tue, 14 Aug 2018 01:27:41 +0000 (21:27 -0400)]
LP#1772680: sort out fm_IDL.xml changes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: schema updates
Galen Charlton [Tue, 14 Aug 2018 01:20:49 +0000 (21:20 -0400)]
LP#1772680: schema updates

This includes tables used by the RBdigital integration, putting
them in a new schema called 'extra' that's meant to collect
Evergreen extensions and integrations that are optional but ship
with Evergreen.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: sort out seed data and upgrade for new RBdigital YAOUS
Galen Charlton [Tue, 14 Aug 2018 01:01:31 +0000 (21:01 -0400)]
LP#1772680: sort out seed data and upgrade for new RBdigital YAOUS

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: correct some copyright and license statements
Galen Charlton [Tue, 14 Aug 2018 00:57:16 +0000 (20:57 -0400)]
LP#1772680: correct some copyright and license statements

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: remove extraneous changes
Galen Charlton [Tue, 14 Aug 2018 00:54:13 +0000 (20:54 -0400)]
LP#1772680: remove extraneous changes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: don't enable integrated e-resource content in stock
Galen Charlton [Tue, 14 Aug 2018 00:53:01 +0000 (20:53 -0400)]
LP#1772680: don't enable integrated e-resource content in stock

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: clean up a couple uses of cache_key
Galen Charlton [Tue, 14 Aug 2018 00:51:12 +0000 (20:51 -0400)]
LP#1772680: clean up a couple uses of cache_key

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: file mode fixes
Galen Charlton [Tue, 14 Aug 2018 00:46:10 +0000 (20:46 -0400)]
LP#1772680: file mode fixes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: remove extraneous file
Galen Charlton [Tue, 14 Aug 2018 00:42:57 +0000 (20:42 -0400)]
LP#1772680: remove extraneous file

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: fix typo
Galen Charlton [Tue, 14 Aug 2018 00:41:58 +0000 (20:41 -0400)]
LP#1772680: fix typo

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Fixed vendor tab issue
Jaswinder Singh [Thu, 26 Jul 2018 00:47:25 +0000 (20:47 -0400)]
LP#1772680: Fixed vendor tab issue

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Resolved multiple issues
Jaswinder Singh [Wed, 25 Jul 2018 20:43:11 +0000 (16:43 -0400)]
LP#1772680: Resolved multiple issues

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Fixed multiple issues and add the ability to return an e-item
Jaswinder Singh [Mon, 23 Jul 2018 16:06:19 +0000 (12:06 -0400)]
LP#1772680: Fixed multiple issues and add the ability to return an e-item

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Minor fixes
Jaswinder Singh [Mon, 23 Jul 2018 04:02:20 +0000 (00:02 -0400)]
LP#1772680: Minor fixes

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Fixed issues with advanced search, Tab name, and wishlist
Jaswinder Singh [Sun, 22 Jul 2018 23:00:40 +0000 (19:00 -0400)]
LP#1772680: Fixed issues with advanced search, Tab name, and wishlist

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Fixed search and other issues
Jaswinder Singh [Thu, 19 Jul 2018 12:29:26 +0000 (08:29 -0400)]
LP#1772680: Fixed search and other issues

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Enhance the add to display wishlist on myopac page
Jaswinder Singh [Tue, 10 Jul 2018 19:08:37 +0000 (15:08 -0400)]
LP#1772680: Enhance the add to display wishlist on myopac page

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Fixed the search issue
Jaswinder Singh [Fri, 6 Jul 2018 15:38:51 +0000 (11:38 -0400)]
LP#1772680: Fixed the search issue

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Resolved multiple issues
Jaswinder Singh [Thu, 28 Jun 2018 19:35:27 +0000 (15:35 -0400)]
LP#1772680: Resolved multiple issues

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Fixed issues dealing with search feature and new User
Jaswinder Singh [Fri, 22 Jun 2018 20:24:38 +0000 (16:24 -0400)]
LP#1772680: Fixed issues dealing with search feature and new User

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Fixed download issue
Jaswinder Singh [Tue, 19 Jun 2018 03:43:34 +0000 (23:43 -0400)]
LP#1772680: Fixed download issue

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: Implementation of Checkout, Hold, and other enhancements
Jaswinder Singh [Mon, 18 Jun 2018 05:06:31 +0000 (01:06 -0400)]
LP#1772680: Implementation of Checkout, Hold, and other enhancements

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1772680: enhancements to RBDigital integration
Jaswinder Singh [Thu, 14 Jun 2018 20:30:40 +0000 (16:30 -0400)]
LP#1772680: enhancements to RBDigital integration

This feature allows searching of RBdigital resources from the Evergreen
catalog without needing to import and maintain bibliographic records for
the RBdigital resources.

The RBdigital search results will appear in the OPAC on a different tab -
a search in basic or advanced Evergreen search will carry over to the
RBdigital tab (along with filters when mapping is feasible) so that the
user can type in a search once and see both sets of results. The design
of the RBdigital tab will make use of the OPAC styling for consistency.

This feature is sponsored by Recorded Books (RBDigital) and
GPLS and was primary written by Jaswinder Singh with code contributions
and testing from the Equinox Open Library Initiative.

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoDocs: LP#1578719 Update DIG Attributions page
Jeanette Lundgren [Wed, 12 Sep 2018 19:52:21 +0000 (15:52 -0400)]
Docs: LP#1578719 Update DIG Attributions page

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
7 years agoLP1490616: Adjust "Penalties & Messages" label (webby)
Dan Scott [Mon, 31 Aug 2015 15:54:10 +0000 (11:54 -0400)]
LP1490616: Adjust "Penalties & Messages" label (webby)

The pane in the web-based staff client to display penalties and messages
currently has a label of "Staff-Generated Penalties/Messages", which is
misleading as the list includes system-generated penalties and messages.

Modify this to "Penalties and Messages" to avoid the "/" construction
(which is considered harder to translate) and avoid the impression that
it contains only staff-generated penalties and messages.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <ben@evergreener.net>
7 years agoLP#1091885: Stamping upgrade script
Ben Shum [Fri, 16 Nov 2018 02:02:54 +0000 (21:02 -0500)]
LP#1091885: Stamping upgrade script

Signed-off-by: Ben Shum <ben@evergreener.net>
7 years agoLP#1091885: make sure bibs get reingested on undelete
Rogan Hamby [Fri, 23 Mar 2018 14:54:05 +0000 (10:54 -0400)]
LP#1091885: make sure bibs get reingested on undelete

Signed-off-by: Rogan Hamby <rogan@equinoxinitiative.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
7 years agoLP#1757455: followup to fix installing i18n
Ben Shum [Thu, 15 Nov 2018 19:04:28 +0000 (14:04 -0500)]
LP#1757455: followup to fix installing i18n

Actually installing a language also runs updatepo and subsequently attempts
to copy the various dtd and property files to their correct places.

Remove from the Makefile target for install, but retain the dtd web opac
folder which is apparently where we put fieldmapper and some other files
later.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1797007 Grid cell tooltips apply to all cells (Ang)
Bill Erickson [Tue, 6 Nov 2018 14:42:17 +0000 (09:42 -0500)]
LP#1797007 Grid cell tooltips apply to all cells (Ang)

Avoid excessive browser page re-flows, caused by checking cell
widths for rendering tooltips, by rendering tooltips for all cells
regardless of the size of the content.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1797007 Grid cell tooltips apply to all cells
Bill Erickson [Mon, 5 Nov 2018 15:52:17 +0000 (10:52 -0500)]
LP#1797007 Grid cell tooltips apply to all cells

Avoid excessive browser page re-flows, caused by checking cell widths
for rendering tooltips, by rendering tooltips for all cells regardless
of the size of the content.

This reverts commit 1e9c0ab388a0697a1f099970240f2da21bfb5e1f.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1757455: Deprecate i18n building for XUL client
Ben Shum [Mon, 5 Nov 2018 19:03:44 +0000 (14:03 -0500)]
LP#1757455: Deprecate i18n building for XUL client

Remove older dtds and properties files from the Makefile for i18n build
process.

To test
-------
[1] Apply patch.
[2] Make a change to a XUL properties or DTD file
[3] Run 'make newpot' in build/i18n.
[4] Verify that your change is not reflected in the updated POT files.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1783440: add release notes entry
Galen Charlton [Tue, 13 Nov 2018 15:56:07 +0000 (10:56 -0500)]
LP#1783440: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1783440: adding UPC to numeric search types in advanced search
Rogan Hamby [Wed, 25 Jul 2018 12:38:11 +0000 (08:38 -0400)]
LP#1783440: adding UPC to numeric search types in advanced search

To test
-------
[1] Go the Advanced Search page in the public catalog, then to the
    Numeric Search tab.
[2] Search on a UPC value (e.g., in Concerto, "883929159529").
[3] Verify that a hit is retrieved.

Signed-off-by: Rogan Hamby <rhamby@equinoxinitiative.org>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1684202 - fix holdings grid refresh... bre_id array always be integers
Cesar Velez [Wed, 7 Nov 2018 16:09:10 +0000 (11:09 -0500)]
LP#1684202 - fix holdings grid refresh... bre_id array always be integers

For some strange reason the volcopy bchannel event data.records
would be an array of string integers or a array of ints depending
on whether you're adding or editing holdings. This addresses that
weirdness.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
7 years agoLP#1684202 - fix bug the prevented automatic refresh
Cesar Velez [Wed, 17 Oct 2018 22:06:01 +0000 (18:06 -0400)]
LP#1684202 - fix bug the prevented automatic refresh

Turns out that Array.includes() does not do implicit type convertions
Typical javascript...

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
7 years agoLP#1684202: Protect against missing features; Make feature more general
Mike Rylander [Fri, 14 Sep 2018 15:03:30 +0000 (11:03 -0400)]
LP#1684202: Protect against missing features; Make feature more general

I've wrapped the BroadcastChannel code in a test derived from the auth version
of the same concept.  Also broadcasting the full set of record IDs and the
pre-update call number IDs for other interfaces that might be interested. The
channel name is also made more generic and made to follow the precedent from
the auth channel name.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
7 years agoStamping upgrade script
Mike Rylander [Mon, 12 Nov 2018 17:26:40 +0000 (12:26 -0500)]
Stamping upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1773479 Show Located URIs in browse
Dan Wells [Fri, 9 Nov 2018 17:28:08 +0000 (12:28 -0500)]
LP#1773479 Show Located URIs in browse

Located URIs depend upon bib-level visibility, as there are no copies
to work with.  The browse code, however, was joining in the copy
visibility table as if it would always have at least one row per bib,
but in the case of located URIs, it does not.

Let's change it to a LEFT JOIN to allow the bib row to show up, at
which point the existing bib visibility check can do its job.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1724348 Honor default tab from catalog search
Dan Wells [Wed, 24 Oct 2018 18:38:01 +0000 (14:38 -0400)]
LP#1724348 Honor default tab from catalog search

The default tab selection was not being honored from catalog searches,
as the search had already set $scope.record_tab, and we were honoring
that value in all cases.

Instead, let's honor that value in cases where the OPAC load doesn't
change our current record, which should only happen if we load the
record directly to a non-opac tab, then go to the OPAC view.

To test:
1) Set any tab other than "OPAC View" as your default view in record
details.
2) Do a catalog search.
3) Select a record, and notice your default view is not set.
4) Apply patch, do the same steps, and notice the default view is now
selected.

To test regression of bug #1708951:
1) In Firefox, load a record directly (e.g.
/eg/opac/staff/cat/catalog/record/123).
2) Note the default view loaded.
3) Click "OPAC View".
4) Note the view does not return to your default view, but stays on
the OPAC.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jason Boyer <JBoyer@library.in.gov>
7 years agoLP#1635737 Due date DST noncat thinko fix
Bill Erickson [Wed, 7 Nov 2018 14:27:30 +0000 (09:27 -0500)]
LP#1635737 Due date DST noncat thinko fix

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1635737 Due date DST-aware thinko fix
Bill Erickson [Tue, 6 Nov 2018 21:22:43 +0000 (16:22 -0500)]
LP#1635737 Due date DST-aware thinko fix

Minor code refactor to fix thinko and syntax issues.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1635737 Apply DST-aware timezone to context dates
Mike Rylander [Mon, 31 Jul 2017 19:55:34 +0000 (15:55 -0400)]
LP#1635737 Apply DST-aware timezone to context dates

Do our best to enforce the rule required by OpenSRF's interval_to_seconds
that when a context date is in use, and you care about DST awareness, you
must set the timezone to a DST-aware value, e.g., 'America/New_York'. In
most situations, 'local' will suffice for this, as the server is typically
configured with a DST-aware timezone in its environment.  However, we will
look for an org unit setting called 'lib.timezone' and use that where we
can.  See LP#1705524 for info on that setting.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/NonCat.pm

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1635737 Use new OpenSRF interval_to_seconds() context
Dan Wells [Fri, 21 Jul 2017 18:28:16 +0000 (14:28 -0400)]
LP#1635737 Use new OpenSRF interval_to_seconds() context

Use the optional context for interval_to_seconds() to account for the
variable length of duration components.  For example, "1 day" may be
shorter or longer than 24 hours during a time change event, "1 month"
may be shorter or longer depending on which month it is currently, etc.

Also, remove some timestamp munging, as that happens within
interval_to_seconds() already.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1635737: Unit tests for DST and date math
Mike Rylander [Tue, 6 Nov 2018 20:27:23 +0000 (15:27 -0500)]
LP#1635737: Unit tests for DST and date math

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1635737 Add optional context to interval_to_seconds
Dan Wells [Tue, 6 Nov 2018 20:13:47 +0000 (15:13 -0500)]
LP#1635737 Add optional context to interval_to_seconds

Any given interval (e.g. "1 month") can be a different amount of
seconds depending on the context (i.e. "1 month" after February 1 is
March 1, but "1 month" after March 1 is April 1, yet March is longer
than February).  This affects months all the time, but also can
affect days, hours, and even seconds once you consider DST and "leap"
times.

By giving an optional context to interval_to_seconds, you can find
the true number of seconds in, for example, "1 month", when starting
from "February 1" (the context).

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoAdd eg_startup back to .gitignore
Ben Shum [Tue, 6 Nov 2018 20:35:49 +0000 (15:35 -0500)]
Add eg_startup back to .gitignore

Since we moved eg_startup to apache_24, we also need to ignore there.

Signed-off-by: Ben Shum <ben@evergreener.net>
7 years agoLP#1783602: Remove copy counts from mr search results page
Kathy Lussier [Wed, 25 Jul 2018 15:51:06 +0000 (11:51 -0400)]
LP#1783602: Remove copy counts from mr search results page

The copy counts on the mr search results page can be wrong if a limiter was
applied to the metarecord search. Rather than supply inaccurate information to
the user, let's remove the counts from that page until a long-term solution can
be developed.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1755543: Change placement of help popovers
Kathy Lussier [Mon, 5 Nov 2018 20:50:24 +0000 (15:50 -0500)]
LP#1755543: Change placement of help popovers

Set the placement of help tip popovers so that they automatically position
to a visible place on the screen.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1755543: Add help tips to Print Item Labels Settings tab
Kathy Lussier [Tue, 13 Mar 2018 16:54:42 +0000 (12:54 -0400)]
LP#1755543: Add help tips to Print Item Labels Settings tab

Instead of providing lengthy settings descriptions, which result in a lot of
scrolling on the Print Item Template page, let's use help tips that can
provide guidance to new users without adding clutter to the interface.

This commit also turns the field labels into HTML labels for improved
accessibility and removes borders on the page. The borders were helpful
when we displayed the help text on the page, but are no longer needed.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1755896: Web Client mobile menu font color contrast.
Garry Collum [Thu, 7 Jun 2018 18:54:45 +0000 (14:54 -0400)]
LP#1755896: Web Client mobile menu font color contrast.

When viewing the main menu in the web client in a small device or in a
browser with a width that is resized to less than 800px the menu
collapses and the submenu choices are difficult to read because of lack
of contrast.  This patch adds some contrast.

To test:
1. View the web client in a browser and lessen the width until the menu
   collapses, or view it in a small device.
2. Open some of the menu options to observe the submenus.
3. Apply the patch.
4. Refresh the browser and repeat steps 1-2 to view the more readable
   submenus.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1789747: tweak disabling the offline circulation link
Galen Charlton [Mon, 5 Nov 2018 21:40:34 +0000 (16:40 -0500)]
LP#1789747: tweak disabling the offline circulation link

This patch ensures that the menu link can be fully disabled by
giving the "disabled" CSS class to the anchor as well as the
li that contains it. It also adds a CSS rule to the disabled
class to force the cursor to not-allowed; due to a quirk, an
anchor with "pointer-events: none" will not respect "cursor: not-allowed",
but the containing element can have that cursor rule.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1789747 More SharedWorker sanity checks for egLovefield
Bill Erickson [Tue, 4 Sep 2018 19:09:31 +0000 (15:09 -0400)]
LP#1789747 More SharedWorker sanity checks for egLovefield

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Rogan Hamby <rhamby@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1789747 SharedWorker sanity checks
Bill Erickson [Thu, 30 Aug 2018 17:19:03 +0000 (13:19 -0400)]
LP#1789747 SharedWorker sanity checks

Avoid page load failures when SharedWorkers (for offline mode) are
not supported.  Additionally, disable the Offline Circulation menu
option when SharedWorkers are not supported.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1798170 Load grid data after settings are applied
Bill Erickson [Tue, 16 Oct 2018 18:15:53 +0000 (14:15 -0400)]
LP#1798170 Load grid data after settings are applied

Ensure the initial grid data fetching code does not fire until after the
grid configuration has been retrieved and applied.  This fixes an issue
where custom columns would contain no values on initial grid load.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1801759: enable mod_remoteip by default
Galen Charlton [Mon, 5 Nov 2018 17:54:24 +0000 (12:54 -0500)]
LP#1801759: enable mod_remoteip by default

Use of mod_remoteip is technically optional, since it's not
required that Evergreen run with a proxy such as NGINX. However, since
use of proxies is common, enablig mod_remoteip just in case could
be useful with minimal cost.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1801759: add mod_remoteip configuration to example Apache config
Galen Charlton [Mon, 5 Nov 2018 17:49:35 +0000 (12:49 -0500)]
LP#1801759: add mod_remoteip configuration to example Apache config

Text taken from an OpenSRF patch added by Bill Erickson per bug 1684970.

This patch adds an Apache configuration stanza that uses mod_remoteip
to pass the user agent's IP address to the HTTP translator. It is meant
for when Apache is being run behind a proxy such as NGINX.

To test
-------
[1] Set up Evergreen with Apache and the WebSockets server running
    behind a proxy such as NGINX.
[2] Enable mod_remoteip (e.g., sudo a2enmod remoteip).
[3] Apply the Apache configuration change in this patch, uncommenting
    out the directives and (if necessary) updating the internal IP
    address of the proxy.
[4] Reload Apache.
[5] Perform an action that uses the HTTP translator, e.g., adding a
    vendor record using the Dojo interface.
[6] Verify that the client IP logged is that of the user agent, not
    the proxy.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoDocs: updating holding, item, call number terminology
Jane Sandberg [Sun, 4 Nov 2018 23:25:44 +0000 (15:25 -0800)]
Docs: updating holding, item, call number terminology

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 years agoDocs: Update old command osrf_ctl.sh to osrf_control
Remington Steed [Fri, 2 Nov 2018 19:00:55 +0000 (15:00 -0400)]
Docs: Update old command osrf_ctl.sh to osrf_control

Thanks to Rosie Le Faive for catching this problem, and providing the
solution!

Signed-off-by: Remington Steed <rjs7@calvin.edu>
7 years agoLP1796988: Fix Saving Last Copy Template
Jason Boyer [Fri, 26 Oct 2018 13:16:14 +0000 (09:16 -0400)]
LP1796988: Fix Saving Last Copy Template

A line that belongs within a forEach loop escaped
its bounds and caused a reference error that prevented
the applyTemplate function from saving the last used
template. This branch ushers this line back to its
pen where it can trouble us no more.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Janet Schrader <jschrader@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
7 years agoDocs: Emergency Closing Handler
abneiman [Thu, 1 Nov 2018 20:59:02 +0000 (13:59 -0700)]
Docs: Emergency Closing Handler

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 years agoDocs: Fix minor release notes formatting bug
Remington Steed [Wed, 31 Oct 2018 20:53:17 +0000 (16:53 -0400)]
Docs: Fix minor release notes formatting bug

Signed-off-by: Remington Steed <rjs7@calvin.edu>
7 years agoForward Port Release Notes for 3.0.13.
Jason Stephenson [Thu, 25 Oct 2018 13:35:37 +0000 (09:35 -0400)]
Forward Port Release Notes for 3.0.13.

Signed-off-by: Jason Stephenson <jason@sigio.com>
7 years agoForward-port 3.1.7 upgrade script
Dan Wells [Wed, 24 Oct 2018 22:18:48 +0000 (18:18 -0400)]
Forward-port 3.1.7 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoForward-port 3.2.1 upgrade script
Dan Wells [Wed, 24 Oct 2018 22:14:28 +0000 (18:14 -0400)]
Forward-port 3.2.1 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoDocs: adding another entry to 3.2.1 release notes
Jane Sandberg [Wed, 24 Oct 2018 16:35:50 +0000 (09:35 -0700)]
Docs: adding another entry to 3.2.1 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>