webstaff: Typo in method name for volume transfer

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: Label field "Owning Library" instead of "Library" in call number area

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: teach egOrgSelector how to be sticky

In order to make the org unit selector in the holdings view
to be "sticky", the egOrgSelector directive now accepts an
optional stickySetting attribute specifying the name of a
preference key for storing the last selected org unit.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: when FF input gains focus, select contents

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: restrict owning and circ lib selection to only those orgs that have can_have_vols true for their org type

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: Force refresh from server on copy delete

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: be explicit about fast-add availability

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: use activateItem to open the vol/copy editor

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: typo preventing a setting from working

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: inform on record save failure, and mark the page clean on successful save

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: make sure copy_notes() contains an array before pushing to it

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: improve styling of aligned grid columns to avoid cell overlap

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: highlight currently active position in phys char wizard

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: allow batch copy attribute editing across bib records

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: make webstaff grid menus scrollable

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: Mark new copy notes as new, so they will save.

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: Typo fix (Catagories)

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: A little spacing tweak to avoid overlapping UI elements in modals

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: Move the "Help" and "Stack Subfields" UI elements around a bit, to save space

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: CSS tweak - add padding belong MARC editor help button

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: disable non-OPAC-view tabs when doing catalog search

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: improve MARC record deletion

The MARC editor now asks the user to confirm
whether to delete the record, and in the case of
deleting bibs, now uses open-ils.cat.biblio.record_entry.delete
so as to catch things like volumes still attached
to the bib and cancelling holds in the bib record.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: add keyboard shortcut legend to MARC editor

Note that once we upgrade to angularjs-ui >= 0.13.0, using
a popover rather than a collapse might be better.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: tweak layout of the merge interface

The lead record is now displayed using the same sort
of tabset as the subordinate records. While, of course,
there can be only one lead record at a time, doing it
this way gives us two things:

[1] Display of the lead bib's ID
[2] Better vertical alignment of the MARC records

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: automatically advance focus in MARC editor

Upon completing a tag, indicator, or subfield code
input, focus will now automatically advance to the next
input, allowing users to enter records with less need
to use the tab button.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: Always accept double-dagger as a SF delimiter

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: another fix to focus-on-new-MARC-field

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: fix setting focus when inserting a new MARC field

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: make context menus in MARC editor scrollable

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: make egGrid actions menu scrollable

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1464767 Browser client scrollable selectors

Adds a new scrollable-menu CSS class.  It's (provisionally?) limited to
larger screens, w/ the assumption that smaller screens handle scrolling
for you.

New class is applied to org unit selects only so far.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Conflicts:
Open-ILS/src/templates/staff/css/style.css.tt2

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: implement subfield stacking in MARC editor

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: add session-stickiness for MARC template selector

The new bib function now remembers the last MARC template
that was used for the lifetime of the browser tab.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: start teaching egHatch about sessionStorage

This patch adds getSessionItem(), setSessionItem(), and
removeSessionItem(), which are all wrappers around
$window.sessionStorage. This is done to support settings
whose values are sticky for the duration of a session,
which at present is the lifetime of the browser tab.

An alternative would be using session cookies; some user
testing is needed to see which lifetime makes the most
sense.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: improve how egVolumeList opens the vol/copy editor

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: teach volcopy editor how to set default item status

It now consults the cat.default_copy_status_fast and
cat.default_copy_status_normal library settings as appropriate.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: add ability to edit copies to the record merge interface

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: teach egVolumeList more tricks

The directive now accepts two new attributes:

* editVolumes - controls display of the 'Edit volumes' button
* editCopies - if true, adds a 'Edit volumes and copies button'

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: require SSL for /eg/staff/

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: force deletion of copies on "delete copies and volumes"

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: Protect against loops before cloning copy/volume data; set proper defaults on newly added copies

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: fetch both staff_client and vandelay_queue record buckets

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1503782: fix horizontal scrollbar in MARC import queue inspector

In the XUL client (and webstaff), attempting to view the contents
of a MARC record import queue displays a table that, due to
its width, will almost always have a horizontal scrollbar. However,
attempting to actually use the scrollbar often causes the
focus to jump to the top of the table instead.  This patch
fixes that.

To test:

[1] Create a bib queue that has at least a dozen records or so.
[2] Inspect the contents of the queue, scroll to the bottom of
    the table, and interact with the horizontal scrollbar.
[3] Observe that doing so typically results in jumping up
    to the top of the table.
[4] Apply the patch, clear cache and refresh, and try step #2
    again.
[5] This time, the horizontal scrollbar should act normally.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: mark some egEmbedFrame bindings as optional

This gets rid of some noise in the browser console.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: fetch MVR to help build record summary

Although this adds another OpenSRF request, using the
MVR rather than fleshing simple_record() gives us
two benefits:

* getting access to the edition
* fields like title and author are now displayed in
  their proper case, rather than the normalized lowercase
  supplied by simple_record().

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: teach record summary how to display the bib call number

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Revert "webstaff: don't break embedded volcopy editor if volume is empty"

This is no longer needed because of other work that makes the
volume copy editor better able to deal with empty volumes.

This reverts commit 8ae0321d5bad47486ca9ff22a99de451a2900850.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: teach side-by-side editing to the record merge interface

It is now possible to edit the lead record in place (in
flat editor mode).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: teach MARC editor some more tricks

[1] Now accepts a flat-only attribute specifying that
    the editor should be restricted to flat mode.
[2] Now accepts an embedded attribute specifying that
    various stuff that isn't useful when the editor
    is embedded in another control should be ignored.
[3] The width of the flat editor's textarea is now
    bounded by its container.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: display MARC records in merge interface in breaker format

Doing this will ease copy-and-paste between records.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: add egRecordBreaker directive

This directive takes a blob of MARCXML or a bib
record ID and renders the record in "breaker"
format.

Example usage:

  <eg-record-breaker record-id="1234"></eg-record-breaker>
  <eg-record-breaker marc-xml="xml"></eg-record-breaker>

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: Allow editing of empty volumes

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: fix saving copy price in vol/copy editor

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: unbreak tabs in volume/copy editor

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: don't break embedded volcopy editor if volume is empty

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: teach the merge record dialog how to edit volumes

This adds an "edit volumes" button under each record in the
merge records interface that opens a modal embedding the
volume editor.

The embedding is done via an iframe in lieu of splitting the
relevant bits of the volume/copy editor into an independent
service.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: teach volcopy editor how to be embeddable

The route /eg/staff/cat/volcopy/$key/embedded will
load the volume/copy editor in an embedded mode; specifically,

[1] the navbar and record summary will not be displayed
[2] "Save & Exit" becomes "Save changes"

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: make record merge interface display volumes for all OUs

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: add unit test for egOrg.root()

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: add egOrg.root() method

Also, start adding some documentation for egOrg.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: go to lead record after merge from bucket

After a successful record merge initiated from a record
bucket, go to the lead record rather than refreshing
the bucket display.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: teach the record merge modal how to display volumes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: more changes to holdingsSvc

- convert holdingsSvc from a singleton to a provider
  of holdings service instance objects
- adjust the catalog app accordingly
- add a new egVolumeList directive that displays
  a list of volumes attached to a bib record, including
  owning library, call number, and copies

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: break holdingsSvc out of catalog/app.js

This will allow using its logic for constructing
volume/copy lists in other places.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: make overlay record modal wider

This patch defines a CSS class, eg-wide-modal, that can be
set as the windowClass of 'lg' Boostrap modals and increase
their width from a fixed width to 95% of the window.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: use tabset rather than accordion for bucket record merge modal

This stylistic change will pave the way towards
better side-by-side record management and editing in this
interface.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: move some "mark for" buttons to record summary

This patch moves the "Mark for..." overlay, volume transfer,
and conjoined items buttons from the MARC editor to
the record summary (next to the "Add To Bucket" button).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: add drop-down for item type Z39.50 search field

It should be noted that this works *only* for OCLC, as
not all targets support use attribute 1001, and the list
of values for that use attribute are target-defined.

A more general solution might be creating a new
config.z3950_attr_value_list table.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Use record, not owning_lib, for the part record field. Doh.

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: tweak labels of remove from bucket actions

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: record buckets: implement show selected in catalog action

This replaces the show all in catalog action.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Add a few important fields for the holdings view grid

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Make the last applied template sticky

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Improve combo box functionality -- clicking on down arrow shows all options (possibly following filtered options)

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Normalize the type of values going into in-memory objects

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: replace acn prefix()/suffix() with IDs only when needed

Fixes an issue that could break saving volumes.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: adjust URL when navigating catalog search results

Navigating from record to record after performing a catalog
search now sets the URL in the browser to /eg/staff/cat/catalog/record/{record_id}.
Clicking on the "Back To Results" button will set the URL
back to /eg/staff/cat/catalog/index.

This allows staff to copy and paste record URIs more conveniently.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add angular-location-update dependency

This module adds a $location.update_path() routine to
allow changing the URL without forcing a controller reload.

This module is copyright (c) 2015 anglibs and released under
the MIT license and is taken from
https://github.com/anglibs/angular-location-update.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Grid saveConfig can generate bad data (not sure how) but we will avoid duplicates in loadConfig

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add a Save & Exit shortcut to the copy attribute editing pane

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Avoid blowing away the volume value when there is no merge target

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Pass IDs instead of objects for prefix and suffix

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Special case for egOrgSelector value reading/writing in copy templates

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: stylistic fix for MARC editor

Prevent record type display from overlapping the
bibliographic source selector.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: tweak MARC editor in "edit overlay record"

The save button is now labeled "Modify"

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: give more feedback for Z39.50 edit-then-import

The "edit then import" modal now varies the label of the
MARC editor's save button based on whether one has yet
to import the current record or if one is just making
changes to it after having imported it. The dialog now
also has a button for going to the newly-imported record
in catalog view.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: provide feedback after record imported via Z39.50

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: teach egConfirmDialog how to set custom labels for buttons

egConfirmDialog() now accepts optional fourth and fifth
arguments to set custom labels for the "OK" and "cancel"
buttons.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: fix deleting fields in MARC editor

When editing a record that has not yet been saved
to Evergreen (either because it is new or because it
is a record coming from a Z39.50 target), ensure that
the context menu 'delete field' operation works.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: make some MARC editor strings translateable

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Select on focus for tag, indicators, and sf codes

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP 1496977: Duplicate Code in OpenILS::Application::Cat::AssetCommon

It looks like two lines of code got duplicated in commit e2f6cca0 in
AssetCommon.  This duplication can lead to data loss for the function
update_fleshed_copies.  It also lead to the following warning when
you use OpenILS::Application::Cat::AssetCommon in a script:

"my" variable $sc_entries masks earlier declaration in same scope at
/usr/local/share/perl/5.18.2/OpenILS/Application/Cat/AssetCommon.pm
line 371.

After this patch, the warning disappears.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Provide context menu options for adding and removing fields; TODO: i18n on strings

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1437110 add Manual Floating Active

Add Manual Floating Active to Checkin Modifiers in web staff client.

Signed-off-by: Victoria Lewis <“vlewis@catalystitservices.com”>

LP#1436980: Default copy circ count to 0 instead of undefined

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1436980 Total Circulations in Patron Bills

Add code to display Total Circulations in
Item Summary on Bills page.

Signed-off-by: Victoria Lewis <vlewis@catalystitservices.com>

LP#1483857 Add code to clear barcodes from in-house use

Signed-off-by: Stephen Moss <smoss@catalystitservices.com>

Provide hooks for on-save callback for marc edit to, for instance, refresh the record summary UI

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: record summary now signals if record is deleted

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Fix typo in comment in 002.schema.config.sql.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>