improve lost+paid handling

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

get next status & suppressed alerts working correctly

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

disable Manage button in Alerts column when there are no alerts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add alerts column to several grids

The item status, holdings, and checkout grids now have an
alerts column that lists the number of copy alerts associated
with the item as well as a button to manage them.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
Open-ILS/web/js/ui/default/staff/cat/item/app.js
Open-ILS/web/js/ui/default/staff/cat/services/holdings.js

teach egGridFields how to compile column tempates

This adds two optional attributes to eg-grid-field:

 compiled: if present, treat the template inside the
           element as a template to be compiled
 handlers: if present, contains an object with a bucket
           of functions (or whatever) that can be invoked
           inside the template as "col.handlers.foo"

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix clearing copy alerts in volume/copy editor

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Focus the next-status dropdown when present, otherwise nothing

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/web/js/ui/default/staff/services/ui.js

add copy alert actions to item status page in list view

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add a copy alert editor dialog

This replaces, in certain contexts, the copy alert manager,
which is now used only during checkin/checkout.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
Open-ILS/web/js/ui/default/staff/circ/services/circ.js

add test of asset.copy_state()

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

avoid transits when handling override of lost/long-overdue checkout

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

ensure that suppressed system alerts do not set next_status

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add more auto-overrides for suppressed alerts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Remove alert focusing -- it does not work well enough.  Also, remove X close button.

Signed-off-by: Mike Rylander <mrylander@gmail.com>

handing of suppressed LOST and LONGOVERDUE events

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix an initialization error

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

teach copy alerts how to automatically generate certain overrides

When a new-style copy alert type is active but supressed, any
system-generated events of that type should be recorded but
not present a pop-up. In some cases, an older-style circ event
make get generated; this patch supplies a way for the new copy
alerts to override the old-style events without having
to sprinkle a bunch of special checks.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

teach copy editor templates about copy alerts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

teach copy templates how to manage copy notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js

update egBasicComboBox for new Bootstrap dropdown

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Apply focus to the element tab-previous to the OK/Continue button in alert popups

Signed-off-by: Mike Rylander <mrylander@gmail.com>

adjust OU lookup for suppression of system-generated alerts too

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

check full org path of circ lib when deciding whether to suppress a copy alert

This allows for a system to suppress alerts of a given type on behalf
of all of its branches.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix bug with creating new copy alert suppression rules

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add multi-select for setting copy alert type next status field

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

adjust labelling

- The action buttons for acknowledging a temporary
  copy alert now use "Clear"
- Menu items for bringing up the copy alerts dialog
  now uniformly use "Manage Copy Alerts"

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

set default value of 'Renewing?' to false when creating alert type

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix fleshing set of next copy statuses

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

when renewing, filter out alerts where in_renew is false

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add add/acknowledge copy alert actions to holdings view menu

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix error made when rebasing

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
Open-ILS/web/js/ui/default/staff/circ/services/circ.js

fix syntax error

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

update from $modal to $uibModal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: Show event name in the manage interface (useful for staff alerts)

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: Make alert type selection sticky when an alert is saved

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fleshed call does not find "odd" circs, fetch directly; Disable auto-overrides on existing circ to allow alerts to show up

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/web/js/ui/default/staff/circ/services/circ.js

TODO: Verify that the resolution of the merge conflict doesn't
cause a regression on LP#1522635

Protect the status list from empty items

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add better page titles

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Use ngInit and ngOptions so we can have a nullable Event field

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Array-ify next_status when sending back to client; Skip old-style status events when using new-style alert infrastructure.

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix last commit... typo

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add dblclick handler for autoGrid

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Align terminology with the copy editor

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Further cleanup of location checks; remove "no" option from at_circ and at_owning

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add LONGOVERDUE to the state list

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add more seed data

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Adjust display of next-status labels in the copy alert popup

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Correct location test for at_circ and at_owning

Signed-off-by: Mike Rylander <mrylander@gmail.com>

tweak styling

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

improve init of next status

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add 'add copy alert' action

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
Open-ILS/web/js/ui/default/staff/circ/services/circ.js

add acknowledge alerts to renewal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

allow both CHECKIN and CHECKOUT alerts to fire during renewal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

correctly test whether the alert_type fires during renewal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

no longer display the legacy copy alert message

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix styling of manage copy alert button in item status

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add new-style copy alerts to volcopy defaults selector

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

copy alert type editor can now create and update copy alert types

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

make copy alert suppression editor feature-complete

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

set name as copy alert type selector field

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add copy alert suppression to splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

start UI for managing copy alert suppression

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add copy alerts to local admin splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

start on a config editor for config.copy_alert_types

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

teach vol/copy editor how to deal with copy alerts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add copy alert ack/manage action to checkin, checkout, and item status

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
Open-ILS/src/templates/staff/cat/item/t_summary_pane.tt2

implement setting next status upon checkin

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

display text for system-generated copy alerts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

return all potential next copy statuses, not just first

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

have a bit of visual separation between alerts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

start work on egCopyAlertManagerDialog

This dialog is currently capable of:

- displaying copy alerts during checkin and checkout
- allowing the operator to acknowledge temporary alerts

TODO:

- allow display of all current alerts
- allow alerts to be added

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
Open-ILS/web/js/ui/default/staff/circ/services/circ.js

some sample copy alert types

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

don't generate system copy alerts if copy state is normal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

support the LOST_AND_PAID status added in LP#1198475

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix various thinkos and syntax errors to get the biz logic working

As of now, open-ils.circ.checkin is now starting to emit
custom copy alerts.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix some typos, syntax errors, and stray invisible characters

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add typo/space fixes to baseline schema

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

biz logic for alerts

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Baseline IDL stuff for alerts

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Initial schema for copy alerts

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1691560: start open-ils.qstore service by default

To test
-------
[1] Apply patch, then restart all services.
[2] Verify that open-ils.qstore is running.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1692106: Z39.50 server includes prefix and suffix in 852

Add the call number prefix and suffix to the 852 $k and $m when copy
information is returned by the Z39.50 server.

Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1704463: Item Status Fields Correction

The Loan Duration and Fine Level fields were
being incorrectly pulled from unrelated fields
on the most recent circ rather than the item.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Docs: Search Filter Enhancements

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>

Docs: Update to Statistical Popularity Badges

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>

Docs: Statistical Popularity Badges

Documentation for new statistical popularity badge feature in the web client.

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>

Docs: Email Checkout Receipts (web client)

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>

Docs: Add doc for Cash Reports feature

Add basic documentation for the previously undocumented Cash Reports
feature.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

lp1702568 Copy Location fix for Hold Detail View

hold.current_copy.location is better fleshed than copy.location in this case

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>

lp1661685 fix circ lib in patron holds list

and make it and the circ modifier column hidden by default

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>

lp1661685 webstaff: Circ Lib column for Items Out

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>

lp1661685 webstaff: Fix Owning Lib in Item Status

Detail View

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>

lp1661685 fieldmapper label change for circ

Change "Circulation Library" to "Checkout / Renewal Library"

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>

lp1661685 webstaff: add money.grocery to pcrud

and add a single column called Location to the Bills interface which shows
either the circ.circ_lib or the grocery.billing_location for a given xact

and the specific columns for both xact types

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>

LP#1685933 - Add Owning Library column to grids in ItemsOut and checkout views

Added necessary fleshing in egCirc service and items out to get acn.owning_lib.shortname

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>

LP#1661685 - Adds circ library column to staff webclient grids

Circulation Library was missing as an option from several grids
Added also function to flesh out circ_lib.shortname to display name.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>

LP#1661685 - Adds missing Circulation Modifier column to several grids

Some views like the Checkout,CheckIn, Holds, And Bills
 did not display the copy's circ_modifier field.
 Also added egCirc.flesh_copy_circ_modifier()

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>

LP#1697754 - WebStaff make receipt on payment sticky

    Add circ.bills.receiptonpay local storage setting.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>

LP#1677000 - webstaff Adds a 'has-notes visual indicator' for patrons with notes.

Made the indicator be clickable and route to Other->Notes.
Other ways to address this not mentioned in LP would be
using a glyphicon instead, or moving the Notes submenu item out of Others tab.
Or even making the entire tab/menu be resposive, and collapsing into an Others submenu
only when needed.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>

LP#1672421-Fix for Catalog record Holds view grid not refreshing

Holds view grid was not refreshing upon paging using next/prev
Added call to egHolds service to fix that.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>