fix up return type testing

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

first cut at procedures

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

handle triggers, and give callback support for handling columns

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

more refactoring

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

use fetchall_hashref instead of fetchall_arrayref

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

better column membership test

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

better view membership test

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

better table membership test

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

narrow the workaround for a hard exception

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

refactoring

handle hstore type

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

handle ::bpchar with column_default

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

handle ARRAY type

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

handle character type

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

handle USER-DEFINED types

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

handle ::text with column_default

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

fix the type numeric tests

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

first attempt at making a test maker

for seeding a baseline set of pgTAP tests for Evergreen

TODO: put SELECT todo()'s in front of the tests that are currently failing but
shouldn't be (quirk with pgTAP and PostgreSQL 9.1?)

TODO: test for presence and attributes of stored procedures

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Use the .pg extension

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

add regression test for LP#1155329

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

use .pg extension for pgTAP test cases

That way, pg_prove --recurse t/ will DWIM.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

start adding pgTAP test cases

pgTAP is a PostgreSQL unit testing framework; about which
more can be found at http://pgtap.org/

This commit introduces the first pgTAP test case, which exercises
the NACO normalization functions.

To run the tests, install pgTAP, create an Evergreen database that
contains (for now) just the seed data, and from the top of the
source tree run

pg_prove -vr -U evergreen Open-ILS/src/sql/Pg/t/*

Replace '-U evergreen' with the psql command-line switches
needed to access your database.

To install pgTAP on a Debian Wheezy system, you can do:

Then, to load the pgTAP extension into the database, run

psql> CREATE EXTENSION pgtap;

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

pgTAP examples

These specific ones do not assume stock test data such as the concerto bibs, and
I think such tests should go elsewhere.  You need to install pgTAP.  I did the
following for my test environment:

    git clone git://github.com/theory/pgtap.git
    cd pgtap
    make
    make installcheck
    sudo make install

Then in my Evergreen database with psql, I did:

    CREATE EXTENSION pgtap;

I also installed a CPAN module to get pg_prove:

    sudo cpan TAP::Parser::SourceHandler::pgTAP

You can use psql to run a given test like so:

opensrf@dev141:~/git/Evergreen/Open-ILS/src/sql/Pg/t (pgtap)$ psql -d evergreen -f 0799.state_field_required_toggle.s
1..4
ok 1 - actor.usr_address.state does not have the NOT NULL constraint
ok 2 - ui.patron.edit.au.state.require exists
ok 3 - ui.patron.edit.au.state.show exists
ok 4 - ui.patron.edit.au.state.suggest exists

Or you can use pg_prove on all or some of them:

opensrf@dev141:~/git/Evergreen/Open-ILS/src/sql/Pg/t (pgtap)$ pg_prove -d evergreen *.s
0799.state_field_required_toggle.s .. ok
dewey.s ............................. 1/6
 # Failed (TODO) test 6: "testing prefix plus decimal"
 #     'YR_DVD_800_100000000000000'
 #         <
 #     'YR_000000000000000_DVD_900'
dewey.s ............................. ok
schema.s ............................ ok
versions.s .......................... ok
All tests successful.
Files=4, Tests=39,  0 wallclock secs ( 0.05 usr  0.03 sys +  0.13 cusr  0.07 csys =  0.28 CPU)
Result: PASS

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Generate Password Label

The "Reset" label for the button that generates random passwords can be
confusing for staff. Changes the label to "Generate Password" to let
people know what the button does.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Prevent JavaScript error on non-Novelist sites

Unless the Evergreen site in question is signed up and configured to
support Novelist added content, every details page will generate a
JavaScript error due to the reference to an undefined JavaScript
function. Guard against that by testing for the presence of the Novelist
URL.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>

Silence QP warning due to inappropriate cmp op

In QueryParser, we're comparing two strings, but using the numeric !=
operator. Switching to the 'ne' operator silences a warning that came up
7,000 today in our logs so far...

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>

Silence uninit var warnings from query normalizer

$field_info can return undef from the search for a matching ID from the
list of normalizers, which in turn generates several uninit var warnings
when attempts are made to access members of the undef variable. We saw
6700 occurrences of these warnings during a typical day of operations.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

return, not next, from eval BLOCK

Per perldoc eval, exiting an eval BLOCK is not allowed. And it generates
warnings - 37,000 of them in one day - on a system on which the fine
generator runs every 15 minutes. Simply returning from the block
achieves the same goal without generating scads of warnings.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP1179609 ACQ lineitem identifier inline update

When the identifier value for a linetiem is changed, apply the change
and refresh the lineitem in real time instead of requiring users to
click the 'Apply Lineitem Identifier' link.

The 'Apply Lineitem Identifier' link has also been removed, since it is
no longer needed.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Add (noop) upgrade script for 2.2.10

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

2.3.8 stub upgrade script

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Support script-based circ in nearest_hold()

The nearest_hold() implementation recently changed to pull in the circ
library ID; however, if circulation runs through scripts, the circ
library on the copy object has been fleshed, and the nearest hold
routine gets very confused.

Check to see if we do, in fact, have an object instead of a plain
scalar, and assign the value to a placeholder variable accordingly.

Thanks to Jeff Godin for his great assistance on debugging this!

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm

(Just whitespace. Resolved by hand.  --miker)

LP 1177388 'Add to Po' Honors default copy count

Create the requested number of copies for lineitems added to purchase
orders whose provider has a non-zero value for 'default copy count'.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Prevent uninit var warnings in Search/Biblio.pm

The logger messages in Search/Biblio.pm throw _many_ uninitialized
variable warnings. With a little care, we can prevent those warnings and
return our attention to more important log messages.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>

Fixes to MARC batch import docs

Added needed subheadings to the MARC batch update docs. Also shortened
line lengths and modified intro that focused on 2.2 new features.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Post-2.5-m1 whitespace fixup

This is an attempt at an automated whitespace cleanup for the m1
milestone of version 2.5.  It was created using the following
commands (run from Open-ILS/src/perlmods/lib):

find . -name "*.pm" \
-exec sh -c 'sed "/<</s/\t/    /g" < {} \
| expand -t 4 > {}.fixed ; \
cp --no-preserve=mode,ownership {}.fixed {}; \
rm {}.fixed' \;

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>

Repair fine generator memory leak

Calling "next" from within a "try" block results in a memory leak,
presumably because "try" is a tangled nest of subs and evals.
Replacing the "try" with a good ol' "eval" avoids the leak.

This can be reproduced with the following:

---------
use Error qw/:try/;

foreach (0..200000) {
    try {
        next;
    } catch Error with {
    };
}
---------

This particular leak in the fine generator is onerous when the fine
generator is run often (e.g. every 15 mins), which means circs that
have already been processed for the day are re-analzyed over and over,
causing the code to continue early (next) to the next loop iteration
for large numbers of circs.  It also happens when a circs are skipped
because they have no fine interval, rate, or max fine.

You know this is happening because you will see something like this in
the storage stderr log:

Exiting eval via next at
/usr/local/share/perl/5.10.1/OpenILS/Application/Storage/Publisher/action.pm
line 820.

Exiting subroutine via next at
/usr/local/share/perl/5.10.1/OpenILS/Application/Storage/Publisher/action.pm
line 820.

This patch does not avoid the "exiting eval via next" warning, since
we're still next'ing out of the eval.  It just avoids the memory leak
(and the "Exiting subroutine" warning).  More extensive refactoring is
needed to to completely remove the second warning.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Use the centralized initialization method for QP

QueryParser maintains an effective singleton for internal configuration of
the driver in order to avoid going to the database on every search request
to gather configuration parameters.  There is also a centralized sub that
has the task of properly configuring said singleton.  Previous to this commit
we were not using that centralized initializer in one case, and that case
happened to be the most important initialization of QP in all of Evergreen.
The fallout from that was that some configuration was not being gathered
and passed to QueryParser, resulting in incorrect search SQL being generated.

This is rectified by using the centralized initializer everywhere that it
is needed and can be used -- and particularly in the effected case.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Search clicked /and/ preceding sf values

When looking for authority records to control a bib field, we currently
search using exactly, and only, the subfield that was clicked.  This
commit changes that so that the full field up to and including the clicked
subfield is used in the simple authority heading search we perform to find
the best-match (pivot) authority record.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Edits to documentation

Edits to fit documentation structure.

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>

Documentation for Binary MARC21 Feeds and search enhancements

Documentation for Binary MARC21 Feeds and Bibliographic Search Enhancements added to opac/advanced_features.

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>

Documentation for MARC Import Remove Fields

MARC Import Remove Field documentation added to docs/admin

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>

Stamping upgrade script for making state not required

Signed-off-by: Ben Shum <bshum@biblio.org>

LP1079041 - making state not required (continued)

The last commit did not add the default YAOUS to the seed data. Also, some
wording tweaks to bring the content in line with the existing entries for
consistency.

Signed-off-by: Ben Shum <bshum@biblio.org>

Make the "state" field in registration a togglable YAOUS

Some countries do not use "State" therefore we need to create
a YAOUS to make it non-required/displaying.  This also requires
that we no longer force a "not null" on state in actor.usr_address.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>

Stamping upgrade script for purge circs fixes

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Add srfsh script to call action.purge_circulations().

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Return count purged

Because postgres dislikes functions that don't return.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Fix rentention typo

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Purge Circulations: Unwrapped Upgrade Script

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Purge Circulations: Allow global age as forced min

This allows a library to keep all circs in the last Y interval, regardless
of user settings that may otherwise cause an earlier purging.

Another global flag that defaults to off controls this behavior.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Purge Circulations: Remove extra delete loop

A trigger on action.circulation purges upwards through the circ chain. Thus
we don't need to do the loop ourselves.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Purge Circulations: Better selection logic

This attempts two things:

1 - Keep the number of circs the library wants based on the most recent
    circulations, regardless of user prefs and such.

    This is accomplished by changing the circ fetching query to use a
    window function in a subquery so we can filter on it easily.

    This also allowed removal of the purge position counter.

2 - Allow removal of circs that are between kept circs if they meet all
    other removal criteria.

    This is accomplished by using CONTINUE instead of EXIT in the loop.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Purge Circulations: Support last xact_finished use

Based on a new (off by default) global flag change between the xact_finish
on the last circ in the chain and the most recent one.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Purge Circulations: Skip partially complete chains

Billings in earlier portions of the chain may leave them open. Thus, look
for any circulations in the chain with a null xact_finish.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Circ Chain Functions should take BIGINTs

Because INTEGER isn't suitable for circ IDs.

This only requires editing the input definitions.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Stamping upgrade script for purge holds functionality

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Update the purge_holds.txt release notes.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Add table, view and trigger for "aging" hold requests on delete.

This creates the action.aged_hold_request table, the
action.all_hold_request view, the action.age_hold_on_delete
function, and the action_hold_request_aging_tgr on action.hold_request.

Add fieldmapper entries for action.all_hold_request view and
action.aged_hold_request table.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Add a purge_holds.srfsh script so it can be run from cron.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Fix typo in purge holds function

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Release notes for Purge Holds routine

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Fix seed values and upgrade script

enabled and label were out of order.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Make user visible holds based on fill/cancel time

Instead of request time. That way holds don't vanish after filling when
keeping history was turned on after hold placement.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Add purge_holds DB function

This allows removing of holds based on patron and library preferences.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

We still don't support Z30.59 or Z39.59

Actually, just fix a few typos :)

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Stamping upgrade script for batch z39.50 search, match, overlay

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Z39.50 Batch Search/Overlay : SQL / IDL

Copied some missing pieces from the upgrade scripts into the seed schema
/ data files.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Z39.50 Batch Search/Overlay Release Notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Z39.50 Batch Search/Overlay TPAC my-list entry point

Similar to the staff client bucket UI, this adds a button which allows
staff to access the batch Z39 search-and-queue operation directly from
the TPAC my-lists UI.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Z39.50 Batch Search/Overlay Z-Index Admin UI

Admin -> Server Admin -> Z-Index Field Maps

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Z39.50 Batch Search/Overlay minor IDL repairs

Added some missing reporter:selector attributes and repaired an invalid
link class.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Z39.50 Batch Search/Overlay Z-Search UI

Adds a new "Find Z39.50 Matches" option to Cataloging -> Manage Record
Buckets.  When selected, the user chooses the Z39 fields, the Z39
sources, the destination queue, and the queue match set.  The user then
submits the search.  Basic progress info is reported to the user.
Once complete, the user can open the destination queue, from which
regular vandelay import, etc. actions may be performed on the newly
found records.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Z39.50 Batch Search/Overlay Seed Data

Org unit setting seed data:
* cat.z3950.batch.max_parallel
* cat.z3950.batch.max_parallel

Stock / sample seed data entries for config.z3950_index_field_map, with
room added for future stock data.

Vandelay bib attribute seed data for Z39.50 source (901z), which is
stamped during the Z39.50 batch search-and-queue operation.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Vandelay : sort queued records by matches

Sort queued records by their matches (based on the first match) so that
like records are grouped in the queue interface.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Vandelay record bucket-limited matching

Provides the option to link record buckets to vandelay queues.  When
linked, vandelay imports where a match set is specified will limit
matches to records within the selected bucket.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Z39.50 Batch Search/Overlay API

New API for performing Z39.50 queries for a set of bib records across a
set of Z39 sources.  Searches are performed in parallel (up to a
configurable maximum number of active searches and maximum results) and
results are stored in a vandelay MARC Import/Export queue.

Search fields and values are determined by Z39 index field maps.  At
search time, the caller provides a set of field maps to use for the
search. Search values for each bib record are found by following the
index maps to the indexed values in metabib.*_field_entry or
metabib.record_attr.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Z39.50 Batch Search/Overlay : SQL / IDL

 * DB table for Z39.50 index field maps, which link Z39 search fields to
   indexed bib data via metabib fields and record attributes (svf)

 * Seed data for Z39.50 batch search org unit settings
  ** cat.z3950.batch.max_parallel
  ** cat.z3950.batch.max_results

 * Stock seed data for config.z3950_index_field_map entries

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Repair SIP start/end list ranges

SIP supports paging of certain lists (holds, fines, etc.) by allowing
the SIP client to provide start and end points for lists.  This patch
repairs how Evgreen extracts the list ranges from arrays.

When using Perl array ranges, the array variable should be accessed via
'@' and not '$'.  Prior to this change, all ranged lists resulted in
returning the first item in the list instead of the full range.

This change affects lists of holds, overdues, fines, and charges.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jeff Godin <jgodin@tadl.org>

Make Force/Recall holds always return as nearest

Without even running the hold rules.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm

(Just whitespace conflicts on tab vs space -- repaired by hand.)

TPAC - set autofocus to user input when placing holds in staff client

When placing holds in TPAC via the staff client, the focus had been on the
basic search field above. Change this to have autofocus on the input field
for the hold user by default.

This can potentially save staff from having to perform an extra click to
select the input field. Now they can immediately begin entering the barcode
of the user they plan to create a hold on behalf of.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

SIP renew-all; reset renewal statuses

Reset the list of renewed and unrenewed items for each instance of the
RenewAll transactions.  Otherwise, items from previous transactions will
bleed into the current transaction.

While we're in there, fix a couple of tabs.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

SIP RenewAll

Adds SIP plugin support for SIP message types 65/66 (Renew All).  When
requested, the plugin performs a renewal on all items currently checked
out for the user.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1040147 Return wrong-shelf holds in clearable list

1. Change the staff client "View Shelf-Expired Holds" action label to
"View Clearable Holds".

2.  When "View Clearable Holds" is selected, display both shelf-expired
and wrong-shelf holds.

New API calls:

open-ils.circ.captured_holds.expired_on_shelf_or_wrong_shelf.retrieve
open-ils.circ.captured_holds.id_list.expired_on_shelf_or_wrong_shelf.retrieve

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

change checkbox label in Browse Hold Shelf

from View Shelf-Expired Holds to View Clearable Holds

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

add Current Shelf Library column to xul interfaces

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Include Wrong-Shelf holds in clear-shelf results

Include non-expired, Wrong-Shelf holds in the results list of the "Clear
Shelf-Expired Holds" process.  ("Wrong-Shelf" holds are those whose
pickup lib was changed while the hold was on the holds shelf).  The idea
behind this option is that branches may use the clear-shelf process as a
general shelf management report beyond just holds that have expired.
I.e. tell me everything I need to remove from the shelf.

This change includes a label change for the clear-shelf menu options:

"Clear Shelf-Expired Holds" -> "Clear Holds Shelf"

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Asciidoc edit for My Lists documentation

Change to asciidoc structure in opac/my_lists.txt

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>

Remove unnecessary TPAC toggle strings on staff client splash page

Accidentally reintroduced with commit ad86ef5d3c689c9b514cc09bfc93e7f451461dc7,
we can skip adding back TPAC toggle strings to the index.xhtml file since that
toggle action has been removed from the page.

Signed-off-by: Ben Shum <bshum@biblio.org>

Acq: Be fuzzy about case when retrieving EDI documents

The edi_fetcher relies on a routine in OpenILS::Acq::EDI to, among
other things, try to avoid fetching the same EDI document multiple times
when many rows in acq.edi_account refer to the same host and login
credentials.

Since in practice most vendors seem to run FTP servers for EDI on
Windows, not UNIX, and pathnames are therefore case-insensitive, that
test for other occurrences ought also to be case-insensitive.

If I were to look at this as a purist, I could argue that vendor servers
might sometimes by run on UNIX, and that for some reason it is possible
that different vendor-to-buyer EDI documents (order responses or
invoices) could have pathnames that differ only in the case of some
characters.  But that seems wildly unlikely.  If anyone does take this
possibility seriously, perhaps acq.edi_account needs a Boolean column to
indicate the remote host's case [in]sensitivity.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

lp1183525 Edit Item Attributes pop-up dimensions

Took Steven Chan's patch from the launchpad bug and added "stickiness" to the
window dimensions.  So by default, it'll come up maximized, but once adjusted,
it will stay adjusted.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

"Return to record" after submission of phone number on SMS page fixed

Before this, it only worked on the page load *before* form submission.
There's probably a more elegant solution that doesn't involve keeping
track of URIs, but this seems to me to work.

Problem relayed to me by Dale Rigney at Equinox, who helped reproduce
the issue and test a fix.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

fix copy/paste error

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Allow translating more strings in xul-files.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Add the copy number to the list of data being pulled for access by the TPAC.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Allow translating the staff client tab names

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Fix Latin-1 encoding that broke doc output

asciidoc only expects and can only handle utf-8 encoding :)

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Improve the db-seed-i18n.py -script to actually grab all strings.

Previously the script could only handle oils_i18n_gettext -markers
if the marker and it's parameters were all on one line.

Now it also correctly parses the postgres E'' escaped strings, and
removes sql string concatenations.

Also adds test cases.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Add new POT files to git so "make newpo" will work

Running "make newpo" errored out because the po subdirectories didn't
exist for the newly added POT files. This will also enable translators
to access the strings in Launchpad.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Add missing dojo nls files to the i18n toolchain, and fix one of the files so they be built.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>