webstaff: remove Edit Offset from actions

and fix typo for offset in the subscriptions area

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

webstaff: serials Receiving Template selector

under Manage Subscriptions

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

webstaff: implement creating scap from a pattern template

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: Link MFHD action

under Manage Subscriptions

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

webstaff: Clone Subscription action

under Manage Subscriptions

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

webstaff: implement fetcher for pattern templates

The method open-ils.serial.pattern_template.retrieve.at
takes a org unit ID and returns the set of patterns visible
to it.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: add admin interface for managing serial pattern templates

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: teach egEditFmRecord how to use custom template for a field

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: implement saving pattern as a template

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: fix problem with IDL definition for spt

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: new egShareDepthSelector directive

This directive implements a selector for OU-sharing depths; depths
and names come from the actor.org_unit_type table. If there are
multiple types defined for a given depth, the display value in
the selector is the concatenation of their names.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: new table to store shared prediction pattern codes

serial.pattern_template is a new table for establishing a
shared list of predication pattern codes. Pattern templates
have an OU owner and share depth; CUD has a new ADMIN_SERIAL_PATTERN_TEMPLATE
permission.

The share depth is meant to be advisory, so there's no pcrud
permission tied to retrieving serial.pattern_template rows.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: improve initialization from pattern code

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: clicking outside pattern modal no longer closes it

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: implement action to cancel creating new pattern

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: implement prediction deletion action

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: implement adding a new prediction

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: fix creating PredictionPattern from null pattern code

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: finish implementing updating patterns

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: changing pattern now marks form dirty

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: embed serials prediction wizard into modal

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: Serials Admin menu and Serial Templates

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

webstaff: update review pane to display pattern summary

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: add PredictionPattern.compile() method

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: start work on review pane of pattern wizard

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: more work on the regularity UI

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: UI for setting pattern regularity

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: add basic frequency inputs

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: tweak add/remove level buttons on enum pane

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: implement chronology tab

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: finish first pass at enumeration pane

Includes three new directives:

egMonthSelector
egSeasonSelector
egMonthDaySelector

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: start of prediction wizard

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: start list of patterns

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: serials: improvements to updating address bar

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: add subscription selector to prediction manager

This also implement updating the browser URL when a
different subscription is chosen.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: serials: add egSubSelector directive

This directive allows the operator to select the subscription
they want to work on in contexts such as the prediction
manager.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: fix toTypedHash conversion of null dates

... and avoid flashbacks to 1969/1970

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: serials - start egPredictionManager directive

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: add subscription ID to serials routes

Teach the serials app to recognize the subscription ID if supplied
in the path. The subscription ID is validated against the bib record;
if it doesn't belong to the bib, the path is rewritten to
drop it.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: wrap serials app directives in ng-if

This is meant to reduce running initialization code unnecessarily
when a user goes directly to one of the tabs

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: rename subscription management tab

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: ensure grid in egSerialsManager is consistently initialized

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: adjust whitespace a bit

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: reorganize serials app layout

This patch lays the groundwork for breaking out each tab
in the main page into a separate directive, and establishes
the directive for the subscription manager. Note that at present
stuff under serials/directives is expected to be firmly bound
with other aspects of the over serials app, including its
services.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: Additional Routing in serials grid

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

webstaff: changes to subscription management form

- adjust layout and styling to be a bit more compact
- add cancel/reset button
- save button now active only when form is dirty

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: add subscription management pane

TODO: more precise dirty field detection
TODO: formatting of form
TODO: use something other than buttons to add distributions and streams?

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: teach egIDL a new fieldmapper object representation

This is the beginning of work to teach egIDL how to
represent FM objects in a way that more easily can be bound
to Angular input widgets, given the verbosity of getterSetter
and the fact that some widgest like uib-datepicker-popup don't
support getterSetter.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1685232: fix egCore.pcrud.apply()

This patch fixes egCore.pcrud.apply() method so that it
behaves as intended (i.e., process an array of fieldmapper
objects and either creates, updates, or deletes them based
on the value of the isnew(), ischanged(), and isdeleted()
flags).

To test
-------
Currently no code uses this method (but some will soon), but
it can be tested by writing some code like this:

   var notes = [];
   var n1 = new egCore.idl.aun();
   n1.usr(userid); // etc.
   n1.isnew(true);
   notes.push(n1);
   var n2 = new egCore.idl.aun();
   n2.usr(userid); // etc.
   n2.isnew(true);
   notes.push(n1);

   egCore.pcrud.apply(notes).then(...

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: typo fix

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: fix sorting in serials distribution/stream grid

Literal attribute names need to be in double quotes when
using orderByFilter.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: dist/streams grid now handles partial subs

If a subscription has no distributions, or if a distribution
has no streams, a partially-filled-in row is now displayed
in the grid.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: create serials distribution/stream grid

TODO: move most of this to a separate directive

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: start core serials services

Routines to fetch a subscription/dist/stream tree for a bib
and produced a flattened version of it for the distribution/stream
grid.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: tweak labels of serials management tabs

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: chop out "/manage/" from serials routes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: skeleton of the serials management page app

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1682609: upgrade to angular-ui-bootstrap 1.3.3

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff serials: add placeholder link to serials app

This is just a placeholder to get to the serials management
page from the record details page; navigation will be sorted
out later.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1670425: RTL improvements to new advanced search limiter block

Add some extra divs to the block with associated styling so that the advanced
search limiter block displays correctly for right-to-left languages. Also, add
some CSS to the rtl stylesheet so that padding and margins are added to the
correct side of blocks.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1670425: Adjust the release notes entry to reflect changes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1670425: New responsive design for advanced search limiters block

When the screen is 600px or smaller, we continue to only display the 'x filters
applied' link as we did with the sidebar display because displaying limiters
pushes the results too far down the screen. Clicking the link toggles the
display of the limiters.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1670425: Moving display of advanced search limiters on search results page

Moves the new 2.12 advanced search filters block out of the sidebar and
along the top of the screen so that the user can see limiters along with their
other search terms.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1665933: describe the new -x option when running -h

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP 1665933: Skip XUL staff client build in make_release.

Add a -x option to skip building the XulRunner staff clients.  This is
useful for making custom tarballs for local installation where you
will build the staff client on the server.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1680624 Remove bower packaging bits

We no longer need to install bower as part of the Makefile.install
targets or worry about the bower_components cache directory when
generating a release. Rip out those references.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1680624 angular-ui-bootstrap stopped shipping minified files

Per https://github.com/angular-ui/bootstrap/issues/5522 upstream
feels users should minimize the files themselves.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1680624 Consolidate package dependencies into package.json

npm already enables us to designate dependencies in package.json,
and projects have increasingly consolidated what bower used to be
used for in package.json. We can do this with an npm-compatible version of
angular-order-object-by from github.

There are a few other tweaks to npm vs bower file locations, such as
ng-toast instead of ngtoast for ngToast.

Pin to AngularJS 1.5.x for now

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1680312: Fix IDs for 950.data.seed-values.sql for i18n

For oils_i18n_gettext purposes, fix the IDs being fed so that we do not
get duplicates when generating the translation files for 950.data.seed-values

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

LP#1680312 Ensure oils_i18n_gettext keys are unique

To avoid inadvertent introduction of duplicate oils_18n_gettext() keys
in the data seed SQL, which will then prevent translated strings from
being able to be loaded, add a regression test.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1677416: unbreak use of egOrgSelector by egEditFmRecord

This patch fixes a regression where attempting to change
the value of an egOrgSelector embedded in an egEditFmRecord
would result in errors like this:

Error: [$compile:nonassign] http://errors.angularjs.org/1.5.11/$compile/nonassign?p0=rec_orgs%5Bfield.name%5D()&p1=selected&p2=egOrgSelector

To test
-------
[1] Open the MARC Tag Tables admin interface in the web
    staff client and edit an existing entry. Note that
    changing the selected OU will result in there being
    no change and error messages appearing in the browser
    JavaScript console.
[2] Apply the patch and repeat step 1.
[3] Verify that no errors are logged.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1167541: Use Patron home org for pickup lib instead of staff's

When staff are placing a hold for a patron, we should use the patron's
preferred pickup location, and failing that, their home library rather
than the staff's home library.

To test
-------
[1] In the web staff client, search for a title to place
    a hold request on, using a patron record
    whose home library is different from the home library of
    the staff member you are logged in as.
[2] Note that the pickup location defaults to the staff
    account's home library.
[3] Apply the patch and repeat step #1. This time, the default
    pickup library should be the home library of the patron.
[4] Set a preferred pickup location for the patron, then
    repeat step #1. This time, the default pickup library
    should be the preferred pickup location just set.
[5] Repeat steps #1-#4 using the XUL staff client; note that
    for step #3, it will be necessary to rebuild the client.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Adding more information about closed dates editor

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Install a modern Node.js

Rather than directing people to use an ancient version of Node.js from source,
point at the LTS version of the downloadable package (if necessary).

Signed-off-by: Dan Scott <dan@coffeecode.net>

LP#1599634: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1599634: follow-ups

Squashed patch containing follows-ups written by Chris Sharp
and Galen Charlton:

*  When running the upgrade script, the DROP VIEW statement resulted in an
error since the view did not already exist.  You could add IF EXISTS, but
CREATE OR REPLACE VIEW is sufficient.

* Changes the ID column to just pass through
the ID from the source tables, promoted to BIGINT in
some cases.  This has the effect of:

- removing a redundancy, as circ_type already specifies the source table
- making it easier to join this view against the circulation tables when
  writing SQL queries

* Renames the schema upgrade script to better
match conventions.

* Move release notes entry so that it will get picked up

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1599634 Circulation report source to include in-house(non cat), and non cat circ

Added a simple view and supporting IDL. This will allow all the circulation
data to output in the same report.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: blake <blake@mobiusconsortium.org>
Conflicts:
Open-ILS/examples/fm_IDL.xml

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1643998: update list of supported languages

Per translations coordinator Eva Cerniňáková, add ar-JO
and remove fi-FI.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1643998 Docs: Updates needed to languages

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: replacing XUL client docs with Browser client docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Information for system administrators about translations

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Web client no longer has borders around patron name

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Merge branch 'master' of git.evergreen-ils.org:Evergreen

Docs: Updating column picker docs for Web client

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

lp1453205 replaced Target_Pickup_Lib1.jpg

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: adding more to the config.tt2 variable list

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding to the list of config.tt2 variables

Docs: Publish the 2.12 release notes

We've released 2.12, let's integrate the corresponding release
notes into the doc build.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Docs: Use the 2.11 release notes

Update root.txt to point to the 2.11 release notes.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

Resolve a few doc build errors with images

* We need to match the case of images exactly on case-sensitive file systems
* Two dots in a file name confuses the simple-minded PDF build
* Comment out images that we don't actually have yet

Signed-off-by: Dan Scott <dscott@laurentian.ca>

LP#1669868: fix regression that broke building staff client

Looks like AM_CONDITIONAL should not be in if blocks per
https://www.gnu.org/software/automake/manual/html_node/Usage-of-Conditionals.html

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

fix typo that broken generation of es-ES lang.dtd

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - po files

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update server upgrade instructions for 2.12.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update release notes for 2.12.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

2.11.3-2.12.0 schema update script

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1668720: remove browser console noise for OPAC

This patch fixes a case where JavaScript used in the OPAC
attempts to set the value of a #client_tz_id input on all
pages, even though only the login page has such an input.

To test:

[1] Load the OPAC homepage and open the JavaScript console/developer tools.
    Note that there's a "Cannot set property 'value' of null"
    error.
[2] Apply the patch and try again; this time there shouldn't
    be such an error.
[3] Open the login page, and verify, using developer tools,
    that the hidden client_tz_id input does have its value
    set to the client timezone.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP 1669868: Fix make check for all distros.

Chris Sharp found that make check was failing on Ubuntu 14.04 and 16.04.

I borrowed a few lines from the OpenSRF configure.ac and modified the
Open-ILS/src/c-apps/tests/Makefile.am to use a more autoconf-oriented
approach that won't lead to unnecessary checks in the install scripts.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1675025: Docs: mention that Vandelay can load MARCXML

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>