Revert "Org unit retrieval cleanup"

This reverts commit 68a4e3b1c8133c9c98503f5d2128e054bf1d2114.

GALILEO uses open-ils.actor.org_tree.slim_hash.retrieve, which was removed in this commit
without considering that effect.  This revert attempts to restore that functionality.

Conflicts:

Open-ILS/src/perlmods/lib/OpenILS/Application/Collections.pm

disabling visibility of hold shelf expiration date

Remove "Claims Never Checked Out" in Items Out summary

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

adding rewrite rules for gapines.org

Default and force patrons to TPac

May be incomplete, but better than nothing.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Disable JSPac in staff client

This includes removing the toggle option for TPac usage.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:

Open-ILS/web/opac/locale/en-US/lang.dtd

adding in gmcharlt's fix for trailing TCN spaces

adding new macros to listed ones

Adding GPLS Helpdesk link to Staff Client portal page and correcting a small typo

re-adding STAFF_MIDDLENAME, PATRON_MIDDLENAME, PATRON_EXPIRE_DATE, and PATRON_EXPIRE_DATE_YMD to rel_2_3_4

adding a hyperlink to the item status interface to allow retrieval of hold patron

Revert "Use my_asv here.. surveys pertinent to the workstation library.. in case survey usage ever takes off.  Should probably move some of this to the middle layer"

This reverts commit 54d45c37d91c78cffa00ca3ff0f6298261d548b2.

adding custom css to remove display of patron credits

adding file that returns circ mod view to normal

adding mrpeters' awesome favicon

Changing default hold error messages.

removing hold/circ history view for patrons until we can review policy concerns

adding PINES help links

updating the username/password hints for the opac

improving the default hold message for range-protected items

Enabling the display of 856 field URLs for related resources

Password Length Helpers

This branch provides length helpers when patrons are setting or resetting
passwords.

This assumes the default 7 characters, 1 number requirement that comes stock.
You would need to change the hard coded strings if you use a different password
requirement regex in Library Settings Editor.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>

Pulls the Copy Notes for the records, shows in the table, introduces a new style

Signed-off-by: edoceo <code@edoceo.com>

Remove the hardcoded width of locg dropdown

The hard coded 12em width causes longer library names to be cut
off.  This removes that restriction.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>

removing journal title and bib call number from query type selector dropdown

adding newly designed PINES logos

removing bib level advanced search filter

adding "Georgia PINES" to the title

adding footer and topnav links and logo

attempt to sort libraries by system in tpac results

Includes tsbere's reccomendations to change Record.pm because
it overrides th sorting in AppUtils.pm

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Bumping version numbers, adding Upgrade Script and Changelog

Signed-off-by: Bill Erickson <berick@esilibrary.com>

2.3.5 Translations Import

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Setting OpenILS.pm VERSION 2.0306

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Prevent compiler warning about unused numtype var

There was a dangling variable left around that was making noise in the
compiler. Credit to Jeff Godin for the heads-up.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Address SQL injection vulnerability in SQL ORM layer

If the user-supplied value and the db column are both numbers
(jsonObject->type == JSON_NUMBER, get_primitive(field) == "number") then
don't quote. Otherwise, quote.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

TPAC bucket item retrieval operates in streaming mode

TPAC bucket item retreive fleshes bib records with large blobs of MARC
data.  When a bucket contains a few thousand items, the size of the
data passed around in atomic retreival mode will exceed the typical jabber
max stanza size and result in a failure.  Retrieve the records in
streaming mode instead.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Repair an issue in search filter group UI about filtering on owner OU

What was intended to be a filter against filter groups' owner field was
instead turned into a filter on filter group ID.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

stamping upgrade script for authority validation fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Avoid problems when auth recs are missing the 901c

Fixed the authority.normalize_heading function to better handle
INT's when there is no 901 present. Now we look for the best-fit
control set instead of throwing a db-level error.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP 1160522 2.3 tpac search modifier query append

Append search modifiers (e.g. limit to available) to the end of the
tpac search query to avoid SQL generation issues with 2.3 series
query parser.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP 1126545 repair staff 'return to results' tpac link

Strip the extra "/" from the URL created by the "return to results"
button in the staff client TPAC view.  Havin the extra "/" in place
prevents the next/previous links from functioning.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Allow access to public hold notes via hold "blob"

If a hold note is marked as "public", it seems reasonable that it
should be visible to anyone who can see that hold, regardless of
who created the note.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>

Fix reversed logic for hold "blob" notes

Hold notes (at least at the data level) allow for both staff and
"private" notes to be attached. This code intended to show "private"
notes to the hold owner and staff notes to staff, but had the logic
reversed.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>

tpac : honor page locale in record detail copy grid

The query used to load the record detail copy grid now uses the same
locale value set as the default for all cstore-editor calls.  This
solves the issue where copy location names, statuses, etc. are not
properly translated.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

More authority fixed-field cleanup

Even with the efforts by many to add and harmonize the authority fixed-field
setup, and maintain functionality, there were some missing bits.  This commit
should take care of those by realigning the remaining field names and allwowing
those fields to be saved properly.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP 1134331 Back-port 2.2.3 and 2.2.4 upgrade scripts

Sites upgrading from versions < 2.2.4 may need these.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP 1150458 DB upgrade stamping

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Changed the way authority tags were being pulled to specifically use an aggregate array.

There appears to have been a change in postgres at some point between 9.0 and 9.1
to the aggregate method. Because of this, postgres was not returning the proper
results when pulling tags for authorities. This change will force postgres to do
a proper aggregate array call and return the correct results.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

DB upgrade script for 2.2.7

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

2.3.4 -> 2.3.5 DB upgrade script

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

2.3.5 Translations repair Finnish Last-Translator

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

2.3.5 Translations newpot

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

2.3.5 Translations Import

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Placeholder DB upgrade for 2.3.4

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Placeholder DB upgrade for 2.2.6

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP 1155611 - prevent unnecessary load of fm_IDL.xml

Ensure fm_IDL.xml is loaded only when IDL2js has not been loaded.

Modified for 2.3 and before to avoid using Object.keys(), which is not
supported in all browsers, but is needed by JSPAC.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Update make_release script for Linux 64 building

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Add 64 bit Linux Client building

Also re-labels most of the 32 bit client as such. The update channel was
left as just "lin" instead of "lin32" for compatibility reasons.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

SIP re-login fetches correct auth session

After a login session expires and the SIP server logs in again to
acquire a new authtoken, be sure to use the new authtoken when fetching
the new session object.  Otherwise, the login_session is left undef and
you may see errors like this when checking in items:

Can't call method "ws_ou" on an undefined value at
/usr/local/share/perl/5.10.1/OpenILS/SIP/Transaction/Checkin.pm line 77.

Incidentally, the checkin code is the only code that references
$sip_handler->{login_session}.  And the problem listed above only occurs
when the login session expires just prior to a checkin call.  In any
other scenario, the login_session would ultimately get repaired.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Fix some typos

Except for the typo in staff client's multiclass_search_help.html,
the rest are in comments.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Fix detection of empty Syndetics AC data elements

Due to a change in how the vendor responds to requests for data
elements which are not present for a requested title, we need to
change how we detect "empty" data elements in the "data_exists"
function.

First, we check for the new "No Data Available" title element, then
we check for the previously-used value of "error".

This change resolves the symptom where the catalog would display
tabs for "Author Notes", "Excerpt", "Table of Contents", on every
record in the catalog, even when clicking each tab would show that
the content was not present / available.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

fix typo preventing transit abort error dialogs

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP1054322 - libparent-perl not needed for Ubuntu Precise

The newer version of Perl 5.14 which comes with Ubuntu Precise already
contains the contents of libparent-perl, which is now an obsolete package.

Remove this dependency from the extra debs installed for Debian and Ubuntu
but then add to the extras for Debian Squeeze and create a new extras just
for Ubuntu Lucid so that it continues to be installed on those systems and
not on Ubuntu Precise.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP1103068 - Show titles and authors for pre-cat items

As noted in LP1103068, TPAC does not currently show anything when viewing a
pre-cataloged item in the my account summary of items checked out.

If the call number is -1 (pre-cat), then show the dummy title and dummy author
values, which fields are hopefully relevant as long as staff were good to put
something meaningful in those during creation of the pre-cat.

Also, wrap the title in a check for attrs.title.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Michael Peters <mpeters@emeralddata.net>

LP1116258 - Hide download circ history if none to be found

As noted in LP1116258, if there is no circ history for a patron, but they
click on the Download CSV button, it leads them to unhappy server errors.

So, hide the Download CSV button unless the number of circs > 0.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>

LP#791881: make it possible to save copy location translations

TranslatorPopup requires that the i18n fieldmapper class be loaded.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Fix spelling error of "Successfully" in ils_events.xml

LP#1155495 "card transaction was processed successfuly" is
spelled incorrectly.   This corrects that misspelling.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Use a consistent spelling of "Pickup" throughout the code

LP#1155494 In myopac/holds.tt2 the text "PickUp Location" is
used, and everywhere else it's "Pickup Location".
Pick one spelling and stick to it.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Wrap upgrade script for use ID as TCN value fix

Signed-off-by: Dan Scott <dscott@laurentian.ca>

LP#1155329: better enforce cat.bib.use_id_for_tcn

Restore previous behavior to the maintain_901() trigger
function so that bib records that are loaded without
explicitly setting the TCN have it set to the bib ID
when the cat.bib.use_id_for_tcn global flag is set, rather
than 'AUTOGENERATED-xxx'.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Serials: printing routing slips fails with Javascript error

The symptom (an error in the Javascript console about dijit.form.Button
and an empty page for routing slips that you try to print at batch
recieve) may or may not be affected by whether you're in a production
environment with the pre-built dojo 1.3.3 package installed or a
development environment without it.

This simple fix makes the problem go away in any case.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Fix holding lib for certain distribution svrs

On a serial virtual record (svr), the holding lib is expected to be
just an ID.  In one logic branch, Search/Serial.pm was attaching the
entire aou object, and we should instead attach just the ID of this
object.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Stamping upgrade for inactive barcode retrieval

Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/sql/Pg/002.schema.config.sql

LP#1154235 Allow inactive patron barcode to be loaded

This addresses LP#1154235 by modifying the evergreen.get_barcodes
function to allow users to retrieve patrons in barcode retrieve
who have inactive barcodes.

This returns to functionality in versions prior to around 2.2.x
series.

End result is staff receiving an alert that the patron was
accessed with an invalid barcode.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Ben Shum <bshum@biblio.org>

Escape barcode completion button labels

Some characters piss off the XML parser.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Show OPAC-invisible copies in TPAC in staff context

We were not calling the staff variation of the copy count method; thus,
the record details template was skipping the copy table in the event
that all copies for a given record were marked as OPAC-invisible via
either copy visibility or shelving location visibility.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>

Don't populate the MFHD menu with distributions

If a distribution has no legacy record, it shouldn't get a menu
entry in the MFHD menus. A magic id of '-1' is used to indicate
this case, so we need to check for that when populating
mfhdDetails via the TPAC.

Also, entryNum must be an int, not a string, because it is
incremented prior to display. Removing the quotes solves this
display issue.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>

extract PO name from picklist upload

If a PO name is encoded in a lineitem (via provider attribute
definition), extract that PO name when creating a new purchase order
from lineitems that were previously only linked to a selection list.
This allows staff to create selection lists first, then orders second,
while retaining the encoded purchase order name.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade for serials harmonization

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix divergence of stock serials schema and upgraded schema

And additionally make a function used in a constraint on
serial.issuance.holding_code a little bit smarter.

These issues were reported to me by Galen Charlton.

The upgrade script included here will set serial.issuance.holding_code
to NULL in cases where the value doesn't validate, but in those cases
there is no part of Evergreen that could have made use of the data
anyway, and the data is just plain bad.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Exclude copies that have been deleted from showing up on the browse holds shelf list.

If an item had been deleted while it had a status of On Holds Shelf, it would permanently show up on
the browse holds list. This will exclude deleted copies from the results.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for null SVF attribute value fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1116509: prevent null SVF attribute value from breaking record import

Fix problem where a record could fail to be staged for import
with the following error:

ERROR: query string argument of EXECUTE is null
CONTEXT: PL/pgSQL function "extract_rec_attrs" line 72 at EXECUTE statement
SQL function "extract_rec_attrs" statement 1

This error would be triggered if at least one SVF attribute has a normalization
function defined that is applied to a null value during record import.

Patch is based on a suggestion by Bob Wicksall.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Reify required authority fixed field names

Adam (and Art, by way of Adam's patch) added a goodly pile of fixed
field definitions that were lacking previously.  The change in this
commit simply changes the label of two (008/11 and 008/15) to those
in use by other parts of the code.  In particular, internally, we call
the field holding a thesaurus code value "Subj" and use that name during
ingest of authority records.  Therefore, that should not change.  This
required a subsequent change to the label of another, to SubjUse.

I've included a duplication in the backend-only (probably deprecated)
version of this mapping to allow the front-end labels to work.

Signed-off-by: Mike Rylander <mrylander@gmail.com>

lp1040381: match up Subj and SubjUse fixed labels

Update the labels used in the fixed field editor for
authority records to match OCLC's labels specified at

http://www.oclc.org/support/documentation/worldcat/authorities/authformat/default.htm

This is consistent with commit's e675b854 change to the
OCLC labels, and also fixes a problem where changing the
008/11 and 008/15 was not reflected in the fixed field boxes.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add fixed fields missing from previous configuration, namely for MAP and SER record types.  Incoporate previous changes for AUT record types from 1040381.

Signed-off-by: Adam Bowling <adbowling@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#867691: Authority match sets are not working

Authority match sets are not supported so hide the option for now.
It's confusing having it there.

Signed-off-by: Mark Cooper <markchristophercooper@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Stamping upgrade for LOC z39.50 target seed data

Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/sql/Pg/002.schema.config.sql

Upgrade script for LP#1105225: LOC z39.50 seed data

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1105225: update LOC z39.50 target seed data

This patch updates the seed data from the target list at
http://www.loc.gov/z3950/lcserver.html#addr.  It also changes the
structure attribute for the 'lccn' search attribute to wordlist,
which means that LCCNs can be searched without having to enter
the leading spaces.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1022582: MARC Exporter includes deleted copies in holdings export

Added check to filter out callnumbers/copies if deleted.

Signed-off-by: Mark Cooper <markchristophercooper@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Remove dependency on libreadline5-dev from Debian and Ubuntu.

libreadline5-dev is old and superseded by libreadline-dev.

Also OpenSRF installs libreadline-dev, so we should not have to
install it from Evergreen's Makefile.install.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1086458: move up event listeners in place_hold.js

The preceding two functions need the event listeners to be defined before
use. Move up to prevent errors.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1086458: fix typo

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1086458: add destructor to caption binding

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1086458: add destructor to messagecatalog

Based on patch by Jason Etheridge.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1086458: clean up event listener functions

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

move EventListenerList out of global_util.js

So that we can more easily pull it into main.xul (which we also do here)

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1086458: remove references to windows during cleanup

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1086458: clear util.list lists and trees during cleanup

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>