LP1779158 Import non-matching saved template repair

Fix issue in Vandelay import form templates where saved template name
did not match the form variable name.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1779158 Cache new queues / display active queues

* Only list active (non-complete) queues in the Vandelay queue selector
  combobox.
* Display an alert message when the user attempts to create a queue
  whose name collides with an existing queue for the user.
* Be sure newly created queues are added to the local cache of queues in
  the Vandelay service.
* Remove unused activeQueue list from vandelay.service to avoid having
  to maintain 2 separate queue caches.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1779158 Angular alert dialog component

Similar to the PromptDialogComponent except it displays a simple message
(formatted as 'danger') and the only option available to the user is to
close the dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

lp1779158 Inspect Queue Improvements

- Add "Delete selected" option to Authority Queues
- Change Queuetype to 'authority' from 'auth' when selecting single record to view
in auth record queue.
- Ensure "Imported As" link correctly navigates to Auth record view for Auth Queues

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue-list.component.html
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.html
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.ts

Signed-off-by: Bill Erickson <berickxx@gmail.com>

lp1779158 Vandelay Authority Import Tweaks

- Check for "Auth" string
- Dummy rec.import_items when record is not bib
- Teach resolveQueue() to assume startQueueId unless a queue is selected already

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/import.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/vandelay.service.ts

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1779158 Vandelay UI accessibilty/usability improvements

* Associate <input>'s with their labels in the import and export forms
* Hide the MARC removal groups selector when record type is authority.
* Disable ACQ copy overlay option when record type is authority.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1800481 Vandelay import form templates

Support saving MARC Import form values as named templates.  Values are
stored as (by defualt) workstation settings.  A template may be selected
as the default and templates may be deleted.

Includes release notes update angular vandelay.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1779158 Ang6 Vandelay Release Notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1779158 Ang6 Vandelay UI Port

Port of the MARC Import/Export UI from a Dojo-driven interface to a
Angular(6) interface.

Includes an additional UI called "Recent Imports" which displays
Vandelay session tracker information for both active sessions and those
within the selected time frame.  Active sessions are updated regularly
to display progress to the user.

Includes grid persist key workstation settings.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1806087 Metarecord holds formats/lang selectors

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1806087 Fix place hold title link URLs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1806087 Browse entry display/facets; holds improvements

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1806087 Clear facet filters on new term search

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1806087 Catalog nav link thinkos

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1806087 Grouped results jump to detail on single rec

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1806087 Group formats and editions (WIP)

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1806087 Group formats and editions (WIP)

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1806087 MARC search treat empty subfield as wildcard

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1806087 Disable selection on catalog copy grid

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1806087 Option to disable grid row selection behavior

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806087 Record detail 'View in Catalog' button

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806087 Disable holds patron search button pending dev

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806087 Search form focus fixes

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806087 Fix Ang search->catalog link; add experimental link

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806087 View Basket URL fix

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806087 Search form bg color

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806087 Browse/search form work continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806087 Catalog pub date filter

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806087 More browse/search form work

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806087 Move browse to tab; context segregation

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806087 Catalog --prod build fix

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806087 Catalog tabbed layout

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806087 minor repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806087 Catalog marc search; formatting

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806087 Catalog org settings speed improvement

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806087 Angular catalog browse UI + API

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806087 Angular staff catalog phase II.

* Record detail tabs redirect to AngJS catalog where needed.
* Initial holds placement UI.
* Record baskets, actions, and UI.
* Ported MonographParts tab to Angular
* Set default catalog tab

LP1765179 - fix issue with pending/staged user reg

After completing a staged user registration, the controller
in regctl.js was refreshing to the same route, and
trying to fetch the same staged user, but never finding it
as it was no longer staged/pending. This addresses that bug
and adds a bChannel refresh to the pending grid, so once
the user is registered in the child tab, it closes the tab and
the pending user grid is updated.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

docs: LP1258628: screenshots & updates to actiontriggers.adoc

Added a handful of screenshots; added language for Message Center definitions, and pulled in language about testing action triggers from this document: http://docs.evergreen-ils.org/dev/_creating_action_triggers.html

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1782652: Make template dropdown larger in Volume/Copy Editor

To test:
1) Open an item in the volume/copy editor.
2) Go to the Copy Templates tab. Note the spacing of the template bar.
3) Create a few templates.  Give them names of 30 characters or more.
4) Go back to the Edit tab and select one of your new templates.  Note
that after you have selected it, the name of your template does not fit
in the dropdown box, and is cut off at the end.
5) Apply this commit.
6) Go to the Copy Templates tab again.  Note that the spacing of the
template bar has not changed.
7) Go to the Edit tab.  Note that the template dropdown has changed
to be much larger.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Janet Schrader <jschrader@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1806968 Stamping SQL upgrade: Vand. session tracker fixes

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806968 Teach Vandelay to pass correct auth tracker type

Pass the correct value ('authority') when creating a Vandelay session
tracker entry for authority records.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>

LP#1806968 Vand ses. tracker upgrade SQL additions

Force the default value to show in the DB as 'bib'::text instead of
'bib'::vandelay.bib_queue_queue_type, which might be confusing.

Removed some stray SQL from the script.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>

LP#1806968 Vandelay record_type sql fix

- Change record_type to TEXT rather than an enum, constrained
with the option of "authority" or "bib"

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/sql/Pg/012.schema.vandelay.sql
new file:   Open-ILS/src/sql/Pg/upgrade/XXXX.schema.vandelay-record-type-fix.sql

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>

LP1807523: Adding some randomness to DOM ID generation

Ensures ID values across multiple FmEditor instances in a page will not
collide.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1807523: Associating labels and inputs in angular fmeditor

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

Translation updates - newpot

Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1730726: Stamping upgrade script

Signed-off-by: Ben Shum <ben@evergreener.net>

LP 1730726: Add Release Notes for PostgreSQL 10 Support.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

Lp 1730726: Fix lp1501781-unaccent_and_squash.pg for PostgreSQL 9.6

PostgreSQL 9.6 apparently exhibits the same behavior as Postgresql 10
when it comes the OE ligature in the unaccent function.  We modify the
test case to take that into account.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

Lp 1730726: Fix lp1501781-unaccent_and_squash.pg for PostgreSQL 10

PostgreSQL 10 has improvements in the unaccent function used by the
evergreen.unaccent_and_squash function.  The test needs a small
modification to take this into account.  Actual code change from Mike
Rylander with a little typo fix.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

Lp 1730726: Fix a number of PgTap tests for PostgreSQL 10.

A number of tests disabled output via "\set ECHO".  In PostgreSQL 10,
the lack of a value in \set is an error.  We change these lines to
"\set ECHO none".

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

Lp 1730726: Basic Patch to build the database with PostgreSQL 10.

* Modify the evergreen.org_top() function, with code from Galen
  Charlton, to be non-set returning.

* Modify Open-ILS/src/support-scripts/eg_db_config.in to not strip the
  period from PostgreSQL version numbers and to use the first two
  components when checking for supported PostgreSQL versions.

* Add link from Open-ILS/src/sql/Pg/000.english.pg94.fts-config.sql
  to Open-ILS/src/sql/Pg/000.english.pg10.fts-config.sql.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1793585: Add Release Notes

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1793585: Fix PostgreSQL apt repo source setup

For standalone DB server install, ensure that we are applying the proper
PostgreSQL community apt repo for packages.

DO NOT backport this branch.  There are presently known issues with
Ubuntu 18.04 and email generation from action/trigger and other
interfaces.  We plan to address these before the 3.3 release, but do
not necessarily expect to backport those fixes.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1793585: Change to use MARC::File::XML

Use MARC::File::XML instead of MARC::XML (this is ancient and not used)

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1793585: PGSQL dependency update

The MARC::XML cpan dependency needs to be included as part of the standalone
Postgres server install for Ubuntu 18.04.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1793585: Fix Unescaped left brace in regex Perl error.

Running make check results in the following error on Perl 5.26:

Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\${ <-- HERE EMAIL_SENDER}/ at Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/HoldNotify.pm line 358.

Prior to Ubuntu 18.04 and Perl 5.26, this was a deprecation warning.
This commit fixes the regular expressions in HoldNotify.pm to escape
the left braces to make this error/warning go away.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1793585: Update README to include Bionic references

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1793585: Support Ubuntu 18.04 Bionic Beaver

Changes to Makefile.install to support this version of Ubuntu.

Note: We are using PG9.6 from the PostgreSQL apt source instead of the
standard PG10 version that ships with Ubuntu 18.04. Further testing required
before we switch PG versions so relying on a known working version for now.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jason@sigio.com>

Add Release Notes for Lp 1662535 & Lp 1743783

Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1743783 Web Client Bill Full Detail Display Issues

Fleshes out retrieved data to be able to display the billing
location for both circulation and grocery bills on the full
details page as well as the owning library for circulation bills.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1662535 Patron Bill Grid Columns

1) Adding missing columns, including:

- Call Number
- Owning Library
- Shelving Location
- Last Billing Note
- Last Billing Timestamp
- Last Payment Timestamp
- Last payment Note
- Last Payment Type

2) Corrected path for Type

3) Changed column name for Location to 'Billing Location'
and the former Billing Location to 'Grocery Billing Location' for clarity

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

Docs: Fix screenshot file name

The asciidoc is looking for "My_Lists_dd.png", but the file has a
capitalized extension ".PNG". This commit renames the file to match the
code, since lowercase is our common naming convention.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: LP#1731048: Update json_query documentation for new join syntax

This commit simply adds the text from the related commit message (see
LP#1527731) to the original DocBook file. NOTE: This documentation is
also available on the wiki, and has been updated there as well:

https://wiki.evergreen-ils.org/doku.php?id=documentation:tutorials:json_query

Signed-off-by: Remington Steed <rjs7@calvin.edu>

LP#1807398 marc_stream/oils_header auth repairs

Fixed a few code thinkos in marc stream workstation login support.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@library.in.gov>

LP1807398: Add workstation to marc_stream_importer

In order to work properly with vandelay session
tracking in 3.2+ a workstation is required at login.
This branch adds a workstation option to the importer
and alerts the user if it's missing.

Signed-off-by: Jason Boyer <JBoyer@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

Docs: Followup commit to fix screenshot for My_Lists3.jpg

The previous commit added some new screenshots for My_Lists, but this one
was saved with .JPG extension instead of .jpg so the original file was
retained.

Signed-off-by: Ben Shum <ben@evergreener.net>

docs: update my_lists.adoc for 3.2, with new and updated screenshots

Removed references to Temporary Lists (now subsumed by Baskets) and updated screenshots.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: virtual index definitions

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Infrastructure changes to authority browse

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: bibliographic record merging and overlay

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Batch actions from search

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: LP1783387: update print templates to reflect new name

launchpad 1783387 - update receipt template editor documentation to reflect language change to "print templates" in web client
put both terms in index
updated title to Print (Receipt) Templates

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: LP1488497: Update Org_Unit_Proximity_Adjustments.adoc

Added link to 'best hold selection sort order', per LP1488497

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Update purchase_requests_patron_view.adoc

Added some language to match the work done here https://bugs.launchpad.net/evergreen/+bug/1774277 & to match documentation submitted on PR 62

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Update purchase_requests_management.adoc

Updated to reflect the work EOLI did here https://bugs.launchpad.net/evergreen/+bug/1774277

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Update basic_holds.adoc

Removing reference to XUL

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Update marc_tag_table.adoc

Striking reference to "sprint 2 preview".  Adding location information & screenshots.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Binding Template added to G-binding.adoc

Added a section on how to apply a binding template to a distribution as this is necessary to ensure the binding does not fail. Also updated an instance of "Action" to "Actions".

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1739606: Allow saving Billing History xacts grid

For a web staff eg-grid to save and retrieve its settings, it needs a
unique persist-key. This commit adds one for the Transactions tab grid
under Billing History (on patron record Bills tab, click the History
grid button).

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1746769 - add item tag owner OU to label in volcopy editor

Adding the owner to differentiate item tags with same label
that are owned by different OU.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

Forward-port 3.2.2 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward-port 3.1.8 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1714070 Stamping upgrade script

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

LP#1714070 Parent/guardian field release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

LP#1714070 Patron parent/guardian field

Adds a new dedicated patron parent/guardian field.  This field is
editable in the patron edit interface, displays in the patron summary
side bar on the browser client, and is search-able from the patron
search interface in the browser client.

Adds patron editor "show" and "suggest" library settings.

Also adds a new library setting
'ui.patron.edit.guardian_required_for_juv' ("GUI: Juvenile account
requires parent/guardian").  When this setting is applied, a value
will be required in the patron editor when the juvenile flag is active.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

Docs: Copy alerts documentation

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: removing broken link from circ manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: create autorenewals documentation

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: correcting syntax error in copy location documentation

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Release notes entry for LP#1804038

Also, add a missing contributor.

Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1804038 Fix-ups for older 'clense' functions

Way back when, we switched from a misspelled 'clense_ISO8601' to a
corrected 'cleanse_ISO8601' in OpenSRF.  This function has again moved,
and is now part of OpenILS::Utils::DateTime, and is named
'clean_ISO8601'.  This was done as part of LP bug #1552778.

However, a few stragglers of the misspelling remained, so these were
missed when the big changeover occurred.  This hopefully catches them
all!

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>

Docs: Multilingual search documentation

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Release notes entry for LP#1793154

Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1793154: Cancel Holds from OPAC Record

The name of the grid handler was misspelled
in the holds grid for records in the opac.
Swapping the location of the 'wide' part of
the function name will allow it to match up
with the functions available in the holds
grid module.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Docs: documenting multiple emails in patron editor (LP1755625)

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: release notes for 3.2.2

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding release notes for 3.1.8

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1643709: Stamping upgrade scripts

Include placeholder 1137 for 3.1 version of the SQL function changed
vs. 1138 which contains the one for 3.2 and master and beyond.

Signed-off-by: Ben Shum <ben@evergreener.net>