working/Evergreen.git
6 years agobib marc record index / searching user/berick/el-integrate-circa-3.3
Bill Erickson [Wed, 28 Aug 2019 21:41:39 +0000 (17:41 -0400)]
bib marc record index / searching

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib marc record index / searching
Bill Erickson [Wed, 28 Aug 2019 16:16:17 +0000 (12:16 -0400)]
bib marc record index / searching

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib marc record index
Bill Erickson [Tue, 27 Aug 2019 21:50:47 +0000 (17:50 -0400)]
bib marc record index

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agosupport es proxied path; indexes one at a time
Bill Erickson [Thu, 18 Jul 2019 19:20:13 +0000 (15:20 -0400)]
support es proxied path; indexes one at a time

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agodata sync continued / _id fix
Bill Erickson [Tue, 9 Jul 2019 14:31:04 +0000 (10:31 -0400)]
data sync continued / _id fix

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoworking on data sync
Bill Erickson [Mon, 8 Jul 2019 22:12:16 +0000 (18:12 -0400)]
working on data sync

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agodisabled marc indexer experiment
Bill Erickson [Mon, 8 Jul 2019 14:46:20 +0000 (10:46 -0400)]
disabled marc indexer experiment

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoRemove some TODO comments: done
Bill Erickson [Tue, 2 Jul 2019 20:51:13 +0000 (16:51 -0400)]
Remove some TODO comments: done

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoEL sample config superseded by per-index definitions
Bill Erickson [Fri, 31 May 2019 18:51:50 +0000 (14:51 -0400)]
EL sample config superseded by per-index definitions

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoforce-on ang7 cat for now
Bill Erickson [Tue, 12 Feb 2019 17:40:30 +0000 (17:40 +0000)]
force-on ang7 cat for now

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoAvoid huge index values
Bill Erickson [Tue, 12 Feb 2019 17:02:36 +0000 (17:02 +0000)]
Avoid huge index values

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLog first/last bib ID of each indexed batch
Bill Erickson [Mon, 11 Feb 2019 19:05:01 +0000 (14:05 -0500)]
Log first/last bib ID of each indexed batch

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoIndexer orders by ID for batch consistency
Bill Erickson [Mon, 11 Feb 2019 17:11:10 +0000 (12:11 -0500)]
Indexer orders by ID for batch consistency

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoindexer start-date support
Bill Erickson [Tue, 6 Nov 2018 15:52:59 +0000 (10:52 -0500)]
indexer start-date support

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoES gets child init
Bill Erickson [Tue, 6 Nov 2018 15:20:02 +0000 (10:20 -0500)]
ES gets child init

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agocopy loc/stat filters
Bill Erickson [Tue, 6 Nov 2018 02:21:50 +0000 (21:21 -0500)]
copy loc/stat filters

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agocopy loc/stat filters wip
Bill Erickson [Mon, 5 Nov 2018 22:21:09 +0000 (17:21 -0500)]
copy loc/stat filters wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoGroup searches OR-based; lower kw normalizer
Bill Erickson [Fri, 2 Nov 2018 20:56:37 +0000 (16:56 -0400)]
Group searches OR-based; lower kw normalizer

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoQP comp continued
Bill Erickson [Fri, 2 Nov 2018 18:48:55 +0000 (14:48 -0400)]
QP comp continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoang6 catalog use correct search_format filter
Bill Erickson [Wed, 31 Oct 2018 21:34:07 +0000 (17:34 -0400)]
ang6 catalog use correct search_format filter

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoQP based query compilation
Bill Erickson [Wed, 31 Oct 2018 21:30:43 +0000 (17:30 -0400)]
QP based query compilation

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agosearch_format filter; logging
Bill Erickson [Tue, 30 Oct 2018 15:07:04 +0000 (11:07 -0400)]
search_format filter; logging

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agofacets continued
Bill Erickson [Tue, 30 Oct 2018 14:51:46 +0000 (10:51 -0400)]
facets continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib search api wip
Bill Erickson [Mon, 29 Oct 2018 22:17:01 +0000 (18:17 -0400)]
bib search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib search api wip
Bill Erickson [Mon, 29 Oct 2018 22:02:32 +0000 (18:02 -0400)]
bib search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib search api wip
Bill Erickson [Mon, 29 Oct 2018 22:01:38 +0000 (18:01 -0400)]
bib search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoIndexer improvements, docs, and options
Bill Erickson [Mon, 29 Oct 2018 17:58:27 +0000 (13:58 -0400)]
Indexer improvements, docs, and options

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agofacets, etc.
Bill Erickson [Sat, 27 Oct 2018 14:31:46 +0000 (10:31 -0400)]
facets, etc.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoel conf idl fields, etc.
Bill Erickson [Fri, 26 Oct 2018 18:00:25 +0000 (14:00 -0400)]
el conf idl fields, etc.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agouse existing indexed values; refactoring
Bill Erickson [Fri, 26 Oct 2018 15:43:38 +0000 (11:43 -0400)]
use existing indexed values; refactoring

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agouse existing indexed values
Bill Erickson [Fri, 26 Oct 2018 01:17:43 +0000 (21:17 -0400)]
use existing indexed values

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib-search indexing; search api wip
Bill Erickson [Wed, 24 Oct 2018 21:42:28 +0000 (17:42 -0400)]
bib-search indexing; search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib-search indexing; search api wip
Bill Erickson [Wed, 24 Oct 2018 19:20:53 +0000 (15:20 -0400)]
bib-search indexing; search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib-search indexing; search api wip
Bill Erickson [Wed, 24 Oct 2018 15:37:37 +0000 (11:37 -0400)]
bib-search indexing; search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib-search indexing wip
Bill Erickson [Wed, 24 Oct 2018 14:36:56 +0000 (10:36 -0400)]
bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib-search indexing wip
Bill Erickson [Tue, 23 Oct 2018 22:18:24 +0000 (18:18 -0400)]
bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib-search indexing wip
Bill Erickson [Tue, 23 Oct 2018 14:57:11 +0000 (10:57 -0400)]
bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib-search indexing wip
Bill Erickson [Mon, 22 Oct 2018 23:31:28 +0000 (19:31 -0400)]
bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib-search indexing wip
Bill Erickson [Mon, 22 Oct 2018 21:09:56 +0000 (17:09 -0400)]
bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agojson config for now; index create/delete
Bill Erickson [Mon, 22 Oct 2018 20:46:04 +0000 (16:46 -0400)]
json config for now; index create/delete

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoES/EG SQL
Bill Erickson [Mon, 22 Oct 2018 16:43:55 +0000 (12:43 -0400)]
ES/EG SQL

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP#1836808: add release notes
Galen Charlton [Wed, 31 Jul 2019 18:12:48 +0000 (14:12 -0400)]
LP#1836808: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agolp1836808 add cancel button to merge edit
Mike Risher [Wed, 17 Jul 2019 17:26:34 +0000 (17:26 +0000)]
lp1836808 add cancel button to merge edit

In the merge UI add a button so one can cancel out of editing mode

To test
-------
[1] Apply the patch and create/find a record bucket that has at least
    two records.
[2] In the Record Buckets interface, select two records and invoke
    the Merge Selected Records action.
[3] Select one record as the lead record, then click the Edit button.
[4] Verify that a "Cancel Edit" button is displayed. Make changes to
    the record, then click "Cancel Edit".
[5] Verify that the contents of the record have not changed.
[6] Click the Edit button again; verify that the record is at its
    original state. Make changes, then save them.
[7] Verify that the lead record has been updated.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1825851: stamp schema update
Galen Charlton [Thu, 8 Aug 2019 20:41:14 +0000 (16:41 -0400)]
LP#1825851: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP1825851 Print template admin misc. repairs/improvements
Bill Erickson [Thu, 1 Aug 2019 20:36:31 +0000 (16:36 -0400)]
LP1825851 Print template admin misc. repairs/improvements

1. When cloning a template, be sure the cloned template is available in
   the template selector regardless of whether it would have been given
   the current filters.

2. When cloning, set the 'active' flag explicitly to false so the user
   is forced to manually activate.  This prevent unintentional
   activation on in-process templtes.

3. When cloning, clear the owner value so the user is forced to select
   an owner value.

4. Allow the template editor textaread to expand vertically as the
   template gets longer (i.e. adds more new lines).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP1825851 Print template failure warnings
Bill Erickson [Thu, 1 Aug 2019 20:35:41 +0000 (16:35 -0400)]
LP1825851 Print template failure warnings

Display error toasts when an attempt is made to a server-generated print
template and no active template can be found or the template generation
failed.

This required moving String and Toast components/services into the base
module so they could be used by the print components/services.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP1825851 Server print templates Release Notes
Bill Erickson [Fri, 12 Jul 2019 21:11:55 +0000 (17:11 -0400)]
LP1825851 Server print templates Release Notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP1825851 Server managed/processed print templates
Bill Erickson [Mon, 15 Apr 2019 22:11:46 +0000 (18:11 -0400)]
LP1825851 Server managed/processed print templates

Adds a new database table config.print_template (and IDL class) for
storing configurable, org- and locale-specific print templates.

Adds a web service which accepts POSTed print data and generates a
print-ready document.  Includes example Apache configs.

Teaches the Angular app to use the new web service for generting
print output.

Adds and Angular print template administration interface.

Adds HTML::Defang for scrubbing unwanted HTML elements and attributes
from print documents for security.

Add the new ADMIN_PRINT_TEMPLATE permission to the Circ Admin group at
System level as a default.

Adds 2 templates, a simple patron_address tepmlate (pending Angular port
of patron UIs) and a 'Holds for Bib Record' template, accessible from
the Angular staff catalog Holds interface.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP1825851 Add Perl HTML::Defang dependency
Bill Erickson [Fri, 24 May 2019 16:38:34 +0000 (12:38 -0400)]
LP1825851 Add Perl HTML::Defang dependency

Added dependency to installer makefile.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP1825851 Combobox display template option
Bill Erickson [Fri, 12 Jul 2019 16:37:59 +0000 (12:37 -0400)]
LP1825851 Combobox display template option

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP1825851 CStoreEditor instance specific personality
Bill Erickson [Thu, 11 Jul 2019 21:20:45 +0000 (17:20 -0400)]
LP1825851 CStoreEditor instance specific personality

Allow applying a CStoreEditor personality to individual editor instances
without overwriting the default / process-wide personality.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP1834665 Bib summary formats and jacket
Bill Erickson [Wed, 10 Jul 2019 15:57:18 +0000 (11:57 -0400)]
LP1834665 Bib summary formats and jacket

Display the format icon and label along the top of the Angular bib
record summary.

Display the jacket image along the left of the bib summary when the
summary is in expaded mode.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoLP1834665 MARC editor success/fail toasts
Bill Erickson [Wed, 10 Jul 2019 15:56:31 +0000 (11:56 -0400)]
LP1834665 MARC editor success/fail toasts

Indicate to the user when a MARC edit succeeds or fails via
toast in the Angular MARC editor component.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoLP1834665 Flat text editor uses '$' delimiter
Bill Erickson [Wed, 10 Jul 2019 15:51:53 +0000 (11:51 -0400)]
LP1834665 Flat text editor uses '$' delimiter

Consistent with the AngJS flat text MARC editor, use '$' as the subfield
delimiter instead of the default '‡'.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoLP1834665 Angular catalog MARC flat text editor
Bill Erickson [Fri, 28 Jun 2019 16:29:07 +0000 (12:29 -0400)]
LP1834665 Angular catalog MARC flat text editor

Adds a set of components for editing MARC records.  The main component
acts as a container with various actions (source selector, delete,
undelete, and save options).  The body of this component is a tabbed
interface, one tab for the Enriched editor and one for the Flat Text
editor.

The Enriched editor tab directs the user to the AngJS version of the page.
the Flat Text editor tab implements the standard MARC flat text editor
interface.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoLP1834665 Import marcrecord.js to Angular
Bill Erickson [Fri, 28 Jun 2019 16:27:35 +0000 (12:27 -0400)]
LP1834665 Import marcrecord.js to Angular

Port the marcrecord.js file into the Angular build configuration so it
may be used by the MARC editor code.

Additionally, port jquery-dependent code to vanilla JS to avoid the
jquery dependency.  As a part of this, some code from the source file
was removed since it was not needed (yet, anyway).  Code added back will
need to be similarly ported (mostly changing XML parsing).

Note as-is, the JS is loaded on every Angular page.  We could optimize
this and have it loaded only when needed if we port it to Typescript and
integrate it into the application instead of loading it as a 3rd-party
dependancy.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoLP1834662 Minor lingering lint repair
Bill Erickson [Mon, 26 Aug 2019 15:50:02 +0000 (11:50 -0400)]
LP1834662 Minor lingering lint repair

Unrelated to LP1834662, but there's no time like the present.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1834662: Fix incorrect locale fallback
Jane Sandberg [Thu, 11 Jul 2019 19:48:22 +0000 (12:48 -0700)]
LP1834662: Fix incorrect locale fallback

Resolves a deprecation warning and validation errors in the
datetime-select component

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1834662: Various fixes to the datetime select
Jane Sandberg [Sun, 7 Jul 2019 20:40:27 +0000 (13:40 -0700)]
LP1834662: Various fixes to the datetime select

* Adds the caret specifier to package.json and bumps up the version of
moment-timezone
* Adds an example of the egValidDatetime directive
* Makes the makeFormatParseable function localizable
* Gets rid of an error when this component is used without ngModel or
reactive forms
* Fixes various linting errors
* Closes the datetimepicker if the user opens another datetimepicker

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1834662 Allow date format defaults to persist.
Bill Erickson [Fri, 5 Jul 2019 18:21:49 +0000 (14:21 -0400)]
LP1834662 Allow date format defaults to persist.

Avoid clobbering the default date / time format strings set by the
FormatService.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoLP1834662: Add date-related components to Angular client.
Jane Sandberg [Wed, 8 May 2019 22:06:22 +0000 (15:06 -0700)]
LP1834662: Add date-related components to Angular client.

* Adds a moment.js-based datetime-select widget to Angular (including a
read-only version)
* Adds a daterange-select widget to Angular

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoDocs: adding alt text to MARC Editor chapter images
Jane Sandberg [Thu, 22 Aug 2019 21:42:56 +0000 (14:42 -0700)]
Docs: adding alt text to MARC Editor chapter images

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoDocs: LP #1803415: Location of MARC Editor 'Delete' Button
Derek C. Zoladz [Wed, 24 Apr 2019 18:40:13 +0000 (14:40 -0400)]
Docs: LP #1803415: Location of MARC Editor 'Delete' Button

Signed-off-by: Derek C. Zoladz <derek@derekzoladz.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoForward-port 3.3.3 upgrade script
Dan Wells [Thu, 22 Aug 2019 21:25:59 +0000 (17:25 -0400)]
Forward-port 3.3.3 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoForward-port 3.2.8 upgrade script
Dan Wells [Thu, 22 Aug 2019 21:25:39 +0000 (17:25 -0400)]
Forward-port 3.2.8 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoForward-port 3.1.14 upgrade script
Dan Wells [Thu, 22 Aug 2019 21:25:12 +0000 (17:25 -0400)]
Forward-port 3.1.14 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoDocs: add checkin trigger holds and cancel transit
dluchenbill [Wed, 24 Apr 2019 18:41:11 +0000 (13:41 -0500)]
Docs: add checkin trigger holds and cancel transit

Signed-off-by: dluchenbill <debbie@mobiusconsortium.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoDocs: add info about merge tracking
April Durrence [Wed, 24 Apr 2019 19:22:14 +0000 (15:22 -0400)]
Docs: add info about merge tracking

Signed-off-by: April Durrence <49952522+adurrence@users.noreply.github.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agodocs: error correction to 3.1.14 release notes
Andrea Buntz Neiman [Thu, 22 Aug 2019 19:09:31 +0000 (15:09 -0400)]
docs: error correction to 3.1.14 release notes

corrected link for "Fixes display issue with menus at certain screen resolutions" - the link & bug number were incorrect.

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoLP#1796945 Match new path_label/alias standard
Dan Wells [Thu, 15 Aug 2019 14:20:17 +0000 (10:20 -0400)]
LP#1796945 Match new path_label/alias standard

The old reporter used '::' as a path separator in some labels, while the
new version uses '->' in its place.  This would normally be just a
curiosity, except that the hashes used as join aliases are generated
from these path labels.  The end result is that while a report can be
cloned, if you add a field anywhere other than the top level, it
references a join alias which does not exist, and the report breaks.

Now, the method by which report templates are upgraded from v4 to v5
does not happen all in one pass, but rather a first pass is made
populate the interface, then the rest is done when the user saves the
clone.  Because of this, it actually seems adequate to only fix the
label, then allow the other steps to fill in the other bits upon saving
of the report.

Thank you to J. Boyer for helping track down the culprit.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
6 years agoLP#1796945 Reporter cloning and creation fixes
Dan Wells [Fri, 3 May 2019 17:17:50 +0000 (13:17 -0400)]
LP#1796945 Reporter cloning and creation fixes

This commit addresses a variety of issues with the webstaff reporter
interface, particularly cases of cloning reports created in the XUL
client.

1. The conversion process did not account for manually selected JOIN
operations (aka nullability).  These JOINs are now honored by the
conversion code.

2. The conversion process did not account for aggregate filters.  These
filters are now converted where present.

3. The previous reporter interface attempted to intelligently apply LEFT
and INNER JOINs by default.  The new interface applied INNER joins
exclusively by default, leading in many cases to different results.
This commit reinstates the previous logic.  One side effect of this
change is that the IDL tree itself is no longer opinionated about JOIN
type, and the default JOIN is undefined.

4. The nullability selector has been expanded to allow for manual
selection of INNER joins, as they will longer be the default in some
cases.

5. Cloned-converted reports did not retain column order.  The order is
now preserved.

6. Some templates created in the older interface could, in some cases,
have aggregate values set as the string "undefined" rather than
actually being undefined.  This led to converted templates failing with
"column [xxx] must appear in the GROUP BY clause...", as they were
incorrectly converted as aggregates.  The conversion code now accounts
for this latent bug.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
6 years agoTranslation updates - po files
Dan Wells [Thu, 22 Aug 2019 16:33:27 +0000 (12:33 -0400)]
Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoTranslation updates - newpot
Dan Wells [Thu, 22 Aug 2019 16:23:06 +0000 (12:23 -0400)]
Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1840852: Separates two MARCXML datafields in sample data
Jane Sandberg [Tue, 20 Aug 2019 22:42:39 +0000 (15:42 -0700)]
LP1840852: Separates two MARCXML datafields in sample data

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Ben Shum <ben@evergreener.net>
6 years agoUpdate upgrade instructions
Dan Wells [Wed, 18 Apr 2018 22:12:19 +0000 (18:12 -0400)]
Update upgrade instructions

Genericize version numbers, plus a few minor tweaks.

Eventually we probably need to start building the docs from tags, and
let the main branch use real placeholders.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoDocs: Adding 3.3.3 release notes
Andrea Buntz Neiman [Wed, 21 Aug 2019 21:03:25 +0000 (14:03 -0700)]
Docs: Adding 3.3.3 release notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoDocs: Adding missing entry to 3.2.8 release notes
Andrea Buntz Neiman [Wed, 21 Aug 2019 21:00:47 +0000 (14:00 -0700)]
Docs: Adding missing entry to 3.2.8 release notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoDocs: Adding 3.1.14 release notes
Jane Sandberg [Wed, 21 Aug 2019 20:30:01 +0000 (13:30 -0700)]
Docs: Adding 3.1.14 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
6 years agoDocs: Adding 3.1.14 release notes
Andrea Buntz Neiman [Wed, 21 Aug 2019 20:25:49 +0000 (13:25 -0700)]
Docs: Adding 3.1.14 release notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agolp1739292 merge UI displays record summary
Mike Risher [Wed, 10 Jul 2019 19:52:58 +0000 (19:52 +0000)]
lp1739292 merge UI displays record summary

Add the record summary to the record merge UI.  Note that when one clicks
on "use as lead record" or "remove from consieration" the order of the
records changes.  The record summary also will change order to match.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/bucket/record/t_merge_records.tt2
new file:   Open-ILS/src/templates/staff/cat/share/t_record_summary_slim.tt2
modified:   Open-ILS/web/js/ui/default/staff/cat/services/record.js

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1839548 Angular catalog holds patron barcode link
Bill Erickson [Fri, 9 Aug 2019 14:21:53 +0000 (10:21 -0400)]
LP1839548 Angular catalog holds patron barcode link

Holds grid on record detail page now present the patron barcode as a
link to the patron UI.

Related, this fixes the URL in the link for the copy barcode.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP1751800 - fix fields fields reversing
James Fournie [Thu, 2 May 2019 16:53:35 +0000 (09:53 -0700)]
LP1751800 - fix fields fields reversing

The pop() here will remove the last item in the array, only to add it
later with a push() a few lines later.  Instead use a shift() to
preserve the order.

Signed-off-by: James Fournie <james.fournie@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP#1785061: move the filter value munging to the template service
Galen Charlton [Wed, 22 May 2019 15:12:37 +0000 (11:12 -0400)]
LP#1785061: move the filter value munging to the template service

This allows the reporter app to stay a bit more focused on
display concerns.

Here's a test plan for the patch series
---------------------------------------
[1] Create a reporter template that has a filter field
    and a filter operator of "In list", "Not in list", "Between",
    or "Not between" and hard-code a value for that filter
    in the template, separating values with a comma.
[2] Try to create a report from that template; note that it
    fails with an error.
[3] Apply the patch and repeat steps 1 and 2. This time, the
    report should succeed.

Note that this fix applies only to hardcoding filter values in the
template; it doesn't change any behavior when attempting to set
a filter value for any of the four operators above at the point of
creating a report.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/web/js/ui/default/staff/reporter/template/app.js

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP#1785061: Split filter value on comma for "in list" and the like
Remington Steed [Thu, 2 May 2019 13:15:30 +0000 (09:15 -0400)]
LP#1785061: Split filter value on comma for "in list" and the like

This commit borrows directly from the XUL reporter code (see
function __default_value_event_handler () in
Open-ILS/web/reports/xul/template-config.js). Basically, when the filter
value is saved, certain cases need special treatment, such as splitting
an "in list" value on commas. This commit includes a helper function
which does the special treatment and saves the filter value. This helper
is called both when the value itself is changed, and when the operator
is changed.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/web/js/ui/default/staff/reporter/template/app.js

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1735768: adding labels to inputs in the public catalog
Jane Sandberg [Sat, 10 Nov 2018 20:32:04 +0000 (12:32 -0800)]
LP1735768: adding labels to inputs in the public catalog

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1837059: stamp DB update
Galen Charlton [Tue, 6 Aug 2019 00:58:34 +0000 (20:58 -0400)]
LP#1837059: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1837059: (follow-up) add release notes
Galen Charlton [Thu, 1 Aug 2019 15:24:34 +0000 (11:24 -0400)]
LP#1837059: (follow-up) add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1837059: (follow-up) mark help text for i18n
Galen Charlton [Thu, 1 Aug 2019 15:17:19 +0000 (11:17 -0400)]
LP#1837059: (follow-up) mark help text for i18n

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP1837059 Address alert config help text
Bill Erickson [Thu, 1 Aug 2019 14:36:06 +0000 (10:36 -0400)]
LP1837059 Address alert config help text

Support passing a helpTemplate value to the staff admin page builder.
Create an Address Alert component so it may define and pass its own help
text to the admin page builder.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP1837059 Local admin workstation settings
Bill Erickson [Thu, 18 Jul 2019 14:45:45 +0000 (10:45 -0400)]
LP1837059 Local admin workstation settings

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP1837059 Angular local admin page
Bill Erickson [Wed, 17 Jul 2019 22:03:31 +0000 (18:03 -0400)]
LP1837059 Angular local admin page

Links to the following pages now refer to their auto-generated Angular
equivalent:

actor/address_alert
config/barcode_completion
actor/copy_alert_suppress
asset/copy_location
asset/copy_tag
permission/grp_penalty_threshold
config/hold_matrix_matchpoint
config/non_cataloged_type
rating/badge

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP1837059 Basic admin page can propagate disableOrgFilter
Bill Erickson [Wed, 17 Jul 2019 22:02:39 +0000 (18:02 -0400)]
LP1837059 Basic admin page can propagate disableOrgFilter

Allow admin pages to hide the automagic org unit filter by passing the
value in via the route.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1722827: stamp DB update
Galen Charlton [Tue, 6 Aug 2019 00:45:28 +0000 (20:45 -0400)]
LP#1722827: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1722827: trim spaces from 856$9 when parsing locating URIs
Rogan Hamby [Fri, 14 Sep 2018 14:48:02 +0000 (10:48 -0400)]
LP#1722827: trim spaces from 856$9 when parsing locating URIs

This patch ensures that any leading and trailing spaces
and non-breaking-spaces in the 856$9 are ignored when
extracting the org unit shortname. As a consequence,
extraneous leading/trailing whitespace in the $9 will not
prevent the located URI from being displayed in the appropriate
places.

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Meg Stroup <mstroup@statelibrary.sc.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1511765 Fix error when checking in with zero-balance lost OU setting enabled
Michele Morgan [Wed, 23 May 2018 17:54:28 +0000 (13:54 -0400)]
LP#1511765 Fix error when checking in with zero-balance lost OU setting enabled

Fixes an error generated when checking in Lost/Long Overdue/Lost and Paid
items with no associated circ when the org unit setting
circ.checkin.lost_zero_balance.do_not_change is set to TRUE

Items can attain this state from migration, or when the associated circ
has been aged.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP1830912 Locally servered material icons
Bill Erickson [Wed, 29 May 2019 14:37:27 +0000 (10:37 -0400)]
LP1830912 Locally servered material icons

Adds the material-icons NPM package and teaches the Angular code to
import the icons at build time instead of fetching the icons from the
Google servers.

Two existing icons were swapped with alternate icons to avoid odd
spacing issues with the locally served versions.

Note 'npm install' is required to pick up the new icons package.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP1802593: Correct formatting of language code in Angularjs, KPAC
Jane Sandberg [Mon, 29 Jul 2019 18:56:31 +0000 (11:56 -0700)]
LP1802593: Correct formatting of language code in Angularjs, KPAC

EgWeb offers two different formats of the current locale: ctx.locale and
ctx.eg_locale.  This commit configures the lang attribute in AngularJS
staff client, OPAC, and KPAC to use eg_locale, since it has the
appropriate format (e.g. en-US, fr-CA).

Also adds some tests for EgWeb's handling of language codes.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1787676: sort Z39.50 sources in JS, retaining Local Catalog at top of list
Jeff Davis [Fri, 17 Aug 2018 17:32:31 +0000 (10:32 -0700)]
LP#1787676: sort Z39.50 sources in JS, retaining Local Catalog at top of list

This reverts the original fix for LP#1119370.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP1742523: Allow two strings in the mark damaged popup to be translated
Jane Sandberg [Sat, 19 May 2018 02:41:12 +0000 (19:41 -0700)]
LP1742523: Allow two strings in the mark damaged popup to be translated

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1795937: (follow-up) propagte new favicon to Angular app
Galen Charlton [Sat, 3 Aug 2019 16:35:26 +0000 (12:35 -0400)]
LP#1795937: (follow-up) propagte new favicon to Angular app

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>