LP#1626157 Support function key shortcuts; add f5 sample

Signed-off-by: Bill Erickson <berickxx@gmail.com>

ACQ admin splash page and IU's

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 ACQ admin splash page and IU's

Angular6 versions of all ACQ admin UI's, minus the funds page, which
requires some additional features.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 .gitignore for temp test files

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 Strip Eg prefix from most classes

Avoid prefixing shared classed with Eg consistent with Angular style.
Prefixing is not necessary since shared code has to be explicitly
imported.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

P#1626157 Catalog bib summary tighter style

Signed-off-by: Bill Erickson <berickxx@gmail.com>

P#1626157 Catalog record tabs continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 Catalog MARC HTML view tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 avoid some quick nav errors

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 More admin UI and entries

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 admin ui org selector descendants/ancestors

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 ng-lint updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 x-port LP#1774448 auth polling fix

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 WIP org selector ancestor/descendant options

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 more admin UI's

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 More admin ui consolidation

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into user/berick/lp1626157-ang6-app

LP#1626157 more admin UI's

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 server admin refactor; browse axis config

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 stat sip config continued; sync Cataloging menu

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 Actor stat cat sip fields config UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 age hold protect config UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 global flag config UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 Grid custom field templates

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Docs: Release notes entry for lp1732975

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

lp1732975 Parts Column Not Populated

- Retrieve Parts information in egItem

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/item/t_list.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/services/item.js

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: Add release note for bug 1707063 to 3.0 notes

I missed the 3.0 notes in the earlier commit.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: Add release note for bug 1707063

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1707063: Naive ng-class test for last-column-modified

Instead of comparing a (potentially undefined) property of a column, we'll
just compare the column object directly when checking to see if a column
header should be highlighted for "last touched in editing mode."

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: Add release notes entry for lp1766379

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1766379: add spaces between terms in author link to prevent a broken search query

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: adding to 3.1.2 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: correcting description of a bugfix

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1626157 hold weight / copy status config UI's; fm form fixes

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Docs: adding to 3.0.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1750887: Copy Objects when Saving Copy Templates

Copy the callnumbers and statcats objects when saving
copy templates to prevent accidental and confusing
editing of in-memory copies.

cesardv: changed tabs to spaces.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1771422 Reset transiting hold copy status fix

Avoid modifying the copy status in the hold-reset API when it's passing
the copy off to the transit API for canceling the transit.  Let the
transit API handle the status instead.

This fixes a bug where resetting a transiting hold, and canceling its
transit, would leave the targeted copy in "in transit" status instead of
"canceled transit".

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1750630: use proper quoting to un-break Transit List print template

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1528909: Patron search clickable barcodes

Patron barcodes in the patron search grid are now click-able, making it
possible to quickly open multiple patrons in new tabs from patron search
by control-clicking (or middle-clicking) the barcode links.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1626157 EgStoreService unit tests

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1721148: In-house use shows copy status

Adds a Copy Status column to the In-House use checkout grid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Geoff Sams <gsams@roanoketexas.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1626157 Grid row count selector

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Lp#1760859: Add Missing Images to Tranist and Hold Slips

Added new truck transit.png image for web client holds/transit dialog

Added holds.png img tag to t_hold_shelf_dialog.tt2

Added transit.png img tag to t_transit_dialog.tt2

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1759352: improve webstaff fix checkout specific due date UX

The Date Options dropdown UI added as a result of bug 1717025
hides the state of the "checkboxes" for custom due date and
the datepicker wasn't disabled when custom due date was disabled.
This addresses these UX issues, to that the user has visual feedback
as to the state of that option.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1751126: Make print holds shelf list aware of clear mode.

We change the Print Full List button on the holds shelf view to be
aware of whether clear mode is active.  If clear mode is active, then
the list of holds to clear is printed.  If not, then the full holds
shelf list is printed.

This commit does not change the label of the print full list button.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772417: (follow-up) improve I18N of the bucket title string

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1772417: Adding the bucket ID to the user bucket display

To test:
1) Open a patron bucket.  Note that the bucket ID is not listed
in the bucket information section at the top of this screen.
2) Apply this commit.
3) Open the same patron bucket.  Note that the bucket ID is
listed in the bucket information section

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1626157 Final ng-lint round

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1752753: Guard against invalid timezone

If the lib.timezone org setting is not a valid timezone, attempting to
use it can result in an internal server error in the OPAC.  Let's handle
the error with try/catch instead.

To test
-------
1. In Library Settings Editor, edit the "Library time zone" setting for
   Example Branch 1, setting the value to something that's not the name
   of a time zone (like "invalid" or "UTC-07:00").
2. In the OPAC, retrieve a record with holdings at Example Branch 1.
    You will get an Internal Server Error.
3. Edit the library setting to use a valid timezone name, like
   "America/Vancouver".
4. Retrieve the same record again. This time, the record will display
   properly.
5. Apply the patch and repeat steps 1 and 2; this time, there should
   be no internal server error.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Moving upgrade script into place

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1768992: Add missing copy alert permissions

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1693035 Login timeout honors workstation org

Use the org unit linked to the provided workstation to collect the
login timeout org unit setting value during login.  Previously, all
checks defaulted to the global org unit.

This patch solidifies the precedence order for OUS lookups during login
like so:

1. Workstation org unit.
2. API org unit value.
3. Users' home org unit.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1746815: Fix sticky hold url param

Renamed the hold_id url param from "id" to "hid" and prevent it from
sticking in url's where it not needed.

To test
-------
[1] Log in to the public catalog as a patron that has at least
    two hold requests.
[2] Go to the My Account holds tab and edit one of the holds.
[3] Rather than submit a change, click on the holds tab again.
[4] Note that /only/ the hold you were edit displays, and that the
    'id' URL parameter persists as you navigate through the public
    catalog.
[5] Apply the patch and repeat steps 1-3. This time, you should
    see all of the holds.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1772017: Correctly Extract Cast from Records

authors.tt2 has been using field 508 for cast display but
the correct field is 511 when ind1=1.

Testing note:

In the Concerto data set, the title "The rum diary" is a good test
record, as it has both a 508 field and a 511.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Adding to 3.1.2 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding to 3.0.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1626157 Generic admin page; sms carriers

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1753005: Avoid copy alert error for call numbers with no copies

When displaying the Holdings View tab for a bib in the web staff client,
if a volume record has no copies, a Javascript error gets thrown.

Item-less volumes still end up in svc.copies at this point, so at the
moment it is necessary to check whether copy_alerts actually exists.
Some renaming might also be in order to clarify that svc.copies doesn't
necessarily contain /only/ fleshed acp records.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1626157 ng-line updates continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1755220: Return value checking in offline session fetch

We need to make sure that we receive the correct shape of data (array) rather
than that we simply got anything when fetching sessions.  In the case of an
expired session token, we'll receive an ILS Event object informing us of the
expiration where we'd normally see a list of sessions.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1745240: Hold Alias Missing from Hold Shelf Slip

A patron's hold alias can be printed in the hold shelf slip using the variable patron.alias.  This patch just adds 'patron.alias' to the list of available options displayed at the top of the template. Also adds a colon before the patron's name fields for consistency.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1745232 - Bill History Receipt doesn't have Finish Date

Adds xact.finish and xact.summary.last_payment to the example data.  Also adds xact.summary.last_payment_ts to the template body to indicate when the last payment was made.  Also adds a list of variables that can be used in the template in the template's description.

To test -
1. apply the patch
2. find a patron with billings, or add some billings to a patron record.
3. make payments on some of the billings using various methods.
4. go to billing history and print the history list.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1743782 Copy Status not available in Check-In Screen

Makes the status an available column to display in the Check-In screen.

To test:
1. Apply patch.
2. Go to check-in and display 'Status' as a column in the table.
3. Check-in various items that may be checked-out, catch a hold, not checked out, etc.

Signed-off-by: gcollum <gcollum@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1765731 - restore CN suffix and preffix in Holds Pull List

Overly gung-ho removal of "redundant" fields/columns in bug
1728147 removed call number prefix and suffix as available columns
in the hold pull list grid in the web staff client; this will
restore them there.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Docs: Adding to and reorganizing the 3.1.2 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Adding to and reorganizing the 3.0.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1765444: improve how MARC editor fetches fixed field metadata

This patch fixes a problem where the web staff MARC editor would
make repeated and redundant calls to two Evergreen methods to fetch
data about fixed field positions and values if that metadata was
not already cached by local storage or Hatch.

In particular, this patch caches and returns the data retrieval
promises, ensuring that only one set of FF position and value
requests are made.

Prior to this patch, each eg-marc-edit-fixed-field directive, of which
there are 64, could end up invoking those methods when initializing
the editor for a record type that had not been previously seen.

To test
-------
[1] Clear all FFPosTable_* and FFValueTable_* keys from local storage
    (or Hatch).
[2] Retrieve a bib record in the web staff client. Note that up to
    64 calls each are made of open-ils.cat.biblio.fixed_field_values.by_rec_type
    and open-ils.fielder.cmfpm.atomic.
[3] Apply the patch and repeat steps #1 and #2.
[4] This time, note that only one call each are made.
[5] Verify that the fixed field inputs continue to work as expected.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1770478: Offline org unit tree can break

A thinko in the org tree reconstruction for offline mode caused the tree to be
broken in some situations, when the orgs were not ordered strictly by ID in
the list stored in the browser's IndexedDB storage.  This commit removes that
requirement, and allows trees of any ID and storage ordering to be
reconstituted.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>

lp1759327 Populate Copy Templates Floating Dropdown

- Add update watcher and call itemSvc.get_floating_groups within
egVolTemplate directive to properly populate dropdown when accessing
volcopy editor from local administration.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1749996: add option to remove floating in web client copy editor

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>

lp1760997 Holds Pull List Blank Fields

- Requires field data to be loaded into holds pull list grid
initially.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1749994 Disable payment button pending payment amount

Apply payment button on patron bills screen should be inactive if Payment
Received is blank

Adds a test to see if there is a value in Payment Received input box. The
Apply Payment button doesn't activate unless a billing or billings is
selected and a numerical value is in Payment Received.

To test.
1. Add some billings to a patron's account.
2. Click some of the billings to select them. Notice that the Apply Payment
   button is active.
3. Apply patch
4. Select some of the billings.  The Apply Payment button is not active.
5. Enter some values into Payment Received.  If values other than numbers
   are entered the Apply Payment button is not activated.  If numbers are
   added the button is activated.
6. Uncheck all of the billings to see that the activated button deactivates,
   if no billings are checked.

Signed-off-by: gcollum <gcollum@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1639022 Webstaff convert change to credit

Add support for converting change to patron credit in the patron bills
interface, consistent with the XUL feature.  When the
'circ.disable_patron_credit' org unit setting is applied, the option is
hidden.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Laura Sachjen <sachjenl@branchdistrictlibrary.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: updating 3.1.2 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: updating 3.0.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#14973322: (follow-up) allow profile-only patron searches

This patch removes the implicit requirement introduced by the previous
patch that a field other than profile be used in the patron search.

For performance reasons, it might be good to mark permission.grp_descendants()
as stable.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP14973322: Search for Users by Profile

Stop treating profile like a text value, instead
include users in the selected profiles and descendants.

To test
-------
[0] Search for users by last name (and / or first) and do not
    select a profile, take note of results
[1] Select the top of your permission group tree (Users, likely) and
    search again, results should be the same.
[2] Select a group further down the tree (Circulators, Administrators,
    Patrons, etc.) and repeat the search, there should only be results
    from that group and its descendants.
[3] Finally, select a group with no child groups. Results will only be
    that specific group.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1497322: add Perl live_t regression and unit tests for patron searching

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Docs: Update "Receipt Template Editor" for Web Client

Completely rewritten chapter. Many thanks to Terran McCanna, as much
was borrowed from her wiki pages.

Signed-off-by: Lynn Floyd <alynn2671@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>

LP#1626157 ng-lint updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 ng-lint updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 ng-lint updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 ng-lint updates / trailing whitespace

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 ng-lint updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 Ang6 test data

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 ng-lint updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 test docs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 ng-lint updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 ng-lint updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 IDL/org unit tests with mock data

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 Unit tests setup / ported EgEventService test

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Docs: Fix two minor typos

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: adding to 3.1.2 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding to 3.0.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Update Long-overdue docs for web client

This commit completes LP #1325704 by documenting the setting which
controls which tabs the long-overdue circ can appear on.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

LP#1626157 Doc updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1756912: Stamping upgrade script for add preferred lib to unapi feeds

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1756912: restore display of copy counts for preferred library

This patch fixes a regression introduced by the patches for bug 1698206
and restores the display of copy counts for the preferred library (when set)
on the public catalog results and record details pages.

To test
-------
[1] Log into the public catalog as a user and set a preferred library.
[2] Perform a catalog search at a system that is other than the
    preferred library set in step 1. Repeat the search with
    "Groups Formats and Editions" checked.
[3] Note that in both cases, the copy counts displayed in search results and
    the record details pages do not include a line for the preferred
    library.
[4] Apply the patch and repeat step 2. This time, the preferred library
    count should be included in the display.

The substance of this patch (with the exception of the pgTAP tests)
follows an approach suggested by Bob Wicksall <bwicksall@pls-net.org>

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#626157 More testing cleanup

Signed-off-by: Bill Erickson <berickxx@gmail.com>