LP1929741 Brief record for PO repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Standalone brief record UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LPLP1929741 Optional experimental Acq; seed data

Adds and org setting and a workstation setting to 1) enable display of
experimental Angular ACQ UI's and 2) enable display of links to the
experimental UI's from search results.

Display a new menu entry "Acquisitions (Experimental)" when the org
setting is enabled.  This menu contains "Create Purchase Order" only for
now.

Copy seed data from upgrade file to seed data file.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Welcome page navigates to staff w/ href

When a route failure occurs, etc. and the user is sent back to the
Welcom to Webby page, make the link to the staff page an href instead of
a routerLink, so Angular is forced to load new route data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Change Op displays failed permission

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 cleanup more PO subs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Clear previous PO on new PO create

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 cleanup PO subscription; improve charges display

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Fund limit/sort on new charges

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 ng lint

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1928258 Combobox sanity checks

Avoid failures caused by calling toLowerCase() on a number.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Item location select starts with; hide Unset

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Combobox supports startsWith search (p2)

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Blanket order finalizing; improved charges handling

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Sort funds by year desc, then code

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Batch of PO fixes

* Avoid clearing the owning library during batch edit copy operations
* Leverage combobox startsWith for distribution formulas
* Disable the order ident selector so it cannot be modified after a PO
  is activated
* Add some icons to the PO actions for more eye-grabbiness.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Combobox supports startsWith search

In lieu of the default behavor of the typeahead, which does a 'contains'
search.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 ACQ order ident indicate multiples

When multiple order identifer values (e.g. ISBN's) exist on a lineitem,
the number of options is now displayed just to the left of the
identifier selector.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Apply default lineitem order identifers

Apply a default order identifier to lineitems instead of leaving the
selector blank.  Ensure the value that will display in the selector
matches what's in the database by setting the value on load when needed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Bundle of ACQ bug fixes

* Distribution formula combobox now displays entries on click
* Ditto Charge Type combobox
* Items now vanish when deleted
* Estimated amount, etc. update when items are added/deleted
* Lineitem action links match order of previous interface.
* PO dry run checks now fire after a brief record is added
* PO activation is blocked if an item has no owning lib.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Delete action trumps ischanged for LID's

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Cache LI after order ident change

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Lineitem delete repairs

Allow deleting lineitems on PO's for certaian states.

Fix lineitem delete code issues.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 View/Place orders sorts newest to oldest

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Limit to active providers; skip empty name picklist

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 AnJS nav create po goes to new UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Improve catalog service sanity check

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Repair 'Create Invoice' link

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Zero-copy and no-assets PO activation

And summary layout improvements.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Ensure PO items always display when present

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 View/Place Orders UI

View/Place orders from a bib record and add/create selection lists or
PO's from the record.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Display copy row number in copy edit grid

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 ACQ caching / batch editing improvements

Ensure that funds/mods/locations of modified copies are available at
render time after saving changes to copies.

Hide the copy batch update bar when no copies are editable.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Combobox additional sanity checks on async/IDL values

1. Avoid PCRUD queries where the selected id value is set to null.
2. Avoid attempts to add null entries to the async entry cache.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Sanity check distrib. formula values

No fields within a distribution formula are required, so confirm a set
of values exists before calling Object.keys() on an undefined value.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Angular Selection List / Po Seed Data

PO and lineitem worksheet print templates.

Workstation preferences for grids and lineitem list page size.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 ACQ Selection List & PO Angluar Port

New selection list UI
New PO UI
New Lineitem worksheet UI with stub print template
New PO print UI with stub print template
New brief record UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Combobox idl auto query filter addition

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Combobox asyncSupportsEmptyTermClick fix

Fixes situation where combobox would fetch the needed entries in async
mode, but fail to open the drop-down after a click.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1929741 Net service tidier request logging

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1718782: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1718782: Add the Srce fixed field to the Angular MARC editor

To test:

1) Without using private browsing, open up a bibliographic record in
the Angular catalog MARC editor.
2) Notice that there is a gap between the ELvl and Audn fixed fields.
3) Apply this patch.
4) Open up the same bibliographic record, this time using private
   browsing (since the Angular MARC editor caches fixed field values).
5) Notice that the Srce fixed field is available between the ELvl and
   Audn fixed fields.
6) Notice that you can right click inside the fixed field to get a list
   of three possible values.
7) Repeat the test with different record types (e.g. BKS, SCO, VIS)

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1913807 Staff catalog shows preferred lib holdings counts

Always show holdings counts for the preferred library (when set) even
when the library is not directly in the search scope.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1910808 Staff catalog show call number

In the search results page, show the first call number for each record
(sorting by label sortkey) that is owned either by the user's preferred
library or the search library.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1857060: Tests for ISBNs with 979 prefix

Also includes a slight tweak to the Amazon AddedContent code to avoid
attempting to convert 979 ISBNs to ISBN-10s (which is not possible).

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1910891: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1910891: Add new booking perms to appropriate groups

Steps to test:

1) Without this patch, create a reservation for a BR1 resource at BR1.
2) Log in as a circulator at BR1.
3) Go to Booking > Manage Reservations.  Note that you can't see your reservation.
4) Run this upgrade script.
5) Repeat steps 2-3.  Notice that you can now see the reservation.
6) Wipe your database and re-install it with the additions to the seed data
in this commit.  Repeat steps 1-3 and notice that you can see the reservation
as expected.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895737: Add Curbside Appointments to Bootstrap OPAC

Add support for requesting / editing / canceling curbside
appointments to the bootstrap opac.

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1908722: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1908722: add electronic resource links

This patch adds electronic resource links to the Show More Details
view in the Angular staff catalog, above the table of items.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1908722 Staff catalog Show More Details

Adds a "Show More Details" (and "Show Fewer Details") buttons to the
Angualr staff catalog.  Similar to the TPAC, activating the button means
more holdings details are displayed in the search results page.

Adds a new workstation setting type called
'eg.staff.catalog.results.show_more'

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1844169: add release note entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1844169: (follow-up) add navigation

This patch adds a link back to the list of Search Filter Groups
from the page for editing a single group.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1844169: (follow-up) add validation to entry form

The Search Filter Group Entries modal now enforces
required fields client-side.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1844169: fix lint

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1844169: Compare query position against string

Compare queryPosition against '0' rather than int 0, avoiding Angular
issues during build process

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1844169: port Search Filter Groups admin interface to Angular

Port search filter groups admin from DOJO UI to Angular. Each search
filter group has its own edit page, from which you can edit search
filter group entries.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1362743 One modal at a time during batch checkin

Modify batch checkins so that only one modal pops up at a time.
When each one is dismissed the next one will appear.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1913221: Don't display blank course section number in OPAC

To test:

1) Use the Library Settings Editor to turn on the Course Materials
   Module.
2) In Local administration, go to the course reserves list.
3) Add several courses, some with section numbers, others without.
4) In the OPAC, use the Course Search function to search for the courses
   you just added.
5) Notice that the search results page has a place for section numbers,
   whether or not the course has one.
6) Click into some of the courses.  Notice that the course page also
   includes a place for section numbers, whether or not the course has
   one.
7) Apply this patch.
8) Repeat steps 4-6.  Notice that the blank "section number" areas no
   longer appear.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1920210: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1920210: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1920210: add auditor tables for acq.fund_debit

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1907296: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1907296 Missing Workstation setting for staff cat item table

Adds the ws setting type eg.grid.catalog.record.copies to allow users to
save grid preferences for the angular catalog item table.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1928005 Bootstrap Opac: Current charges not aligned on mobile.

This patch removes the classes from the charges table that presents the table in a vertical format.
It wraps the table in a <div> that uses the table-responsive class.

To test add some charges to a patron record.
Bring that patron's account up in the opac and view the charges table in the smallest browser size
possible.
Notice that the table switches to a vertical format and the column names are mis-aligned.

Apply the patch.

View the table again.  The table should now be horizontal with all of the columns correct.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1929136: (follow-up) reduce bounce time to 500ms

During testing, 500ms was enough to avoid excessive
PCRUD calls while still keeping the interface's display
of duplicate or missing barcode warnings responsive.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1929136: delay barcode lookup on change in holdings editor

In the Holdings Editor, any change to the barcode field results in an
immediate API call.  Thus, if you type the barcode "123456789", you
would get 9 separate calls: 1, 12, 123, 1234, 12345 ...

This commit adds a 1000ms delay to avoid excessive pcrud calls when
typing a barcode.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: updates to library settings; filename fixes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Forward port the 3.6.3 to 3.6.4 db upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>

Forward port 3.5.4 to 3.5.5 db upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>

Forward port 3.5.3 to 3.5.4 db upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>

Forward-port 3.7.1 version upgrade script

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

update Czech translations for Angular staff client

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: 3.7.1 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: 3.6 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Release notes for 3.5.5

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1930933: fix issue with over-escaping in search results title attributes

This patch fixes an issue where a record with a title containing the
word "hidden" can have its title, ironically enough, not show up
on public catalog search results.

To test
-------
[1] Create an OPAC-visible record whose 245 is something like:

    =245 04$aThe hidden one <script>alert('title!')</script>

[2] Search for the record in both the TPAC and Bootstrap skin. Note
    that the title isn't displayed.
[3] Apply the patch and repeat step 2. This time, the full title
    should be displayed.
[4] Verify that the OPAC does not display an alert box.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

LP1910145 Angular Hold Detail Notes & Notifications

The hold detail view now displays hold notes and hold notification
records.  Notes and Notifications may be created by staff.  Notes may be
deleted by staff.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1887876 Checkout catalog doesn't load workstation prefs

The catalog under the Holds tab in the Checkout interface
doesn't load the default search or preferred library if
you haven't visited the main catalog page earlier in the
session.

This branch sets these settings as cookies in the
AngularJS wrapper for the catalog embedded in the Checkout
interface under the Holds tab.

Test:
1. Close browser, open browser, log into Evergreen
2. Admin->Workstation set search & preferred library
3. Open a patron record -> Holds tab -> Place Holds
4. Search for an item owned by your preferred library
5. Note the library's copies aren't separately indicated
6. Apply patch and repeat steps 1-5
7. Note the library's copies are separately indicated

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1930088 Angular catalog: metarecord search returns no results

This adds a missing param to a call to get_one_record_summary
that's necessary after commit c07ce8.

To test, perform a search using the Group Formats/Editions checkbox
and you should see results.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1895738: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

lp1895738 need eg.orgselect.hopeless.wide_holds

This fixes the following:

ERROR Error: Uncaught (in promise): No user or workstation setting type exists for: "eg.orgselect.hopeless.wide_holds".
Create a ws/user setting type or use setLocalItem() to store the value locally.

However, it exposes a different (harmless?) error within the /eg2 holds grid:

ERROR Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value for 'ng-untouched': 'true'. Current value: 'false'.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1901893: (follow-up) add cellTextGenerator

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1901893 Bucket column link tweak

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1901893 Carousel bucket should be linked from grid

Re-formats the bucket column content as a link that opens the
carousel's associated bucket in a new tab.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1778955: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1778955: fixing upgrade script, removing duplicate function definition

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1778955: Remove our custom version of array_remove(anyarray,anyelement)

As of Postgres 9.3 there is a built in array_remove() function that is faster
than our custom version that uses unnest().  We should use that instead.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1908619: add a release notes sentence

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1908619 Adjustments to Staff Search Preferences Page

Change 'Catalog Preferences' to 'Search Preferences' and
add a Return button at the bottom to make it more obvious how
to get out of the interface.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jennifer Bruch <jbruch@sparkpa.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1922120: Add to carousel action in angular catalog

To test:

1) Create several manual carousels, and make sure they are
set to active.
2) Open a bib record in the Angular staff catalog.
3) Under Other Actions, choose the "Add to Carousel" action
4) Choose your preferred carousel.
5) Click Add to carousel.
6) Go back to carousel administration (or look at the carousel
itself), and confirm that the record has been added to the
carousel in question.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

docs: fix typo in 3.6 release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: radio monograph part selector in OPAC

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: add admin docs for multiple holds feature

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Update migrating_your_data.adoc

Signed-off-by: Stephen Wills <swills@beyond-print.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Update librarysettings.doc

Signed-off-by: Stephen Wills <swills@beyond-print.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: LP 1751146 browser bookmarks toolbar

Add tips for using the browser bookmarks toolbar in place of the XUL button bar

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: LP 1250528 change font size in browser

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: small follow-up tweaks to survey documentation

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Updated Surveys Pictures

Updated images for Surveys.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>