working/Evergreen.git
4 years agoLP1929741 Brief record for PO repair user/berick/lp1929741-acq-selection-order-angular-v3
Bill Erickson [Mon, 26 Jul 2021 15:01:24 +0000 (11:01 -0400)]
LP1929741 Brief record for PO repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Standalone brief record UI
Bill Erickson [Wed, 30 Jun 2021 20:36:20 +0000 (16:36 -0400)]
LP1929741 Standalone brief record UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLPLP1929741 Optional experimental Acq; seed data
Bill Erickson [Wed, 14 Jul 2021 14:52:44 +0000 (10:52 -0400)]
LPLP1929741 Optional experimental Acq; seed data

Adds and org setting and a workstation setting to 1) enable display of
experimental Angular ACQ UI's and 2) enable display of links to the
experimental UI's from search results.

Display a new menu entry "Acquisitions (Experimental)" when the org
setting is enabled.  This menu contains "Create Purchase Order" only for
now.

Copy seed data from upgrade file to seed data file.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Welcome page navigates to staff w/ href
Bill Erickson [Thu, 24 Jun 2021 15:30:24 +0000 (11:30 -0400)]
LP1929741 Welcome page navigates to staff w/ href

When a route failure occurs, etc. and the user is sent back to the
Welcom to Webby page, make the link to the staff page an href instead of
a routerLink, so Angular is forced to load new route data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Change Op displays failed permission
Bill Erickson [Thu, 24 Jun 2021 15:29:54 +0000 (11:29 -0400)]
LP1929741 Change Op displays failed permission

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 cleanup more PO subs
Bill Erickson [Tue, 22 Jun 2021 20:31:10 +0000 (16:31 -0400)]
LP1929741 cleanup more PO subs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Clear previous PO on new PO create
Bill Erickson [Tue, 22 Jun 2021 20:18:18 +0000 (16:18 -0400)]
LP1929741 Clear previous PO on new PO create

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 cleanup PO subscription; improve charges display
Bill Erickson [Tue, 22 Jun 2021 20:02:40 +0000 (16:02 -0400)]
LP1929741 cleanup PO subscription; improve charges display

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Fund limit/sort on new charges
Bill Erickson [Tue, 22 Jun 2021 19:44:08 +0000 (15:44 -0400)]
LP1929741 Fund limit/sort on new charges

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 ng lint
Bill Erickson [Tue, 22 Jun 2021 19:39:57 +0000 (15:39 -0400)]
LP1929741 ng lint

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1928258 Combobox sanity checks
Bill Erickson [Mon, 14 Jun 2021 19:55:29 +0000 (15:55 -0400)]
LP1928258 Combobox sanity checks

Avoid failures caused by calling toLowerCase() on a number.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Item location select starts with; hide Unset
Bill Erickson [Tue, 22 Jun 2021 18:47:44 +0000 (14:47 -0400)]
LP1929741 Item location select starts with; hide Unset

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Combobox supports startsWith search (p2)
Bill Erickson [Tue, 22 Jun 2021 18:46:51 +0000 (14:46 -0400)]
LP1929741 Combobox supports startsWith search (p2)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Blanket order finalizing; improved charges handling
Bill Erickson [Tue, 22 Jun 2021 18:06:00 +0000 (14:06 -0400)]
LP1929741 Blanket order finalizing; improved charges handling

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Sort funds by year desc, then code
Bill Erickson [Tue, 22 Jun 2021 16:19:44 +0000 (12:19 -0400)]
LP1929741 Sort funds by year desc, then code

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Batch of PO fixes
Bill Erickson [Tue, 22 Jun 2021 15:43:05 +0000 (11:43 -0400)]
LP1929741 Batch of PO fixes

* Avoid clearing the owning library during batch edit copy operations
* Leverage combobox startsWith for distribution formulas
* Disable the order ident selector so it cannot be modified after a PO
  is activated
* Add some icons to the PO actions for more eye-grabbiness.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Combobox supports startsWith search
Bill Erickson [Tue, 22 Jun 2021 15:42:00 +0000 (11:42 -0400)]
LP1929741 Combobox supports startsWith search

In lieu of the default behavor of the typeahead, which does a 'contains'
search.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 ACQ order ident indicate multiples
Bill Erickson [Mon, 14 Jun 2021 21:43:15 +0000 (17:43 -0400)]
LP1929741 ACQ order ident indicate multiples

When multiple order identifer values (e.g. ISBN's) exist on a lineitem,
the number of options is now displayed just to the left of the
identifier selector.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Apply default lineitem order identifers
Bill Erickson [Mon, 14 Jun 2021 21:35:21 +0000 (17:35 -0400)]
LP1929741 Apply default lineitem order identifers

Apply a default order identifier to lineitems instead of leaving the
selector blank.  Ensure the value that will display in the selector
matches what's in the database by setting the value on load when needed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Bundle of ACQ bug fixes
Bill Erickson [Fri, 11 Jun 2021 15:29:47 +0000 (11:29 -0400)]
LP1929741 Bundle of ACQ bug fixes

* Distribution formula combobox now displays entries on click
* Ditto Charge Type combobox
* Items now vanish when deleted
* Estimated amount, etc. update when items are added/deleted
* Lineitem action links match order of previous interface.
* PO dry run checks now fire after a brief record is added
* PO activation is blocked if an item has no owning lib.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Delete action trumps ischanged for LID's
Bill Erickson [Fri, 11 Jun 2021 14:28:06 +0000 (10:28 -0400)]
LP1929741 Delete action trumps ischanged for LID's

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Cache LI after order ident change
Bill Erickson [Wed, 9 Jun 2021 15:16:08 +0000 (11:16 -0400)]
LP1929741 Cache LI after order ident change

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Lineitem delete repairs
Bill Erickson [Mon, 3 May 2021 15:28:09 +0000 (11:28 -0400)]
LP1929741 Lineitem delete repairs

Allow deleting lineitems on PO's for certaian states.

Fix lineitem delete code issues.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 View/Place orders sorts newest to oldest
Bill Erickson [Tue, 20 Apr 2021 15:15:36 +0000 (11:15 -0400)]
LP1929741 View/Place orders sorts newest to oldest

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Limit to active providers; skip empty name picklist
Bill Erickson [Thu, 8 Apr 2021 14:30:56 +0000 (10:30 -0400)]
LP1929741 Limit to active providers; skip empty name picklist

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 AnJS nav create po goes to new UI
Bill Erickson [Fri, 26 Feb 2021 16:11:19 +0000 (11:11 -0500)]
LP1929741 AnJS nav create po goes to new UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Improve catalog service sanity check
Bill Erickson [Tue, 27 Apr 2021 14:32:05 +0000 (10:32 -0400)]
LP1929741 Improve catalog service sanity check

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Repair 'Create Invoice' link
Bill Erickson [Tue, 2 Feb 2021 18:41:47 +0000 (13:41 -0500)]
LP1929741 Repair 'Create Invoice' link

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Zero-copy and no-assets PO activation
Bill Erickson [Mon, 1 Feb 2021 22:29:26 +0000 (17:29 -0500)]
LP1929741 Zero-copy and no-assets PO activation

And summary layout improvements.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Ensure PO items always display when present
Bill Erickson [Mon, 1 Feb 2021 21:16:07 +0000 (16:16 -0500)]
LP1929741 Ensure PO items always display when present

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 View/Place Orders UI
Bill Erickson [Tue, 26 Jan 2021 18:26:35 +0000 (13:26 -0500)]
LP1929741 View/Place Orders UI

View/Place orders from a bib record and add/create selection lists or
PO's from the record.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Display copy row number in copy edit grid
Bill Erickson [Wed, 20 Jan 2021 22:02:38 +0000 (17:02 -0500)]
LP1929741 Display copy row number in copy edit grid

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 ACQ caching / batch editing improvements
Bill Erickson [Wed, 20 Jan 2021 20:49:55 +0000 (15:49 -0500)]
LP1929741 ACQ caching / batch editing improvements

Ensure that funds/mods/locations of modified copies are available at
render time after saving changes to copies.

Hide the copy batch update bar when no copies are editable.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Combobox additional sanity checks on async/IDL values
Bill Erickson [Wed, 20 Jan 2021 20:47:03 +0000 (15:47 -0500)]
LP1929741 Combobox additional sanity checks on async/IDL values

1. Avoid PCRUD queries where the selected id value is set to null.
2. Avoid attempts to add null entries to the async entry cache.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Sanity check distrib. formula values
Bill Erickson [Wed, 20 Jan 2021 19:14:36 +0000 (14:14 -0500)]
LP1929741 Sanity check distrib. formula values

No fields within a distribution formula are required, so confirm a set
of values exists before calling Object.keys() on an undefined value.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Angular Selection List / Po Seed Data
Bill Erickson [Fri, 15 Jan 2021 15:33:55 +0000 (10:33 -0500)]
LP1929741 Angular Selection List / Po Seed Data

PO and lineitem worksheet print templates.

Workstation preferences for grids and lineitem list page size.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 ACQ Selection List & PO Angluar Port
Bill Erickson [Thu, 8 Oct 2020 22:22:12 +0000 (18:22 -0400)]
LP1929741 ACQ Selection List & PO Angluar Port

New selection list UI
New PO UI
New Lineitem worksheet UI with stub print template
New PO print UI with stub print template
New brief record UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Combobox idl auto query filter addition
Bill Erickson [Fri, 4 Dec 2020 20:39:33 +0000 (15:39 -0500)]
LP1929741 Combobox idl auto query filter addition

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Combobox asyncSupportsEmptyTermClick fix
Bill Erickson [Fri, 4 Dec 2020 16:17:51 +0000 (11:17 -0500)]
LP1929741 Combobox asyncSupportsEmptyTermClick fix

Fixes situation where combobox would fetch the needed entries in async
mode, but fail to open the drop-down after a click.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1929741 Net service tidier request logging
Bill Erickson [Wed, 30 Dec 2020 16:43:50 +0000 (11:43 -0500)]
LP1929741 Net service tidier request logging

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoStamping upgrade script
Mike Rylander [Wed, 15 Sep 2021 14:31:39 +0000 (10:31 -0400)]
Stamping upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agolp1905028 lost items and price versus acq cost
Jason Etheridge [Fri, 28 May 2021 20:25:22 +0000 (16:25 -0400)]
lp1905028 lost items and price versus acq cost

This feature adds two new library settings:

    Use Item Price or Cost as Primary Item Value
    Use Item Price or Cost as Backup Item Value

which intersect the behavior of these existing settings:

    Charge lost on zero
    Default Item Price
    Minimum Item Price
    Maximum Item Price

Each of these settings affect how item price is used in
various contexts and is not limited to "lost" items, but
can affect notices, fine rules, and billings for long
overdue and damaged items (as well as lost items).

By default, the price field on items is the only field
considered by these various uses, but if we set, for
example, "Use Item Price or Cost as Primary Item Value" to
"cost", then we'll use the cost field instead of the price
field.

Alternately, if we set the "Backup Item Value" to "cost"
and either leave the "Primary Item Value" setting unset or
set to "price", then we'll consider the price field first,
and if it is either unset/null or equal to 0 (and
"Charge lost on zero" is true), then it'll fall-through to
the cost field.  We can also flip the behavior with these
settings and consider cost first and then price second.

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP1752356 Offline Block List Download Date
Terran McCanna [Thu, 20 Aug 2020 22:37:28 +0000 (18:37 -0400)]
LP1752356 Offline Block List Download Date

Amended previous commits by adding the download block list date to
the other reasons why an account could show up on the block list.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Jason Boyer <jboyer@equinoxOLI.org>
4 years agoLP1752356 Offline expired patrons download date additions
Bill Erickson [Wed, 3 Jul 2019 18:34:39 +0000 (14:34 -0400)]
LP1752356 Offline expired patrons download date additions

Modify wording to clarify the date displayed is that of the block list
download and not necessarily the date the patron was flagged expired.

Avoid console errors when the file download date is not known -- edge
case where the code is updated but the block list was not updated in the
meantime.

Clean up some debug logging.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <jboyer@equinoxOLI.org>
4 years agoLP1752356 Offline block list date addition
Mike Risher [Mon, 1 Jul 2019 15:56:17 +0000 (15:56 +0000)]
LP1752356 Offline block list date addition

In offline mode when checking out for an expired patron, we changed
the error message so that the last date the blocklist was downloaded
is displayed along with the patron barcode

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <jboyer@equinoxOLI.org>
4 years agoLP1170795 Stamp Database Update
Jason Boyer [Wed, 8 Sep 2021 19:01:48 +0000 (15:01 -0400)]
LP1170795 Stamp Database Update

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
4 years agoLP1170795: Void deposits on checkin
Jason Boyer [Wed, 11 Sep 2019 16:45:00 +0000 (12:45 -0400)]
LP1170795: Void deposits on checkin

Release note

Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <jboyer@equinoxOLI.org>
4 years agoLP1170795: Void deposits on checkin
blake [Fri, 3 Feb 2017 22:45:29 +0000 (16:45 -0600)]
LP1170795: Void deposits on checkin

Introduce a library setting circ.void_item_deposit. When set, the money.billing
deposit row will be voided on checkin.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <jboyer@equinoxOLI.org>
4 years agoLP#1823983: repeat_delay check removes event definition id filter
Mike Rylander [Tue, 9 Apr 2019 15:30:15 +0000 (11:30 -0400)]
LP#1823983: repeat_delay check removes event definition id filter

This bug has existed since the repeat_delay feature was added, but likely only
rarely was triggered because most events don't have a repeat_delay, and those
that do don't interact with the same target.  However, as more repeatable event
definitions are created, inappropriate interaction becomes more likely.

In this commit we avoid overwriting the whole join condition clause, which
already contains an event definition id filter and needs to retain it.

Included is an unrelated change that uses the new-ish form of
interval_to_seconds that avoids DST boundary shifting issues by passing a
context DateTime object as the second parameter.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1809157 SMS Carriers display not in alphabetical order
Garry Collum [Wed, 28 Apr 2021 19:26:39 +0000 (15:26 -0400)]
LP1809157 SMS Carriers display not in alphabetical order

This alphabetizes the carrier display when editing the sms carrier in an existing hold.

It also adds the region to the name to make the interface consistent with other interfaces.

To Test:

1. Enable SMS options in the Library Settings.
2. Place a hold for a patron.
3. Use the Edit Notifications Settings.  Enter an SMS number, if needed.
4. Drop-down the Carrier list - the list is not in alphabetical order.
5. Apply the patch and repeat 3-4.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1932051: serialize adding items to bucket from Item Status
Jeff Davis [Mon, 23 Aug 2021 18:24:05 +0000 (11:24 -0700)]
LP#1932051: serialize adding items to bucket from Item Status

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
4 years agoLP#1932051: Batch calls for add items to bucket
Chris Sharp [Tue, 15 Jun 2021 15:59:48 +0000 (11:59 -0400)]
LP#1932051: Batch calls for add items to bucket

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
4 years agoLP#1743611 Circ History by Year Info
Dan Briem [Thu, 26 Aug 2021 18:52:51 +0000 (14:52 -0400)]
LP#1743611 Circ History by Year Info

Adds an info button next to Total Circs in the AngularJS staff
client Item Status screen. Clicking the button displays a
popover list of total circs by year.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoLP827356: Stamp Ugrade Script
Jason Boyer [Fri, 27 Aug 2021 19:56:10 +0000 (15:56 -0400)]
LP827356: Stamp Ugrade Script

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
4 years agolp827356 new rules protect bre -1, acn -1 and acl 1 as well as marc editing buttons...
Rogan Hamby [Thu, 18 Mar 2021 13:11:00 +0000 (13:11 +0000)]
lp827356 new rules protect bre -1, acn -1 and acl 1 as well as marc editing buttons disabled

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
4 years agoLP1931162: Stamp Upgrade Script
Jason Boyer [Fri, 27 Aug 2021 18:45:54 +0000 (14:45 -0400)]
LP1931162: Stamp Upgrade Script

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
4 years agoLP#1931162: DYM needs some situational optimization
Mike Rylander [Mon, 7 Jun 2021 19:57:32 +0000 (15:57 -0400)]
LP#1931162: DYM needs some situational optimization

For some data sets and some queries the Did You Mean search suggestion
logic can be much too slow. This is mainly in cases where a "misspelled"
word of sufficient length greater than the symspell prefix length is
checked against many short prefixes that have many long suggestions
attached to them.

This commit optimizes for that case in particular by testing the length
of suggestions and prefix keys against the user input to avoid
unnecessary tests.  Futher, it captures the edit distance of suggestions
that pass that test in-line, avoiding expensive retesting, and caches
the short-cutoff edit distance when in low-verbosity mode to avoid
future different-but-not-too-different suggestions coming from the same
prefix key.

It additionally provides a general optimization by batching the capture
of suggest counts to avoid per-suggestion secondary lookups, and a
micro-optimization of ordering suggestions by length at distance cache
time.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
4 years agolp1908439 Auto-override enhancment
Jason Etheridge [Tue, 9 Feb 2021 14:42:06 +0000 (09:42 -0500)]
lp1908439 Auto-override enhancment

This reworks the override action dialogs in the patron display for Check
Out and Items Out, and in the Circulation -> Renew Items interface.  It
exposes the auto-override behavior as checkboxes giving staff more fine
grained control over which events are auto-forced or skipped upon
subsequent encounters.  It also changes the Cancel action for batch
renewals to abort the remaining renewals in the batch, and makes it so
that new authorization credentials provided during such a batch will be
treated as an operator change for the entire batch.  We also fix an
existing bug where events marked as already encountered for
auto-override could leak into other patron contexts via Patron Search.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoRepair missing line in seed data causing build failures
Jason Boyer [Mon, 16 Aug 2021 11:18:57 +0000 (07:18 -0400)]
Repair missing line in seed data causing build failures

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
4 years agoLP#1888723: stamp DB update
Galen Charlton [Sun, 15 Aug 2021 23:58:38 +0000 (19:58 -0400)]
LP#1888723: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1888723: tweak eg-item-location-select
Galen Charlton [Sun, 15 Aug 2021 23:37:39 +0000 (19:37 -0400)]
LP#1888723: tweak eg-item-location-select

The contextOrgId Input() can now be changed dynamically; doing
so will refresh the list list of shelving locations available
in the drop-down.

Apply this to the distribution formula editor.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Disable special copy statuses in status selector
Bill Erickson [Wed, 3 Mar 2021 15:52:55 +0000 (10:52 -0500)]
LP1888723 Disable special copy statuses in status selector

It is no longer possible to manually move a copy into a special copy
status in the Angular volcopy attributes editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Support disabling select entries in combobox
Bill Erickson [Wed, 3 Mar 2021 15:52:36 +0000 (10:52 -0500)]
LP1888723 Support disabling select entries in combobox

Adds a new @Input() disableEntries: any[] for tracking identifier
values in the combobox that should be marked as disabled / unselectable.

Substantive updates during rebasing made by Galen Charlton.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Item location select honors context org
Bill Erickson [Fri, 28 Aug 2020 19:16:20 +0000 (15:16 -0400)]
LP1888723 Item location select honors context org

The Angular <eg-item-location-select /> component now limits the
locations to display to those within the specified context org unit.

Instead of acting as the source of context org units, the permFilter org
units now act as limiters.  This is done so that users with global
permissions won't by default result in retrieving all copy locations.
In cases where all are needed, however, they can still be retrieved by
setting the context org unit appropriately.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Avoid save warning on vol load; vol save thinko
Bill Erickson [Wed, 11 Aug 2021 19:01:06 +0000 (15:01 -0400)]
LP1888723 Avoid save warning on vol load; vol save thinko

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Traditional catalog still uses traditional holdings editor
Bill Erickson [Mon, 12 Jul 2021 16:54:14 +0000 (12:54 -0400)]
LP1888723 Traditional catalog still uses traditional holdings editor

Avoid sending staff to the new holdings editor from within the
traditional catalog, so there remains a way to get to the traditional
editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Remove ref. to nonexistent workstation setting
Bill Erickson [Mon, 12 Jul 2021 16:53:52 +0000 (12:53 -0400)]
LP1888723 Remove ref. to nonexistent workstation setting

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Manage mode for single-copy edits notes/tags/alerts
Bill Erickson [Mon, 12 Jul 2021 16:38:16 +0000 (12:38 -0400)]
LP1888723 Manage mode for single-copy edits notes/tags/alerts

When editing multiple items, always open the Item Alerts/Tags/Notes
dialogs in "manage" mode so users can see and edit existing values on
the edited copy.

In batch copy mode, these dialogs still only allow adding new values.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Angular volcopy Apply All actions
Bill Erickson [Mon, 12 Jul 2021 16:02:58 +0000 (12:02 -0400)]
LP1888723 Angular volcopy Apply All actions

Replace Save and SAve & Exit buttons in the Angular holdings editor with
'Apply All & Save' and 'Apply All, Save & Exit' buttons.  With this,
staff are not required to click Apply on every change.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Merge repairs
Bill Erickson [Mon, 12 Jul 2021 15:26:22 +0000 (11:26 -0400)]
LP1888723 Merge repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Avoid defaulting CN labels for existing CN's
Bill Erickson [Wed, 3 Mar 2021 17:27:51 +0000 (12:27 -0500)]
LP1888723 Avoid defaulting CN labels for existing CN's

When a call number is loaded in the editor whose label is an empty
string, avoid applying a default values to the label so it's clear in
the UI that the call number label is blank.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Adds call number edit link to catalog copy table
Bill Erickson [Wed, 3 Mar 2021 17:27:30 +0000 (12:27 -0500)]
LP1888723 Adds call number edit link to catalog copy table

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Remove no longer needed (click) handler
Bill Erickson [Wed, 17 Feb 2021 15:09:30 +0000 (10:09 -0500)]
LP1888723 Remove no longer needed (click) handler

The holdings Edit link no longer includes a redirect and can be
opened/closed as expected via a regular href (routerLink).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Sort new-volum holding orgs alphabetically
Bill Erickson [Tue, 9 Feb 2021 20:04:38 +0000 (15:04 -0500)]
LP1888723 Sort new-volum holding orgs alphabetically

When adding new call numbers to newly represented org units in the
volcopy holdings grid, ensure newly added org units are sorted
alphabetically by the org unit shortname.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Use existing user setting for copy templates
Bill Erickson [Tue, 9 Feb 2021 16:33:33 +0000 (11:33 -0500)]
LP1888723 Use existing user setting for copy templates

Also propagate the new 'defaults' workstation setting to the seed data
file.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Repair Add Item Alerts action
Bill Erickson [Mon, 8 Feb 2021 20:13:49 +0000 (15:13 -0500)]
LP1888723 Repair Add Item Alerts action

Adding alerts opens the copy alerts dialog, not the copy notes dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Value summaries '1 copy' vs 'x copies'
Bill Erickson [Mon, 11 Jan 2021 21:08:08 +0000 (16:08 -0500)]
LP1888723 Value summaries '1 copy' vs 'x copies'

Add pluralization support to the copy summary counts so that values
linked to only a single copy display as "1 copy" instead of "1 copies"

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Volcopy strings should be global
Bill Erickson [Wed, 6 Jan 2021 18:10:58 +0000 (13:10 -0500)]
LP1888723 Volcopy strings should be global

Moving the <eg-string /> entries to the root of the tepmlate ensures all
references to those strings are defined / non-null.  Otherwise, if the
user opts to hide a field which contained its own strings (e.g. loan
duration), the code would fail on null references, e.g.:

ERROR TypeError: Cannot read property 'text' of undefined

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Copy value counts separation
Bill Erickson [Tue, 5 Jan 2021 20:01:16 +0000 (15:01 -0500)]
LP1888723 Copy value counts separation

Provide a small amount of padding and light vertical border for the item
value summary counts so the counts don't blend with longer values (e.g.
long call numbers, etc.)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Call number modification repair
Bill Erickson [Mon, 28 Dec 2020 23:36:01 +0000 (18:36 -0500)]
LP1888723 Call number modification repair

Fixes an issues where modifying the call number label without modifying
any items would result in modifying the call number for all linked items
instead of the items actually loaded in the volcopy editor.

Also fixes a case where modifying call numbers failed to reflect
correctly in the catalog holdings view.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Detect unapplied changes; improve tab change
Bill Erickson [Wed, 16 Dec 2020 16:03:54 +0000 (08:03 -0800)]
LP1888723 Detect unapplied changes; improve tab change

1. Detect when a change was initiated for one of the copy attributes,
but not applied during change detection for warning alerts.

2. Improve handling of inter-tab navigation for change alerts.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Improve copy default status lookup
Bill Erickson [Tue, 15 Dec 2020 15:40:45 +0000 (07:40 -0800)]
LP1888723 Improve copy default status lookup

Fixes an issue where a) default copy statuses were not getting correctly
applied and b) the copy status org setting lookup was not correctly
serialized, which can lead to actor drone exhaustion on the server (see
also bug 1896285).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Unsaved changes navigation warning
Bill Erickson [Mon, 14 Dec 2020 17:20:38 +0000 (09:20 -0800)]
LP1888723 Unsaved changes navigation warning

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Add/Manage item notes from catalog holdings
Bill Erickson [Thu, 24 Sep 2020 19:53:16 +0000 (15:53 -0400)]
LP1888723 Add/Manage item notes from catalog holdings

Adds an entry point for adding and managing Item Notes from the Angular
staff catalog holdings view.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Item notes dialog and volcopy entry point
Bill Erickson [Thu, 24 Sep 2020 19:39:45 +0000 (15:39 -0400)]
LP1888723 Item notes dialog and volcopy entry point

Support for adding new item notes to one or more items in the copy
editor interface.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Copy tag dialog placeholder fixes
Bill Erickson [Thu, 24 Sep 2020 18:45:34 +0000 (14:45 -0400)]
LP1888723 Copy tag dialog placeholder fixes

Change the placeholder for the tag label to read 'Enter tag label'.

Modify the 'Select Tag Type' text to 'Select tag type' for consistent
casing.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Volcopy parts on demand; checkdigit preference
Bill Erickson [Mon, 14 Sep 2020 18:43:25 +0000 (14:43 -0400)]
LP1888723 Volcopy parts on demand; checkdigit preference

Support creating monograph parts on the fly in the Angular holdings
editor.

Create a separate preference for controlling the visibility of the 'Use
Checkdigit' checkbox.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Combobox avoids clearing selected for freetext
Bill Erickson [Mon, 14 Sep 2020 18:27:34 +0000 (14:27 -0400)]
LP1888723 Combobox avoids clearing selected for freetext

Follow-up to LP#1850547: Avoid clearing the selected item in the
combobox when selectedId is set to null in cases where freetext is
enabled and a freetext value is present.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Item attrs edit owning lib change repair
Bill Erickson [Thu, 10 Sep 2020 21:59:23 +0000 (17:59 -0400)]
LP1888723 Item attrs edit owning lib change repair

Fixes a thinko in the item update code when changing the owning lib for
an item.  A value must be passed to copy.ischange(...) to have any
effect.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Item attributes editor can now clear stat cats
Bill Erickson [Thu, 10 Sep 2020 21:38:10 +0000 (17:38 -0400)]
LP1888723 Item attributes editor can now clear stat cats

Correctly implement stat cat copy map deletion in the Angular holdings
editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Angular volcopy UI mods and repairs
Bill Erickson [Wed, 26 Aug 2020 22:09:11 +0000 (18:09 -0400)]
LP1888723 Angular volcopy UI mods and repairs

* Use plus/minus buttons for adding and removing vols and copies.
* Support adding multiple vols and copies via add-multi pop-over
* Support hiding the Parts column
* Move Generate Barcodes and Use Checkdigit to bottom row.
* Collapse Batch Actions row by default, state stored in preferences.
* Fix issue where loading a record with no holdings would result in a
  mostly image page.
* Various display/layout repairs for showing/hiding columns

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Holdings refresh handles deleted call numbers
Bill Erickson [Mon, 24 Aug 2020 16:16:49 +0000 (12:16 -0400)]
LP1888723 Holdings refresh handles deleted call numbers

Teach the holdings grid in the staff catalog to correctly remove deleted
volumes from its tree when holding are modified in another tab.

To test, in the holding editor, modify a call number to have the same
label as another call number with the same owning org unit and save.  On
the backend, this will result in one of the call numbers getting
deleted.  Confirm the deleted call number no longer appears in the
holdings grid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Angular holdings broadcast changes
Bill Erickson [Tue, 18 Aug 2020 20:44:34 +0000 (16:44 -0400)]
LP1888723 Angular holdings broadcast changes

Broadcast to other tabs information about which holdings have changed
during editing in the Angular volcopy UI.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Angular holdings trims barcode spaces
Bill Erickson [Tue, 18 Aug 2020 20:35:02 +0000 (16:35 -0400)]
LP1888723 Angular holdings trims barcode spaces

The barcode input form trims leading and trailing spaces from barcodes
in the Angular holdings editor.

Spaces in the middle of the barcode are not removed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Angular holdings from catalog edit link; 1i8n repairs
Bill Erickson [Fri, 14 Aug 2020 16:48:29 +0000 (12:48 -0400)]
LP1888723 Angular holdings from catalog edit link; 1i8n repairs

The 'Edit' link in the copy table within the Angular staff catalog nows
directs users to the Angular volcopy editor.

Remove a number of nested 1i8n declarations.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Angular Holdings Maint / Item Attr Release Notes
Bill Erickson [Thu, 23 Jul 2020 20:23:59 +0000 (16:23 -0400)]
LP1888723 Angular Holdings Maint / Item Attr Release Notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Angular Holdings Maintenance / Item Attributes Editor
Bill Erickson [Thu, 4 Jun 2020 16:36:09 +0000 (12:36 -0400)]
LP1888723 Angular Holdings Maintenance / Item Attributes Editor

Angular port of the holdings and item attributes editors interfaces.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Angular File exporter service
Bill Erickson [Tue, 23 Jun 2020 20:57:07 +0000 (16:57 -0400)]
LP1888723 Angular File exporter service

Package up some of the nitty gritty of supporting file exports from the
Angular client into a utility service.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 combobox down arrow same as click
Bill Erickson [Thu, 2 Jul 2020 21:39:00 +0000 (17:39 -0400)]
LP1888723 combobox down arrow same as click

<eg-combobox /> now treats down arrow as the same as a click operation,
allowing for activation of selectabled options dropdown via keyboard.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1888723 Cat vol update API repairs
Bill Erickson [Thu, 2 Jul 2020 20:56:46 +0000 (16:56 -0400)]
LP1888723 Cat vol update API repairs

Repair cases where subs in the volume update API failed to return the
expected response constructs, specifically (response, event).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>