old-git.evergreen-ils.org Git - working/Evergreen.git/log

LP1850555 Item location selector improvements

* Ensure that the desired location is always available in the selector
  regardless of whether the staff have permission to use the location.

* Display org unit short name for selected locations simimilar to how
  they are displayed in the selector dropdown.

* Adds an <Unset> option in cases where the new 'required' flag is set
  to false.  This explicitly makes it possible for staff to cleare the
  value.

* Gracefully handle cases where locations from no org units are eligible
  for display.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Bill Erickson [Wed, 6 Nov 2019 17:41:32 +0000 (12:41 -0500)]

LP1850555 Angular Item (Copy) Location Select Component

<eg-item-location-select .../>

Adds a new item location select component which filters the list of
displayed locations based on a permission-check org or a specific
context org unit.

Values in the selector are decorated with the org unit short name in
parens after the location name to clarify the owning lib.

Sandbox example included.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Bill Erickson [Tue, 16 Jun 2020 21:48:25 +0000 (17:48 -0400)]

LPXXX Angular Volcopy

Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Bill Erickson [Wed, 27 May 2020 21:04:24 +0000 (17:04 -0400)]

VOLCOPY Item attr batch component

Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Bill Erickson [Tue, 16 Jun 2020 21:05:22 +0000 (17:05 -0400)]

LPXXX Angular Volcopy

Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Bill Erickson [Wed, 13 May 2020 16:17:19 +0000 (12:17 -0400)]

LP1878079 Staffcat 'Edit' items / call numbers support

Adds support to the Angular staff catalog to properly handle requests
to Edit Items, Edit Call Numbers, and Edit Call Numbers and Items.
Prior to his change, these operations would behave more like Add
operations than Edit operations.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Bill Erickson [Mon, 11 May 2020 19:10:37 +0000 (15:10 -0400)]

LP1878079 Staffcat Add Call Nums honors selected orgs

When adding new call numbers from the Angular staff catalog Holdings
View grid, take all selected grid rows into consideration when
determining how many call numbers to add and what their owning libs
should be.

To test:
* Navigate to the Holdings View tab of a record detail page in the Angular
  staff catalog.
* Select multiple rows in the grid which are org unit-only rows (i.e.
  the row does not refer to a specific call number or item).
* From the action menu / right client menu, select "Add Callnumbers"
* Confirm that a call number entry for each selected org unit is present
  in the spawned holdings editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Bill Erickson [Tue, 16 Jun 2020 20:19:55 +0000 (16:19 -0400)]

LPXXX Angular Volcopy

Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Bill Erickson [Tue, 16 Jun 2020 16:35:54 +0000 (12:35 -0400)]

LPXXX Angular accesskey sort repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Bill Erickson [Fri, 5 Jun 2020 20:54:23 +0000 (16:54 -0400)]

LPXXX Angular Volcopy

Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Bill Erickson [Thu, 30 Apr 2020 19:33:57 +0000 (15:33 -0400)]

LPXXX Barcode auto-generate API get skip-dupes option

Option to verify generated barcodes do not exist in the database. When
a dupe is found, skip over it and continue to the next barcode.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Bill Erickson [Thu, 4 Jun 2020 16:36:09 +0000 (12:36 -0400)]

LPXXX Angular Volcopy

Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Bill Erickson [Wed, 24 Jun 2020 16:25:16 +0000 (12:25 -0400)]

LP1884787 ng lint and unit test repairs

Minor lint update, some of which affected tests and required a few
additional test spec updates.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

commit | commitdiff | tree

Galen Charlton [Tue, 23 Jun 2020 18:39:45 +0000 (14:39 -0400)]

LP#1884787: update Angular staff client to work with momement-timezone >= 0.5.29

Now that moment-timezone ships with an index.d.ts (as of 0.5.29), this
patch updates how moment-timezone is imported and used since we
now have to care more about type-checking.

Among other things, this updates the ScheduleRow interface to account
for the fact that with the stricter type checking coming from the recent
moment-timezone change, ScheduleRow.time as a moment.Moment object
cannot be in the same interface as a string index type.

To test
-------
[1] Make sure that results of  'npm run test' are clean.
[2] Create a reservation or two in the booking interface and
    verify that scheduled reservations show up on the grid
    in the create reservations page.
[3] Verify that the icons indicating whether resources are
    available or not at a given time are correct on the
    create reservations grid.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Galen Charlton [Tue, 23 Jun 2020 18:39:13 +0000 (14:39 -0400)]

LP#1884787: update package-lock.json

Reflects current npm update state as of 2020-06-23.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Galen Charlton [Tue, 23 Jun 2020 18:38:44 +0000 (14:38 -0400)]

LP#1884787: bump up moment and moment-timezone

Latest as of 2020-06-23.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Galen Charlton [Mon, 22 Jun 2020 21:43:07 +0000 (17:43 -0400)]

LP#1851306: (follow-up) add additional test stubs

Accounting for changes in ReservationActionsService.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

commit | commitdiff | tree

Galen Charlton [Thu, 18 Jun 2020 20:27:19 +0000 (16:27 -0400)]

LP#1851306: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

commit | commitdiff | tree

Galen Charlton [Thu, 18 Jun 2020 20:13:21 +0000 (16:13 -0400)]

LP#1851306: (follow-up) fix printing of destination

Updated the default template for booking capture
transit slips to print the shortname of the destination.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

commit | commitdiff | tree

Galen Charlton [Thu, 18 Jun 2020 20:12:08 +0000 (16:12 -0400)]

LP#1851306: (follow-up) add get_org_unit() helper to print templates

The immediate use case is allowing the destination library's
shortname to print on booking capture slips.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

commit | commitdiff | tree

Galen Charlton [Thu, 18 Jun 2020 17:56:40 +0000 (13:56 -0400)]

LP#1851306: (follow-up) fix AngularJS staff client navbar link

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

commit | commitdiff | tree

Jane Sandberg [Sun, 17 Nov 2019 04:50:00 +0000 (20:50 -0800)]

LP1851306: Port Capture Booking Resource to Angular

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

commit | commitdiff | tree

Bill Erickson [Fri, 12 Jun 2020 14:20:20 +0000 (10:20 -0400)]

3.5 Post-Beta Release Notes Additions

Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Bill Erickson [Fri, 12 Jun 2020 15:20:29 +0000 (11:20 -0400)]

LP1883267 Minor release note tweaks

Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Mike Rylander [Fri, 12 Jun 2020 14:55:29 +0000 (10:55 -0400)]

LP#1883267: Adding release notes

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Mike Rylander [Fri, 12 Jun 2020 14:36:48 +0000 (10:36 -0400)]

LP#1883267: Never cache Angular index.html

If we cache index.html then clients will be delayed seeing updates in
normal circumstances.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Dan Wells [Thu, 11 Jun 2020 21:03:34 +0000 (17:03 -0400)]

Forward-port 3.4.3 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

commit | commitdiff | tree

Dan Wells [Thu, 11 Jun 2020 20:53:53 +0000 (16:53 -0400)]

Forward-port 3.3.7 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

commit | commitdiff | tree

Mike Rylander [Wed, 10 Jun 2020 19:29:16 +0000 (15:29 -0400)]

LP#1882937: Comment and dead-code cleanup

Adjust comments in Storage::Driver::Pg to remove references to
Class::DBI::Replication, which we did not end up using.

Also remove a commented-out sub that purported to make use of a function
that did not exist in the home-grown multi-db implementation.

NOTE: While unused, the multi-db implementation in Storage::Driver::Pg
intelligently decides when to use a read-only secondary based on the
existence of a transaction or the "write-iness" state controlled by the
caller, and does not require separate main (or primary) and secondary
db lists.

Signed-off-by: Mike Rylander <mrylander@gmail.com>

commit | commitdiff | tree

Sam Link [Wed, 10 Jun 2020 12:32:26 +0000 (08:32 -0400)]

LP1882937 Replace master/slave terminology

In Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg.pm
changed master/slave terminology to more neutral primary/standby.

Signed-off-by: Mike Rylander <mrylander@gmail.com>

commit | commitdiff | tree

Jason Boyer [Thu, 21 May 2020 22:19:57 +0000 (18:19 -0400)]

LP1880035: Fix rendering of monograph parts

A BorderContainer is primarily used to allow anchoring views to the top,
bottom, left, or right of the container and usually allows the use of a
splitter to resize child views. Since we don't use any of that and don't
need such a control, it was apparrently just luck that it worked at all.
Using a plain ContentPane instead allows the page to render as expected.

Thanks to Galen Charlton for tracking this down and finding the fix.

Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

commit | commitdiff | tree

Bill Erickson [Thu, 22 Aug 2019 14:12:53 +0000 (10:12 -0400)]

LP1837656 Org proximity admin disable org filter

Disable the org unit filter for the auto-generated org unit proximity
adjustment admin page so that it does not automatically filter the grid by
any of the org unit fields.

Modify the IDL to indicate that the 'pos' field on the org unit
proximity adjustement class is required.

To test:

1. Navigate to
/eg2/en-US/staff/admin/server/actor/org_unit_proximity_adjustment
2. Create an adjustment if non exist.
3. Confirm the 'Position' field is now required.
4. Confirm new adjusment row appears in the grid after it's created.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

commit | commitdiff | tree

Bill Erickson [Wed, 6 May 2020 14:47:37 +0000 (10:47 -0400)]

LP1847800 Admin grid filter display, default fields, IDL repairs

* Indicate in the UI when grid filters are applied via URL and offer a
  way for the user to clear the filters.

* When grid filters are applied, use them as the basis for the "Default
  New Record" object which seeds the fm-editor.  In other words, apply
  default values to the fm-editor to match the grid filters.

* Repair some IDL thinkos and add more 'selector' values.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

commit | commitdiff | tree

Jeff Davis [Tue, 5 May 2020 21:37:05 +0000 (14:37 -0700)]

LP#1847800: secondary admin pages for Authority Control Sets and Authority Thesauri

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

commit | commitdiff | tree

Jeff Davis [Tue, 5 May 2020 21:11:41 +0000 (14:11 -0700)]

LP#1847800 / LP#1847810: secondary admin pages: MARC Search/Facet Fields -> virtual index definitions

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

commit | commitdiff | tree

Jeff Davis [Tue, 5 May 2020 19:16:37 +0000 (12:16 -0700)]

LP#1847800 / LP#1847781: secondary admin pages for MARC Import Remove Fields

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

commit | commitdiff | tree

Bill Erickson [Wed, 29 Apr 2020 21:27:23 +0000 (17:27 -0400)]

LP1847800 Admin grids support config_field links

For IDL fields which have config_field=true, the value in the admin grid
is rendered as a link to the grid for the linked field. Additionally,
the link contains a gridFilter so the destination grid only displays
rows related to the selected field.

Adds config_field=true values for z39.50 source and two links for hard
due date and hard due date values.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

commit | commitdiff | tree

Jeff Davis [Wed, 18 Dec 2019 00:06:19 +0000 (16:06 -0800)]

LP#1847800 / LP#1834687: secondary admin pages: config_field attribute in IDL

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

commit | commitdiff | tree

Chris Sharp [Mon, 4 May 2020 17:20:09 +0000 (13:20 -0400)]

LP#1873048 - Stamp upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

commit | commitdiff | tree

Jeff Davis [Thu, 30 Apr 2020 17:36:44 +0000 (10:36 -0700)]

LP#1873048: add scoped retrieve perms for booking resource types and resources

In the XUL client, when selecting a resource type, the list was limited
by owning library.  But in the web client, the list would show all
resource types across all libraries.  This commit addresses that
regression by adding a new VIEW_BOOKING_RESOURCE_TYPE permission with
context_field in the IDL.  That way, users only see resource types owned
by org units where they have the permission.

While we're at it, a new VIEW_BOOKING_RESOURCE perm is also added for
resources.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

commit | commitdiff | tree

Jeff Davis [Tue, 28 Apr 2020 20:52:52 +0000 (13:52 -0700)]

LP#1865533: save changes on Edit Hold in My Account

When editing a hold in the OPAC, changes are not saved if the SMS field
is blank. The sms_notify value is being passed as an empty string, and
this non-null value violates the "sms_check" constraint on
action.hold_request. Replacing the empty string with undef allows the
hold update to succeed.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

commit | commitdiff | tree

Daniel Pearl [Wed, 13 Mar 2019 14:07:17 +0000 (10:07 -0400)]

LP1787636: Sort Libraries without Holdings In Holdings View

Empty libraries in holdings view are listed at the end of the library
list instead of integrated within the list. This patch sorts them
within the list.

Signed-off-by: Daniel Pearl <dpearl@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

commit | commitdiff | tree

Jason Stephenson [Thu, 19 Mar 2020 13:45:18 +0000 (09:45 -0400)]

LP1787636: Remove right justification in grid view

Align all owning libraries to the left as requested in the bug
description and comments.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

commit | commitdiff | tree

Jason Stephenson [Thu, 26 Mar 2020 14:47:46 +0000 (10:47 -0400)]

LP1813088: Coerce Values to String in egGridValueFilter

Coerce values to string in the switch for Boolean columns in the main
egGridValueFilter function. This came about after an IRC conversation
with Mike Rylander who suggested this as a possible fix. It should
when field values are strings, integers, or Booleans.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

commit | commitdiff | tree

Bill Erickson [Tue, 31 Mar 2020 15:51:41 +0000 (11:51 -0400)]

LP1869906 Angular staff cat browse links

Use routerLinks instead of click-handlers for browse results links so
users have the option to control-click and open individual results in a
new tab.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

commit | commitdiff | tree

Jason Stephenson [Thu, 30 Apr 2020 18:09:40 +0000 (14:09 -0400)]

LP#1876163 - Fix Angular Test Failure

ERROR in app/core/format.spec.ts - TS2554: Expected 4 arguments,
but got 3.

orgService = new OrgService(netService, authService, pcrudService);

Commit 9e8d662f418 added a new first argument to the OrgService
constructor and two files needed updates:

* app/core/format.spec.ts
* src/app/core/org.spec.ts

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

commit | commitdiff | tree

Ben Shum [Thu, 30 Apr 2020 18:16:19 +0000 (14:16 -0400)]

LP#1869794: Stamping upgrade script

Signed-off-by: Ben Shum <ben@evergreener.net>

commit | commitdiff | tree

Jason Etheridge [Wed, 26 Feb 2020 14:40:04 +0000 (09:40 -0500)]

LP#1869794 new best hold sort order

owning lib to requestee home lib proximity

implementation, release notes and TechRef tweak

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Lindsay Stratton <lstratton@wlsmail.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

commit | commitdiff | tree

Bill Erickson [Wed, 29 Apr 2020 14:14:34 +0000 (10:14 -0400)]

LP1858448 Aged money pgtap test repair

Enable the "age money with circulations" setting in the original aged
money pgtap test so the aged money it seeks may be created and found.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>

commit | commitdiff | tree

Chris Sharp [Wed, 29 Apr 2020 15:40:08 +0000 (11:40 -0400)]

LP#1873286 - Add release notes entry

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Evergreen ILS

RSS Atom