LP#1996818 Issues Placing Holds from the Patron Record

Set the hold target using the same cookie Angular uses when
placing holds from AngularJS patron records.

Clear the cookie and broadcast to all catalog tabs to remove
the hold target when:
- the Clear button for the hold target is pressed
- the hold interface loads a different patron
- a different Angular route loads
- AngularJS app starts (left the Angular context)

When a catalog tab is closed, clear the cookie and broadcast
it so that any open catalog tabs can restore it.

To test:
1. After loading the patch, build Angular and AngularJS
2. Place a hold from AngJS patron record, note target is set
3. Open multiple catalog tabs
5. Close one catalog tab, note target persists in other tabs
6. Click Clear button, note target is cleared in all tabs
7. Repeat steps 2-3, load a different patron in the hold
   interface, note target is cleared in all tabs
8. Repeat steps 2-3, click the home icon in the navbar, note
   target is cleared in all tabs
9. Repeat steps 2-3, click AngJS Check Out in the navbar,
   note target is cleared in all tabs

Signed-off-by: Dan Briem <dbriem@wlsmail.org>

correct antora.yml for the main branch

It needs to be 'latest' in the main branch in order to not
conflict with the target for other release stream branches

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Release note fixes

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Release notes update

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Clear out misc doc file

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

add some attributions to the release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

3.11 Release Notes

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Updating bootstrap opac relator codes for 3.11

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

Updating relator codes for 3.11

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP1983628: Add editor for item notes

Test plan:
1. Open your favorite bib record in the staff catalog
2. On the item table tab, find a barcode and click "Edit"
3. Press the Item Notes button.
4. Add a note with a title and value.
5. Press Apply Changes
6. Press Apply All and Save
7. Press the Item Notes button again.
8. Without this commit, you will not have a way to edit
these notes.  With this commit, you will have an edit
button.
9. Confirm that you can Back out of the editor without
making changes
10. Confirm that you can make changes and they persist.

This commit also adds a test to confirm that this fm-editor
won't inadvertently fetch every single row in asset.copy
(as a linked field).

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

Docs: updating site.yml for 3.11 docs

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: LP1836221 correction for archive stat cat

Taking out the 'aged' in the circulation data for 'Archive with Circs'.  Two changes were made.

Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

LP 1955666 Remove RFID Product Integrations page from docs

Removed obsolete RFID Product Information page as well as the link to the page.

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: Custom Penalties edits for 3.11

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

LP2019894 Fix stacked buttons in fund details modal

Corrects the alignment of the "Create Allocation" and "Transfer Money"
buttons in the Fund Details modal (Acquisitions Administration > Fund
Administration).

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP# 2004205: quiet warn logs from stat cat warnings

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1887866: add aria-labels to AngularJS grid controls

This is a modified version of a patch originally by Mike Risher
to add some aria-label attributes to the AngularJS grid.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Forward port database upgrades

Signed-off-by: Jason Stephenson <jason@sigio.com>

Update 3.10 release notes for security fixes

Signed-off-by: Jason Stephenson <jason@sigio.com>

Improve 3.9.3 release notes formatting

Signed-off-by: Jason Stephenson <jason@sigio.com>

Update release notes with security fixes

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#2004055: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#2004055: Stamp Upgrade Script

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#2004055: Simpler Display Field highlighting

This commit uses database functions to precompute the normalized and
tokenized tsquery required for highlighting before it is returned to the
user, and disallows highlight-time compilation of the highlight map.
The primary purpose of this is to avoid the chance for user input to
find its way directly into SQL statements, but an additional benefit is
that it becomes much simpler for high level application code to make use
of Display Field highlighting in non-search contexts.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

Malicious search protect release notes

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

Allow QP tester to run without a full stack in simple situations

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#1775958: Rework pullup mechanism to flatten more nested queries

The bulk of this commit reworks the query tree pullup logic, which is
responsible for simplifying the query tree that is used to generate the
SQL query for search.  In particular, we now do a better job of finding
opportunities to merge adjacent parts of the query that have the same
requested_class (pre-dealiasing) in the face of boolean OR operators,
explicit grouping, and alternating requested_class values.  The result
is fewer joins in the SQL, which should speed up all but the most
trivial searches, and generally help protect the database from mis- or
mal-constructed queries.  We also now use CTEs to separate branches of
the logical search tree into descrete subqueries, which helps reduce
the total core query JOINs, and provides the planner with more options
for join order.

This also does away with the conversion of a negated atom into an
"un-phrase".  Instead, we just detect and handle those directly as atoms
with a prefix, as appropriate.  This allows single negated words to be
used directly in the core tsquery construct, rather than having them
require a separate join and special where clause.

Additionally, this commit handles phrases differently at both the QP and
SQL level, making use of Postgres's phrase support in modern versions
and simplifying how they're handled within the base parse tree
structure.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#1908576: Stamp Upgrade Script

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

Login redirect restriction release notes

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#1908576: Restrict login redirection

This commit implements a new global flag: opac.login_redirect_domains
When this flag is enabled, redirection from login via redirect_to will
be restricted to local URLs.  For local URLs, they must either start
with a / (provide an absolute path) or the hostname in the URL must
match the current hostname and have a scheme of http, https, ftp, or
ftps.

The value for the global flag can be set to a list of comma-separated
domain names.  Redirection to these domains, and subdomains/hosts
thereof, will also be allowed.  For all non-local URLs allowed by the
global flag value, the scheme must be one of http, https, ftp, or ftps.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

Translation updates - xtb files - main

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Translation updates - po files - main

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: draft release notes for 3.10.2 and 3.9.3

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

LP#2000482: (follow-up) remove duplicated text

Might have snuck in during a merge conflict resolution.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP 2017913 Add html filter to reason

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP2017913 Display Upcoming Closures in OPAC

Displays the upcoming closures (max of 10) that have been entered through the
Closed Dates Editor in the OPAC on the library info pages for each branch.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP2017913 Display Upcoming Closures in OPAC

Adds ability to display detailed hours when closure is partial day.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP2017913 Adds release note

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP2017913 Display Closures in OPAC

Adjusted CSS due to testing feedback and also applied CSS to open
hours display on the same page for consistency.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#2019150: link to AngularJS Patron Requests interface

Due to a presumed timing issue in 2018, the AngularJS patron purchase
request interface created in bug 1774277 was never linked to from the
Angular navbar (only the AngularJS one).

This patch fixes this.

To test
-------
[1] Apply the patch.
[2] From the Angular menu, go to Acquisitions -> Patron Requests
    and verify that it loads the AngularJS interface rather
    than the legacy Dojo one.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP2018939 Restore barcode label for course materials

Replaces a <label> for course material barcodes that was accidentally
removed.

Also adds a CSS rule to restore single-line input group styling.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP2009092 Line item list checkbox labels

Adds <label>s for the line item ID checkboxes in the PO list.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1915326: Followup to Silence Offline / Shared Worker Errors

The user agent string hasn't been 'PhantomJS' for quite some time, so look for
'Headless' and add that to the Firefox launcher. Also redirect requests for
offline-db-worker.js to the current directory.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP#1915326: fix AngularJS test suite

Several tests of egOrg started failing when Lovefield
was added as a dependency. This patch fixes them by
ensuring that Lovefield is loaded.

To test
-------
[1] Go to Open-ILS/web/js/ui/default/staff and run
    `npm run test`. Note that six tests fail because
    'lf' is undefined.
[2] Apply the patch and repeat step 1. This time, all
    of the tests should pass.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

Translation updates - newpot - main

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1778567: don't return cached list/tree before updating

The absorbList function can be used to append items to an existing
cached list (and ditto for absorbTree), so we shouldn't start off by
returning the cached version.

Thanks to James Fournie for catching this.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP2002363 Aria labels for catalog search +/- buttons

Adds aria-label to the staff catalog search row plus/minus buttons. The
labels match the title attributes on the buttons, to allow dictation
users to identify the phrases that should be spoken to select the
buttons.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Chrystal Messam <messamc@liveoakpl.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1808016: improve error handling by open-ils.pcrud

This patch ensures that requests to open-ils.pcrud return
an error code (before the request completion code) when
a permissions or constraint check fails.

To test
-------
[1] Make an invalid request, e.g., by attempting to create a claim
    type whose owner is not set in the Acquisitions Claiming admin
    interface.
[2] Note that the user interface reports that the action succeeds
    (although the new claim type is not actually created).
[3] Apply the patch and repeat step 1. This time, the admin interface
    shoudl report that the creation failed.

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1828468 Release note

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1828468 keyboard navigation for Angular nav bar

Adds ng-Bootstrap directives for keyboard navigation support in the main
navigation bar. Includes visible focus styling for both buttons and
links.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP2008918: (follow-up) standardize on the info cyan for the modal headers

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP2008918: use new default colors for modal headers

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP2008918: default modal background color

To test:
1) Open the holdings editor in the angular staff catalog
2) right click on an item
3) select Add/Manage Item notes
4) Note that you can't see the text at the top of the modal, nor can you see the close button
5) Apply this patch and repeat steps 1-3
6) Note that the modal header is a darker color, so the text and close button are again visible.

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#2019032: restore functionality of two line item actions

The "Add Brief Record" and "Load Bibs and Items" actions in the
Angular line item manager stopped working after the upgrade
to Angular 15. It turns out that the routerLink values associated
with those two actions were always incorrect, but for some
reason Angular 12's router worked around the error. Angular 15
does not, hence this patch.

To test
-------
[1] Navigate to a pending purchase order.
[2] Attempt the "Add Brief Record" and "Load Bibs and Items" items
    from the Actions drop-down. Note that the request forms
    do not display and the purchase order title becomes
    "Purchase Order #NaN (pending)".
[3] Apply the patch and repeat step 2. This time, the two
    actions should bring up the correct forms.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Jeff Godin <jgodin@tadl.org>

LP#1901072 Menus Don't Recognize Max Recent Patrons Setting

On the Angular menu, both Retrieve Last Patron and Recent Patrons
links appear under Circulation, regardless of what the "Number of
Retrievable Recent Patrons" setting is set to.

On both the AngularJS and Angular menus, both links appear under
Circulation (Experimental).

On the Angular menu, Circulation->Retrieve Recent Patrons links
to the Angular interface instead of the AngularJS interface.

To test this fix:
1. Set Enable Angular Circulation Menu setting to True
2. Set Number of Retrievable Recent Patrons setting to 0
   - Retrieve Last Patron and Recent Patrons links don't appear
3. Set to 1 or unset (default fallback is 1)
   - Retrieve Last Patron link appears only
4. Set to greather than 1
   - both links appear
   - Circulation->Retrieve Recent Patrons loads the AngJS interface

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Susan Morrison <smorrison@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP2015137 Tab order for admin splash link tables

Replaces row/column logic with CSS columns in the link table component
used in settings screens. This allows the user to tab through the
settings in alphabetical order, rather than the three-across groupings
that previously broke up similarly named settings.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP#2013223: quiet browser console noise from some AngularJS grids

This patch quells console error noise from certain AngularJS grids.

To test
-------
[1] Go to the AngularJS Renew Items, Holds Shelf, or patron holds list
    pages.
[2] Note that the brower console has a lot of "TypeError: action.handler is undefined"
    error messages.
[3] Apply the patch and repeat step 1. This time, the "action.handler"
    errors should be gone.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1920826: Add release notes and stamp upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1920826: ensure that some DB updates missed in 3.6.0 are included

This patch fixes a situation where an Evergreen database that had
been been upgraded to 3.6.0 at some point in its past using the
3.5.1-3.6.0 DB update script may be missing some DB revisions.

To test
-------
[1] Locate a test database that had been upgraded to 3.6.0 at some point
    and is missing some or all of DB revisions 1236-1240.
[2] Run the DB update in this patch.
[3] Verify that the DB revisions are in place and that the following
    bugs are resolved:

    - https://bugs.launchpad.net/evergreen/+bug/1788260 (1236)
    - https://bugs.launchpad.net/evergreen/+bug/1908727 (1237)
    - https://bugs.launchpad.net/evergreen/+bug/1835127 (1238)
    - https://bugs.launchpad.net/evergreen/+bug/1910891 (also 1238)
    - https://bugs.launchpad.net/evergreen/+bug/1882825 (1239)
    - https://bugs.launchpad.net/evergreen/+bug/1096209 (1240)

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1989195: (follow-up) flesh out Chrome e2e options

- add instructions to the cheat sheet
- add a chrome-headless mode

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1989195: (follow-up) minor reformatting of Angular cheat sheet

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1989195: upgrade nightwatch

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1989195: Update nightwatch selectors

Also, remove flakey test for now

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1989195: Nightwatch Chrome Config & Notes

This does not install the chrome driver by default.  It only modifies
the config to support chrome as an option.

For those that want to test with Chrome in addition to Firefox:

$ npm install --save-dev chromedriver
$ ng e2e --env chrome

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1989195: Use nightwatch for e2e testing angular client

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#2003946 Add Release Note

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP2003946 LI ID in Search jumps to item detail page

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1972917: fix circ modifier column in course materials grid

To test:
1. Add a circulation modifier to your system if it doesn't
already have some.
2. In Local Admin > Course Materials > Edit Course > Course
Materials, turn on the circ modifier column in the grid.
3. Associate an item with the course using its barcode.
Make sure you have selected a circulation modifier and
checked the circulation modifier box.
4. Press the "Add Material" button.
5. Note that the circulation modifier column says
"[Object object]"
6. Apply this patch and repeat steps 2-4.
7. Note that the column now has the name of the circulation
modifier.

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP2001728 - Don't display circ_staff for opac and autorenewals

Item Status Circ History List: Displays the placeholder <OPAC Renewal>
or <Auto-renewal> instead of the patron information in the Check Out
Staff field.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#2004052 Hold Shelf Actions Menu Includes Irrelevant Actions

Removes Activate, Suspend, Set Top of Queue, Un-Set Top of Queue,
Set Desired Item Quality, Transfer to Marked Title from the
actions menu on the Holds Shelf grid.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1940321: Remove apt-key from Makefile.debian

Bullseye is the end of the line for apt-key, but we don't need to wait
until it's gone to give it a send-off.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP2011434 stamping upgrade script

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP2011434 (follow-up): use NOT VALID / VALIDATE CONSTRAINT pattern to minimize locking on action.hold_request

Also simplify the WHERE clause in the UPDATE statement, making its intentions clearer to my eye at least

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

adding a foreign key check for selction_ou on action.hold_request

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
adding a check in the upgrade script for a non-existent selection_ou and changing it to the request_lib

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP2015481: Re-align Labels for Circ History

Move Call number to the end of the Circ History table to match Items Out
and also correct the label order for narrow screen CSS.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP2015141 Labels for email record math captcha

Adds a <label> tag surrounding the math problem shown to users who are
not logged in when they email a record from the OPAC.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#2018534: treat year as numeric when retrieving item circs by year

The open-ils.pcrud.search.circbyyr API uses EXTRACT to extract the year
from circulation timestamps.  In recent versions of Postgres, the return
type for EXTRACT was changed from double precision to numeric (thanks to
Jason Boyer for noticing this!); for obscure reasons, this causes pcrud
to return the year as a string instead of a number.  So, let's get the
staff client to force those values to be numbers before doing math with
them.

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP2018208 Empty alt for result record images, icons

Adds empty alt attributes for jacket images and format icons that are
immediately followed by equivalent text representations, and are
therefore redundant for screen reader users.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Translation updates - newpot - main branch

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP2006971 Stamping SQL Upgrade (Custom Penalties)

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#2006971: Batch penalty script additions

Teach batch penalty processing script to accept penalty subsets,
allow alternate context location based on each patron home library,
and allow has/does-not-have penalty command line options to look up
custom system penalties by name.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1944986 Has / No-Has Penalty filters

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org>

LP1944986 Patron penalty batch updater script

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org>

LP#2006971: Custom system penalty business logic

Allow processing of penalty subsets, and the option of patron home
context rather than staff workstation location context.

Adjust Collections API to make use of the custom penalty versions
where applicable.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#2006971: Custom system penalties

This development creates a set of Library Settings that a staff
member with appropriate permissions can use to set a custom value
for a stock penalty according to the following workflow:

-- Create a new penalty in Standing Penalties
-- Set the desired penalty threshold in Group Penalty Thresholds
-- Use the Library Setting to associate your new penalty with a
   stock system penalty and organizational unit context.

The custom penalty will be automatically applied in place of the
stock penalty at the specified org units, when the patrons'
account meets the penalty criteria.

System penalties that can be overridden:

 * PATRON_EXCEEDS_FINES
 * PATRON_EXCEEDS_OVERDUE_COUNT
 * PATRON_EXCEEDS_CHECKOUT_COUNT
 * PATRON_EXCEEDS_LOST_COUNT
 * PATRON_EXCEEDS_LONGOVERDUE_COUNT
 * PATRON_EXCEEDS_COLLECTIONS_WARNING
 * PATRON_IN_COLLECTIONS

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1965446 Stamping upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1965446 Option to Disable Title-Level Holds on Bib Records with Parts

This feature adds one global flag and one library setting, respectively:

    * circ.holds.api_require_monographic_part_when_present
      Holds: Require Monographic Part When Present for hold check.
    * circ.holds.ui_require_monographic_part_when_present
      Require Monographic Part when Present

Normally the selection of a monographic part during hold placement is optional if there is at least one copy
on the bib without a monographic part.  A true value for this setting for any involved owning library for the
bib or for the global flag will require part selection even under this condition.  This essentially removes
the All/Any Parts option from the part selection drop-down, for both versions of the public catalog (TPAC and
BOOPAC), and for the Angular staff catalog interface.

At the API level, we consider just the global flag and will throw a TITLE_HOLD_WHEN_MONOGRAPHIC_PART_REQUIRED
event for a title hold request when there are items with monographic parts on the bib.  It is possible for
the library settings and the global flag to differ, but the global flag will catch every instance of hold
placement including those by third party callers, SIP, etc.

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxoli.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

Translation updates - newpot - main branch

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP2018403 Update sr-only class in Facets sidebar

Changes the new Facets sidebar heading in the staff catalog search
results from the Bootstrap 4 sr-only class to the Bootstrap 5 one,
visually-hidden.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1901932: (follow-up) add caveats to documentation

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1901932: (follow-up) update dataset for upcoming 3.11-beta release

As it happens, very little actually changed, though a significant
chunk of make_concerto_from_evergreen_db.pl's output was not checked
it because it consisted purely of differences in timestamp columns
due to time zone differences.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1901932: (follow-up) update help in make_release

This patch clarifies the usage of make_release during
updates of Enhanced Concerto and makes it clear that
such updates are considered experimental for now.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1901932: (follow-up) update release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1901932 Wish List - Enhanced Concerto dataset

Tweaks to the build script, hardcoding some sequences that aren't set
automatically. Also removed the "admin" user (1) entry from actor.passwd

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1901932 Wish List - Enhanced Concerto dataset

. Adding better ECD output for master branch
. Much improved enhanced generator script
. Introducing make_release changes to incorporate the upgrade of the ECD.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1901932 Wish List - Enhanced Concerto dataset

Introducing a new concerto dataset. Loadable via eg_db_config.
Including the perl script and full documentation on this dataset
How to re-create it, etc.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1979345: Stamping upgrade script

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

LP#1979345: restrict access to holds pull list

This commit adds a new VIEW_HOLD_PULL_LIST permission.  In order to view
a library's holds pull list, you need to have the new permission at that
library.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>

LP1993305 stamp upgrade script

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1993305 Comprise SmartPay release notes

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1993305 Comprise SmartPay support, middle layer bits

Squashed commits:
  * middle
  * billing total in smartpay last_chance equivalent
  * fix xact propagation
  * remove some logging in middle layer
  * increase timeout for cached object and hope it exceeds smartpay session expiry

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1993305 Comprise SmartPay support, UI bits

Squashed commits:
  * ui
  * 0.50 minimum across the board

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1993305 Comprise SmartPay support, schema

Squashed commits:
   * schema
   * SmartPAY location ID description

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>