Dan Scott [Sun, 23 Oct 2011 23:58:53 +0000 (16:58 -0700)]
Make idlval build, rather than be dead code
The tool "idlval" contained in Open-ILS/src/c-apps can be used to check
the correctness of fieldmapper definitions in files like
Open-ILS/examples/fm_IDL.xml - but currently does not have a build
target, nor does it compile cleanly due to the use of unspecified
OpenSRF header files. This commit adds a build target, fixes the compile
problems, and installs the tool in the bin directory.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Liam Whalen [Thu, 3 Nov 2011 20:53:57 +0000 (16:53 -0400)]
Modified authority.indexing_ingest_or_delete to update MARC data
The authority.indexing_ingest_or_delete trigger in the update script
was missing a call to authority.propagate_changes which is responsible
for updating the MARC data of records affected by an auhtority merge.
This patch adds the call to authority.propagate_changes as it appears
in the authority.indexing_ingest_or_delete trigger from the file
999.functions.global.sql.
Signed-off-by: Liam Whalen <lwhalen@nrcan-rncan.gc.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Mike Rylander [Wed, 2 Nov 2011 19:53:56 +0000 (15:53 -0400)]
2.0-ification of the phrase-search fix for LP#834042
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Lebbeous Fogle-Weekley [Thu, 6 Oct 2011 16:06:09 +0000 (12:06 -0400)]
Acq: fix a bug that sometimes prevents the general search page from loading
Within Acquisitions General Search, javascript included from one file
in the <head> relies on the variable "localeStrings" being initialized
by javascript included from a file in <body>. Sometimes the wrong
javascript wins the race, you get an error about localeStrings being
undefined in the Javascript console, and the page stops loading.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Tue, 1 Nov 2011 17:29:25 +0000 (13:29 -0400)]
Force Amazon AC requests to use 10-digit ISBNs
Inspired by a patch submitted by Ian Bays <ian.bays@ptfs-europe.com>
via https://bugs.launchpad.net/evergreen/+bug/870171, this patch takes
the incoming key and, if it is longer than 10 characters (a 10-digit
ISBN or Amazon ID), attempts to normalize it and return a 10-digit ISBN.
We don't normalize all incoming keys because some sites are horribly
abusing the 020 MARC field to include an Amazon ID instead of an ISBN -
but that works in practice and we'd rather not break working
installations if we can avoid it.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Jason Stephenson [Wed, 19 Oct 2011 20:47:03 +0000 (16:47 -0400)]
Use ne on line 631 of Actor.pm.
This is so that we stop getting errors like
Argument "
1319057146.
8881216485.
4819607085" isn't numeric in numeric ne (!=) at
/usr/local/share/perl/5.10.1/OpenILS/Application/Actor.pm line 630.
in /openils/var/log/open-ils.actor_stderr.log
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Michael Peters [Thu, 27 Oct 2011 13:42:37 +0000 (09:42 -0400)]
A tweak to eg.conf to prevent against the BEAST exploit in TLS/SSL
Based on recommedation from https://community.qualys.com/blogs/securitylabs/2011/10/17/mitigating-the-beast-attack-on-tls
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Bill Erickson [Wed, 5 Oct 2011 13:39:47 +0000 (09:39 -0400)]
Z39.50 local catalog fetch-more repairs
Fixes the following problem:
When paging through local catalog results in the Z39.50 interface,
paging off then end of the local results would result in an unknown
server error caused by trying to retrieve an empty list of records.
$list->{count} in this context is the overall hit count, not the counts
in the current page of results. Note also if {count} is zero, the list
of IDs will be undef, so we use both.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Lebbeous Fogle-Weekley [Thu, 6 Oct 2011 22:06:22 +0000 (18:06 -0400)]
Avoid a possible bug in selection list deletion
This particularly matters for the "ephemeral," unnamed selection list that
Acquisitions General Search uses to hold bib records represented as
lineitems, as that list is deleted for the next run of that kind of
search.
It's possible to get lineitems onto that list that are in a state
other than "new". Code that deletes this list first deletes the
lineitems that belong to it, but that code formerly assumed that there
are two types of lineitems. "new" ones (that should be deleted) and ones
that belong to purchase orders (that should be deatched). That doesn't
necessarily cover all possible lineitems on the picklist, so deletion
ultimately fails.
This fixes that.
[update: now this bugfix incorporates a bugfix, the need for which was
detected by Ben Shum. See LP #869581]
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Sun, 16 Oct 2011 22:39:00 +0000 (18:39 -0400)]
Cache open-ils.fielder results by locale
The problem was particularly visible in search facets, but existed
before: the cache key used for fielder results did not take locale into
account, so on a multi-locale system the first locale won and populated
the cache for all other locales.
Use a session locale if provided, otherwise default to the locale set in
opensrf.xml
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Thomas Berezansky [Tue, 4 Oct 2011 19:28:36 +0000 (15:28 -0400)]
Add "submit on enter" to all advanced search boxes
Instead of just the one with an ID specified.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Mike Rylander [Thu, 13 Oct 2011 20:01:59 +0000 (16:01 -0400)]
Stamping upgrade for asset.merge_record_assets fix from dbs
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Thu, 13 Oct 2011 17:14:13 +0000 (13:14 -0400)]
Fix located URI merging in action.merge_record_assets()
Perhaps due to the unexpected results of the XPath expression, which
returns a count of nodes for subfields, etc, rather than just a count of
the number of 856 datafields, NULL was being concatenated onto a string
- which of course made the string NULL.
Use COALESCE() to prevent the NULLness from spreading and enable
action.merge_record_assets() to do the right thing.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Stephenson [Fri, 16 Sep 2011 12:52:44 +0000 (08:52 -0400)]
Fix z39.50 import isbn and issn searches on local catalog.
Make cat_search_z_style_wrapper do identifier searches for isbn and
issn.
Modify the_quest_for_knowledge to accept identifier searches for isbn
and issn.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Bill Erickson [Tue, 11 Oct 2011 21:03:57 +0000 (17:03 -0400)]
Authentication block logging
* Login too-many-auth-failures message at Info level instead of Internal
* Log the username getting blocked
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Dan Scott [Mon, 10 Oct 2011 20:15:04 +0000 (16:15 -0400)]
Fix broken Net::Z3950::SimpleServer 1.14 install
Pin the install of Net::Z3950::SimpleServer to the
known-to-work-with yaz 3.0.x version, 1.12. 1.14 introduced dependencies
on yaz 4.1.x that can't be easily worked around.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Galen Charlton [Thu, 6 Oct 2011 17:55:43 +0000 (13:55 -0400)]
fix authentication failure
Ensure that the auth_limit values are read when open-ils.auth
initializes, not during oilsAuthInit(). This solves a problem
observed on brick-based setups where authentication could
incorrectly fail because the drone that processes
open-ils.auth.authenticate.complete didn't have the the block
count value initialized yet.
Also fixed type nit when compare the fail count to the block
limit.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Lebbeous Fogle-Weekley [Tue, 4 Oct 2011 21:51:35 +0000 (17:51 -0400)]
Really add *entire* selection list to a purchase order, when desired,
and generally do what a user would expect when, in Acq, the user
executes an operation on "all items".
This addresses LaunchPad bug #810030.
The fundamental issue is that an AcqLiTable, which is used in several
different ways in different interfaces, may be representing items on a
selection list (for example), but it doesn't necessarily know all of the
items that belong to that selection list. It only knows what it has drawn.
This addresses that deficiency by teaching the getSelected() method
some new tricks so that it can consult the server in the various ways
appropriate to getting a list of /all/ the items on a selection list, a
purchase order, a virtual PO, a set of search results, etc.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Etheridge [Tue, 4 Oct 2011 18:33:20 +0000 (14:33 -0400)]
Merge branch 'rel_2_0' of git.evergreen-ils.org:Evergreen into rel_2_0
Thomas Berezansky [Fri, 12 Aug 2011 13:17:46 +0000 (09:17 -0400)]
Clear password from password_prompt post-login
Otherwise it remains as the plain text value.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Mike Rylander [Tue, 4 Oct 2011 18:19:39 +0000 (14:19 -0400)]
Upgrade script for 2.0.10
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Thomas Berezansky [Sat, 24 Sep 2011 20:51:20 +0000 (16:51 -0400)]
Require password to change email/username
Alter backend to check password period, not just for password changes.
Add form elements for asking for current password to JSPac.
Add handling for said form elements where needed.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Thomas Berezansky [Mon, 12 Sep 2011 17:33:03 +0000 (13:33 -0400)]
When workstation is invalid request a new seed
The original one may no longer be valid
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Thomas Berezansky [Thu, 1 Sep 2011 20:41:33 +0000 (16:41 -0400)]
Make more auth values configurable
Amount of time seed is valid
Amount of time to keep failure count in memcache since last auth event
Number of failures before locking out auth attempts
Also, remove seed from memcache once it has been used once.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Thomas Berezansky [Tue, 30 Aug 2011 15:55:35 +0000 (11:55 -0400)]
Brute Force protection for authentication
Count auth failures in memcache.
If 10+ have occurred cause failure.
After 90 seconds of no activity counter resets.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Lebbeous Fogle-Weekley [Fri, 30 Sep 2011 17:37:58 +0000 (13:37 -0400)]
link asset.copy_template.status to config.copy_status in the IDL
If nothing else, this provides a dropdown for status in the copy
template editor (the one for Serials, under the admin menus, not the
one on the copy editing interface).
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Lebbeous Fogle-Weekley [Mon, 3 Oct 2011 20:03:00 +0000 (16:03 -0400)]
JSPAC: Fix a bug (I think) in orgIsMine(), and show more MFHD holdings ...
... when search scope would have it so.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Sat, 10 Sep 2011 16:28:32 +0000 (12:28 -0400)]
Refresh dynamic link cache after libjs install
The build of SpiderMonkey can fail if it can't find the freshly
installed libjs library, so run ldconfig after building libjs to avoid
that bit o' fun.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Fri, 30 Sep 2011 03:27:19 +0000 (23:27 -0400)]
LP740320: Make <enter> submit the new bookbag dialog
For the keyboard jockeys out there - if the enter key doesn't submit,
the UI reviewer will not commit.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
James Fournie [Fri, 26 Aug 2011 16:23:53 +0000 (09:23 -0700)]
Initial dialog isn't quite wide enough, here's a hackish way to fix it
Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
James Fournie [Fri, 26 Aug 2011 16:19:14 +0000 (09:19 -0700)]
Should probably use a more common button rather than the one for the advanced search
Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
James Fournie [Fri, 26 Aug 2011 15:56:44 +0000 (08:56 -0700)]
This makes more sense as an alert; the Dojo dialog has no button which is not user-friendly.
Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Mike Rylander [Tue, 2 Aug 2011 16:42:53 +0000 (12:42 -0400)]
Markup-based dijit.Dialog implementation, inspired by and based on a patch from Joseph Lewis in https://bugs.launchpad.net/evergreen/+bug/787162
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Liam Whalen [Fri, 16 Sep 2011 12:52:08 +0000 (08:52 -0400)]
Modified spine_labels.js to retain UTF-8 encoding
Dan Wells posted a fix to the DEV list for receipt printing that allowed the
receipt printer to print UTF-8 characters. I used the ideas in that fix to
modify spine_labels.js. In spine_labels.js, the url passed to the preview in
preview_xul_192 was encoding the url with the javascript encode() function.
This function does not preserve UTF-8 encodings. I changed the function to
encodeURIComponent, and UTF-8 characters are now displayed properly by the
spine label printer code.
Signed-off-by: Liam Whalen <lwhalen@evergreen-dev.catalogue.nrcan.gc.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Michael Peters [Wed, 28 Sep 2011 13:09:33 +0000 (09:09 -0400)]
A slight modification to prevent clipping in the EDI Accounts interface
Just a few tweaks via CSS to make sure the footer notes don't clip off part of the main grid.
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Wed, 28 Sep 2011 19:45:36 +0000 (15:45 -0400)]
Provide proper hrefs for links back from report debugging pages
Reimplementation of a fix provided by Michael Peters. The originally submitted
patch included several fixes provided by an unrelated patch, and a regression
in build-time embedded tokens.
Original branch at: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrpeters-isl/clark_kent_back_links
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Thu, 22 Sep 2011 16:51:22 +0000 (12:51 -0400)]
LP856567: Mark HTML report output as Unicode-encoded
Non-ASCII characters in report ouput that has been generated in HTML
format appears to be corrupted when viewed in a browser. This can be
manually corrected by switching the "Encoding" browser option, but it
would be better to include <meta charset='utf-8'> in the output HTML to
tell the browser directly.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Wells [Tue, 27 Sep 2011 16:22:38 +0000 (12:22 -0400)]
MFHD compression fails with pattern-less captions
The current code assumes that if you try to compress a range of
MFHD holdings, you actually have the necessary pattern information.
This commit introduces a very basic check to avoid the most common
failure case.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Mon, 26 Sep 2011 16:43:37 +0000 (12:43 -0400)]
2.1-ish upgrade script preamble
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Mon, 26 Sep 2011 16:18:03 +0000 (12:18 -0400)]
Stamping upgrade script for EDI cleanup
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Lebbeous Fogle-Weekley [Mon, 19 Sep 2011 17:19:22 +0000 (13:19 -0400)]
Some EDI translation fixes for troublesome input characters
This attempts to address enough of the issues in
https://bugs.launchpad.net/evergreen/+bug/812593 to move forward.
When the ? character appears in lineitem attributes for a PO that we
send off for EDI translation, the translator fails if that ? is the last
character of the string. This commit avoids that situation.
This commit also removes any Unicode characters from the JEDI (the input
to the translator process), as they're not going to make it to the
EDIFACT output anyhow, and will just confound the translator.
This commit also pre-escapes quotation marks in lineitem attributes so
that we don't produce invalid JSON for our JEDI.
This commit also destroys the death star.
Seriously, the right way to fix some of the issues people have had is
for somebody to learn Ruby and to address them either in edi_webrick.rb, in
edi4r, or in openils-mapper (wherever the issues may be). Working on
that.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Sun, 25 Sep 2011 20:55:38 +0000 (16:55 -0400)]
lp859190: make marc_stream_import always import non-matches
Fixes regression of (implicit, undocumented) functionality
introduced in commit
da3a45344205. Current use case for
the streaming MARC importer for OCLC Connexion exports assumes
that non-matching records should always be added.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Jason Etheridge [Wed, 21 Sep 2011 15:47:36 +0000 (11:47 -0400)]
properties in chrome:// return XHR status 0
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Jason Etheridge [Tue, 20 Sep 2011 14:52:02 +0000 (10:52 -0400)]
LP#854760 messagecat fails with certain 404 pages
We were failing to check the HTTP status on the underlying XHR requests.
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Sat, 17 Sep 2011 03:44:28 +0000 (23:44 -0400)]
Can't have two identical IDs on the same page
Nobody who cares about the pure Web experience ever noticed that this
page has two identical IDs. Chromium and other browsers complain,
though, so make them happy.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Thu, 25 Aug 2011 18:20:56 +0000 (14:20 -0400)]
Clear hold shelf [expire] time at checkout to alternate patron
When an item on the holds shelf is checked out to an alternate patron
(i.e. not the hold user), clear the shelf_time and shelf_expire_time
along with capture_time, current_copy, etc. on the hold.
tsbere++ for isolating the problem.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Jason Etheridge [Wed, 14 Sep 2011 14:58:31 +0000 (10:58 -0400)]
Merge branch 'rel_2_0' of git.evergreen-ils.org:Evergreen into rel_2_0
Jason Etheridge [Wed, 3 Aug 2011 04:44:41 +0000 (00:44 -0400)]
Fix staff client Clear Expired Hold Shelf action
Accomodate an API change. FIXME: See if can remove some of the redundant and/or
un-needed data being sent over the wire.
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Tue, 13 Sep 2011 19:37:06 +0000 (15:37 -0400)]
Provide a default value for, and explicitly change, the record type so the type dropdown works as intended
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Thomas Berezansky [Fri, 9 Sep 2011 19:23:09 +0000 (15:23 -0400)]
Fix dos_print when NSPrint interface is used
By adding params.dos_print = true where needed.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Lebbeous Fogle-Weekley [Wed, 7 Sep 2011 20:15:20 +0000 (16:15 -0400)]
A/T reactor 'AstCall' can't have global CStoreEditor
It's not good for any Evergreen service to try to have a global
cstoreeditor instance. Scope it to the handler() sub that needs it, and
comment out the thus-far unused/unfinished retrieve() sub.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Stephenson [Tue, 30 Aug 2011 17:08:40 +0000 (13:08 -0400)]
Fix for LP bug #702422.
Add @libdir@/javascript/ path in legacy script section of
oils_sip.xml.example so that legacy scripts work with SIP2.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
James Fournie [Wed, 31 Aug 2011 17:37:21 +0000 (10:37 -0700)]
Adding org unit context selector to providers screen
This helps alleviate the bug reported in LP 731510 and
generally improves usability.
Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Wells [Tue, 6 Sep 2011 16:14:39 +0000 (12:14 -0400)]
Clear org_unit cache fix for autogen.sh
autogen.sh is not properly clearing the org_tree cache. It is
unclear how this hasn't caused a problem before, but this fix
works for me and should be at least harmless in other enviroments.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Jason Etheridge [Wed, 20 Jul 2011 05:29:43 +0000 (01:29 -0400)]
adjust legacy xul column definitions for dates/timestamps to ensure correct sorting
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Etheridge [Mon, 18 Jul 2011 21:17:30 +0000 (17:17 -0400)]
remove circ.util.std_map_row_to_columns; default to the one provided by list.js
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Etheridge [Mon, 18 Jul 2011 19:27:22 +0000 (15:27 -0400)]
Better sort support for xul lists (see launchpad bug ://bugs.launchpad.net/evergreen/+bug/751745)
Example of supplying a sort_value function for item Create Date, and automatic sort_value for fm_columns-generated timestamp and money column definitions.
Need to provide more such functions, and eventually move everything over to fm_columns
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Wells [Thu, 1 Sep 2011 13:13:47 +0000 (09:13 -0400)]
Hourly fine periods do not charge enough
Hourly fine periods are not charging for the first period of
overdue-ness. If an item is due at 2:00pm and has a fine of
$.50 per hour, the first fine should be eligible for generation
at 2:01pm. As it stands, the first fine does not generate until
an entire fine period has elapsed, so in this case, 3:00pm.
The previous version of the code had a special case for day-
granular fine periods, so a majority of fines were not affected.
This commit expands the same idea (charging for the fine period
you are currently "in") to all fine periods.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Wed, 18 May 2011 15:13:16 +0000 (11:13 -0400)]
avoid error when generating fines on checkin
Prevents "No active transaction to commit" error when checking
in overdue loans.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Michael Peters [Thu, 11 Aug 2011 01:31:02 +0000 (21:31 -0400)]
LP#824257 Fix nasty overlapping when patron has more than 6 notes
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Mike Rylander [Wed, 24 Aug 2011 19:24:24 +0000 (15:24 -0400)]
Correct make target for lucid
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Wed, 24 Aug 2011 17:10:21 +0000 (13:10 -0400)]
Put the actual release number into the upgrade script
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Wed, 24 Aug 2011 16:55:09 +0000 (12:55 -0400)]
2.0.9 upgrade script
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Wed, 24 Aug 2011 16:51:31 +0000 (12:51 -0400)]
Adding tag upgrade script to parent branch
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Tue, 23 Aug 2011 18:34:55 +0000 (14:34 -0400)]
2.[01]-stamped upgrade script for LP#816131
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Thomas Berezansky [Mon, 22 Aug 2011 18:44:17 +0000 (14:44 -0400)]
Reverse direction of org_unit_ancestors
Apparently callers expect it to start at the top of the org tree.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Thomas Berezansky [Thu, 11 Aug 2011 13:36:36 +0000 (09:36 -0400)]
Unwrapped upgrade script for oua_force_order
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Thomas Berezansky [Thu, 11 Aug 2011 13:35:18 +0000 (09:35 -0400)]
New version of actor.org_unit_ancestors
Preserves order through joins
Basically actor.org_unit_ancestors_distance with a join to get the
entire org units, rather than just IDs and a distance.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Liam Whalen [Thu, 11 Aug 2011 18:36:19 +0000 (14:36 -0400)]
Fixed seaching for a colon (:) surrounded by white space
When searching for a colon surrounded by white space the search would
freeze. An example of such a search would be:
Climate change economics and policy : an RFF anthology
This was happening because the decompose function within QueryParser.pm
Would build a regular expression that would search the query for both
classes and class aliases e.g (keyword and kw). However, when buliding
the regex for aliases QueryParser would add extraneous or symbols (|)
to the end of the regex without adding the accompanying alias.
This was happening because there was a check to see if the corresponding
class to each alias had already been added to the regex. But, the
check to see if the alias had already been appened to the regex happened
too late. I have moved the check to encopase the appending of the or
symbols and the class.
Signed-off-by: Liam Whalen <lwhalen@evergreen-dev.catalogue.nrcan.gc.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Stephenson [Tue, 9 Aug 2011 17:51:22 +0000 (13:51 -0400)]
Branchify patch from LP bug #802523 and backport to rel_2_0.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Tue, 23 Aug 2011 13:47:47 +0000 (09:47 -0400)]
Add pgsql 9.0 target for Debian / Ubuntu, and a Fedora 15 target
People are starting to adopt PostgreSQL 9.0 in Evergreen 2.0 as a
stepping stone towards Evergreen 2.1; make it easier for them by
providing a target in the 2.0 Makefile.install.
Also, while we're in here, remove the Fedora 13 reference and replace it
with Fedora 15, as Fedora 13 is no longer supported and Fedora 15 comes
with the power of PostgreSQL 9.0. OH YEAH!
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Mike Rylander [Tue, 23 Aug 2011 13:19:29 +0000 (09:19 -0400)]
Support Evergreen 2.0 on Pg 9.0
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Etheridge [Fri, 19 Aug 2011 22:22:28 +0000 (18:22 -0400)]
Fix penalty generation during billing creation
by passing the editor object referencing the database transaction to xact_org
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Lebbeous Fogle-Weekley [Mon, 22 Aug 2011 14:37:30 +0000 (10:37 -0400)]
Display only available formats for metarecord holds in IE
The OPAC's usual hideMe()/unHideMe() tricks don't work for <option>
elements in Internet Explorer 8. Use the disabled attribute.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Fri, 19 Aug 2011 19:50:22 +0000 (15:50 -0400)]
Vandelay: repair item attr context org selector
1. Prevents resetting the context selector to the workstation org unit
each time it's changed.
2. Prevent the unintentional pileup of dojo.connect() events, which
can lead to exponential growth in the number of server calls to fetch
import-item-attribute-definitions with each change of the context org
selector.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Ben Shum [Tue, 2 Aug 2011 15:15:57 +0000 (11:15 -0400)]
#LP801961, error when running edi_fetcher.pl
This patch addresses an error encountered when running edi_fetcher.pl.
The method "is_dir" should be just plain "dir" in RemoteAccount.pm file.
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Stephenson [Tue, 9 Aug 2011 19:49:21 +0000 (15:49 -0400)]
Branchify second patch from James Fournie on LP bug #791941.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Stephenson [Tue, 9 Aug 2011 19:48:46 +0000 (15:48 -0400)]
Branchify first patch from James Fournie on LP bug #791941.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Robert Soulliere [Tue, 9 Aug 2011 19:06:44 +0000 (15:06 -0400)]
Branchify the patch from LP bug #809478.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Wells [Tue, 16 Aug 2011 15:22:36 +0000 (11:22 -0400)]
Improve Vandelay Import/Merge Checkbox Labels
Since these labels are used both for the initial import and also
for imports from the queue, the use of the word "Auto" can be
confusing and misleading. This commit reflects changes already
made in trunk for these labels.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Wells [Tue, 16 Aug 2011 15:03:16 +0000 (11:03 -0400)]
Fix importing of 'No Match' records from a queue
This small change honors the 'No Match' checkbox when importing
from a queue.
This bug has existed for a while, but was only recently exposed
by
06e4d3370068002a303c9a5a03448ee0e1249fc0. Before that commit,
no-match records always imported, even when you didn't want them.
After that commit, they import when wanted on the initial load,
but could not be imported from the queue.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Wells [Tue, 16 Aug 2011 21:22:47 +0000 (17:22 -0400)]
Stricter order for actor.org_unit_parent_protect()
actor.org_unit_parent_protect() may not work due to the fact
that 'IF' conditions in PL/pgSQL are not necessarily processed
in the order written. This line:
"IF TG_OP = 'INSERT' OR NEW.parent_ou
IS DISTINCT FROM OLD.parent_ou THEN"
may fail because the 'IS DISTINCT FROM' happens before the
'INSERT' check, and and that fails because there is no 'OLD'
variable for INSERTs.
This commit may not be the optimal style for this circumstance
in this language, but it works. It also appears to change more
than it really does due to a loss of one level of indentation in
the structure.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Wells [Tue, 16 Aug 2011 21:16:35 +0000 (17:16 -0400)]
Whitespace Only Changes
Files uses primarily tabs, function used both spaces and tabs.
It now uses all tabs.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Mike Rylander [Tue, 16 Aug 2011 15:05:04 +0000 (11:05 -0400)]
Stamped upgrades for LP#790329
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Mon, 15 Aug 2011 17:42:55 +0000 (13:42 -0400)]
LP#790329 org_lasso search is broken
Fix the JavaScript error when we attempt to create a feed for the
shortname of the org_unit_lasso (lassos have no shortname) - which lets
the request hit the backend Perl module, which in turn chokes on a test
for OU that only allows two conditions: either all digits is treated as
a numeric ID for an org unit, or it is a shortname. Of course, lassos
are negative integers, so we have to modify the test slightly to make it
happier.
There was no depth for org lasso copy counts, and this was handled
correctly in the main case by the asset.opac_lasso_record_copy_count()
function and its staff variant, but when a copy was not found at a given
org_unit in the lasso a request was made for the non-existent depth and
the function would error out.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Lebbeous Fogle-Weekley [Tue, 16 Aug 2011 13:10:45 +0000 (09:10 -0400)]
Keep the logging output of the EDI translator by default
There is valuable troubleshooting information there that is otherwise hard to
find. This particularly matters when the output of an EDI
Action/Trigger template (JEDI) doesn't successfully get translated to
EDIFACT for nonobvious reasons.
In production environments, you might instead pipe to logger so that you can
collect output with syslog, rather than in a flat file. As long as
output goes *somewhere.*
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Mike Rylander [Tue, 16 Aug 2011 13:04:09 +0000 (09:04 -0400)]
Stamped upgrades for LP#825303
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Fri, 12 Aug 2011 20:09:11 +0000 (16:09 -0400)]
return only the one applicable OU setting value
Correct actor.org_unit_ancestor_setting so that it returns
at most one setting value, rather than the entire set
of values defined for the OU and its ancestors.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Fri, 12 Aug 2011 16:18:54 +0000 (12:18 -0400)]
lp#825303: fix cat.default_classification_scheme lookup
Fixes a bug where the wrong default classification scheme
could be chosen when adding a new volume whose classification
scheme was not explicitly set.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Etheridge [Wed, 10 Aug 2011 18:19:42 +0000 (14:19 -0400)]
lp#780679, fix misleading label for hold transfer
for rel_2_0. later versions of EG also have a selective hold transfer feature
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Lebbeous Fogle-Weekley [Mon, 8 Aug 2011 17:22:05 +0000 (13:22 -0400)]
In a middle-layer method for returning holdable formats on a metarecord,
Do a better test of copy holdability than we were doing previously.
We can't do a perfect test: we don't really know what patron we're doing
this for, and even if we did, from here it's nontrivial to figure out
whether we're doing indb holds or script-based, much less run the tests.
Still, we can test whether a copy's in a holdable status, a holdable
location, and is itself not explicitly marked unholdable.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Thu, 4 Aug 2011 19:14:05 +0000 (15:14 -0400)]
Stamped upgrade script for ACQ_INVOICE_REOPEN permission addition
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Stephenson [Thu, 4 Aug 2011 14:13:56 +0000 (10:13 -0400)]
Upgrade script for LP818311 branch.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Michael Peters [Thu, 4 Aug 2011 12:59:15 +0000 (08:59 -0400)]
LP#818311: ACQ_INVOICE_REOPEN is missing
This patch adds the missing ACQ_INVOICE_REOPEN to the Acquisitions
Administrator user.
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Jason Etheridge [Fri, 5 Aug 2011 02:27:45 +0000 (22:27 -0400)]
mrpeters caught this; wrong variable fed to error dialog
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Bill Erickson [Thu, 4 Aug 2011 20:54:45 +0000 (16:54 -0400)]
Repaired copy private/public note vandelay bug
Previously, all copy notes imported through vandelay were coming in as
public copy notes.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Thomas Berezansky [Thu, 28 Jul 2011 15:04:36 +0000 (11:04 -0400)]
Only update MARC on full entry of fixed fields
AKA:
Lang is 3 characters long. Entering 1 character would cause focus to leave.
MARC would also update incorrectly.
This only triggers the update when the full 3 characters are entered.
This not only prevents issues with catalogers editing multi-character fixed
fields but also makes it less likely they accidentally corrupt the records.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Etheridge [Thu, 21 Jul 2011 19:25:28 +0000 (15:25 -0400)]
lp#792595: Don't allow pre-cats into record buckets via Item Status -> Actions for Catalogers
Alerts with the number of pre-cat records skipped prior to invoking the title bucket dialog.
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
James Fournie [Thu, 28 Jul 2011 19:08:18 +0000 (12:08 -0700)]
This adds a SAN box to the org unit editor's address editor pane.
Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Wells [Fri, 29 Jul 2011 22:09:19 +0000 (18:09 -0400)]
Vandelay fix for merging without loading new
This fix is derivative of
da3a453442050482a419deff91d3dc92fdbf132a
in master, but with new feature code removed for backport to 2.1
and 2.0. It does the following:
- renames 'vlUploadQueueAutoImport' to 'vlUploadQueueImportNoMatch' to
match identical change in master and to increase code clarity
- honors this flag when doing a merge.
Previously, if you checked one of the two auto-merge boxes, any records
which did not merge loaded as new records even if the 'Auto-Import
Non-Colliding Records' box was not checked. You can now do one, the
other, or both together (auto-importing and merging) as needed.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
projects / working / Evergreen.git / log