working/Evergreen.git
3 years agoLP#1942220: (follow-up) fix issue with seed data user/gmcharlt/lp1942220_angular_acq_sprint4
Galen Charlton [Tue, 30 Aug 2022 16:06:55 +0000 (12:06 -0400)]
LP#1942220: (follow-up) fix issue with seed data

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) update package-lock.json
Galen Charlton [Tue, 30 Aug 2022 16:02:52 +0000 (12:02 -0400)]
LP#1942220: (follow-up) update package-lock.json

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: fix a merging issue with eg-item-location-select
Galen Charlton [Tue, 30 Aug 2022 16:02:28 +0000 (12:02 -0400)]
LP#1942220: fix a merging issue with eg-item-location-select

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1570623: Exclude deleted copies from line item existing
Galen Charlton [Mon, 29 Aug 2022 22:35:15 +0000 (22:35 +0000)]
LP#1570623: Exclude deleted copies from line item existing

This is a rebase of a patch originally written by
Tiffany Little <tlittle@georgialibraries.org>

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: release notes for Angular Acquisitions
Galen Charlton [Mon, 29 Aug 2022 22:30:32 +0000 (22:30 +0000)]
LP#1942220: release notes for Angular Acquisitions

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1981714: fix Dojo AutoFieldWidget initialization bug
Galen Charlton [Thu, 14 Jul 2022 16:12:59 +0000 (16:12 +0000)]
LP#1981714: fix Dojo AutoFieldWidget initialization bug

This patch fixes a bug where AutoFieldWidget wouldn't
invoke the callback when building an org unit selector. Fixing this
allows library settings (including acq.default_owning_lib_for_auto_lids
added in the previous patch) whose datatype is link and whose fm_class
is aou to work in the Dojo Library Settings editor.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1981714: add settings to control owning library of auto-added LIDs
Galen Charlton [Thu, 14 Jul 2022 16:14:36 +0000 (16:14 +0000)]
LP#1981714: add settings to control owning library of auto-added LIDs

Previously, when line item copies/details/items where automatically created
because the provider's default copy count is non-zero, the owning library
of those line item copies was set to the workstation library. This patch
adds two new settings to tweak this behavior:

* How to set default owning library for auto-created line item items

Stategy to use to set default owning library to set when line item items
are auto-created because the provider's default copy count has been set.
Valid values are "workstation" to use the workstation library, "blank"
to leave it blank, and "use_setting" to use the "Default owning library
for auto-created line item items" setting. If not set, the workstation
library will be used.

* Default owning library for auto-created line item items

The default owning library to set when line item items are auto-created
because the provider's default copy count has been set. This applies if
the "How to set default owning library for auto-created line item
items" setting is set to "use_setting".

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) revert to legacy A/T for PO printing
Galen Charlton [Fri, 29 Jul 2022 02:25:37 +0000 (02:25 +0000)]
LP#1942220: (follow-up) revert to legacy A/T for PO printing

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: various updates to business logic
Galen Charlton [Wed, 8 Dec 2021 23:40:21 +0000 (18:40 -0500)]
LP#1942220: various updates to business logic

* set 024 ind1 correctly (i.e., to '1') when applying UPC as order
  identifier

* add flesh_po_items_further option to PO retrieval

  This fleshes in any fund debits and debit invoice items associated
  with PO direct charges

* add open-ils.acq.po_item.disencumber method

  This method disencumbers a PO item by setting its fund debit's amount
  to zero. Note that this can be done only for encumbrances; if the
  debit is an expenditure, it cannot be changed.

* add flesh_li_details_receiver to LI retrieval

* add two additional fleshing options to LI retrieval

  Specifically, flesh_copy_location and flesh_call_number. These take
  effect only when flesh_copies is also true and are used to further
  flesh values of items attached to line item details.

* remove cancel reason if last LID of LI is received

  Otherwise, a sequence where a line item was cancelled but one of
  its items was received would have the LI end up in a received
  state but with a cancel reason.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: more Angularization of the Acquisitions staff interfaces
Galen Charlton [Mon, 29 Nov 2021 16:11:02 +0000 (11:11 -0500)]
LP#1942220: more Angularization of the Acquisitions staff interfaces

This patch extends on the work done for bugs 1929741 and 1929749
to finish converting the following interfaces to Angular:

- Selection Lists
- Load MARC Order Records
- Purchase Orders
- Create Purchase Order

Note: this project was often referred to as "Angular acquisitions
sprint 4"

Mike Rylander made some contributions to this patch.

Sponsored-by: Evergreen Community Development Initiative
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: combobox: improve idlIncludeLibraryInLabel
Galen Charlton [Thu, 13 Jan 2022 15:29:47 +0000 (10:29 -0500)]
LP#1929749: combobox: improve idlIncludeLibraryInLabel

This option no longer requires that the OU field be
fleshed.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: combobox: reset if idlQueryAnd changes
Galen Charlton [Tue, 14 Dec 2021 16:06:52 +0000 (11:06 -0500)]
LP#1942220: combobox: reset if idlQueryAnd changes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: eg-item-location-select: fix use of contextOrgId
Galen Charlton [Wed, 8 Dec 2021 15:42:20 +0000 (10:42 -0500)]
LP#1942220: eg-item-location-select: fix use of contextOrgId

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1960526: adjust link color on Angular and AngularJS staff interfaces
Galen Charlton [Thu, 10 Feb 2022 16:00:22 +0000 (11:00 -0500)]
LP#1960526: adjust link color on Angular and AngularJS staff interfaces

Change the default link blue on the Angular and AngularJS interfaces
to #255a88. This achieves two things:

- Improves the color contrast on the AngularJS side against a white
  background from AA for normal text to AAA.
- Improves the Angular side so that it meets AAA color contrast for
  normal and large text, instead of meeting only AA for large text.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
3 years agoLP#1929749: point to new PO interface if creating a PO
Galen Charlton [Tue, 30 Nov 2021 16:18:12 +0000 (11:18 -0500)]
LP#1929749: point to new PO interface if creating a PO

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: fix lint
Galen Charlton [Tue, 30 Nov 2021 14:59:23 +0000 (09:59 -0500)]
LP#1929749: fix lint

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929749 Finetuning LMOR based on LP comments
Tiffany Little [Mon, 20 Sep 2021 14:58:29 +0000 (10:58 -0400)]
LP1929749 Finetuning LMOR based on LP comments

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: Adds support for picking up library settings.
Tiffany Little [Thu, 3 Jun 2021 11:45:33 +0000 (07:45 -0400)]
LP#1929749: Adds support for picking up library settings.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929749 ACQ Load MARC Order Records port
Tiffany Little [Fri, 28 May 2021 15:29:53 +0000 (11:29 -0400)]
LP1929749 ACQ Load MARC Order Records port

[Note that this includes some work by Galen Charlton to reconcile
 the picklist module with work done by Bill Erickson for LP#1929741]

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1357037: seed data - WS for LI sort order
Galen Charlton [Mon, 29 Nov 2021 21:06:18 +0000 (16:06 -0500)]
LP#1357037: seed data - WS for LI sort order

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1357037: add sorting option to Angular line item lists
Galen Charlton [Mon, 29 Nov 2021 21:04:16 +0000 (16:04 -0500)]
LP#1357037: add sorting option to Angular line item lists

This applies to the line item lists in the following new
Angular interfaces:

- purchase order
- selection list
- list of line items related to a bib record

The available sort options are:

- line item ID
- title
- author
- publisher
- order identifier (i.e., ISBN, ISSN, and/or UPC)

The method open-ils.acq.lineitem.unified_search is now used to retrieve
line items to make use of existing sorting functionality.

The last sort order used is persistant via a workstation setting

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929741: update LI worksheet template
Galen Charlton [Sat, 5 Feb 2022 17:33:30 +0000 (12:33 -0500)]
LP#1929741: update LI worksheet template

This commit adds back various elements to better match the
Dojo version of the template.

This commmit also corrects some IDs in the upgrade script.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929741: repair adding brief record from PL page
Galen Charlton [Mon, 29 Nov 2021 21:00:36 +0000 (16:00 -0500)]
LP#1929741: repair adding brief record from PL page

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741: bump up ID for new config.print_template inserts
Galen Charlton [Mon, 29 Nov 2021 15:03:17 +0000 (10:03 -0500)]
LP1929741: bump up ID for new config.print_template inserts

Resolving a logical merge conflict.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Brief record for PO repair
Bill Erickson [Mon, 26 Jul 2021 15:01:24 +0000 (11:01 -0400)]
LP1929741 Brief record for PO repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Standalone brief record UI
Bill Erickson [Wed, 30 Jun 2021 20:36:20 +0000 (16:36 -0400)]
LP1929741 Standalone brief record UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLPLP1929741 Optional experimental Acq; seed data
Bill Erickson [Wed, 14 Jul 2021 14:52:44 +0000 (10:52 -0400)]
LPLP1929741 Optional experimental Acq; seed data

Adds and org setting and a workstation setting to 1) enable display of
experimental Angular ACQ UI's and 2) enable display of links to the
experimental UI's from search results.

Display a new menu entry "Acquisitions (Experimental)" when the org
setting is enabled.  This menu contains "Create Purchase Order" only for
now.

Copy seed data from upgrade file to seed data file.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Welcome page navigates to staff w/ href
Bill Erickson [Thu, 24 Jun 2021 15:30:24 +0000 (11:30 -0400)]
LP1929741 Welcome page navigates to staff w/ href

When a route failure occurs, etc. and the user is sent back to the
Welcom to Webby page, make the link to the staff page an href instead of
a routerLink, so Angular is forced to load new route data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Change Op displays failed permission
Bill Erickson [Thu, 24 Jun 2021 15:29:54 +0000 (11:29 -0400)]
LP1929741 Change Op displays failed permission

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 cleanup more PO subs
Bill Erickson [Tue, 22 Jun 2021 20:31:10 +0000 (16:31 -0400)]
LP1929741 cleanup more PO subs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Clear previous PO on new PO create
Bill Erickson [Tue, 22 Jun 2021 20:18:18 +0000 (16:18 -0400)]
LP1929741 Clear previous PO on new PO create

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 cleanup PO subscription; improve charges display
Bill Erickson [Tue, 22 Jun 2021 20:02:40 +0000 (16:02 -0400)]
LP1929741 cleanup PO subscription; improve charges display

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Fund limit/sort on new charges
Bill Erickson [Tue, 22 Jun 2021 19:44:08 +0000 (15:44 -0400)]
LP1929741 Fund limit/sort on new charges

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 ng lint
Bill Erickson [Tue, 22 Jun 2021 19:39:57 +0000 (15:39 -0400)]
LP1929741 ng lint

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1928258 Combobox sanity checks
Bill Erickson [Mon, 14 Jun 2021 19:55:29 +0000 (15:55 -0400)]
LP1928258 Combobox sanity checks

Avoid failures caused by calling toLowerCase() on a number.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Item location select starts with; hide Unset
Bill Erickson [Tue, 22 Jun 2021 18:47:44 +0000 (14:47 -0400)]
LP1929741 Item location select starts with; hide Unset

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Combobox supports startsWith search (p2)
Bill Erickson [Tue, 22 Jun 2021 18:46:51 +0000 (14:46 -0400)]
LP1929741 Combobox supports startsWith search (p2)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Blanket order finalizing; improved charges handling
Bill Erickson [Tue, 22 Jun 2021 18:06:00 +0000 (14:06 -0400)]
LP1929741 Blanket order finalizing; improved charges handling

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Sort funds by year desc, then code
Bill Erickson [Tue, 22 Jun 2021 16:19:44 +0000 (12:19 -0400)]
LP1929741 Sort funds by year desc, then code

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Batch of PO fixes
Bill Erickson [Tue, 22 Jun 2021 15:43:05 +0000 (11:43 -0400)]
LP1929741 Batch of PO fixes

* Avoid clearing the owning library during batch edit copy operations
* Leverage combobox startsWith for distribution formulas
* Disable the order ident selector so it cannot be modified after a PO
  is activated
* Add some icons to the PO actions for more eye-grabbiness.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Combobox supports startsWith search
Bill Erickson [Tue, 22 Jun 2021 15:42:00 +0000 (11:42 -0400)]
LP1929741 Combobox supports startsWith search

In lieu of the default behavor of the typeahead, which does a 'contains'
search.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 ACQ order ident indicate multiples
Bill Erickson [Mon, 14 Jun 2021 21:43:15 +0000 (17:43 -0400)]
LP1929741 ACQ order ident indicate multiples

When multiple order identifer values (e.g. ISBN's) exist on a lineitem,
the number of options is now displayed just to the left of the
identifier selector.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Apply default lineitem order identifers
Bill Erickson [Mon, 14 Jun 2021 21:35:21 +0000 (17:35 -0400)]
LP1929741 Apply default lineitem order identifers

Apply a default order identifier to lineitems instead of leaving the
selector blank.  Ensure the value that will display in the selector
matches what's in the database by setting the value on load when needed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Bundle of ACQ bug fixes
Bill Erickson [Fri, 11 Jun 2021 15:29:47 +0000 (11:29 -0400)]
LP1929741 Bundle of ACQ bug fixes

* Distribution formula combobox now displays entries on click
* Ditto Charge Type combobox
* Items now vanish when deleted
* Estimated amount, etc. update when items are added/deleted
* Lineitem action links match order of previous interface.
* PO dry run checks now fire after a brief record is added
* PO activation is blocked if an item has no owning lib.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Delete action trumps ischanged for LID's
Bill Erickson [Fri, 11 Jun 2021 14:28:06 +0000 (10:28 -0400)]
LP1929741 Delete action trumps ischanged for LID's

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Cache LI after order ident change
Bill Erickson [Wed, 9 Jun 2021 15:16:08 +0000 (11:16 -0400)]
LP1929741 Cache LI after order ident change

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Lineitem delete repairs
Bill Erickson [Mon, 3 May 2021 15:28:09 +0000 (11:28 -0400)]
LP1929741 Lineitem delete repairs

Allow deleting lineitems on PO's for certaian states.

Fix lineitem delete code issues.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 View/Place orders sorts newest to oldest
Bill Erickson [Tue, 20 Apr 2021 15:15:36 +0000 (11:15 -0400)]
LP1929741 View/Place orders sorts newest to oldest

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Limit to active providers; skip empty name picklist
Bill Erickson [Thu, 8 Apr 2021 14:30:56 +0000 (10:30 -0400)]
LP1929741 Limit to active providers; skip empty name picklist

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 AnJS nav create po goes to new UI
Bill Erickson [Fri, 26 Feb 2021 16:11:19 +0000 (11:11 -0500)]
LP1929741 AnJS nav create po goes to new UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Improve catalog service sanity check
Bill Erickson [Tue, 27 Apr 2021 14:32:05 +0000 (10:32 -0400)]
LP1929741 Improve catalog service sanity check

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Repair 'Create Invoice' link
Bill Erickson [Tue, 2 Feb 2021 18:41:47 +0000 (13:41 -0500)]
LP1929741 Repair 'Create Invoice' link

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Zero-copy and no-assets PO activation
Bill Erickson [Mon, 1 Feb 2021 22:29:26 +0000 (17:29 -0500)]
LP1929741 Zero-copy and no-assets PO activation

And summary layout improvements.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Ensure PO items always display when present
Bill Erickson [Mon, 1 Feb 2021 21:16:07 +0000 (16:16 -0500)]
LP1929741 Ensure PO items always display when present

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 View/Place Orders UI
Bill Erickson [Tue, 26 Jan 2021 18:26:35 +0000 (13:26 -0500)]
LP1929741 View/Place Orders UI

View/Place orders from a bib record and add/create selection lists or
PO's from the record.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Display copy row number in copy edit grid
Bill Erickson [Wed, 20 Jan 2021 22:02:38 +0000 (17:02 -0500)]
LP1929741 Display copy row number in copy edit grid

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 ACQ caching / batch editing improvements
Bill Erickson [Wed, 20 Jan 2021 20:49:55 +0000 (15:49 -0500)]
LP1929741 ACQ caching / batch editing improvements

Ensure that funds/mods/locations of modified copies are available at
render time after saving changes to copies.

Hide the copy batch update bar when no copies are editable.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Combobox additional sanity checks on async/IDL values
Bill Erickson [Wed, 20 Jan 2021 20:47:03 +0000 (15:47 -0500)]
LP1929741 Combobox additional sanity checks on async/IDL values

1. Avoid PCRUD queries where the selected id value is set to null.
2. Avoid attempts to add null entries to the async entry cache.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Sanity check distrib. formula values
Bill Erickson [Wed, 20 Jan 2021 19:14:36 +0000 (14:14 -0500)]
LP1929741 Sanity check distrib. formula values

No fields within a distribution formula are required, so confirm a set
of values exists before calling Object.keys() on an undefined value.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Angular Selection List / Po Seed Data
Bill Erickson [Fri, 15 Jan 2021 15:33:55 +0000 (10:33 -0500)]
LP1929741 Angular Selection List / Po Seed Data

PO and lineitem worksheet print templates.

Workstation preferences for grids and lineitem list page size.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 ACQ Selection List & PO Angluar Port
Bill Erickson [Thu, 8 Oct 2020 22:22:12 +0000 (18:22 -0400)]
LP1929741 ACQ Selection List & PO Angluar Port

New selection list UI
New PO UI
New Lineitem worksheet UI with stub print template
New PO print UI with stub print template
New brief record UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Combobox idl auto query filter addition
Bill Erickson [Fri, 4 Dec 2020 20:39:33 +0000 (15:39 -0500)]
LP1929741 Combobox idl auto query filter addition

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Combobox asyncSupportsEmptyTermClick fix
Bill Erickson [Fri, 4 Dec 2020 16:17:51 +0000 (11:17 -0500)]
LP1929741 Combobox asyncSupportsEmptyTermClick fix

Fixes situation where combobox would fetch the needed entries in async
mode, but fail to open the drop-down after a click.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Net service tidier request logging
Bill Erickson [Wed, 30 Dec 2020 16:43:50 +0000 (11:43 -0500)]
LP1929741 Net service tidier request logging

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoUpdate carousels.adoc
gmontimantis [Wed, 6 Apr 2022 17:22:37 +0000 (13:22 -0400)]
Update carousels.adoc

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoDocs: correct permission
Andrea Buntz Neiman [Mon, 13 Jun 2022 20:03:07 +0000 (16:03 -0400)]
Docs: correct permission

updated doc to cite the actual permission

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoDocs: Adding group penalty thresholds
Jennifer Pringle [Mon, 13 Jun 2022 20:29:56 +0000 (13:29 -0700)]
Docs: Adding group penalty thresholds

new page and screenshots for group penalty thresholds

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoDocs: Updating Authorities
Jennifer Pringle [Fri, 17 Jun 2022 20:04:05 +0000 (13:04 -0700)]
Docs: Updating Authorities

Authorities section text and screenshots updated.

Changes come from Jennifer Weston jennifer.weston@equinoxoli.org

Co-authored-by: Jennifer Weston <jennifer.weston@equinoxoli.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP#1771636: Add release notes entry
Michele Morgan [Wed, 10 Aug 2022 15:07:40 +0000 (11:07 -0400)]
LP#1771636: Add release notes entry

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1823225 Patron Penalty Refresh Action
Bill Erickson [Mon, 11 Jul 2022 18:06:44 +0000 (14:06 -0400)]
LP1823225 Patron Penalty Refresh Action

New menu entry added under the 'Other' menu for patrons.  It refreshes
the patron's penalties and reloads the patron to ensure all needed data
is refreshed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1910546: Stamping upgrade script
Michele Morgan [Mon, 1 Aug 2022 18:30:25 +0000 (14:30 -0400)]
LP1910546: Stamping upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1910546 Prevent Copy Location Delete With Active Copies
Bill Erickson [Tue, 19 Jul 2022 14:19:29 +0000 (10:19 -0400)]
LP1910546 Prevent Copy Location Delete With Active Copies

Raise a database exception when any attempt is made to marke a copy
location as deleted when the location contains non-deleted copies.

To Test:

1. Navigate to /eg2/staff/admin/local/asset/copy_location

2. Attempt to delete a copy location that is known to contain
   non-deleted copies.

3. Confirm an error message is displayed and the location is not marked
   as deleted.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1771636: Stamping upgrade script
Michele Morgan [Fri, 29 Jul 2022 20:22:24 +0000 (16:22 -0400)]
LP1771636: Stamping upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1771636 Org Select Combined Org Names Option
Bill Erickson [Mon, 3 Jan 2022 17:54:43 +0000 (12:54 -0500)]
LP1771636 Org Select Combined Org Names Option

Adds an option to the staff client workstation settings page for
"Include Full Library Names in Library Selector?".  When enabled, Angular org
unit selectors display the full branch in addition to the branch short
code.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1978567: Teach fieldmapper.py about field groups
Jason Boyer [Thu, 28 Jul 2022 19:15:17 +0000 (15:15 -0400)]
LP1978567: Teach fieldmapper.py about field groups

Because the "group" tag in IDL field_groups was never added to
this file that helps with translations, Simple Reporter field groups
all have the same name when built for release.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
3 years agoLP1956986: follow-up to fix linter
Jane Sandberg [Wed, 27 Jul 2022 22:24:46 +0000 (15:24 -0700)]
LP1956986: follow-up to fix linter

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP1956986 Holdings View display correct copy alerts count
Bill Erickson [Wed, 13 Jul 2022 15:56:13 +0000 (11:56 -0400)]
LP1956986 Holdings View display correct copy alerts count

Avoid counting ACK'ed copies as active copy alerts in the catalog
Holdings View, copy alert column.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
3 years agoLP1956986 Copy alerts consistently set ack_staff
Bill Erickson [Wed, 13 Jul 2022 15:51:57 +0000 (11:51 -0400)]
LP1956986 Copy alerts consistently set ack_staff

Moves the logic of when to apply a value for ack_staff into the copy
alerts dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
3 years agoLP#1956986: fix and refactor item alert handing in Angular editor
Galen Charlton [Mon, 11 Jul 2022 16:31:36 +0000 (12:31 -0400)]
LP#1956986: fix and refactor item alert handing in Angular editor

This patch changes the handling of item alerts in the Angular
Holdings View and Item Attributes editor to be more like how
item notes and item tags are handled.

In particular:

- The separate 'Add Item Alert' and 'Edit Item Alerts' context menu
  items in Holdings View are consolidated to a 'Add/Manage Item Alerts'
  action.
- Pending new alerts are displayed in separate area of the modal
- The 'Apply Changes' and 'Add New' buttons now work the same way as
  item notes and item tags

To test
-------
[1] Apply patch.
[2] Create a new item with one or more item alerts. Verify that they are
    properly saved.
[3] Edit an existing item and add, modify, and clear alerts. Verify that
    the changes are saved.
[4] From Holdings View, choose 'Add/Manage Item Alerts' with a single
    item selected. Verify that changes are saved.
[5] From Holdings View, choose 'Add/Manage Item Alerts' with multiple
    items selected. Verify that you are only given the option to add
    new alerts. Verify that new alerts are saved.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
3 years agoLP#1978889: display alert type for existing item alerts
Galen Charlton [Mon, 11 Jul 2022 14:38:47 +0000 (10:38 -0400)]
LP#1978889: display alert type for existing item alerts

This patch ensures that the type of an item alert is
displayed when managing item alerts in the Angular item
attributes editor.

To test
-------
[1] Add an alert to an item.
[2] From the Angular Holdings View, chose 'Edit Item Alerts'
    for that item. Note that the combobox for the existing
    alert does not display a value.
[3] Open the item in the Item Attributes editor and click
    the Item Alerts button. Again, note that the alert type
    combobox does not display a value.
[4] Apply the patch and repeat steps 2 and 3. This time, the alert
    type should be displayed.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
3 years agoLP1956627 Copy editor shows full org path of copy locations
Bill Erickson [Fri, 8 Jul 2022 21:46:40 +0000 (17:46 -0400)]
LP1956627 Copy editor shows full org path of copy locations

Copy location selector in the copy editor now includes locations from all
org units above, at, and below the workstation org unit.

Previously, copy locations at "lower" org units were not included.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Carol Witt <wittc@cwmars.org>
3 years agoLP1980692-Patron print option should be 'copies'
Garry Collum [Mon, 18 Jul 2022 19:11:01 +0000 (19:11 +0000)]
LP1980692-Patron print option should be 'copies'

When printing from the patron's bills page the option to select the number
of copies to print reads 'items'.  This changes the label to 'copies'.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP1955838 Hatch Native Browser Printing Option
Bill Erickson [Mon, 27 Dec 2021 18:04:37 +0000 (13:04 -0500)]
LP1955838 Hatch Native Browser Printing Option

Adds a new printer option to the Hatch printer settings page called
"Browser Printer".  When selected for a print context, all print request
using that context are printed via window.print() instead of going
through Hatch for printing.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1884950 Org service loads all ou types fix
Bill Erickson [Wed, 13 Jul 2022 14:09:33 +0000 (10:09 -0400)]
LP1884950 Org service loads all ou types fix

Recover an unintended line deletion.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoLP1884950 Org service loads all ou types
Bill Erickson [Wed, 6 Jul 2022 20:35:28 +0000 (16:35 -0400)]
LP1884950 Org service loads all ou types

Explicitly load all org unit types at page startup so that we fetch org
types that may not have an org unit attached.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoLP1884950 Org Unit Admin Scrolling
Bill Erickson [Wed, 6 Jul 2022 19:32:42 +0000 (15:32 -0400)]
LP1884950 Org Unit Admin Scrolling

Admin -> Server Admin -> Organizational Units now displays the tree of
org units in a vertical-scrollable div which occupies 80% of the
vertical window space.

Tree is opened to the first level of child nodes.  Deeper child nodes
are collapsed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoForward 3.7.4 DB Upgrade Script
Jason Stephenson [Thu, 21 Jul 2022 15:50:32 +0000 (11:50 -0400)]
Forward 3.7.4 DB Upgrade Script

Signed-off-by: Jason Stephenson <jason@sigio.com>
3 years agoDocs: 3.7.4 Release Notes
Jason Stephenson [Wed, 20 Jul 2022 12:57:55 +0000 (08:57 -0400)]
Docs: 3.7.4 Release Notes

Signed-off-by: Jason Stephenson <jason@sigio.com>
3 years agoLP1958573 PMC messages created by action triggers not patron-visible
Terran McCanna [Thu, 20 Jan 2022 19:42:33 +0000 (14:42 -0500)]
LP1958573 PMC messages created by action triggers not patron-visible

This adds a missing patron-visibility flag to messages created for
the patron message center by notification action triggers (when
using grouped events).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoStaff banner added to the staff portal local administration page.
Shula Link [Mon, 27 Jun 2022 13:26:38 +0000 (09:26 -0400)]
Staff banner added to the staff portal local administration page.

Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1956790 Support applying item alerts via templates
Bill Erickson [Fri, 8 Jul 2022 15:17:51 +0000 (11:17 -0400)]
LP1956790 Support applying item alerts via templates

Fixes an issue where item alerts contained within copy templates failed
to apply when using the new Angular holdings editor.

Testing note: if you add an item alert by applying a template, it currently
will not be displayed in the item alerts dialog until you save the item.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1980257: add release notes entry
Galen Charlton [Tue, 12 Jul 2022 13:38:21 +0000 (09:38 -0400)]
LP#1980257: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1980257: (follow-up) add balance owed to the pending grid as well
Galen Charlton [Tue, 12 Jul 2022 13:36:13 +0000 (09:36 -0400)]
LP#1980257: (follow-up) add balance owed to the pending grid as well

Doing this maintains symmetry between the user bucket grid
and the pending user grid and supports workflows where a staff
member may wish to check the patron balance before adding a
user to a bucket.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1980257: Patron bucket money summary
Bill Erickson [Wed, 29 Jun 2022 18:44:12 +0000 (14:44 -0400)]
LP#1980257: Patron bucket money summary

This patch adds the patron's balance owed as a column
in the user bucket grid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1975879 Holdings editor allows owning lib changed user/gmcharlt/lp1975879_signoff
Bill Erickson [Fri, 8 Jul 2022 20:19:44 +0000 (16:19 -0400)]
LP1975879 Holdings editor allows owning lib changed

A new edit (pencil) icon appears to the left of the first call number
field in the 'holdings' tab of the copy edit.  When clicked, the user has
a chance to enter a new org unit value to act as the owning lib of the
affected call number.

If the "Change Circ Lib When Owning Lib Changes" preference is set, then
any copies linked to the affected call number within the current edit
session will have their circ libs updated to match the new owning lib of
the call number.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1981095: fix deletion of item tags in Angular item attributes editor
Galen Charlton [Fri, 8 Jul 2022 16:46:40 +0000 (12:46 -0400)]
LP#1981095: fix deletion of item tags in Angular item attributes editor

This patch fixes several bugs that prevent item tags from
being correctly deleted by the Angular item attributes editor.

To test
-------
[1] Apply patch.
[2] Edit a single item in the Angular item attributes editor.
[3] Verify that tags can be added and deleted.
[4] In Holdings View, choose Add/Manage Item Tags for a single
    selected item.
[5] Verify that tags can be added and deleted;
[6] Repeat steps 4 and 5 for a different item after successfully
    deleting an item tag. Verify that tags can be added and deleted.
[7] In Holdings View, choose Add/Manage Item Tags for multiple
    selected items.
[8] Verify that ntoes can be added to the selected items

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1959716 Follow up to allow managing/deleting in-place copies
Bill Erickson [Fri, 8 Jul 2022 20:43:42 +0000 (16:43 -0400)]
LP1959716 Follow up to allow managing/deleting in-place copies

Fixes a thinko which prevented management / deletion of existing copies
in the copy editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1955065 Item note dialog close value repairs
Bill Erickson [Fri, 8 Jul 2022 19:10:51 +0000 (15:10 -0400)]
LP1955065 Item note dialog close value repairs

Handle cases where the copy note dialog is closed via Cancel actions and
emits no data.

Also be sure the dialog emits consistently shaped data when it does emit
data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1955065: fix deletion of item notes in Angular item attributes editor
Galen Charlton [Fri, 8 Jul 2022 16:03:35 +0000 (12:03 -0400)]
LP#1955065: fix deletion of item notes in Angular item attributes editor

This patch fixes several bugs that prevent item notes from
being correctly deleted by the Angular item attributes editor.

To test
-------
[1] Apply patch.
[2] Edit a single item in the Angular item attributes editor.
[3] Verify that notes can be added and deleted.
[4] In Holdings View, choose Add/Manage Item Notes for a single
    selected item.
[5] Verify that notes can be added and deleted;
[6] Repeat steps 4 and 5 for a different item after successfully
    deleting an item note. Verify that notes can be added and deleted.
[7] In Holdings View, choose Add/Manage Item Notes for multiple
    selected items.
[8] Verify that ntoes can be added to the selected items.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1965448 Holdings edit enforce required stat cats
Bill Erickson [Thu, 7 Jul 2022 20:28:36 +0000 (16:28 -0400)]
LP1965448 Holdings edit enforce required stat cats

Required copy stat cats require a value when creating or editing
copies.

Switching between tabs in the copy editor no longer alert the user when
a change is pending, since it may be necessary to hop between tabs to
resolve issues.  Pending changes alerts will still appear when leaving
the page if needed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>