working/Evergreen.git
3 years agoMerge branch 'user/khuckins/lp1913815-course-browse-not-working' into course-material... user/khuckins/course-material-merged-test-branch
Kyle Huckins [Tue, 22 Mar 2022 22:00:00 +0000 (22:00 +0000)]
Merge branch 'user/khuckins/lp1913815-course-browse-not-working' into course-material-test-4

3 years agoMerge branch 'user/khuckins/lp1913340-OPAC-course-search-archived-results' into cours...
Kyle Huckins [Tue, 22 Mar 2022 21:56:02 +0000 (21:56 +0000)]
Merge branch 'user/khuckins/lp1913340-OPAC-course-search-archived-results' into course-material-test-4

3 years agoMerge branch 'user/khuckins/lp1930896-course-reserves-carriage-return-shouldnt-add...
Kyle Huckins [Tue, 22 Mar 2022 21:51:21 +0000 (21:51 +0000)]
Merge branch 'user/khuckins/lp1930896-course-reserves-carriage-return-shouldnt-add' into course-material-test-4

3 years agoMerge branch 'user/khuckins/lp1907927-allow-editing-items-attached-to-course' into...
Kyle Huckins [Tue, 22 Mar 2022 21:41:15 +0000 (21:41 +0000)]
Merge branch 'user/khuckins/lp1907927-allow-editing-items-attached-to-course' into course-material-test-3

3 years agoMisc fixes
Kyle Huckins [Tue, 22 Mar 2022 21:32:19 +0000 (21:32 +0000)]
Misc fixes

3 years agoMerge branch 'user/khuckins/lp1929588-duplicate-course' into course-material-test-3
Kyle Huckins [Tue, 22 Mar 2022 21:29:01 +0000 (21:29 +0000)]
Merge branch 'user/khuckins/lp1929588-duplicate-course' into course-material-test-3

3 years agoMerge branch 'user/khuckins/lp1940105-archive-course-should-detach_material' into...
Kyle Huckins [Tue, 22 Mar 2022 21:22:27 +0000 (21:22 +0000)]
Merge branch 'user/khuckins/lp1940105-archive-course-should-detach_material' into course-material-test-3

3 years agoMerge branch 'user/khuckins/lp1913816-course-materials-owning-lib-required' into...
Kyle Huckins [Tue, 22 Mar 2022 21:18:19 +0000 (21:18 +0000)]
Merge branch 'user/khuckins/lp1913816-course-materials-owning-lib-required' into course-material-test-3

3 years agoMerge branch 'user/khuckins/lp1895706-unarchive-courses' into course-material-test-2
Kyle Huckins [Tue, 22 Mar 2022 21:04:30 +0000 (21:04 +0000)]
Merge branch 'user/khuckins/lp1895706-unarchive-courses' into course-material-test-2

3 years agoMerge branch 'user/khuckins/lp1939994-course-details-archive-workaround' into course...
Kyle Huckins [Tue, 22 Mar 2022 21:02:37 +0000 (21:02 +0000)]
Merge branch 'user/khuckins/lp1939994-course-details-archive-workaround' into course-material-test-2

3 years agolp1923057 Course Materials disassociate Rework
Kyle Huckins [Sun, 13 Mar 2022 05:05:55 +0000 (05:05 +0000)]
lp1923057 Course Materials disassociate Rework

- Adds a "Currently Associated" boolean and Removal time for course materials
- When disassociating a course material, the time will still show up in the admin grid for course materials, marked as not currently associated.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
3 years agolp1915556 Incorrect Placement for edit_time()
Kyle Huckins [Tue, 22 Mar 2022 19:31:33 +0000 (19:31 +0000)]
lp1915556 Incorrect Placement for edit_time()

- edit_time() setting changed to affect the course material, not the copy

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
3 years agolp1907927 Fix sql Formatting user/khuckins/lp1907927-allow-editing-items-attached-to-course
Kyle Huckins [Sun, 20 Mar 2022 23:43:22 +0000 (23:43 +0000)]
lp1907927 Fix sql Formatting

- Set upgrade script formatting to LF from CRLF
- Set temporary callnumber to Text rather than Int

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
3 years agolp1895706 - Unarchvie Course Button handles correctly
Kyle Huckins [Sun, 20 Mar 2022 21:26:43 +0000 (21:26 +0000)]
lp1895706 - Unarchvie Course Button handles correctly

- Ensure changes made in 1939994 are reflected properly
- Hide Archive Course button if Course is archived
- Hide Unarchive Course button if Course is active

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
3 years agolp1929588 Duplicate Course add Copy to course name
Kyle Huckins [Thu, 17 Mar 2022 17:09:47 +0000 (17:09 +0000)]
lp1929588 Duplicate Course add Copy to course name

- Append " (Copy)" to new course name

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
3 years agolp1907927 Allow Editing Items Attached to Course
Kyle Huckins [Wed, 16 Mar 2022 06:44:14 +0000 (06:44 +0000)]
lp1907927 Allow Editing Items Attached to Course

- Adds additional IDL/DB fields to Course Materials, holding Temporary Locaton, Circ Modifiers, Status, and Callnumbers
- Enables the editing of the above fields to apply to the linked copy

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/examples/fm_IDL.xml
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/share/course.service.ts
modified:   Open-ILS/src/perlmods/lib/OpenILS/Application/Courses.pm
modified:   Open-ILS/src/sql/Pg/040.schema.asset.sql
new file:   Open-ILS/src/sql/Pg/upgrade/XXXX.schema.lp1907927-edit-items-attached-to-course.sql

3 years agolp1913816 Course Materials Owning Lib is Required user/khuckins/lp1913816-course-materials-owning-lib-required
Kyle Huckins [Tue, 15 Mar 2022 19:20:55 +0000 (19:20 +0000)]
lp1913816 Course Materials Owning Lib is Required

- Requires an Owning Library to be set when creating or editing a Course

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/sql/Pg/040.schema.asset.sql
new file:   Open-ILS/src/sql/Pg/upgrade/XXXX.schema.lp19138160-course-materials-owning-lib-shouldnt-be-null.sql

3 years agolp1939994 Course Details Page Archive Workaround user/khuckins/lp1939994-course-details-archive-workaround
Kyle Huckins [Tue, 15 Mar 2022 03:10:25 +0000 (03:10 +0000)]
lp1939994 Course Details Page Archive Workaround

- Course Page stores is_archived() locally, checking for either the current course being archived, or the locally stored variable.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-users.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-users.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.ts

3 years agolp1915556 Course Material Trace Editing
Kyle Huckins [Sun, 13 Mar 2022 01:54:33 +0000 (01:54 +0000)]
lp1915556 Course Material Trace Editing

- Add Creator, Editor, Create_Time, and Edit_Time fields to Course_Module Course, Course Materials, Term, and Role tables and IDL
- Cursory handling within EG2 to prevent setting and editing the above fields directly in EG2

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/examples/fm_IDL.xml
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.html
modified:   Open-ILS/src/eg2/src/app/staff/share/course.service.ts
modified:   Open-ILS/src/sql/Pg/040.schema.asset.sql
new file:   Open-ILS/src/sql/Pg/upgrade/XXXX.scheme.lp1915556-course-material-trace-editing-history.sql

3 years agolp1913340 - List All Courses in OPAC user/khuckins/lp1913340-OPAC-course-search-archived-results
Kyle Huckins [Sun, 13 Mar 2022 00:27:16 +0000 (00:27 +0000)]
lp1913340 - List All Courses in OPAC

- Removed handling preventing an empty query from providing results
- Strip * from query to ensure expected behavior

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
3 years agolp1913815 Browse for Course Fixes
Kyle Huckins [Sat, 12 Mar 2022 22:13:13 +0000 (22:13 +0000)]
lp1913815 Browse for Course Fixes

- Course Browse is no longer case sensitive
- Course Browse will now default to the correct page

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
3 years agolp1929588 Duplicate Course
Kyle Huckins [Sun, 27 Feb 2022 04:44:37 +0000 (04:44 +0000)]
lp1929588 Duplicate Course

- Add Grid action to duplicate existing course

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
3 years agolp1940105 Archive Course Should Use detach_material user/khuckins/lp1940105-archive-course-should-detach_material
Kyle Huckins [Sun, 27 Feb 2022 01:33:29 +0000 (01:33 +0000)]
lp1940105 Archive Course Should Use detach_material

- Replaced resetItemFields with detachMaterials in Course Service
- Refactored disassociateMaterials to utilize detach_materials
- Refacotred deleteSelectedMaterials to utilize Course Service detachMaterials function

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
3 years agolp1895706 Unarchive Old Courses
Kyle Huckins [Tue, 22 Feb 2022 17:26:59 +0000 (17:26 +0000)]
lp1895706 Unarchive Old Courses

- Add option to unarchive old courses
- Remove non-public Course Users when unarchiving course

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.ts

3 years agolp1930896 Brief Record Carriage Return Shouldn't Add user/khuckins/lp1930896-course-reserves-carriage-return-shouldnt-add
Kyle Huckins [Wed, 16 Feb 2022 22:54:24 +0000 (22:54 +0000)]
lp1930896 Brief Record Carriage Return Shouldn't Add

- Ensure the Simplified Marc Edit form doesn't submit on pressing the enter key

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
3 years agolp1930896 - Course Reserves Carriage Return Shouldn't Add
Kyle Huckins [Wed, 9 Feb 2022 23:20:50 +0000 (23:20 +0000)]
lp1930896 - Course Reserves Carriage Return Shouldn't Add

- Removed Enter KeyUp property from the Patron Barcode field on Associate User
- Removed Enter KeyUp property from the Item Barcode field on Associate Item

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
3 years agoAdding videos from Conferences
Lynn Floyd [Mon, 6 Sep 2021 16:13:13 +0000 (12:13 -0400)]
Adding videos from Conferences

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoDocs: Updating Opac Lists doc
gmontimantis [Wed, 2 Feb 2022 16:54:44 +0000 (11:54 -0500)]
Docs: Updating Opac Lists doc

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoLP1948035 (follow-up): don't use commonjs in spec tsconfig
Jane Sandberg [Tue, 25 Jan 2022 20:37:10 +0000 (12:37 -0800)]
LP1948035 (follow-up): don't use commonjs in spec tsconfig

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoLP1948035 Angular 12 updates
Bill Erickson [Thu, 21 Oct 2021 15:54:13 +0000 (11:54 -0400)]
LP1948035 Angular 12 updates

Run ng upgrade from 10 -> 11 -> 12.

Updates package.json deps for Angular 12.

Removes deprecated angular/http dependency

Fix a couple of cases where Promise<any> now requires resolve(something)
instead of resolve() (which would be Promise<void>).

Fix some CSS syntax issues.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoLP1948035 Update Node/Angular Deps for Ang 12
Bill Erickson [Thu, 21 Oct 2021 15:03:13 +0000 (11:03 -0400)]
LP1948035 Update Node/Angular Deps for Ang 12

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoDocs: use asciidoc ordered list rather than adding numbers manually
Jane Sandberg [Tue, 25 Jan 2022 17:50:47 +0000 (09:50 -0800)]
Docs: use asciidoc ordered list rather than adding numbers manually

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoDocs: updating z39.50 overlay doc and images
gmontimantis [Wed, 10 Nov 2021 19:37:40 +0000 (14:37 -0500)]
Docs: updating z39.50 overlay doc and images

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoDocs: Update barcode_completion_grid.jpg
gmontimantis [Mon, 24 Jan 2022 19:04:16 +0000 (14:04 -0500)]
Docs: Update barcode_completion_grid.jpg

Updated barcode grid screenshot; other one was too blurry

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoDocs: Update basic_holds.adoc
gmontimantis [Fri, 30 Jul 2021 14:15:46 +0000 (10:15 -0400)]
Docs: Update basic_holds.adoc

removing Print full pull list alternative reference

https://bugs.launchpad.net/evergreen/+bug/1775402
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoDocs: Update basic_holds.adoc to include updated screenshot
gmontimantis [Fri, 30 Jul 2021 14:14:01 +0000 (10:14 -0400)]
Docs: Update basic_holds.adoc to include updated screenshot

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoDocs: add a chapter about the course materials module
Jane Sandberg [Fri, 14 Jan 2022 23:58:02 +0000 (15:58 -0800)]
Docs: add a chapter about the course materials module

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoLP1903476 Followup; Remove perl action, limit to docs/
Jason Boyer [Wed, 12 Jan 2022 12:17:19 +0000 (07:17 -0500)]
LP1903476 Followup; Remove perl action, limit to docs/

Since the 'ubuntu-latest' image includes perl 5.30 the
actions-setup-perl step just adds more time to the process.

GitHub Actions can be limited to (or exclude) paths so now
docs will only be built when pushes or PRs happen under docs/.

Also added a couple name tags for the interface.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
3 years agoLP1903476: Use Github Actions to build antora documentation
Jane Sandberg [Wed, 27 Oct 2021 17:16:30 +0000 (10:16 -0700)]
LP1903476: Use Github Actions to build antora documentation

This allows documenters to submit a pull request and get a
preview version where they can view their changes.  The goal
is to provide quick feedback to documenters on whether their
changes build correctly and appear as desired, without them
having to have a full docs building setup locally.

To test:
1. Use the Github Web site to fork the Evergreen repository.
2. Take the .github/workflows/docs.yml file from this commit.
Add it to any branch of your fork of the Evergreen repository.
3. Click on the Actions tab of your fork in the Github Web
site.
4. Click on the most recent run (at the top of the list).
5. When the build process is done (should take 3-4 minutes),
download and unzip the artifact that appears at the bottom of
the screen.  Open index.html in your browser.  Confirm that
the docs built properly.
6. On the same branch, make some changes to the documentation
in the docs/modules directory.
7. Repeat steps 3-5.  Confirm that your changes are reflected
in the new artifact.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
3 years agoLP 1942645: stamp upgrade script
Jane Sandberg [Tue, 14 Dec 2021 21:02:15 +0000 (13:02 -0800)]
LP 1942645: stamp upgrade script

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agolp-1942645 term name uniqueness
malexander [Wed, 8 Dec 2021 19:12:23 +0000 (19:12 +0000)]
lp-1942645 term name uniqueness

dropped name uniqueness between orgs, added constraint to owning lib and name

Includes syntax corrections from Martha Driscoll -- thank you, Martha!

Signed-off-by: malexander <malexander@catalyte.io>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoLp 1862652: pingest.pl reingest record attributes fix
Jason Stephenson [Mon, 10 Feb 2020 16:09:37 +0000 (11:09 -0500)]
Lp 1862652: pingest.pl reingest record attributes fix

Use the rdeleted parameter when reingesting record attributes in
pingest.pl support script so that passing argument values to the
--attr option makes sense.

Prior to this patch, arguments of the --attr option would be ignored,
and all record attribute fields were reingested for all records,
deleted and not deleted alike.

With this patch, the arguments of the --attr option are respected for
not deleted records.  Deleted records still have all attributes
reingested.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoLP1933275 Staff catalog holdings view shows correct counts
Bill Erickson [Thu, 8 Jul 2021 14:19:43 +0000 (10:19 -0400)]
LP1933275 Staff catalog holdings view shows correct counts

teaches the Holdings view to determine the number of copies and call
numbers attached to each org unit based on the full data set (via new
API) instead of copies in hand, since we may only have copies in hand
for a subset of child org units.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoDocs: remove outdated screenshots
Jane Sandberg [Thu, 2 Dec 2021 00:08:52 +0000 (16:08 -0800)]
Docs: remove outdated screenshots

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoDocs: update lsa-barcode-completion
gmontimantis [Thu, 18 Nov 2021 13:57:26 +0000 (08:57 -0500)]
Docs: update lsa-barcode-completion

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoDocs: correction to 3.7.2 release notes
Andrea Buntz Neiman [Tue, 30 Nov 2021 15:36:01 +0000 (10:36 -0500)]
Docs: correction to 3.7.2 release notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
4 years agoDocs: correction to Override Action docs
Andrea Buntz Neiman [Tue, 30 Nov 2021 15:29:43 +0000 (10:29 -0500)]
Docs: correction to Override Action docs

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
4 years agoLP1772631 Untranslatable Strings
Shula Link [Fri, 14 May 2021 18:14:15 +0000 (14:14 -0400)]
LP1772631 Untranslatable Strings

Changes as suggested have been made in t_bills_historical.tt2, marking
appropriate lines for translation.

Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoLP#1949910: serialize deleting items from item bucket
Galen Charlton [Thu, 11 Nov 2021 16:21:11 +0000 (11:21 -0500)]
LP#1949910: serialize deleting items from item bucket

This patch serializes the fetching and fleshing of items to delete
when the delete-from-item-bucket action is invoked, thereby
avoiding possible drone starvation from open-ils.search. It
also throws up the progress dialog for good measure while
the deletion occurs.

To test
-------
[1] Set up an item bucket with 25-50 items.
[2] From the item bucket intervace, invoke the action to delete
    all of the items.
[3] Note that the open-ils.search.asset.copy.fleshed2.retrieve calls,
    one for each item, are all made simultaneously. Assuming stock
    max_children settings, this will cause open-ils.search to log
    that some requests are hitting the backlog.
[4] Apply the patch and refresh the item bucket page, then repeat
    step 2 (it doesn't matter for this purpose that the items have
    already been deleted). This time, the open-ils.search API calls
    are made serially and a progress bar is displayed while the
    deletion takes place. Verify that no requests hit the backlog.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoForward Port 3.6.3 Upgrade Script
Jason Boyer [Thu, 18 Nov 2021 13:52:09 +0000 (08:52 -0500)]
Forward Port 3.6.3 Upgrade Script

4 years agodocs: updating batch_importing_MARC.adoc
gmontimantis [Wed, 17 Nov 2021 18:40:16 +0000 (13:40 -0500)]
docs: updating batch_importing_MARC.adoc

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoDocs: lp1739277 Release Notes for Org Selector Styling
Kyle Huckins [Wed, 31 Jul 2019 16:42:35 +0000 (16:42 +0000)]
Docs: lp1739277 Release Notes for Org Selector Styling

- Add release notes for new Org Selector Styling functionality.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
new file:   docs/RELEASE_NOTES_NEXT/Client/org-select-styling.adoc

Signed-off-by: Jennifer Bruch <jbruch@sparkpa.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agolp1739277 OrgSelect Class Callback Holdings Implementation
Kyle Huckins [Tue, 30 Jul 2019 19:00:14 +0000 (19:00 +0000)]
lp1739277 OrgSelect Class Callback Holdings Implementation

- Implement OrgSelectClassCallback in Angular Catalog Holdings UI

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/catalog/record/holdings.component.html
modified:   Open-ILS/src/eg2/src/app/staff/catalog/record/holdings.component.ts

Signed-off-by: Jennifer Bruch <jbruch@sparkpa.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agoLP1739277 Angular org selector style callback
Bill Erickson [Tue, 30 Jul 2019 16:12:12 +0000 (12:12 -0400)]
LP1739277 Angular org selector style callback

Allow the caller of an <eg-org-select> to pass a function which is
called against each org unit in the list to determine what CSS class(es)
should be applied to the org unit label in the list.

Includes sandbox example.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Bruch <jbruch@sparkpa.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agolp1855780 stamp upgrade script
Jane Sandberg [Wed, 17 Nov 2021 19:53:52 +0000 (11:53 -0800)]
lp1855780 stamp upgrade script

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agolp1855780 preload values for comboboxes in angular event definition editor
Jane Sandberg [Wed, 17 Nov 2021 19:39:04 +0000 (11:39 -0800)]
lp1855780 preload values for comboboxes in angular event definition editor

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agolp1855780 remove unnecessary whitespace
Jane Sandberg [Wed, 17 Nov 2021 19:22:16 +0000 (11:22 -0800)]
lp1855780 remove unnecessary whitespace

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoLP#1855780: add release notes entry
Galen Charlton [Tue, 9 Nov 2021 15:53:58 +0000 (10:53 -0500)]
LP#1855780: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoLP#1855780: add grid config settings
Galen Charlton [Tue, 9 Nov 2021 15:51:27 +0000 (10:51 -0500)]
LP#1855780: add grid config settings

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoLP#1855780: improve reporting of event test errors
Galen Charlton [Tue, 9 Nov 2021 15:41:58 +0000 (10:41 -0500)]
LP#1855780: improve reporting of event test errors

- make error title/caption strings available to i18n
- catch and report on exceptions, not just ILS events

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoLP#1855780: adjustments to cloning
Galen Charlton [Tue, 9 Nov 2021 15:24:04 +0000 (10:24 -0500)]
LP#1855780: adjustments to cloning

- set the owning OU to null in the clone
- reduce console noise when cloning environment entries

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoLP#1855780: tweaks to grids
Galen Charlton [Mon, 8 Nov 2021 20:58:04 +0000 (15:58 -0500)]
LP#1855780: tweaks to grids

- make main A/T event definition grid header sticky
- do not display environment ID and parameter ID
  columns by default in the event definition
  editor

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoLP#1855780: add option to include environment in clone of an event
Galen Charlton [Mon, 8 Nov 2021 17:28:19 +0000 (12:28 -0500)]
LP#1855780: add option to include environment in clone of an event

This recovers a patch from Mike Risher that got dropped
when attempting to get a clean rebase from a branch merge.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoLP#1855780: avoid race condition when deleting env or params
Galen Charlton [Mon, 8 Nov 2021 17:00:42 +0000 (12:00 -0500)]
LP#1855780: avoid race condition when deleting env or params

When deleting from a grid using pcrud.autoApply, the grid
should be refreshed only at the very end. Otherwise, even if you're
deleting only one row, the grid reload could occur before the
deletion is committed, yielding a grid fetch error when
pcrud complains about verifying access to a row that is
no longer in the database.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoLP#1855780: updates to IDL
Galen Charlton [Mon, 8 Nov 2021 16:51:15 +0000 (11:51 -0500)]
LP#1855780: updates to IDL

- mark various action/trigger record fields as required
  for the sake of the Angular record editor
- make atcol retrievable via pcrud

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoLP#1855780: fix lint
Galen Charlton [Mon, 8 Nov 2021 16:26:47 +0000 (11:26 -0500)]
LP#1855780: fix lint

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoLP#1855780: adding the go-back button from Mike Risher's code
Rogan Hamby [Fri, 24 Sep 2021 19:21:47 +0000 (19:21 +0000)]
LP#1855780: adding the go-back button from Mike Risher's code

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoLP#1855780 Angular Notification/Action Triggers port
Mike Risher [Thu, 19 Dec 2019 17:56:41 +0000 (17:56 +0000)]
LP#1855780 Angular Notification/Action Triggers port

Port Notification Action Triggers from DOJO to Angular.  This consists of 4 grids, each
navigated to by its corresponding tab. The Trigger Event Definitions grid allows
cloning of records.  When editing an event defintion one can also edit parameters,
environments, and run tests.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoLP1951030: Remove OpenILS/Utils/ISBN from Manifest
Jason Stephenson [Mon, 15 Nov 2021 22:50:25 +0000 (17:50 -0500)]
LP1951030: Remove OpenILS/Utils/ISBN from Manifest

Remove a remnant of the OpenILS::Utils::ISBN module that was removed
in the branch for Launchpad bug 1856906.

To test this fix, run make check in Open-ILS/src/perlmods on a test
system to run the tests.  Before this patch, you get the following
message:

WARNING: the following files are missing in your kit:
lib/OpenILS/Utils/ISBN.pm
Please inform the author.

After applying this patch, the message goes away.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1856906: (follow-up) fix unit test count
Galen Charlton [Fri, 12 Nov 2021 20:38:17 +0000 (15:38 -0500)]
LP1856906: (follow-up) fix unit test count

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoDocs: Adding latency test and disable sounds to workstation admin.
Jennifer Pringle [Thu, 7 Oct 2021 18:46:13 +0000 (11:46 -0700)]
Docs: Adding latency test and disable sounds to workstation admin.

Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoDocs: Transit List
Lynn Floyd [Fri, 4 Jun 2021 19:41:31 +0000 (15:41 -0400)]
Docs: Transit List

Documentation on Transit List.

Signed-off-by: Lynn Floyd <alynn2671@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoDocs: Update receipt_template_editor.adoc
gmontimantis [Mon, 28 Jun 2021 16:22:57 +0000 (12:22 -0400)]
Docs: Update receipt_template_editor.adoc

Fixes https://bugs.launchpad.net/evergreen/+bug/1929592

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
4 years agoLP1766726 Clarify Field Hints on Print Templates
Terran McCanna [Tue, 21 Sep 2021 20:48:50 +0000 (16:48 -0400)]
LP1766726 Clarify Field Hints on Print Templates

Adds 'patron.' to beginning of patron field hints in Checkout and Items Out
templates to make it easier for users to understand.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1528301: minor tweaks to release notes
Galen Charlton [Thu, 11 Nov 2021 15:16:19 +0000 (10:16 -0500)]
LP#1528301: minor tweaks to release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1528301: Release Note for Phone in Checkin Response
Jason Boyer [Fri, 6 Sep 2019 18:22:30 +0000 (14:22 -0400)]
LP1528301: Release Note for Phone in Checkin Response

Have to tell people about it if they're going to use it.

Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1528301: Hold Notify Phone in Checkin Response
Jason Boyer [Fri, 6 Sep 2019 18:10:45 +0000 (14:10 -0400)]
LP1528301: Hold Notify Phone in Checkin Response

Adds a setting to oils_sip.xml.sample to en/dis-able
the extention of including the hold notify phone number
for captured holds in the SIP Checkin Response.
Defaults to false.

Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1528301 Add SIP Support for BF field on type 10 checkin responses
blake [Thu, 9 Jun 2016 14:04:56 +0000 (09:04 -0500)]
LP1528301 Add SIP Support for BF field on type 10 checkin responses

This little patch will append the BF field in the SIP response during
checkin when the item is for another hold. Some self check software vendors
(ahem Bibliotheca) implement the hold phone number for the next patron this way.
You will need this patch as well as the code change to the SIPServer repo
LP1528301_Add_SIP_Support_for_BF_field_on_type_10_checkin_responses

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1856906: remove unused OpenILS::Utils::ISBN perl module
Jane Sandberg [Thu, 15 Jul 2021 20:58:43 +0000 (13:58 -0700)]
LP1856906: remove unused OpenILS::Utils::ISBN perl module

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1819233 improve AngularJS eg-basic-combo-box filtering
Mike Risher [Wed, 20 May 2020 23:27:20 +0000 (23:27 +0000)]
LP#1819233 improve AngularJS eg-basic-combo-box filtering

Adjust the eg-basic-combo-box so that it doesn’t give console errors
when typing characters such as [. Fix the bug that causes it to
sometimes show no results when there are valid results that match.

To test
-------
[1] Apply the patch, then create a new report template, add a
    display field, then open the Change Transform modal.
[2] Verify that the selection box will accept characters like '['
    as input without browser console noise, that the filtering
    is case-insensitive, and that filtering continues to work
    after clicking on the selector.
[3] Instances of this combo box can also be found in the AngularJS
    volume/copy editor.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1906842 PLACE_UNFILLABLE_HOLD permission not working if no titles exist
Steven Callender [Fri, 4 Dec 2020 14:59:25 +0000 (09:59 -0500)]
LP1906842 PLACE_UNFILLABLE_HOLD permission not working if no titles exist

This fix will correct an issue where the screen just keeps looping to
the override screen when trying to place a hold that has no titles
available for it.

Patch courtesy of Mike Rylander.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agodocs: 3.8 Triggered Events Log Rewrite
Angela Kilsdonk [Mon, 18 Oct 2021 13:38:28 +0000 (09:38 -0400)]
docs: 3.8 Triggered Events Log Rewrite

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agodocs: 3.8 hold copy ratio reports
Andrea Buntz Neiman [Mon, 18 Oct 2021 13:35:33 +0000 (09:35 -0400)]
docs: 3.8 hold copy ratio reports

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agodocs: 3.8 Acq Admin
Angela Kilsdonk [Mon, 18 Oct 2021 13:32:24 +0000 (09:32 -0400)]
docs: 3.8 Acq Admin

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agodocs: 3.8 Patron Photo URL + Consolidate Patron Notes
Angela Kilsdonk [Mon, 18 Oct 2021 13:25:51 +0000 (09:25 -0400)]
docs: 3.8 Patron Photo URL + Consolidate Patron Notes

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agodocs: 3.8 selected new Library Settings
Andrea Buntz Neiman [Mon, 18 Oct 2021 13:19:53 +0000 (09:19 -0400)]
docs: 3.8 selected new Library Settings

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agodocs: 3.8 Override Actions
Andrea Buntz Neiman [Mon, 18 Oct 2021 13:16:12 +0000 (09:16 -0400)]
docs: 3.8 Override Actions

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agodocs: 3.8 Stripe Payment Intents
Andrea Buntz Neiman [Mon, 18 Oct 2021 13:13:36 +0000 (09:13 -0400)]
docs: 3.8 Stripe Payment Intents

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1831803: stamp schema update
Galen Charlton [Fri, 5 Nov 2021 22:30:53 +0000 (18:30 -0400)]
LP#1831803: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1831803: (follow-up) update release notes formatting
Galen Charlton [Fri, 5 Nov 2021 22:27:03 +0000 (18:27 -0400)]
LP#1831803: (follow-up) update release notes formatting

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1831803: drop the disused search-related types during upgrade
Galen Charlton [Fri, 5 Nov 2021 22:25:41 +0000 (18:25 -0400)]
LP#1831803: drop the disused search-related types during upgrade

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1831803: Remove unused data types
Jason Boyer [Fri, 24 Sep 2021 13:12:20 +0000 (09:12 -0400)]
LP1831803: Remove unused data types

The search.search_args and search.search_result types appear to have only
been used in combination with search.query_parser_qts, so they can also
be retired.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1831803: release note for removing old staged search stuff from db
Jeff Davis [Fri, 18 Oct 2019 19:44:52 +0000 (12:44 -0700)]
LP#1831803: release note for removing old staged search stuff from db

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1831803: remove asset.refresh_opac_visible_copies_mat_view if it exists too
Jeff Davis [Fri, 18 Oct 2019 19:26:03 +0000 (12:26 -0700)]
LP#1831803: remove asset.refresh_opac_visible_copies_mat_view if it exists too

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1831803: remove obsolete asset.opac_visible_copies and search.query_parser_fts...
Jeff Davis [Wed, 5 Jun 2019 21:30:11 +0000 (14:30 -0700)]
LP#1831803: remove obsolete asset.opac_visible_copies and search.query_parser_fts from database

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1830387: add release notes entry
Galen Charlton [Fri, 5 Nov 2021 22:19:55 +0000 (18:19 -0400)]
LP#1830387: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1830387: (follow-up) normalize whitespace
Galen Charlton [Fri, 5 Nov 2021 22:18:59 +0000 (18:18 -0400)]
LP#1830387: (follow-up) normalize whitespace

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP1830387 Add access to juvenile flag in print templates
Terran McCanna [Tue, 21 Sep 2021 20:18:51 +0000 (16:18 -0400)]
LP1830387 Add access to juvenile flag in print templates

Adds juvenile t/f flag to print templates for checkout and
items out.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agodocs: add 3.8 to target branches for Antora
Galen Charlton [Fri, 5 Nov 2021 21:21:39 +0000 (17:21 -0400)]
docs: add 3.8 to target branches for Antora

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoTranslation updates - po files - 3.8.0
Galen Charlton [Fri, 5 Nov 2021 20:23:51 +0000 (16:23 -0400)]
Translation updates - po files - 3.8.0

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>