teach place hold form how to clear cart

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

add clear entire basket checkbox to baskets page

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

show only current basket when invoking the lists page from a 'create list from basket' action

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

add confirmation when using the AJAX Clear Basket link

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

if the basket page is used to clear all items from basket, return to original referrer

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

avoid interference with search form enter-to-submit

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

add 'add to new list' action on the view basket page (for baskets only)

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

disable basket actions when none selected

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

change style of action menu

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

fix issues with managing multiple query (and other) CGI params

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

show clear cart link only when cart has contents

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

more wording fixes

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

disable advanced hold options if we have multiple holds

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

improve images

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

more changes

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

replace icons with basket images

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

change visible labeling of 'Cart' to 'Basket'

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

fix hold form when placing multiple titles

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

display cart on browse and advanced search forms too

Signed-off-by: Galen Charlton <gmc@equinoxintiative.org>

show cart controls on results when logged in

make legacy (and page-specific) add/remove cart budgets use AJAX when JS available

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

check entries in cart view by default

hover text for checkboxes

ensure that cart has access to list of bookbags

(when user is logged in)

unbreak place_hold action

more fixed to select-all checkbox management

add AJAX cart clearing action

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

tweak handling of select-all

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

better syncing of cart state

This patch improves how the display of the cart size and selected records
are handled when the back (and forward) buttons are used, and embeds
record_selectors.js on all pages. It also:

* adds more bullet-proofing of element existance in record_selectors.js
* adds an /eg/opac/api/mylist/retrieve API

clarify warning message when cart is empty

Since the idiom is changing from "creating a temporary list"
to "filling a cart that always exists, but might be empty", adjust
the warning message accordingly.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

and have list actions check for zero-selection actions

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

implement warning if attempting action from cart view with nothing selected

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

fix actually moving cart items to new list

teach create new list action how to move contents of cart to it

note that the mkurl macro is now also getting the beginnings of
a hard-coded list of params to always clear so that move_cart_by_default
doesn't travel around unnecessarily

warn if attempting to print or email an empty cart

Also:

* make styling of the warning message consistent
* add return to referrer button

fix matching of bib IDs

fix emailing only subset of records

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

fix previous patch

use a separate anon cache session for cart

This works around the staffsearches anoncache handling stomping
over the cart when the OPAC is embedded, as open-ils.actor.anon_cache.get_value
currently can't distinguish between an invalid session key and a case
where the sub-key is not yet populated in the anon cache value.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

another s/list/cart/g

LP#nnnn: fix title issue in bib email and print

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Merge remote-tracking branch 'origin/master' into user/gmcharlt/lp1721575_batch_actions

Forward port 3.1.2 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward port 3.0.8 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Docs: Add bullet number images removed in 2.10

These number images are used by the code callout feature of AsciiDoc,
used by the new Receipt Template Editor chapter (and possibly other
docs). I had renamed them in 2015, supposedly to prevent an ePub build
error, but that broke the code callout images. And since I cannot
replicate the ePub error now, I am renaming them back to their original
state, with sincere apologies to code callout readers everywhere.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: Release notes entry for lp1732975

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

lp1732975 Parts Column Not Populated

- Retrieve Parts information in egItem

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/item/t_list.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/services/item.js

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: Add release note for bug 1707063 to 3.0 notes

I missed the 3.0 notes in the earlier commit.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: Add release note for bug 1707063

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1707063: Naive ng-class test for last-column-modified

Instead of comparing a (potentially undefined) property of a column, we'll
just compare the column object directly when checking to see if a column
header should be highlighted for "last touched in editing mode."

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: Add release notes entry for lp1766379

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1766379: add spaces between terms in author link to prevent a broken search query

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: adding to 3.1.2 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: correcting description of a bugfix

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding to 3.0.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1750887: Copy Objects when Saving Copy Templates

Copy the callnumbers and statcats objects when saving
copy templates to prevent accidental and confusing
editing of in-memory copies.

cesardv: changed tabs to spaces.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1771422 Reset transiting hold copy status fix

Avoid modifying the copy status in the hold-reset API when it's passing
the copy off to the transit API for canceling the transit.  Let the
transit API handle the status instead.

This fixes a bug where resetting a transiting hold, and canceling its
transit, would leave the targeted copy in "in transit" status instead of
"canceled transit".

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1750630: use proper quoting to un-break Transit List print template

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1528909: Patron search clickable barcodes

Patron barcodes in the patron search grid are now click-able, making it
possible to quickly open multiple patrons in new tabs from patron search
by control-clicking (or middle-clicking) the barcode links.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1721148: In-house use shows copy status

Adds a Copy Status column to the In-House use checkout grid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Geoff Sams <gsams@roanoketexas.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Lp#1760859: Add Missing Images to Tranist and Hold Slips

Added new truck transit.png image for web client holds/transit dialog

Added holds.png img tag to t_hold_shelf_dialog.tt2

Added transit.png img tag to t_transit_dialog.tt2

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1759352: improve webstaff fix checkout specific due date UX

The Date Options dropdown UI added as a result of bug 1717025
hides the state of the "checkboxes" for custom due date and
the datepicker wasn't disabled when custom due date was disabled.
This addresses these UX issues, to that the user has visual feedback
as to the state of that option.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1751126: Make print holds shelf list aware of clear mode.

We change the Print Full List button on the holds shelf view to be
aware of whether clear mode is active.  If clear mode is active, then
the list of holds to clear is printed.  If not, then the full holds
shelf list is printed.

This commit does not change the label of the print full list button.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772417: (follow-up) improve I18N of the bucket title string

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1772417: Adding the bucket ID to the user bucket display

To test:
1) Open a patron bucket.  Note that the bucket ID is not listed
in the bucket information section at the top of this screen.
2) Apply this commit.
3) Open the same patron bucket.  Note that the bucket ID is
listed in the bucket information section

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1752753: Guard against invalid timezone

If the lib.timezone org setting is not a valid timezone, attempting to
use it can result in an internal server error in the OPAC.  Let's handle
the error with try/catch instead.

To test
-------
1. In Library Settings Editor, edit the "Library time zone" setting for
   Example Branch 1, setting the value to something that's not the name
   of a time zone (like "invalid" or "UTC-07:00").
2. In the OPAC, retrieve a record with holdings at Example Branch 1.
    You will get an Internal Server Error.
3. Edit the library setting to use a valid timezone name, like
   "America/Vancouver".
4. Retrieve the same record again. This time, the record will display
   properly.
5. Apply the patch and repeat steps 1 and 2; this time, there should
   be no internal server error.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Moving upgrade script into place

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1768992: Add missing copy alert permissions

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1693035 Login timeout honors workstation org

Use the org unit linked to the provided workstation to collect the
login timeout org unit setting value during login.  Previously, all
checks defaulted to the global org unit.

This patch solidifies the precedence order for OUS lookups during login
like so:

1. Workstation org unit.
2. API org unit value.
3. Users' home org unit.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1746815: Fix sticky hold url param

Renamed the hold_id url param from "id" to "hid" and prevent it from
sticking in url's where it not needed.

To test
-------
[1] Log in to the public catalog as a patron that has at least
    two hold requests.
[2] Go to the My Account holds tab and edit one of the holds.
[3] Rather than submit a change, click on the holds tab again.
[4] Note that /only/ the hold you were edit displays, and that the
    'id' URL parameter persists as you navigate through the public
    catalog.
[5] Apply the patch and repeat steps 1-3. This time, you should
    see all of the holds.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1772017: Correctly Extract Cast from Records

authors.tt2 has been using field 508 for cast display but
the correct field is 511 when ind1=1.

Testing note:

In the Concerto data set, the title "The rum diary" is a good test
record, as it has both a 508 field and a 511.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Adding to 3.1.2 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding to 3.0.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1753005: Avoid copy alert error for call numbers with no copies

When displaying the Holdings View tab for a bib in the web staff client,
if a volume record has no copies, a Javascript error gets thrown.

Item-less volumes still end up in svc.copies at this point, so at the
moment it is necessary to check whether copy_alerts actually exists.
Some renaming might also be in order to clarify that svc.copies doesn't
necessarily contain /only/ fleshed acp records.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1721575: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1755220: Return value checking in offline session fetch

We need to make sure that we receive the correct shape of data (array) rather
than that we simply got anything when fetching sessions.  In the case of an
expired session token, we'll receive an ILS Event object informing us of the
expiration where we'd normally see a list of sessions.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1745240: Hold Alias Missing from Hold Shelf Slip

A patron's hold alias can be printed in the hold shelf slip using the variable patron.alias.  This patch just adds 'patron.alias' to the list of available options displayed at the top of the template. Also adds a colon before the patron's name fields for consistency.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1745232 - Bill History Receipt doesn't have Finish Date

Adds xact.finish and xact.summary.last_payment to the example data.  Also adds xact.summary.last_payment_ts to the template body to indicate when the last payment was made.  Also adds a list of variables that can be used in the template in the template's description.

To test -
1. apply the patch
2. find a patron with billings, or add some billings to a patron record.
3. make payments on some of the billings using various methods.
4. go to billing history and print the history list.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1743782 Copy Status not available in Check-In Screen

Makes the status an available column to display in the Check-In screen.

To test:
1. Apply patch.
2. Go to check-in and display 'Status' as a column in the table.
3. Check-in various items that may be checked-out, catch a hold, not checked out, etc.

Signed-off-by: gcollum <gcollum@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1765731 - restore CN suffix and preffix in Holds Pull List

Overly gung-ho removal of "redundant" fields/columns in bug
1728147 removed call number prefix and suffix as available columns
in the hold pull list grid in the web staff client; this will
restore them there.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

implement ctx.max_cart_size

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add print and email actions to list and cart pages

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

don't show add to list cart action in staff view

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

fix visibility of popmenu

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

separate out cart from list in actions list

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

more terminology tweaks

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Adding to and reorganizing the 3.1.2 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Adding to and reorganizing the 3.0.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

add an add-to-cart action for the web staff client

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add the actual image

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

replace clipboard icon with smaller cart icon in appropriate contexts

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

yet more terminology tweaks

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

another terminology tweak

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

change user terminology from Temporary List to Cart

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

implement action to place hold on entire list

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add action for emailing cart

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

add template for cart clearing confirmation

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1765444: improve how MARC editor fetches fixed field metadata

This patch fixes a problem where the web staff MARC editor would
make repeated and redundant calls to two Evergreen methods to fetch
data about fixed field positions and values if that metadata was
not already cached by local storage or Hatch.

In particular, this patch caches and returns the data retrieval
promises, ensuring that only one set of FF position and value
requests are made.

Prior to this patch, each eg-marc-edit-fixed-field directive, of which
there are 64, could end up invoking those methods when initializing
the editor for a record type that had not been previously seen.

To test
-------
[1] Clear all FFPosTable_* and FFValueTable_* keys from local storage
    (or Hatch).
[2] Retrieve a bib record in the web staff client. Note that up to
    64 calls each are made of open-ils.cat.biblio.fixed_field_values.by_rec_type
    and open-ils.fielder.cmfpm.atomic.
[3] Apply the patch and repeat steps #1 and #2.
[4] This time, note that only one call each are made.
[5] Verify that the fixed field inputs continue to work as expected.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

add explicit view action to cart menu