working/Evergreen.git
13 years agoSMS Number Munging user/mrpeters-isl/sms_munge_signoff
Thomas Berezansky [Tue, 2 Oct 2012 17:31:13 +0000 (13:31 -0400)]
SMS Number Munging

Munge "pretty printed" numbers into raw sets of digits in the A/T helper.

This allows aliases to still work for services that support them.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Tue, 2 Oct 2012 13:15:01 +0000 (09:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoDocumentation: Update authority control set documentation for authority field set up
Yamil Suarez [Tue, 2 Oct 2012 04:47:29 +0000 (00:47 -0400)]
Documentation: Update authority control set documentation for authority field set up

Updated the "authority fields" section with information on the valid "non-filing indicator" values.

Signed-off-by: Yamil Suarez <ysuarez@berklee.edu>
Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
13 years agoMerge branches 'master' and 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Fri, 28 Sep 2012 14:15:06 +0000 (10:15 -0400)]
Merge branches 'master' and 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoCopy location group searching repairs
Bill Erickson [Fri, 21 Sep 2012 21:10:58 +0000 (17:10 -0400)]
Copy location group searching repairs

In the get_library BLOCK, upgrade any use of 'loc' to 'locg' instead of
trying to determine which to use in which situation.  Before this change,
'loc' was being used as the loc_name for the main org unit selector,
which should always use 'locg'.  For any other cases (related to search
params), it's always safe to use 'locg' over 'loc'.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoMerge branches 'master' and 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Fri, 28 Sep 2012 06:15:01 +0000 (02:15 -0400)]
Merge branches 'master' and 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoDocs want a space after the main header
Dan Scott [Fri, 28 Sep 2012 05:00:54 +0000 (01:00 -0400)]
Docs want a space after the main header

Formatting gets messed up if we don't have the expected blank line after
the main header. Okay.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoMake relator_map script executable
Ben Shum [Wed, 5 Sep 2012 21:02:43 +0000 (17:02 -0400)]
Make relator_map script executable

Signed-off-by: Ben Shum <bshum@biblio.org>
13 years agoTPAC: Fine-grained credits in record details
Dan Scott [Wed, 5 Sep 2012 04:27:03 +0000 (00:27 -0400)]
TPAC: Fine-grained credits in record details

For 7xx fields with $4 subfields containing relator codes, generate a
relator code map from http://www.loc.gov/marc/relators/relacode.html
that we can use in the record details to provide specific credits,
rather than the generic (and often inappropriate) "Added author" label.

For example:

700 1. ‡aMaley, Desmond, ‡d1954- ‡4prf.

This now generates "Maley, Desmond, 1954- (Performer)" in the record
details credit section.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
13 years agoDocs: Minimum list of TPAC templates to customize
Dan Scott [Fri, 28 Sep 2012 03:52:14 +0000 (23:52 -0400)]
Docs: Minimum list of TPAC templates to customize

In an effort to help new sites adopt the TPAC and avoid leaving
embarrassing placeholders around, I present... the minimum list!

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Wed, 19 Sep 2012 16:15:05 +0000 (12:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoDefault notify by text receipt replaces to blank
Thomas Berezansky [Wed, 19 Sep 2012 14:19:48 +0000 (10:19 -0400)]
Default notify by text receipt replaces to blank

So that when the option is disabled we don't leave behind things like
%notify_by_text% and %notify_by_text_msg%.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Wed, 19 Sep 2012 15:15:05 +0000 (11:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoTPAC: Results - don't show the pubdate if we're showing full pubinfo
Dan Scott [Wed, 12 Sep 2012 16:59:53 +0000 (12:59 -0400)]
TPAC: Results - don't show the pubdate if we're showing full pubinfo

In the "show few details" mode, we show just the pubdate; in the "show
full details" mode, we're showing the full pubinfo and therefore do not
need to show the stubby pubdate.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
13 years agoTPAC: Display full publication info
Dan Scott [Wed, 12 Sep 2012 15:50:03 +0000 (11:50 -0400)]
TPAC: Display full publication info

In both the results table and record summary, we were failing to display
the place of publication - which is critical information for people
trying to track down the right edition or constructing a bibliography.

Grab the place of publication, and then reconstruct 260abc (avoiding
another XPath iteration and giving ourselves the ability to enhance the
schema.org microdata at the same time).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
13 years agoEnable 1-hit redirect for item barcode searches
Thomas Berezansky [Mon, 20 Aug 2012 16:22:44 +0000 (12:22 -0400)]
Enable 1-hit redirect for item barcode searches

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoProtect against fleshed circ_lib in legacy check_age_protect
Bill Erickson [Mon, 17 Sep 2012 12:48:26 +0000 (08:48 -0400)]
Protect against fleshed circ_lib in legacy check_age_protect

Retrieving org settings with an org unit object as the context org unit
results in errors and dying.

This affects legacy scripts only.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Tue, 18 Sep 2012 15:15:06 +0000 (11:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoSort of in line with 949322 but not absolutely necessary
edoceo [Thu, 2 Aug 2012 02:37:37 +0000 (19:37 -0700)]
Sort of in line with 949322 but not absolutely necessary
This just supresses the message about what text was copied to the clipboard - globally!

Signed-off-by: edoceo <code@edoceo.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agolp949322 Copy Patron barcode to clipboard when clicking their name
edoceo [Thu, 2 Aug 2012 02:33:20 +0000 (19:33 -0700)]
lp949322 Copy Patron barcode to clipboard when clicking their name
CTRL+Click will open the patron record in a new tab

Signed-off-by: edoceo <code@edoceo.com>
This affects the patron label in Item Status -> Alt View -> Holds/Transits.  Looks good to me.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Sun, 16 Sep 2012 15:15:06 +0000 (11:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoVarious additions to the 2.3 release notes.
Kathy Lussier [Sun, 16 Sep 2012 04:56:55 +0000 (00:56 -0400)]
Various additions to the 2.3 release notes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Tue, 11 Sep 2012 00:15:05 +0000 (20:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoHide Print Page button on Simplified Pull List
Ben Shum [Mon, 10 Sep 2012 19:03:59 +0000 (15:03 -0400)]
Hide Print Page button on Simplified Pull List

On the Simplified Pull List interface, there is a button for "Print Page"
that shows up in the upper right corner. The suggestion is to hide that
button to avoid library staff printing just what's visible instead of using
the proper "Print Pull List" button that's actually on the page.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Fri, 7 Sep 2012 18:15:05 +0000 (14:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoTPAC: Escape single quotes in MFHD record location
Dan Scott [Thu, 6 Sep 2012 16:25:01 +0000 (12:25 -0400)]
TPAC: Escape single quotes in MFHD record location

If an MFHD record contains an 852 field with a subfield containing a
single quote, the unescaped single quote is introduced directly into the
value of the JavaScript hash that uses single quotes as delimiters -
thereby generating a JS exception and preventing the staff client from
properly populating the MFHD Editor menu.

This commit escapes incoming single quotes from the MFHD location field
to prevent that from happening. The other fields in the JS hash are
numeric and therefore should not need escaping.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Fri, 7 Sep 2012 17:15:05 +0000 (13:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Fri, 7 Sep 2012 16:15:05 +0000 (12:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoRemove defunct variable from 'jtitle' code
Dan Wells [Fri, 7 Sep 2012 13:50:11 +0000 (09:50 -0400)]
Remove defunct variable from 'jtitle' code

With the second part of the 'jtitle' code moved elsewhere,
we no longer need this extra '$q' variable.  No big deal, but
best to sweep up while we're in here.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoRevert "Bug #1044721: QP handles explicit group+joiner badly"
Lebbeous Fogle-Weekley [Fri, 7 Sep 2012 15:42:12 +0000 (11:42 -0400)]
Revert "Bug #1044721: QP handles explicit group+joiner badly"

This reverts commit b77bb9943009b81042b4ef1a6ac33ec9e3e96dd7.

Unfortunately this had side effects that escaped our manual testing
processes.  Especially with facets as reported by Ben Shum.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Fri, 7 Sep 2012 14:15:05 +0000 (10:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoJournal title hackery - move to a more robust location
Dan Scott [Fri, 7 Sep 2012 03:37:32 +0000 (23:37 -0400)]
Journal title hackery - move to a more robust location

The fix for bug #1044721 broke the journal title hack, which probably
should have lived where this commit moves it - if, in the age of filter
groups, we decide whether it's worthwhile to keep it alive at all.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Tue, 4 Sep 2012 21:15:05 +0000 (17:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoUpgrade bits for Vandelay Overlay Changes
Dan Wells [Tue, 4 Sep 2012 21:09:44 +0000 (17:09 -0400)]
Upgrade bits for Vandelay Overlay Changes

Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoIncrease Overlay Speed for Standard Identifiers
Dan Wells [Thu, 30 Aug 2012 19:26:15 +0000 (15:26 -0400)]
Increase Overlay Speed for Standard Identifiers

Due to an inefficient query order and a confused query planner,
some overlay matching can end up going abysmally slow.  See LP
bug #1024095 for elaboration on the issue.

This commit reorders the joins as originally suggested by Lebbeous,
then adds a specific index to coax the query planner into making the
best choices.  The example index here only targets the 02x identifier
fields, so other tag/subfield/substring(value) indexes will likely
be necessary for maximum benefit when matching on other fields
(e.g. 010).

These changes combined with the previous commit which replaces 'LIKE
ANY' with 'LIKE (... OR ...)' has shown great promise in testing.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoVandelay: Fix index-miss with MARC Imports using Match Sets
Lebbeous Fogle-Weekley [Tue, 26 Jun 2012 00:00:33 +0000 (20:00 -0400)]
Vandelay: Fix index-miss with MARC Imports using Match Sets

In some Postgres installations, an expression such as:

(value LIKE '13423488%' OR value LIKE '245425%') will use a btree index,
but

value LIKE ANY('{13423488%,245425%}'::TEXT[])

will not.

Missing such an index can make matching incoming bibs based on a field
that's present in most of your existing records terrifically slow.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoBug #1044721: QP handles explicit group+joiner badly
Jared Camins-Esakov [Sat, 1 Sep 2012 14:21:51 +0000 (10:21 -0400)]
Bug #1044721: QP handles explicit group+joiner badly

Although the following four queries should be equivalent:
  george  ||  fred
 (george) ||  fred
  george  || (fred)
 (george) || (fred)

The Pg QueryParser driver generates SQL queries that return different
numbers of results for each of those queries, with all desired results
appearing only with the first query. This seems to be because of the way
filters are added in the interface.

This patch adjusts the Search code in TPAC to add an explicit group
around the user-entered query, which enables the Pg QueryParser driver
to handle all four of the above queries properly.

This patch should also resolve the problems encountered with the patch
for bug #1040740, "Implicit ANDs should have higher precedence than
explicit ORs"

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Tue, 4 Sep 2012 19:15:05 +0000 (15:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoGracefully handle reporter class with no labels
Bill Erickson [Tue, 4 Sep 2012 18:43:27 +0000 (14:43 -0400)]
Gracefully handle reporter class with no labels

LP 1045964 -- unable to clone report template

The template interface was failing while rendering the reporter sources
drop-down when a reporter source (IDL class) had no label.  This adds a
sanity check around that.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Tue, 4 Sep 2012 18:15:05 +0000 (14:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoFix Merge All Records in Bucket action
Thomas Berezansky [Tue, 4 Sep 2012 17:23:37 +0000 (13:23 -0400)]
Fix Merge All Records in Bucket action

A xul file was not being prefixed with oils://remote

Note: This is a quick fix. Ideally we move the url to constants.js.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoDefine a few strings missing from cat.properties
Dan Scott [Tue, 4 Sep 2012 17:46:41 +0000 (13:46 -0400)]
Define a few strings missing from cat.properties

By the power of build/i18n/test/check_properties.py ...

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoImporting translations for 2.3.rc1
Bill Erickson [Fri, 31 Aug 2012 22:46:27 +0000 (18:46 -0400)]
Importing translations for 2.3.rc1

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Sun, 2 Sep 2012 04:15:07 +0000 (00:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoDo the SQL upgrade dance for list pubdate in CSV
Dan Scott [Sun, 2 Sep 2012 02:59:21 +0000 (22:59 -0400)]
Do the SQL upgrade dance for list pubdate in CSV

With a slight tweak to base the upgrade off of the event definition name
instead of the ID; possibly more resilient.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Sun, 2 Sep 2012 03:15:06 +0000 (23:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoAdd pub date to CSV output.
Jason Stephenson [Fri, 27 Jul 2012 13:25:05 +0000 (09:25 -0400)]
Add pub date to CSV output.

Change the template for the ContainerCSV reactor to add the publication
date (MARC 260$c) in the csv output in the same position that the previous
commit adds it to the html output.

Add an upgrade script to update the existing template for the ContainerCSV
reactor in action_trigger.event_definition.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoTPAC: Add the ability to set a different default locale
Dan Scott [Sat, 4 Aug 2012 14:10:48 +0000 (10:10 -0400)]
TPAC: Add the ability to set a different default locale

Installations with multiple sites might desire different default locales
for their skins. This adds the Apache config directive
"OILSWebDefaultLocale", which enables you to set the default locale on a
global and a per-skin basis.

Note that this prevents the browser Accept-language header from having
any effect; sadly that header is not often used in real life.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Conflicts:
Open-ILS/examples/apache/eg_vhost.conf

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Fri, 31 Aug 2012 19:15:06 +0000 (15:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoTPAC: Make call number browse record links retain search lib
Dan Scott [Mon, 13 Aug 2012 20:50:33 +0000 (16:50 -0400)]
TPAC: Make call number browse record links retain search lib

In addition to maintaining scope for the call number browse search
results, we also need to maintain the scope for the links for the call
number records in the results themselves (for example, the "retrieve
this record" link, or the "search for this author" link).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Thu, 30 Aug 2012 19:15:06 +0000 (15:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoDocumentation: removie file reference to line items since section was moved to anothe...
Robert Soulliere [Thu, 30 Aug 2012 18:52:08 +0000 (14:52 -0400)]
Documentation: removie file reference to line items since section was moved to another file.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
13 years agoDocumentation: Add sections for new features in Acquisitions
Robert Soulliere [Thu, 30 Aug 2012 18:40:00 +0000 (14:40 -0400)]
Documentation: Add sections for new features in Acquisitions

From: http://www.esilibrary.com/esi/availableDocs.php
RS added some index terms to start beefing up our index for the docs.

13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Thu, 30 Aug 2012 18:15:05 +0000 (14:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoChanged the thawing of a hold to first update the hold record and then re-target.
Steven Callender [Tue, 10 Jul 2012 19:43:59 +0000 (15:43 -0400)]
Changed the thawing of a hold to first update the hold record and then re-target.

When thawing a hold, originaly we were first re-targeting before actually saving the hold record. On items with large quantities, sometimes the hold would timeout on targetig before getting a chance to actually save. This patch moves things around to first save the hold record before attempting to retarget.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Thu, 30 Aug 2012 17:15:06 +0000 (13:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoAcq: In general search, make value widgets for OU-linked fields right again
Lebbeous Fogle-Weekley [Thu, 30 Aug 2012 16:42:01 +0000 (12:42 -0400)]
Acq: In general search, make value widgets for OU-linked fields right again

They always used to be OU selector dropdowns until a thinko in 55a82b5.
This restores them.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoAcq: Fix General Search for Lineitem Attribute-based fields
Lebbeous Fogle-Weekley [Thu, 30 Aug 2012 16:20:13 +0000 (12:20 -0400)]
Acq: Fix General Search for Lineitem Attribute-based fields

Reported by Ben Shum and Kathy Lussier, the Acq General Search interface
was broken in that you couldn't use any of the search fields under
Lineitem Attribute.  This error was indeed introduced by recent commit
55a82b5 as Ben determined, but simply reverting that commit left other
things broken.

This commit actually targets the problem and seems to fix it in my
testing.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Thu, 30 Aug 2012 16:15:05 +0000 (12:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoAcq: New lineitems added to existing POs should inherit provider
Lebbeous Fogle-Weekley [Tue, 28 Aug 2012 20:09:00 +0000 (16:09 -0400)]
Acq: New lineitems added to existing POs should inherit provider

Jeremy Miller of the Albany Public Library in Albany, OR, reports that
through the interface at
    Actions For This Record -> View/Place Orders
in the staff client, when you add a lineitem to an existing PO, the new
lineitem has a null value in the "provider" field, instead of inheriting
the expected value from the PO.

This causes problems for some Acquisitions workflows.

The feature containing the bug appeared in 2.2, and this fix for it can be
backported that far.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoACQ support for two-step vandelay imports
Bill Erickson [Wed, 2 May 2012 13:55:06 +0000 (09:55 -0400)]
ACQ support for two-step vandelay imports

If a lineitm is loaded into a queue via ACQ+Vandelay and a later attempt
is made to load the record into the catalog via ACQ+Vandelay, the
attempt will fail, because ACQ+Vandelay treats all
not-yet-fully-imported lineitems as new to vandelay.  This change
inspects lineitems at vandelay processing time to determine if they are
already linked to a VL record or if a new one is needed.  It also
removes the requirement that a queue be provided when all records in
process are already linked to a VL record (which already lives in a
queue).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Thu, 30 Aug 2012 04:15:06 +0000 (00:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoAdd a new "starts with" search option to the advanced search page.
Kathy Lussier [Wed, 1 Aug 2012 13:31:24 +0000 (09:31 -0400)]
Add a new "starts with" search option to the advanced search page.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Wed, 29 Aug 2012 14:15:05 +0000 (10:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoAdd kpac to 2.3 release notes
Bill Erickson [Fri, 24 Aug 2012 17:27:24 +0000 (13:27 -0400)]
Add kpac to 2.3 release notes

This is a snippet from the main kpac documentation in
docs/opac/kids_opac.txt, added to make sure it's represented in the
release notes.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Fri, 24 Aug 2012 19:15:06 +0000 (15:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoFix sorting when printing from FlattenerGrid-based interfaces
Lebbeous Fogle-Weekley [Mon, 13 Aug 2012 15:47:48 +0000 (11:47 -0400)]
Fix sorting when printing from FlattenerGrid-based interfaces

This particularly affects the Simplified Hold Pull List.  The printed
verison of your data is supposed to reflect the same sort order that has
been selected in the visual interface, and now it does.

Buggy handling of the different avenues of sorting the grid (clicking column
headers, using the column-picker/multicolumn-sort dialog, default sort order)
had broken the flow of the data needed to build the right sort clause for
some situations.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Fri, 24 Aug 2012 03:15:05 +0000 (23:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoFix epub complaint about image with extra colon
Dan Scott [Fri, 24 Aug 2012 03:02:42 +0000 (23:02 -0400)]
Fix epub complaint about image with extra colon

The "+" operators are typically only used to embed an image within an
ordered or unordered list to avoid breaking the indentation level or
numbering; here, we were using the "+" operators between regular
paragraphs, which doesn't make much sense. What made less sense was the
processing result, which bizarrely added an extra colon to the front of
the image path, leading to a (naturally) missing image and processing
error.

The fix is just to throw the image tag in between the paragraphs with no
special "+" operators; just blank lines.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Fri, 24 Aug 2012 02:15:06 +0000 (22:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoDocument how to create a TPAC/KPAC search box
Dan Scott [Fri, 24 Aug 2012 01:12:40 +0000 (21:12 -0400)]
Document how to create a TPAC/KPAC search box

Now that we're in the land of the TPAC, it's time to ensure that
everyone can update their simple search boxes so that they no longer
point at the JSPAC and point at the TPAC or Kid's OPAC instead.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoResolve doc PDF transform error
Dan Scott [Fri, 24 Aug 2012 01:14:02 +0000 (21:14 -0400)]
Resolve doc PDF transform error

The doc build gets angry when a target that does not exist is linked
from somewhere else in the docs. So, make the target exist.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Thu, 23 Aug 2012 19:15:06 +0000 (15:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoDocumentation: Add documentation for setting maximum checkout by copy location.
Sally Fortin [Thu, 23 Aug 2012 18:21:39 +0000 (14:21 -0400)]
Documentation: Add documentation for setting maximum checkout by copy location.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Thu, 23 Aug 2012 18:15:06 +0000 (14:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoDocumentaton: Add documentation on patron border color enhancements for 2.3.
Sally Fortin [Thu, 23 Aug 2012 17:40:51 +0000 (13:40 -0400)]
Documentaton: Add documentation on patron border color enhancements for 2.3.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Thu, 23 Aug 2012 14:15:05 +0000 (10:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoAdd 2.1.2-2.1.3 database schema upgrade script
Dan Scott [Thu, 23 Aug 2012 13:43:18 +0000 (09:43 -0400)]
Add 2.1.2-2.1.3 database schema upgrade script

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Wed, 22 Aug 2012 20:15:06 +0000 (16:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoMake the ContainerCSV reactor output more than 10 records.
Jason Stephenson [Thu, 26 Jul 2012 17:45:06 +0000 (13:45 -0400)]
Make the ContainerCSV reactor output more than 10 records.

Call AppUtils->bib_container_items_via_search with an args hashref
that hard codes the search limit to 1,000 records instead of using
the biblio.multiclass search default of 10.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoMake item_barcode_shortcut load user bookbags in EGCatLoader::Search.
Jason Stephenson [Wed, 25 Jul 2012 15:03:01 +0000 (11:03 -0400)]
Make item_barcode_shortcut load user bookbags in EGCatLoader::Search.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoMake sure that bookbag information loads in MARC expert search.
Jason Stephenson [Wed, 25 Jul 2012 20:41:44 +0000 (16:41 -0400)]
Make sure that bookbag information loads in MARC expert search.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoAllow some buttons in Import via Z39.50 to wrap lines
Dan Scott [Tue, 7 Aug 2012 20:39:37 +0000 (16:39 -0400)]
Allow some buttons in Import via Z39.50 to wrap lines

Some of our technicians with 4:3 ratio monitors and a reasonable
font-size are unable to see the "Import Record" button on the Import via
Z39.50 screen, because the buttons in that row are laid out in a single,
non-wrapping row, and there is no affordance for scrolling over to the
side.

Simply changing the containing "hbox" element to a "description" element
allows enough of the buttons to overflow to resolve the problem in our
experience.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoFix LP949249, Edit, then Create button creates a new item in all cases
Steven Chan [Wed, 25 Jul 2012 23:12:19 +0000 (16:12 -0700)]
Fix LP949249, Edit, then Create button creates a new item in all cases

This fix also resolves the following:
* https://bugs.launchpad.net/evergreen/+bug/806585,
Item Attributes saved on Close
* https://bugs.launchpad.net/evergreen/+bug/644753,
check for duplicate barcode during a create session in copy/volume editor

1. The Copy Editor screen is launched from the Volume Copy Creator,
which is launched from the Holdings Maintenance screen. If the default
interface is set, CE is shown in a separate window; if the 'unified'
interface is set, CE is embedded in the same window as VCC. Upon the
user clicking Save or Close in the Copy Editor, the intent is to create
a new item record or not, respectively.  However, it happens that a new
record is always created, because VCC instructs CE to let VCC update the
item, which will occur whether the user has clicked either button.

To fix 1, if the default interface is set, we reconfigure CE to update
the item or not, depending on the button clicked; otherwise, in the
unified interface, we allow VCC to update the item or not.

2. Upon updating the item, if the barcode is a duplicate, the ensuing
sequence of events is problematic: a database-level alert message is
shown, Copy Editor is closed, and Volume Copy Creator is closed, thus
forcing the user to re-formulate the request from Holdings Maintenance.

To fix 2, we show a higher-level alert message to the user. If the
default interface is set, we stay within CE, reconfigure the barcode to
be an input field, and focus the user on it; otherwise, in the unified
interface, we return the user to an area of the screen where the barcode
field is available. In either case, the user can re-enter a barcode
value and re-submit without losing any values previously entered into CE.

3. We also take the opportunity to enhance the coding performance of
Copy Editor, by delegating the handling of the button and key clicks to
the parent groupbox element. Previously, the event handler was attached
to several child elements, which is not performant.

Conflicts fix:

Open-ILS/xul/staff_client/server/cat/copy_editor.js

Signed-off-by: Ben Shum <bshum@biblio.org>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Wed, 22 Aug 2012 19:15:06 +0000 (15:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoRemove an extra ternary op
Thomas Berezansky [Thu, 12 Jul 2012 15:42:21 +0000 (11:42 -0400)]
Remove an extra ternary op

And adjust the comment to make more sense. There is no higher level filter
that prevents copy holds on parted items, so there is no filter for them to
"slip through".

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
13 years agoAllow copy-ish holds to target, even for part-copies, if they somehow slip through...
Mike Rylander [Wed, 13 Jun 2012 13:37:54 +0000 (09:37 -0400)]
Allow copy-ish holds to target, even for part-copies, if they somehow slip through the UI pre-checks

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
13 years agoTPAC: remove some unused CSS
Bill Erickson [Fri, 4 May 2012 14:04:32 +0000 (10:04 -0400)]
TPAC: remove some unused CSS

Remove CSS referring to images that are no longer in the repository.

See also https://bugs.launchpad.net/evergreen/+bug/956023

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
13 years agoTTPAC image directory cleanup
Michael Peters [Thu, 15 Mar 2012 13:49:06 +0000 (09:49 -0400)]
TTPAC image directory cleanup

There are a significant number of images remaining in TTPAC
that are no longer used, leftover from KCLS, etc.

This branch does a little cleanup on the image directory
and nets us about a 200KB savings overall.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
13 years ago2.2.1 -> 2.2.2 upgrade script
Lebbeous Fogle-Weekley [Wed, 22 Aug 2012 18:49:02 +0000 (14:49 -0400)]
2.2.1 -> 2.2.2 upgrade script

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoSanity check cstore limit/offset param values
Bill Erickson [Thu, 16 Aug 2012 19:40:58 +0000 (15:40 -0400)]
Sanity check cstore limit/offset param values

Certain cstore calls (direct / json_query) that support limit/offset
params called with a non-string / non-numeric value

e.g. { "limit": null }

result in a cstore segfault as it tries to call atoi(NULL) under the
covers.  This patch prevents this by verifying that the limit/offset
values are actual strings or numbers (i.e. return a value from
jsonObjectGetString) and not JSON_NULL, etc.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Wed, 22 Aug 2012 18:15:05 +0000 (14:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoTPac: Show email address when placing hold
Thomas Berezansky [Fri, 17 Aug 2012 20:20:35 +0000 (16:20 -0400)]
TPac: Show email address when placing hold

Both for staff and patron benefit.

Also, we disable the checkbox if there is no email address on file.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTPAC: Move "Export to RefWorks" into utility area
Dan Scott [Wed, 15 Aug 2012 11:18:53 +0000 (07:18 -0400)]
TPAC: Move "Export to RefWorks" into utility area

When the RefWorks functionality was being added to TPAC, the design and
layout were very much in flux. Now that the layout has been established
with utilities like "Place Hold" on the right hand side, move the
"Export to RefWorks" button into the same location.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Wed, 22 Aug 2012 17:15:05 +0000 (13:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years ago2.2.0 -> 2.2.1 upgrade script never actually went into master or rel_2_2
Lebbeous Fogle-Weekley [Wed, 22 Aug 2012 16:20:22 +0000 (12:20 -0400)]
2.2.0 -> 2.2.1 upgrade script never actually went into master or rel_2_2

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Wed, 22 Aug 2012 14:15:06 +0000 (10:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoImporting translations for 2.3.beta2, Part II
Bill Erickson [Wed, 22 Aug 2012 12:59:52 +0000 (08:59 -0400)]
Importing translations for 2.3.beta2, Part II

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoImporting translations for 2.3.beta2
Bill Erickson [Wed, 22 Aug 2012 12:45:54 +0000 (08:45 -0400)]
Importing translations for 2.3.beta2

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Michael Peters [Tue, 21 Aug 2012 22:15:05 +0000 (18:15 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen