adding index column to new reservations screen

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Merge branch 'user/sandbergja/ng-booking-refresh' of git.evergreen-ils.org:working/Evergreen into angular_booking

fixing typo

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

fixing typo

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

adding toast to successful cancelation

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

fixing columns in create reservation grid

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

adding a basic grid to create

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding a super-basic Create Reservation screen

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

make sure finished reservations are not in manage reservations

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

don't show canceled reservations

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

correcting grid refresh action

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Add Show Reservations for Resources

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Fix limit Manage Reservations by resource barcode

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Change name of Manage Reservations

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

just trying out syntax for pcrud

fixing issue

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

limit by resource barcode

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

fixing path

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

updating navbar

improving routes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

changing let to const

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

adding missing semicolon

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

updating module name

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Rename Current Reservations to Manage Reservations

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding datePlusTime to timestamp columns

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding a confirm dialog for canceling

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding links from other interfaces

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding action -- not working yet

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

fixing closing tag

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding grid setting to db

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

refining fmeditor

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding a cancel action

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding an editor

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

add note field

Adding columns

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding a working, sortable grid to current reservations

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding basic pull list

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding a booking module

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1808268 eg2 grid action disableOnRows sanity check

The === null test for determining if a disableOnRows handler was set was
not broad enough to capture undefined values.  This commit changes it to
a more generic if() test to cover null/undefined.  Also, instead of
creating a dummy function in the action, the testing code checks for the
presence of the function at run time.

Apply a fix to an ng-lint warning introduced by this series of commits in
the sandbox code.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1808268 eg2 grid rename action disable option

Rename the "disabled" attribute on toolbar-action to "disabeOnRows" to
better clarify the expected input value: function returning bool instead
of bool variable.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1808268: Add [disable] option to <eg-grid-toolbar-action> in eg2

To test:
1) Apply this commit and recompile eg2.
2) Open the eg2 sandbox (https://yourdomain/eg2/staff/sandbox)
3) Ensure that the action called "Action that needs a single row"
is only enabled when one row of the grid is selected.
4) Create more <eg-grid-toolbar-actions> on grids in eg2.  Make sure
that they all enable/disable those actions per the output of the
functions you reference in the [disabled] attribute.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

fixing typo

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

fixing typo

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

adding toast to successful cancelation

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

fixing columns in create reservation grid

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

adding a basic grid to create

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding a super-basic Create Reservation screen

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

make sure finished reservations are not in manage reservations

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

don't show canceled reservations

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

correcting grid refresh action

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Add Show Reservations for Resources

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Fix limit Manage Reservations by resource barcode

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Change name of Manage Reservations

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Forward-port 3.2.3 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward-port 3.1.9 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1727345 - fix bibsource when importing or overlaying

This addresses several issues that were causing the
bib source to either not display correctly on the record page
or not save correctly when editing z3950 imports/overlays
Refactors passing around of bib source into eg-marc-edit and it's
child directive egMarcEditBibsource.

Two paths to test:
Path A)
    1. Import a new bib record from z3950, but via "Edit then Import"
    2. Bring up marc editor and choose save w/ bib source.
    3. Verify chosen bib source saved correctly on record page.
Path B)
    1. Mark a record as target for Overlay, go to z3950 import.
    2. Make a search, select item for Overlay.
    3. Choose Edit z3950 record to bring up marceditor, save with a bib source.
    4. Verify chosen bib source saved correctly on record page.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1812698 - stamping upgrade script

Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1812698 - Fix broken pubdate display

reporter.simple_record, which is now used more
extensively for bib display, had a copy-paste error
originating in 2014 that now gets corrected.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

just trying out syntax for pcrud

fixing issue

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

limit by resource barcode

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

fixing path

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

updating navbar

improving routes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

changing let to const

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

adding missing semicolon

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

updating module name

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Rename Current Reservations to Manage Reservations

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding datePlusTime to timestamp columns

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding a confirm dialog for canceling

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding links from other interfaces

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding action -- not working yet

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

fixing closing tag

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding grid setting to db

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

refining fmeditor

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding a cancel action

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding an editor

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

add note field

Adding columns

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding a working, sortable grid to current reservations

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding basic pull list

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Adding a booking module

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1807764 Angular grid gets datePlusTime option

Adds a new boolean datePlusTime option to the Angular grid column
configuration, informing the grid to display both date and time in the
cell for a datetype=timestamp column.

Includes sandbox example.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding one more note to 3.2.3 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1805856: Open new windows for record operations

This branch changes the call from $window.location.open
to match other others ($window.open). Testing the 2 z39.50
changes worked as expected!

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1805856: Open records in new tabs

Catalogers have given the feedback that it's very helpful to have
certain records open in a new tab after they perform certain tasks.

This commit opens the relevant records in a new tab in the following
circumstances:
1) Cataloging > Z39.50 > Import > Go to record (previously opened in the
existing tab)
2) Cataloging > Z39.50 > Overlay > Overlay (previously did not open the
overlaid record at all)
3) Cataloging > Record Buckets > Merge (previously opened the lead
record in the existing tab)

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Boyer <JBoyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: adding release notes for 3.2.3

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding 3.1.9 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1742521: Receipt Count Repair

The div wrapping the receipt printing controls was
shown or hidden using an ng-if declaration which
created a new $scope as explained in bug 1696238,
which caused the controller to not notice that the
value was changed. Changing that to an ng-show
allows the updated value to get where it needs to
be.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1804716: grab recall-able copies before they are filtered out

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

Lp 1803734: Only push on-order purchase orders in edi_order_pusher.pl.

Add a check for the state of purchase orders being on-order when
gathering them in edi_order_pusher.pl.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Lp 1801998: Deprecate Hatch Storage Grammar Fix

Make a minor fix to punctuation in a newly added message.

Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1801998 Deprecate Hatch for data storage

Add a deprecation warning to the Hatch configuration page notifying
users that Hatch for storage is deprecated.  Includes suggestions on how
to migrate away from Hatch for storage.

Remove the unusued "Use Hatch for Offline Files" option.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1737800 - add delete action to pending patrons

This adds a way to remove a pending/staged user from
the pending users grid.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1810802 org_top() SQL upgrade repairs

1. Drop the org_top function before recreating it since the return type
changes.

2. Fis syntax error in "COMMIT:"

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1765179 - fix issue with pending/staged user reg

After completing a staged user registration, the controller
in regctl.js was refreshing to the same route, and
trying to fetch the same staged user, but never finding it
as it was no longer staged/pending. This addresses that bug
and adds a bChannel refresh to the pending grid, so once
the user is registered in the child tab, it closes the tab and
the pending user grid is updated.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

docs: LP1258628: screenshots & updates to actiontriggers.adoc

Added a handful of screenshots; added language for Message Center definitions, and pulled in language about testing action triggers from this document: http://docs.evergreen-ils.org/dev/_creating_action_triggers.html

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1782652: Make template dropdown larger in Volume/Copy Editor

To test:
1) Open an item in the volume/copy editor.
2) Go to the Copy Templates tab. Note the spacing of the template bar.
3) Create a few templates.  Give them names of 30 characters or more.
4) Go back to the Edit tab and select one of your new templates.  Note
that after you have selected it, the name of your template does not fit
in the dropdown box, and is cut off at the end.
5) Apply this commit.
6) Go to the Copy Templates tab again.  Note that the spacing of the
template bar has not changed.
7) Go to the Edit tab.  Note that the template dropdown has changed
to be much larger.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Janet Schrader <jschrader@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1806968 Stamping SQL upgrade: Vand. session tracker fixes

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806968 Teach Vandelay to pass correct auth tracker type

Pass the correct value ('authority') when creating a Vandelay session
tracker entry for authority records.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>