From 06c81b580245572527e12072f1d40fdfe7e74cde Mon Sep 17 00:00:00 2001 From: Lebbeous Fogle-Weekley Date: Thu, 26 Jul 2012 16:45:24 -0400 Subject: [PATCH] Trying to update patron CSS color fails here, so don't try After modifying user standing penalties ("messages" in the staff client patron interface), you could get this error message in an alert() dialog: TypeError: patron.display is undefined. We were apparently trying to use patron.util.set_patron_css() wrongly, so the commented out changed verison of the call got farther, but stopped at ...penalties[i].standing_penalty().name is not a function. Which probably has something to do with unfleshed data. Somebody can get to the bottom of this if they want, but for now it's easier just not to try to do this and make the alert() dialog go away. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Bill Erickson --- Open-ILS/xul/staff_client/server/patron/standing_penalties.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Open-ILS/xul/staff_client/server/patron/standing_penalties.js b/Open-ILS/xul/staff_client/server/patron/standing_penalties.js index ce62e22335..d36edf4476 100644 --- a/Open-ILS/xul/staff_client/server/patron/standing_penalties.js +++ b/Open-ILS/xul/staff_client/server/patron/standing_penalties.js @@ -226,7 +226,7 @@ function handle_remove_penalty(ev) { */ document.getElementById('progress').hidden = true; - patron.util.set_penalty_css(xulG.patron, patron.display.w.document.documentElement); + //patron.util.set_penalty_css(xulG.patron); } ); document.getElementById('progress').hidden = false; @@ -311,7 +311,7 @@ function handle_edit_penalty(ev) { row_params.row.my.csp = p.standing_penalty(); list.refresh_row( row_params ); - patron.util.set_penalty_css(xulG.patron, patron.display.w.document.documentElement); + //patron.util.set_penalty_css(xulG.patron); document.getElementById('progress').hidden = true; } catch(E) { alert(E); @@ -375,7 +375,7 @@ function handle_archive_penalty(ev) { if (--outstanding_requests==0) { document.getElementById('progress').hidden = true; - patron.util.set_penalty_css(xulG.patron, patron.display.w.document.documentElement); + //patron.util.set_penalty_css(xulG.patron); } } }(ids[i]) -- 2.11.0