From 090500fdd85ae14a29818d243048162dfc42d4bd Mon Sep 17 00:00:00 2001 From: Jason Stephenson Date: Thu, 9 Feb 2023 11:22:58 -0500 Subject: [PATCH] LP#2006749: Fix call to ou_ancestor_setting_perm_check in AppUtils.pm The $self and $e arguments are missing when the ou_ancestor_setting subroutine calls ou_ancestor_setting_perm_check in AppUtils. The $coust argument also need to be $coust->view_perm->code for the allowed check in ou_ancestor_setting_perm_check. This commit corrects the call to ou_ancestor_setting_perm_check. Signed-off-by: Jason Stephenson Signed-off-by: Chris Sharp Signed-off-by: Galen Charlton --- Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm index 3c323775ba..441d0c0da9 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm @@ -1318,7 +1318,7 @@ sub ou_ancestor_setting { my $coust = $e->retrieve_config_org_unit_setting_type([ $name, {flesh => 1, flesh_fields => {coust => ['view_perm']}} ]); - return undef unless ou_ancestor_setting_perm_check($orgid, $coust, $auth) + return undef unless $self->ou_ancestor_setting_perm_check($orgid, $coust->view_perm->code, $e, $auth) } my $query = {from => ['actor.org_unit_ancestor_setting', $name, $orgid]}; -- 2.11.0