From 0e9f29730a5777630e11fcffee752c75c215533f Mon Sep 17 00:00:00 2001
From: Kathy Lussier <klussier@masslnc.org>
Date: Tue, 25 Jul 2017 10:23:20 -0400
Subject: [PATCH] LP#1706365: cursor for record menu items should be a pointer

When using the Mark For or Other Actions menus on the bib record page, the
cursor becomes an i-beam while hovering over the menu items instead of the
expected pointer. This commit adds an empty href attribute to the a tag for menu
items so that a pointer displays instead.

Test plan:
Log into the web client and retrieve a record. Click the 'Mark For' menu on the
record page. Pre-patch, as you scroll through the menu items, the cursor will
turn into an i-beam, indicating that text can be selected. Post-patch, the
cursor will be the expected pointer that typically displays for links.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
---
 Open-ILS/src/templates/staff/cat/catalog/t_catalog.tt2 | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/Open-ILS/src/templates/staff/cat/catalog/t_catalog.tt2 b/Open-ILS/src/templates/staff/cat/catalog/t_catalog.tt2
index 51357faf9c..bcb52df856 100644
--- a/Open-ILS/src/templates/staff/cat/catalog/t_catalog.tt2
+++ b/Open-ILS/src/templates/staff/cat/catalog/t_catalog.tt2
@@ -32,31 +32,31 @@
         </button>
         <ul uib-dropdown-menu role="menu" aria-labelledby="mark-for-button">
              <li role="menuitem">
-                    <a ng-click="markConjoined()">
+                    <a ng-click="markConjoined()" href="">
                         [% l('Conjoined Items') %]
                     <span class="target-record-aside" ng-if="current_conjoined_target">[% l('(Currently [_1])', '{{current_conjoined_target}}') %]</span>
                 </a>
             </li>
            <li role="menuitem">
-                <a ng-click="markOverlay()">
+                <a ng-click="markOverlay()" href="">
                     [% l('Overlay Target') %]
                     <span class="target-record-aside" ng-if="current_overlay_target">[% l('(Currently [_1])', '{{current_overlay_target}}') %]</span>
                 </a>
             </li>
             <li role="menuitem">
-                <a ng-click="mark_hold_transfer_dest()">
+                <a ng-click="mark_hold_transfer_dest()" href="">
                    [% l('Title Hold Transfer') %]
                 <span class="target-record-aside" ng-if="current_hold_transfer_dest">[% l('(Currently [_1])', '{{current_hold_transfer_dest}}') %]</span>
                 </a>
             </li>
             <li role="menuitem">
-                <a ng-click="markVolTransfer()">
+                <a ng-click="markVolTransfer()" href="">
                     [% l('Volume Transfer') %]
                     <span class="target-record-aside" ng-if="current_voltransfer_target">[% l('(Currently [_1])', '{{current_voltransfer_target}}') %]</span>
                 </a>
             </li>
             <li role="menuitem">
-                <a ng-click="clearRecordMarks()">[% l('Reset Record Marks') %]</a>
+                <a ng-click="clearRecordMarks()" href="">[% l('Reset Record Marks') %]</a>
             </li>
         </ul>
     </div>
@@ -66,12 +66,12 @@
         </button>
         <ul uib-dropdown-menu role="menu" aria-labelledby="other-actions-button">
              <li role="menuitem">
-                    <a ng-click="add_to_record_bucket()">
+                    <a ng-click="add_to_record_bucket()" href="">
                         [% l('Add To Bucket') %]
                     </a>
             </li>
             <li role="menuitem">
-                   <a ng-click="view_place_orders()">
+                   <a ng-click="view_place_orders()" href="">
                         [% l('View/Place Orders') %]
                    </a>
             </li>
-- 
2.11.0