From 104dab70e416b98a4bb136d66302ac5590fdaf9b Mon Sep 17 00:00:00 2001
From: miker <miker@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Sun, 21 Mar 2010 20:02:29 +0000
Subject: [PATCH] remove OFFSET/LIMIT -- do that inside the stored proc for hit
 estimation; simplify phrase restriction logic

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15923 dcc99617-32d9-48b4-a31d-7c20da2025e4
---
 .../Application/Storage/Driver/Pg/QueryParser.pm     | 20 ++++----------------
 1 file changed, 4 insertions(+), 16 deletions(-)

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm b/Open-ILS/src/perlmods/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm
index 8cfe87606..b956eae93 100644
--- a/Open-ILS/src/perlmods/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm
@@ -406,14 +406,6 @@ sub toSQL {
     my $key = 'm.source';
     $key = 'm.metarecord' if (grep {$_->name eq 'metarecord'} @{$self->modifiers});
 
-    my $sp_size = $self->QueryParser->superpage_size || 1000;
-    my $sp = $self->QueryParser->superpage || 1;
-
-    my $offset = '';
-    if ($sp > 1) {
-        $offset = 'OFFSET ' . ($sp - 1) * $sp_size;
-    }
-
     my ($before) = $self->find_filter('before');
     my ($after) = $self->find_filter('after');
     my ($during) = $self->find_filter('during');
@@ -466,9 +458,7 @@ SELECT  $key AS id,
         $bib_level
         AND $$flat_plan{where}
   GROUP BY 1
-  ORDER BY 4 $desc, 5 DESC
-  LIMIT $sp_size
-  $offset
+  ORDER BY 4 $desc, 5 DESC, 3 DESC
 SQL
 
 }
@@ -545,11 +535,9 @@ sub flatten {
                 $from .= "\n\t\tLIMIT $core_limit\n\t) AS $talias ON (m.source = $talias.source)";
                 $from .= "\n\tJOIN config.metabib_field AS ${talias}_weight ON (${talias}_weight.id = $talias.field)\n";
 
-                $where .= $talias . ".id IS NOT NULL ";
-                my $phrases = $node->phrases;
-                if (@$phrases) {
-                    $where .= ' AND (' . join(' AND ', map {"$talias.value ~ \$_$$\$$_\$_$$\$"} @$phrases) . ')';;
-                }
+                $where .= '(' . $talias . ".id IS NOT NULL";
+                $where .= ' AND ' . join(' AND ', map {"$talias.value ~* \$_$$\$$_\$_$$\$"} @{$node->phrases}) if (@{$node->phrases});
+                $where .= ')';
 
                 push @rank_list, $node_rank;
 
-- 
2.11.0