From 113554e494eb2a65d0c8dc6ef4289254ff6b7221 Mon Sep 17 00:00:00 2001 From: Jason Stephenson Date: Fri, 13 May 2011 09:06:32 -0400 Subject: [PATCH] Fix stylistic nits pointed out by Mike Rylander. Signed-off-by: Jason Stephenson --- .../src/perlmods/lib/OpenILS/SIP/Transaction/FeePayment.pm | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Transaction/FeePayment.pm b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Transaction/FeePayment.pm index 03894e6703..85da0cdee7 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Transaction/FeePayment.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Transaction/FeePayment.pm @@ -32,9 +32,7 @@ sub new { my $self = $class->SUPER::new(@_); - my $element; - - foreach $element (keys %fields) { + foreach my $element (keys %fields) { $self->{_permitted}->{$element} = $fields{$element}; } @@ -47,9 +45,8 @@ sub do_fee_payment { my $results = $U->simplereq('open-ils.actor', 'open-ils.actor.user.transactions.history.have_balance', $self->{authtoken}, $self->patron->internal_id); if (ref $results eq 'ARRAY') { syslog('LOG_INFO', scalar @$results . " bills found for " . $self->patron->internal_id); - my $bill; my $payment = $self->fee_amount; - foreach $bill (@{$results}) { + foreach my $bill (@{$results}) { syslog('LOG_INFO', 'bill '. $bill->id . ' amount ' . $bill->balance_owed); if (!$self->transaction_id) { if ($bill->balance_owed >= $payment) { @@ -87,8 +84,7 @@ sub do_fee_payment { } } -sub pay_bill -{ +sub pay_bill { my ($self, $bill, $amount) = @_; my $user = $self->patron->{user}; my $r = $U->simplereq('open-ils.circ', 'open-ils.circ.money.payment', $self->{authtoken}, -- 2.11.0