From 114cdc31b422f044d1e2d478a56a502d148b27d7 Mon Sep 17 00:00:00 2001 From: Dan Allen Date: Tue, 22 Dec 2020 02:25:04 -0700 Subject: [PATCH] pass radix to parseInt function (to avoid unnecessary checks and unwanted side effects) --- src/js/02-on-this-page.js | 4 ++-- src/js/05-mobile-navbar.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/js/02-on-this-page.js b/src/js/02-on-this-page.js index 0bf7320..035bea4 100644 --- a/src/js/02-on-this-page.js +++ b/src/js/02-on-this-page.js @@ -4,7 +4,7 @@ var sidebar = document.querySelector('aside.toc.sidebar') if (!sidebar) return if (document.querySelector('body.-toc')) return sidebar.parentNode.removeChild(sidebar) - var levels = parseInt(sidebar.dataset.levels || 2) + var levels = parseInt(sidebar.dataset.levels || 2, 10) if (levels < 0) return var articleSelector = 'article.doc' @@ -30,7 +30,7 @@ link.textContent = heading.textContent links[(link.href = '#' + heading.id)] = link var listItem = document.createElement('li') - listItem.dataset.level = parseInt(heading.nodeName.slice(1)) - 1 + listItem.dataset.level = parseInt(heading.nodeName.slice(1), 10) - 1 listItem.appendChild(link) accum.appendChild(listItem) return accum diff --git a/src/js/05-mobile-navbar.js b/src/js/05-mobile-navbar.js index b718738..892d0e7 100644 --- a/src/js/05-mobile-navbar.js +++ b/src/js/05-mobile-navbar.js @@ -13,7 +13,7 @@ if (menu.classList.toggle('is-active')) { menu.style.maxHeight = '' var expectedMaxHeight = window.innerHeight - Math.round(menu.getBoundingClientRect().top) - var actualMaxHeight = parseInt(window.getComputedStyle(menu).maxHeight) + var actualMaxHeight = parseInt(window.getComputedStyle(menu).maxHeight, 10) if (actualMaxHeight !== expectedMaxHeight) menu.style.maxHeight = expectedMaxHeight + 'px' } } -- 2.11.0