From 1445fdd093a3f77c0a14b94b39bd9e7714578978 Mon Sep 17 00:00:00 2001 From: Dan Scott Date: Mon, 12 Dec 2016 16:13:00 -0500 Subject: [PATCH] LP#1594937 Fix off-by-one display of closed dates The switch to toISOString() to format dates introduced an off-by-one error in the closed dates display, showing one extra day of closure due to the timezone being ignored in toISOString(). toLocaleDateString() is the future of locale-sensitive date formats. In XUL, because it is an old version of Firefox, it lacks locale sensitivity, but for the purposes of the web staff client it's a good base to build on as even Internet Explorer supports the locale and options arguments as of IE 11. And for the immediate purposes of showing the right dates in the closed dates editor, it works. Signed-off-by: Dan Scott Signed-off-by: Chris Sharp --- Open-ILS/xul/staff_client/server/admin/closed_dates.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/xul/staff_client/server/admin/closed_dates.js b/Open-ILS/xul/staff_client/server/admin/closed_dates.js index 50d74c2832..68dbe84b7b 100644 --- a/Open-ILS/xul/staff_client/server/admin/closed_dates.js +++ b/Open-ILS/xul/staff_client/server/admin/closed_dates.js @@ -174,7 +174,7 @@ function cdDateToHours(date) { function cdDateToDate(date) { var date_obj = new Date(Date.parse(date)); - return date_obj.toISOString().replace(/T.*/,''); // == %F + return date_obj.toLocaleDateString(); } -- 2.11.0