From 171991601db37cf27e4b9515b06fdf1a80fcf929 Mon Sep 17 00:00:00 2001
From: kenstir <kenstir@gmail.com>
Date: Sat, 28 Dec 2013 11:07:00 -0500
Subject: [PATCH] attempt to fix crash seen once in dialog.dismiss()

---
 .../checkout/ItemsCheckOutListView.java            | 29 ++++++++--------------
 1 file changed, 11 insertions(+), 18 deletions(-)

diff --git a/Open-ILS/src/Android/core/src/org/evergreen/android/accountAccess/checkout/ItemsCheckOutListView.java b/Open-ILS/src/Android/core/src/org/evergreen/android/accountAccess/checkout/ItemsCheckOutListView.java
index 47f76a22d4..d4e74b10fc 100644
--- a/Open-ILS/src/Android/core/src/org/evergreen/android/accountAccess/checkout/ItemsCheckOutListView.java
+++ b/Open-ILS/src/Android/core/src/org/evergreen/android/accountAccess/checkout/ItemsCheckOutListView.java
@@ -154,16 +154,13 @@ public class ItemsCheckOutListView extends Activity {
 
                         itemsNo.setText(" " + circRecords.size() + " ");
 
-                        int overdueNo = 0;
                         // find overdue items
-
+                        int overdueNo = 0;
                         for (int i = 0; i < circRecords.size(); i++) {
                             CircRecord circ = circRecords.get(i);
-
                             if (circ.getDueDateObject().compareTo(currentDate) < 0)
                                 overdueNo++;
                         }
-
                         overdueItems.setText(" " + overdueNo);
 
                         progressDialog.dismiss();
@@ -178,17 +175,15 @@ public class ItemsCheckOutListView extends Activity {
             }
         });
 
-        if (accountAccess.isAuthenticated()) {
-            progressDialog = new ProgressDialog(context);
-            progressDialog.setMessage("Retrieving circulation data");
-            progressDialog.show();
-            getCirc.start();
-
-        } else
-            Toast.makeText(context,
-                    "You must be authenticated to retrieve circulation records",
-                    Toast.LENGTH_LONG);
+        progressDialog = new ProgressDialog(context);
+        progressDialog.setMessage("Retrieving circulation data");
+        progressDialog.show();
+        getCirc.start();
+    }
 
+    private void dismissProgress() {
+        if (progressDialog != null && progressDialog.isShowing())
+            progressDialog.dismiss();
     }
 
     @Override
@@ -278,10 +273,8 @@ public class ItemsCheckOutListView extends Activity {
                             runOnUiThread(new Runnable() {
                                 @Override
                                 public void run() {
-                                    progressDialog = new ProgressDialog(
-                                            context);
-                                    progressDialog
-                                            .setMessage("Renewing item");
+                                    progressDialog = new ProgressDialog(context);
+                                    progressDialog.setMessage("Renewing item");
                                     progressDialog.show();
                                 }
                             });
-- 
2.11.0