From 17ae1c63b186cbd41c869f1b3a14076fe63627fc Mon Sep 17 00:00:00 2001
From: Bill Erickson <berick@esilibrary.com>
Date: Tue, 18 Jan 2011 11:48:11 -0500
Subject: [PATCH] make better use of media_prefix; only apply ses cookie in
 secure context; updated docs

---
 Open-ILS/examples/oils_web.xml.example           | 20 ++++++++++++++++++--
 Open-ILS/src/perlmods/OpenILS/WWW/EGCatLoader.pm |  1 +
 Open-ILS/src/perlmods/lib/OpenILS/WWW/EGWeb.pm   |  8 ++++++++
 Open-ILS/web/templates/default/opac/rdetail.tt2  |  4 +++-
 Open-ILS/web/templates/default/opac/results.tt2  |  2 +-
 5 files changed, 31 insertions(+), 4 deletions(-)

diff --git a/Open-ILS/examples/oils_web.xml.example b/Open-ILS/examples/oils_web.xml.example
index c5d36220a6..e5f0efbe2b 100644
--- a/Open-ILS/examples/oils_web.xml.example
+++ b/Open-ILS/examples/oils_web.xml.example
@@ -9,8 +9,24 @@
         files have the following filename extension -->
     <default_template_extension>tt2</default_template_extension>
 
-    <!-- media_prefix can be a remote server.  
-         E.g. <media_prefix>http://static.example.com/media</media_prefix> -->
+    <!-- Media Prefix.  Allows static files to be served from an alternate domain/server
+
+            Examples:
+
+                # local URL path
+                <media_prefix>/media</media_prefix> 
+
+                # server w/ path.  
+                <media_prefix>static.example.com/media</media_prefix> 
+
+                ===
+                In the first 2 examples, the request protocol (http vs https) will
+                match the protocol of the current page
+                ===
+
+                # full-qualified with static protocol
+                <media_prefix>http://static.example.com/media</media_prefix> 
+     -->
     <media_prefix/>
 
     <!-- If set to true, all output will be parsed as XML before delivery to the client.  
diff --git a/Open-ILS/src/perlmods/OpenILS/WWW/EGCatLoader.pm b/Open-ILS/src/perlmods/OpenILS/WWW/EGCatLoader.pm
index 18afc95cb9..634797d690 100644
--- a/Open-ILS/src/perlmods/OpenILS/WWW/EGCatLoader.pm
+++ b/Open-ILS/src/perlmods/OpenILS/WWW/EGCatLoader.pm
@@ -187,6 +187,7 @@ sub load_login {
             -cookie => $cgi->cookie(
                 -name => 'ses',
                 -path => '/',
+                -secure => 1,
                 -value => $response->{payload}->{authtoken},
                 -expires => CORE::time + $response->{payload}->{authtime}
             )
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGWeb.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGWeb.pm
index 4ddcb86ad2..c51700443c 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGWeb.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGWeb.pm
@@ -120,6 +120,14 @@ sub load_context {
         parse_accept_lang($r->headers_in->get('Accept-Language')) || 'en-US';
     $r->log->debug('skin = ' . $ctx->{skin} . ' : theme = ' . 
         $ctx->{theme} . ' : locale = ' . $ctx->{locale});
+
+    my $mprefix = $ctx->{media_prefix};
+    if($mprefix !~ /^http/ and $mprefix !~ /^\//) {
+        # if a hostname is provided /w no protocol, match the protocol to the current page
+        $ctx->{media_prefix} = ($cgi->https) ? "https://$mprefix" : "http://$mprefix";
+    }
+
+
     return $ctx;
 }
 
diff --git a/Open-ILS/web/templates/default/opac/rdetail.tt2 b/Open-ILS/web/templates/default/opac/rdetail.tt2
index a4966fd24b..f32bd49768 100644
--- a/Open-ILS/web/templates/default/opac/rdetail.tt2
+++ b/Open-ILS/web/templates/default/opac/rdetail.tt2
@@ -22,7 +22,9 @@
     <table id='record_table' style='width:auto'>
         <tr>
             <td rowspan='10' style='width:55px; vertical-align:top; padding-right:4px;'>
-                <img width='50' height='70' src='/opac/extras/ac/jacket/small/[% attrs.isbn_clean || attrs.upc %]'/>
+                [% IF attrs.isbn_clean || attrs.upc %]
+                <img width='50' height='70' src='[% ctx.media_prefix %]/opac/extras/ac/jacket/small/[% attrs.isbn_clean || attrs.upc %]'/>
+                [% END %]
             </td>
         </tr>
         [% IF attrs.title %]<tr><td>Title</td><td>[% attrs.title %]</td></tr>[% END %]
diff --git a/Open-ILS/web/templates/default/opac/results.tt2 b/Open-ILS/web/templates/default/opac/results.tt2
index 8704eeb6d3..f862973dcc 100644
--- a/Open-ILS/web/templates/default/opac/results.tt2
+++ b/Open-ILS/web/templates/default/opac/results.tt2
@@ -81,7 +81,7 @@
                 <tr>
                     <td style='width:52px;height:72px'>
                         [% IF attrs.isbn %]
-                        <img width='50' height='70' src='/opac/extras/ac/jacket/small/[% attrs.isbn_clean || attrs.upc %]'/>
+                        <img width='50' height='70' src='[% ctx.media_prefix %]/opac/extras/ac/jacket/small/[% attrs.isbn_clean || attrs.upc %]'/>
                         [% END %]
                     </td>
                     <td width='auto'>
-- 
2.11.0