From 19356163431ad8f79e66e0ea7150768da3ff98d0 Mon Sep 17 00:00:00 2001
From: Dan Briem <dbriem@wlsmail.org>
Date: Wed, 18 Nov 2020 16:50:06 -0500
Subject: [PATCH] LP#1778522 Precat item creation should be more intentional

Precat items can be created before all of the info is entered.
The dialog autofocuses the title field, so a double barcode scan
will populate the title field and createt the precat without
giving an opportunity to fill in the other fields.

This prevents form submission unless you click the Precat
Checkout button.

To test:
1. Try to check out a barcode that doesn't exist to any patron
2. On the precat dialog, enter a value into the title field
3. Note the precat is created
4. Apply patch
5. Repeat steps 1-3 and note the precat isn't created until
   the Precat Checkout button is clicked

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
---
 Open-ILS/src/templates/staff/circ/share/t_precat_dialog.tt2 | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Open-ILS/src/templates/staff/circ/share/t_precat_dialog.tt2 b/Open-ILS/src/templates/staff/circ/share/t_precat_dialog.tt2
index e505496cf7..06bf6dacb4 100644
--- a/Open-ILS/src/templates/staff/circ/share/t_precat_dialog.tt2
+++ b/Open-ILS/src/templates/staff/circ/share/t_precat_dialog.tt2
@@ -30,8 +30,7 @@
           <label for="precat-isbn">[% l('Call Number') %]</label>
           <input type="text" class="form-control" id="precat-isbn"
             ng-disabled="!can_create_precats"
-            ng-keydown="preventSubmit($event)"
-            ng-model="precatArgs.dummy_isbn" placeholder="[% l('Call Number...') %]"/>
+            ng-model="precatArgs.dummy_isbn" placeholder="[% l('ISBN...') %]"/>
         </div>
         <div class="form-group">
           <label for="precat-circmod">[% l('Circulation Modifier') %]</label>
-- 
2.11.0